[PATCH 0/2] Use proper printk format in appletbdrm

2025-03-12 Thread Aditya Garg
The vsprint patch was originally being sent as a seperate patch [1], and I was waiting it to be taken up. But since 6.15 merge window is near, a potential delay between the drm and vsprintf patch might make the vsprint patch as an unused addition in 6.15. So, I am sending it together. From what I h

Re: [PATCH v3 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

2025-03-12 Thread Krzysztof Kozlowski
On Tue, Mar 11, 2025 at 07:05:31PM -0300, Maíra Canal wrote: > > > +reg-names: > > > + items: > > > +- const: hub > > > +- const: core0 > > > +- const: sms > > > +- const: bridge > > > > This is an ABI change because previously the 3

[PATCH] drm/bridge: anx7625: Remove redundant 'flush_workqueue()' calls

2025-03-12 Thread Chen Ni
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni --- dri

[PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

2025-03-12 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/apple

[PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte or

Re: [PATCH] drm/sti: remove duplicate object names

2025-03-12 Thread Rolf Eike Beer
On Donnerstag, 16. Januar 2025 09:33:18 Mitteleuropäische Normalzeit Dmitry Baryshkov wrote: > On Wed, Jan 15, 2025 at 09:58:59AM +0100, Rolf Eike Beer wrote: > > When merging 2 drivers common object files were not deduplicated. > > > > Fixes: dcec16efd677 ("drm/sti: Build monolithic driver") > >

[PATCH] drm/rockchip: vop2: Fix interface enable/mux setting of DP1 on rk3588

2025-03-12 Thread Andy Yan
From: Andy Yan This is a copy-paste error, which affects DP1 usage. Fixes: 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: add h/vsync-disable support

2025-03-12 Thread Zini, Alessandro
On Fri, 2025-03-07 at 08:05 +0200, Dmitry Baryshkov wrote: > On Thu, Mar 06, 2025 at 10:11:33AM +0100, A. Zini wrote: > > From: Alessandro Zini > > > > The h/vsync-disable properties are used to control whether to use or > > not h/vsync signals, by configuring their pulse width to zero. > > > >

Re: [PATCH v7 1/7] drm: Move some options to separate new Kconfig

2025-03-12 Thread Philipp Stanner
+Cc Dave, Sima (get_maintainer?) On Tue, 2025-03-11 at 09:23 +, Tvrtko Ursulin wrote: > Move some options out into a new debug specific kconfig file in order > to > make things a bit cleaner. > > Signed-off-by: Tvrtko Ursulin Would be nice to get an ACK / RB from the DRM maintainers since t

Re: [PATCH] drm/rockchip: vop2: Fix interface enable/mux setting of DP1 on rk3588

2025-03-12 Thread Piotr Oniszczuk
> Wiadomość napisana przez Andy Yan w dniu 12 mar 2025, o > godz. 07:42: > > copy-paste error, which affects DP1 usage Andy, Great finding. Now i see nice screen on rock5itx on dpi1 out :-) With this: my users are politely asking: when we wili have audio (and cec) support on dpi1?

Re: [PATCH] drm/amd/display: Remove incorrect macro guard

2025-03-12 Thread Christian König
Am 11.03.25 um 18:10 schrieb Alex Hung: > This macro guard "__cplusplus" is unnecessary and should not be there. > > Signed-off-by: Alex Hung > --- > drivers/gpu/drm/amd/display/dc/sspl/dc_spl.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/sspl/dc_spl.

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-12 Thread Christian König
Am 11.03.25 um 18:13 schrieb Raag Jadav: > On Mon, Mar 10, 2025 at 06:03:27PM -0400, Alex Deucher wrote: >> On Mon, Mar 10, 2025 at 5:54 PM André Almeida wrote: >>> Em 01/03/2025 03:04, Raag Jadav escreveu: On Fri, Feb 28, 2025 at 06:49:43PM -0300, André Almeida wrote: > Hi Raag, > >>

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-12 Thread Raag Jadav
On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: > On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > > Em 01/03/2025 02:53, Raag Jadav escreveu: > > > On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > > > > Hi Raag, > > > > > > > > On 2/28/25 11:20, Raag Ja

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread kernel test robot
ixiong1025%40163.com patch subject: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group config: sparc-randconfig-001-20250312 (https://download.01.org/0day-ci/archive/20250312/202503121852.0x6j0c7a-...@intel.com/config) compiler: sparc64-linux-gcc (GCC) 14.2.0 reproduce (this is a

Re: [PATCH v7 0/7] DRM scheduler kunit tests

2025-03-12 Thread Philipp Stanner
On Tue, 2025-03-11 at 09:23 +, Tvrtko Ursulin wrote: > There has repeatedly been quite a bit of apprehension when any change > to the DRM > scheduler is proposed, with two main reasons being code base is > considered > fragile, not well understood and not very well documented, and > secondly th

[PATCH v2 1/7] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-03-12 Thread Andy Yan
From: Andy Yan The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX controller. And this DPTX controller need share a USBDP PHY with the USB 3.0 OTG controller during operation. Signed-off-by: Andy Yan Reviewed-by: Rob Herring (Arm) --- Changes in v2: - Link to V1: https://lore.k

[PATCH v2 5/7] arm64: dts: rockchip: Add DP1 for rk3588

2025-03-12 Thread Andy Yan
From: Andy Yan The DP1 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY1 with USB 3.1 HOST1 controller. Signed-off-by: Andy Yan --- (no changes since v1) .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ 1 file changed, 30 inser

[PATCH v2 0/7] Add support for RK3588 DisplayPort Controller

2025-03-12 Thread Andy Yan
From: Andy Yan There are two DW DPTX based DisplayPort Controller on rk3588 which are compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps

[PATCH v2 3/7] drm/rockchip: Add RK3588 DPTX output support

2025-03-12 Thread Andy Yan
From: Andy Yan Add driver extension for Synopsys DesignWare DPTX IP used on Rockchip RK3588 SoC. Signed-off-by: Andy Yan --- Changes in v2: - no include uapi path - switch to drmm_encoder_init drivers/gpu/drm/rockchip/Kconfig| 7 + drivers/gpu/drm/rockchip/Makefile |

[PATCH v2 4/7] arm64: dts: rockchip: Add DP0 for rk3588

2025-03-12 Thread Andy Yan
From: Andy Yan The DP0 is compliant with the DisplayPort Specification Version 1.4, and share the USBDP combo PHY0 with USB 3.1 HOST0 controller. Signed-off-by: Andy Yan --- (no changes since v1) arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 30 +++ 1 file changed, 30 inser

[PATCH v2 7/7] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-03-12 Thread Andy Yan
From: Andy Yan The HDMI Port next to Headphone Jack is drived by DP1 on rk3588 via a dp2hdmi converter. Add related dt nodes to enable it. Note: ROCKCHIP_VOP2_EP_DP1 is defined as 11 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "b"" if we

[PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-12 Thread Andy Yan
From: Andy Yan The DW DP TX Controller is compliant with the DisplayPort Specification Version 1.4 with the following features: * DisplayPort 1.4a * Main Link: 1/2/4 lanes * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps * AUX channel 1Mbps * Single Stream Transport(SST) * Multistream

[PATCH v2 6/7] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-03-12 Thread Andy Yan
From: Andy Yan Enable the Mini DisplayPort on this board. Note that ROCKCHIP_VOP2_EP_DP0 is defined as 10 in dt-binding header, but it will trigger a dtc warning like "graph node unit address error, expected "a"" if we use it directly after endpoint, so we use "a" instead here. Signed-off-by: An

Re: [PATCH v3 0/7] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

2025-03-12 Thread Raag Jadav
On Tue, Mar 11, 2025 at 03:13:42PM -0300, Maíra Canal wrote: > This series addresses GPU reset issues reported in [1], where running a > long compute job would trigger repeated GPU resets, leading to a UI > freeze. > > Patches #1 and #2 prevent the same faulty job from being resubmitted in a > loo

Re: [PATCH 0/2] Add POWERTIP PH128800T004-ZZA01 panel support

2025-03-12 Thread Louis Chauvet
On Tue, 11 Mar 2025 17:40:04 +0100, Antonin Godard wrote: > The POWERTIP PH128800T004-ZZA01 panel is close to the POWERTIP > PH128800T006-ZHC01, with different timings. Add a binding and a panel > entry under panel-simple.c. > > Applied, thanks! [1/2] dt-bindings: display: simple: Add POWERTI

Re: [PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-03-12 Thread Dmitry Baryshkov
On Wed, 12 Mar 2025 at 11:47, Ayushi Makhija wrote: > > On 3/11/2025 9:11 PM, Dmitry Baryshkov wrote: > > On Tue, Mar 11, 2025 at 05:54:44PM +0530, Ayushi Makhija wrote: > >> The anx7625_link_bridge() checks if a device is not a panel > >> bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT

Re: [PATCH v2 6/8] drm/client: s/new_crtc/crtc/

2025-03-12 Thread Jani Nikula
On Fri, 28 Feb 2025, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the 'new_crtc' variable to just 'crtc' in > drm_client_firmware_config(). We don't call any of the other > stuff in here new or old so this feels out of place. > > v2: Rebase > > Signed-off-by: Ville Syrjälä Reviewed-by:

Re: [PATCH v2 7/8] drm/client: Move variables to tighter scope

2025-03-12 Thread Jani Nikula
On Fri, 28 Feb 2025, Ville Syrjala wrote: > From: Ville Syrjälä > > Bunch of variables are only needed inside loops and whatnot. > Move them to a tighter scope to make the code less confusing. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_client_modese

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Anusha Srivatsa
On Tue, Mar 11, 2025 at 11:52 AM Doug Anderson wrote: > Hi, > > On Mon, Mar 10, 2025 at 1:58 PM Anusha Srivatsa > wrote: > > > > @@ -70,6 +70,7 @@ static int r63353_panel_power_on(struct r63353_panel > *rpanel) > > { > > struct mipi_dsi_device *dsi = rpanel->dsi; > > struct devi

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-12 Thread Krzysztof Kozlowski
On 06/03/2025 19:11, Konrad Dybcio wrote: > From: Konrad Dybcio > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/power/qcom

Re: [PATCH v2 5/8] drm/client: Stop using the legacy crtc->mode

2025-03-12 Thread Jani Nikula
On Fri, 28 Feb 2025, Ville Syrjala wrote: > From: Ville Syrjälä > > crtc->mode is legacy junk and shouldn't really be used with > atomic drivers. > > Most (all?) atomic drivers do end up still calling > drm_atomic_helper_update_legacy_modeset_state() at some > point, so crtc->mode does still get

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: > >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct >> > r63353_panel *rpanel) >> > static int r63353_panel_activate(struct r63353_panel *rpanel) >> > { >> > struct mipi_dsi_device *dsi = rpanel->dsi; >> > -

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 7:54 AM Anusha Srivatsa wrote: > >> > @@ -78,7 +79,7 @@ static int r63353_panel_power_on(struct r63353_panel >> > *rpanel) >> > return ret; >> > } >> > >> > - usleep_range(15000, 25000); >> > + mipi_dsi_usleep_range(&dsi_ctx, 15000,

[PATCH v2 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread Shixiong Ou
From: Shixiong Ou Use device_add_group() to simplify creation and removal. Signed-off-by: Shixiong Ou --- v1->v2: fix build error. drivers/video/fbdev/core/fbcon.c | 49 ++-- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/video/fbde

[PATCH v2 2/2] fbcon: Change return value type to void

2025-03-12 Thread Shixiong Ou
From: Shixiong Ou fbcon_init_device() doesn't need to return a value. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/core/fbcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 9ee5f8492249..6

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-12 Thread Yury Norov
On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > On March 11, 2025 3:01:30 PM PDT, Yury Norov wrote: > >On Sun, Mar 09, 2025 at 11:48:26PM +0800, Kuan-Wei Chiu wrote: > >> On Fri, Mar 07, 2025 at 12:07:02PM -0800, H. Peter Anvin wrote: > >> > On March 7, 2025 11:53:10 AM PST, Davi

Re: [PATCH v2 4/8] drm/client: Make copies of modes

2025-03-12 Thread Jani Nikula
On Fri, 28 Feb 2025, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_client_firmware_config() is currently picking up the current > mode of the crtc via the legacy crtc->mode, which is not supposed > to be used by atomic drivers at all. We can't simply switch over > to the proper crtc->state->

Re: [PATCH v7 0/7] DRM scheduler kunit tests

2025-03-12 Thread Tvrtko Ursulin
On 12/03/2025 13:49, Philipp Stanner wrote: [snip] There I see a UAF. Do you have an idea what that might be? I would only expect memory leaks and the test assertions failing. It is expected all hell to break loose in aspirational mode. There the mock scheduler shutdown relies solely on drm

Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix Kconfig dependencies for ASoC

2025-03-12 Thread Tomi Valkeinen
Hi Arnd, On 27/02/2025 15:20, Arnd Bergmann wrote: From: Arnd Bergmann The new audio code fails to build when sounds support is in a loadable module but the GPU driver is built-in: x86_64-linux-ld: zynqmp_dp_audio.c:(.text+0x6a8): undefined reference to `devm_snd_soc_register_card' x86_64-li

linux-next: build warnings after merge of the drm-intel tree

2025-03-12 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced these warnings: Documentation/gpu/i915:141: drivers/gpu/drm/i915/display/intel_hotplug.c:1068: ERROR: Unexpected indentation. [docutils] Documentation/gpu/i915:141: drivers/gpu/drm/i915/display/intel_hotplug.c

Re: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

2025-03-12 Thread andriy.shevche...@linux.intel.com
On Wed, Mar 12, 2025 at 12:51:33PM +0100, Thomas Zimmermann wrote: > Am 12.03.25 um 10:06 schrieb Aditya Garg: ... > If you want to print out protocol-header tokens, why not use formatting > macros as we do with DRM mode? There's one for the format string [1] and one > for the argument. [2] It's

Re: [PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-12 Thread Piotr Oniszczuk
> Wiadomość napisana przez Andy Yan w dniu 12 mar 2025, o > godz. 11:42: > > From: Andy Yan > > The DW DP TX Controller is compliant with the DisplayPort Specification > Version 1.4 with the following features: > > * DisplayPort 1.4a > * Main Link: 1/2/4 lanes > * Main Link Support 1.62Gbp

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Anusha Srivatsa
On Tue, Mar 11, 2025 at 3:31 AM Maxime Ripard wrote: > On Mon, Mar 10, 2025 at 04:58:22PM -0400, Anusha Srivatsa wrote: > > Move away from using deprecated API and use _multi > > variants if available. Use mipi_dsi_msleep() > > and mipi_dsi_usleep_range() instead of msleep() > > and usleep_range(

Re: [PATCH v4] drm/i915: Fix harmful driver register/unregister asymmetry

2025-03-12 Thread Krzysztof Niemiec
On 2025-03-11 at 21:04:56 GMT, Janusz Krzysztofik wrote: > Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if > drm_dev_register() fails"), we return from i915_driver_register() > immediately if drm_dev_register() fails, skipping remaining registration > steps, and continue only with

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Sven Peter
Hi, On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: >> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >> >> Hi >> >>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >>> > On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: Hi > Am 12.03.25 um 10:05 schrieb Adi

[PATCH v3 0/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-12 Thread David Turner
deletions(-) --- base-commit: eff0347e7c228335e9ff64aaf02c66957803af6a change-id: 20250312-vc4_hotplug-3ae4e783484a Best regards, -- David Turner

[PATCH v3 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-12 Thread David Turner
Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows when to add/remove HDMI audio devices. Signed-off-by: Stefan Wahren Signed-off-by: David Turner --- drivers/gpu/drm/vc4/vc4_hdmi.c | 18 ++ drivers/gpu/drm/vc4/vc4_hdmi.h | 7 +++ 2 files changed, 25 in

[PATCH v3 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect

2025-03-12 Thread David Turner
From: Stefan Wahren drm_atomic_helper_connector_hdmi_hotplug() must be called regardless of the connection status, otherwise the HDMI audio disconnect event won't be notified. Also update the comment on drm_atomic_helper_connector_hdmi_hotplug() to explain that this is necessary. Fixes: 2ea9ec5

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Thomas Zimmermann
Hi Am 12.03.25 um 10:05 schrieb Aditya Garg: From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with

Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-03-12 Thread Krzysztof Kozlowski
On Tue, Mar 11, 2025 at 05:54:38PM +0530, Ayushi Makhija wrote: > Document DSI controller and phy on SA8775P platform. > > Signed-off-by: Ayushi Makhija > --- > .../display/msm/qcom,sa8775p-mdss.yaml| 188 ++ > 1 file changed, 188 insertions(+) > > diff --git > a/Docume

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: > > Hi > >> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> On 12 Mar 2025, at 5:16 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> Am 12.03.25 um 10:05 schrieb Aditya Garg: From: Hector Martin %p4cc is designed f

Re: [PATCH 1/3] drm/udl: Unregister device before cleaning up on disconnect

2025-03-12 Thread Patrik Jakobsson
On Mon, Mar 3, 2025 at 4:09 PM Thomas Zimmermann wrote: > > Disconnecting a DisplayLink device results in the following kernel > error messages > > [ 93.041748] [drm:udl_urb_completion [udl]] *ERROR* udl_urb_completion - > nonzero write bulk status received: -115 > [ 93.055299] [drm:udl_submi

Re: [PATCH 3/3] drm/probe-helper: Do not fail from drmm_kms_helper_poll_init()

2025-03-12 Thread Patrik Jakobsson
On Mon, Mar 3, 2025 at 4:24 PM Thomas Zimmermann wrote: > > Failing to set up connector polling is not significant enough to > fail device probing. Print a warning and return nothing from the > init helper. > > This only affects the managed init function. The unmanaged init > already never fails w

Re: [PATCH] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-12 Thread Christian König
Am 12.03.25 um 14:09 schrieb Chris Bainbridge: > Fix an oops in ttm_bo_delayed_delete which results from dererencing a > dangling pointer: > > Oops: general protection fault, probably for non-canonical address > 0x6b6b6b6b6b6b6b7b: [#1] PREEMPT SMP > CPU: 4 UID: 0 PID: 1082 Comm: kworker/u65:

Re: [PATCH] drm/sched: revert "drm_sched_job_cleanup(): correct false doc"

2025-03-12 Thread Philipp Stanner
On Wed, 2025-03-12 at 14:44 +0100, Christian König wrote: > This reverts commit 44d2f310f008613c1dbe5e234c2cf2be90cbbfab. > > The function drm_sched_job_arm() is indeed the point of no return. > The > background is that it is nearly impossible for the driver to > correctly > retract the fence and

[v4 23/23] drm/doc/rfc: Add documentation for multi-segmented 1D LUT

2025-03-12 Thread Uma Shankar
Add documentation to explain properties of the exposed hardware 1D LUT blocks, its identification and computation of the LUT samples based on the number of samples, their distribution and precison. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- Documentation/gpu/rfc/color_p

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread AngeloGioacchino Del Regno
Il 12/03/25 15:20, Ariel D'Alessandro ha scritto: Angelo, On 3/11/25 6:10 AM, AngeloGioacchino Del Regno wrote: Il 10/03/25 20:59, Ariel D'Alessandro ha scritto: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Phys

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-12 Thread André Almeida
Em 12/03/2025 07:06, Raag Jadav escreveu: On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: Em 01/03/2025 02:53, Raag Jadav escreveu: On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: Hi Raag, On 2/28/25 11

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread Thomas Weißschuh
Hi, On Tue, Mar 11, 2025 at 07:28:55PM +0800, oushixiong1...@163.com wrote: > From: Shixiong Ou > > Use device_add_group() to simplify creation and removal. > > Signed-off-by: Shixiong Ou > --- > drivers/video/fbdev/core/fbcon.c | 48 +++- > 1 file changed, 22 inse

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-12 Thread H. Peter Anvin
On March 12, 2025 4:56:31 PM PDT, Jacob Keller wrote: > > >On 3/7/2025 11:36 AM, David Laight wrote: >> On Fri, 7 Mar 2025 12:42:41 +0100 >> Jiri Slaby wrote: >> >>> On 07. 03. 25, 12:38, Ingo Molnar wrote: * Jiri Slaby wrote: > On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote:

Re:Re: [PATCH v2 2/7] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-12 Thread Andy Yan
Hi Piotr, 在 2025-03-12 22:23:15,"Piotr Oniszczuk" 写道: > > >> Wiadomość napisana przez Andy Yan w dniu 12 mar 2025, o >> godz. 11:42: >> >> From: Andy Yan >> >> The DW DP TX Controller is compliant with the DisplayPort Specification >> Version 1.4 with the following features: >> >> * Display

Re:Re: [PATCH v2 7/7] arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX

2025-03-12 Thread Andy Yan
Hi Dmitry, At 2025-03-12 20:39:17, "Dmitry Baryshkov" wrote: >On Wed, Mar 12, 2025 at 06:42:08PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> The HDMI Port next to Headphone Jack is drived by >> DP1 on rk3588 via a dp2hdmi converter. >> >> Add related dt nodes to enable it. >> >> Note: ROC

[PATCH RFC 1/2] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-12 Thread Anusha Srivatsa
Introduce reference counted allocations for panels to avoid use-after-free. The patch adds the macro devm_drm_bridge_alloc() to allocate a new refcounted panel. Followed the documentation for drmm_encoder_alloc() and devm_drm_dev_alloc and other similar implementations for this purpose. Also addin

[PATCH v5 3/6] PCI: Allow IOV resources to be resized in pci_resize_resource()

2025-03-12 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized. The structures are very similar, which means we can reuse most of the implementation. Extend the pci_resize_resource() function to accept IOV resources. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski --- drivers/pci/io

[PATCH 1/2] drm/panfrost: Add PM runtime flags

2025-03-12 Thread Philippe Simons
When the GPU is the only device attached to a single power domain, core genpd disable and enable it when gpu enter and leave runtime suspend. Some power-domain requires a sequence before disabled, and the reverse when enabled. Add PM flags for CLK and RST, and implement in panfrost_device_runtime

[PATCH 2/2] drm/panfrost: add h616 compatible string

2025-03-12 Thread Philippe Simons
Tie the Allwinner compatible string to the two features bits that will toggle the clocks and the reset line whenever the power domain is changing state. Signed-off-by: Philippe Simons --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/

[PATCH 0/2] drm/panfrost:

2025-03-12 Thread Philippe Simons
Allwinner H616 has a dedicated power domain for its Mali G31. Currently after probe, the GPU is put in runtime suspend which disable the power domain. On first usage of GPU, the power domain enable hangs the system. This series adds the necessary calls to enable the clocks and deasserting the re

[GIT PULL v2] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. HDMI fixup and refinement 2. Move to devm_platform_ioremap_resource() usage 3. Add MT8188 dsc compatible 4. Fix config_updating flag never false when no mbox channel 5. dp: drm_err => dev_err in HPD path to avoid NULL ptr 6. Add dpi power-domains example 7. Add

Re: [GIT PULL] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2025年3月12日 週三 上午7:40寫道: > > Hey, > > This introduced a warning on my local builds, > > commit 30d5c46444a6aa4c78103fb898250ab5e6e8a97d > Author: Jason-JH Lin > Date: Mon Feb 24 13:12:21 2025 +0800 > > drm/mediatek: Fix config_updating flag never false when no mbox c

[PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-12 Thread Mel Henning
We add this ioctl to set up the zcull context switch buffer so userspace can manage it. This also includes support for unbinding the buffer, which helps simplify device teardown on the userspace side. Signed-off-by: Mel Henning --- drivers/gpu/drm/nouveau/include/nvif/if0020.h | 6 +++ .../gpu/

[PATCH 0/2] drm/nouveau: ZCULL support

2025-03-12 Thread Mel Henning
These patches add kernel-side support for using the zcull hardware in nvidia gpus. Zcull aims to improve memory bandwidth by using an early approximate depth test, similar to hierarchical Z on an AMD card. These patches add two new ioctls on nouveau devices, which are currently only supported when

[PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-12 Thread Mel Henning
Userspace needs this information to set up zcull correctly. Signed-off-by: Mel Henning --- .../drm/nouveau/include/nvkm/core/device.h| 6 ++ .../sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gr.h | 69 +++ drivers/gpu/drm/nouveau/nouveau_abi16.c | 15 drivers/gpu/drm/nouve

Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

2025-03-12 Thread Nícolas F . R . A . Prado
On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote: > The mediatek display driver fails to probe on mt8173-elm-hana and > mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY > configurations. > > Enable the following PHY drivers for MediaTek platforms: > - CONFIG_PHY_MTK_

Re: [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function

2025-03-12 Thread Thomas Zimmermann
Merged into drm-misc-next. Thanks for the patch. Am 05.03.25 um 15:09 schrieb Dario Binacchi: Use aperture helpers to remove all generic graphics drivers before loading mxsfb. Makes mxsfb compatible with simpledrm. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-12 Thread Jacob Keller
On 3/7/2025 11:36 AM, David Laight wrote: > On Fri, 7 Mar 2025 12:42:41 +0100 > Jiri Slaby wrote: > >> On 07. 03. 25, 12:38, Ingo Molnar wrote: >>> >>> * Jiri Slaby wrote: >>> On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > Change return type to bool for better clarity. Update the

[GIT PULL] mediatek drm next for 6.15

2025-03-12 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. HDMI fixup and refinement 2. Move to devm_platform_ioremap_resource() usage 3. Add MT8188 dsc compatible 4. Fix config_updating flag never false when no mbox channel 5. dp: drm_err => dev_err in HPD path to avoid NULL ptr 6. Add dpi power-domains example 7. Add

Re: [PATCH next] drm/xe: Fix uninitialized variable in xe_vm_bind_ioctl()

2025-03-12 Thread Dan Carpenter
On Mon, Mar 10, 2025 at 12:56:46PM -0400, Rodrigo Vivi wrote: > On Mon, Mar 10, 2025 at 01:48:00PM +0300, Dan Carpenter wrote: > > The error handling assumes that vm_bind_ioctl_check_args() will > > initialize "bind_ops" but there are a couple early returns where that's > > not true. Initialize "b

Re: [PATCH v4 18/25] drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-12 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20250311] [also build test ERROR on v6.14-rc6] [cannot apply to drm-exynos/exynos-drm-next rockchip/for-next tegra/for-next drm-xe/drm-xe-next linus/master v6.14-rc6 v6.14-rc5 v6.14-rc4] [If your patc

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 5:00 PM Anusha Srivatsa wrote: > > > > On Wed, Mar 12, 2025 at 11:48 AM Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: >> > >> >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct >> >> > r63353_panel *rpan

[RFC PATCH 12/19] drm/xe: Make the PT code handle placement per PTE rather than per vma / range

2025-03-12 Thread Thomas Hellström
With SVM, ranges forwarded to the PT code for binding can, mostly due to races when migrating, point to both VRAM and system / foreign device memory. Make the PT code able to handle that by checking, for each PTE set up, whether it points to local VRAM or to system memory. Signed-off-by: Thomas He

linux-next: manual merge of the tip tree with the drm tree

2025-03-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: drivers/gpu/drm/i915/i915_pmu.c between commit: 87b593d79864 ("drm/i915/pmu: Drop custom hotplug code") from the drm tree and commit: 82ad584eed8b ("drm/i915/pmu: Switch to use hrtimer_setup()") from the tip tree. I f

[PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls

2025-03-12 Thread Chen Ni
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni --- dri

Re: [PATCH v1 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-12 Thread Ariel D'Alessandro
Boris, Angelo, On 3/11/25 7:05 AM, Boris Brezillon wrote: On Tue, 11 Mar 2025 10:14:44 +0100 AngeloGioacchino Del Regno wrote: Il 11/03/25 09:05, Boris Brezillon ha scritto: On Mon, 10 Mar 2025 16:59:19 -0300 Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-03-12 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 80e54e84911a923c40d7bee33a34c1b4be148d7a: Linux 6.14-rc6 (2025-03-09 13:45:25 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-03-12 for you to fe

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > Hi, > > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: On 12 Mar 2025, at 5:29 PM, Thomas Zimmermann wrote: >>> >>> Hi >>> Am 12.03.25 um 12:49 schrieb Aditya Garg: >> On 12 Mar 2025, at 5:16 PM, Thomas Zimmerm

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Andy Shevchenko
On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: > > On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: > > On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: ... > > I don't have a strong opinion either way: for SMC I just need to print > > FourCC keys for debugging / information in a fe

Re: [PATCH 1/2] fbcon: Register sysfs groups through device_add_group

2025-03-12 Thread kernel test robot
Hi, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.14-rc6 next-20250312] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH 00/63] Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2025-03-12 Thread jim . cromie
hello everyone, sorry for the late reply. I have a cleaner version cooking now. less inter-commit churn, by bringing more cleanups forward. I'll send a -v2 soon. (lets forget all the meandering crap versions I sent) Louis, thanks for testing ! I wrote the test script and submod.ko so the

Re: [PATCH v7 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults

2025-03-12 Thread Zhang, Jianxun
Sorry if my reply is still in a wrong format. I have set plain text in the web-based outlook this time but don't know if it really works. Refer to my inline comment, thanks. From: Cavitt, Jonathan Sent: Tuesday, March 11, 2025 7:11 AM To: Brost, Matthew;

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-12 Thread Kuan-Wei Chiu
On Wed, Mar 12, 2025 at 11:51:12AM -0400, Yury Norov wrote: > On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > > On March 11, 2025 3:01:30 PM PDT, Yury Norov wrote: > > >On Sun, Mar 09, 2025 at 11:48:26PM +0800, Kuan-Wei Chiu wrote: > > >> On Fri, Mar 07, 2025 at 12:07:02PM -0800,

Re: [PATCH v2 01/10] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY

2025-03-12 Thread Krzysztof Kozlowski
On Tue, Mar 11, 2025 at 05:54:36PM +0530, Ayushi Makhija wrote: > Document the DSI PHY on the SA8775P Platform. > > Signed-off-by: Ayushi Makhija > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski Best r

Re: [PATCH v3] drm/ci: fix merge request rules

2025-03-12 Thread Helen Mae Koike Fornazier
Em seg., 10 de mar. de 2025 às 05:25, Daniel Stone escreveu: > > On Fri, 28 Feb 2025 at 13:26, Vignesh Raman > wrote: > > Merge request pipelines were only created when changes > > were made to drivers/gpu/drm/ci/, causing MRs that > > didn't touch this path to break. Fix MR pipeline rules > > t

Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-03-12 Thread Aditya Garg
> On 13 Mar 2025, at 12:58 AM, Andy Shevchenko > wrote: > > On Wed, Mar 12, 2025 at 07:14:36PM +, Aditya Garg wrote: On 12 Mar 2025, at 9:05 PM, Sven Peter wrote: >>> On Wed, Mar 12, 2025, at 13:03, Aditya Garg wrote: > > ... > >>> I don't have a strong opinion either way: for SMC

Re: [PATCH v2 7/7] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-03-12 Thread kernel test robot
: 4423e607ff50157aaf088854b145936cbab4d560 patch link: https://lore.kernel.org/r/20250311-hdmi-conn-yuv-v2-7-fbdb94f02562%40collabora.com patch subject: [PATCH v2 7/7] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode config: x86_64-randconfig-004-20250312 (https://download

Re: [PATCH v7 0/7] DRM scheduler kunit tests

2025-03-12 Thread Philipp Stanner
On Wed, 2025-03-12 at 10:50 +, Tvrtko Ursulin wrote: > > On 12/03/2025 10:39, Philipp Stanner wrote: > > On Tue, 2025-03-11 at 09:23 +, Tvrtko Ursulin wrote: > > > There has repeatedly been quite a bit of apprehension when any > > > change > > > to the DRM > > > scheduler is proposed, with

[PATCH] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-12 Thread Chris Bainbridge
Fix an oops in ttm_bo_delayed_delete which results from dererencing a dangling pointer: Oops: general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b6b7b: [#1] PREEMPT SMP CPU: 4 UID: 0 PID: 1082 Comm: kworker/u65:2 Not tainted 6.14.0-rc4-00267-g505460b44513-dirty #216 H

[v4 20/23] drm/i915/color: Program Pre-CSC registers

2025-03-12 Thread Uma Shankar
Add callback for programming Pre-CSC LUT for TGL and beyond Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/dr

Re: [PATCH v7 0/7] DRM scheduler kunit tests

2025-03-12 Thread Tvrtko Ursulin
On 12/03/2025 13:27, Tvrtko Ursulin wrote: On 12/03/2025 12:35, Philipp Stanner wrote: On Wed, 2025-03-12 at 10:50 +, Tvrtko Ursulin wrote: On 12/03/2025 10:39, Philipp Stanner wrote: On Tue, 2025-03-11 at 09:23 +, Tvrtko Ursulin wrote: There has repeatedly been quite a bit of app

[PATCH v2 0/2] drm/display: HDMI documentation improvements

2025-03-12 Thread Maxime Ripard
Hi, These patches improve the HDMI infrastructure documentation, in particular to mention that edid-decode can help debug and check infoframes issues. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v2: - Put a link to the v4l-utils repo - Used a newer edid-decode

[PATCH v2 1/2] drm/display: hdmi: Create documentation section

2025-03-12 Thread Maxime Ripard
We have had documentation for the public functions in the HDMI helpers, but those were never referenced anywhere and thus not compiled as part of the doc. Let's add a section. Signed-off-by: Maxime Ripard --- Documentation/gpu/drm-kms-helpers.rst | 15 +++ drivers/gpu/drm/

  1   2   >