Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Vincent Mailhol
On 07/03/2025 at 02:55, Andy Shevchenko wrote: > On Fri, Mar 07, 2025 at 01:08:15AM +0900, Vincent Mailhol wrote: >> On 06/03/2025 at 22:11, Andy Shevchenko wrote: >>> On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol via B4 Relay >>> wrote: From: Vincent Mailhol Add some a

[PATCH next] drm/msm/dpu: Fix uninitialized variable in dpu_crtc_kickoff_clone_mode()

2025-03-07 Thread Dan Carpenter
After the loop there is a check for whether "wb_encoder" has been set to non-NULL, however it was never set to NULL. Initialize it to NULL. Fixes: ad06972d5365 ("drm/msm/dpu: Reorder encoder kickoff for CWB") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 fi

[PATCH v3 0/3] Add support for AM62L DSS

2025-03-07 Thread Devarsh Thakkar
This adds support for DSS subsystem present in TI's AM62L SoC which supports single display pipeline with DPI output which is also routed to DSI Tx controller within the SoC. Change Log: V3: - Make generic infra to support truncated K3 DSS IP's - Remove AM62A updates from AM62L DT binding updates

Re: [PATCH v4 1/3] drm/drm_mm: Safe macro for iterating through nodes in range

2025-03-07 Thread Christian König
Am 06.03.25 um 23:21 schrieb Tomasz Lis: > Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range > squished together into one macro. Looks sane in general, but the other patches who actually use that never made it into my inbox. Please send them out to me once more and maybe pu

[PATCH v3 1/2] drm/vmwgfx: Refactor cursor handling

2025-03-07 Thread Zack Rusin
Refactor cursor handling to make the code maintainable again. Over the last 12 years the svga device improved support for virtualized cursors and at the same time the drm interfaces evolved quite a bit from pre-atomic to current atomic ones. vmwgfx only added new code over the years, instead of adj

[PATCH v3 2/2] drm/vmwgfx: Bump the minor version

2025-03-07 Thread Zack Rusin
Bump the minor version of vmwgfx in order to detect releases where the cursor issues have been fixed. Cursors created with dumb buffer were broken on vmwgfx. Userspace (e.g. kwin) has workarounds for those issues and often disables hardware cursors on vmwgfx. This allows enabling hardware cursors

Re: [PATCH v5 drm-dp 3/9] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-03-07 Thread Dmitry Baryshkov
On Fri, Mar 07, 2025 at 06:16:34PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Add dp serdes cfg in link training process, and related adapting > and modificating. Change some init values about training, because we want > completely to negotiation process, so we start with the maximum rate a

[PATCH v3 0/2] Fix native cursors with vmwgfx

2025-03-07 Thread Zack Rusin
vmwgfx had a number of cursor issues that related both to our handling of dumb buffers and general detection when a cursor has actually changed. Fix those issues and bump the kernel module version to allow userspace to recognize fixed versions of the driver. v2: Include the fix for leaked dirty tr

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Simona Vetter
On Fri, Mar 07, 2025 at 08:32:55AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 11:28:37AM +0100, Simona Vetter wrote: > > > > I wouldn't say it is wrong. It is still the correct thing to do, and > > > following down the normal cleanup paths is a good way to ensure the > > > special cas

Re: [PATCH 2/2] drm/display: hdmi: Mention Infoframes testing with edid-decode

2025-03-07 Thread Hans Verkuil
Hi Maxime, On 06/03/2025 18:17, Maxime Ripard wrote: > edid-decode gained recently support to check that infoframes are > compliant and match the EDID the monitor exposes. > > Since the HDMI helpers provide those infoframes in debugfs, it makes it > easy to check from userspace that the drivers (

Re: [PATCH v5 drm-dp 9/9] drm/hisilicon/hibmc: Add vga connector detect functions

2025-03-07 Thread Dmitry Baryshkov
On Fri, Mar 07, 2025 at 06:16:40PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Because the connected VGA connector would make driver can't get the > userspace call, adding detect_ctx in vga connector to make HPD active > userspace. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-03-07 Thread Simona Vetter
On Fri, Mar 07, 2025 at 09:42:25AM +0100, Simona Vetter wrote: > On Tue, Feb 18, 2025 at 03:23:25PM +0100, Thomas Zimmermann wrote: > > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > > scanline pitch and allocation size. Implementations of struct > > drm_driver.dumb_create can c

Re: [PATCH v4 6/8] soc: mediatek: Add programming flow for unsupported subsys ID hardware

2025-03-07 Thread 林睿祥

[PATCH v4 1/5] drm: Move some options to separate new Kconfig

2025-03-07 Thread Tvrtko Ursulin
Move some options out into a new debug specific kconfig file in order to make things a bit cleaner. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/drm/Kconfig | 109 ++ drivers

[PATCH 09/10] iommu/arm-smmu-qcom: Add SAR2130P MDSS compatible

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add the SAR2130P compatible to clients compatible list, the device require identity domain. Signed-off-by: Dmitry Baryshkov --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/dr

Re: [PATCH 06/10] drm/msm/mdss: add SAR2130P device configuration

2025-03-07 Thread Dmitry Baryshkov
On Sat, Mar 08, 2025 at 03:42:24AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Add compatible and device configuration for the Qualcomm SAR2130P > platform. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_mdss.c | 11 +++ > 1 file changed, 11 inserti

Re: [PATCH next] drm: adp: Fix NULL vs IS_ERR() check in adp_plane_new()

2025-03-07 Thread Sasha Finkelstein
On Fri, 7 Mar 2025 at 10:31, Dan Carpenter wrote: > > The __drmm_universal_plane_alloc() function doesn't return NULL, it > returns error pointers. Update the check to match. > > Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver") Acked-by: Sasha Finkelstein

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-07 Thread David Laight
On Fri, 07 Mar 2025 11:30:35 -0800 "H. Peter Anvin" wrote: > On March 7, 2025 10:49:56 AM PST, Andrew Cooper > wrote: > >> (int)true most definitely is guaranteed to be 1. > > > >That's not technically correct any more. > > > >GCC has introduced hardened bools that intentionally have bit patt

Re: [PATCH v6 0/7] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 12:18:02PM -0500, Yury Norov wrote: > No rush, please allow your reviewers a week or two before submitting > a new iteration unless you want to disregard the previous version for > some reason, of course. This will not get into the upcoming merge > window, anyways. > > So,

RE: [PATCH v6 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-07 Thread Lin, Shuicheng
On Fri, Mar 7, 2025 2:41 PM Cavitt, Jonathan wrote > Add additional information to each VM so they can report up to the first > 50 seen pagefaults. Only failed pagefaults are saved this way, as successful > pagefaults should recover and not need to be reported to userspace. > > v2: > - Free vm af

RE: [PATCH v6 0/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl

2025-03-07 Thread Lin, Shuicheng
One generic question, do we have test case to verify whether the function is working correctly? Thanks. I think we could have IGT test case to trigger the fault, then have another IGT test case to query it with this new uapi. And make sure we could get the expected data with the new uapi. Shuich

[PATCH v6 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol In an upcoming change, GENMASK() and its friends will indirectly depend on sizeof() which is not available in asm. Instead of adding further complexity to __GENMASK() to make it work for both asm and non asm, just split the definition of the two variants. Signed-off-by: Vi

[PATCH v6 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Vincent Mailhol Add some additional tests in lib/test_bits.c to cover the expected results of the fixed type BIT_U*() macros. Signed-off-by: Vincent Mailhol --- Changelog: v5 -> v6: - No changes. v4 -> v5: - BIT_U8()/BIT_U16() are now back to u8/u16. v3 -> v4: - Ne

[PATCH 2/5] drm/msm/dpu: enable SmartDMA on SC8180X

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Reworking of the catalog dropped the SmartDMA feature bit on the SC8180X platform. Renable SmartDMA support on this SoC. Fixes: 460c410f02e4 ("drm/msm/dpu: duplicate sdm845 catalog entries") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_

Re: [PATCH next] drm/msm/dpu: Fix uninitialized variable in dpu_crtc_kickoff_clone_mode()

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Fri, 07 Mar 2025 12:29:39 +0300, Dan Carpenter wrote: > After the loop there is a check for whether "wb_encoder" has been set > to non-NULL, however it was never set to NULL. Initialize it to NULL. > > Applied, thanks! [1/1] drm/msm/dpu: Fix uninitialized variable

Re: [PATCH -next] drm/msm/dpu: Remove duplicate dpu_hw_cwb.h header

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Fri, 07 Mar 2025 09:50:30 +0800, Jiapeng Chong wrote: > ./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: dpu_hw_cwb.h is included more > than once. > > Applied, thanks! [1/1] drm/msm/dpu: Remove duplicate dpu_hw_cwb.h header https://gitlab.freedesktop.org/lumag

Re: [PATCH v3 00/21] drm/msm: Add support for SM8750

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Fri, 21 Feb 2025 16:24:10 +0100, Krzysztof Kozlowski wrote: > Dependency / Rabased on top of > == > https://lore.kernel.org/all/20241214-dpu-drop-features-v1-0-988f0662c...@linaro.org/ > > Merging > === > DSI pieces here might not be rea

Re: [PATCH] drm/msm/dpu: Adjust CDM_MUX to support CWB PINGPONG

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Wed, 05 Mar 2025 19:16:51 -0800, Jessica Zhang wrote: > Similar to WB_MUX, CDM_MUX also needs to be adjusted to support > dedicated CWB PINGPONGs > > Applied, thanks! [1/1] drm/msm/dpu: Adjust CDM_MUX to support CWB PINGPONG https://gitlab.freedesktop.org/luma

Re: [PATCH 0/2] drm/msm/dpu: two fixes for kerneldocs

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Thu, 06 Mar 2025 10:22:28 +0200, Dmitry Baryshkov wrote: > Applied, thanks! [1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs https://gitlab.freedesktop.org/lumag/msm/-/commit/096775c3dcf3 [2/2] drm/msm/dpu: correct struct dpu_encoder_virt docs

[PATCH 3/5] drm/msm/dpu: enable SmartDMA on SC8280XP

2025-03-07 Thread Dmitry Baryshkov
From: Abhinav Kumar In order to support more versatile configuration of the display pipes on SC8280XP, enable SmartDMA for this platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 16 1 file changed, 8 insertions(+), 8 delet

[PATCH 04/11] arm64: dts: qcom: msm8916: Fix KPSS ACC compatible

2025-03-07 Thread Konrad Dybcio
From: Konrad Dybcio The current compatible has been used with no corresponding documentation. Replace it with one that has been documented. This has no functional effect, as these nodes' resources are only consumed through a phandle reference, anyway. Signed-off-by: Konrad Dybcio --- arch/arm

Re: [PATCH] dma-buf: Take a breath during dma-fence-chain subtests

2025-03-07 Thread Christian König
Am 06.03.25 um 16:11 schrieb Nitin Gote: > Give the scheduler a chance to breath by adding delay of 10ms > as some of the loops may take some time on old machines (like apl/bsw/pnv), > and so catch the attention of the watchdogs. > > v1: Instead of cond_resched(), use more generic call like > f

Re: [PATCH 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-07 Thread Dmitry Baryshkov
On Fri, Mar 07, 2025 at 09:40:56PM -0600, Rob Herring (Arm) wrote: > > On Sat, 08 Mar 2025 03:42:23 +0200, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov > > > > Describe the Mobile Display SubSystem (MDSS) device present on the > > Qualcomm SAR2130P platform. It looks pretty close to SM8550

[PATCH 0/5] drm/msm/dpu: update SmartDMA feature masks

2025-03-07 Thread Dmitry Baryshkov
It is easy to skip or ignore the fact that the default SSPP feature masks for SDM845+ don't include the SmartDMA bit (both during development and during the review stage). Enable SmartDMA on SC8180X, SC8280XP, SM8150 and SM8550. Then rename SSPP feature masks to make it more explicit that using no

[PATCH 5/5] drm/msm/dpu: rename non-SmartDMA feature masks to be more explicit

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov It is easy to skip or ignore the fact that the default SSPP feature masks for SDM845+ don't include the SmartDMA bit (both during development and during the review stage). Rename SSPP feature masks to make it more explicit that using non-SmartDMA masks should not be an exce

[PATCH 1/5] drm/msm/dpu: enable SmartDMA on SM8150

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Reworking of the catalog dropped the SmartDMA feature bit on the SM8150 platform. Renable SmartDMA support on this SoC. Fixes: 460c410f02e4 ("drm/msm/dpu: duplicate sdm845 catalog entries") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0

[PATCH 4/5] drm/msm/dpu: enable SmartDMA on SM8550

2025-03-07 Thread Dmitry Baryshkov
From: Abhinav Kumar In order to support more versatile configuration of the display pipes on SM8550, enable SmartDMA for this platform. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 20 ++-- 1 file changed, 10 insertions(+), 10 delet

[PATCH v6 3/7] bits: introduce fixed-type BIT_U*()

2025-03-07 Thread Vincent Mailhol via B4 Relay
From: Lucas De Marchi Implement fixed-type BIT_U*() to help drivers add stricter checks, like it was done for GENMASK_U*(). Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Co-developed-by: Vincent Mailhol Signed-off-by: Vincent Mailhol --- Changelog: v5 -> v6: - No changes. v

Re: Time for drm-ci-next?

2025-03-07 Thread Rob Clark
On Fri, Mar 7, 2025 at 9:00 AM Maxime Ripard wrote: > > On Fri, Mar 07, 2025 at 08:42:46AM -0800, Rob Clark wrote: > > On Tue, Sep 24, 2024 at 5:27 AM Vignesh Raman > > wrote: > > > > > > Hi, > > > > > > On 12/09/24 11:18, Dmitry Baryshkov wrote: > > > > On Mon, Sep 09, 2024 at 07:34:04AM GMT, Ro

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-07 Thread David Laight
On Fri, 7 Mar 2025 12:42:41 +0100 Jiri Slaby wrote: > On 07. 03. 25, 12:38, Ingo Molnar wrote: > > > > * Jiri Slaby wrote: > > > >> On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > >>> Change return type to bool for better clarity. Update the kernel doc > >>> comment accordingly, including fix

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-07 Thread H. Peter Anvin
On March 7, 2025 11:30:08 AM PST, Yury Norov wrote: >On Fri, Mar 07, 2025 at 04:14:34AM -0800, H. Peter Anvin wrote: >> On March 7, 2025 4:13:26 AM PST, Ingo Molnar wrote: >> > >> >* Jiri Slaby wrote: >> > >> >> On 07. 03. 25, 12:38, Ingo Molnar wrote: >> >> > >> >> > * Jiri Slaby wrote: >> >>

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-07 Thread Konrad Dybcio
On 7.03.2025 12:07 PM, Stephan Gerhold wrote: > On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> MSM8916 seems to reuse the same hardware as MSM8974 and friends (for >> whom this binding document was created). Add a new compatible for it. >> >> Signed-off

Re: [PATCH v6 1/7] bits: split the definition of the asm and non-asm GENMASK()

2025-03-07 Thread Andy Shevchenko
On Sat, Mar 08, 2025 at 01:48:48AM +0900, Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > In an upcoming change, GENMASK() and its friends will indirectly > depend on sizeof() which is not available in asm. > > Instead of adding further complexity to __GENMASK() to make it work >

[PATCH v6 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-07 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

[PATCH v6 6/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl

2025-03-07 Thread Jonathan Cavitt
Add support for userspace to request a list of observed failed pagefaults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from

[PATCH v6 4/6] drm/xe/uapi: Define drm_xe_vm_get_faults

2025-03-07 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_faults ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 49 +++ 1 file changed, 49 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 616916985e3f..90c2fcd

[PATCH v6 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-07 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_p

Re: [PATCH RFC v3 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-03-07 Thread Lyude Paul
I thought we had agreed that drm_dp_aux_dev.c was one of the few places where we wanted to keep using the old functions here? On Fri, 2025-03-07 at 06:34 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > Acked-by

[PATCH v2] drm/gpusvm: Fix kernel-doc

2025-03-07 Thread Lucas De Marchi
thew Brost Signed-off-by: Lucas De Marchi --- Changes in v2: - Unindent paragraph that shouldn't be part of "Device Memory Operations" - Link to v1: https://lore.kernel.org/r/20250307-fix-svm-kerneldoc-v1-1-c786f73ae...@intel.com --- Documentation/gpu/rfc/gpusvm.rst |

[PATCH 10/10] arm64: dts: qcom: sar2130p: add display nodes

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Add display controller, two DSI hosts, two DSI PHYs and a single DP controller. Link DP to the QMP Combo PHY. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sar2130p.dtsi | 394 + 1 file changed, 394 insertions(+) diff --git

[PATCH 02/10] dt-bindings: display/msm: dsi-controller-main: describe SAR2130P

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe MIPI DSI controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 00/10] drm/msm: add support for SAR2130P

2025-03-07 Thread Dmitry Baryshkov
Add support for the Mobile Display SubSystem (MDSS) device present on the Qualcomm SAR2130P platform. The MDSS device is similar to SM8550, it features two MIPI DSI controllers, two MIPI DSI PHYs and one DisplayPort controller. Note, due to the technical limitations DP controller wasn't completely

Re: [PATCH 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-07 Thread Rob Herring (Arm)
On Sat, 08 Mar 2025 03:42:23 +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Describe the Mobile Display SubSystem (MDSS) device present on the > Qualcomm SAR2130P platform. It looks pretty close to SM8550 on the > system level. SAR2130P features two DSI hosts and single DisplayPort

[PATCH 01/10] dt-bindings: display/msm: dp-controller: describe SAR2130P

2025-03-07 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Describe DisplayPort controller present on Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/d

Re: [PATCH v2 1/2] drm/mipi-dsi: Add mipi_dsi_dual_msleep

2025-03-07 Thread neil . armstrong
On 07/03/2025 10:15, Tejas Vipin wrote: Introduces mipi_dsi_dual_msleep to make it easier to use msleep in the case of a double-DSI panel. Signed-off-by: Tejas Vipin --- include/drm/drm_mipi_dsi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Simona Vetter
On Thu, Mar 06, 2025 at 11:32:36AM -0400, Jason Gunthorpe wrote: > On Thu, Mar 06, 2025 at 11:42:38AM +0100, Simona Vetter wrote: > > > Further, I just remembered, (Danilo please notice!) there is another > > > related issue here that DMA mappings *may not* outlive remove() > > > either. netdev had

Re: [PATCH v5 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-07 Thread Gwan-gyeong Mun
On 3/4/25 7:08 PM, Jonathan Cavitt wrote: The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by:

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Jason Gunthorpe
On Fri, Mar 07, 2025 at 11:28:37AM +0100, Simona Vetter wrote: > > I wouldn't say it is wrong. It is still the correct thing to do, and > > following down the normal cleanup paths is a good way to ensure the > > special case doesn't have bugs. The primary difference is you want to > > understand t

Re: [PATCH] drm/gpusvm: Fix kernel-doc

2025-03-07 Thread Matthew Brost
drm_gpusvm_notifier *notifier, > @@ -499,7 +514,7 @@ drm_gpusvm_notifier_invalidate(struct > mmu_interval_notifier *mni, > return true; > } > > -/** > +/* > * drm_gpusvm_notifier_ops - MMU interval notifier operations for GPU SVM > */ > static const struct

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-07 Thread Yury Norov
On Fri, Mar 07, 2025 at 07:57:48AM +0100, Jiri Slaby wrote: > On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > > Several parts of the kernel contain redundant implementations of parity > > calculations for 16/32/64-bit values. Introduces generic > > parity16/32/64() helpers in bitops.h, providing a sta

[PATCH] drm/panthor: Make the timeout per-queue instead of per-job

2025-03-07 Thread Ashley Smith
The timeout logic provided by drm_sched leads to races when we try to suspend it while the drm_sched workqueue queues more jobs. Let's overhaul the timeout handling in panthor to have our own delayed work that's resumed/suspended when a group is resumed/suspended. When an actual timeout occurs, we

Re: [PATCH 2/2] drm/msm/dpu: correct struct dpu_encoder_virt docs

2025-03-07 Thread Rob Clark
On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov wrote: > > Fix a typo in struct dpu_encoder_virt kerneldoc, which made it ignore > description of the cwb_mask field. > > Fixes: dd331404ac7c ("drm/msm/dpu: Configure CWB in writeback encoder") > Signed-off-by: Dmitry Baryshkov Reviewed-by: Rob Cl

Re: [PATCH 1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs

2025-03-07 Thread Rob Clark
On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov wrote: > > Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode > status changes") and describe old_crtc_state and new_crtc_state params > instead of the single previously used parameter crtc_state. > > Fixes: 20972609d12c ("drm/

Re: [PATCH v5 7/7] test_bits: add tests for BIT_U*()

2025-03-07 Thread Andy Shevchenko
On Fri, Mar 07, 2025 at 07:11:42PM +0900, Vincent Mailhol wrote: > On 07/03/2025 at 02:55, Andy Shevchenko wrote: > > On Fri, Mar 07, 2025 at 01:08:15AM +0900, Vincent Mailhol wrote: > >> On 06/03/2025 at 22:11, Andy Shevchenko wrote: > >>> On Thu, Mar 06, 2025 at 08:29:58PM +0900, Vincent Mailhol

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-07 Thread Kuan-Wei Chiu
Hi Jiri, On Fri, Mar 07, 2025 at 07:57:48AM +0100, Jiri Slaby wrote: > On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > > Several parts of the kernel contain redundant implementations of parity > > calculations for 16/32/64-bit values. Introduces generic > > parity16/32/64() helpers in bitops.h, provi

[PATCH v5 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-07 Thread Yongbang Shi
From: Baihan Li This dp controller need features of digital-to-analog conversion and high-speed transmission in chip by its extern serdes controller. Our serdes cfg is relatively simple, just need two register configurations. Don't need too much functions, like: power on/off, initialize, and some

Re: [PATCH v2 1/2] drm/vmwgfx: Refactor cursor handling

2025-03-07 Thread kernel test robot
it exynos-drm-next patch link: https://lore.kernel.org/r/20250306041222.2776379-2-zack.rusin%40broadcom.com patch subject: [PATCH v2 1/2] drm/vmwgfx: Refactor cursor handling config: arm64-randconfig-003-20250307 (https://download.01.org/0day-ci/archive/20250307/202503071951.dbymeilu-...

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-07 Thread Ingo Molnar
* Jiri Slaby wrote: > On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: > > Change return type to bool for better clarity. Update the kernel doc > > comment accordingly, including fixing "@value" to "@val" and adjusting > > examples. Also mark the function with __attribute_const__ to allow > > potenti

Re: [PATCH v5 drm-dp 2/9] drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage and pre-emphasis

2025-03-07 Thread Dmitry Baryshkov
On Fri, Mar 07, 2025 at 06:16:33PM +0800, Yongbang Shi wrote: > From: Baihan Li > > This dp controller need features of digital-to-analog conversion and > high-speed transmission in chip by its extern serdes controller. Our > serdes cfg is relatively simple, just need two register configurations.

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-07 Thread Jiri Slaby
On 07. 03. 25, 10:19, Kuan-Wei Chiu wrote: I used to believe that casting a boolean variable to int would always result in 0 or 1 until a few months ago when Waiman Long explicitly pointed out during a review that C does not guarantee this. So I revisited the C11 standard, which states that cast

Re: [PATCH v2 2/2] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-07 Thread neil . armstrong
On 07/03/2025 10:15, Tejas Vipin wrote: Changes the novatek-nt36523 panel to use multi style functions for improved error handling. Additionally, novatek-nt36523 will now continue to execute the init sequence on one of the DSI devices on an error occurring on the other one. Sorry but I think th

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-03-07 Thread Maxime Ripard
On Wed, Feb 19, 2025 at 02:35:14PM +0100, Louis Chauvet wrote: > > > Le 19/02/2025 à 11:15, Maxime Ripard a écrit : > > On Wed, Feb 05, 2025 at 04:32:07PM +0100, Louis Chauvet wrote: > > > On 05/02/25 - 09:55, Maxime Ripard wrote: > > > > On Mon, Jan 27, 2025 at 11:48:23AM +0100, Louis Chauvet wr

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Greg KH
On Fri, Mar 07, 2025 at 10:46:29AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 03:00:09PM +0100, Greg KH wrote: > > On Fri, Mar 07, 2025 at 08:32:55AM -0400, Jason Gunthorpe wrote: > > > On Fri, Mar 07, 2025 at 11:28:37AM +0100, Simona Vetter wrote: > > > > > > > > I wouldn't say it is

Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

2025-03-07 Thread Frank Li
On Fri, Mar 07, 2025 at 12:22:17PM +0100, Luca Ceresoli wrote: > Hello Liu, > > On Fri, 7 Mar 2025 14:42:12 +0800 > Liu Ying wrote: > > > On 03/07/2025, Luca Ceresoli wrote: > > > 'ret' can only be 0 at this point, being preceded by a 'if (ret) return > > > ret;'. So return 0 for clarity. > > > >

Re: [PATCH drm-next 2/2] drm/virtio: Use atomic_vmap to work drm_panic in GUI

2025-03-07 Thread kernel test robot
patch link: https://lore.kernel.org/r/20250305152555.318159-3-ryasuoka%40redhat.com patch subject: [PATCH drm-next 2/2] drm/virtio: Use atomic_vmap to work drm_panic in GUI config: i386-buildonly-randconfig-001-20250306 (https://download.01.org/0day-ci/archive/20250307/202503070700.epiur1e6

Re: [PATCH v2 3/3] drm: panel: Add a driver for Generic MIPI-DSI/DPI(+SPI) panels

2025-03-07 Thread kernel test robot
Hi Hironori, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v6.14-rc5 next-20250305] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[PATCH v3 07/16] lib/bch: Replace open-coded parity calculation with parity32()

2025-03-07 Thread Kuan-Wei Chiu
Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- Changes in v3: - Change parity32(mask) to !!parity32(mask).

Re: [PATCH v5 0/7] bits: Fixed-type GENMASK()/BIT()

2025-03-07 Thread Andy Shevchenko
On Thu, Mar 06, 2025 at 08:29:51PM +0900, Vincent Mailhol via B4 Relay wrote: > Introduce some fixed width variant of the GENMASK() and the BIT() > macros in bits.h. Note that the main goal is not to get the correct > type, but rather to enforce more checks at compile time. For example: > > GENM

Re: [PATCH v3 01/16] bitops: Change parity8() return type to bool

2025-03-07 Thread Jiri Slaby
On 07. 03. 25, 12:38, Ingo Molnar wrote: * Jiri Slaby wrote: On 06. 03. 25, 17:25, Kuan-Wei Chiu wrote: Change return type to bool for better clarity. Update the kernel doc comment accordingly, including fixing "@value" to "@val" and adjusting examples. Also mark the function with __attribut

Re: [PATCH] drm/msm/dpu: Adjust CDM_MUX to support CWB PINGPONG

2025-03-07 Thread Dmitry Baryshkov
On Thu, Mar 06, 2025 at 11:33:46AM -0800, Abhinav Kumar wrote: > > > On 3/5/2025 10:44 PM, Dmitry Baryshkov wrote: > > On Wed, Mar 05, 2025 at 07:16:51PM -0800, Jessica Zhang wrote: > > > Similar to WB_MUX, CDM_MUX also needs to be adjusted to support > > > dedicated CWB PINGPONGs > > > > > > Si

Re: [PATCH v5 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-07 Thread Gwan-gyeong Mun
On 3/4/25 7:08 PM, Jonathan Cavitt wrote: Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. The unrecoverable pagefault scena

Re: [PATCH v2 1/5] drm/prime: Support dedicated DMA device for dma-buf imports

2025-03-07 Thread Jani Nikula
On Fri, 07 Mar 2025, Thomas Zimmermann wrote: > Importing dma-bufs via PRIME requires a DMA-capable device. Devices on > peripheral busses, such as USB, often cannot perform DMA by themselves. > Without DMA-capable device PRIME import fails. DRM drivers for USB > devices already use a separate DMA

Re: [PATCH v2 0/5] drm: Provide a dedicated DMA device for PRIME import

2025-03-07 Thread Jani Nikula
On Fri, 07 Mar 2025, Thomas Zimmermann wrote: > Importing dma-bufs via PRIME requires a DMA-capable hardware device. > This is not the case for USB, where DMA is performed entirely by the > USB controller instead of the USB devices. > > Drivers for USB-based hardware maintain their own workarounds

Re: [PATCH v7 3/3] drm/sched: Update timedout_job()'s documentation

2025-03-07 Thread Philipp Stanner
On Thu, 2025-03-06 at 12:57 -0800, Matthew Brost wrote: > On Wed, Mar 05, 2025 at 02:05:52PM +0100, Philipp Stanner wrote: > > drm_sched_backend_ops.timedout_job()'s documentation is outdated. > > It > > mentions the deprecated function drm_sched_resubmit_jobs(). > > Furthermore, > > it does not po

[PATCH v3 08/16] drm/vkms: Allow to configure multiple encoders via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/encoders to allow to create as many encoders as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 87 +

[PATCH v3 09/16] drm/vkms: Allow to attach encoders and CRTCs via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/encoders/encoder/possible_crtcs that will contain symbolic links to the possible CRTCs for the encoder. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 + drivers/gp

[PATCH v3 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/planes to allow to create as many planes as required. Reviewed-by: Louis Chauvet Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 16 - drivers/gpu/drm/vkms/vkms_co

[PATCH v3 11/16] drm/vkms: Allow to attach connectors and encoders via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/connectors/connector/possible_encoders that will contain symbolic links to the possible encoders for the connector. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 +

[PATCH v3 12/16] drm/vkms: Allow to configure the default device creation

2025-03-07 Thread José Expósito
Add a new module param to allow to create or not the default VKMS instance. Useful when combined with configfs to avoid having additional VKMS instances. Reviewed-by: Louis Chauvet Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c | 7 +++ 1 file changed, 7 insertions(+) dif

[PATCH v3 02/16] drm/vkms: Add and remove VKMS instances via configfs

2025-03-07 Thread José Expósito
Allow to create, enable, disable and destroy VKMS instances using configfs. For the moment, it is not possible to add pipeline items, so trying to enable the device will fail printing an informative error to the log. Reviewed-by: Louis Chauvet Co-developed-by: Louis Chauvet Signed-off-by: Louis

[PATCH v3 01/16] drm/vkms: Expose device creation and destruction

2025-03-07 Thread José Expósito
In preparation for configfs support, expose vkms_create() and vkms_destroy(). Reviewed-by: Louis Chauvet Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c | 4 ++-- drivers/gpu/drm/vkms/vkms_drv.h | 20 +++

[PATCH v3 07/16] drm/vkms: Allow to attach planes and CRTCs via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/planes/plane/possible_crtcs that will contain symbolic links to the possible CRTCs for the plane. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 9 + drivers/gpu/

[PATCH v3 10/16] drm/vkms: Allow to configure multiple connectors via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/connectors to allow to create as many connectors as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 87 +

[PATCH v3 15/16] drm/vkms: Allow to update the connector status

2025-03-07 Thread José Expósito
Implement the drm_connector_funcs.detect() callback to update the connector status by returning the status stored in the configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_connector.c | 28 +++ drivers/gpu/drm/vkms/vkms_connector.h | 3 +++ 2 files

[PATCH v3 14/16] drm/vkms: Allow to configure connector status

2025-03-07 Thread José Expósito
Allow to store the connector status in vkms_config_connector and add a getter and a setter functions as well a KUnit test. This change only adds the configuration, the connector status is not used yet. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/tests/vkms_config_test.c | 24 +

[PATCH v3 16/16] drm/vkms: Allow to configure connector status via configfs

2025-03-07 Thread José Expósito
When a connector is created, add a `status` file to allow to update the connector status to: - 1 connector_status_connected - 2 connector_status_disconnected - 3 connector_status_unknown If the device is enabled, updating the status hot-plug or unplugs the connector. Signed-off-by: José Expós

Re: [PATCH] drm/sti: fix inconsistent indenting warning

2025-03-07 Thread Raphaël Gallais-Pou
Le 05/03/2025 à 11:16, Charles Han a écrit : Fix below inconsistent indenting smatch warning. smatch warnings: drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting Signed-off-by: Charles Han Hi, Acked-by: Raphaël Gallais-Pou Thanks, Raphaël --- drivers/gpu/dr

[PATCH v3 00/16] drm/vkms: Add configfs support

2025-03-07 Thread José Expósito
Hi everyone, This series allow to configure one or more VKMS instances without having to reload the driver using configfs. The series is structured in 3 blocks: - Patches 1..11: Basic device configuration. For simplicity, I kept the available options as minimal as possible. - Patches 12

[PATCH v3 05/16] drm/vkms: Allow to configure multiple CRTCs via configfs

2025-03-07 Thread José Expósito
Create a default subgroup at /config/vkms/crtcs to allow to create as many CRTCs as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 85 +++

Re: [RFC v3 01/33] rust: drm: Add a small handful of fourcc bindings

2025-03-07 Thread Maxime Ripard
Hi, On Wed, Mar 05, 2025 at 05:59:17PM -0500, Lyude Paul wrote: > This adds some very basic rust bindings for fourcc. We only have a single > format code added for the moment, but this is enough to get a driver > registered. > > Signed-off-by: Lyude Paul > > --- > V3: > * Drop FormatList and Mo

  1   2   3   >