Re: [PATCH v1 drm-dp 1/4] drm/hisilicon/hibmc: Add dp phy cfg to adjust serdes rate, voltage and pre-emphasis

2025-02-05 Thread Yongbang Shi
On Mon, Jan 27, 2025 at 11:20:21AM +0800, Yongbang Shi wrote: From: Baihan Li This phy is inited and configured for dp, and integrating them into dp init and dp link training process. My feeling is that this patch has too many changes. They might seem related to you, but not to the reviewers.

Re: [PATCH v1 drm-dp 2/4] drm/hisilicon/hibmc: Getting connector info and edid by using aux channel

2025-02-05 Thread Yongbang Shi
On Mon, Jan 27, 2025 at 11:20:22AM +0800, Yongbang Shi wrote: From: Baihan Li Registering drm_aux and using it to get connector edid with drm functions. Refactoring some structs to fit aux's register framework. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- drivers/gpu/drm/hisili

Re: [RFC 0/1] drm/mm: Introduce address space shifting

2025-02-05 Thread Christian König
Am 04.02.25 um 23:41 schrieb Tomasz Lis: This RFC asks for introduction of an interface which allows to shift a range managed by drm_mm instance without repeating the node list creation. What do you mean with "shift" here? As far as I can see from the code you just modify the start address of

[PATCH v2 1/3] drm/ci: uprev mesa

2025-02-05 Thread Vignesh Raman
Uprev mesa to adapt to the latest changes in mesa ci which includes new container jobs and stages. Also update lava-submit script to adapt to the recent changes in mesa to use LAVA rootfs overlays. Signed-off-by: Vignesh Raman --- v2: - Uprev mesa to the latest version and update the yaml file

[PATCH v2 3/3] drm/ci: update expectation files

2025-02-05 Thread Vignesh Raman
Update expectation files for the mesa uprev. Signed-off-by: Vignesh Raman --- v2: - New commit in v2. --- drivers/gpu/drm/ci/xfails/vkms-none-fails.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ci/xfails/vkms-none-fails.txt b/drivers/gpu/drm/ci/xfails/vkms-none-f

Re: [PATCH v1 drm-dp 3/4] drm/hisilicon/hibmc: Add debugfs interface to enable colorbar feature and get link status

2025-02-05 Thread Yongbang Shi
On Mon, Jan 27, 2025 at 11:20:23AM +0800, Yongbang Shi wrote: From: Baihan Li Create 3 files in drm debugfs: This definitely needs to be split. Hi Dmitry, Right, I got it. I will split any patch which has mutiple fileds changing blended together. colorbar-cfg: Get/Set colorbar cfg What

[PATCH v2 2/3] drm/ci: update gitlab rules

2025-02-05 Thread Vignesh Raman
Update gitlab rules to include scheduled pipelines. Signed-off-by: Vignesh Raman --- v2: - No changes. --- drivers/gpu/drm/ci/build.yml | 1 - drivers/gpu/drm/ci/gitlab-ci.yml | 116 +-- drivers/gpu/drm/ci/test.yml | 26 +++ 3 files changed, 63 in

[PATCH v2 0/3] drm/ci: uprev mesa and modify gitlab rules

2025-02-05 Thread Vignesh Raman
Uprev mesa to adapt to the latest changes in mesa-ci, including new container jobs and stages. Update the lava-submit script to align with recent mes-ci changes for using LAVA rootfs overlays. Modify gitLab rules to include scheduled pipelines. Also update the expectation files. Pipeline link, htt

RE: [PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of Abel > Vesa > Sent: Monday, February 3, 2025 4:28 PM > To: Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Simona Vetter ; Karol > Herbst ; Lyude Paul ; Danilo > Krummrich ; Jani Nikula ; > Vivi, Rodrigo ; Joo

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Erik Faye-Lund
On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > Unfortunately, this goes in the opposite direction than what I was asked to do here:

[PATCH v4 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-02-05 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 56 -- 1 file changed, 41 insertions(+), 15 delet

Re: [PATCH] dt-bindings: gpu: arm,mali-midgard: add exynos7870-mali compatible

2025-02-05 Thread Krzysztof Kozlowski
On Tue, Feb 04, 2025 at 02:02:55AM +0530, Kaustabh Chakraborty wrote: > Exynos7870 SoC uses the ARM Mali T830 GPU, document its compatible > string with the appropriate fallback. The T830 compatible is already > defined in the panfrost driver, but was commented out as it was unused. > > Signed-off

Re: [PATCH v1 drm-dp 4/4] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-05 Thread Yongbang Shi
On Mon, Jan 27, 2025 at 11:20:24AM +0800, Yongbang Shi wrote: From: Baihan Li This is a series of functions about getting dp connector status function, registering irq function, interrupt handler function, and hpd event process function to realize DP HPD feature. Please follow the Documentatio

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-02-05 Thread Maxime Ripard
On Mon, Jan 27, 2025 at 11:48:23AM +0100, Louis Chauvet wrote: > On 26/01/25 - 18:06, Maxime Ripard wrote: > > On Tue, Jan 21, 2025 at 11:48:06AM +0100, Louis Chauvet wrote: > > > +static struct yuv_u8_to_argb_u16_case yuv_u8_to_argb_u16_cases[] = { > > > + /* > > > + * colour.RGB_to_YCbCr(, > > >

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Geert Uytterhoeven
Hi Biju, On Wed, 5 Feb 2025 at 11:20, Biju Das wrote: > > -Original Message- > > From: Thierry Reding > > On Tue, Feb 04, 2025 at 03:33:53PM +, Biju Das wrote: > > > > -Original Message- > > > > From: Thierry Reding > > > > On Tue, Feb 04, 2025 at 09:07:05AM +, Biju Das

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Biju Das
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 05 February 2025 10:25 > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > Hi Biju, > > On Wed, 5 Feb 2025 at 11:20, Biju Das wrote: > > > -Original Message- > > > From: Thierry Reding On Tu

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Alice Ryhl
On Wed, Feb 5, 2025 at 12:30 AM Rob Herring (Arm) wrote: > > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Reviewed-by: Alice Ryhl

[PATCH v4 2/3] drm/plane: modify create_in_formats to accommodate async

2025-02-05 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/drm_plane.c | 40

[PATCH v4 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-02-05 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flips are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flips

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-05 Thread Krzysztof Kozlowski
On 05/02/2025 03:51, Dmitry Baryshkov wrote: > On Tue, Feb 04, 2025 at 04:46:04PM +0100, Krzysztof Kozlowski wrote: >> On 04/02/2025 15:26, Dmitry Baryshkov wrote: >>> On Tue, Feb 04, 2025 at 10:21:25AM +0100, Krzysztof Kozlowski wrote: On 03/02/2025 18:41, Dmitry Baryshkov wrote: > On Mon

[PATCH] drm/scheduler: Remove some unused prototypes

2025-02-05 Thread Tvrtko Ursulin
As far as I can tell some removed prototypes were introduced by probably bad conflict resolution in fc58764bbf60 ("Merge tag 'amd-drm-next-6.2-2022-11-18' of https://gitlab.freedesktop.org/agd5f/linux into drm-next"). Remove them. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Kr

[Bug 200531] amdgpu: *ERROR* REG_WAIT timeout when a display is put to sleep

2025-02-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200531 Ramses VdP (ram...@well-founded.dev) changed: What|Removed |Added CC||ram...@well-founded

[RFC] drm/scheduler: Remove mention of TDR from scheduler API

2025-02-05 Thread Tvrtko Ursulin
Christian suggests scheduler should not use the term TDR because it only can do basic timeout detection on it's own, not the full blown timeout- detection-and-recovery (TDR) as the term is generally understood. Attempt to rename it to a more basic drm_sched_trigger_timeout. Signed-off-by: Tvrtko

Re: [PATCH v3 1/2] dt-bindings: drm/bridge: Add no-hpd property

2025-02-05 Thread Krzysztof Kozlowski
On 05/02/2025 12:50, Harikrishna Shenoy wrote: > From: Rahul T R > > The mhdp bridge can work without its HPD pin hooked up to the connector, > but the current bridge driver throws an error when hpd line is not > connected to the connector. For such cases, we need an indication for > no-hpd, usin

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-02-05 Thread Louis Chauvet
On 05/02/25 - 09:55, Maxime Ripard wrote: > On Mon, Jan 27, 2025 at 11:48:23AM +0100, Louis Chauvet wrote: > > On 26/01/25 - 18:06, Maxime Ripard wrote: > > > On Tue, Jan 21, 2025 at 11:48:06AM +0100, Louis Chauvet wrote: > > > > +static struct yuv_u8_to_argb_u16_case yuv_u8_to_argb_u16_cases[] = {

Re: [PATCH] drm/panel: sharp-ls060t1sx01: transition to mipi_dsi wrapped functions

2025-02-05 Thread Doug Anderson
Hi, On Mon, Feb 3, 2025 at 9:59 AM Doug Anderson wrote: > > Hi, > > On Sat, Feb 1, 2025 at 10:55 AM Tejas Vipin wrote: > > > > Changes the sharp-ls060t1sx01 panel to use multi style functions for > > Not worth spinning for this, but s/Changes/Change/ > > > improved error handling. > > > > Signed

[PATCH 0/8] Enable Aux based Nits brightness control for eDP

2025-02-05 Thread Suraj Kandpal
>From eDP 1.5 we are supposed to use the VESA pathways to control brightness. But still did not have the Nits brightness control coded in. This series enables NITS based backlight control over AUX using VESA pathways. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3669 Signed-off-by

Re: [RFC 3/5] drm/scheduler: Add a simple TDR test

2025-02-05 Thread Tvrtko Ursulin
On 04/02/2025 16:21, Christian König wrote: Am 03.02.25 um 16:30 schrieb Tvrtko Ursulin: Add a very simple TDR test which submits a single job and verifies that the TDR handling will run if the backend failed to complete the job in time. I think I said it before but I strongly suggest to not

Re: [PATCH v1 drm-dp 3/4] drm/hisilicon/hibmc: Add debugfs interface to enable colorbar feature and get link status

2025-02-05 Thread Dmitry Baryshkov
On 5 February 2025 10:18:00 EET, Yongbang Shi wrote: >> On Mon, Jan 27, 2025 at 11:20:23AM +0800, Yongbang Shi wrote: >>> From: Baihan Li >>> >>> Create 3 files in drm debugfs: >> This definitely needs to be split. > >Hi Dmitry, > >Right, I got it. I will split any patch which has mutiple fileds

[PATCH v7] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V

2025-02-05 Thread Damon Ding
The raw edid for LP079QX1-SP0V panel model is: 00 ff ff ff ff ff ff 00 16 83 00 00 00 00 00 00 04 17 01 00 a5 10 0c 78 06 ef 05 a3 54 4c 99 26 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 ea 4e 00 4c 60 00 14 80 0c 10 84 00 78 a0 00 00 00 18 00 00 00 10 00 00 00 00 00 00 00 00

Re: [RFC PATCH 3/5] dt-bindings: gpu: Add protected heap name to Mali Valhall CSF binding

2025-02-05 Thread Krzysztof Kozlowski
On 03/02/2025 16:31, Florent Tomasin wrote: > Hi Krzysztof > > On 30/01/2025 13:25, Krzysztof Kozlowski wrote: >> On 30/01/2025 14:08, Florent Tomasin wrote: >>> Allow mali-valhall-csf driver to retrieve a protected >>> heap at probe time by passing the name of the heap >>> as attribute to the dev

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Biju Das
Hi Thierry Reding, > -Original Message- > From: Thierry Reding > Sent: 04 February 2025 18:02 > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > On Tue, Feb 04, 2025 at 03:33:53PM +, Biju Das wrote: > > Hi Thierry Reding, > > > > > -Original Message- > >

[PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-02-05 Thread Biju Das
The of_get_child_by_name() increments the refcount in tegra_dc_rgb_probe, but the driver does not decrement the refcount during unbind. Fix the unbound reference count using devm_add_action_or_reset() helper. Fixes: d8f4a9eda006 ("drm: Add NVIDIA Tegra20 support") Signed-off-by: Biju Das --- dri

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-05 Thread Dmitry Baryshkov
Hi, On Wed, 5 Feb 2025 at 11:34, Krzysztof Kozlowski wrote: > > On 05/02/2025 03:51, Dmitry Baryshkov wrote: > > On Tue, Feb 04, 2025 at 04:46:04PM +0100, Krzysztof Kozlowski wrote: > >> On 04/02/2025 15:26, Dmitry Baryshkov wrote: > >>> On Tue, Feb 04, 2025 at 10:21:25AM +0100, Krzysztof Kozlows

RE: [PATCH 4/7] drm/i915/backlight: Modify function to get VESA brightness in Nits

2025-02-05 Thread Murthy, Arun R
> Modify vesa_get_brightness function to take into account > luminance_control_support and based on that read the appropriate register > and return the value. > > --v2 > -Changes since we now use luminance instead of nits > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- > .../drm/i9

Re: [PATCH 14/14] Documentation: Update the todo

2025-02-05 Thread Anusha Srivatsa
On Fri, Jan 31, 2025 at 7:53 AM Thomas Zimmermann wrote: > Hi Maxime > > > Am 29.01.25 um 15:31 schrieb Maxime Ripard: > > Hi Thomas, > > > > On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > >> Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > >>> Remove the TODO now that this s

On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-05 Thread Simona Vetter
On Tue, Feb 04, 2025 at 03:46:14AM +0900, Hector Martin wrote: > Adding Linus > > My 2c: If Linus doesn't pipe up with an authoritative answer to this > thread, Miguel and the other Rust folks should just merge this series > once it is reviewed and ready, ignoring Christoph's overt attempt at > sa

RE: [PATCH 3/8] drm/i915/backlight: Use proper interface based on eDP version

2025-02-05 Thread Murthy, Arun R
> eDP is supposed to use VESA interface when using revision 1.5 and above, use > Intel interface for backlight control otherwise. Add check to use correct > interface. > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy -

[PATCH v13 13/13] drm/rockchip: vop2: Add support for rk3576

2025-02-05 Thread Andy Yan
From: Andy Yan VOP2 on rk3576: Three video ports: VP0 Max 4096x2160 VP1 Max 2560x1600 VP2 Max 1920x1080 2 4K Cluster windows with AFBC/RFBC, line RGB and YUV 4 Esmart windows with line RGB/YUV support: Esmart0/1: 4K Esmart2/3: 2k, or worked together as a single 4K plane at shared line buffer mod

[PATCH v13 08/13] drm/rockchip: vop2: Set plane possible crtcs by possible vp mask

2025-02-05 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a window cannot attach to all Video Ports, we introduce a possible_vp_mask for every window to indicate which Video Ports this window can attach to. Signed-off-by: Andy Yan Tested-by: Michael Riesch # on RK3568 Tested-by: Detlev Casanova --- (no

Re: [RFC] drm/scheduler: Remove mention of TDR from scheduler API

2025-02-05 Thread Matthew Brost
On Wed, Feb 05, 2025 at 01:44:48PM +0100, Christian König wrote: > Am 05.02.25 um 12:14 schrieb Tvrtko Ursulin: > > Christian suggests scheduler should not use the term TDR because it only > > can do basic timeout detection on it's own, not the full blown timeout- > > detection-and-recovery (TDR) a

RE: [PATCH 4/8] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Murthy, Arun R
> Check if we are capable of controlling brightness via luminance which is > dependent on PANEL_LUMINANCE_CONTROL_CAPABLE bit being set on > EDP_GENERAL_CAPABILITY_2 register. > > --v2 > -Prefer using luminance rather than nits [Jani] -Fix commit message > > --v3 > -Fix the bit name used in commi

[PATCH v13 12/13] dt-bindings: display: vop2: Add rk3576 support

2025-02-05 Thread Andy Yan
From: Andy Yan Add vop found on rk3576, the main difference between rk3576 and the previous vop is that each VP has its own interrupt line. Signed-off-by: Andy Yan --- Changes in v13: - Use maxItems constraint for clocks in allOf block Changes in v12: - Split from patch 10/13 Changes in v11

RE: [PATCH 2/8] drm/dp: Increase eDP display control capability size

2025-02-05 Thread Murthy, Arun R
> Increase the eDP display control capability size to take into account the > general > capability register 703 and 704 that have recently been added. > > Signed-off-by: Suraj Kandpal > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy > include/drm/display

[PATCH 8/8] drm/i915/backlight: Enable nits based luminance

2025-02-05 Thread Suraj Kandpal
Enable nits based luminance by writing the PANEL_LUMINANCE_CONTROL bit and set the correct register to change brightness. Signed-off-by: Suraj Kandpal Tested-by: Ben Kao Reviewed-by: Arun R Murthy --- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 +++ 1 file changed, 15 in

[PATCH 4/8] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Suraj Kandpal
Check if we are capable of controlling brightness via luminance which is dependent on PANEL_LUMINANCE_CONTROL_CAPABLE bit being set on EDP_GENERAL_CAPABILITY_2 register. --v2 -Prefer using luminance rather than nits [Jani] -Fix commit message --v3 -Fix the bit name used in commit message [Arun] -

Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG_reclaim

2025-02-05 Thread Sergey Senozhatsky
On (25/02/03 10:39), Kirill A. Shutemov wrote: > > Hi, I'm seeing following panic with SWAP after this commit: > > > > [ 29.672319] Oops: general protection fault, probably for > > non-canonical address 0x88909a3be3: [#1] PREEMPT SMP NOPTI > > [ 29.675503] CPU: 82 UID: 0 PID: 5145 Comm

[PATCH 3/8] drm/i915/backlight: Use proper interface based on eDP version

2025-02-05 Thread Suraj Kandpal
eDP is supposed to use VESA interface when using revision 1.5 and above, use Intel interface for backlight control otherwise. Add check to use correct interface. Signed-off-by: Suraj Kandpal Tested-by: Ben Kao --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 8 +++- 1 file change

[PATCH 6/8] drm/i915/backlight: Add function to change brightness in nits for VESA

2025-02-05 Thread Suraj Kandpal
Create a function that fills in the value for PANEL_TARGET_LUMINANCE_VALUE which helps in changing the luminance in nits using VESA interface. --v2 -Prefer using luminance over nits [Jani] Signed-off-by: Suraj Kandpal Tested-by: Ben Kao Reviewed-by: Arun R Murthy --- .../drm/i915/display/inte

RE: [PATCH 1/8] drm/dp: Add eDP 1.5 bit definition

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, February 6, 2025 12:03 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Kao, Ben ; Kandpal, Suraj > > Subject: [PATCH 1/8] d

[PATCH] drm/bridge: convert to use devm_platform_ioremap_resource()

2025-02-05 Thread oushixiong1025
From: Shixiong Ou convert to use devm_platform_ioremap_resource(). Signed-off-by: Shixiong Ou --- drivers/gpu/drm/bridge/microchip-lvds.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c ind

[PATCH v13 02/13] drm/rockchip: vop2: Rename TRANSFORM_OFFSET to TRANSFORM_OFFS

2025-02-05 Thread Andy Yan
From: Andy Yan This help avoid "exceeds 100 columns" warning from checkpatch Signed-off-by: Andy Yan --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8 drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) d

[PATCH v13 11/13] dt-bindings: display: vop2: Add missing rockchip, grf property for rk3566/8

2025-02-05 Thread Andy Yan
From: Andy Yan The clock polarity of RGB signal output is controlled by GRF, this property is already being used in the current device tree, but forgot to describe it as a required property in the binding file. Signed-off-by: Andy Yan --- Changes in v13: - Fix typo - Explain the function of t

[PATCH v13 03/13] drm/rockchip: vop2: Add platform specific callback

2025-02-05 Thread Andy Yan
From: Andy Yan The VOP interface mux, overlay, background delay cycle configuration of different SOC are much different. Add platform specific callback ops to let the core driver look cleaner and more refined. Signed-off-by: Andy Yan Tested-by: Michael Riesch # on RK3568 Tested-by: Detlev Casa

[PATCH v13 05/13] drm/rockchip: vop2: Support for different layer select configuration between VPs

2025-02-05 Thread Andy Yan
From: Andy Yan In the upcoming VOP for rk3576, every VP has it's own LAYER_SEL register, and the configuration value of each VP for the same window maybe different, so extend the layer_sel_id to array, let it can descption the layer select configuration value for different VP. Signed-off-by: And

[PATCH v13 06/13] drm/rockchip: vop2: Introduce vop hardware version

2025-02-05 Thread Andy Yan
From: Andy Yan There is a version number hardcoded in the VOP VERSION_INFO register, and the version number increments sequentially based on the production order of the SOC. So using this version number to distinguish different VOP features will simplify the code. Signed-off-by: Andy Yan Teste

[PATCH v13 00/13] VOP Support for rk3576

2025-02-05 Thread Andy Yan
From: Andy Yan PATCH 1~9 are preparations for rk3576 support PATCH 10~13 are real support for rk376 I test it with a 1080P/4K HDMI output with modetest and weston output. If there are some one want to have a try, I have a tree based on Linux 6.14-rc1 here[0] [0]https://github.com/andyshrk/lin

RE: [PATCH 2/8] drm/dp: Increase eDP display control capability size

2025-02-05 Thread Kandpal, Suraj
> -Original Message- > From: Murthy, Arun R > Sent: Thursday, February 6, 2025 12:13 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Shankar, Uma ; Kao, Ben > Subject: RE: [PATCH 2/8] drm/dp: Increase eD

[PATCH v13 01/13] drm/rockchip: vop2: use devm_regmap_field_alloc for cluster-regs

2025-02-05 Thread Andy Yan
From: Heiko Stuebner Right now vop2_cluster_init() copies the base vop2_cluster_regs and adapts the reg value with the current window's offset before adding the fields to the regmap. This conflicts with the notion of reg_fields being const, see https://lore.kernel.org/all/20240706-regmap-const-s

[PATCH v13 07/13] drm/rockchip: vop2: Register the primary plane and overlay plane separately

2025-02-05 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports, so make sure all VP find it's suitable primary plane, then register the remain windows as overlay plane will make code easier. Signed-off-by: Andy Yan Tested-by: Michael Riesch # on RK3568 Tested-by: Detle

[PATCH v13 04/13] drm/rockchip: vop2: Merge vop2_cluster/esmart_init function

2025-02-05 Thread Andy Yan
From: Andy Yan Now these two function share the same logic, the can be merged as one. Signed-off-by: Andy Yan --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 42 +--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/rock

[PATCH v13 10/13] dt-bindings: display: vop2: describe constraint SoC by SoC

2025-02-05 Thread Andy Yan
From: Andy Yan As more SoCs variants are introduced, each SoC brings its own unique set of constraints, describe this constraints SoC by SoC will make things easier. Signed-off-by: Andy Yan --- Changes in v13: - Add maxItems constraint for clocks - Remove constraint for interrupts in allOf bl

[PATCH v13 09/13] drm/rockchip: vop2: Add uv swap for cluster window

2025-02-05 Thread Andy Yan
From: Andy Yan The Cluster windows of upcoming VOP on rk3576 also support linear YUV support, we need to set uv swap bit for it. As the VOP2_WIN_UV_SWA register defined on rk3568/rk3588 is 0x, so this register will not be touched on these two platforms. Signed-off-by: Andy Yan Tested-b

Re: [PATCH 12/12] Documentation: Update the todo

2025-02-05 Thread Thomas Zimmermann
Hi Am 05.02.25 um 21:08 schrieb Anusha Srivatsa: Update the Documentation to be more precise. v2: Update for clarity Cc: Thomas Zimmermann Signed-off-by: Anusha Srivatsa --- Documentation/gpu/todo.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Docume

[PATCH 7/8] drm/i915/backlight: Setup nits based luminance via VESA

2025-02-05 Thread Suraj Kandpal
Modify backlight setup function for VESA interface to take into account the nits based luminance. --v2 -Prefer using luminance over nits [Jani] Signed-off-by: Suraj Kandpal Tested-by: Ben Kao Reviewed-by: Arun R Murthy --- .../drm/i915/display/intel_dp_aux_backlight.c | 99 +++

[PATCH 2/8] drm/dp: Increase eDP display control capability size

2025-02-05 Thread Suraj Kandpal
Increase the eDP display control capability size to take into account the general capability register 703 and 704 that have recently been added. Signed-off-by: Suraj Kandpal --- include/drm/display/drm_dp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/display/d

[PATCH 1/8] drm/dp: Add eDP 1.5 bit definition

2025-02-05 Thread Suraj Kandpal
Add the eDP revision bit value for 1.5. Spec: eDPv1.5 Table 16-5 Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy Tested-by: Ben Kao --- include/drm/display/drm_dp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 480

[PATCH 5/8] drm/i915/backlight: Modify function to get VESA brightness in Nits

2025-02-05 Thread Suraj Kandpal
Modify vesa_get_brightness function to take into account luminance_control_support and based on that read the appropriate register and return the value. --v2 -Changes since we now use luminance instead of nits Signed-off-by: Suraj Kandpal Tested-by: Ben Kao Reviewed-by: Arun R Murthy --- .../

Re: [PATCH v5 3/5] drm: panel: Add a panel driver for the Summit display

2025-02-05 Thread Neil Armstrong
On 05/02/2025 23:10, Sasha Finkelstein via B4 Relay wrote: From: Sasha Finkelstein This is the display panel used for the touchbar on laptops that have it. Co-developed-by: Nick Chan Signed-off-by: Nick Chan Signed-off-by: Sasha Finkelstein --- drivers/gpu/drm/panel/Kconfig| 9 +

Re: [PATCH v5 0/5] Driver for pre-DCP apple display controller.

2025-02-05 Thread Neil Armstrong
On 05/02/2025 23:10, Sasha Finkelstein via B4 Relay wrote: Hi. This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of the "touchbar" touch panel present on those. Signed-off-by: Sasha Finkelstein --- LGTM should patches

[pull] amdgpu drm-fixes-6.14

2025-02-05 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b: Linux 6.14-rc1 (2025-02-02 15:39:26 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-02-05 for you to fe

[PATCH v5 2/5] drm: adp: Add Apple Display Pipe driver

2025-02-05 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein This display controller is present on M-series chips and is used to drive the touchbar display. Co-developed-by: Janne Grunau Signed-off-by: Janne Grunau Signed-off-by: Sasha Finkelstein --- drivers/gpu/drm/Kconfig| 2 + drivers/gpu/drm/Makefile | 1

[PATCH v5 5/5] MAINTAINERS: Add entries for touchbar display driver

2025-02-05 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein Add the MAINTAINERS entries for the driver Acked-by: Sven Peter Signed-off-by: Sasha Finkelstein --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a87ddad78e26f28ffd0f3433560d6db1518f9f95..4ce0d3bcf67910d909ba4126

[PATCH v5 0/5] Driver for pre-DCP apple display controller.

2025-02-05 Thread Sasha Finkelstein via B4 Relay
Hi. This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of the "touchbar" touch panel present on those. Signed-off-by: Sasha Finkelstein --- Changes in v5: - Moved to using the component framework. - Other lifetime fixes -

[PATCH v5 3/5] drm: panel: Add a panel driver for the Summit display

2025-02-05 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein This is the display panel used for the touchbar on laptops that have it. Co-developed-by: Nick Chan Signed-off-by: Nick Chan Signed-off-by: Sasha Finkelstein --- drivers/gpu/drm/panel/Kconfig| 9 +++ drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/

[PATCH v5 1/5] dt-bindings: display: Add Apple pre-DCP display controller

2025-02-05 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein Add bindings for a secondary display controller present on certain Apple laptops. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sasha Finkelstein --- .../display/apple,h7-display-pipe-mipi.yaml| 83 .../bindings/display/apple,h7-display-p

[PATCH v5 4/5] arm64: dts: apple: Add touchbar screen nodes

2025-02-05 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein Adds device tree entries for the touchbar screen Co-developed-by: Janne Grunau Signed-off-by: Janne Grunau Reviewed-by: Nick Chan Signed-off-by: Sasha Finkelstein --- arch/arm64/boot/dts/apple/t8103-j293.dts | 31 arch/arm64/boot/dts/apple/t8103.dtsi

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Rob Herring
On Wed, Feb 5, 2025 at 8:17 AM Erik Faye-Lund wrote: > > On Wed, 2025-02-05 at 11:53 +0100, Erik Faye-Lund wrote: > > On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > > > Use an enum instead of #defines for panthor IOCTLs. This allows the > > > header to be used with Rust code as bind

Re: [PATCH v3 02/10] drm/display: add CEC helpers code

2025-02-05 Thread Dmitry Baryshkov
On Wed, Feb 05, 2025 at 03:27:05PM +0100, Maxime Ripard wrote: > On Tue, Jan 28, 2025 at 02:17:19PM +0200, Dmitry Baryshkov wrote: > > On Tue, Jan 28, 2025 at 11:36:06AM +0100, Maxime Ripard wrote: > > > On Sun, Jan 26, 2025 at 03:29:07PM +0200, Dmitry Baryshkov wrote: > > > > Add generic CEC helpe

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Maxime Ripard
On Mon, Feb 03, 2025 at 04:43:23PM +, Florent Tomasin wrote: > Hi Maxime, Nicolas > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > >> Hi Nicolas, > >> > >> On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrote: >

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Nicolas Dufresne
Le mercredi 05 février 2025 à 15:53 +0100, Maxime Ripard a écrit : > On Tue, Feb 04, 2025 at 01:22:58PM -0500, Nicolas Dufresne wrote: > > Le lundi 03 février 2025 à 16:43 +, Florent Tomasin a écrit : > > > Hi Maxime, Nicolas > > > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > > Le

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Nicolas Dufresne
Le mercredi 05 février 2025 à 15:52 +0100, Maxime Ripard a écrit : > On Mon, Feb 03, 2025 at 04:43:23PM +, Florent Tomasin wrote: > > Hi Maxime, Nicolas > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > > > > Hi Nicolas

Re: [PATCH v2 2/2] gpu: nova-core: add initial documentation

2025-02-05 Thread Miguel Ojeda
On Wed, Feb 5, 2025 at 2:57 PM Zhi Wang wrote: > > It would be also helpful to make the process explicit. E.g. sharing your > command lines used to checking the patches. So folks can align with the > expected outcome, e.g. command line parameters. These two guidelines (and generally the few other

Re: [PATCH v1] MAINTAINERS: Update drm/ci maintainers

2025-02-05 Thread Helen Mae Koike Fornazier
On Wed, 05 Feb 2025 10:47:47 -0300 Vignesh Raman wrote --- > Update drm/ci maintainer entries: > > * Add myself as drm/ci maintainer. > * Update Helen's email address. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com> > --- > MAINTAINERS | 3 ++- > 1 file

Re: [PATCH v2 0/3] drm/ci: uprev mesa and modify gitlab rules

2025-02-05 Thread Helen Mae Koike Fornazier
On Wed, 05 Feb 2025 05:16:45 -0300 Vignesh Raman wrote --- > Uprev mesa to adapt to the latest changes in mesa-ci, > including new container jobs and stages. Update the > lava-submit script to align with recent mes-ci changes > for using LAVA rootfs overlays. Modify gitLab rules

Re: [PATCH v3 01/10] drm/connector: add CEC-related fields

2025-02-05 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 03:12:41PM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 28, 2025 at 11:33:05AM +0100, Maxime Ripard wrote: > > On Sun, Jan 26, 2025 at 03:29:06PM +0200, Dmitry Baryshkov wrote: > > > As a preparation to adding HDMI CEC helper code, add CEC-related fields > > > to the struct

Re: [PATCH v3 09/10] drm/bridge: allow limiting I2S formats

2025-02-05 Thread Maxime Ripard
On Wed, Jan 29, 2025 at 01:45:56AM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 28, 2025 at 05:11:16PM +0100, Maxime Ripard wrote: > > On Sun, Jan 26, 2025 at 03:29:14PM +0200, Dmitry Baryshkov wrote: > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > > index > > > b55e80a5

Re: [PATCH v2 2/2] gpu: nova-core: add initial documentation

2025-02-05 Thread Zhi Wang
On Tue, 4 Feb 2025 20:03:12 +0100 Danilo Krummrich wrote: > Add the initial documentation of the Nova project. > > The initial project documentation consists out of a brief introduction > of the project, as well as project guidelines both general and nova-core > specific and a task list for nov

RE: [PATCH 2/7] drm/i915/backlight: Use proper interface based on eDP version

2025-02-05 Thread Murthy, Arun R
> eDP is supposed to use VESA interface when using revision 1.5 and above, use > Intel interface for backlight control otherwise. Add check to use correct > interface. > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy -

Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum

2025-02-05 Thread Erik Faye-Lund
On Wed, 2025-02-05 at 11:53 +0100, Erik Faye-Lund wrote: > On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote: > > Use an enum instead of #defines for panthor IOCTLs. This allows the > > header to be used with Rust code as bindgen can't handle complex > > defines. > > > > > Unfortunately

Re: [PATCH v16 2/7] drm/ttm/pool, drm/ttm/tt: Provide a helper to shrink pages

2025-02-05 Thread Christian König
Am 30.01.25 um 11:13 schrieb Thomas Hellström: Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to ba

Re: [PATCH v1] MAINTAINERS: Update drm/ci maintainers

2025-02-05 Thread Daniel Stone
On Wed, 5 Feb 2025 at 13:48, Vignesh Raman wrote: > Update drm/ci maintainer entries: > > * Add myself as drm/ci maintainer. > * Update Helen's email address. Acked-by: Daniel Stone

Re: [PATCH v3 02/10] drm/display: add CEC helpers code

2025-02-05 Thread Maxime Ripard
On Tue, Jan 28, 2025 at 02:17:19PM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 28, 2025 at 11:36:06AM +0100, Maxime Ripard wrote: > > On Sun, Jan 26, 2025 at 03:29:07PM +0200, Dmitry Baryshkov wrote: > > > Add generic CEC helpers to be used by HDMI drivers. Both notifier and > > > and adapter are

RE: [PATCH 3/7] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Murthy, Arun R
> Check if we are capable of controlling brightness via luminance which is > dependent on PANEL_LUMINANCE_OVERRIDE being set. > Is PANEL_LUMINANCE_OVERRIDE a macro? I don't see this definition! > --v2 > -Prefer using luminance rather than nits [Jani] -Fix commit message > > Signed-off-by: Suraj

Re: [PATCH v3 1/2] drm/bridge: it6505: add support DRM_BRIDGE_OP_HDMI to drm_bridge

2025-02-05 Thread Dmitry Baryshkov
On Wed, Feb 05, 2025 at 02:41:03PM +0800, Hermes Wu via B4 Relay wrote: > From: Hermes Wu > > Add DRM_BRIDGE_OP_HDMI to bridge.ops and implement necessary callback > functions. Wait Now I feel really sorry. I stumbled upon HDMI_related bits and then I thought that it's a HDMI bridge without

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-05 Thread Dmitry Baryshkov
On Wed, Feb 05, 2025 at 02:42:03PM +0100, Krzysztof Kozlowski wrote: > On 05/02/2025 12:23, Dmitry Baryshkov wrote: > + > +static void dsi_pll_disable_global_clk(struct dsi_pll_7nm *pll) > +{ > +dsi_pll_cmn_clk_cfg1_update(pll, BIT(5), 0); > } >

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Maxime Ripard
On Tue, Feb 04, 2025 at 01:22:58PM -0500, Nicolas Dufresne wrote: > Le lundi 03 février 2025 à 16:43 +, Florent Tomasin a écrit : > > Hi Maxime, Nicolas > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > > > > Hi Nicolas

Re: [PATCH v2 2/2] gpu: nova-core: add initial documentation

2025-02-05 Thread Zhi Wang
On Wed, 5 Feb 2025 15:13:12 +0100 Miguel Ojeda wrote: > On Wed, Feb 5, 2025 at 2:57 PM Zhi Wang wrote: > > > > It would be also helpful to make the process explicit. E.g. sharing your > > command lines used to checking the patches. So folks can align with the > > expected outcome, e.g. command l

Re: [PATCH] drm/amd: Refactor find_system_memory()

2025-02-05 Thread Felix Kuehling
On 2025-02-05 14:31, Mario Limonciello wrote: > On 2/4/2025 17:19, Felix Kuehling wrote: >> >> On 2025-02-04 17:21, Mario Limonciello wrote: >>> From: Mario Limonciello >>> >>> find_system_memory() pulls out two fields from an SMBIOS type 17 >>> device and sets them on KFD devices. This however

[PATCH 10/12] drm/tiny: move to devm_platform_ioremap_resource() usage

2025-02-05 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

  1   2   >