Re: [PATCH v4] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-21 Thread Rodrigo Vivi
On Sat, Jan 18, 2025 at 06:47:27PM +0100, Michal Wajdeczko wrote: > > > On 17.01.2025 22:57, Vinay Belgaumkar wrote: > > Default SLPC power profile is Base(0). Power Saving mode(1) > > has conservative up/down thresholds and is suitable for use with > > apps that typically need to be power effici

[PATCH RFC v3 06/14] drm/vkms: Introduce configfs for crtc and encoder

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to configure CRTCs and encoders. The CRTCs and encoders are created in their own directory. To link the CRTC, symlinks are used in the `possible_crtcs` folders. The current interface is: /config/vkms DE

[PATCH RFC v3 01/14] drm/vkms: Add vkms_delete/create_device helper

2025-01-21 Thread Louis Chauvet
In preparation for introduction of ConfigFS support, expose the vkms_destroy/create helper to remove a vkms device. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.c | 4 ++-- drivers/gpu/drm/vkms/vkms_drv.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/d

[PATCH RFC v3 03/14] drm/vkms: Introduce ConfigFS interface

2025-01-21 Thread Louis Chauvet
VKMS is manly used to test userspace program and its behavior. The current implementation is not very configurable as you can only have one device, with few specific planes. This is the introduction of a basic interface to dynamically create new devices. The new interface is: /config/vkms DEVIC

[PATCH RFC v3 05/14] drm/vkms: Introduce configfs for plane rotation

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to configure the available rotation per planes. VKMS supports any rotation and reflection, so the userspace can choose any combination. The supported rotations are configured by writing a rotation bitmask to the

[PATCH RFC v3 04/14] drm/vkms: Introduce configfs for plane

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to create and configure planes. The planes are created by creating a directory in the `planes` directory. The type of plane is configured by writing 0 (Overlay), 1 (primary) or 2 (cursor) in the file `type`. As

[PATCH RFC v3 12/14] drm/vkms: Introduce configfs for connector id

2025-01-21 Thread Louis Chauvet
A connector can't be identified by a name, so add a configfs file to retrieve its id. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_configfs.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_c

[PATCH RFC v3 10/14] drm/vkms: Introduce configfs for device name

2025-01-21 Thread Louis Chauvet
To allows the userspace to identify the device once it is enabled, create a file to fetch it. This file can only be read once the device is enabled, and will return the device name, which can later be used to use it. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_configfs.c | 16 +++

[PATCH RFC v3 09/14] drm/vkms: Introduce configfs for plane format

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to configure the available formats per planes. VKMS supports many formats, so the userspace can choose any combination of them. The supported formats are configured by writing in the file supported_formats: - `+

[PATCH RFC v3 08/14] drm/vkms: Introduce configfs for connector type

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to change a connector type. The type of a connector can be changed by editing the file type and by writing the connector type number. The current interface is: /config/vkms DEVICE_1 ┣━ enable

[PATCH RFC v3 07/14] drm/vkms: Introduce configfs for connectors

2025-01-21 Thread Louis Chauvet
To allows the userspace to test many hardware configuration, introduce a new interface to create and configure connectors. The connectors are created by creating a directory in the `connectors` directory. Connectors and encoders can be linked by creating a symlink in the possible_encoders directo

[PATCH RFC v3 00/14] drm/vkms: ConfigFS interface

2025-01-21 Thread Louis Chauvet
e aims to be extendable (new property can easly be added in objects) and easy to use (objects are created simply by creating folders, and configured by writing files). This series depends on https://lore.kernel.org/all/20250121-google-remove-crtc-index-from-parameter-v3-0-cac00a3c3...@bootlin.com/ S

[PATCH RFC v3 02/14] drm/vkms: Cleanup configuration field on device destroy

2025-01-21 Thread Louis Chauvet
To avoid having dangling pointers in struct vkms_config, remove all of them when the device is destroyed. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 23 +++ drivers/gpu/drm/vkms/vkms_config.h | 3 ++- drivers/gpu/drm/vkms/vkms_drv.c| 2 +- 3 f

[PATCH RFC v3 11/14] drm/vkms: Introduce configfs for connector status

2025-01-21 Thread Louis Chauvet
As a connector can be connected and disconnected once a device is created, create a file to allow changing this status. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_configfs.c | 45 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH RFC v3 13/14] drm/vkms: Introduce configfs for connector EDID

2025-01-21 Thread Louis Chauvet
Due to limitation of ConfigFS, the max len of EDID is PAGE_SIZE (4kB on x86), it should be sufficient for many tests. One possible evolution is using a ConfigFS blob to allow bigger EDID. The EDID can be changed at any time. As for physical display, you need to trigger an HPD event to refresh the

[PATCH RFC v3 14/14] drm/vkms: Introduce configfs for encoder type

2025-01-21 Thread Louis Chauvet
In order to support multiple configuration, add the possibility to change the encoder type. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_configfs.c | 57 1 file changed, 57 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/driv

[PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Guenter Roeck
The scale() functions detects invalid parameters, but continues its calculations anyway. This causes bad results if negative values are used for unsigned operations. Worst case, a division by 0 error will be seen if source_min == source_max. On top of that, after v6.13, the sequence of WARN_ON() f

[PATCH v2 3/3] drm/sched: Update timedout_job()'s documentation

2025-01-21 Thread Philipp Stanner
drm_sched_backend_ops.timedout_job()'s documentation is outdated. It mentions the deprecated function drm_sched_resubmit_job(). Furthermore, it does not point out the important distinction between hardware and firmware schedulers. Since firmware schedulers tyipically only use one entity per schedu

[PATCH v2 2/3] drm/sched: Adjust outdated docu for run_job()

2025-01-21 Thread Philipp Stanner
The documentation for drm_sched_backend_ops.run_job() mentions a certain function called drm_sched_job_recovery(). This function does not exist. What's actually meant is drm_sched_resubmit_jobs(), which is by now also deprecated. Remove the mention of the removed function. Discourage the behavior

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-21 Thread Jeffrey Hugo
On 1/20/2025 10:16 PM, Manivannan Sadhasivam wrote: On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed-b

[PATCH] drm/bridge: Use devm_platform_get_and_ioremap_resource()

2025-01-21 Thread oushixiong1025
From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- drivers/gpu/drm/bridge/microchip-lvds.c| 5 ++--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/

Re: [RFC v3 09/18] drm/imagination: Add reset controller support for GPU initialization

2025-01-21 Thread Philipp Zabel
On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Certain platforms, such as the T-Head TH1520 and Banana Pi BPI-F3, > require a controlled GPU reset sequence during the power-up procedure > to ensure proper initialization. Without this reset, the GPU may remain > in an undefined state,

Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-21 Thread Philipp Zabel
On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This > controller manages resets for subsystems such as the GPU within the > TH1520 SoC. This mentions "resets", plural, but the #reset-cells = <0> below and the driver implem

Re: [RFC v3 08/18] reset: thead: Add TH1520 reset controller driver

2025-01-21 Thread Philipp Zabel
On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Introduce reset controller driver for the T-HEAD TH1520 SoC. The > controller manages hardware reset lines for various SoC subsystems, such > as the GPU. This statement is confusing, given the implementation only handles a single (GPU) r

Re: [RFC v3 11/18] dt-bindings: gpu: Add compatibles for T-HEAD TH1520 GPU

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:21:04PM +0100, Michal Wilczynski wrote: >reg: > maxItems: 1 > @@ -25,11 +30,8 @@ properties: > maxItems: 3 > >clock-names: > -items: > - - const: core > - - const: mem > - - const: sys > minItems: 1 > +maxItems: 3 So what i

Re: [RFC v3 10/18] dt-bindings: gpu: Add 'resets' property for GPU initialization

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:21:03PM +0100, Michal Wilczynski wrote: > Many RISC-V boards featuring Imagination Technologies GPUs require a > reset line to be de-asserted as part of the GPU power-up sequence. To > support this, add a 'resets' property (and corresponding 'reset-names') > to the GPU de

Re: [RFC v3 16/18] riscv: dts: thead: Introduce power domain nodes with aon firmware

2025-01-21 Thread Krzysztof Kozlowski
On 20/01/2025 18:21, Michal Wilczynski wrote: > The DRM Imagination GPU requires a power-domain driver. In the T-HEAD > TH1520 SoC implements power management capabilities through the E902 > core, which can be communicated with through the mailbox, using firmware > protocol. > > Add AON node, whic

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-21 Thread Philipp Zabel
Hi, On Mo, 2025-01-20 at 08:58 +0100, Thomas Zimmermann wrote: > Hi > > > Am 18.01.25 um 03:37 schrieb Marek Olšák: > [...] > > > > 3) Implementing DRM_FORMAT_MOD_LINEAR as having 256B pitch and offset > > alignment. This is what we do today. Even if Intel and some AMD chips > > can do 64B or

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov wrote: > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: > > While working on the generic mode_valid() implementation for the HDMI > > Connector framework I noticed that unlike other DRM objects > > drm_connector accepts non-

Re: [PATCH 3/4] drm/sched: Remove to_drm_sched_job internal helper

2025-01-21 Thread Tvrtko Ursulin
On 20/01/2025 17:17, Danilo Krummrich wrote: On Mon, Jan 20, 2025 at 04:52:39PM +, Tvrtko Ursulin wrote: The code assumes queue node is the first element in struct drm_sched_job. I'd add that this assumption lies in doing the NULL check after the container_of(). Without saying that, it m

Re: [RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock controller support

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:20:54PM +0100, Michal Wilczynski wrote: > properties: >compatible: > -const: thead,th1520-clk-ap > +enum: > + - thead,th1520-clk-ap > + - thead,th1520-clk-vo > >reg: > maxItems: 1 > >clocks: > items: > - - description: mai

Re: [PATCH RFC] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 12:06:15AM +0100, Marijn Suijten wrote: > Some SoCs such as SC7280 (used in the FairPhone 5) have only a single > DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology > (2 LM and 2 DSC for a single interface) make it impossible to use > Display Stream Compr

Re: [PATCH 2/2] drm/bridge: nwl-dsi: Set bridge type

2025-01-21 Thread Dmitry Baryshkov
On Mon, Jan 20, 2025 at 02:21:35PM +0100, Alexander Stein wrote: > This is a DSI bridge, so set the bridge type accordingly. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/nwl-dsi.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov -- With best wishe

Re: [PATCH 1/2] drm/bridge: ti-sn65dsi83: Set bridge type

2025-01-21 Thread Dmitry Baryshkov
On Mon, Jan 20, 2025 at 02:21:34PM +0100, Alexander Stein wrote: > This is a DSI to LVDS bridge, so set the bridge type accordingly. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov -- Wi

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
Hi Dmitry, CC sfr On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov wrote: > On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote: > > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov > > wrote: > > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: > > > > While working on the ge

Re: [PATCH 8/8] drm/ast: Only warn about unsupported TX chips on Gen4 and later

2025-01-21 Thread Thomas Zimmermann
Hi Am 20.01.25 um 11:37 schrieb Jocelyn Falempe: On 17/01/2025 11:29, Thomas Zimmermann wrote: Only Gen4 and later read the installed TX chip from the SoC. So only warn on those generations about unsupported chips. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Thanks for revi

Re: [PATCH] fbdev/sh_mobile_lcdcfb: Use backlight helper

2025-01-21 Thread Helge Deller
On 1/21/25 07:42, oushixiong1...@163.com wrote: From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) That patch did not apply any longer to git head. I fixed it up manually and applied it to fbde

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-01-21 Thread Andy Shevchenko
On Tue, Jan 21, 2025 at 08:33:09AM +0100, Marek Szyprowski wrote: > On 17.01.2025 18:28, Andy Shevchenko wrote: > > On Fri, Jan 17, 2025 at 05:05:42PM +0100, Marek Szyprowski wrote: > > Does it fail in the same way? > > Yes, the hw revision is reported as zero in this case: LT9611 revision: > 0x

Re: [PATCH v9 0/8] drm/vkms: Switch all vkms object to DRM managed objects

2025-01-21 Thread Louis Chauvet
On 16/01/25 - 18:47, Louis Chauvet wrote: > To simplify the memory managment, this series replace all manual drm > object managment by drm-managed one. This way the VKMS code don't have to > manage it directly and the DRM core will handle the object destruction. > > No functional changes are inten

Re: [RFC v3 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 0fa7c5728f1e..c56a1fb6e02a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20184,6 +20184,7 @@ M:Fu Wei > L: linux-ri...@lists.infradead.org > S: Maintained > T: gi

Re: [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

2025-01-21 Thread Ulf Hansson
On Mon, 20 Jan 2025 at 18:21, Michal Wilczynski wrote: > > The T-Head TH1520 SoC contains multiple power islands that can be > programmatically turned on and off using the AON (Always-On) protocol > and a hardware mailbox [1]. The relevant mailbox driver has already been > merged into the mainline

Re: [PATCH] drm/bridge: it6505: support hdmi_codec_ops for audio stream setup

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 04:59:22PM +0800, Hermes Wu via B4 Relay wrote: > From: Hermes Wu > > IT6505 supports audio form I2S to DP audio data sub stream > > Support audio codec operation include > hw_params, audio_startup, audio_shutdown, hook_plugged_cb. The DRM framework recently got generic

Re: [PATCH] drm/aspeed: Use devm_platform_get_and_ioremap_resource()

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 03:50:41PM +0800, oushixiong1...@163.com wrote: > From: Shixiong Ou > Missing commit message > Signed-off-by: Shixiong Ou This doesn't match your email address, so SoB is missing. -- With best wishes Dmitry

Re: [PATCH] drm/bridge: Use devm_platform_get_and_ioremap_resource()

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 04:13:36PM +0800, oushixiong1...@163.com wrote: > From: Shixiong Ou > Missing commit message > Signed-off-by: Shixiong Ou This doesn't match your email address, so SoB is missing. > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- > drivers/gpu/drm/

Re: [PATCH v4 0/3] drm/vkms: Switch to allocated for drm objects

2025-01-21 Thread Louis Chauvet
On 17/01/25 - 10:04, Louis Chauvet wrote: > Specific allocations for each DRM object is not strictly needed in VKMS > right now, but in order to implement dynamic configuration of VKMS > (configFS), it will be easier to have one allocation per DRM object. > > There is no need for a dynamic allocat

Re: [PATCH v7 11/12] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2025-01-21 Thread Dmitry Baryshkov
On Mon, Jan 20, 2025 at 11:18:22PM +0530, Aradhya Bhatia wrote: > Hi Dmitry, > > On 20/01/25 14:08, Dmitry Baryshkov wrote: > > On Fri, Jan 17, 2025 at 06:37:00PM +0530, Aradhya Bhatia wrote: > >> Hi Dmitry, > >> > >> On 14/01/25 16:54, Dmitry Baryshkov wrote: > >>> On Tue, Jan 14, 2025 at 11:26:2

[PATCH] drm/bridge: it6505: support hdmi_codec_ops for audio stream setup

2025-01-21 Thread Hermes Wu via B4 Relay
From: Hermes Wu IT6505 supports audio form I2S to DP audio data sub stream Support audio codec operation include hw_params, audio_startup, audio_shutdown, hook_plugged_cb. In order to prevent pop noise from sink devise, delay audio by after I2S signal is enable by source. Signed-off-by: Hermes

Re: [PATCH v4] drm/bridge: it6505: fix HDCP V match check is not performed correctly

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 03:01:51PM +0800, Hermes Wu via B4 Relay wrote: > From: Hermes Wu > > Fix a typo where V compare incorrectly compares av[] with av[] itself, > which can result in HDCP failure. > > The loop of V compare is expected to iterate for 5 times > which compare V array form av[0]

Re: [PATCH 2/3] drm/display/dp: Define function to setup Extended wake time

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 11:35:21AM +0530, Suraj Kandpal wrote: > Extended wake timeout request helps to give additional > time by reading the DPCD register through which sink requests the > minimal amount of time required to wake the sink up. > Source device shall keep retying the AUX tansaction t

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 12:10:25PM +0100, Geert Uytterhoeven wrote: > Hi Dmitry, > > CC sfr > > On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov > wrote: > > On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven > > wrote: > > > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov > > > wrote: > > >

Re: [PATCH v5 08/10] drm/bridge: samsung-dsim: use supporting variable for out_bridge

2025-01-21 Thread Luca Ceresoli
Hi Maxime, On Thu, 16 Jan 2025 13:26:25 +0100 Maxime Ripard wrote: [...] > > And then there is the panel bridge. My understanding (which I'd love to > > get clarified in case it is not accurate) is that DRM bridges expect to > > always interact with "the next bridge", which cannot work for the

Re: [PATCH v5 08/10] drm/bridge: samsung-dsim: use supporting variable for out_bridge

2025-01-21 Thread Luca Ceresoli
Hi Dmitry, On Thu, 16 Jan 2025 12:56:25 +0200 Dmitry Baryshkov wrote: [...] > > Idea 3: > > > > The idea is that if the panel driver framework always creates a panel > > bridge, it will never need to be created on the fly automagically by > > its consumers, so the whole problem would disappea

Re: [PATCH v3 4/5] drm/i915/display: Populate list of async supported formats/modifiers

2025-01-21 Thread Ville Syrjälä
On Tue, Jan 21, 2025 at 03:34:20AM +, Murthy, Arun R wrote: > > On Wed, Jan 08, 2025 at 11:09:02AM +0530, Arun R Murthy wrote: > > > Populate the list of formats/modifiers supported by async flip. > > > Register a async property and expose the same to user through blob. > > > > > > Signed-off-b

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-21 Thread Alexander Gordeev
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: Hi Joel, > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifi

[PATCH] drm/panel: samsung-s6e88a0-ams452ef01: transition to mipi_dsi wrapped functions

2025-01-21 Thread Tejas Vipin
Changes the samsung-s6e88a0-ams452ef01 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- .../panel/panel-samsung-s6e88a0-ams452ef01.c | 89 +++ 1 file changed, 31 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/panel/pane

[PATCH v2 1/3] drm/sched: Document run_job() refcount hazard

2025-01-21 Thread Philipp Stanner
From: Philipp Stanner drm_sched_backend_ops.run_job() returns a dma_fence for the scheduler. That fence is signalled by the driver once the hardware completed the associated job. The scheduler does not increment the reference count on that fence, but implicitly expects to inherit this fence from

[PATCH v2 0/3] drm/sched: Documentation and refcount improvements

2025-01-21 Thread Philipp Stanner
Changes in v2: - Document what run_job() is allowed to return. (Tvrtko) - Delete confusing comment about putting the fence. (Danilo) - Apply Danilo's RB to patch 1. - Delete info about job recovery for entities in patch 3. (Danilo, me) - Set the term "ring" as fix term for both HW rings a

Re: [PATCH] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Jani Nikula
On Mon, 20 Jan 2025, Guenter Roeck wrote: > The scale() functions detects invalid parameters, but continues > its calculations anyway. This causes bad results if negative values > are used for unsigned operations. Worst case, a division by 0 error > will be seen if source_min == source_max. > > On

Re: [PATCH] drm/panic: fix compilation issue on ARM

2025-01-21 Thread Alice Ryhl
On 1/20/25 10:52 PM, Miguel Ojeda wrote: Hi Emmanuel, On Mon, Jan 20, 2025 at 1:45 PM Emmanuel Gil Peyrot wrote: In C, the char type is specified with “The implementation shall define char to have the same range, representation, and behavior as either signed char or unsigned char.” On x86 it

Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-21 Thread Michal Wilczynski
On 1/21/25 09:35, Philipp Zabel wrote: > On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: >> Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This >> controller manages resets for subsystems such as the GPU within the >> TH1520 SoC. > > This mentions "resets", plural, but

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Rodrigo Vivi
On Tue, Jan 21, 2025 at 06:52:03AM -0800, Guenter Roeck wrote: > The scale() functions detects invalid parameters, but continues > its calculations anyway. This causes bad results if negative values > are used for unsigned operations. Worst case, a division by 0 error > will be seen if source_min =

[PATCH v5 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-01-21 Thread Werner Sembach
The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via WMI. To make the backlight userspace configurable this driver emulates a LampArray HID device and translates the input from hidraw to the corre

[PATCH v5 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2025-01-21 Thread Werner Sembach
Hi, after some other work, picked this up again. Only coding style changes vs v4. I now got my feet a little wet with hid-bpf regarding something else, and with that knowledge I would leave the long arrays in the beginning in the kernel code for the time being: sirius_16_ansii_kbl_mapping and si

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Linus Torvalds
On Tue, 21 Jan 2025 at 14:59, Rodrigo Vivi wrote: > > I'm pushing this soon to drm-intel-next, unless Linus want to take > this one directly to his tree Let's just go through the proper channels and go through the drm tree. Unless I've issed something, I think this is only an active issue on par

Re: [PATCH v4 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2025-01-21 Thread Rodrigo Vivi
On Tue, Jan 21, 2025 at 11:09:34AM -0800, Alan Previn wrote: > The GuC-Error-Capture is currently reaching into xe_devcoredump > structure to store its own place-holder snaphot to workaround > the race between G2H-Error-Capture-Notification vs Drm-Scheduler > triggering GuC-Submission-exec-queue-ti

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-21 Thread Simona Vetter
On Mon, Jan 20, 2025 at 03:48:04PM -0400, Jason Gunthorpe wrote: > On Mon, Jan 20, 2025 at 07:50:23PM +0100, Simona Vetter wrote: > > On Mon, Jan 20, 2025 at 01:59:01PM -0400, Jason Gunthorpe wrote: > > > On Mon, Jan 20, 2025 at 01:14:12PM +0100, Christian König wrote: > > > What is going wrong wit

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-21 Thread 陳柏霖

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-21 Thread Manivannan Sadhasivam
On Tue, Jan 21, 2025 at 08:29:32AM -0700, Jeffrey Hugo wrote: > On 1/20/2025 10:16 PM, Manivannan Sadhasivam wrote: > > On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: > > > Add basic support for the new AIC200 product. The PCIe Device ID is > > > 0xa110. With this, we can turn on the

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-21 Thread 陳柏霖

Re: [PATCH] drm/panel: samsung-s6e88a0-ams452ef01: transition to mipi_dsi wrapped functions

2025-01-21 Thread Doug Anderson
Hi, On Tue, Jan 21, 2025 at 5:48 AM Tejas Vipin wrote: > > @@ -136,12 +113,8 @@ static int s6e88a0_ams452ef01_prepare(struct drm_panel > *panel) > static int s6e88a0_ams452ef01_unprepare(struct drm_panel *panel) > { > struct s6e88a0_ams452ef01 *ctx = to_s6e88a0_ams452ef01(panel); > -

[PATCH] drm/print: Include drm_device.h

2025-01-21 Thread Gustavo Sousa
The header drm_print.h uses members of struct drm_device pointers, as such, it should include drm_device.h to let the compiler know the full type definition. Without such include, users of drm_print.h that don't explicitly need drm_device.h would bump into build errors and be forced to include the

Re: [PATCH v3 00/30] Introduce GPU SVM and Xe SVM implementation

2025-01-21 Thread Matthew Brost
On Fri, Jan 17, 2025 at 11:47:41AM +0200, Gwan-gyeong Mun wrote: > Hi, > This kernel oops, which I reported before, was caused by my incorrect > modification (incorrect applying of review comments) of this patch > "[v3,19/30] drm/xe: Add SVM device memory mirroring" > ( the kernel oops occurred bec

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-21 Thread Jeffrey Hugo
On 1/21/2025 10:06 AM, Manivannan Sadhasivam wrote: On Tue, Jan 21, 2025 at 08:29:32AM -0700, Jeffrey Hugo wrote: On 1/20/2025 10:16 PM, Manivannan Sadhasivam wrote: On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: Add basic support for the new AIC200 product. The PCIe Device ID i

Re: [RFC PATCH 01/12] dma-buf: Introduce dma_buf_get_pfn_unlocked() kAPI

2025-01-21 Thread Jason Gunthorpe
On Tue, Jan 21, 2025 at 05:11:32PM +0100, Simona Vetter wrote: > On Mon, Jan 20, 2025 at 03:48:04PM -0400, Jason Gunthorpe wrote: > > On Mon, Jan 20, 2025 at 07:50:23PM +0100, Simona Vetter wrote: > > > On Mon, Jan 20, 2025 at 01:59:01PM -0400, Jason Gunthorpe wrote: > > > > On Mon, Jan 20, 2025 at

Re: [PATCH RFC] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-01-21 Thread Luca Weiss
Hi Marijn, On Tue Jan 21, 2025 at 12:06 AM CET, Marijn Suijten wrote: > Some SoCs such as SC7280 (used in the FairPhone 5) have only a single > DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology > (2 LM and 2 DSC for a single interface) make it impossible to use > Display Strea

[PATCH v2] drm: drm_fourcc: adding 10/12/14 bit formats

2025-01-21 Thread Yulia Garbovich
Adding the following formats - DRM_FORMAT_RX106 - DRM_FORMAT_GXRX106106 - DRM_FORMAT_RX124 - DRM_FORMAT_GXRX124124 - DRM_FORMAT_AXBXGXRX124124124124 - DRM_FORMAT_RX142 - DRM_FORMAT_GXRX142142 - DRM_FORMAT_AXBXGXRX142142142142 They are useful for communicatin

Re: [git pull] drm for 6.14-rc1 (sending early due to holidays)

2025-01-21 Thread pr-tracker-bot
The pull request you sent on Fri, 17 Jan 2025 15:22:44 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2025-01-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/96c84703f1cf6ea43617f9565166681cd71df104 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH 09/35] drm/msm/dpu: remove DSPP_SC7180_MASK

2025-01-21 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: Stop declaring DPU_DSPP_PCC as a part of the DSPP features, use the presence of the PCC sblk to check whether PCC is present in the hardware or not. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h |

Re: [PATCH 10/35] drm/msm/dpu: get rid of DPU_CTL_HAS_LAYER_EXT4

2025-01-21 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: Continue migration to the MDSS-revision based checks and replace DPU_CTL_HAS_LAYER_EXT4 feature bit with the core_major_ver >= 9 check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 12 ++---

Re: [PATCH 09/35] drm/msm/dpu: remove DSPP_SC7180_MASK

2025-01-21 Thread Dmitry Baryshkov
Hi Abhinav, On Wed, 22 Jan 2025 at 02:28, Abhinav Kumar wrote: > > > > On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: > > Stop declaring DPU_DSPP_PCC as a part of the DSPP features, use the > > presence of the PCC sblk to check whether PCC is present in the hardware > > or not. > > > > Signed-off

Re: [PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2025-01-21 Thread Louis Chauvet
On 21/01/25 - 11:45, José Expósito wrote: > On Mon, Jan 20, 2025 at 06:26:07PM +0100, Louis Chauvet wrote: > > On 20/01/25 - 17:23, José Expósito wrote: > > > > A specific allocation for the CRTC is not strictly necessary at this > > > > point, but in order to implement dynamic configuration of VKM

Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-21 Thread Zack Rusin
On Tue, Jan 21, 2025 at 2:11 PM Ian Forbes wrote: > > On Fri, Jan 17, 2025 at 1:20 PM Zack Rusin wrote: > > > > You're going to have to explain that one in the commit message a lot > > better because as is it doesn't make sense to me. Especially the > > !vbo->is_dumb in vmw_bo_free. > > > > z > >

[PATCH v4 1/1] drm/xe/guc/capture: Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2025-01-21 Thread Alan Previn
The order of the devcoredump event flow is: drm-scheduler -> guc-submission-execq-timed-out-job -> guc-submission-kill-job -> xe-devcoredump (once the work is confirmed to have been killed). As we are aware, the GuC-FW IRQ for error-capture delivery and extraction could have happened before the st

Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-21 Thread Ian Forbes
On Fri, Jan 17, 2025 at 1:20 PM Zack Rusin wrote: > > You're going to have to explain that one in the commit message a lot > better because as is it doesn't make sense to me. Especially the > !vbo->is_dumb in vmw_bo_free. > > z The dirty tracker is freed later in vmw_bo_release when it's a cohere

[PATCH v4 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2025-01-21 Thread Alan Previn
The GuC-Error-Capture is currently reaching into xe_devcoredump structure to store its own place-holder snaphot to workaround the race between G2H-Error-Capture-Notification vs Drm-Scheduler triggering GuC-Submission-exec-queue-timeout/kill. Part of that race workaround design included GuC-Error-C

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-21 Thread Marek Olšák
On Mon, Jan 20, 2025 at 1:41 PM Simona Vetter wrote: > On Mon, Jan 20, 2025 at 08:58:20AM +0100, Thomas Zimmermann wrote: > > Hi > > > > > > Am 18.01.25 um 03:37 schrieb Marek Olšák: > > [...] > > > > > > 3) Implementing DRM_FORMAT_MOD_LINEAR as having 256B pitch and offset > > > alignment. This

Re: [PATCH v7 11/12] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2025-01-21 Thread Aradhya Bhatia
Hi Dmitry, On 21/01/25 16:20, Dmitry Baryshkov wrote: > On Mon, Jan 20, 2025 at 11:18:22PM +0530, Aradhya Bhatia wrote: >> Hi Dmitry, >> >> On 20/01/25 14:08, Dmitry Baryshkov wrote: >>> On Fri, Jan 17, 2025 at 06:37:00PM +0530, Aradhya Bhatia wrote: Hi Dmitry, On 14/01/25 16:54, Dm

Re: [RFC PATCH 08/12] vfio/pci: Create host unaccessible dma-buf for private device

2025-01-21 Thread Jason Gunthorpe
On Tue, Jun 25, 2024 at 05:12:10AM +0800, Xu Yilun wrote: > When VFIO works as a TEE user in VM, it means an attester (e.g. PCI > subsystem) has already moved the device to RUN state. So VFIO & DPDK > are all TEE users, no need to manipulate TDISP state between them. > AFAICS, this is the most pre

Re: [RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock controller support

2025-01-21 Thread Michal Wilczynski
On 1/21/25 10:47, Krzysztof Kozlowski wrote: > On Mon, Jan 20, 2025 at 06:20:54PM +0100, Michal Wilczynski wrote: >> properties: >>compatible: >> -const: thead,th1520-clk-ap >> +enum: >> + - thead,th1520-clk-ap >> + - thead,th1520-clk-vo >> >>reg: >> maxItems: 1

Re: [RFC v3 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node

2025-01-21 Thread Michal Wilczynski
On 1/21/25 10:52, Krzysztof Kozlowski wrote: > On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 0fa7c5728f1e..c56a1fb6e02a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -20184,6 +20184,7 @@ M: Fu Wei >> L: linux-r

Re: [RFC v3 04/18] firmware: thead: Add AON firmware protocol driver

2025-01-21 Thread Michal Wilczynski
On 1/21/25 10:56, Krzysztof Kozlowski wrote: > On Mon, Jan 20, 2025 at 06:20:57PM +0100, Michal Wilczynski wrote: >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include > > How/where do you use this header? Indeed, it's used by the power-domain d

Re: [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

2025-01-21 Thread Michal Wilczynski
On 1/21/25 11:02, Krzysztof Kozlowski wrote: > On Mon, Jan 20, 2025 at 06:20:58PM +0100, Michal Wilczynski wrote: >> The T-Head TH1520 SoC contains multiple power islands that can be >> programmatically turned on and off using the AON (Always-On) protocol >> and a hardware mailbox [1]. The relev

Re: [RFC v3 04/18] firmware: thead: Add AON firmware protocol driver

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:20:57PM +0100, Michal Wilczynski wrote: > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include How/where do you use this header? > + > +#define MAX_RX_TIMEOUT (msecs_to_jiffies(3000)) > +#define MAX_TX_TIMEOUT 500 > + > +struct th

Re: [RFC v3 05/18] pmdomain: thead: Add power-domain driver for TH1520

2025-01-21 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 06:20:58PM +0100, Michal Wilczynski wrote: > The T-Head TH1520 SoC contains multiple power islands that can be > programmatically turned on and off using the AON (Always-On) protocol > and a hardware mailbox [1]. The relevant mailbox driver has already been > merged into the

[PATCH v3 03/16] drm/vkms: Move default_config creation to its own function

2025-01-21 Thread Louis Chauvet
Extract the initialization of the default configuration to a function. Refactor, no functional changes. Signed-off-by: Louis Chauvet [Changes: Cherry pick and solve conflicts] Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 15 +++ drivers/gpu/drm/vkms/vkms_con

[PATCH v3 04/16] drm/vkms: Introduce config for plane

2025-01-21 Thread Louis Chauvet
The current vkms driver only allows the usage of one primary, eight overlays and one cursor plane. This new configuration structure aims to make the configuration more flexible. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 92 -- drive

[PATCH v3 02/16] drm/vkms: Add a validation function for vkms configuration

2025-01-21 Thread Louis Chauvet
As the configuration will be used by userspace, add a validator to avoid creating a broken DRM device Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 6 ++ drivers/gpu/drm/vkms/vkms_config.h | 13 + 2 files changed, 19 insertions(+) diff --git a/drivers/gp

[PATCH v3 07/16] drm/vkms: Introduce config for CRTCs and encoders

2025-01-21 Thread Louis Chauvet
The current VKMS driver can only uses one CRTC and one encoder. This patch introduce in the same time CRTC and encoders as they are tighly linked. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 269 + drivers/gpu/drm/vkms/vkms_config.h |

[PATCH v3 09/16] drm/vkms: Introduce config for CRTC name

2025-01-21 Thread Louis Chauvet
As a CRTC will be a directory in ConfigFS, add the name configuration for CRTC name so we will be able to reflect the configfs directory name in the drm name. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 5 + drivers/gpu/drm/vkms/vkms_config.h | 2 ++ drivers/gpu/drm

[PATCH v3 00/16] drm/vkms: Introduce detailed configuration

2025-01-21 Thread Louis Chauvet
The current code is not flexible to configure the VKMS device. In preparation for ConfigFS interface introduce few structure that can be used to configure the device creation: `vkms_config`. This part is splitted from the ConfigFS implementation itself to avoid mixing two complex interfaces. The

  1   2   >