Re: [PATCH v6 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-12-12 Thread Maxime Ripard
On Mon, 9 Dec 2024 11:39:13 +0800, Liu Ying wrote: > i.MX8qxp Display Controller display engine consists of all processing > units that operate in a display clock domain. Add minimal feature > support with FrameGen and TCon so that the engine can output display > timings. The FrameGen driver, TCo

Re: [PATCH v6 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-12-12 Thread Maxime Ripard
On Mon, 9 Dec 2024 11:39:14 +0800, Liu Ying wrote: > i.MX8qxp Display Controller pixel engine consists of all processing > units that operate in the AXI bus clock domain. Add drivers for > ConstFrame, ExtDst, FetchLayer, FetchWarp and LayerBlend units, as > well as a pixel engine driver, so that t

Re: [PATCH v6 11/19] drm/imx: Add i.MX8qxp Display Controller interrupt controller

2024-12-12 Thread Maxime Ripard
On Mon, 9 Dec 2024 11:39:15 +0800, Liu Ying wrote: > i.MX8qxp Display Controller has a built-in interrupt controller to support > Enable/Status/Preset/Clear interrupt bit. Add driver for it. > > Signed-off-by: Liu Ying Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v6 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-12 Thread Maxime Ripard
On Mon, 9 Dec 2024 11:39:16 +0800, Liu Ying wrote: > i.MX8qxp Display Controller(DC) is comprised of three main components that > include a blit engine for 2D graphics accelerations, display controller for > display output processing, as well as a command sequencer. Add kernel > mode setting suppo

Re: [v9,1/6] drm/panic: Move drawing functions to drm_draw

2024-12-12 Thread Jocelyn Falempe
On 11/12/2024 22:34, Kees Bakker wrote: Op 04-12-2024 om 16:45 schreef Jocelyn Falempe: Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Joce

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-12 Thread neil . armstrong
On 11/12/2024 15:42, Johan Hovold wrote: On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: +/** + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode + * @aux: DisplayPort AUX channel + * @enable: Enable or disable transparent mode + * + * Returns 0 on success or

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-12 Thread Johan Hovold
On Thu, Dec 12, 2024 at 09:31:09AM +0100, neil.armstr...@linaro.org wrote: > On 11/12/2024 15:42, Johan Hovold wrote: > >> +EXPORT_SYMBOL(drm_dp_lttpr_set_transparent_mode); > > > > This appears to be what the driver currently uses, but why not > > EXPORT_SYMBOL_GPL? > > drivers/gpu/drm/display/

Re: [PATCH 14/26] drm/xe/eudebug: implement userptr_vma access

2024-12-12 Thread Thomas Hellström
On Mon, 2024-12-09 at 16:31 +0100, Simona Vetter wrote: > On Mon, Dec 09, 2024 at 03:03:04PM +0100, Christian König wrote: > > Am 09.12.24 um 14:33 schrieb Mika Kuoppala: > > > From: Andrzej Hajda > > > > > > Debugger needs to read/write program's vmas including > > > userptr_vma. > > > Since hmm

Re: [PATCH v9 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-12 Thread Jocelyn Falempe
t;Default DRM Client" and then it starts scrolling endlessly. https://download.01.org/0day-ci/archive/20241212/202412121555.fp663tyh-...@intel.com/config regards, dan carpenter From e4d197debd2c199c9f2d8e35e41e36c2836926b9 Mon Sep 17 00:00:00 2001 From: Jocelyn Falempe Date: Thu, 12 Dec 2024 0

Re: [PATCH v3 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 04:59, Abhinav Kumar wrote: > > > > On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > > Having I/O regions inside a msm_dp_catalog_private() results in extra > > layers of one-line wrappers for accessing the data. Move I/O region base > > and size to the globally visible stru

Re: [PATCH v9 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-12 Thread Dan Carpenter
On Thu, Dec 12, 2024 at 09:49:19AM +0100, Jocelyn Falempe wrote: > On 12/12/2024 08:41, Dan Carpenter wrote: > > This patch breaks "make oldconfig" for me. It just gets into an endless > > loop of: > > > >Default DRM Client > >choice[1-0?]: 0 > >Default DRM Client > >choice[1-0?]:

Re: [PATCH v3 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 05:26, Abhinav Kumar wrote: > > > > On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > > All other submodules pass arguments directly. Drop struct > > msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass > > all data to msm_dp_panel_get() directly. > > > > R

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Marc Zyngier
On Thu, 12 Dec 2024 05:31:00 +, Pavan Kondeti wrote: > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > On Wed, 11 Dec 2024 00:37:34 +, > > Pavan Kondeti wrote: > > > > > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > > > > +static int a6xx_switch

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 05:12, Abhinav Kumar wrote: > > > > On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > > to program audio packet data. Use 0 as Packet ID, as it was not > > programmed earlier. > > > > Reviewed-by: St

Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-12 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote: > > > On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > > Rather than printing random garbage from stack and pretending that it is > > the default safe_to_exit_level, set the variable beforehand. > > > > Fixes: d13e36d7d222 ("drm/msm/

Re: [PATCH v1 06/10] drm/bridge: analogix_dp: Add support for phy configuration.

2024-12-12 Thread Damon Ding
Hi Dmitry, On 2024/11/30 16:53, Dmitry Baryshkov wrote: On Wed, Nov 27, 2024 at 03:51:53PM +0800, Damon Ding wrote: Add support to configurate link rate, lane count, voltage swing and pre-emphasis with phy_configure(). It is helpful in application scenarios where analogix controller is mixed wi

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-12 Thread Dmitry Baryshkov
On Thu, Dec 12, 2024 at 11:36:29AM +0530, Vignesh Raman wrote: > Hi Dmitry, > > On 12/12/24 03:09, Dmitry Baryshkov wrote: > > On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote: > > > Uprev IGT to the latest version and update expectation files. > > > > > > Signed-off-by: Vignesh Rama

Re: [PATCH 01/26] ptrace: export ptrace_may_access

2024-12-12 Thread Joonas Lahtinen
Quoting Christoph Hellwig (2024-12-10 06:29:38) > On Mon, Dec 09, 2024 at 03:32:52PM +0200, Mika Kuoppala wrote: > > xe driver would like to allow fine grained access control > > for GDB debugger using ptrace. Without this export, the only > > option would be to check for CAP_SYS_ADMIN. > > > > Th

Re: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-12 Thread Dmitry Baryshkov
On Thu, Dec 12, 2024 at 01:51:10PM +0800, Xin Ji wrote: > When user enabled HDCP feature, userspace will set HDCP content > to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update > HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream > support HDCP feature. > > However onc

[PATCH] drm/client: Fix drm client endless Kconfig loop

2024-12-12 Thread Jocelyn Falempe
if DRM_CLIENT_SELECTION is enabled, and none of the client is, the "Default DRM Client" choice is empty, and this makes Kconfig goes into an infinite loop of: Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 So only allow

Re: [PATCH v5 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Andrej Picej
On 12. 12. 24 00:04, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 08:57:17AM +0100, Andrej Picej wrote: On 10. 12. 24 14:59, Dmitry Baryshkov wrote: On Tue, Dec 10, 2024 at 02:41:01PM +0100, Andrej Picej wrote: On 10. 12. 24 12:43, Dmitry Baryshkov wrote: On Tue, Dec 10, 2024 at 10:

Re: [PATCH v4 1/3] dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight

2024-12-12 Thread Krzysztof Kozlowski
On Wed, Dec 11, 2024 at 07:34:37PM +0800, Nick Chan wrote: > Add backlight controllers attached via Apple DWI 2-wire interface. > > Signed-off-by: Nick Chan > --- > .../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++ > 1 file changed, 57 insertions(+) > create mode 100644 >

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-12 Thread Jani Nikula
On Wed, 11 Dec 2024, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 03:42:27PM +0100, Johan Hovold wrote: >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: >> >> > +/** >> > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode >> > + * @aux: DisplayPort AUX ch

Re: [PATCH] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()

2024-12-12 Thread Karol P
On Wed, 11 Dec 2024 at 13:59, Laurent Pinchart wrote: > > Hi Karol, > > Thank you for the patch. > > On Wed, Dec 11, 2024 at 01:20:26PM +0100, Karol Przybylski wrote: > > This patch fixes a potential integer overflow in the zynqmp_dp_rate_get() > > function. > > > > The issue comes up when the ex

Re: [PATCH v5 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Dmitry Baryshkov
On Thu, Dec 12, 2024 at 09:08:03AM +0100, Andrej Picej wrote: > > > On 12. 12. 24 00:04, Dmitry Baryshkov wrote: > > On Wed, Dec 11, 2024 at 08:57:17AM +0100, Andrej Picej wrote: > > > > > > > > > On 10. 12. 24 14:59, Dmitry Baryshkov wrote: > > > > On Tue, Dec 10, 2024 at 02:41:01PM +0100, And

Re: [PATCH v10 4/6] drm: consider GEM object shared when it is exported

2024-12-12 Thread Christian König
Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, December 11, 2024 10:03 Am 11.12.24 um 15:02 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, December 11, 2024 3:16 Am 10.12.24 um 18:59 schrieb Yunxiang Li:

[PATCHv2] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()

2024-12-12 Thread Karol Przybylski
This patch fixes a potential integer overflow in the zynqmp_dp_rate_get() The issue comes up when the expression drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 1 is evaluated using 32-bit Now the constant is a compatible 64-bit type. Resolves coverity issues: CID 1636340 and CID 1635811 Sig

Re: [PATCH v3 11/11] drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in intel_dp_mst.c

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > Follow the canonical way in intel_dp_mst.c, referencing a connector only > via a struct intel_connector pointer and naming this pointer 'connector' > instead of 'intel_connector', the only exception being the casting of > a drm_connector function parameter p

Re: [PATCH] drm/client: Fix drm client endless Kconfig loop

2024-12-12 Thread Jocelyn Falempe
On 12/12/2024 10:11, Jocelyn Falempe wrote: if DRM_CLIENT_SELECTION is enabled, and none of the client is, the "Default DRM Client" choice is empty, and this makes Kconfig goes into an infinite loop of: Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default

Re: [PATCH] drm/fbdev-dma: Add shadow buffering for deferred I/O

2024-12-12 Thread Simona Vetter
On Wed, Dec 11, 2024 at 10:06:28AM +0100, Thomas Zimmermann wrote: > DMA areas are not necessarily backed by struct page, so we cannot > rely on it for deferred I/O. Allocate a shadow buffer for drivers > that require deferred I/O and use it as framebuffer memory. > > Fixes driver errors about bei

Re: [PATCH] drm/fbdev-dma: Add shadow buffering for deferred I/O

2024-12-12 Thread Javier Martinez Canillas
Simona Vetter writes: > On Wed, Dec 11, 2024 at 10:06:28AM +0100, Thomas Zimmermann wrote: >> DMA areas are not necessarily backed by struct page, so we cannot >> rely on it for deferred I/O. Allocate a shadow buffer for drivers >> that require deferred I/O and use it as framebuffer memory. >> >

[PATCH next] drm/vc4: unlock on error in vc4_hvs_get_fifo_frame_count()

2024-12-12 Thread Dan Carpenter
Presumably the default path is never used. However, if it were used for some reason then call drm_dev_exit() before returning. Fixes: 8f2fc64773be ("drm/vc4: Fix reading of frame count on GEN5 / Pi4") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vc4/vc4_hvs.c | 2 +- 1 file changed, 1 inser

Re: [PATCH drm-next] drm/amdgpu: simplify return statement in amdgpu_ras_eeprom_init

2024-12-12 Thread Alex Deucher
On Thu, Dec 12, 2024 at 9:18 AM Dheeraj Reddy Jonnalagadda wrote: > > Remove the logically dead code in the last return statement of > amdgpu_ras_eeprom_init. The condition res < 0 is redundant since > res is already checked for a negative value earlier. Replace > return res < 0 ? res : 0; with re

Re: [PATCH -next] drm/amd/display: use swap() in update_phy_id_mapping()

2024-12-12 Thread Alex Deucher
Applied. Thanks! On Wed, Dec 11, 2024 at 8:47 PM Jiapeng Chong wrote: > > Use existing swap() function rather than duplicating its implementation. > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING > opportunity for swap(). > ./drivers/gpu/drm/amd/display/amdgpu_dm/a

[PATCH 05/12] drm/i915/display: fbdev: Move custom restore code to new callback

2024-12-12 Thread Thomas Zimmermann
i915's fbdev contains code for restoring the client's framebuffer. It is specific to i195 and cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_restore and implement it for i915. The fbdev helpers invoke the callback after restoring the fbdev client. Sign

[PATCH 09/12] drm/i915/display: Move fbdev code around

2024-12-12 Thread Thomas Zimmermann
Move fbdev code around in the source file before switching to DRM's generic fbdev client. This will make the conversion less intrusive. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 85 +++--- 1 file changed, 44 insertion

[PATCH 11/12] drm/i915/display: Remove compile guard around fbdev debugfs output

2024-12-12 Thread Thomas Zimmermann
If fbdev support has been disabled, no output will be shown. Remove the fbdev-related compile guard from the driver's debugfs code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 10/12] drm/{i915,xe}: Run DRM default client setup

2024-12-12 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro that sets the callback in struct drm_driver according to the kernel configuration. Call drm_client_setup_with_color_mode() to run the kernel's default client setup for

[PATCH 00/12] drm/{i915,xe}: Convert to DRM client setup

2024-12-12 Thread Thomas Zimmermann
i915 and xe are the last remaining drivers that still implement their own fbdev client. All other clients have been mass converted to DRM's client setup in in the series at [1]. As Intel drivers require more effort than others, their changes have been moved into this separate series. With DRM's cl

[PATCH 01/12] drm/{i915, xe}: Suspend/resume fbdev emulation via client interfaces

2024-12-12 Thread Thomas Zimmermann
Implement drm_client_dev_suspend() and drm_client_dev_resume() for i915's fbdev emulation and call the helper via DRM client interfaces. This is required to convert i915 and xe to DRM's generic fbdev client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display

[PATCH 04/12] drm/i915/display: Remove fbdev suspend and hotplug tracking

2024-12-12 Thread Thomas Zimmermann
The DRM client code already tracks suspend status and hotplug events for each client. Remove similar code from i915's fbdev client. Allows for the removal of all hdp_* fields form struct intel_fbdev. Calls to intel_fbdev_output_poll_changed() are reduced the shared helper drm_fb_helper_hotplug_eve

[PATCH 03/12] drm/client: Send pending hotplug events after resume

2024-12-12 Thread Thomas Zimmermann
If a hotplug event arrives while the client has been suspended, DRM's client code will deliver the event after resuming. The functionality has been taken form i915, where it can be removed by a later commit. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client_event.c | 9 + i

[PATCH 02/12] drm/client: Add client-hotplug helper

2024-12-12 Thread Thomas Zimmermann
Move client hotplug calls to drm_client_hotplug(). We'll need this helper to send hotplug events after resuming. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client_event.c | 32 ++ 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/gp

[PATCH 08/12] drm/i915/display: Remove struct drm_fb_helper from struct intel_fbdev

2024-12-12 Thread Thomas Zimmermann
Store instances of drm_fb_helper and struct intel_fbdev separately. This will allow i915 to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of type each per DRM device, so both can be referenced directly from the i915 and DRM dev

[PATCH 07/12] drm/i915/display: Remove preferred_bpp from struct intel_fbdev

2024-12-12 Thread Thomas Zimmermann
The value preferred_bpp in struct intel_fbdev duplicates preferred_bpp in struct drm_fb_helper. Remove the former. Instead let intel_fbdev_init_bios() read the framebuffer from the hardware. Then derive preferred_bpp from its format and initialize struct drm_fb_helper with the value. The default i

[PATCH 12/12] drm/fb-helper: Remove struct drm_fb_helper.fb_probe

2024-12-12 Thread Thomas Zimmermann
The callback fb_probe in struct drm_fb_helper is unused. Remove it. New drivers should set struct drm_driver.fbdev_probe instead and call drm_client_setup() to instantiate in-kernel DRM clients. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 8 include/drm/drm_f

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-12 Thread Rob Clark
On Thu, Dec 12, 2024 at 7:59 AM Akhil P Oommen wrote: > > On 12/5/2024 10:24 PM, Rob Clark wrote: > > From: Rob Clark > > > > Performance counter usage falls into two categories: > > > > 1. Local usage, where the counter configuration, start, and end read > >happen within (locally to) a singl

[PATCH 06/12] drm/i915/display: fbdev: Move custom suspend code to new callback

2024-12-12 Thread Thomas Zimmermann
If the fbdev buffer is backed by stolen memory, it has to be cleared upon resume from hibernation. Move the code into the new callback fb_set_suspend, so that it can run from DRM's generic fbdev client. No functional change. Other drivers are not affected. Signed-off-by: Thomas Zimmermann --- dr

Re: [PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for static connectors initialized/added during driver loading, for which > the driver ensures that look-ups via

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-12 Thread Simona Vetter
On Wed, Dec 11, 2024 at 07:34:10PM -0500, Lyude Paul wrote: > On Wed, 2024-12-11 at 09:43 +0100, Simona Vetter wrote: > > On Tue, Dec 10, 2024 at 06:41:52PM -0500, Lyude Paul wrote: > > > On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > > > > Hi Lyude, > > > > > > > > > On 30 Sep 2024, a

[PATCH v2 2/3] drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM

2024-12-12 Thread Thomas Zimmermann
Select FB_CORE if GEM's DMA and TTM implementations support fbdev emulation. Fixes linker errors about missing symbols from the fbdev subsystem. Also see [1] for a related SHMEM fix. Fixes: dadd28d4142f ("drm/client: Add client-lib module") Signed-off-by: Thomas Zimmermann Link: https://patchwor

[PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about recursive dependencies, such as error: recurs

Re: [PATCH v3 02/11] drm/connector: Add FIXME for GETRESOURCES ioctl wrt. uninited connectors

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > The connectors enumerated by the GETRESOURCES ioctl may not be fully > initialized yet wrt. to the state set up during connector registration > (for instance the connector's debugfs/sysfs interfaces may not exist > yet). This can happen in two ways: > > 1. C

[PATCH v2 0/3] drm,fbdev: Fix module dependencies

2024-12-12 Thread Thomas Zimmermann
Fix the dependencies among the various graphics modules. Before addressing the FB_CORE issue, patch 1 first resolves a problem with BACKLIGHT_CLASS_DEVICE. A number of fbdev drivers select it, which results in a recursive-dependency error after patch has been applied. Making these drivers (or part

[PATCH v2 3/3] drm: rework FB_CORE dependency

2024-12-12 Thread Thomas Zimmermann
From: Arnd Bergmann The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, but there are now configurations that have code calling into fb_core as built-in even though the client_lib itself is a loadable module: x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm

Re: [PATCH v9 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-12 Thread Simona Vetter
ached patch should fix it, can you try it ? > > I will submit that shortly. > > Thanks for reporting it. > > Best regards, > > -- > > Jocelyn > > > > > > I'm using this arm64 randconfig as a base. I type "make oldconfig" and

Re: [PATCH v3 03/11] drm/connector: Add deprication notes for drm_connector_register/unregister

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > Drivers should register/unregister only dynamic (MST) connectors > manually using drm_connector_dynamic_register()/unregister(). > Static connectors are registered/unregistered by the DRM core > automatically. Some drivers still call drm_connector_register()

Re: [PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > MST connectors should be initialized/registered by calling > drm_connector_dynamic_init()/drm_connector_dynamic_register(). The > previous patch adding these functions explains the issue with the References to "previous patch" become meaningless after this

Re: [PATCH 14/26] drm/xe/eudebug: implement userptr_vma access

2024-12-12 Thread Simona Vetter
On Thu, Dec 12, 2024 at 09:49:24AM +0100, Thomas Hellström wrote: > On Mon, 2024-12-09 at 16:31 +0100, Simona Vetter wrote: > > On Mon, Dec 09, 2024 at 03:03:04PM +0100, Christian König wrote: > > > Am 09.12.24 um 14:33 schrieb Mika Kuoppala: > > > > From: Andrzej Hajda > > > > > > > > Debugger n

Re: [PATCH v3 05/11] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > After a connector is added to the drm_mode_config::connector_list, it's > visible to any in-kernel users looking up connectors via the above list. > Make sure that the connector is properly initialized before such > look-ups, by initializing the connector wi

Re: [PATCH v3 06/11] drm/amd/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > After a connector is added to the drm_mode_config::connector_list, it's > visible to any in-kernel users looking up connectors via the above list. > Make sure that the connector is properly initialized before such > look-ups, by initializing the connector wi

Re: [PATCH v3 07/11] drm/nouveau/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > After a connector is added to the drm_mode_config::connector_list, it's > visible to any in-kernel users looking up connectors via the above list. > Make sure that the connector is properly initialized before such > look-ups, by initializing the connector wi

Re: [PATCH v3 08/11] drm/connector: Warn if a connector is registered/added incorrectly

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > All the drivers should be converted now to use > drm_connector_dynamic_init() for MST connectors, hence > drm_connector_dynamic_register()->drm_connector_add() can WARN now if > this was not the case (for instance if a driver inited an MST connector > with o

Re: [PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-12 Thread Simona Vetter
On Wed, Dec 11, 2024 at 07:33:03PM -0500, Lyude Paul wrote: > Coming in again with the good patches I see :D > > Apologies for not seeing these patches before, I really need to figure out a > way to keep up with dri-devel outside of patches that are CC'd to me :S (if > you ever need me to review s

Re: [PATCH v3 10/11] drm/i915/dp_mst: Fix error handling while adding a connector

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, Imre Deak wrote: > After an error during adding an MST connector the MST port and the > intel_connector object could be leaked, fix this up. > > Reviewed-by: Rodrigo Vivi > Signed-off-by: Imre Deak Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp_ms

Re: [PATCH v5 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Andrej Picej
On 12. 12. 24 10:28, Dmitry Baryshkov wrote: On Thu, Dec 12, 2024 at 09:08:03AM +0100, Andrej Picej wrote: On 12. 12. 24 00:04, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 08:57:17AM +0100, Andrej Picej wrote: On 10. 12. 24 14:59, Dmitry Baryshkov wrote: On Tue, Dec 10, 2024 at 02:

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-12 Thread Raag Jadav
On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote: > On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > > + misc maintainers > > > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > > > Am 03.12.24 um 06:00 schrieb Raag Jadav: > > > > On Mon, Dec 02, 2024 a

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Mark Rutland
On Thu, Dec 12, 2024 at 08:50:12AM +, Marc Zyngier wrote: > On Thu, 12 Dec 2024 05:31:00 +, > Pavan Kondeti wrote: > > > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > > On Wed, 11 Dec 2024 00:37:34 +, > > > Pavan Kondeti wrote: > > > > > > > > On Tue, Dec 10, 2

Re: [PATCH v6 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Christophe JAILLET
Le 12/12/2024 à 13:17, Andrej Picej a écrit : Add a optional properties to change LVDS output voltage. This should not be static as this depends mainly on the connected display voltage requirement. We have three properties: - "ti,lvds-termination-ohms", which sets near end termination, - "ti,lvds

[PATCH 2/2] drm/panel: simple: add Multi-Inno Technology MI1010Z1T-1CP11

2024-12-12 Thread Marek Vasut
Add Multi-Inno Technology MI1010Z1T-1CP11 10.1" 1024x600 LVDS panel support. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herring Cc: Sam Ravnborg Cc: Simona V

RE: [PATCH v10 4/6] drm: consider GEM object shared when it is exported

2024-12-12 Thread Li, Yunxiang (Teddy)
[Public] > From: Koenig, Christian > Sent: Thursday, December 12, 2024 4:25 > Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy): > > [Public] > > > >> From: Koenig, Christian > >> Sent: Wednesday, December 11, 2024 10:03 Am 11.12.24 um 15:02 schrieb > >> Li, Yunxiang (Teddy): > >>> [Public] > >>

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-12 Thread Antonino Maniscalco
On 12/12/24 4:58 PM, Akhil P Oommen wrote: On 12/5/2024 10:24 PM, Rob Clark wrote: From: Rob Clark Performance counter usage falls into two categories: 1. Local usage, where the counter configuration, start, and end read happen within (locally to) a single SUBMIT. In this case, there is

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

2024-12-12 Thread AngeloGioacchino Del Regno
Il 12/12/24 16:33, Jason-JH.Lin ha scritto: The OVL hardware capabilities have changed starting from MT8195, making the MT8183 compatible no longer applicable. Therefore, it is necessary to update the OVL compatible from MT8183 to MT8195. Signed-off-by: Jason-JH.Lin Jason, just so you know -

[PATCH v2 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset

2024-12-12 Thread Dave Stevenson
I missed the DT errors from the recent patchset[1] (DT patches in linux-next via Florian, DRM bindings patches on dri-misc-next) as Rob's bot report got spam filtered, so this is a fixup set. Largely it was changes to number of interrupts or clocks in the bindings, so those are now covered. I've

[PATCH v2 1/7] dt-bindings: display: bcm2711-hdmi: Add interrupt details for BCM2712

2024-12-12 Thread Dave Stevenson
Commit 62948c62abca ("dt-bindings: display: Add BCM2712 HDMI bindings") added the compatible strings for BCM2712, but missed out that the number of interrupts changed. Update the schema to include the interrupt requirements. Fixes: 62948c62abca ("dt-bindings: display: Add BCM2712 HDMI bindings")

[PATCH v2 6/7] arm64: dts: broadcom: Correct hdmi device node names

2024-12-12 Thread Dave Stevenson
The names of the hdmi0 and hdmi1 nodes had addresses that didn't match the reg properties for the nodes. Fixes: f66b382affd8 ("arm64: dts: broadcom: Add display pipeline support to BCM2712") Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 4 ++-- 1 file changed, 2

[PATCH v2 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-12 Thread Dave Stevenson
gpio-line-names is a generic property that can be supported by any GPIO controller, so permit it through the binding. It is permitted to have a variable number of GPIOs per node based on brcm,gpio-bank-widths, so define an arbitrary maximum number of items based on current users. Signed-off-by: D

[PATCH v2 2/7] dt-bindings: display: Fix BCM2835 HVS bindings for BCM2712

2024-12-12 Thread Dave Stevenson
Commit 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") added the compatible string for BCM2712, but missed out that the number of interrupts and clocks changed too. Update to validate clock and interrupts for the variants. Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HV

[PATCH v2 5/7] arm64: dts: broadcom: Rename bcm2712 interrupt controllers

2024-12-12 Thread Dave Stevenson
CHECK_DTBS produces errors on bcm2712-rpi-5-b.dtb and bcm2712-d-rpi-5-b.dtb of: intc@7d508380: $nodename:0: 'intc@7d508380' does not match '^interrupt-controller(@[0-9a-f,]+)*$' from schema $id: http://devicetree.org/schemas/interrupt-controller/brcm,l2-intc.yaml# intc@7d508400: $nodename

[PATCH v2 7/7] arm64: dts: broadcom: Remove intc controller on BCM2712.

2024-12-12 Thread Dave Stevenson
The brcm,bcm2836-l1-intc controller isn't used on this platform. It is used on 32-bit kernels for the smp_boot_secondary hook, but BCM2712 can't run a 32-bit kernel. Remove the node. Fixes: e1417095a139 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT") Signed-off-by: Dave S

Re: [PATCH v10 4/6] drm: consider GEM object shared when it is exported

2024-12-12 Thread Christian König
Am 12.12.24 um 15:04 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Thursday, December 12, 2024 4:25 Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, December 11, 2024 10:03 Am 11.12.24 um 15:02 schrieb Li, Yunxiang

[PATCH v2 4/7] dt-bindings: interrupt-controller: brcm,bcm2836-l1-intc: Drop interrupt-controller requirement

2024-12-12 Thread Dave Stevenson
Since commit 88bbe85dcd37 ("irqchip: bcm2836: Move SMP startup code to arch/arm (v2)") the bcm2836-l1-intc block on bcm2711 is only used as a base address for the smp_boot_secondary hook on 32 bit kernels. It is not used as an interrupt controller. Drop the binding requirement for interrupt-contro

[PATCH 6.1 633/772] dma-fence: Use kernels sort for merging fences

2024-12-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Tvrtko Ursulin commit fe52c649438b8489c9456681d93a9b3de3d38263 upstream. One alternative to the fix Christian proposed in https://lore.kernel.org/dri-devel/20241024124159.4519-3-christian.koe..

[PATCH 6.1 632/772] dma-fence: Fix reference leak on fence merge failure path

2024-12-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Tvrtko Ursulin commit 949291c5314009b4f6e252391edbb40fdd5d5414 upstream. Release all fence references if the output dma-fence-array could not be allocated. Signed-off-by: Tvrtko Ursulin Fixes

Re: [PATCH] drm/log: select CONFIG_FONT_SUPPORT

2024-12-12 Thread Jocelyn Falempe
On 12/12/2024 16:39, Arnd Bergmann wrote: From: Arnd Bergmann Without fonts, this fails to link: drivers/gpu/drm/clients/drm_log.o: in function `drm_log_init_client': drm_log.c:(.text+0x3d4): undefined reference to `get_default_font' Select this, like the other users do. Thanks for the fix,

[PATCH 6.1 761/772] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2024-12-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit 71ce046327cfd3aef3f93d1c44e091395eb03f8f upstream. Some drivers require the mapped tt pages to be decrypted. In an ideal world this would have been handled by the dma layer, b

[PATCH 6.1 762/772] drm/ttm: Print the memory decryption status just once

2024-12-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit 27906e5d78248b19bcdfdae72049338c828897bb upstream. Stop printing the TT memory decryption status info each time tt is created and instead print it just once. Reduces the spam

[PATCH 6.1 769/772] drm/msm: DEVFREQ_GOV_SIMPLE_ONDEMAND is no longer needed

2024-12-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap commit a722511b18268bd1f7084eee243af416b85f288f upstream. DRM_MSM no longer needs DEVFREQ_GOV_SIMPLE_ONDEMAND (since commit dbd7a2a941b8 ("PM / devfreq: Fix build issues with devfr

Re: [PATCH] drm/rockchip: Fix Copyright description

2024-12-12 Thread Sebastian Reichel
Hi, On Thu, Dec 12, 2024 at 08:43:44PM +0800, Andy Yan wrote: > From: Andy Yan > > The company name has update to Rockchip Electronics Co., Ltd. > since 2021. > And change Co.Ltd to Co., Ltd. to fix mail server warning: > DBL_SPAM(6.50)[co.ltd:url]; > > Signed-off-by: Andy Yan > --- Reviewed-

Patch "drm/msm: DEVFREQ_GOV_SIMPLE_ONDEMAND is no longer needed" has been added to the 6.1-stable tree

2024-12-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/msm: DEVFREQ_GOV_SIMPLE_ONDEMAND is no longer needed to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH 2/2] drm/panel: simple: add Multi-Inno Technology MI0700A2T-30

2024-12-12 Thread Marek Vasut
On 11/25/24 2:33 AM, Marek Vasut wrote: Add Multi-Inno Technology MI0700A2T-30 7" 800x480 LVDS panel support. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herr

[PATCH v6 2/3] drm/bridge: ti-sn65dsi83: Add ti, lvds-vod-swing optional properties

2024-12-12 Thread Andrej Picej
Add a optional properties to change LVDS output voltage. This should not be static as this depends mainly on the connected display voltage requirement. We have three properties: - "ti,lvds-termination-ohms", which sets near end termination, - "ti,lvds-vod-swing-data-microvolt" and - "ti,lvds-vod-sw

[PATCH v6 3/3] arm64: dts: imx8mm-phyboard-polis-peb-av-10: Set lvds-vod-swing

2024-12-12 Thread Andrej Picej
Set custom differential output voltage for LVDS, to fulfill requirements of the connected display. LVDS differential voltage for data-lanes and clock output has to be between 200 mV and 600 mV. Driver sets 200 Ohm near-end termination by default. Signed-off-by: Andrej Picej --- Changes in v6: - n

[PATCH v6 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add properties for ti, lvds-vod-swing

2024-12-12 Thread Andrej Picej
Add properties which can be used to specify LVDS differential output voltage. Since this also depends on near-end signal termination also include property which sets this. LVDS differential output voltage is specified with an array (min, max), which should match the one from connected device. Sign

[PATCH v6 0/3] SN65DSI83/4 lvds_vod_swing properties

2024-12-12 Thread Andrej Picej
Hi all, The LVDS differential voltage swing can be specified as arrays of min, max in microvolts. Two arrays, one for data-lanes and one for clock-lane can be specified. Additionally, because LVDS voltage swing depends on near-end termination this can now also be specified with separate property.

Re: [PATCH 6.1.y] drm/amd/display: Don't refer to dc_sink in is_dsc_need_re_compute

2024-12-12 Thread Greg KH
On Wed, Dec 11, 2024 at 06:15:44PM +0800, jianqi.ren...@windriver.com wrote: > From: Wayne Lin > > [ Upstream commit fcf6a49d79923a234844b8efe830a61f3f0584e4 ] > > [Why] > When unplug one of monitors connected after mst hub, encounter null pointer > dereference. > > It's due to dc_sink get rel

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-12 Thread Rob Clark
On Thu, Dec 12, 2024 at 9:08 AM Rob Clark wrote: > > On Thu, Dec 12, 2024 at 7:59 AM Akhil P Oommen > wrote: > > > > On 12/5/2024 10:24 PM, Rob Clark wrote: > > > From: Rob Clark > > > > > > Performance counter usage falls into two categories: > > > > > > 1. Local usage, where the counter confi

[PATCH 6.12 187/466] dma-fence: Use kernels sort for merging fences

2024-12-12 Thread Greg Kroah-Hartman
6.12-stable review patch. If anyone has any objections, please let me know. -- From: Tvrtko Ursulin commit fe52c649438b8489c9456681d93a9b3de3d38263 upstream. One alternative to the fix Christian proposed in https://lore.kernel.org/dri-devel/20241024124159.4519-3-christian.koe.

[PATCH 6.12 186/466] dma-fence: Fix reference leak on fence merge failure path

2024-12-12 Thread Greg Kroah-Hartman
6.12-stable review patch. If anyone has any objections, please let me know. -- From: Tvrtko Ursulin commit 949291c5314009b4f6e252391edbb40fdd5d5414 upstream. Release all fence references if the output dma-fence-array could not be allocated. Signed-off-by: Tvrtko Ursulin Fixe

Re: [PATCH v2 next] drm/vc4: unlock on error in vc4_hvs_get_fifo_frame_count()

2024-12-12 Thread Dave Stevenson
On Thu, 12 Dec 2024 at 12:47, Dan Carpenter wrote: > > The default statement is never used in real life. However, if it were > used for some reason then call drm_dev_exit() before returning. > > Fixes: 8f2fc64773be ("drm/vc4: Fix reading of frame count on GEN5 / Pi4") > Signed-off-by: Dan Carpent

  1   2   3   >