Re: [PATCH v2] drm/i2c: tda9950: Constify struct i2c_device_id

2024-11-19 Thread Thomas Zimmermann
Am 15.11.24 um 18:17 schrieb Christophe JAILLET: 'struct i2c_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: == text data bss dec

[PATCH v2] drm/bridge: adv7533: Reset DSI receiver logic

2024-11-19 Thread Stefan Ekenberg
Reset DSI receiver logic during power on. The need for this change was discovered when investigating issue with ADV7535. The symptom of the problem was that ADV7535 continuously outputs a black image. This happened for about 10% of the times that ADV7535 was powered on. The rest of the times the im

[PATCH v4] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

2024-11-19 Thread Stefan Ekenberg
AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1 while updating Audio InfoFrame information and then set to 0 when done. Otherwise partially updated Audio InfoFrames could be sent out. Two cases where this rule were not followed are fixed: - In adv7511_hdmi_hw_params() make sure

[PATCHv4 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-19 Thread Arun R Murthy
In Display 20+, new registers are added for setting index, reading histogram and writing the IET. v2: Removed duplicate code (Jani) v3: Moved histogram core changes to earlier patches (Jani/Suraj) v4: Rebased after addressing comments on patch 1 Signed-off-by: Arun R Murthy --- .../gpu/drm/i915

[PATCHv4 4/8] drm/i915/histogram: histogram interrupt handling

2024-11-19 Thread Arun R Murthy
Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt. v2: Added intel_crtc backpointer to intel_histogram struct (Jani) Removed histogram_wq and instead use dev_priv->unodered_eq (Jani)

[PATCH 6/8] drm/i915/histogram: histogram delay counter doesnt reset

2024-11-19 Thread Arun R Murthy
The delay counter for histogram does not reset and as a result the histogram bin never gets updated. Workaround would be to use save and restore histogram register. Wa: 14014889975 Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_histogram.c | 17 + .../gpu/dr

[PATCHv2 1/8] drm/i915/histogram: Define registers for histogram

2024-11-19 Thread Arun R Murthy
Add the register/bit definitions for global histogram. v2: Intended the register contents, removed unused regs (Jani) Signed-off-by: Arun R Murthy --- .../drm/i915/display/intel_histogram_regs.h | 48 +++ 1 file changed, 48 insertions(+) create mode 100644 drivers/gpu/drm/i91

[PATCHv4 2/8] drm/i915/histogram: Add support for histogram

2024-11-19 Thread Arun R Murthy
Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This e

[PATCHv5 0/8] Display Global Histogram

2024-11-19 Thread Arun R Murthy
Display histogram is a hardware functionality where a statistics for 'x' number of frames is generated to form a histogram data. This is notified to the user via histogram event. Compositor will then upon sensing the histogram event will read the histogram data from KMD via crtc property. A library

[PATCHv5 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-19 Thread Arun R Murthy
CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly. "Histogram" is a crtc property to read the binary histogram data. "Global

[PATCH 3/8] drm/xe: Add histogram support to Xe builds

2024-11-19 Thread Arun R Murthy
Histogram added as part of i915/display driver. Adding the same for xe as well. Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/xe/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index a93e6fcc0ad

[PATCH 8/8] drm/i915/histogram: Enable pipe dithering

2024-11-19 Thread Arun R Murthy
Enable pipe dithering while enabling histogram to overcome some atrifacts seen on the screen. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_histogram.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c b/drivers/

Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-19 Thread Petr Mladek
On Mon 2024-11-18 10:18:49, Easwar Hariharan wrote: > On 11/18/2024 3:06 AM, Petr Mladek wrote: > > On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: > >> > >> > >> Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > >>> [Vous ne recevez pas souvent de courriers de > >>> eahar...@linux.microsoft

Re: Merging the xe / ttm shrinker series?

2024-11-19 Thread Thomas Hellström
Hi, Christian, On Sun, 2024-11-03 at 13:38 +0100, Thomas Hellström wrote: > Hi, Christian, > > The TTM shrinker series is now at v12 with all patches R-B:d. > > Ack to merge through drm-xe-next? > > Thanks, > Thomas > Gentle ping on this, The requested change of the ttm_backup interface done

Re: [PATCH v1] drm/virtio: Don't create a context with default param if context_init is supported

2024-11-19 Thread Dmitry Osipenko
On 10/21/24 01:47, Dmitry Osipenko wrote: > From: Pierre-Eric Pelloux-Prayer > > Xorg context creation fails for native contexts that use > VIRTGPU_CONTEXT_INIT because context is already initialized implicitly > when dumb buffer is created. Fix it by not creating default vrend context > if conte

Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-19 Thread Miroslav Benes
On Tue, 19 Nov 2024, Petr Mladek wrote: > On Mon 2024-11-18 10:18:49, Easwar Hariharan wrote: > > On 11/18/2024 3:06 AM, Petr Mladek wrote: > > > On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: > > >> > > >> > > >> Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > > >>> [Vous ne recevez pas

Re: [PATCH v2 RESEND] drm/virtio: use generic dumb_map_offset implementation

2024-11-19 Thread Dmitry Osipenko
On 11/7/24 17:10, Peter Shkenev wrote: > Currently, virtio uses its own dumb_map_offset implementation, > virtio_gpu_mode_dumb_mmap. It works similarly to generic implementation, > drm_gem_dumb_map_offset, and using the generic implementation is > preferable (and making drivers to do so is a task s

Re: [PATCH v3 1/2] drm/virtio: Use drm_gem_plane_helper_prepare_fb()

2024-11-19 Thread Dmitry Osipenko
On 10/21/24 02:08, Dmitry Osipenko wrote: > From: Dongwon Kim > > Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer > synchronization. We need to wait for explicit fences in a case of > Venus and native contexts when guest user space uses explicit fencing. > > Signed-off-by:

Re: [PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-19 Thread Dmitry Osipenko
Hi, Vivek On 11/19/24 09:01, Kasireddy, Vivek wrote: ... > After rebasing v2 of this patch series on top of the above patch, I see that > this use-case works as expected with Qemu master. Let me send out v3, > which would be a rebase of v2 on top of the above patch. ... >>> Am I doing anything wro

Re: [PATCH v4] drm/virtio: Add drm_panic support

2024-11-19 Thread Jocelyn Falempe
On 18/11/2024 17:16, Dmitry Osipenko wrote: On 11/13/24 11:44, Ryosuke Yasuoka wrote: From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- On a s

Re: [RFC PATCH 13/29] drm/xe/mmap: Add mmap support for PCI memory barrier

2024-11-19 Thread Christian König
Am 19.11.24 um 00:37 schrieb Matthew Brost: From: Tejas Upadhyay In order to avoid having userspace to use MI_MEM_FENCE, we are adding a mechanism for userspace to generate a PCI memory barrier with low overhead (avoiding IOCTL call as well as writing to VRAM will adds some overhead). This is

Re: [PATCH] drm/panthor: Simplify FW fast reset path

2024-11-19 Thread Boris Brezillon
On Mon, 18 Nov 2024 15:21:52 + Karunika Choo wrote: > Stop checking the FW halt_status as MCU_STATUS should be sufficient. > This should make the check for successful FW halt and subsequently > setting fast_reset to true more robust. > > We should also clear GLB_REQ.GLB_HALT bit only on post

RE: [PATCH v4 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: dri-devel On Behalf Of > Laurent Pinchart > Sent: 16 November 2024 15:32 > Subject: Re: [PATCH v4 1/3] drm: adv7511: Fix use-after-free in > adv7533_attach_dsi() > > Hi Biju, > > Thank you for the patch. > > On Sat,

RE: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate"

2024-11-19 Thread Ying Liu
On 11/19/24, Marek Vasut wrote: > On 11/18/24 4:54 AM, Ying Liu wrote: > > Hi Marek, > > Hi, > > >>> media_disp1_pix clock is the pixel clock of the first i.MX8MP LCDIFv3 > >>> display controller, while media_disp2_pix clock is the pixel clock of > >>> the second i.MX8MP LCDIFv3 display controlle

Re: Merging the xe / ttm shrinker series?

2024-11-19 Thread Christian König
Am 19.11.24 um 12:22 schrieb Thomas Hellström: Hi, Christian, On Sun, 2024-11-03 at 13:38 +0100, Thomas Hellström wrote: Hi, Christian, The TTM shrinker series is now at v12 with all patches R-B:d. Ack to merge through drm-xe-next? Thanks, Thomas Gentle ping on this, The requested change o

Re: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence

2024-11-19 Thread Pierre-Eric Pelloux-Prayer
Le 15/11/2024 à 13:23, Steven Price a écrit : On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote: This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_am

Re: [PATCH v2 09/29] drm/xe: Add SVM range invalidation

2024-11-19 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > Add SVM range invalidation vfunc. > > v2: >  - Don't run invalidation if VM is closed >  - Cycle notifier lock in xe_svm_close >  - Drop xe_gt_tlb_invalidation_fence_fini > > Signed-off-by: Matthew Brost > --- >  drivers/gpu/drm/xe/xe_gt_

Re: [PATCH v3] drm/vkms: Remove index parameter from init_vkms_output

2024-11-19 Thread Louis Chauvet
On 19/11/24 - 14:34, Louis Chauvet wrote: > VKMS currently supports only one CRTC, so it make no sense to have this > index configurable. To avoid issues, replace this hardcoded index by > drm_crtc_mask when applicable. > > There is no need to manually set a crtc mask on primary and cursor plane >

Re: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence

2024-11-19 Thread Pierre-Eric Pelloux-Prayer
Le 15/11/2024 à 15:56, Philipp Stanner a écrit : On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote: This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. I think this commit message should detail what the patch is actual

Re: [PATCH v13 5/9] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-11-19 Thread José Expósito
On Mon, Nov 18, 2024 at 06:35:30PM +0100, Louis Chauvet wrote: > On 18/11/24 - 18:24, José Expósito wrote: > > On Mon, Nov 18, 2024 at 06:17:11PM +0100, Louis Chauvet wrote: > > > On 18/11/24 - 18:10, José Expósito wrote: > > > > > Introduce the usage of block_h/block_w to compute the offset and th

[PATCH v6 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
As per [1] and [2], ADV7535/7533 supports only 2-, 3-, or 4-lane. Drop unsupported 1-lane. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf [2] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: ad

[PATCH v6 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
The host_node pointer was assigned and freed in adv7533_parse_dt(), and later, adv7533_attach_dsi() uses the same. Fix this use-after-free issue by dropping of_node_put() in adv7533_parse_dt() and calling of_node_put() in error path of probe() and also in the remove(). Fixes: 1e4d58cd7f88 ("drm/br

[PATCH v6 0/3] drm: adv7511: ADV7535 fixes

2024-11-19 Thread Biju Das
This patch series aims to fix 2 bugs in the ADV7535 driver 1) use-after-free bug in adv7533_attach_dsi() 2) Drop unsupported single lane. Changes in v6: - Fixed memory leak by adding goto stattement in error path of adv7511_init_regulators(). - Added Rb tag from Adam for patch#3. Changes in

[PATCH v6 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-19 Thread Biju Das
As per [1] and [2], ADV7535/7533 supports only 2-, 3-, or 4-lane. Drop unsupported 1-lane from bindings. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf [2] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf Fixes: 1e4d58cd7f88 ("

[PATCH v2 08/11] drm/msm: adreno: request for maximum bus bandwidth usage

2024-11-19 Thread Neil Armstrong
When requesting a DDR bandwidth level along a GPU frequency level via the GMU, we can also specify the bus bandwidth usage in a 16bit quantitized value. For now simply request the maximum bus usage. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +++ driver

[PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-19 Thread Neil Armstrong
The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. In order to calculate vote values used by the GPU Management Unit (GMU), we need to parse all the possible OPP Bandwid

[PATCH v5 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
The host_node pointer was assigned and freed in adv7533_parse_dt(), and later, adv7533_attach_dsi() uses the same. Fix this use-after-free issue by dropping of_node_put() in adv7533_parse_dt() and calling of_node_put() in error path of probe() and also in the remove(). Fixes: 1e4d58cd7f88 ("drm/br

[PATCH v5 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
As per [1] and [2], ADV7535/7533 supports only 2-, 3-, or 4-lane. Drop unsupported 1-lane. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf [2] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: ad

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-11-19 Thread 胡俊光

Re: [PATCH 2/2] drm/sched: Fix docu of drm_sched_entity_flush()

2024-11-19 Thread Philipp Stanner
On Tue, 2024-11-19 at 15:27 +0100, Christian König wrote: > Am 19.11.24 um 14:41 schrieb Philipp Stanner: > > drm_sched_entity_flush()'s documentation states that an error is > > being > > returned when "the process was killed". That is not what the > > function > > actually does. > > > > Furtherm

[PATCH] drm/amdgpu: Fix an error handling path in amdgpu_device_xgmi_reset_func()

2024-11-19 Thread Christophe JAILLET
In case of error after a amdgpu_gfx_rlc_enter_safe_mode() call, it is not balanced by a corresponding amdgpu_gfx_rlc_exit_safe_mode() call. Add the missing call. Fixes: c6a6e2db9945 ("drm/amdgpu: Redo XGMI reset synchronization.") Signed-off-by: Christophe JAILLET --- Compile tested only. This

[PATCH v2 01/11] opp: core: implement dev_pm_opp_get_bw

2024-11-19 Thread Neil Armstrong
Add and implement the dev_pm_opp_get_bw() to retrieve the OPP's bandwidth in the same way as the dev_pm_opp_get_voltage() helper. Retrieving bandwidth is required in the case of the Adreno GPU where the GPU Management Unit can handle the Bandwidth scaling. The helper can get the peak or average b

[PATCH v2 07/11] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-11-19 Thread Neil Armstrong
The Adreno GMU Management Unit (GMU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, until now we left the OPP core scale the OPP bandwidth via the interconnect path. In order to enable bandwidth voting via the GPU Management Unit (GMU), when an opp is set by devfreq w

Re: [PATCH v2 18/29] drm/xe: Add drm_gpusvm_devmem to xe_bo

2024-11-19 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > Add drm_gpusvm_devmem to xe_bo. Required to enable SVM migrations. > > Signed-off-by: Matthew Brost > --- >  drivers/gpu/drm/xe/xe_bo_types.h | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_bo_types.

Re: [PULL] drm-misc-next

2024-11-19 Thread Nathan Chancellor
On Tue, Nov 19, 2024 at 04:29:53PM +, Liviu Dudau wrote: > On Mon, Nov 18, 2024 at 08:08:16AM -0700, Nathan Chancellor wrote: > > On Thu, Oct 31, 2024 at 02:41:38PM +0100, Maarten Lankhorst wrote: > > > Cristian Ciocaltea (3): > > > drm/rockchip: Add basic RK3588 HDMI output support > >

[PATCH v7 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
As per [1] and [2], ADV7535/7533 supports only 2-, 3-, or 4-lane. Drop unsupported 1-lane. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf [2] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: ad

Re: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate"

2024-11-19 Thread Marek Vasut
On 11/19/24 9:18 AM, Ying Liu wrote: [...] The TC9595 can drive an DP output, for that the clock which have to be set on the LCDIF cannot be predicted, as that information comes from the monitor EDID/DPCD. That is why the LCDIF has to be able to configure the Video PLL1 clock to accurate clock

Re: [PATCH v2 19/21] drm/imagination: Add device_memory_force_cpu_cached override

2024-11-19 Thread Andrew Davis
On 11/18/24 7:02 AM, Matt Coster wrote: The TI k3-j721s2 platform has a bug relating to cache snooping on the AXI Well we don't really know it is the bug on our side until we root cause it.. Anyway, why do need such a complex work around here? GEM buffer objects only need to be coherent, cache

[PATCH] drm/amd/pm: Fix an error handling path in vega10_enable_se_edc_force_stall_config()

2024-11-19 Thread Christophe JAILLET
In case of error after a amdgpu_gfx_rlc_enter_safe_mode() call, it is not balanced by a corresponding amdgpu_gfx_rlc_exit_safe_mode() call. Add the missing call. Fixes: 9b7b8154cdb8 ("drm/amd/powerplay: added didt support for vega10") Signed-off-by: Christophe JAILLET --- *Not* even compile test

[PATCH] drm/panthor: Fix compilation failure on panthor_fw.c

2024-11-19 Thread Liviu Dudau
Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot to copy the definition of glb_iface when it move one line of code. Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") Signed-off-by: Liviu Dudau --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + 1 file cha

RE: [PATCH v5 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: 19 November 2024 16:28 > Subject: Re: [PATCH v5 1/3] drm: adv7511: Fix use-after-free in > adv7533_attach_dsi() > > Hi Biju, > > Thank you for the patch. > > On Tue, Nov 19, 2024 at 01:10:03PM +, Biju Das wrote: > >

Re: [PATCH v14 2/8] drm/ttm: Provide a shmem backup implementation

2024-11-19 Thread Christian König
Am 15.11.24 um 16:01 schrieb Thomas Hellström: Provide a standalone shmem backup implementation. Given the ttm_backup interface, this could later on be extended to providing other backup implementation than shmem, with one use-case being GPU swapout to a user-provided fd. v5: - Fix a UAF. (kerne

[PATCH 2/2] drm/sched: Fix docu of drm_sched_entity_flush()

2024-11-19 Thread Philipp Stanner
drm_sched_entity_flush()'s documentation states that an error is being returned when "the process was killed". That is not what the function actually does. Furthermore, it contains an inprecise statement about how the function is part of a convenience wrapper. Move that statement to drm_sched_ent

[PATCH 1/2] drm/sched: Fix drm_sched_entity_flush() return val

2024-11-19 Thread Philipp Stanner
The documentation of drm_sched_entity_flush() states that the function shall - always - return the remaining timeout time in jiffies. However, that is not what the function actually does; in one of its if branches it simply returns the unchanged timeout value. Furthermore, the used function wait_

Re: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence

2024-11-19 Thread Tvrtko Ursulin
On 19/11/2024 13:39, Pierre-Eric Pelloux-Prayer wrote: Le 14/11/2024 à 13:01, Tvrtko Ursulin a écrit : On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote: This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. I wonder if it would be

Re: [PATCH v2 10/29] drm/gpuvm: Add DRM_GPUVA_OP_USER

2024-11-19 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > Add DRM_GPUVA_OP_USER which allows driver to define their own gpuvm > ops. > > Cc: Danilo Krummrich > Signed-off-by: Matthew Brost > --- >  include/drm/drm_gpuvm.h | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/include/drm

Re: [PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-19 Thread Bjorn Andersson
On Tue, Nov 12, 2024 at 3:15 PM Akhil P Oommen wrote: > > On 11/11/2024 8:38 PM, Rob Clark wrote: > > On Sun, Nov 10, 2024 at 9:31 AM Bjorn Andersson > > wrote: > >> > >> Support for per-process page tables requires the SMMU aparture to be > >> setup such that the GPU can make updates with the SM

Re: [PATCH v2 1/3] drm/vmwgfx: Introduce userspace managed surfaces

2024-11-19 Thread Zack Rusin
On Fri, Oct 18, 2024 at 5:01 PM Maaz Mombasawala wrote: > > The kernel currently exposes both mobs and surfaces to userspace through > ioctls. We would like to move to a model where kernel would only expose > mobs and have userspace manage surfaces. This would simplify kernel paths > for surfaces

Re: [PATCH v2 2/3] drm/vmwgfx: Support hw_destroy for userspace managed surfaces

2024-11-19 Thread Zack Rusin
On Fri, Oct 18, 2024 at 5:01 PM Maaz Mombasawala wrote: > > A userspace may create a userspace managed surface but not destroy it, > add hw_destroy function for userspace surfaces so that vmwgfx records the > destroy command and submits it when the userspace context is destroyed. > > Signed-off-by

Re: [PATCH 2/2] nouveau/dp: handle retries for AUX CH transfers with GSP.

2024-11-19 Thread Ben Skeggs
On 11/11/24 13:41, Dave Airlie wrote: From: Dave Airlie eb284f4b3781 drm/nouveau/dp: Honor GSP link training retry timeouts tried to fix a problem with panel retires, however it appears the auxch also needs the same treatment, so add the same retry wrapper around it. This fixes some eDP pane

Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-11-19 Thread Johan Hovold
On Fri, Aug 30, 2024 at 07:36:32PM +0200, György Kurucz wrote: > For context, I have a Lenovo Yoga Slim 7x laptop, and was having issues > with the display staying black after sleep. As a workaround, I could > switch to a different VT and back. > > > [ 1185.831970] [dpu error]connector not conn

Re: [PATCH v2 14/29] drm/xe: Do not allow system allocator VMA unbind if the GPU has bindings

2024-11-19 Thread Matthew Brost
On Tue, Nov 19, 2024 at 05:33:11PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > > uAPI is designed with the the use case that only mapping a BO to a > > malloc'd address will unbind a system allocator VMA. Thus it doesn't > > make tons of sense to allow

Re: [PATCH v14 2/8] drm/ttm: Provide a shmem backup implementation

2024-11-19 Thread Thomas Hellström
On Tue, 2024-11-19 at 14:40 +0100, Christian König wrote: > Am 15.11.24 um 16:01 schrieb Thomas Hellström: > > Provide a standalone shmem backup implementation. > > Given the ttm_backup interface, this could > > later on be extended to providing other backup > > implementation than shmem, with one

Re: [PATCH v1 07/10] media: platform: mediatek: add isp_7x video ops

2024-11-19 Thread 胡俊光

[PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-19 Thread Neil Armstrong
Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b

[PATCH 0/5] Introduce drm sharpness property

2024-11-19 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural detail

Re: linux-next: build failure after merge of the random tree

2024-11-19 Thread Stephen Rothwell
Hi all, On Thu, 10 Oct 2024 15:38:55 +1100 Stephen Rothwell wrote: > > On Tue, 1 Oct 2024 13:44:23 +1000 Stephen Rothwell > wrote: > > > > After merging the random tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > > > Caused by commit > > > > 38d1a9d296c8

[PATCH] drm/vmwgfx: Add Fake EDID

2024-11-19 Thread Ian Forbes
Most compositors are using a change in EDID as an indicator to refresh their connector information on hotplug regardless of whether the connector was previously connected. Originally the hotplug_mode_update property was supposed to provide a hint to userspace to always refresh connector info on hot

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-11-19 Thread 胡俊光

RE: [PATCHv2 1/8] drm/i915/histogram: Define registers for histogram

2024-11-19 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv2 1/8] drm/i915/histogram: Defin

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-19 Thread Raag Jadav
On Tue, Nov 19, 2024 at 10:25:10AM +0530, Ghimiray, Himal Prasad wrote: > On 15-11-2024 10:37, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") > > as part of refactoring. > > > > Now

Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

2024-11-19 Thread Krzysztof Kozlowski
On 20/11/2024 07:18, keith zhao wrote: > + /* Unmute hotplug interrupt */ > + hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG, v_MASK_INT_HOTPLUG(1)); > + > + ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq, > + inno_hdmi_irq, IRQF_S

[PATCH v7 0/3] drm: adv7511: ADV7535 fixes

2024-11-19 Thread Biju Das
This patch series aims to fix 2 bugs in the ADV7535 driver 1) use-after-free bug in adv7533_attach_dsi() 2) Drop unsupported single lane. Changes in v7: - Dropped check for host_node as of_node_put() is a no-op when called with a NULL pointer. - Added Rb tag from Laurent for patch#1. Change

[PATCH v7 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
The host_node pointer was assigned and freed in adv7533_parse_dt(), and later, adv7533_attach_dsi() uses the same. Fix this use-after-free issue by dropping of_node_put() in adv7533_parse_dt() and calling of_node_put() in error path of probe() and also in the remove(). Fixes: 1e4d58cd7f88 ("drm/br

Re: [PATCH v2 16/29] drm/xe: Add migrate layer functions for SVM support

2024-11-19 Thread Matthew Brost
On Tue, Nov 19, 2024 at 05:45:27PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > > Add functions which migrate to / from VRAM accepting a single DPA > > argument (VRAM) and array of dma addresses (SRAM). > > > > v2: > >  - Don't unlock job_mutex in erro

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-19 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-11-15 09:17:15) > On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > > > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > > > > On T

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-11-19 Thread 胡俊光

[PATCH 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-11-19 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check v3: Fix build issue Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c | 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ .../gpu/drm/i915/display/intel_display_types.h

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-11-19 Thread 胡俊光

[PATCH v5 4/9] drm/vs: Add Hardware Functions for VS DC8200

2024-11-19 Thread keith zhao
This commit introduces hardware-based APIs for the VS DRM related to the DC8200 Signed-off-by: keith zhao --- MAINTAINERS|1 + drivers/gpu/drm/Kconfig|2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/verisilicon/Kconfig

[PATCH v5 0/9] drm/verisilicon : support DC8200 and inno hdmi

2024-11-19 Thread keith zhao
Verisilicon/DC8200 display controller IP has 2 display pipes and each pipe support a primary plane and a cursor plane . In addition, there are 4 overlay planes as 2 display pipes common resources. The first display pipe is bound to the inno HDMI encoder. The second display pipe is bound to Inter

[PATCH v5 1/9] dt-bindings: display: bindings for starfive, JH7110 display pipeline

2024-11-19 Thread keith zhao
- Added bindings to support the display subsystem on the JH7110 SoC. - Included the DC8200 display controller and Inno HDMI controller. - Created innosilicon,inno-hdmi.yaml schema containing common properties for the Inno DesignWare HDMI TX controller. This isn't a full device tree binding sp

[PATCH v5 5/9] drm/vs: Add Base API for VS Mode Configuration

2024-11-19 Thread keith zhao
This commit adds a base API for configuring VS modes, which will streamline the setup and management of display modes in the VS DRM subsystem. In this implementation, we are using drm_atomic_helper_commit_tail_rpm() instead of drm_atomic_helper_commit_tail() to ensure that we skip planes related t

[PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

2024-11-19 Thread keith zhao
move rochchip inno hdmi connector to a newly created directory named inno-hdmi.c, and rename rockchip/inno_hdmi.c to rockchip/inno_hdmi-rockchip.c This patch refines the Innosilicon HDMI architecture by abstracting the existing connector into a bridge architecture. The drm_bridge_connector_init fu

[PATCH v5 8/9] drm/vs: Add Innosilicon HDMI Support

2024-11-19 Thread keith zhao
This commit adds the Innosilicon HDMI driver, designed to interface with the VS display controller. The driver leverages the APIs provided by the Innosilicon HDMI bridge. Signed-off-by: keith zhao --- drivers/gpu/drm/verisilicon/Kconfig | 19 + drivers/gpu/drm/verisilicon/Makefile

[PATCH v5 9/9] drm/vs: Add VS DRM Master Driver for JH7110 SoC

2024-11-19 Thread keith zhao
The VS DRM master driver for the JH7110 System on Chip (SoC), along with the addition of a DMA GEM (Graphics Execution Manager) driver Signed-off-by: keith zhao --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_drv.c | 777 +++ 2 files chan

Re: [PATCH v1 03/10] media: platform: mediatek: add isp_7x seninf unit

2024-11-19 Thread 胡俊光

Re: [PATCH v2 13/29] drm/xe: Add unbind to SVM garbage collector

2024-11-19 Thread Matthew Brost
On Tue, Nov 19, 2024 at 04:31:05PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > > Add unbind to SVM garbage collector. To facilitate add unbind support > > function to VM layer which unbinds a SVM range. Also teach PY layer > > to > > understand unbinds

Re: [PATCH v5 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Tue, Nov 19, 2024 at 01:10:03PM +, Biju Das wrote: > The host_node pointer was assigned and freed in adv7533_parse_dt(), and > later, adv7533_attach_dsi() uses the same. Fix this use-after-free issue > by dropping of_node_put() in adv7533_parse_dt() and ca

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-19 Thread Gwan-gyeong Mun
On 10/16/24 6:24 AM, Matthew Brost wrote: + +/** + * drm_gpusvm_get_devmem_page - Get a reference to a device memory page + * @page: Pointer to the page + * @zdd: Pointer to the GPU SVM zone device data + * + * This function associates the given page with the specified GPU SVM zone + * device

Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-11-19 Thread Leonard Lausen
>> The issue of "internal display fails to resume properly (switching VT brings >> it back)" >> also affects sc7180 platform during some resumes. Do you see the issue >> consistently >> during every resume? > > Yes, it happens on every suspend cycle here. > > I didn't notice the issue initially

Re: [PATCH v2 17/29] drm/xe: Add SVM device memory mirroring

2024-11-19 Thread Gwan-gyeong Mun
On 10/16/24 6:25 AM, Matthew Brost wrote: +/** + * xe_devm_add: Remap and provide memmap backing for device memory + * @tile: tile that the memory region belongs to + * @mr: memory region to remap + * + * This remap device memory to host physical address space and create + * struct page to bac

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-11-19 Thread 胡俊光

[PATCH 3/5] drm/i915/display: Enable the second scaler for sharpness

2024-11-19 Thread Nemesa Garg
As only second scaler can be used for sharpness check if it is available and also check if panel fitting is also not enabled, then set the sharpness. Panel fitting will have the preference over sharpness property. v2: Add the panel fitting check before enabling sharpness v3: Reframe commit message

[PATCH 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-11-19 Thread Nemesa Garg
The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum.

[PATCH 4/5] drm/i915/display: Add registers and compute the strength

2024-11-19 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. v2: Replace i915/dev_priv with display[Jani] v3: Create separate file for defining register[Jani] Add display->drm in debug prints[Jani] v4: Rebase v5: Fix build issue Signed-off-by: Nemesa Gar

[PATCH 1/5] drm: Introduce sharpness strength property

2024-11-19 Thread Nemesa Garg
Introduces the new crtc property "SHARPNESS_STRENGTH" that allows the user to set the intensity so as to get the sharpness effect. The value of this property can be set from 0-255. It is useful in scenario when the output is blurry and user want to sharpen the pixels. User can increase/decrease the

[PATCH v2] drm/mediatek: Move mtk_crtc_finish_page_flip() to ddp_cmdq_cb()

2024-11-19 Thread Jason-JH . Lin
mtk_crtc_finish_page_flip() is used to notify userspace that a page flip has been completed, allowing userspace to free the frame buffer of the last frame and commit the next frame. In MediaTek's hardware design for configuring display hardware by using GCE, `DRM_EVENT_FLIP_COMPLETE` should be not

RE: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate"

2024-11-19 Thread Ying Liu
On 11/20/24, Marek Vasut wrote: > On 11/19/24 9:18 AM, Ying Liu wrote: > > [...] > > >> The TC9595 can drive an DP output, for that the clock which have to be > >> set on the LCDIF cannot be predicted, as that information comes from the > >> monitor EDID/DPCD. That is why the LCDIF has to be able

[PATCH v5 2/9] riscv: dts: Add display property

2024-11-19 Thread keith zhao
Add the display DT nodes in Starfive JH7110 soc-specific DT file. Signed-off-by: keith zhao --- .../boot/dts/starfive/jh7110-common.dtsi | 125 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 41 ++ 2 files changed, 166 insertions(+) diff --git a/arch/riscv/boot/dts

  1   2   >