Re: [PATCH] drm: use ATOMIC64_INIT() for atomic64_t

On Tue, 05 Nov 2024, Jonathan Gray wrote: > On Thu, Jan 11, 2024 at 11:56:20AM +0200, Jani Nikula wrote: >> On Thu, 11 Jan 2024, Jonathan Gray wrote: >> > use ATOMIC64_INIT() not ATOMIC_INIT() for atomic64_t >> > >> > Fixes: 3f09a0cd4ea3 ("drm: Add common fdinfo helper") >> > Signed-off-by: Jonat

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

> -Original Message- > From: Vivi, Rodrigo > Sent: Monday, November 4, 2024 11:16 PM > To: Usyskin, Alexander > Cc: Gupta, Anshuman ; Deak, Imre > ; Miquel Raynal ; > Richard Weinberger ; Vignesh Raghavendra > ; De Marchi, Lucas ; Thomas > Hellström ; Maarten Lankhorst > ; Maxime Ripard ;

Re: [PATCH v5 5/6] drm/log: Implement suspend/resume

On Mon 2024-11-04 16:38:53, John Ogness wrote: > On 2024-11-04, Petr Mladek wrote: > > I wonder whether console_start()/console_stop() should really > > manipulate CON_ENABLE flag. It might be historical solution when > > @console_suspended was a global variable. > > > > But it has changed with th

[PATCH v6 1/6] drm/panic: Move drawing functions to drm_draw

Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Jocelyn Falempe --- v5: * Export drm_draw symbols, so they can be used if drm_client_lib is

[PATCH v6 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks li

[PATCH v6 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. Design decisions: * It uses the drm_c

[PATCH v6 5/6] drm/log: Implement suspend/resume

Normally the console is already suspended when the graphic driver suspend callback is called, but if the parameter no_console_suspend is set, it might still be active. So call console_stop()/console_start() in the suspend/resume callbacks, to make sure it won't try to write to the framebuffer while

[PATCH v6 6/6] drm/log: Add integer scaling support

Add a module parameter, to increase the font size for HiDPI screen. Even with CONFIG_FONT_TER16x32, it can still be a bit small to read. In this case, adding drm_log.scale=2 to your kernel command line will double the character size. Signed-off-by: Jocelyn Falempe --- v5: * Change scale paramet

[PATCH v6 3/6] drm/log: Do not draw if drm_master is taken

When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/d

[PATCH v6 4/6] drm/log: Color the timestamp, to improve readability

Color the timesamp prefix, similar to dmesg. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/drivers/gpu/drm/drm_log.c index 226e206e8b6a3..635dff7b37ce5 1006

[PATCH v2 0/2] drm: adv7511: ADV7535 fixes

This patch series aims to fix 2 bugs in ADV7535 driver 1) use-after-free bug in adv7533_attach_dsi() 2) out-of-bounds array in adv7511_dsi_config_timing_gen() for clock_div_by_lanes[]. changes in v2: * Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. * Dropped invalid Mail add

Re: [PATCH v4 04/13] media: uapi: Add MEDIA_BUS_FMT_RGB101010_1X7X5_{SPWG, JEIDA}

On Tue, 5 Nov 2024 at 10:53, Sakari Ailus wrote: > > Hi Ying, > > On Mon, Oct 28, 2024 at 10:37:31AM +0800, Liu Ying wrote: > > Add two media bus formats that identify 30-bit RGB pixels transmitted > > by a LVDS link with five differential data pairs, serialized into 7 > > time slots, using standa

Re: (subset) [PATCH v5 00/13] Add ITE IT6263 LVDS to HDMI converter support

On Mon, 04 Nov 2024 11:27:53 +0800, Liu Ying wrote: > This patch series aims to add ITE IT6263 LVDS to HDMI converter on > i.MX8MP EVK. Combined with LVDS receiver and HDMI 1.4a transmitter, > the IT6263 supports LVDS input and HDMI 1.4 output by conversion > function. IT6263 product link can be

Re:[PATCH v7] rockchip/drm: vop2: add support for gamma LUT

Hi Piotr, At 2024-11-02 03:01:17, "Piotr Zalewski" wrote: >Add support for gamma LUT in VOP2 driver. The implementation was inspired >by one found in VOP1 driver. Blue and red channels in gamma LUT register >write were swapped with respect to how gamma LUT values are written in >VOP1. Gamma LUT

[PATCH v2 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

The host_node pointer assigned and freed in adv7533_parse_dt() and later adv7533_attach_dsi() uses the same. Fix this issue by freeing the host_node in adv7533_attach_dsi() instead of adv7533_parse_dt(). Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.o

Re: [PATCH] drm: use ATOMIC64_INIT() for atomic64_t

On Thu, Jan 11, 2024 at 11:56:20AM +0200, Jani Nikula wrote: > On Thu, 11 Jan 2024, Jonathan Gray wrote: > > use ATOMIC64_INIT() not ATOMIC_INIT() for atomic64_t > > > > Fixes: 3f09a0cd4ea3 ("drm: Add common fdinfo helper") > > Signed-off-by: Jonathan Gray > > Reviewed-by: Jani Nikula This pat

[PATCH 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

The host_node pointer assigned and freed in adv7533_parse_dt() and later adv7533_attach_dsi() uses the same. Fix this issue by freeing the host_node in adv7533_attach_dsi() instead of adv7533_parse_dt(). Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Signed-off-by: Biju Das

[PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

Fix out-of-bounds array in adv7511_dsi_config_timing_gen(), when dsi lanes = 1. Fixes: 78fa479d703c ("drm/bridge: adv7533: Use internal timing generator") Reported-by: Hien Huynh Signed-off-by: Biju Das --- Changes in v2: - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. - Dro

Re: [PATCH v6 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

On 2024-11-05, Jocelyn Falempe wrote: > drm_log is a simple logger that uses the drm_client API to print the > kmsg boot log on the screen. This is not a full replacement to fbcon, > as it will only print the kmsg. It will never handle user input, or a > terminal because this is better done in use

Re: [PATCH v6 5/6] drm/log: Implement suspend/resume

On 2024-11-05, Jocelyn Falempe wrote: > Normally the console is already suspended when the graphic driver > suspend callback is called, but if the parameter no_console_suspend > is set, it might still be active. > So call console_stop()/console_start() in the suspend/resume > callbacks, to make su

[PATCH] drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event()

The code for detecting and updating the connector status in cdn_dp_pd_event_work() has a number of problems. - It does not aquire the locks to call the detect helper and update the connector status. These are struct drm_mode_config.connection_mutex and struct drm_mode_config.mutex. - It does not

Re: [PATCH v1] drm/ci: remove update-xfails.py

On Thu, 31 Oct 2024 02:39:13 -0300 WangYuli wrote --- > > On 2024/10/30 17:17, Vignesh Raman wrote: > > We can remove the xfails/update-xfails.py script as it is not > > used in CI jobs. Once ci-collate [1] is tested for drm-ci, > > we can use this tool directly to update fails

Re: [PATCH v2] dt-bindings: display: mediatek: dp: Reference common DAI properties

On Tue, 05 Nov 2024 17:00:28 +0800, Fei Shao wrote: > The MediaTek DP hardware supports audio and exposes a DAI, so the > '#sound-dai-cells' property is needed for describing the DAI links. > > Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be > used, and filter out non-DP c

Re: [PATCH v6 5/6] drm/log: Implement suspend/resume

On Tue 2024-11-05 13:42:25, Jocelyn Falempe wrote: > Normally the console is already suspended when the graphic driver > suspend callback is called, but if the parameter no_console_suspend > is set, it might still be active. > So call console_stop()/console_start() in the suspend/resume > callbacks

[PATCH 10/21] drm/imagination: Remove firmware enable_reg

After the previous commit ("drm/imagination: Revert to non-threaded IRQs"), this register is now only used to enable firmware interrupts at start-of-day. This is, however, unnecessary since they are enabled by default. In addition, the soon-to-be-added RISC-V firmware processors do not have an equ

[PATCH 21/21] arm64: dts: ti: k3-j721s2: Add GPU node

The J721S2 binding is based on the TI downstream binding in 54b0f2a00d92 ("arm64: dts: ti: k3-j721s2-main: add gpu node") from [1] but with updated compatible strings. The clock[2] and power[3] indices were verified from docs, but the source of the interrupt index remains elusive. References for

[PATCH 20/21] drm/imagination: Add support for TI AM68 GPU

Add the new compatible string recently introduced in the dt bindings ("img,img-bxs-4-64") to the dt_match table and link the appropriate firmware. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/imag

[PATCH 18/21] drm/imagination: Add platform overrides infrastructure

This infrastructure will be used in cases where a specific GPU integration or implementation requires some special handling in the driver. The first use case is the device cached memory override added in the next patch. The infrastructure is built out in this separate commit to make it clear which

[PATCH 05/21] drm/imagination: Use more specific compatible strings

Follow-on from the companion dt-bindings change ("dt-bindings: gpu: img: More explicit compatible strings"), deprecating "img,img-axe" in favour of the more specific "img,img-axe-1-16m". Keep the previous compatible string around for backwards compatibility. Signed-off-by: Matt Coster --- drive

[PATCH 19/21] drm/imagination: Add device_memory_force_cpu_cached override

The TI k3-j721s2 platform has a bug relating to cache snooping on the AXI ACE-Lite interface. Disabling cache snooping altogether would also resolve the issue, but is considered more of a performance hit. Given the platform is dma-coherent, forcing all device-accessible memory allocations through

[PATCH 14/21] drm/imagination: Use callbacks for fw irq handling

This allows for more versatility in checking and clearing firmware registers used for interrupt handling. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_device.h | 18 + drivers/gpu/drm/imagination/pvr_fw.h | 45 +-- drivers/gpu/drm/i

[PATCH 04/21] dt-bindings: gpu: img: Allow dma-coherent

This attribute will be required for the BXS-4-64 MC1 and will be enabled in the DTS for the TI k3-j721s2 in a subsequent patch; add it now so dtbs_check doesn't complain later. Signed-off-by: Matt Coster --- Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 2 ++ 1 file changed, 2 i

[PATCH 02/21] dt-bindings: gpu: img: Further constrain clocks

All Imagination GPUs use three clocks: core, mem and sys. All reasonably modern Imagination GPUs also support a single-clock mode where the SoC only hooks up core and the other two are derived internally. On GPUs which support this mode, it is the default and most commonly used integration. Codify

[PATCH 13/21] drm/imagination: Use a lookup table for fw defs

With more than two firmware processor types, the if/else chain in pvr_fw_init() gets a bit ridiculous. Use a static array indexed on pvr_fw_processor_type (which is now a proper enum instead of #defines) instead. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_device.h | 4

[PATCH 03/21] dt-bindings: gpu: img: Power domain details

The single existing GPU (AXE-1-16M) only requires a single power domain. Subsequent patches will add support for BXS-4-64 MC1, which has two power domains. Add infrastructure now to allow for this. Signed-off-by: Matt Coster --- .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 29 +++

[PATCH 00/21] Imagination BXS-4-64 MC1 GPU support

This GPU is found in the TI AM68 family of SoCs, with initial support added to the k3-j721s2 devicetree and tested on a TI SK-AM68 board. A suitable firmware binary can currently be found in the IMG linux-firmware repository[1] as powervr/rogue_36.53.104.796_v1.fw. A merge request will be sent out

[PATCH 07/21] arm64: dts: ti: k3-am62: New GPU binding details

Use the new compatible string introduced earlier (in "dt-bindings: gpu: img: More explicit compatible strings") and add a name to the single power domain for this GPU (introduced in "dt-bindings: gpu: img: Power domain details"). Signed-off-by: Matt Coster --- arch/arm64/boot/dts/ti/k3-am62-main

[PATCH 06/21] drm/imagination: Add power domain control

The first supported GPU only used a single power domain so this was automatically handled by the device runtime. In order to support multiple power domains, they must be enumerated from devicetree and linked to both the GPU device and each other to ensure correct power sequencing at start time. F

Re: [PATCH v1] drm/i915/guc: Flush ct receive tasklet during reset preparation

On 2024-11-04 6:20 p.m., Daniele Ceraolo Spurio wrote: On 10/30/2024 3:38 PM, Zhanjun Dong wrote: GuC to host communication is interrupt driven, the handling has 3 parts: interrupt context, tasklet and request queue worker. During GuC reset prepare, interrupt is disabled before destroy con

Re: [PATCH v2 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

Hi Biju, Thank you for the patch. On Tue, Nov 05, 2024 at 11:12:18AM +, Biju Das wrote: > The host_node pointer assigned and freed in adv7533_parse_dt() > and later adv7533_attach_dsi() uses the same. Fix this issue > by freeing the host_node in adv7533_attach_dsi() instead of > adv7533_parse

[PATCH 17/21] drm/imagination: Add RISC-V firmware processor support

From: Sarah Walker Newer PowerVR GPUs (such as the BXS-4-64 MC1) use a RISC-V firmware processor instead of the previous MIPS or META. Signed-off-by: Sarah Walker Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_fw.c

[PATCH 12/21] drm/imagination: Make has_fixed_data_addr a value

This is currently a callback function which takes no parameters; there's no reason for this so let's make it a straightforward value in pvr_fw_defs. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_fw.c | 2 +- drivers/gpu/drm/imagination/pvr_fw.h | 23 --

Re: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

Hi Biju, Thank you for the patch. On Tue, Nov 05, 2024 at 11:12:19AM +, Biju Das wrote: > Fix out-of-bounds array in adv7511_dsi_config_timing_gen(), > when dsi lanes = 1. Does the hardware support using the internal timing generator with a single lane ? If so adv7511_dsi_config_timing_gen()

[PATCH 16/21] drm/imagination: Move ELF fw utils to common file

Currently only MIPS firmware processors use ELF-formatted firmware. When adding support for RISC-V firmware processors, it will be useful to have ELF handling functions ready to go. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_f

Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

On Sun, Nov 03, 2024 at 05:03:31PM +, Thomas Weißschuh wrote: > Several drivers need to dynamically calculate the size of an binary > attribute. Currently this is done by assigning attr->size from the > is_bin_visible() callback. s/an binary/a binary/ > This has drawbacks: > * It is not docum

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

On Tue, Nov 05, 2024 at 11:22:12AM +0100, Thomas Hellström wrote: > On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > > We > > > have > > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > > erval_tree_generic.h#L24 > > > > > > to relate to. Now GPUVM can't use the

Re: (subset) [PATCH v5 00/13] Add ITE IT6263 LVDS to HDMI converter support

On Tue, Nov 05, 2024 at 01:28:48PM +0200, Dmitry Baryshkov wrote: > On Mon, 04 Nov 2024 11:27:53 +0800, Liu Ying wrote: > > This patch series aims to add ITE IT6263 LVDS to HDMI converter on > > i.MX8MP EVK. Combined with LVDS receiver and HDMI 1.4a transmitter, > > the IT6263 supports LVDS input

Re: [PATCH v2 00/10] sysfs: constify struct bin_attribute (Part 1)

On Sun, Nov 03, 2024 at 05:03:29PM +, Thomas Weißschuh wrote: > struct bin_attribute contains a bunch of pointer members, which when > overwritten by accident or malice can lead to system instability and > security problems. > Moving the definitions of struct bin_attribute to read-only memory >

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

On Tue, Nov 05, 2024 at 09:15:03AM +0100, Herve Codina wrote: > On Mon, 28 Oct 2024 16:09:13 +0200 Laurent Pinchart wrote: > > On Mon, Oct 28, 2024 at 02:55:47PM +0100, Maxime Ripard wrote: > > > On Mon, Oct 28, 2024 at 03:28:58PM +0200, Laurent Pinchart wrote: > > > > On Mon, Oct 28, 2024 at 01:

Re: [PATCH] drm/panthor: Be stricter about IO mapping flags

On Tue, Nov 05, 2024 at 12:17:13AM +0100, Jann Horn wrote: > The current panthor_device_mmap_io() implementation has two issues: > > 1. For mapping DRM_PANTHOR_USER_FLUSH_ID_MMIO_OFFSET, >panthor_device_mmap_io() bails if VM_WRITE is set, but does not clear >VM_MAYWRITE. That means userspa

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

On Tue, Nov 05, 2024 at 09:15:03AM +0100, Herve Codina wrote: > Hi Maxime, Laurent, > > On Mon, 28 Oct 2024 16:09:13 +0200 > Laurent Pinchart wrote: > > > On Mon, Oct 28, 2024 at 02:55:47PM +0100, Maxime Ripard wrote: > > > On Mon, Oct 28, 2024 at 03:28:58PM +0200, Laurent Pinchart wrote: > >

Re: [PATCH 1/7] dt-bindings: display: panel: Rename rg35xx-plus-panel back to WL-355608-A8

On Tue, Nov 05, 2024 at 02:52:29PM +0900, Hironori KIKUCHI wrote: > A panel assembly is changed in the recent revision of Anbernic RG35XX > Plus, so the `anbernic,rg35xx-plus-panel` identifier is neither suitable > nor unique for the panel anymore. > > Fortunately, the panel can be distinguished b

[Bug 219468] Screen flickering on Radeon 680M - 6.12

https://bugzilla.kernel.org/show_bug.cgi?id=219468 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v5 5/6] drm/log: Implement suspend/resume

On 2024-11-05, Petr Mladek wrote: > Observation: > > + CON_ENABLED is not needed for the original purpose. Only enabled > consoles are added into @console_list. > > + CON_ENABLED is still used to explicitely block the console driver > during suspend by console_stop()/console_start() in

Re: [PATCH v18 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

> > On Tue, Oct 29, 2024 at 02:02:14PM +0800, Sandor Yu wrote: > > Add Cadence HDP-TX DisplayPort and HDMI PHY driver for i.MX8MQ. > > > > Cadence HDP-TX PHY could be put in either DP mode or > > HDMI mode base on the configuration chosen. > > DisplayPort or HDMI PHY mode is configured in the driv

Re: [PATCH v18 1/8] drm: bridge: Cadence: Create MHDP helper driver

> > On Tue, Oct 29, 2024 at 02:02:09PM +0800, Sandor Yu wrote: > > Mailbox access functions in MHDP8546 will be share to other MHDP > > driver and Cadence HDP-TX HDMI/DP PHY drivers. > > > > Create a new MHDP helper driver and move all mailbox access functions > into. > > According the mailbox acc

Re: [PATCH v18 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

> On Tue, Oct 29, 2024 at 02:02:11PM +0800, Sandor Yu wrote: > > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. > > > > Signed-off-by: Sandor Yu > > --- > > v17->v18: > > - remove lane-mapping and replace it with data-lanes > > - remove r-b tag as property changed. > > > > v16->v17: >

Re: [PATCH] drm/vkms: avoid race-condition between flushing and destroying

On 29/07/23 - 19:49, Maíra Canal wrote: > After we flush the workqueue at the commit tale, we need to make sure > that no work is queued until we destroy the state. Currently, new work > can be queued in the workqueue, even after the commit tale, as the > vblank thread is still running. > > Theref

[PATCH] drm/sched: Improve teardown documentation

If jobs are still enqueued in struct drm_gpu_scheduler.pending_list when drm_sched_fini() gets called, those jobs will be leaked since that function stops both job-submission and (automatic) job-cleanup. It is, thus, up to the driver to take care of preventing leaks. The related function drm_sched

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: Continued review: > +/** > + * drm_gpusvm_migrate_unmap_pages() - Unmap pages previously mapped > for GPU SVM migration > + * @dev: The device for which the pages were mapped > + * @dma_addr: Array of DMA addresses corresponding to mapped p

Re: [PATCH] drm/panthor: Be stricter about IO mapping flags

On Tue, Nov 5, 2024 at 10:56 AM Liviu Dudau wrote: > On Tue, Nov 05, 2024 at 12:17:13AM +0100, Jann Horn wrote: > > The current panthor_device_mmap_io() implementation has two issues: > > > > 1. For mapping DRM_PANTHOR_USER_FLUSH_ID_MMIO_OFFSET, > >panthor_device_mmap_io() bails if VM_WRITE is

Re: [PATCH v5 04/13] media: uapi: Add MEDIA_BUS_FMT_RGB101010_1X7X5_{SPWG, JEIDA}

On Mon, Nov 04, 2024 at 02:00:56PM +0200, Dmitry Baryshkov wrote: > On Mon, Nov 04, 2024 at 11:27:57AM +0800, Liu Ying wrote: > > Add two media bus formats that identify 30-bit RGB pixels transmitted > > by a LVDS link with five differential data pairs, serialized into 7 > > time slots, using stand

[PATCH] drm/vmwgfx: Remove initialization of connector status

Remove the connector-status initialization from several of vmwgfx's functions. It is not required by the driver or DRM helpers. DRM initializes the connector to unknown status in __drm_connector_init() and reads the physical status when DRM clients or the user needs the information, or if it detec

Re: [PATCH] drm/vmwgfx: Remove initialization of connector status

Prepares for an update of https://patchwork.freedesktop.org/series/139879/ . Am 05.11.24 um 14:20 schrieb Thomas Zimmermann: Remove the connector-status initialization from several of vmwgfx's functions. It is not required by the driver or DRM helpers. DRM initializes the connector to unknown

Re: [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions

* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > cdns_mhdp_hdcp_set_lc() and cdns_mhdp_hdcp_set_public_key_param() > were added by commit > 6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP") > but never used. > > Remove them. > > Signed-off-by: Dr. David

Re: [PATCH] drm/rockchip: cdn-dp: Remove unused functions

* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > cdn_dp_get_event and cdn_dp_dpcd_write were added in 2017 by commit > 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") > > but unused. > Remove them. > (Build tested only on x86-64) > > Signe

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

On Sun, Nov 03, 2024 at 05:03:34PM +, Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the

[PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings

Like the existing AXE-1-16M integration, BXS-4-64 uses the single clock integration in the TI k3-j721s2. Signed-off-by: Matt Coster --- .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 45 ++ 1 file changed, 45 insertions(+) diff --git a/Documentation/devicetree/bindings

Re: [PATCH bpf-next 2/2] bpf: Switch bpf arena to use drm_mm instead of maple_tree

/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20241101235453.63380-3-alexei.starovoitov%40gmail.com patch subject: [PATCH bpf-next 2/2] bpf: Switch bpf arena to use drm_mm instead of maple_tree config: sparc-randconfig-r061-20241105 (https://download.01.org/0day-ci

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

On Tue, Nov 05, 2024 at 03:48:24PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > Continued review: > > > +/** > > + * drm_gpusvm_migrate_unmap_pages() - Unmap pages previously mapped > > for GPU SVM migration > > + * @dev: The device for which the

RE: [PATCH v2 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: 05 November 2024 16:02 > Subject: Re: [PATCH v2 1/2] drm: adv7511: Fix use-after-free in > adv7533_attach_dsi() > > Hi Biju, > > Thank you for the patch. > > On Tue, Nov 05, 2024 at 11:12:18AM

[PATCH 15/21] drm/imagination: Add register required for RISC-V firmware

Add definitions for a register required for a subsequent patch adding support for RISC-V firmware. ROGUE_CR_FWCORE_DMI_DMCONTROL is used to control the debug module in the firmware processor. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_rogue_cr_defs.h | 17 - 1

[PATCH 01/21] dt-bindings: gpu: img: More explicit compatible strings

The current compatible strings are not specific enough to constrain the hardware in devicetree. For example, the current "img,img-axe" string refers to the entire family of Series AXE GPUs. The more specific "img,img-axe-1-16m" string refers to the AXE-1-16M GPU which, unlike the rest of its family

[PATCH 11/21] drm/imagination: Rename event_mask -> status_mask

Now that enable_reg isn't used, rename the previously shared event_mask to status_mask since it's only used with status_reg. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_fw.h | 6 +++--- drivers/gpu/drm/imagination/pvr_fw_meta.c | 2 +- drivers/gpu/drm/imagination/pvr_fw_m

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

On Tue, 2024-11-05 at 08:12 -0800, Matthew Brost wrote: > On Tue, Nov 05, 2024 at 11:22:12AM +0100, Thomas Hellström wrote: > > On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > > > We > > > > have > > > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > > > erval_t

Re: [PATCH v2 2/3] iommu/io-pgtable-arm-v7s: Remove split on unmap behavior

On Mon, Nov 04, 2024 at 04:09:51PM -0400, Jason Gunthorpe wrote: > Runs OK now: > > arm-v7s io-pgtable: self test ok > arm-lpae io-pgtable: selftest: pgsize_bitmap 0x40201000, IAS 32 > > Jason > > --- a/drivers/iommu/io-pgtable-arm-v7s.c > +++ b/drivers/iommu/io-pgtable-arm-v7s.c > @@ -819,7 +81

Re: [PATCH v2 2/3] iommu/io-pgtable-arm-v7s: Remove split on unmap behavior

On Tue, Nov 05, 2024 at 04:59:43PM +, Will Deacon wrote: > > /* Full unmap */ > > iova = 0; > > for_each_set_bit(i, &cfg.pgsize_bitmap, BITS_PER_LONG) { > > Yup, and you can do the same for the other selftest in io-pgtable-arm.c Ugh, yes, I ran it and thought the log it printed wa

Re: [PATCH 2/2] drm: bridge: ti-sn65dsi83: Add error recovery mechanism

Hi Maxime, Laurent, On Mon, 28 Oct 2024 16:09:13 +0200 Laurent Pinchart wrote: > On Mon, Oct 28, 2024 at 02:55:47PM +0100, Maxime Ripard wrote: > > On Mon, Oct 28, 2024 at 03:28:58PM +0200, Laurent Pinchart wrote: > > > On Mon, Oct 28, 2024 at 01:21:45PM +0100, Maxime Ripard wrote: > > > > O

Re: [PATCH] drm/panthor: Be stricter about IO mapping flags

On Tue, 05 Nov 2024 00:17:13 +0100 Jann Horn wrote: > The current panthor_device_mmap_io() implementation has two issues: > > 1. For mapping DRM_PANTHOR_USER_FLUSH_ID_MMIO_OFFSET, >panthor_device_mmap_io() bails if VM_WRITE is set, but does not clear >VM_MAYWRITE. That means userspace ca

[PATCH v2] dt-bindings: display: mediatek: dp: Reference common DAI properties

The MediaTek DP hardware supports audio and exposes a DAI, so the '#sound-dai-cells' property is needed for describing the DAI links. Reference the dai-common.yaml schema to allow '#sound-dai-cells' to be used, and filter out non-DP compatibles as MediaTek eDP in the same binding doesn't support a

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

Re: [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build

On Sun, 03 Nov 2024, Jonathan Gray wrote: > intel_pxp_gsccs_is_ready_for_sessions() is gated by CONFIG_DRM_I915_PXP > but called from intel_pxp.c which isn't. Provide a fallback inline > function to fix the non-optimised build. > > Fixes: 99afb7cc8c44 ("drm/i915/pxp: Add ARB session creation and

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

Am 04.11.24 um 22:49 schrieb Matthew Brost: On Mon, Nov 04, 2024 at 08:28:34PM +0100, Christian König wrote: Am 04.11.24 um 18:34 schrieb Rodrigo Vivi: On Thu, Oct 31, 2024 at 04:43:19PM -0700, Matthew Brost wrote: On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: Non-contiguous

Re: [PATCH] drm/vkms: Remove usage of legacy drm_crtc members

On 03/10/24 - 17:41, Louis Chauvet wrote: > Some members of the drm_crtc structure have been deprecated in favor of > equivalent members in the drm_crtc_state structure. As reported by Ville > Syrjala [1], the VKMS driver was still using these deprecated fields. This > commit updates the VKMS drive

[Bug 219468] New: Screen flickering on Radeon 680M - 6.12

https://bugzilla.kernel.org/show_bug.cgi?id=219468 Bug ID: 219468 Summary: Screen flickering on Radeon 680M - 6.12 Product: Drivers Version: 2.5 Hardware: AMD OS: Linux Status: NEW Severity: low

Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

On Mon Nov 4, 2024 at 12:52 PM PST, André Almeida wrote: > Hi Christopher, > > Em 03/11/2024 03:36, Christopher Snowhill escreveu: > > On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote: > >> Currently, DRM atomic uAPI allows only primary planes to be flipped > >> asynchronously. However, each

[Bug 219468] Screen flickering on Radeon 680M - 6.12

https://bugzilla.kernel.org/show_bug.cgi?id=219468 --- Comment #1 from Joungmin Lee (leejm...@gmail.com) --- Created attachment 307142 --> https://bugzilla.kernel.org/attachment.cgi?id=307142&action=edit kernel configuration kernel config -- You may reply to this email to add a comment. You

[Bug 219468] Screen flickering on Radeon 680M - 6.12

https://bugzilla.kernel.org/show_bug.cgi?id=219468 Joungmin Lee (leejm...@gmail.com) changed: What|Removed |Added Kernel Version||6.12 --- Comment #2 f

Re: [PATCH v4] drm/xe: Fix build error for XE_IOCTL_DBG macro

> there were some checkpatch issues about mixing tabs and spaces. Next > time please double check the checkpatch output. I also reworded the > commit message a little bit to follow an imperative mood as outlined at > https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#describe-you

[Bug 219468] Screen flickering on Radeon 680M - 6.12

https://bugzilla.kernel.org/show_bug.cgi?id=219468 --- Comment #3 from Joungmin Lee (leejm...@gmail.com) --- System info from inxi System: Host: leej-zenbook Kernel: 6.12.0-rc6-1-llvm-241014 arch: x86_64 bits: 64 compiler: clang v: 19.1.3 clocksource: tsc avail: acpi_pm parameter

[PATCH 3/4] drm/i915/display: Add async_flip flag in get_modifiers

get_modifiers will get the list of modifiers supported by the plane. Add a flag async_flip to fetch only the async_flip supported modifiers. Also expose function to get the number of modifiers supported by the platform. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/i9xx_plane.c

[PATCH 4/4] drm/i915/display: Add async supported formats/modifiers

Add the formats/modifiers supported by asynchronous flips by the platform based on the plane capabilities. Signed-off-by: Arun R Murthy --- .../drm/i915/display/skl_universal_plane.c| 22 +++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_univ

[PATCH 1/4] drm/plane: Add new plane property IN_FORMATS_ASYNC

There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flips are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flips

[PATCH 2/4] drm/i915/fb: Add async field to the modifiers description

Few of the modifiers are not supported with async flip. Add an element async_flip to say if the modifier supports asynchronous flips. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_fb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/d

[PATCH 0/4] Expose modifiers/formats supported by async flips

All of the formats/modifiers supported by the plane during synchronous flips are nor supported by asynchronous flips. The formats/modifiers exposed to user by IN_FORMATS exposes all formats/modifiers supported by plane and this list varies for async flips. If the async flip supported formats/modifi

Re: [PATCH V3 drm-dp 3/4] drm/hisilicon/hibmc: add dp hw moduel in hibmc

On Tue, 5 Nov 2024 at 06:06, Yongbang Shi wrote: > > > On Fri, Nov 01, 2024 at 06:50:27PM +0800, Yongbang Shi wrote: > >> From: baihan li > >> > >> Build a dp level that hibmc driver can enable dp by > >> calling their functions. > >> > >> Signed-off-by: baihan li > >> Signed-off-by: yongbang sh

Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

On Tue, 5 Nov 2024 at 10:15, Christopher Snowhill wrote: > > On Mon Nov 4, 2024 at 12:52 PM PST, André Almeida wrote: > > Hi Christopher, > > > > Em 03/11/2024 03:36, Christopher Snowhill escreveu: > > > On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote: > > >> Currently, DRM atomic uAPI all

Re: [PATCH v4 04/13] media: uapi: Add MEDIA_BUS_FMT_RGB101010_1X7X5_{SPWG, JEIDA}

Hi Ying, On Mon, Oct 28, 2024 at 10:37:31AM +0800, Liu Ying wrote: > Add two media bus formats that identify 30-bit RGB pixels transmitted > by a LVDS link with five differential data pairs, serialized into 7 > time slots, using standard SPWG/VESA or JEIDA data mapping. > > Signed-off-by: Liu Yin

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

On Mon, 2024-11-04 at 15:07 -0800, Matthew Brost wrote: > > We > > have > > https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/int > > erval_tree_generic.h#L24 > > > > to relate to. Now GPUVM can't use the generic version since it > > needs > > u64 intervals. These trees need unsigned

  1   2   >