Re: [PATCH 3/5] perf: Add pmu get/put

2024-10-14 Thread Lucas De Marchi
On Mon, Oct 14, 2024 at 09:25:19PM +0200, Peter Zijlstra wrote: On Mon, Oct 14, 2024 at 01:20:34PM -0500, Lucas De Marchi wrote: On Mon, Oct 14, 2024 at 07:32:46PM +0200, Peter Zijlstra wrote: > I'm confused.. probably because I still don't have any clue about > drivers and the above isn't re

Re: [PATCH v2] locking/ww_mutex: Adjust to lockdep nest_lock requirements

2024-10-14 Thread Boqun Feng
Hi Thomas, On Wed, Oct 09, 2024 at 11:20:31AM +0200, Thomas Hellström wrote: > When using mutex_acquire_nest() with a nest_lock, lockdep refcounts the > number of acquired lockdep_maps of mutexes of the same class, and also > keeps a pointer to the first acquired lockdep_map of a class. That point

Re: [PATCH v2] drm/msm/dpu: don't always activate merge_3d block

2024-10-14 Thread Jessica Zhang
On 10/14/2024 12:13 AM, Dmitry Baryshkov wrote: On Sun, Oct 13, 2024 at 07:37:20PM -0700, Abhinav Kumar wrote: Hi Dmitry On 10/13/2024 5:20 PM, Dmitry Baryshkov wrote: On Fri, Oct 11, 2024 at 10:25:13AM -0700, Jessica Zhang wrote: Only enable the merge_3d block for the video phys encoder w

Re: vc4: HDMI Sink doesn't support RGB, something's wrong.

2024-10-14 Thread Stefan Wahren
Am 14.10.24 um 12:54 schrieb Dave Stevenson: On Mon, 14 Oct 2024 at 10:04, Maxime Ripard wrote: Hi, On Sun, Oct 13, 2024 at 09:57:58PM GMT, Stefan Wahren wrote: Am 13.10.24 um 21:11 schrieb Dave Stevenson: Hi Stefan. On Sun, 13 Oct 2024, 18:19 Stefan Wahren, wrote: Hi, i rece

Re: [PATCH v2 1/2] drm/msm/dsi: improve/fix dsc pclk calculation

2024-10-14 Thread Abhinav Kumar
On 10/6/2024 10:01 PM, Jonathan Marek wrote: drm_mode_vrefresh() can introduce a large rounding error, avoid it. Fixes: 7c9e4a554d4a ("drm/msm/dsi: Reduce pclk rate for compression") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] accel/qaic: Add crashdump to Sahara

2024-10-14 Thread Bjorn Andersson
On Wed, Sep 18, 2024 at 09:52:54AM -0600, Jeffrey Hugo wrote: > The Sahara protocol has a crashdump functionality. In the hello > exchange, the device can advertise it has a memory dump available for > the host to collect. Instead of the device making requests of the host, > the host requests data

[PATCH] drm/i915/lspcon: do not hardcode settle timeout

2024-10-14 Thread Giedrius Statkevičius
Avoid hardcoding the LSPCON settle timeout because it takes a longer time on certain chips made by certain vendors. Use the function that already exists to determine the timeout. Signed-off-by: Giedrius Statkevičius --- drivers/gpu/drm/display/drm_dp_dual_mode_helper.c | 3 +-- drivers/gpu/drm/i

Re: [PATCH 1/5] perf: Add dummy pmu module

2024-10-14 Thread Jeff Johnson
On 10/8/24 11:34, Lucas De Marchi wrote: ... > +module_init(dummy_init); > +module_exit(dummy_exit); > + > +MODULE_AUTHOR("Lucas De Marchi "); > +MODULE_LICENSE("GPL"); Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPT

Re: [PATCH v10 0/2] Add driver for Sharp Memory LCD

2024-10-14 Thread Alex Lanzano
On Mon, Oct 14, 2024 at 10:35:03AM GMT, Dmitry Baryshkov wrote: > On Mon, Oct 07, 2024 at 11:03:09PM -0400, Alex Lanzano wrote: > > This patch series add support for the monochrome Sharp Memory LCD > > panels. This series is based off of the work done by Mehdi Djait. > > > > References: > > https:

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-10-14 Thread Danilo Krummrich
On Sat, Oct 05, 2024 at 09:04:11AM -0700, Kees Cook wrote: > > > > >On 03/10/24 12:36, Danilo Krummrich wrote: > >> On 9/13/24 12:23 PM, Danilo Krummrich wrote: > > I am reminded that I should check all my MUAs to render the date as > -MM-DD so my brain doesn't explode when I see people "t

Re: [PATCH V4 07/10] accel/amdxdna: Add command execution

2024-10-14 Thread Matthew Brost
On Fri, Oct 11, 2024 at 04:12:41PM -0700, Lizhi Hou wrote: > Add interfaces for user application to submit command and wait for its > completion. > > Co-developed-by: Min Ma > Signed-off-by: Min Ma > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/aie2_ctx.c | 624 +

Re: [PATCH] fbdev: Constify struct sbus_mmap_map

2024-10-14 Thread Helge Deller
On 10/13/24 13:48, Christophe JAILLET wrote: 'struct sbus_mmap_map' are not modified in these drivers. Constifying this structure moves some data to a read-only section, so increases overall security. Update sbusfb_mmap_helper() accordingly. On a x86_64, with allmodconfig, as an example: Befor

Re: [PATCH] video: fix inconsistent indentation warning

2024-10-14 Thread Helge Deller
On 10/6/24 09:15, SurajSonawane2415 wrote: Fix the indentation to ensure consistent code style and improve readability, and to fix this warning: drivers/video/fbdev/nvidia/nv_hw.c:1512 NVLoadStateExt() warn: inconsistent indenting Signed-off-by: SurajSonawane2415 --- drivers/video/fbdev/nvidi

Re: [PATCH 6/7] drm/panic: allow verbose boolean for clarity

2024-10-14 Thread Jocelyn Falempe
On 14/10/2024 18:59, Miguel Ojeda wrote: On Mon, Oct 14, 2024 at 10:54 AM Jocelyn Falempe wrote: With the suggestions from Alice Ryhl to not introduce a return, and use expect: +1 to both. `expect` (here and the other ones I suggested) require `rust-next`, so if this goes through DRM, then

Re: [PATCH 3/5] perf: Add pmu get/put

2024-10-14 Thread Peter Zijlstra
On Mon, Oct 14, 2024 at 01:20:34PM -0500, Lucas De Marchi wrote: > On Mon, Oct 14, 2024 at 07:32:46PM +0200, Peter Zijlstra wrote: > > I'm confused.. probably because I still don't have any clue about > > drivers and the above isn't really telling me much either. > > > > I don't see how you get r

[PATCH 1/9] drm/panfrost: Replace DRM driver allocation method with newer one

2024-10-14 Thread Adrián Larumbe
Drop the deprecated DRM driver allocation method in favour of devm_drm_dev_alloc(). Overall just make it the same as in Panthor. Also discard now superfluous generic and platform device pointers inside the main panfrost device structure. Some ancient checkpatch issues unearthed as a result of thes

[PATCH 2/9] drm/panfrost: handle inexistent GPU during probe

2024-10-14 Thread Adrián Larumbe
Just in case we're dealing with a yet not recognised device. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost

[PATCH 3/9] drm/panfrost: handle error when allocating AS number

2024-10-14 Thread Adrián Larumbe
If we reach the beginning of the LRU AS list, then trigger an error. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 4 +++- drivers/gpu/drm/panfrost/panfrost_mmu.c | 8 +--- drivers/gpu/drm/panfrost/panfrost_mmu.h | 2 +- drivers/gpu/drm/panfrost/panf

[PATCH 4/9] drm/panfrost: handle job hw submit errors

2024-10-14 Thread Adrián Larumbe
Avoid waiting for the DRM scheduler job timeout handler and let the DRM scheduler core signal the error fence immediately instead when HW job submission fails. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 17 - 1 file changed, 12 insertions(+), 5 de

[PATCH 5/9] drm/panfrost: Handle page mapping failure

2024-10-14 Thread Adrián Larumbe
Right now Panfrost's GPU page fault IRQ assumes the architectural page mapping function always suceeds. That might not always be the case, so we haravest its return status and unmap whatever we had mapped so far. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 66

[PATCH 6/9] drm/panfrost: Avoid re-enabling job interrupts in the reset path

2024-10-14 Thread Adrián Larumbe
Rather than remasking interrupts after a device reset in the main reset path, allow selecting whether to do this with an additional bool parameter. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 6 +++--- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- driver

[PATCH 8/9] drm/panfrost: Add forward declaration and types header

2024-10-14 Thread Adrián Larumbe
This is to make LLVM syntactic analysers happy. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_mmu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.h b/drivers/gpu/drm/panfrost/panfrost_mmu.h index 0b2c0b59db3f..a19282a22aab 100

[PATCH 7/9] drm/panfrost: Refactor job IRQ enabling sequence

2024-10-14 Thread Adrián Larumbe
Just a convenience macro to avoid reduplication. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c index 68

[PATCH 9/9] drm/panfrost: Explicitly clean up panfrost fence

2024-10-14 Thread Adrián Larumbe
Doesn't make any functional difference because generic dma_fence is the first panfrost_fence structure member, but I guess it doesn't hurt either. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/p

Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Liu Ying
On 10/14/2024, Dmitry Baryshkov wrote: > On Mon, Oct 14, 2024 at 01:33:44PM +0800, Liu Ying wrote: >> On 10/14/2024, Dmitry Baryshkov wrote: >>> On Sat, Oct 12, 2024 at 05:14:13PM +0800, Liu Ying wrote: On 10/12/2024, Dmitry Baryshkov wrote: > On Sat, Oct 12, 2024 at 03:35:39PM +0800, Liu

[PATCH] Revert "drm/mgag200: Add vblank support"

2024-10-14 Thread Thomas Zimmermann
This reverts commit 6c9e14ee9f519ee605a3694fbfa4711284781d22. This reverts commit d5070c9b29440c270b534bbacd636b8fa558e82b. This reverts commit 89c6ea2006e2d39b125848fb0195c08fa0b354be. The VLINE interrupt doesn't work correctly on G200SE-A (at least). We have also seen missing interrupts on G200E

Re: [linux-next:master] [drm/ast] 4e29cc7c5c: WARNING:at_drivers/gpu/drm/ast/ast_dp.c:#ast_dp_set_enable[ast]

2024-10-14 Thread Thomas Zimmermann
Am 15.10.24 um 04:44 schrieb kernel test robot: Hello, kernel test robot noticed "WARNING:at_drivers/gpu/drm/ast/ast_dp.c:#ast_dp_set_enable[ast]" on: commit: 4e29cc7c5c673299cfbaf4982fc8b6a72c9f706f ("drm/ast: astdp: Replace ast_dp_set_on_off()") https://git.kernel.org/cgit/linux/kernel/

[PATCH 2/2] drm/ast: vga: Clear EDID if no display is connected

2024-10-14 Thread Thomas Zimmermann
Do not keep the obsolete EDID around after unplugging the display from the connector. Signed-off-by: Thomas Zimmermann Fixes: 2a2391f857cd ("drm/ast: vga: Transparently handle BMC support") Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org --- drive

[PATCH 1/2] drm/ast: sil164: Clear EDID if no display is connected

2024-10-14 Thread Thomas Zimmermann
Do not keep the obsolete EDID around after unplugging the display from the connector. Signed-off-by: Thomas Zimmermann Fixes: d20c2f846428 ("drm/ast: sil164: Transparently handle BMC support") Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org --- dr

[PATCH 0/2] drm/ast: Trivial EDID fixes

2024-10-14 Thread Thomas Zimmermann
After unplugging a display from the connector, the driver has to clear the connector's EDID property. Recent code for BMC support forget to do this for VGA- and SIL164-based transmitters. Fix it. Thomas Zimmermann (2): drm/ast: sil164: Clear EDID if no display is connected drm/ast: vga: Clear

[PATCH] fbdev: da8xx: remove the driver

2024-10-14 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This driver is no longer used on any platform. It has been replaced by tilcdc on the two DaVinci boards we still support and can be removed. Signed-off-by: Bartosz Golaszewski --- drivers/video/fbdev/Kconfig| 13 - drivers/video/fbdev/Makefile |1 - driver

Re: [PATCH v4 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-10-14 Thread Soutrik Mukhopadhyay
On 10/7/2024 1:21 AM, Dmitry Baryshkov wrote: On Fri, Oct 04, 2024 at 04:00:46PM GMT, Soutrik Mukhopadhyay wrote: The Qualcomm SA8775P platform comes with 2 DisplayPort controllers for each mdss, having different base offsets than the previous SoCs. The support for all 4 DPTX have been added h

Re: [PATCH v2 2/2] drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation

2024-10-14 Thread Abhinav Kumar
On 10/6/2024 10:01 PM, Jonathan Marek wrote: When (mode->clock * 1000) is larger than (1<<31), int to unsigned long conversion will sign extend the int to 64 bits and the pclk_rate value will be incorrect. Fix this by making the result of the multiplication unsigned. Note that above (1<<32)

Re: [PATCH] drm/msm/hdmi: drop pll_cmp_to_fdata from hdmi_phy_8998

2024-10-14 Thread Abhinav Kumar
On 9/21/2024 2:14 PM, Dmitry Baryshkov wrote: The pll_cmp_to_fdata() was never used by the working code. Drop it to prevent warnings with W=1 and clang. Reported-by: Jani Nikula Closes: https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.1725962479.git.jani.nik...@int

[PATCH v5] gpu: drm: replace of_graph_get_next_endpoint()

2024-10-14 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[linux-next:master] [drm/ast] 4e29cc7c5c: WARNING:at_drivers/gpu/drm/ast/ast_dp.c:#ast_dp_set_enable[ast]

2024-10-14 Thread kernel test robot
Hello, kernel test robot noticed "WARNING:at_drivers/gpu/drm/ast/ast_dp.c:#ast_dp_set_enable[ast]" on: commit: 4e29cc7c5c673299cfbaf4982fc8b6a72c9f706f ("drm/ast: astdp: Replace ast_dp_set_on_off()") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master [test failed on lin

Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread kernel test robot
linus/master v6.12-rc3 next-20241014] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab

Re: [PATCH 1/5] perf: Add dummy pmu module

2024-10-14 Thread Lucas De Marchi
On Mon, Oct 14, 2024 at 05:26:19PM -0700, Jeff Johnson wrote: On 10/8/24 11:34, Lucas De Marchi wrote: ... +module_init(dummy_init); +module_exit(dummy_exit); + +MODULE_AUTHOR("Lucas De Marchi "); +MODULE_LICENSE("GPL"); Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the desc

Re: [PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-14 Thread Jessica Zhang
On 10/10/2024 8:20 AM, Dmitry Baryshkov wrote: On Wed, Oct 09, 2024 at 08:41:13PM GMT, Jessica Zhang wrote: Don't set the merge_3d pending flush bits if the mode_3d is BLEND_3D_NONE. Always flushing merge_3d can cause timeout issues when there are multiple commits with concurrent writeback e

[PATCH v5] rockchip/drm: vop2: add support for gamma LUT

2024-10-14 Thread Piotr Zalewski
Add support for gamma LUT in VOP2 driver. The implementation was inspired by one found in VOP1 driver. Blue and red channels in gamma LUT register write were swapped with respect to how gamma LUT values are written in VOP1. Gamma LUT port selection was added before the write of new gamma LUT table

Re: [PATCH v2] drm/panthor: Fix firmware initialization on systems with a page size > 4k

2024-10-14 Thread Liviu Dudau
Hi Boris, I'm a bit confused, I thought the plan was to separate the FW_PAGE_SIZE from the rest of Panthor's PAGE_SIZE. On Mon, Oct 14, 2024 at 11:31:34AM +0200, Boris Brezillon wrote: > The system and GPU MMU page size might differ, which becomes a > problem for FW sections that need to be mappe

RE: [PATCH 1/2] drm/sched: adding a new scheduling policy

2024-10-14 Thread Deucher, Alexander
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Zhang, Jesse(Jie) > Sent: Friday, October 11, 2024 9:45 PM > To: Koenig, Christian ; dri- > de...@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH 1/2]

RE: [PATCH v5 03/10] drm/bridge: it6505: add AUX operation for HDCP KSV list read

2024-10-14 Thread Hermes.Wu
>-Original Message- >From: Dmitry Baryshkov >Sent: Monday, October 14, 2024 7:53 PM >To: Hermes Wu (吳佳宏) >Cc: Pin-yen Lin ; Kenneth Hung (洪家倫) >; Pet Weng (翁玉芬) ; Andrzej Hajda >; Neil Armstrong ; Robert >Foss ; Laurent Pinchart ; >Jonas Karlman ; Jernej Skrabec ; >Maarten Lankhors

Re:[PATCH v5] rockchip/drm: vop2: add support for gamma LUT

2024-10-14 Thread Andy Yan
Hi Piotr, At 2024-10-15 06:30:27, "Piotr Zalewski" wrote: >Add support for gamma LUT in VOP2 driver. The implementation was inspired >by one found in VOP1 driver. Blue and red channels in gamma LUT register >write were swapped with respect to how gamma LUT values are written in >VOP1. Gamma LUT

Re: vc4: HDMI Sink doesn't support RGB, something's wrong.

2024-10-14 Thread Dave Stevenson
On Mon, 14 Oct 2024 at 10:04, Maxime Ripard wrote: > > Hi, > > On Sun, Oct 13, 2024 at 09:57:58PM GMT, Stefan Wahren wrote: > > Am 13.10.24 um 21:11 schrieb Dave Stevenson: > > > Hi Stefan. > > > > > > On Sun, 13 Oct 2024, 18:19 Stefan Wahren, wrote: > > > > > > Hi, > > > > > > i recently

[PATCH 5/5] drm/sched: Further optimise drm_sched_entity_push_job

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit larger refactoring we can do the same optimisation on the rq->lock. (Currently both drm_sched_rq_add_entity() and drm_sched_rq_update_f

[PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re-acquire by adding a new drm_sched_rq_update_fifo_locked() helper. v2: * Remove drm_sched_rq_update_fifo() altogether. (Christian) Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Lu

[PATCH 4/5] drm/sched: Re-group and rename the entity run-queue lock

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Christian suggested to rename the lock and improve the documentation of what it protects. And to also re-order the structure members so all protected by the lock are together in a block. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Alex Deucher Cc: Luben Tuikov

[PATCH 2/5] drm/sched: Stop setting current entity in FIFO mode

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It does not seem there is a need to set the current entity in FIFO mode since ot only serves as being a "cursor" in round-robin mode. Even if scheduling mode is changed at runtime the change in behaviour is simply to restart from the first entity, instead of continuing in RR

[PATCH 3/5] drm/sched: Re-order struct drm_sched_rq members for clarity

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Current kerneldoc for struct drm_sched_rq incompletely documents what fields are protected by the lock. This is not good because it is misleading. Lets fix it by listing all the elements which are protected by the lock. While at it, lets also re-order the members so all pr

[PATCH 0/5] Small DRM scheduler improvements

2024-10-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Leftovers from the earlier "DRM scheduler fixes and improvements" series. It looks the fixes have now propagated back to drm-misc-next so this should now be mergeable. It also needed a small rebase to account for one revert and one spelling fix which landed in the meantime.

[PATCH v4 3/5] drm/i915/display: Enable the second scaler for sharpness

2024-10-14 Thread Nemesa Garg
As only second scaler can be used for sharpness check if it is available and also check if panel fitting is also not enabled, then set the sharpness. Panel fitting will have the preference over sharpness property. v2: Add the panel fitting check before enabling sharpness v3: Reframe commit message

[PATCH v3 4/5] drm/i915/display: Add registers and compute the strength

2024-10-14 Thread Nemesa Garg
Add new registers and related bits. Compute the strength value and tap value based on display mode. v2: Replace i915/dev_priv with display[Jani] v3: Create separate file for defining register[Jani] Add display->drm in debug prints[Jani] Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/di

[PATCH v2 5/5] drm/i915/display: Load the lut values and enable sharpness

2024-10-14 Thread Nemesa Garg
Load the lut values during pipe enable. v2: Add the display version check Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/intel_crtc.c| 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 6 ++ .../gpu/drm/i915/display/intel_display_types.h | 2 ++ drivers/gpu

[PATCH 0/5] Introduce drm sharpness property

2024-10-14 Thread Nemesa Garg
Many a times images are blurred or upscaled content is also not as crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural detail

[PATCH v4 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-10-14 Thread Nemesa Garg
The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all values and then dividing each value with a sum.

[PATCH v2 1/5] drm: Introduce sharpness strength property

2024-10-14 Thread Nemesa Garg
Introduces the new crtc property "SHARPNESS_STRENGTH" that allows the user to set the intensity so as to get the sharpness effect. The value of this property can be set from 0-255. It is useful in scenario when the output is blurry and user want to sharpen the pixels. User can increase/decrease the

Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 06:01:49PM +0800, Liu Ying wrote: > On 10/14/2024, Dmitry Baryshkov wrote: > > [...] > > > My suggestion would be to add a single root-level property which > > specifies which port provides even pixel data. > > That won't work. The LVDS source side expec

Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 08:09:44AM +, Biju Das wrote: > Hi Dmitry, > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: Monday, October 14, 2024 9:04 AM > > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 > > LVDS to HDMI converter > > > > On Mon, O

Re: [PATCH v5 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-10-14 Thread Fei Shao
On Mon, Sep 23, 2024 at 9:26 PM Liankun Yang wrote: > > Update efuse data for MT8188 displayport. > > The DP monitor can not display when DUT connected to USB-c to DP dongle. > Analysis view is invalid DP efuse data. > > Fixes: 350c3fe907fb ("drm/mediatek: dp: Add support MT8188 dp/edp function")

Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 07:39:16AM +, Biju Das wrote: > Hi Liu and Dmitry, > > > -Original Message- > > From: Liu Ying > > Sent: Monday, October 14, 2024 6:34 AM > > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 > > LVDS to HDMI converter > > > > On 10/14/

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Chuwi Hi10x

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 10:02:23AM +0800, Raymond Jay Golo wrote: > The Chuwi Hi10x uses a panel which has been mounted > 90 degrees rotated. Add a quirk for this. > > Signed-off-by: Raymond Jay Golo > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertion

RE: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Biju Das
> -Original Message- > From: Biju Das > Sent: Monday, October 14, 2024 8:39 AM > To: Liu Ying ; Dmitry Baryshkov > > Cc: dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org; > i...@lists.linux.dev; linux-arm-ker...@lists.infradead.org; > andrzej

Re: [PATCH v10 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-10-14 Thread Uwe Kleine-König
Hello, On Mon, Oct 07, 2024 at 11:03:11PM -0400, Alex Lanzano wrote: > Add support for the monochrome Sharp Memory LCDs. > > Co-developed-by: Mehdi Djait > Signed-off-by: Mehdi Djait > Signed-off-by: Alex Lanzano > Reviewed-by: Dmitry Baryshkov The pwm bits look ok now. Acked-by: Uwe Kleine

RE: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Biju Das
Hi Dmitry, > -Original Message- > From: Dmitry Baryshkov > Sent: Monday, October 14, 2024 9:04 AM > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS > to HDMI converter > > On Mon, Oct 14, 2024 at 07:39:16AM +, Biju Das wrote: > > Hi Liu and Dmitry, > >

RE: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: Liu Ying > Sent: Monday, October 14, 2024 8:18 AM > Subject: Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter > > On 10/14/2024, Dmitry Baryshkov wrote: > > On Sat, Oct 12, 2024 at 03:35:40PM +0800, Liu Ying wrote: > >> Add ba

Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 04:28:29PM +0800, Liu Ying wrote: > On 10/14/2024, Dmitry Baryshkov wrote: > > On Mon, Oct 14, 2024 at 03:18:15PM +0800, Liu Ying wrote: > >> On 10/14/2024, Dmitry Baryshkov wrote: > >>> On Sat, Oct 12, 2024 at 03:35:40PM +0800, Liu Ying wrote: > Add basic HDMI video ou

RE: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Biju Das
Hi Dmitry, > -Original Message- > From: Dmitry Baryshkov > Sent: Monday, October 14, 2024 12:16 PM > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS > to HDMI converter > > On Mon, Oct 14, 2024 at 08:09:44AM +, Biju Das wrote: > > Hi Dmitry, > > > > > -

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-14 Thread Philipp Stanner
Hi, On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In FIFO mode We can avoid dropping the lock only to immediately re- > acquire > by adding a new drm_sched_rq_update_fifo_locked() helper. > Please write detailed commit messages, as described here [1]. 1

Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 11:25:00AM +, Biju Das wrote: > Hi Dmitry, > > > -Original Message- > > From: Dmitry Baryshkov > > Sent: Monday, October 14, 2024 12:16 PM > > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 > > LVDS to HDMI converter > > > > On Mon,

Re: [PATCH 2/5] drm/sched: Stop setting current entity in FIFO mode

2024-10-14 Thread Philipp Stanner
On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It does not seem there is a need to set the current entity in FIFO > mode > since ot only serves as being a "cursor" in round-robin mode. Even if s/ot/it > scheduling mode is changed at runtime the change in be

Re: [PATCH 3/3] drm/panthor: Rreset device and load FW after failed PM suspend

2024-10-14 Thread Boris Brezillon
On Fri, 11 Oct 2024 23:57:01 +0100 Adrián Larumbe wrote: > On rk3588 SoCs, during a runtime PM suspend, the transition to the > lowest voltage/frequency pair might sometimes fail for reasons not yet > understood. In that case, even a slow FW reset will fail, leaving the > device's PM runtime stat

Re: [PATCH 2/3] drm/panthor: Retry OPP transition to suspension state a few times

2024-10-14 Thread Boris Brezillon
On Fri, 11 Oct 2024 23:57:00 +0100 Adrián Larumbe wrote: > When the device's runtime PM suspend callback is invoked, the switch to > a suspension OPP might sometimes fail. Although this is beyond the > control of the Panthor driver, we can attempt suspending it more than > once as a defensive str

Re: [PATCH v2 6/9] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 14, 2024 at 03:18:15PM +0800, Liu Ying wrote: > On 10/14/2024, Dmitry Baryshkov wrote: > > On Sat, Oct 12, 2024 at 03:35:40PM +0800, Liu Ying wrote: > >> Add basic HDMI video output support. Currently, only RGB888 output > >> pixel format is supported. At the LVDS input side, the drive

Re: [PATCH v10 0/2] Add driver for Sharp Memory LCD

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 11:03:09PM -0400, Alex Lanzano wrote: > This patch series add support for the monochrome Sharp Memory LCD > panels. This series is based off of the work done by Mehdi Djait. > > References: > https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267

Re: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 08:39:04PM +0530, Advait Dhamorikar wrote: > atmel_hlcdc_plane_update_buffers: may use an uninitialized > sr variable when the if condition remains unsatisfied. > The variable may contain an arbitrary value left from earlier computations. > > Reported-by: kernel test robot

Re: [PATCH RFC 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-10-14 Thread Krzysztof Kozlowski
On Sat, Oct 12, 2024 at 01:59:29AM +0530, Akhil P Oommen wrote: > Add a new schema which extends opp-v2 to support a new vendor specific > property required for Adreno GPUs found in Qualcomm's SoCs. The new > property called "qcom,opp-acd-level" carries a u32 value recommended > for each opp needs

RE: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-14 Thread Biju Das
Hi Liu and Dmitry, > -Original Message- > From: Liu Ying > Sent: Monday, October 14, 2024 6:34 AM > Subject: Re: [PATCH v2 5/9] dt-bindings: display: bridge: Add ITE IT6263 LVDS > to HDMI converter > > On 10/14/2024, Dmitry Baryshkov wrote: > > On Sat, Oct 12, 2024 at 05:14:13PM +0800,

Re: [PATCH RFC 3/3] arm64: dts: qcom: x1e80100: Add ACD levels for GPU

2024-10-14 Thread Krzysztof Kozlowski
On Sat, Oct 12, 2024 at 01:59:30AM +0530, Akhil P Oommen wrote: > Update GPU node to include acd level values. > > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dt

Re: [PATCH v2 2/2] drm/bridge: sii902x: Set input bus format based on bus-width

2024-10-14 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 10:52:13AM +0200, Wadim Egorov wrote: > Introduce a bus-width property to define the number of parallel RGB > input pins connected to the transmitter. The input bus formats are updated > accordingly. If the property is not specified, default to 24-bit bus-width. > > Signed-

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-14 Thread 胡俊光

Re: [PATCH 4/8] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate

2024-10-14 Thread Liu Ying
On 10/14/2024, Maxime Ripard wrote: > On Sat, Oct 12, 2024 at 02:18:16PM GMT, Liu Ying wrote: >> On 10/11/2024, Maxime Ripard wrote: >>> On Mon, Sep 30, 2024 at 03:55:30PM GMT, Liu Ying wrote: On 09/30/2024, Maxime Ripard wrote: > On Mon, Sep 30, 2024 at 01:28:59PM GMT, Liu Ying wrote: >>>

Re: [PATCH] drm: atmel-hlcdc: update the LCDC_ATTRE register in plane atomic_disable

2024-10-14 Thread Nicolas Ferre
On 14/10/2024 at 08:46, Manikandan Muralidharan wrote: update the LCDC_ATTRE register in drm plane atomic_disable to handle the configuration changes of each layer when a plane is disabled. Signed-off-by: Manikandan Muralidharan Reviewed-by: Nicolas Ferre Thanks Mani. Best regards, Nicola

[PATCH] drm: atmel-hlcdc: fix atmel_xlcdc_plane_setup_scaler()

2024-10-14 Thread Manikandan Muralidharan
From: Cyrille Pitchen On SoCs, like the SAM9X75, which embed the XLCDC ip, the registers that configure the unified scaling engine were not filled with proper values. Indeed, for YCbCr formats, the VXSCFACT bitfield of the HEOCFG25 register and the HXSCFACT bitfield of the HEOCFG27 register were

Re: [PATCH 4/7] drm/panic: remove redundant field when assigning value

2024-10-14 Thread Jocelyn Falempe
On 12/10/2024 09:52, Thomas Böhler wrote: Rust allows initializing fields of a struct without specifying the attribute that is assigned if the variable has the same name. In this instance this is done for all other attributes of the struct except for `data`. Remove the redundant `data` in the ass

[PATCH v12 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-10-14 Thread AngeloGioacchino Del Regno
Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths per HW instance (so potentially up to six displays for multi-vdo SoCs). The MMSYS or VDOSYS is always the first component in the DDP pipeline, so it only supports an output port with multiple endpoints - where each endpoint def

[PATCH v12 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

2024-10-14 Thread AngeloGioacchino Del Regno
The display IPs in MediaTek SoCs support being interconnected with different instances of DDP IPs (for example, merge0 or merge1) and/or with different DDP IPs (for example, rdma can be connected with either color, dpi, dsi, merge, etc), forming a full Display Data Path that ends with an actual dis

[PATCH v12 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-10-14 Thread AngeloGioacchino Del Regno
It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for 10 SoCs and this is going to grow larger and larger, and with new hacks like the introduction of mtk_drm_route which is a

[PATCH v12 0/3] drm/mediatek: Add support for OF graphs

2024-10-14 Thread AngeloGioacchino Del Regno
Changes in v12: - Added comment to describe graph for OVL_ADAPTOR in patch [3/3] as suggested by CK Hu. Changes in v11: - Added OVL_ADAPTOR_MDP_RDMA to OVL Adaptor exclusive components list to avoid failures in graphs with MDP_RDMA inside - Rebased on next-20241004 Changes in v10: - Rem

[PATCH v4 07/12] drm/client: Move suspend/resume into DRM client callbacks

2024-10-14 Thread Thomas Zimmermann
Suspend and resume is still tied to fbdev emulation. Modeset helpers and several drivers call drm_fb_helper_set_suspend_unlocked() to inform the fbdev client about suspend/resume events. To make it work with arbitrary clients, add per-client callback functions for suspend and resume. Implement the

[PATCH v4 00/12] drm: Introduce DRM client library

2024-10-14 Thread Thomas Zimmermann
With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it is time to provide a single place for the clients. The base client code and client event handling is now optional. It still remains in the DRM core, which simplifies module dependencie

[PATCH v4 05/12] drm/fbdev: Store fbdev module parameters in separate file

2024-10-14 Thread Thomas Zimmermann
The fbdev code does not really belong into drm_kms_helper.ko. But there are module parameters that control the behavior of the fbdev emulation. It is not possible to remove them from the module without breaking someone's installation. Therefore move the fbdev module parameters to drm_kms_helper_co

[PATCH v4 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

2024-10-14 Thread Thomas Zimmermann
Commit 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O") added deferred I/O for fbdev-dma. Also select the Kconfig symbol FB_DEFERRED_IO (via FB_DMAMEM_HELPERS_DEFERRED). Fixes build errors about missing fbdefio, such as drivers/gpu/drm/drm_fbdev_dma.c:218:26: error: 'stru

[PATCH v4 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-14 Thread Thomas Zimmermann
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[PATCH v4 10/12] drm/radeon: Suspend and resume clients with client helpers

2024-10-14 Thread Thomas Zimmermann
Replace calls to radeon_fbdev_set_suspend() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. v4: - refer to radeon_fbdev_set_suspend() in commit description (Jonathan) Signed-off-by

[PATCH v4 11/12] drm/client: Make client support optional

2024-10-14 Thread Thomas Zimmermann
Only build client code if DRM_CLIENT has been selected. Automatially do so if one of the default clients has been enabled. If client support has been disabled, the helpers for client-related events are empty and the regular client functions are not present. Amdgpu has an internal DRM client, so it

[PATCH v4 08/12] drm/amdgpu: Suspend and resume internal clients with client helpers

2024-10-14 Thread Thomas Zimmermann
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc:

[PATCH v4 06/12] drm/client: Move client event handlers to drm_client_event.c

2024-10-14 Thread Thomas Zimmermann
A number of DRM-client functions serve as entry points from device operations to client code. Moving them info a separate file will later allow for a more fine-grained kernel configuration. For most of the users it is sufficient to include instead of the full driver-side interface in v2: - renam

[PATCH v4 12/12] drm/client: Add client-lib module

2024-10-14 Thread Thomas Zimmermann
Add drm_client_lib.ko to contain DRM's built-in client. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT_LIB. The Kconfig rules separate the DRM drivers from the DRM clients. A driver can opt into the default clients, but the user co

[PATCH v4 09/12] drm/nouveau: Suspend and resume clients with client helpers

2024-10-14 Thread Thomas Zimmermann
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo

  1   2   >