Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-10 Thread 胡俊光

[PATCH] drm/panel: himax-hx83102: Adjust power and gamma to optimize brightness

2024-10-10 Thread Cong Yang
The current panel brightness is only 360 nit. Adjust the power and gamma to optimize the panel brightness. The brightness after adjustment is 390 nit. Fixes: 3179338750d8 ("drm/panel: Support for IVO t109nw41 MIPI-DSI panel") Signed-off-by: Cong Yang --- drivers/gpu/drm/panel/panel-himax-hx83102

Re: [PATCH v3 1/5] PCI/IOV: Restore VF resizable BAR state after reset

2024-10-10 Thread Bjorn Helgaas
On Thu, Oct 10, 2024 at 12:31:59PM +0200, Michał Winiarski wrote: > Similar to regular resizable BAR, VF BAR can also be resized, e.g. by > the system firmware, or the PCI subsystem itself. > Add the capability ID and restore it as a part of IOV state. > See PCIe r4.0, sec 9.3.7.4. Add blank line

Re: [PATCH v3 4/5] PCI/IOV: Allow extending VF BAR within original resource boundary

2024-10-10 Thread Bjorn Helgaas
On Thu, Oct 10, 2024 at 12:32:02PM +0200, Michał Winiarski wrote: > VF MMIO resource reservation, either created by system firmware and > inherited by Linux PCI subsystem or created by the subsystem itself, > contains enough space to fit the BAR of all SR-IOV Virtual Functions > that can potentiall

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-10 Thread 胡俊光

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:15写道: > > On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > > Blend pipes by set of mixer pair config. The first 2 pipes are for left > > half screen with the first set of mixer pair config. And the later 2 pipes > > are for right in quad pipe case. > > >

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:08写道: > > On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > > Store pipes in array with removing dedicated r_pipe. There are > > 2 pipes in a drm plane at most currently. While 4 pipes are > > needed for new usage case. This change generalize the handling

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Liu Ying
On 10/11/2024, Marek Vasut wrote: > On 10/10/24 9:15 AM, Liu Ying wrote: >> On 10/09/2024, Marek Vasut wrote: >>> The LDB serializer clock operate at either x7 or x14 rate of the input >> >> Isn't it either x7 or 3.5x? > > Is it 3.5 for the dual-link LVDS ? Yes. static unsigned long fsl_ldb_link

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:21写道: > > On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > > Share SSPP info for multi-rect case if virtual plane is not enabled. > > Otherwise, the 2nd half of DMA content is not displayed due to sspp > > pointer of r_pipe is null. > > Fixes? Yeah. It i

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Dmitry Baryshkov
On Fri, 11 Oct 2024 at 09:54, Jun Nie wrote: > > Dmitry Baryshkov 于2024年10月10日周四 21:21写道: > > > > On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > > > Share SSPP info for multi-rect case if virtual plane is not enabled. > > > Otherwise, the 2nd half of DMA content is not displayed due to

[PATCH 0/7] drm: Add physical status and BMC support to conenctor

2024-10-10 Thread Thomas Zimmermann
Track a connector's physical status separately from the logical status and implement BMC support for DRM drivers. Connectors with virtual BMC stay connected even if no display is physically connected. DRM clients then continue displaying output to the BMC. Ast and mgag200 have been doing this for

[PATCH 1/7] drm/probe-helper: Call connector detect functions in single helper

2024-10-10 Thread Thomas Zimmermann
Move the logic to call the connector's detect helper into a single internal function. Reduces code duplication. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_probe_helper.c | 33 +++--- 1 file changed, 17 insertions(+), 16 deletions(-)

[PATCH 4/7] drm/ast: sil164: Clear EDID if no display is connected

2024-10-10 Thread Thomas Zimmermann
Do not keep the obsolete EDID around after unplugging the display form the connector. Signed-off-by: Thomas Zimmermann Fixes: d20c2f846428 ("drm/ast: sil164: Transparently handle BMC support") Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org --- dr

[PATCH 2/7] drm: Add physical status to connector

2024-10-10 Thread Thomas Zimmermann
Track the connector's physical status in addition to its logical status. The latter is directly derived from the former and for most connectors both values are in sync. Server chips with BMC, such as Aspeed, Matrox and HiSilicon, often provide virtual outputs for remote management. Without a conne

[PATCH 3/7] drm: Add bmc_attached flag to connector

2024-10-10 Thread Thomas Zimmermann
Add the bmc_attached flag to struct drm_connector to signal the presence of a virtual BMC output. The connector reports to be in status connected even without a physically connected display. Fbcon or userspace compositors would otherwise stop displaying to the BMC. Signed-off-by: Thomas Zimmermann

[PATCH 7/7] drm/mgag200: Track physical connector status in struct drm_connector

2024-10-10 Thread Thomas Zimmermann
Set bmc_attached for the VGA connector on servers and let DRM's probe helpers track the physical and logical connector state. Remove similar logic from mgag200. Also resolve a design issue, where mgag200 uses the connector's edid_blob_ptr. It is an internal value that drivers should not access dir

[PATCH 6/7] drm/ast: Track physical connector status in struct drm_connector

2024-10-10 Thread Thomas Zimmermann
Set bmc_attached for all connectors and let DRM's probe helpers track the physical and logical connector state. Remove such logic and related data structures from ast. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 21 ++--- drivers/gpu/drm/ast/ast_dp501.

[PATCH 5/7] drm/ast: vga: Clear EDID if no display is connected

2024-10-10 Thread Thomas Zimmermann
Do not keep the obsolete EDID around after unplugging the display form the connector. Signed-off-by: Thomas Zimmermann Fixes: 2a2391f857cd ("drm/ast: vga: Transparently handle BMC support") Cc: Thomas Zimmermann Cc: Jocelyn Falempe Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org --- drive

Re: [PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

2024-10-10 Thread 胡俊光

Re: [PATCH 1/2] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-10-10 Thread Marek Vasut
On 10/10/24 7:22 AM, Liu Ying wrote: On 10/09/2024, Marek Vasut wrote: The media_ldb_root_clk supply LDB serializer. These clock are usually shared with the LCDIFv3 pixel clock and supplied by the Video PLL on i.MX8MP, but the LDB clock run at either x7 or x14 rate of the LCDIFv3 pixel clock. Al

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Marek Vasut
On 10/10/24 9:15 AM, Liu Ying wrote: On 10/09/2024, Marek Vasut wrote: The LDB serializer clock operate at either x7 or x14 rate of the input Isn't it either x7 or 3.5x? Is it 3.5 for the dual-link LVDS ? I don't have such a panel right now to test. [...] diff --git a/drivers/gpu/drm/brid

[PATCH 0/3] drm: logicvc: add of_node_put() and switch to a more secure approach

2024-10-10 Thread Javier Carrasco
() in for_each_child_of_node() drm: logicvc: switch to for_each_child_of_node_scoped() drm: logicvc: use automatic cleanup facility for layers_node drivers/gpu/drm/logicvc/logicvc_layer.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) --- base-commit:

[PATCH 1/3] drm: logicvc: fix missing of_node_put() in for_each_child_of_node()

2024-10-10 Thread Javier Carrasco
Early exits from the for_each_child_of_node() loop require explicit calls to of_node_put() for the child node. Add the missing 'of_node_put(layer_node)' in the only error path. Cc: sta...@vger.kernel.org Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") Signed-off-by: Ja

[PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped()

2024-10-10 Thread Javier Carrasco
Use the scoped variant of the macro to avoid leaking memory upon early exits without the required call to of_node_put(). Signed-off-by: Javier Carrasco --- drivers/gpu/drm/logicvc/logicvc_layer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logic

[PATCH 3/3] drm: logicvc: use automatic cleanup facility for layers_node

2024-10-10 Thread Javier Carrasco
Use the more robust approach provided by the __free() macro to automatically call of_node_put() when the device node goes out of scope. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/logicvc/logicvc_layer.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/driver

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-10 Thread Liu Ying
On 10/11/2024, Marek Vasut wrote: > On 10/10/24 7:31 AM, Liu Ying wrote: > > Hi, Hi, > >>> This Video PLL1 configuration since moved to &media_blk_ctrl {} , but it is >>> still in the imx8mp.dtsi . Therefore, to make your panel work at the >>> correct desired pixel clock frequency instead of

Re: [PATCH v2 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-10 Thread Rob Herring (Arm)
mentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.yaml: Documentation/devicetree/bindings/mfd/zii,rave-sp.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241010-zii_yaml-v2-2-0ab730607...@nxp.com The base for the series is generally the latest rc1. A diffe

Re: [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()

2024-10-10 Thread Zack Rusin
On Mon, Oct 7, 2024 at 7:52 AM Thorsten Blum wrote: > > Since kvfree() already checks if its argument is NULL, an additional > check before calling kvfree() is unnecessary and can be removed. > > Remove both and the following Coccinelle/coccicheck warnings reported by > ifnullfree.cocci: > > WAR

[PULL] drm-xe-fixes

2024-10-10 Thread Lucas De Marchi
Hi Dave and Simona, A few drm-xe fixes for 6.12-rc3. thanks Lucas De Marchi drm-xe-fixes-2024-10-10: Driver Changes: - Fix error checking with xa_store() (Matthe Auld) - Fix missing freq restore on GSC load error (Vinay) - Fix wedged_mode file permission (Matt Roper) - Fix use-after-free in ct

Re: [PATCH v2 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-10 Thread Rob Herring (Arm)
On Thu, 10 Oct 2024 11:42:39 -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > Additional Changes: > - Remove mfd parent node at example. > - Ref to backlight's common.yaml > > Signed-off-by: Frank Li > --- > .../leds/backlight/zii,rave-sp-bac

Re: [PATCH v8 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-10 Thread Greg Kroah-Hartman
On Tue, Oct 08, 2024 at 02:39:45PM +0200, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at > compile time. We thus need to add HAS_IOPORT as dependency for those > drivers using them unconditionally. Some 8250 serial drivers support > MMIO only use, s

Re: [PATCH 1/2] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-10-10 Thread Liu Ying
On 10/11/2024, Marek Vasut wrote: > On 10/10/24 7:22 AM, Liu Ying wrote: >> On 10/09/2024, Marek Vasut wrote: >>> The media_ldb_root_clk supply LDB serializer. These clock are usually >>> shared with the LCDIFv3 pixel clock and supplied by the Video PLL on >>> i.MX8MP, but the LDB clock run at eith

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-10 Thread 胡俊光

[PATCH 1/2] drm/sched: adding a new scheduling policy

2024-10-10 Thread jesse.zhang
From: "jesse.zh...@amd.com" Added ring ID scheduling. In some cases, userspace needs to run a job on a specific ring. Instead of selecting the best ring to run based on the ring score. For example, The user want to run a bad job on a specific ring to check whether the ring can recover from a queu

[PATCH 2/2] drm/amdgpu: add the ring id schedule module parameter for amdgpu

2024-10-10 Thread jesse.zhang
From: "jesse.zh...@amd.com" Added ring id schedule to switch scheduling policy when cs submits. Schedule the ring by setting the ring id. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++-- drivers/gpu/drm/amd/amd

Re: [PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:12写道: > > On Wed, Oct 09, 2024 at 04:50:21PM GMT, Jun Nie wrote: > > Update mixer number info earlier so that the plane nopipe check > > can have the info to clip the plane. Otherwise, the first nonpipe > > check will have mixer number as 0 and plane is not check

Re: [PATCH v4 13/18] dt-bindings: usb-switch: Extend for DisplayPort altmode

2024-10-10 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-09-19 03:40:19) > On Sat, Aug 31, 2024 at 09:06:51PM GMT, Stephen Boyd wrote: > > diff --git a/Documentation/devicetree/bindings/usb/usb-switch.yaml > > b/Documentation/devicetree/bindings/usb/usb-switch.yaml > > index f5dc7e23b134..816f295f322f 100644 > > --- a/Docu

Re: [PATCH next] drm/amdgpu: Fix off by one in current_memory_partition_show()

2024-10-10 Thread Lazar, Lijo
On 10/11/2024 12:05 AM, Dan Carpenter wrote: > The >= ARRAY_SIZE() should be > ARRAY_SIZE() to prevent an out of > bounds read. > > Fixes: 012be6f22c01 ("drm/amdgpu: Add sysfs interfaces for NPS mode") > Signed-off-by: Dan Carpenter Reviewed-by: Lijo Lazar Thanks, Lijo > --- > drivers/gpu

Re: linux-next: build warning after merge of the drm-intel tree

2024-10-10 Thread Stephen Rothwell
Hi all, On Tue, 1 Oct 2024 13:43:31 +1000 Stephen Rothwell wrote: > > After merging the drm-intel tree, today's linux-next build (htmldocs) > produced this warning: > > drivers/gpu/drm/i915/i915_irq.c:1: warning: > 'intel_runtime_pm_disable_interrupts' not found > drivers/gpu/drm/i915/i915_irq

Re: [PATCH] drm/mipi-dsi: fix kernel doc on mipi_dsi_compression_mode_multi

2024-10-10 Thread Neil Armstrong
Hi, On Thu, 10 Oct 2024 13:31:42 +0300, Dzmitry Sankouski wrote: > Replace dsi parameter on ctx in kernel doc of > mipi_dsi_compression_mode_multi function. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/mipi-dsi: fix kernel doc on mipi_dsi

[PATCH] drm/ttm: Fix incorrect use of kernel-doc format

2024-10-10 Thread Thomas Hellström
Add a missing colon. Cc: dri-devel@lists.freedesktop.org Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/linux-next/20241010160942.192ca...@canb.auug.org.au/ Fixes: fc5d96670eb2 ("drm/ttm: Move swapped objects off the manager's LRU list") Signed-off-by: Thomas Hellström --- inclu

Re: [PATCH v2 12/14] drm/msm/dpu: support plane splitting in quad-pipe case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:25PM GMT, Jun Nie wrote: > Clip plane into pipes per left and right half screen ROI if topology > is quad pipe. Why? Please provide an explanation for the reviewers not knowing the details. > Then split the clipped rectangle by half if the rectangle > width still exc

Re: [PATCH][next] drm/amdgpu: Fix potential integer overflow on shift of a int

2024-10-10 Thread Christian König
Am 10.10.24 um 13:22 schrieb Colin Ian King: The left shift of int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then assigned to and operated upon using a 64 bit unsigned integer. In the case where the shift is 32 or more this can lead to an overflow. Avoid this by shifting

Re: [PATCH 2/2] MAINTAINERS: Fix VC4's mailing lists

2024-10-10 Thread Maíra Canal
Hi Dave & Maxime, On 10/10/24 04:36, Maxime Ripard wrote: On Wed, Oct 09, 2024 at 04:13:01PM GMT, Dave Stevenson wrote: Hi Maíra On Wed, 9 Oct 2024 at 15:12, Maíra Canal wrote: VC4 has two relevant mailing list: kernel-l...@raspberrypi.com and dri-devel@lists.freedesktop.org. Therefore, lis

[PULL] drm-misc-fixes

2024-10-10 Thread Thomas Zimmermann
Hi Dave, Sima, here's drm-misc-fixes for this week. Best regards Thomas drm-misc-fixes-2024-10-10: Short summary of fixes pull: fbdev-dma: - Only clean up deferred I/O if instanciated nouveau: - dmem: Fix privileged error in copy engine channel; Fix possible data leak in migrate_to_ram() - gsp

Re: [PATCH] drm/mipi-dsi: fix kernel doc on mipi_dsi_compression_mode_multi

2024-10-10 Thread Neil Armstrong
ansactions * @enable: Whether to enable or disable the DSC * * Enable or disable Display Stream Compression on the peripheral using the --- base-commit: 4c93ede2b0c73a7708f46a01669769d15d31e1d2 change-id: 20241010-starqltechn_integration_upstream_drm_fix-72233382f98f Best regards, R

Re: [PATCH v3] drm/display: Fix building with GCC 15

2024-10-10 Thread Jani Nikula
On Wed, 02 Oct 2024, Jani Nikula wrote: > On Wed, 02 Oct 2024, Brahmajit Das wrote: >> GCC 15 enables -Werror=unterminated-string-initialization by default. >> This results in the following build error >> >> drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function >> ‘is_hdmi_adaptor’: >>

Re: [PATCH v3 3/5] PCI: Allow IOV resources to be resized in pci_resize_resource

2024-10-10 Thread Michał Winiarski
On Thu, Oct 10, 2024 at 02:17:11PM +0300, Ilpo Järvinen wrote: > On Thu, 10 Oct 2024, Michał Winiarski wrote: > > > Similar to regular resizable BAR, VF BAR can also be resized. > > The structures are very similar, which means we can reuse most of the > > implementation. See PCIe r4.0, sec 9.3.7.4

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > Store pipes in array with removing dedicated r_pipe. There are > 2 pipes in a drm plane at most currently. While 4 pipes are > needed for new usage case. This change generalize the handling > to pipe pair and ease handling to another pipe pai

Re: [PATCH v2 07/14] drm/msm/dpu: bind correct pingpong for quad pipe

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:20PM GMT, Jun Nie wrote: > There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd > interface to 3rd PP instead of the 2nd PP. > > Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 ---

Re: [PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:21PM GMT, Jun Nie wrote: > Update mixer number info earlier so that the plane nopipe check > can have the info to clip the plane. Otherwise, the first nonpipe > check will have mixer number as 0 and plane is not checked. > > Signed-off-by: Jun Nie > --- > drivers/gp

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > Blend pipes by set of mixer pair config. The first 2 pipes are for left > half screen with the first set of mixer pair config. And the later 2 pipes > are for right in quad pipe case. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/

Re: [PATCH v2 10/14] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:23PM GMT, Jun Nie wrote: > Move requreiment check to routine of every pipe check. Because there is s/Because there is/There will be/ > multiple SSPPs for quad-pipe case in future. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > Share SSPP info for multi-rect case if virtual plane is not enabled. > Otherwise, the 2nd half of DMA content is not displayed due to sspp > pointer of r_pipe is null. Fixes? > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dp

[PULL] drm-intel-fixes

2024-10-10 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes PR towards v6.12-rc3. Just one HDCP refcount fix. Regards, Joonas drm-intel-fixes-2024-10-10: - HDCP refcount fix The following changes since commit 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b: Linux 6.12-rc2 (2024-10-06 15:32:27 -0700) are ava

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-10 Thread Thomas Zimmermann
Hi Am 04.10.24 um 18:58 schrieb Luck, Tony: Thomas, v6.12-rc1 plus your off-by-one patch is still broken. Thanks for testing. Here's another patch to try Ville's suggestion. It should disable HW vblank IRQs on your system. Could you please test it and report on the results? Best regards T

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-10 Thread Dmitry Baryshkov
On Thu, 10 Oct 2024 at 04:47, Jun Nie wrote: > > Dmitry Baryshkov 于2024年10月10日周四 06:10写道: > > > > On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > > > > > Only 2 DSC engines are allowed, or no DSC is involved currently. > > > > Can't parse this phrase. > > How about this: > If DSC is enabled, the

Re: [PATCH] drm/msm/dpu: don't always program merge_3d block

2024-10-10 Thread Dmitry Baryshkov
On Thu, 10 Oct 2024 at 06:46, Jessica Zhang wrote: > > Only program the merge_3d block for the video phys encoder when the 3d > blend mode is not NONE Please describe why, not what. > > Fixes: 3e79527a33a8 ("drm/msm/dpu: enable merge_3d support on sm8150/sm8250") > Suggested-by: Abhinav Kumar >

Re: [PATCH v3 1/5] PCI/IOV: Restore VF resizable BAR state after reset

2024-10-10 Thread Ilpo Järvinen
On Thu, 10 Oct 2024, Michał Winiarski wrote: > Similar to regular resizable BAR, VF BAR can also be resized, e.g. by > the system firmware, or the PCI subsystem itself. > Add the capability ID and restore it as a part of IOV state. > See PCIe r4.0, sec 9.3.7.4. > > Signed-off-by: Michał Winiarski

Re: [PATCH v3 3/5] PCI: Allow IOV resources to be resized in pci_resize_resource

2024-10-10 Thread Ilpo Järvinen
On Thu, 10 Oct 2024, Michał Winiarski wrote: > Similar to regular resizable BAR, VF BAR can also be resized. > The structures are very similar, which means we can reuse most of the > implementation. See PCIe r4.0, sec 9.3.7.4. > > Signed-off-by: Michał Winiarski > --- > drivers/pci/iov.c

Re: [PATCH net-next v25 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-10-10 Thread Lai, Yi
Hi Mina Almasry, Greetings! I used Syzkaller and found that there is BUG: soft lockup inqt in linux-next tree next-20241008 After bisection and the first bad commit is: " 678f6e28b5f6 net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags " All detailed into can be found at: https://github

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-10 Thread AngeloGioacchino Del Regno
Il 09/10/24 13:15, Shu-hsiang Yang ha scritto: Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv modules. Key functionalities include data processing, V4L2 integration, resource management, debug support, and various control operations. Additionally, IRQ handling, platform devic

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 02:38:43PM GMT, Jun Nie wrote: > Only 2 DSC engines are allowed, or no DSC is involved currently. > We need 4 DSC in quad-pipe topology in future. So let's only configure > DSC engines in use, instread of maximum number of DSC engines. > > Signed-off-by: Jun Nie > --- > d

Re: [PATCH][next] drm/xe/guc: Fix inverted logic on snapshot->copy check

2024-10-10 Thread Thomas Hellström
On Wed, 2024-10-09 at 09:32 -0700, John Harrison wrote: > On 10/9/2024 09:05, Colin Ian King wrote: > > Currently the check to see if snapshot->copy has been allocated is > > inverted and ends up dereferencing snapshot->copy when free'ing > > objects in the array when it is null or not free'ing the

Re: [PATCH v2 00/14] drm/msm/dpu: Support quad pipe with dual-DSI

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:13PM GMT, Jun Nie wrote: > > --- > 2 or more SSPPs and dual-DSI interface are need for super wide DSI panel. > And 4 DSC are prefered for power optimal in this case. This patch set > extend number of pipes to 4 and revise related mixer blending logic > to support quad

Re: [PATCH v2 01/14] drm/msm/dpu: polish log for resource allocation

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:14PM GMT, Jun Nie wrote: > Add resource allocation type info. Please describe changes properly. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --g

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-10 Thread Lucas De Marchi
On Tue, Oct 08, 2024 at 06:02:43PM +0300, Raag Jadav wrote: On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > On 30.09.2024 09:38, Raag Jadav wrote: > > > > +/** > > + * enum drm_wedge_recovery - Recovery method for we

[REGRESSION] GM20B pmu timeout

2024-10-10 Thread Diogo Ivo
Hello, Somewhere between 6.11-rc4 and 6.11-rc5 the following error message is displayed when trying to initialize a nvc0_screen on the Tegra X1's GM20B: [ 34.431210] nouveau 5700.gpu: pmu:hpq: timeout waiting for queue ready [ 34.438145] nouveau 5700.gpu: gr: init failed, -110 nvc0_screen

Re: [PATCH v2 13/14] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:26PM GMT, Jun Nie wrote: > Support SSPP assignment for quad-pipe case with unified method. > The first 2 pipes can share a set of mixer config and enable > multi-rect mode if condition is met. It is also the case for > the later 2 pipes. > > Signed-off-by: Jun Nie >

Re: [PATCH v1 02/10] media: platform: mediatek: add seninf controller

2024-10-10 Thread 胡俊光

[PATCH 3/4] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-10 Thread Jakob Hauser
The tables for brightness to candela, aid and elvss were taken from downstream kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [1][2][3]. The gamma table gets generated in "ss_dsi_smart_dimming_S6E88A0_AMS427AP24.c" [4] with hard-coded starting values. The function smart_dimming_in

[PATCH 1/4] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings

2024-10-10 Thread Jakob Hauser
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller. Signed-off-by: Jakob Hauser --- Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git current branch drm-misc-next. --- .../panel/samsung,s6e88a0-ams427ap24.yaml | 68 +++ 1 file changed, 68 ins

[PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-10 Thread Jakob Hauser
This initial part of the panel driver was mostly generated by the "linux-mdss-dsi-panel-driver-generator" tool [1], reading downstream Android kernel file "dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi" [2]. On top of the generic output of the tool, there were a couple of changes applied: - Add

[PATCH 4/4] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-10 Thread Jakob Hauser
The way of implementing a flip option follows the existing panel-samsung-s6e8aa0.c [1][2][3]. The value to flip the screen is taken from a downstream kernel file of a similar but older panel [4]. The mipi clock [5] for the new panel samsung-s6e88a0-ams427ap24 matches 461 MHz and a hardware read-ou

[PATCH 0/4] Add new panel driver Samsung S6E88A0-AMS427AP24

2024-10-10 Thread Jakob Hauser
The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0 controller. Patches are based on current branch drm-misc-next. Jakob Hauser (4): dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver drm/panel:

Re: [PATCH v3 2/5] PCI: Add a helper to identify IOV resources

2024-10-10 Thread Bjorn Helgaas
On Thu, Oct 10, 2024 at 12:32:00PM +0200, Michał Winiarski wrote: > There are multiple places where special handling is required for IOV > resources. > Extract it to a helper and drop a few ifdefs. Add blank line between paragraphs. Include name of helper in subject line and commit log, i.e., pci

Re: [PATCH v3 3/5] PCI: Allow IOV resources to be resized in pci_resize_resource

2024-10-10 Thread Bjorn Helgaas
On Thu, Oct 10, 2024 at 12:32:01PM +0200, Michał Winiarski wrote: > Similar to regular resizable BAR, VF BAR can also be resized. > The structures are very similar, which means we can reuse most of the > implementation. See PCIe r4.0, sec 9.3.7.4. Add blank line between paragraphs. Add "()" after

Re: [PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

2024-10-10 Thread 胡俊光

Re: [PATCH v1 02/10] media: platform: mediatek: add seninf controller

2024-10-10 Thread 胡俊光

Re: [PATCH net-next v25 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-10-10 Thread Lai, Yi
On Thu, Oct 10, 2024 at 12:05:38PM -0700, Mina Almasry wrote: > On Thu, Oct 10, 2024 at 4:17 AM Lai, Yi wrote: > > > > Hi Mina Almasry, > > > > Greetings! > > > > I used Syzkaller and found that there is BUG: soft lockup inqt in > > linux-next tree next-20241008 > > > > After bisection and the fi

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-10-10 Thread 胡俊光

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Liu Ying
On 10/09/2024, Marek Vasut wrote: > The LDB serializer clock operate at either x7 or x14 rate of the input Isn't it either x7 or 3.5x? s/operate/operates/ > LCDIFv3 scanout engine clock. Make sure the serializer clock and their > upstream Video PLL are configured early in .mode_set to the x7 or

Re: Question about possible NULL Pointer Dereference in hx83102_get_modes()

2024-10-10 Thread Maxime Ripard
Hi, On Wed, Oct 09, 2024 at 02:38:22PM GMT, Zichen Xie wrote: > Dear Developers for DRM PANEL DRIVERS, > > We are developing a static analyzer for Linux Kernel, and we are > curious about the function drm_mode_duplicate() in > hx83102_get_modes(). > https://elixir.bootlin.com/linux/v6.12-rc2/sour

[PATCH v3 0/5] PCI: VF resizable BAR

2024-10-10 Thread Michał Winiarski
Hi, Resurrecting an old series [1], now that we have an in-tree user for it. For regular BAR, drivers can use pci_resize_resource to resize it to the desired size provided that it is supported by the hardware, which the driver can query using pci_rebar_get_possible_sizes. This series expands the

[PATCH v3 1/5] PCI/IOV: Restore VF resizable BAR state after reset

2024-10-10 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized, e.g. by the system firmware, or the PCI subsystem itself. Add the capability ID and restore it as a part of IOV state. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski --- drivers/pci/iov.c | 29

[PATCH v3 2/5] PCI: Add a helper to identify IOV resources

2024-10-10 Thread Michał Winiarski
There are multiple places where special handling is required for IOV resources. Extract it to a helper and drop a few ifdefs. Signed-off-by: Michał Winiarski --- drivers/pci/pci.h | 18 ++ drivers/pci/setup-bus.c | 5 + drivers/pci/setup-res.c | 4 +--- 3 files change

[PATCH v3 5/5] drm/xe/pf: Extend the VF LMEM BAR

2024-10-10 Thread Michał Winiarski
Opt into extending the VF BAR. LMEM is partitioned between multiple VFs, and we expect that the more VFs we have, the less LMEM is assigned to each VF. This means that we can achieve full LMEM BAR access without the need to attempt full VF LMEM BAR resize via pci_resize_resource(). Signed-off-by:

[PATCH v3 4/5] PCI/IOV: Allow extending VF BAR within original resource boundary

2024-10-10 Thread Michał Winiarski
VF MMIO resource reservation, either created by system firmware and inherited by Linux PCI subsystem or created by the subsystem itself, contains enough space to fit the BAR of all SR-IOV Virtual Functions that can potentially be created (total VFs supported by the device). This can be leveraged wh

[PATCH v3 3/5] PCI: Allow IOV resources to be resized in pci_resize_resource

2024-10-10 Thread Michał Winiarski
Similar to regular resizable BAR, VF BAR can also be resized. The structures are very similar, which means we can reuse most of the implementation. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski --- drivers/pci/iov.c | 20 drivers/pci/pci.c | 9

[PATCH] drm/mipi-dsi: fix kernel doc on mipi_dsi_compression_mode_multi

2024-10-10 Thread Dzmitry Sankouski
* Enable or disable Display Stream Compression on the peripheral using the --- base-commit: 4c93ede2b0c73a7708f46a01669769d15d31e1d2 change-id: 20241010-starqltechn_integration_upstream_drm_fix-72233382f98f Best regards, -- Dzmitry Sankouski

[PULL] drm-xe-next

2024-10-10 Thread Thomas Hellstrom
Hi Dave & Simona First drm-xe-next pull request for 6.13 Thanks, Thomas drm-xe-next-2024-10-10: Cross-subsystem Changes: - Add drm_line_printer (Michal) Driver Changes: - Fix an UAF (Matt Auld) - Sanity check compression and coherency mode (Matt Auld) - Some PIC-ID work (Jani) - Use IS_ENABLED(

[bug report] drm: add DRM_SET_CLIENT_NAME ioctl

2024-10-10 Thread Dan Carpenter
Hello Pierre-Eric Pelloux-Prayer, Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct 3, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/drm_debugfs.c:104 drm_clients_info() warn: was precision intended? '64' drivers/gpu/dr

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-10-10 Thread Michał Winiarski
On Fri, Sep 20, 2024 at 12:07:34PM +0200, Christian König wrote: > Am 20.09.24 um 00:35 schrieb Michał Winiarski: > > VF MMIO resource reservation, either created by system firmware and > > inherited by Linux PCI subsystem or created by the subsystem itself, > > contains enough space to fit the BAR

[PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call

2024-10-10 Thread Liu Ying
drm_hdmi_avi_infoframe_from_display_mode() called from it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to initialize an HDMI AVI infoframe. So, drop the redundant hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set(). Signed-off-by: Liu Ying --- drivers/gpu/dr

[PATCH] drm: atmel-hlcdc: bypass LCDC pixel clock divider when using LCDC Generic Clock

2024-10-10 Thread Manikandan Muralidharan
In sam9x7 SoC where XLCDC IP is used,add support to bypass the LCDC pixel clock divider when LCDC Generic clock is enabled.Used to match and drive the panel requested Pixel clock. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 8 +++- include/linu

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-10 Thread Tvrtko Ursulin
On 09/10/2024 23:55, Adrián Larumbe wrote: Hi Tvrtko, On 04.10.2024 14:41, Tvrtko Ursulin wrote: Hi Adrian, On 03/10/2024 00:45, Adrián Larumbe wrote: Some drivers must allocate a considerable amount of memory for bookkeeping structures and GPU's MCU-kernel shared communication regions. Th

Re: [PATCH v3 2/5] PCI: Add a helper to identify IOV resources

2024-10-10 Thread Ilpo Järvinen
On Thu, 10 Oct 2024, Michał Winiarski wrote: > There are multiple places where special handling is required for IOV > resources. > Extract it to a helper and drop a few ifdefs. > > Signed-off-by: Michał Winiarski > --- > drivers/pci/pci.h | 18 ++ > drivers/pci/setup-bus.c

[PATCH][next] drm/amdgpu: Fix potential integer overflow on shift of a int

2024-10-10 Thread Colin Ian King
The left shift of int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then assigned to and operated upon using a 64 bit unsigned integer. In the case where the shift is 32 or more this can lead to an overflow. Avoid this by shifting using the BIT_ULL macro instead. Fixes: f0b19b

Re: [PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 08:41:13PM GMT, Jessica Zhang wrote: > Don't set the merge_3d pending flush bits if the mode_3d is > BLEND_3D_NONE. > > Always flushing merge_3d can cause timeout issues when there are > multiple commits with concurrent writeback enabled. > > This is because the video phys

[PATCH v2] drm/vkms: Remove index parameter from init_vkms_output

2024-10-10 Thread Louis Chauvet
VKMS currently supports only one CRTC, so it make no sense to have this index configurable. To avoid issues, replace this hardcoded index by drm_crtc_mask when applicable. There is no need to manually set a crtc mask on primary and cursor plane as it is automatically set by drmm_crtc_alloc_with_pl

  1   2   >