Re: [PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2024 at 11:26:10AM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2024, Brahmajit Das wrote: > > GCC 15 enables -Werror=unterminated-string-initialization by default. > > This results in the following build error > > > > drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function >

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Pavel Machek
On Wed 2024-10-02 10:13:10, Benjamin Tissoires wrote: > On Oct 01 2024, Pavel Machek wrote: > > Hi! > > > > > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > > > all of the requirements here: > > > - need to be dynamic > > > - still unsure of the userspace implementation,

Re: [PATCH v8 0/5] Support fdinfo runtime and memory stats on Panthor

2024-10-02 Thread Boris Brezillon
On Wed, 02 Oct 2024 12:26:49 +0300 Jani Nikula wrote: > On Wed, 02 Oct 2024, Boris Brezillon wrote: > > Queued to drm-misc-next after applying the few modifications I > > mentioned. Also added Steve's ack (given on IRC) on the first patch. > > Can we have the drm-tip rebuild conflict resoluti

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Ilpo Järvinen
On Wed, 2 Oct 2024, Pavel Machek wrote: > Hi! > > > > +static struct wmi_driver tuxedo_nb04_wmi_ab_driver = { > > > + .driver = { > > > + .name = "tuxedo_nb04_wmi_ab", > > > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > > > + }, > > > + .id_table = tuxedo_nb04_wmi_ab_device_ids, >

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Pavel Machek
On Wed 2024-10-02 13:01:05, Ilpo Järvinen wrote: > On Wed, 2 Oct 2024, Pavel Machek wrote: > > > Hi! > > > > > > +static struct wmi_driver tuxedo_nb04_wmi_ab_driver = { > > > > + .driver = { > > > > + .name = "tuxedo_nb04_wmi_ab", > > > > + .probe_type = PROBE_PR

Re: [PATCH v3] drm/display: Fix building with GCC 15

2024-10-02 Thread Jani Nikula
On Wed, 02 Oct 2024, Brahmajit Das wrote: > GCC 15 enables -Werror=unterminated-string-initialization by default. > This results in the following build error > > drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function > ‘is_hdmi_adaptor’: > drivers/gpu/drm/display/drm_dp_dual_mode_helper.c

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Ilpo Järvinen
On Tue, 1 Oct 2024, Werner Sembach wrote: > The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key > controllable RGB keyboard backlight. The firmware API for it is implemented > via WMI. > > To make the backlight userspace configurable this driver emulates a > LampArray HID d

RE: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-02 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: linux-arm-kernel On > Behalf Of Liu Ying > Sent: Monday, September 30, 2024 6:29 AM > Subject: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter > > Add basic HDMI video output support. Currently, only RGB888 output pixel > format i

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 02 2024, Pavel Machek wrote: > On Wed 2024-10-02 10:13:10, Benjamin Tissoires wrote: > > On Oct 01 2024, Pavel Machek wrote: > > > Hi! > > > > > > > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > > > > all of the requirements here: > > > > - need to be dynamic > >

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Yao Zi
On Wed, Oct 02, 2024 at 09:59:57AM +0200, Neil Armstrong wrote: > I thing the code should look like: > > if (priv->viu.osd1_afbcd) { > meson_canvas_config(priv->canvas, priv->canvas_id_osd1, > priv->viu.osd1_addr, > priv->viu.osd1_stride, >

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Maxime Ripard
+ Jocelyn On Wed, Oct 02, 2024 at 09:59:57AM GMT, Neil Armstrong wrote: > > diff --git a/drivers/gpu/drm/meson/meson_plane.c > > b/drivers/gpu/drm/meson/meson_plane.c > > index b43ac61201f3..b2def784c00d 100644 > > --- a/drivers/gpu/drm/meson/meson_plane.c > > +++ b/drivers/gpu/drm/meson/meson_pl

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-02 Thread Jani Nikula
On Tue, 01 Oct 2024, Christophe JAILLET wrote: > Le 30/09/2024 à 09:48, Jani Nikula a écrit : >> On Sat, 28 Sep 2024, Christophe JAILLET >> wrote: >>> "name" is allocated and freed in intel_backlight_device_register(). >>> The initial allocation just duplicates "intel_backlight". >>> >>> Later,

Re: [PATCH 07/28] drm/i915: Use video aperture helpers

2024-10-02 Thread Jani Nikula
On Mon, 30 Sep 2024, Thomas Zimmermann wrote: > DRM's aperture functions have long been implemented as helpers > under drivers/video/ for use with fbdev. Avoid the DRM wrappers by > calling the video functions directly. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Joonas Lahtinen

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-10-02 Thread Jani Nikula
On Wed, 25 Sep 2024, Maxime Ripard wrote: > On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote: >> I think for at least drm the consensus is clear, we won't have kunit tests >> that splat. > > Where was that ever discussed? Well, where was it ever agreed that it's okay for drm kunit test

Re: [RFC PATCH v4 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Pavel Machek
Hi! > > +static struct wmi_driver tuxedo_nb04_wmi_ab_driver = { > > + .driver = { > > + .name = "tuxedo_nb04_wmi_ab", > > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > > + }, > > + .id_table = tuxedo_nb04_wmi_ab_device_ids, > > + .probe = probe, > > + .remove = remove,

Re: [PATCH v2 2/5] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs

2024-10-02 Thread AngeloGioacchino Del Regno
Il 02/10/24 07:01, Macpaul Lin ha scritto: On 9/30/24 16:49, AngeloGioacchino Del Regno wrote: Il 26/09/24 13:14, Macpaul Lin ha scritto: The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due to an excessively long 'interrupts' property. The error message was: [snip]

Re: [PATCH] drm/i915: Rename functions in the docs to match code changes

2024-10-02 Thread Krzysztof Karas
On 2024-09-30 at 23:25:54 -0700, Harshit Mogalapalli wrote: > make htmldocs is reporting: > > drivers/gpu/drm/i915/i915_irq.c:1: warning: > 'intel_runtime_pm_disable_interrupts' not found > drivers/gpu/drm/i915/i915_irq.c:1: warning: > 'intel_runtime_pm_enable_interrupts' not found > Hi Harshit

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Neil Armstrong
Hi, On 02/10/2024 13:02, Maxime Ripard wrote: + Jocelyn On Wed, Oct 02, 2024 at 09:59:57AM GMT, Neil Armstrong wrote: diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index b43ac61201f3..b2def784c00d 100644 --- a/drivers/gpu/drm/meson/meson_plane.c +++ b/

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-02 Thread Thomas Hellström
Hi, Christian, Ping? Can i get an ack to proceed with this? Thanks, Thomas On Wed, 2024-09-18 at 14:57 +0200, Thomas Hellström wrote: > Sima, Christian > > I've updated the shrinker series now with a guarded for_each macro > instead: > > https://patchwork.freedesktop.org/patch/614514/?series

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-02 Thread Christian König
Ah, yes sorry totally forgotten about that. Give me till Friday to swap everything back into my head again. Christian. Am 02.10.24 um 13:30 schrieb Thomas Hellström: Hi, Christian, Ping? Can i get an ack to proceed with this? Thanks, Thomas On Wed, 2024-09-18 at 14:57 +0200, Thomas Hellst

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-02 Thread Thomas Hellström
Hi On Wed, 2024-10-02 at 13:32 +0200, Christian König wrote: > Ah, yes sorry totally forgotten about that. > > Give me till Friday to swap everything back into my head again. > > Christian. Thanks! Once we agree on a direction MBrost is ready to do an in-depth review. /Thomas > > Am 02.10.

Re: RESEND Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-10-02 Thread Thomas Hellström
Hi, Christian, Gentle ping on this one as well. Thanks, Thomas On Thu, 2024-09-19 at 17:24 +0200, Thomas Hellström wrote: > Hi Christian, > > Ping? > > /Thomas > > > On Thu, 2024-09-12 at 15:40 +0200, Thomas Hellström wrote: > > Hi, Christian, > > > > On Wed, 2024-09-04 at 12:47 +0200, Chri

Re: [PATCH] drm/i915: Rename functions in the docs to match code changes

2024-10-02 Thread Andi Shyti
Hi Harshit, On Mon, Sep 30, 2024 at 11:25:54PM -0700, Harshit Mogalapalli wrote: > make htmldocs is reporting: > > drivers/gpu/drm/i915/i915_irq.c:1: warning: > 'intel_runtime_pm_disable_interrupts' not found > drivers/gpu/drm/i915/i915_irq.c:1: warning: > 'intel_runtime_pm_enable_interrupts' n

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > Hi Benjamin, > > Am 01.10.24 um 15:41 schrieb Benjamin Tissoires: > > On Oct 01 2024, Werner Sembach wrote: > > > (sorry resend because thunderbird made it a html mail) > > > > > > Hi, > > > > > > Am 30.09.24 um 19:06 schrieb Benjamin Tissoires: > > > > On

Re: [PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Jani Nikula
On Tue, 01 Oct 2024, Brahmajit Das wrote: > GCC 15 enables -Werror=unterminated-string-initialization by default. > This results in the following build error > > drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function > ‘is_hdmi_adaptor’: > drivers/gpu/drm/display/drm_dp_dual_mode_helper.c

Re: [PATCH v8 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-10-02 Thread Boris Brezillon
On Tue, 24 Sep 2024 00:06:21 +0100 Adrián Larumbe wrote: > +static u32 calc_profiling_ringbuf_num_slots(struct panthor_device *ptdev, > +u32 cs_ringbuf_size) > +{ > + u32 min_profiled_job_instrs = U32_MAX; > + u32 last_flag = fls(PANTHOR_DEVICE_PROFILIN

Re: [PATCH v8 3/5] drm/panthor: add DRM fdinfo support

2024-10-02 Thread Boris Brezillon
On Tue, 24 Sep 2024 00:06:23 +0100 Adrián Larumbe wrote: > +static void update_fdinfo_stats(struct panthor_job *job) > +{ > + struct panthor_group *group = job->group; > + struct panthor_queue *queue = group->queues[job->queue_idx]; > + struct panthor_gpu_usage *fdinfo = &group->fdinf

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Werner Sembach wrote: > Hi Armin, > > Am 01.10.24 um 18:45 schrieb Armin Wolf: [...snipped...] > > Why not having a simple led driver for HID LampArray devices which exposes > > the > > whole LampArray as a single LED? > Yes that is my plan, but see my last reply to Benjamin, it m

Re: [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

2024-10-02 Thread Thomas Zimmermann
Hi Am 02.10.24 um 00:41 schrieb Tony Luck: My system threw out a bunch of stack traces while booting v6.12-rc1 and hung. Thanks for the bug report. Can you provide the output of 'sudo lspci -vvv' for the graphics device? Best regards Thomas First of these looks like this: [ 33.639799]

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Benjamin Tissoires
On Oct 01 2024, Pavel Machek wrote: > Hi! > > > PPS: sorry for pushing that hard on HID-BPF, but I can see that it fits > > all of the requirements here: > > - need to be dynamic > > - still unsure of the userspace implementation, meaning that userspace > > might do something wrong, which might

Re: [PATCH v8 3/5] drm/panthor: add DRM fdinfo support

2024-10-02 Thread Boris Brezillon
On Sun, 29 Sep 2024 08:25:38 +0800 kernel test robot wrote: > Hi Adrián, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on linus/master] > [also build test ERROR on v6.11 next-20240927] > [cannot apply to drm-misc/drm-misc-next] > [If your patch is applied

[PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-02 Thread Thomas Hellström
The ttm_device_init funcition uses multiple bool arguments. That means readability in the caller becomes poor, and all callers need to change if yet another bool is added. Instead use a struct with multiple single-bit flags. This addresses both problems. Prefer it over using defines or enums with

[PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM

2024-10-02 Thread Thomas Hellström
Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether correc

[PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM

2024-10-02 Thread Thomas Hellström
Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether correc

Re: [PATCH v8 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-10-02 Thread Matthias Brugger
On 14/09/2024 08:31, Jianeng Ceng wrote: Ponyta is a custom label Chromebook based on MT8186. It is a self-developed project of Huaqin and has no fixed OEM. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Jianeng Ceng Reviewed-by: Matthias Brugger

RE: [PATCH v4] docs/gpu: ci: update flake tests requirements

2024-10-02 Thread Deucher, Alexander
[Public] > -Original Message- > From: Vignesh Raman > Sent: Tuesday, October 1, 2024 9:51 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; amd- > g...@lists.freedesktop.org > Cc: dani...@collabora.com; helen.ko...@collabora.com; airl...@gmail.com; > dan...@ffwll.ch; robdc

Re: [PATCH] drm/etnaviv: Print error message if inserting IOVA address range fails

2024-10-02 Thread Lucas Stach
Am Mittwoch, dem 02.10.2024 um 03:26 +0800 schrieb Sui Jingfeng: > Hi, > > On 2024/10/1 16:27, Lucas Stach wrote: > > Hi Sui, > > > > Am Dienstag, dem 01.10.2024 um 06:17 +0800 schrieb Sui Jingfeng: > > > Etnaviv assumes that GPU page size is 4KiB, yet on some systems, the CPU > > > page size is

Re: [PATCH v8 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-10-02 Thread Steven Price
On 02/10/2024 09:38, Boris Brezillon wrote: > On Tue, 24 Sep 2024 00:06:21 +0100 > Adrián Larumbe wrote: > >> +static u32 calc_profiling_ringbuf_num_slots(struct panthor_device *ptdev, >> + u32 cs_ringbuf_size) >> +{ >> +u32 min_profiled_job_instrs = U32_MAX;

Re: [PATCH v8 0/5] Support fdinfo runtime and memory stats on Panthor

2024-10-02 Thread Boris Brezillon
On Tue, 24 Sep 2024 00:06:20 +0100 Adrián Larumbe wrote: > This patch series enables userspace utilities like gputop and nvtop to query a > render context's fdinfo file and figure out rates of engine and memory > utilisation. > > Previous discussion can be found at > https://lore.kernel.org/dri

Re: [PATCH v8 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-10-02 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > @@ -0,0 +1,681 @@ … > +static int sharp_memory_maintain_display(struct sharp_memory_device *smd) > +{ … > + u8 *tx_buffer = smd->tx_buffer; > + > + mutex_lock(&smd->tx_mutex); … > + mutex_unlock(&smd->tx_mutex); > + > + return ret; > +

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-02 Thread Louis Chauvet
On 01/10/24 - 20:54, Randy Dunlap wrote: > Hi-- > > On 9/30/24 8:31 AM, Louis Chauvet wrote: > > The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing > > different concepts (coordinate calculation and color management), extract > > the x_limit and x_dst computation outside of this

Re: [PATCH v2 00/10] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

2024-10-02 Thread Diederik de Haas
Hi Jonas and Laurent, I may be showing my n00bness ... or I actually found something ... On Fri Sep 13, 2024 at 7:30 PM CEST, Diederik de Haas wrote: > On Sun Sep 8, 2024 at 3:28 PM CEST, Jonas Karlman wrote: > > This series ensure poweron/poweroff and CEC phys addr invalidation is > > happening

Re: [v2,06/10] drm/bochs: Allocate DRM device in struct bochs_device

2024-10-02 Thread Kees Bakker
Op 02-09-2024 om 12:53 schreef Thomas Zimmermann: Allocate an instance of struct drm_device in struct bochs_device. Also remove all uses of dev_private from bochs and upcast from the embedded instance if necessary. Signed-off-by: Thomas Zimmermann Acked-by: Gerd Hoffmann --- drivers/gpu/drm/

Re: [PATCH v3 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-10-02 Thread Doug Anderson
Hi, On Fri, Sep 27, 2024 at 2:44 AM Zhaoxiong Lv wrote: > > In MTK chips, if the DRM runtime resume has not yet completed and the > system enters sleep mode at the same time, there is a possibility of > a black screen after waking the machine. Reduce the disable delay > resolves this issue, This

Re: [PATCH v3 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-10-02 Thread Doug Anderson
Hi, On Fri, Sep 27, 2024 at 2:44 AM Zhaoxiong Lv wrote: > > In MTK chips, if the DRM runtime resume has not yet completed and the > system enters sleep mode at the same time, there is a possibility of > a black screen after waking the machine. Reduce the disable delay > resolves this issue, Simi

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-10-02 Thread Lyude Paul
Fine by me On Tue, 2024-10-01 at 10:35 -0300, Jason Gunthorpe wrote: > On Mon, Sep 16, 2024 at 04:42:33PM -0400, Lyude Paul wrote: > > Sigh. Took me a minute but I think I know what happened - I meant to push > > the > > entire series to drm-misc-next and not drm-misc-fixes, but I must have > >

[PATCH][next] drm/amdgpu: Fix spelling mistake "initializtion" -> "initialization"

2024-10-02 Thread Colin Ian King
There is a spelling mistake in a dev_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index b17e

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-02 Thread 林睿祥

Re: [PATCH v8 0/2] Add driver for Sharp Memory LCD

2024-10-02 Thread Uwe Kleine-König
Hello, On Tue, Oct 01, 2024 at 11:37:35PM -0400, Alex Lanzano wrote: > This patch series add support for the monochrome Sharp Memory LCD > panels. This series is based off of the work done by Mehdi Djait. > > References: > https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99

[PATCH 1/3] dma-buf: replace symbolic permission S_IRUGO with octal 0444

2024-10-02 Thread Pintu Kumar
Symbolic permissions are not preferred, instead use the octal. Also, fix other warnings/errors as well for cleanup. WARNING: Block comments use * on subsequent lines + /* only support discovering the end of the buffer, + but also allow SEEK_SET to maintain the idiomatic WARNING: Bl

Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

2024-10-02 Thread Adam Thiede
On 10/1/24 13:02, Jason-JH Lin (林睿祥) wrote: On Tue, 2024-10-01 at 08:55 +, CK Hu (胡俊光) wrote: Hi, Jason: Would you clarify this problem? OK~ Regards, CK On Mon, 2024-09-30 at 12:48 -0500, Adam Thiede wrote: > > External email : Please do not click links or open attachments > until

[PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Brahmajit Das
GCC 15 enables -Werror=unterminated-string-initialization by default. This results in the following build error drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function ‘is_hdmi_adaptor’: drivers/gpu/drm/display/drm_dp_dual_mode_helper.c:164:17: error: initializer-string for array of ‘cha

[PATCH 2/3] dma-buf/heaps: replace kmap_atomic with kmap_local_page

2024-10-02 Thread Pintu Kumar
Use of kmap_atomic/kunmap_atomic is deprecated, use kmap_local_page/kunmap_local instead. This is reported by checkpatch. Also fix repeated word issue. WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead + void *vaddr = kmap_atomic(page); WARNING: Dep

[PATCH 1/1] drm/display: Fix building with GCC 15

2024-10-02 Thread Brahmajit Das
GCC 15 enables -Werror=unterminated-string-initialization by default. This results in the following build error drivers/gpu/drm/display/drm_dp_dual_mode_helper.c: In function ‘is_hdmi_adaptor’: drivers/gpu/drm/display/drm_dp_dual_mode_helper.c:164:17: error: initializer-string for array of ‘cha

[PATCH][next] drm/i915/display: Fix spelling mistake "Uncomressed" -> "Uncompressed"

2024-10-02 Thread Colin Ian King
There is a spelling mistake in a drm_WARN message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display

Re: [RFC PATCH 1/1] drm/meson: Support drm_panic

2024-10-02 Thread Neil Armstrong
Hi ! On 01/10/2024 23:04, Yao Zi wrote: This patch implements drm_plane_helper_funcs.get_scanout_buffer for primary plane, enabling meson-drm to work with drm_panic. This implementation tries to use current framebuffer as scanout buffer. In case of AFBC enabled, we disable the decoder path and

Re: [PATCH][next] drm/i915/display: Fix spelling mistake "Uncomressed" -> "Uncompressed"

2024-10-02 Thread Nautiyal, Ankit K
On 10/2/2024 1:19 PM, Colin Ian King wrote: There is a spelling mistake in a drm_WARN message. Fix it. Signed-off-by: Colin Ian King Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

Re: [PATCH v8 0/5] Support fdinfo runtime and memory stats on Panthor

2024-10-02 Thread Jani Nikula
On Wed, 02 Oct 2024, Boris Brezillon wrote: > Queued to drm-misc-next after applying the few modifications I > mentioned. Also added Steve's ack (given on IRC) on the first patch. Can we have the drm-tip rebuild conflict resolution too, please? diff --cc drivers/gpu/drm/panthor/panthor_drv.c ind

[Bug 203033] nouveau hung task

2024-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203033 Matteo Croce (rootki...@yahoo.it) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-10-02 Thread Armin Wolf
Am 02.10.24 um 10:42 schrieb Benjamin Tissoires: On Oct 01 2024, Werner Sembach wrote: Hi Armin, Am 01.10.24 um 18:45 schrieb Armin Wolf: [...snipped...] Why not having a simple led driver for HID LampArray devices which exposes the whole LampArray as a single LED? Yes that is my plan, but

Re: [PATCH v8 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-10-02 Thread Greg KH
On Wed, Oct 02, 2024 at 10:56:42AM +0200, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > > @@ -0,0 +1,681 @@ > … > > +static int sharp_memory_maintain_display(struct sharp_memory_device *smd) > > +{ > … > > + u8 *tx_buffer = smd->tx_buffer; > > + > > + mutex_lock(&smd

Re: [PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-10-02 Thread AngeloGioacchino Del Regno
Il 16/09/24 19:19, Rob Herring (Arm) ha scritto: On Sat, 14 Sep 2024 14:31:20 +0800, Jianeng Ceng wrote: This is v8 of the MT8186 Chromebook device tree series. --- Changes in v8: - PATCH 1/2: Remove custom label. - PATCH 2/2: Change the commit about ponyta. - Link to v7:https://lore.kernel.or

Re: (subset) [PATCH v5 1/5] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node

2024-10-02 Thread AngeloGioacchino Del Regno
On Wed, 02 Oct 2024 13:16:16 +0800, Macpaul Lin wrote: > The infracfg_ao node in mt8195.dtsi was causing a dtbs_check error. > The error message was: > > syscon@10001000: compatible: ['mediatek,mt8195-infracfg_ao', 'syscon', > 'simple-mfd'] is too long > > To resolve this, remove

Re: (subset) [PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

2024-10-02 Thread AngeloGioacchino Del Regno
On Thu, 12 Sep 2024 22:43:57 +0800, Pin-yen Lin wrote: > This series fixes two binding schema errors in mediatek,dpi binding. > The first patch adds the power-domain property to the binding, and the > second patch adds the port node as it's required by the binding. > > > Pin-yen Lin (2): > dt-b

[PATCH v9 07/11] drm/print: Introduce drm_line_printer

2024-10-02 Thread John . C . Harrison
From: Michal Wajdeczko This drm printer wrapper can be used to increase the robustness of the captured output generated by any other drm_printer to make sure we didn't lost any intermediate lines of the output by adding line numbers to each output line. Helpful for capturing some crash data. v2:

[PATCH v9 0/2] drm/atomic: Ease async flip restrictions

2024-10-02 Thread André Almeida
ge-id: 20241002-tonyk-async_flip-828cfe9cf3ca Best regards, -- André Almeida

[PATCH v9 2/2] drm/amdgpu: Enable async flip on overlay planes

2024-10-02 Thread André Almeida
amdgpu can handle async flips on overlay planes, so allow it for atomic async checks. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pla

[PATCH v9 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-10-02 Thread André Almeida
Currently, DRM atomic uAPI allows only primary planes to be flipped asynchronously. However, each driver might be able to perform async flips in other different plane types. To enable drivers to set their own restrictions on which type of plane they can or cannot flip, use the existing atomic_async

Re: [PATCH v5 2/5] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs

2024-10-02 Thread Rob Herring
On Wed, Oct 02, 2024 at 01:16:17PM +0800, Macpaul Lin wrote: > The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due > to an excessively long 'interrupts' property. The error message was: > > infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0], >

[RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-02 Thread Adrián Larumbe
Some drivers must allocate a considerable amount of memory for bookkeeping structures and GPU's MCU-kernel shared communication regions. These are often created as a result of the invocation of the driver's ioctl() interface functions, so it is sensible to consider them as being owned by the render

[RFC PATCH 0/2] Allow fdinfo to display size of internal BO's

2024-10-02 Thread Adrián Larumbe
This patch series lets DRM fdinfo stats functions display an additional tag that will reflect the amount of memory internal BOs of a DRM driver take up. The rationale for this is that some drivers, like Panthor, need quite a bit of memory for things like queue ring buffers or tiler heap chunks, an

[RFC PATCH 2/2] drm/panthor: register size of internal objects through fdinfo

2024-10-02 Thread Adrián Larumbe
This includes both DRM objects created to support queues, groups and heaps, and also objects whose pages are shared between the GPU and the MCU. However, this doesn't include objects that hold the firmware's binary regions, since these aren't owned by a render context and are allocated only once a

[PATCH] drm/panfrost: Add missing OPP table refcnt decremental

2024-10-02 Thread Adrián Larumbe
Commit f11b0417eec2 ("drm/panfrost: Add fdinfo support GPU load metrics") retrieves the OPP for the maximum device clock frequency, but forgets to keep the reference count balanced by putting the returned OPP object. This eventually leads to an OPP core warning when removing the device. Fix it by

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-02 Thread Jani Nikula
On Wed, 02 Oct 2024, Thomas Hellström wrote: > The ttm_device_init funcition uses multiple bool arguments. That means > readability in the caller becomes poor, and all callers need to change if > yet another bool is added. > > Instead use a struct with multiple single-bit flags. This addresses bot

[PATCH RESEND] locking/ww_mutex: Adjust to lockdep nest_lock requirements

2024-10-02 Thread Thomas Hellström
When using mutex_acquire_nest() with a nest_lock, lockdep refcounts the number of acquired lockdep_maps of mutexes of the same class, and also keeps a pointer to the first acquired lockdep_map of a class. That pointer is then used for various comparison-, printing- and checking purposes, but there

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-02 Thread Thomas Hellström
On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > The ttm_device_init funcition uses multiple bool arguments. That > > means > > readability in the caller becomes poor, and all callers need to > > change if > > yet another bool is added.

Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-10-02 Thread Lee Jones
On Fri, 27 Sep 2024, Werner Sembach wrote: > Hi, > first revision integrating Armins feedback. > > Stuff I did not yet change and did not comment on previously: > - Still have to ask Christoffer why the mutex is required > - Still using acpi_size instad of size_t in the util functions, because th

Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-10-02 Thread Christian König
Am 02.10.24 um 14:24 schrieb Thomas Hellström: The ttm_device_init funcition uses multiple bool arguments. That means readability in the caller becomes poor, and all callers need to change if yet another bool is added. Instead use a struct with multiple single-bit flags. This addresses both prob

Re: [RESEND PATCH] drm/i915:Remove unused parameter in marco

2024-10-02 Thread Jani Nikula
On Wed, 25 Sep 2024, He Lugang wrote: > The parameter dev_priv is actually not used in macro PORT_ALPM_CTL > and PORT_ALPM_LFPS_CTL,so remove it to simplify the code. > > Reviewed-by: Jani Nikula > Signed-off-by: He Lugang > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- > driver

[PATCH v2] drm/amd/pm: check return value of amdgpu_irq_add_id()

2024-10-02 Thread Igor Artemiev
amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. This patch adds error code check. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Signed-off-by: Igor Artemiev --- v2: Remove the cast to struct amdgpu_device as Christian König sugg

[PULL] drm-intel-fixes

2024-10-02 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes toward v6.12-rc2. Just one & vs && fixup into PM code that should only trigger with debug Kconfig options. Regards, Joonas *** drm-intel-fixes-2024-10-02: - One fix for bitwise and logical "and" mixup in PM code The following changes since commit 985

Re: [PATCH v2] drm/amd/pm: check return value of amdgpu_irq_add_id()

2024-10-02 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 2, 2024 at 9:28 AM Igor Artemiev wrote: > > amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. > This patch adds error code check. > > Found by Linux Verification Center (linuxtesting.org) with static > analysis tool SVACE. > > Signed-off-

Re: [PATCH][next] drm/amdgpu: Fix spelling mistake "initializtion" -> "initialization"

2024-10-02 Thread Alex Deucher
Applied. Thanks! On Wed, Oct 2, 2024 at 3:51 AM Colin Ian King wrote: > > There is a spelling mistake in a dev_err message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driver

[PATCH 0/2] drm: Treewide plane/crtc legacy state sweeping

2024-10-02 Thread Ville Syrjala
From: Ville Syrjälä An attempt to hide the drm_plane/crtc legacy state better. This also highlights the fact that a lot of supposedly atomic drivers are poking around in the legacy crtc state, which is rather questionable. For planes we did force the legacy state to NULL already to force drivers

[PATCH 1/2] drm: Move plane->{fb, old_fb, crtc} to legacy sub-structure

2024-10-02 Thread Ville Syrjala
From: Ville Syrjälä Hide the plane->fb/etc. footguns better by stashing them inside a "legacy" sub struct. Eventually maybe we could turn 'legacy' into a pointer that only exists on legacy drivers to completely prevent any abuse by atomic drivers... Side note: _dpu_plane_set_danger_state() look

[PATCH 2/2] drm: Move crtc->{x, y, mode, enabled} to legacy sub-structure

2024-10-02 Thread Ville Syrjala
From: Ville Syrjälä Atomic drivers shouldn't be using the legacy state stored directly under drm_crtc. Move that junk into a 'legacy' sub structure to highlight the offenders, of which there are quite a few unfortunately. I'm hoping we could get all these fixed and then declare the legacy state

[PATCH v2 02/11] drm/xe: Select DRM_CLIENT_SELECTION

2024-10-02 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

[PATCH v2 03/11] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-02 Thread Thomas Zimmermann
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH v2 07/11] drm/amdgpu: Suspend and resume internal clients with client helpers

2024-10-02 Thread Thomas Zimmermann
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc:

[PATCH v2 01/11] drm/i915: Select DRM_CLIENT_SELECTION

2024-10-02 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula i Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 00/11] drm: Introduce DRM client library

2024-10-02 Thread Thomas Zimmermann
With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the in-kernel client code. It is designed such that drivers can opt into client suppor

Re: [PATCH v2 00/31] accel/ivpu: Fixes for 6.12-rc1

2024-10-02 Thread Jacek Lawrynowicz
Applied to drm-misc-fixes On 9/30/2024 9:52 PM, Jacek Lawrynowicz wrote: > Most notable changes are coredump and tracing support. > The rest are stability fixes, some refactoring and typos. > > Changes in v2: > - Fix typos in FW API headers > - Split fw refactor commit into 2 commits and improved

Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-10-02 Thread Werner Sembach
Hi, Am 02.10.24 um 14:52 schrieb Lee Jones: On Fri, 27 Sep 2024, Werner Sembach wrote: Hi, first revision integrating Armins feedback. Stuff I did not yet change and did not comment on previously: - Still have to ask Christoffer why the mutex is required - Still using acpi_size instad of size

Re: [PATCH 02/28] drm/arm/hdlcd: Use video aperture helpers

2024-10-02 Thread Liviu Dudau
On Mon, Sep 30, 2024 at 03:03:00PM +0200, Thomas Zimmermann wrote: > DRM's aperture functions have long been implemented as helpers > under drivers/video/ for use with fbdev. Avoid the DRM wrappers by > calling the video functions directly. > > Signed-off-by: Thomas Zimmermann > Cc: Liviu Dudau

[PATCH 2/2] drm/fbdev: Ensure that one of the probe functions is defined

2024-10-02 Thread Dave Stevenson
Commit 5d08c44e47b9 ("drm/fbdev: Add memory-agnostic fbdev client") added the newer probe function, but left a path where no probe function was called. fb_helper->fb would then be NULL and the strcpy would throw a NULL pointer exception. Handle that error case. Fixes: 5d08c44e47b9 ("drm/fbdev: Ad

[PATCH 0/2] drm: Fix up and error handling after fbdev changes

2024-10-02 Thread Dave Stevenson
ons is defined drivers/gpu/drm/drm_fb_helper.c | 2 ++ drivers/gpu/drm/vc4/vc4_drv.c | 1 + 2 files changed, 3 insertions(+) --- base-commit: 86fdd6b9b1e98cfd26249505e8ce72f4fc0de37f change-id: 20241002-vc4_fbdev_fix-f4c8b11928cd Best regards, -- Dave Stevenson

[PATCH 1/2] drm/vc4: Run default client setup for all variants.

2024-10-02 Thread Dave Stevenson
Commit 45903624e9fc ("drm/vc4: Run DRM default client setup") only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver definition, which caused an issue on vc5 (Pi4) as there was no fbdev_probe function defined. Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup") Signed-off-by: Dav

Re: [PATCH v4 1/2] drm/sched: Use drm sched lockdep map for submit_wq

2024-10-02 Thread Danilo Krummrich
On Wed, Oct 02, 2024 at 03:00:08PM +, Matthew Brost wrote: > On Wed, Oct 02, 2024 at 04:16:00PM +0200, Danilo Krummrich wrote: > > On Wed, Oct 02, 2024 at 06:16:38AM -0700, Matthew Brost wrote: > > > Avoid leaking a lockdep map on each drm sched creation and destruction > > > by using a single

[PULL] drm-misc-fixes

2024-10-02 Thread Thomas Zimmermann
Hi Dave, Sima, although a bit early, here's the week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2024-10-02: Short summary of fixes pull: panthor: - Set FOP_UNSIGNED_OFFSET in fops instance - Acquire lock in panthor_vm_prepare_map_op_ctx() - Avoid ninitialized variable in tick_c

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-02 Thread Louis Chauvet
On 02/10/24 - 08:49, Randy Dunlap wrote: > Hi Louis, > > On 10/2/24 1:57 AM, Louis Chauvet wrote: > > On 01/10/24 - 20:54, Randy Dunlap wrote: > >> Hi-- > >> > >> On 9/30/24 8:31 AM, Louis Chauvet wrote: > >>> The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing > >>> different con

  1   2   >