Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-25 Thread barnabas . czeman
On 2024-08-01 21:25, Dmitry Baryshkov wrote: On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: This patch series add dpu support for MSM8996/MSM8953 devices. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provid

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-25 Thread Dmitry Baryshkov
On Wed, 25 Sept 2024 at 23:28, wrote: > > On 2024-08-01 21:25, Dmitry Baryshkov wrote: > > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > >> This patch series add dpu support for MSM8996/MSM8953 devices. > >> > >> Note, by default these platforms are still handled by the MDP5 dri

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Abhinav Kumar
On 9/25/2024 2:11 PM, Dmitry Baryshkov wrote: On Wed, 25 Sept 2024 at 22:39, Jessica Zhang wrote: On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: From: Dmitry Baryshkov All resource allocation is centered around the LMs. Then

Re: [PATCH] [V2] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

2024-09-25 Thread Dmitry Baryshkov
On Thu, Aug 01, 2024 at 09:10:03AM GMT, Marco Rodolfi wrote: > From: Marco Rodolfi > > This patch also take account of the different resolution for the > aftermarket DeckHD panel, which hasn't been accounted for yet in kernel, > since these quirks are applied based on BIOS information + panel > r

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kwanghoon Son
On Wed, 2024-09-25 at 20:05 +, Kaustabh Chakraborty wrote: > On 2024-09-25 19:56, Krzysztof Kozlowski wrote: > > On 25/09/2024 21:36, Kaustabh Chakraborty wrote: > > > On 2024-09-25 19:25, Krzysztof Kozlowski wrote: > > > > On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > > > > > On 2024-09-2

[PATCH] drm/exynos: remove unused prototype for crtc

2024-09-25 Thread Kwanghoon Son
, - struct exynos_drm_plane *exynos_plane); /* This function gets crtc device matched with out_type. */ struct exynos_drm_crtc *exynos_drm_crtc_get_by_type(struct drm_device *drm_dev, --- base-commit: 684a64bf32b6e488004e0ad7f0d7e922798f65b6 change-id: 20240925

[PATCH v2 1/2] drm: fsl-dcu: Use dev_err_probe

2024-09-25 Thread Alexander Stein
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein --- Changes in v2: * None drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[PATCH v2 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2024-09-25 Thread Alexander Stein
From: Matthias Schiffer The PIXCLK needs to be enabled in SCFG before accessing certain DCU registers, or the access will hang. For simplicity, the PIXCLK is enabled unconditionally, resulting in increased power consumption. Signed-off-by: Matthias Schiffer Signed-off-by: Alexander Stein --- C

Re: [PATCH v4 ] gpu: drm: replace of_graph_get_next_endpoint()

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 12:05:42AM GMT, Kuninori Morimoto wrote: > From DT point of view, in general, drivers should be asking for a > specific port number because their function is fixed in the binding. > > of_graph_get_next_endpoint() doesn't match to this concept. > > Simply replace > >

Re: [PATCH v2 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 07:55:51AM GMT, Alexander Stein wrote: > From: Matthias Schiffer > > The PIXCLK needs to be enabled in SCFG before accessing certain DCU > registers, or the access will hang. For simplicity, the PIXCLK is enabled > unconditionally, resulting in increased power consumption.

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Jessica Zhang
On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: From: Dmitry Baryshkov All resource allocation is centered around the LMs. Then other blocks (except DSCs) are allocated basing on the LMs that was selected, and LM powers up the CRTC

Re: [PATCH v6 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-09-25 Thread Uwe Kleine-König
Hello, On Thu, Sep 05, 2024 at 08:44:00AM -0400, Alex Lanzano wrote: > +static void sharp_memory_crtc_enable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + struct pwm_state pwm_state; > + struct sharp_memory_device *smd = drm_to_sharp_m

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-25 Thread Dmitry Baryshkov
On Wed, 25 Sept 2024 at 22:39, Jessica Zhang wrote: > > > > On 9/24/2024 4:13 PM, Dmitry Baryshkov wrote: > > On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: > >> From: Dmitry Baryshkov > >> > >> All resource allocation is centered around the LMs. Then other blocks > >> (except DSCs)

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-25 Thread Matthew Brost
On Tue, Sep 24, 2024 at 04:30:06PM +, Matthew Brost wrote: > On Tue, Sep 24, 2024 at 12:42:56PM +0200, Thomas Hellström wrote: > > Hi, Matt, > > > > Some random review comments on this patch I came across while looking > > at multi-device. > > > > Thanks, > > Thomas > > > > > > On Tue, 2024

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Marek Vasut
On 9/25/24 5:07 PM, Philipp Zabel wrote: Hi, On Di, 2024-09-24 at 17:28 +0200, Marek Vasut wrote: On 9/6/24 11:01 AM, Philipp Zabel wrote: [...] Instead of presenting two devices to userspace, it would be better to have a single video device that can distribute work to both IPUs. Why do yo

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Marek Vasut
On 9/25/24 7:58 PM, Nicolas Dufresne wrote: Hi, [...] +static struct v4l2_pix_format * +ipu_mem2mem_vdic_get_format(struct ipu_mem2mem_vdic_priv *priv, + enum v4l2_buf_type type) +{ + return &priv->fmt[V4L2_TYPE_IS_OUTPUT(type) ? V4L2_M2M_SRC : V4L2_M2M_DST]; +

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-25 Thread Marek Vasut
On 9/25/24 6:43 PM, Philipp Zabel wrote: On Di, 2024-09-24 at 12:47 +0200, Marek Vasut wrote: On 9/4/24 11:05 AM, Philipp Zabel wrote: On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 subsampling, turn it into boolean to se

Re: [PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-25 Thread Jessica Zhang
On 9/25/2024 1:12 AM, Jani Nikula wrote: On Tue, 24 Sep 2024, Jessica Zhang wrote: Add helper to check if the given CRTC state is in clone mode Signed-off-by: Jessica Zhang --- include/drm/drm_crtc.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_crtc.h b/inc

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-25 Thread Rob Clark
On Tue, Sep 24, 2024 at 8:22 AM Akhil P Oommen wrote: > > On Tue, Sep 24, 2024 at 07:47:12AM -0700, Rob Clark wrote: > > On Tue, Sep 24, 2024 at 4:54 AM Antonino Maniscalco > > wrote: > > > > > > On 9/20/24 7:09 PM, Akhil P Oommen wrote: > > > > On Wed, Sep 18, 2024 at 09:46:33AM +0200, Neil Arms

Re: [PATCH v3] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-25 Thread Helge Deller
On 9/25/24 07:29, Qianqiang Liu wrote: syzbot has found a NULL pointer dereference bug in fbcon. Here is the simplified C reproducer: struct param { uint8_t type; struct tiocl_selection ts; }; int main() { struct fb_con2fbmap con2fb; struct param param;

Re: [PATCH] fbdev: omapfb: Call of_node_put(ep) only once in omapdss_of_find_source_for_first_ep()

2024-09-25 Thread Helge Deller
On 9/25/24 21:21, Markus Elfring wrote: From: Markus Elfring Date: Wed, 25 Sep 2024 21:12:36 +0200 An of_node_put(ep) call was immediately used after a pointer check for a of_graph_get_remote_port() call in this function implementation. Thus call such a function only once instead directly befor

[PATCH v6 1/9] of: property: add of_graph_get_next_port()

2024-09-25 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_device_endpoint() - of_graph_get_device_endpoint_count() - for_each_of_graph_device_endpoint() Here, for_each_of_graph_device_endpoint() loop finds each endpoints ports { port@0 { (1)

[PATCH v6 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-09-25 Thread Kuninori Morimoto
We already have of_graph_get_next_endpoint(), but it is not intuitive to use in some case. (X) node { (Y) ports { (P0)port@0 { endpoint { remote-endpoint = ...; };}; (P10) port@1 { endpoint { remote-endpoint = ...; }; (P11)

[PATCH v6 0/9] of: property: add of_graph_get_next_port/port_endpoint()

2024-09-25 Thread Kuninori Morimoto
Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark This is v6 patch-set Current Of-graph has "endpoint base" for loop, but doesn't have "port base" loop. "endpoint base" loop only is not enough. This patch-set add new "port base" for loop, and use it. Unfortunately, new helper function need to call

[PATCH v6 4/9] ASoC: rcar_snd: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/sh/rcar/core.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c i

[PATCH v6 3/9] ASoC: test-component: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Current test-component.c is using for_each_endpoint_of_node() for parsing "port", because there was no "port" base loop before. It has been assuming 1 port has 1 endpoint here. But now we can use "port" base loop (= for_each_of_graph_port()). Let's replace for_each function from "endpoint" base to

[PATCH v6 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card2.c | 104 -- 1 file changed, 48 insertions(+), 56 deletions(-) diff --git a/sound/soc/generic/audio-graph-car

[PATCH v6 8/9] fbdev: omapfb: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dpi.c| 3 +- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 66 --- drivers/video/fbdev/omap2/omapfb/dss/dss.c| 20 +++--- drive

[PATCH v6 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Acked-by: Mark Brown --- sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-

[PATCH v6 9/9] media: xilinx-tpg: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/media/platform/xilinx/xilinx-tpg.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/xilinx/xilin

[PATCH v6 7/9] gpu: drm: omapdrm: use new of_graph functions

2024-09-25 Thread Kuninori Morimoto
Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- drivers/gpu/drm/omapdrm/dss/sdi.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH v4 ] gpu: drm: replace of_graph_get_next_endpoint()

2024-09-25 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-25 Thread Helge Deller
Hi Ville, On 9/23/24 17:57, Ville Syrjala wrote: Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the attribute even

Re: [PATCH v2 1/2] drm: fsl-dcu: Use dev_err_probe

2024-09-25 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 07:55:50AM GMT, Alexander Stein wrote: > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe > to remove an invalid error message and add it to deferral description. > > Signed-off-by: Alexander Stein > --- > Changes in v2: > * None > > drivers/gpu/dr

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Krzysztof Kozlowski
On 25/09/2024 22:05, Kaustabh Chakraborty wrote: > On 2024-09-25 19:56, Krzysztof Kozlowski wrote: >> On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >>> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: On 25/09/2024 20:42, Kaustabh Chakraborty wrote: > On 2024-09-20 12:39, Krzysztof Kozlo

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Krzysztof Kozlowski
On 25/09/2024 21:36, Kaustabh Chakraborty wrote: > On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >>> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: On 19/09/2024 17:20, Kaustabh Chakraborty wrote: > Add the compatible string of Exynos7

Re: [PATCH v2] drm/meson: switch to a managed drm device

2024-09-25 Thread Martin Blumenstingl
Hi Anastasia, thank you for picking this up and apologies for my late reply. On Tue, Sep 10, 2024 at 5:17 PM Anastasia Belova wrote: [...] > @@ -215,7 +210,7 @@ static int meson_drv_bind_master(struct device *dev, bool > has_components) > regs = devm_platform_ioremap_resource_byname(pde

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-25 19:56, Krzysztof Kozlowski wrote: > On 25/09/2024 21:36, Kaustabh Chakraborty wrote: >> On 2024-09-25 19:25, Krzysztof Kozlowski wrote: >>> On 25/09/2024 20:42, Kaustabh Chakraborty wrote: On 2024-09-20 12:39, Krzysztof Kozlowski wrote: > On 19/09/2024 17:20, Kaustabh Chakrab

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-25 19:25, Krzysztof Kozlowski wrote: > On 25/09/2024 20:42, Kaustabh Chakraborty wrote: >> On 2024-09-20 12:39, Krzysztof Kozlowski wrote: >>> On 19/09/2024 17:20, Kaustabh Chakraborty wrote: Add the compatible string of Exynos7870 to the existing list. Signed-off-by: Kaus

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-20 12:39, Krzysztof Kozlowski wrote: > On 19/09/2024 17:20, Kaustabh Chakraborty wrote: >> Add the compatible string of Exynos7870 to the existing list. >> >> Signed-off-by: Kaustabh Chakraborty > > ... and the DTS is ? Didn't quite understand. The patch adds the compatible string fo

Re: [PATCH] drm: xlnx: zynqmp_dpsub: also call drm_helper_hpd_irq_event

2024-09-25 Thread Steffen Dirkwinkel
Hi Laurent, On Tue, 2024-09-24 at 21:43 +0300, Laurent Pinchart wrote: > Hi Steffen, > > Thank you for the patch. > > On Mon, Sep 23, 2024 at 09:48:03AM +0200, li...@steffen.cc wrote: > > From: Steffen Dirkwinkel > > > > With hpd going through the bridge as of commit eb2d64bfcc17 > > ("drm: xl

Re: [PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()

2024-09-25 Thread Kaustabh Chakraborty
On 2024-09-20 12:40, Krzysztof Kozlowski wrote: > On 19/09/2024 17:11, Kaustabh Chakraborty wrote: >> decon_commit() gets called during atomic_enable. At this stage, DECON is >> suspended, and thus the function refuses to run. Fix the suspended >> condition checking in decon_commit(). >> >> Signed

Re: [PATCH v5 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-25 Thread 胡俊光

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Christian König
Am 25.09.24 um 01:05 schrieb Dmitry Baryshkov: On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote: On 9/23/24 1:33 AM, Dmitry Baryshkov wrote: Hi, On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens Wiklander wrote: Hi, This patch set is based on top of Yong Wu's restricted heap patch set [

Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs

2024-09-25 Thread Macpaul Lin
On 9/25/24 00:00, Conor Dooley wrote: On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del Regno wrote: Il 24/09/24 12:31, Macpaul Lin ha scritto: The display node in mt8195.dtsi was triggering a CHECK_DTBS error due to an excessively long 'clocks' property: display@14f06000: cl

Re: [PATCH v2 02/10] drm/bochs: Use helpers for struct drm_edid

2024-09-25 Thread Dmitry Baryshkov
On Wed, Sep 25, 2024 at 10:15:49AM GMT, Thomas Zimmermann wrote: > Hi > > Am 23.09.24 um 06:35 schrieb Dmitry Baryshkov: > > On Mon, Sep 02, 2024 at 12:53:40PM GMT, Thomas Zimmermann wrote: > > > Implement a read function for struct drm_edid and read the EDID data > > > with drm_edit_read_custom()

Re: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Jani Nikula
On Thu, 19 Sep 2024, Arun R Murthy wrote: > In Display 20+, new registers are added for setting index, reading > histogram and writing the IET. > > v2: Removed duplicate code (Jani) > v3: Moved histogram core changes to earlier patches (Jani/Suraj) > > Signed-off-by: Arun R Murthy > --- > .../gp

Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Jens Wiklander
On Mon, Sep 23, 2024 at 09:33:29AM +0300, Dmitry Baryshkov wrote: > Hi, > > On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens Wiklander wrote: > > Hi, > > > > This patch set is based on top of Yong Wu's restricted heap patch set [1]. > > It's also a continuation on Olivier's Add dma-buf secure-heap pa

Re: [PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-25 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 02:06:35AM GMT, Dmitry Baryshkov wrote: > On Tue, Sep 24, 2024 at 03:59:17PM GMT, Jessica Zhang wrote: > > Add helper to check if the given CRTC state is in clone mode > > > > Signed-off-by: Jessica Zhang > > --- > > include/drm/drm_crtc.h | 7 +++ > > 1 file change

Re: [PATCH v2 02/22] drm: Add valid clones check

2024-09-25 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 03:59:18PM GMT, Jessica Zhang wrote: > Check that all encoders attached to a given CRTC are valid > possible_clones of each other. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/drm_atomic_helper.c | 23 +++ > 1 file changed, 23 insertions(+)

Re: [PATCH v4 18/26] drm: sun4i: de3: Implement AFBC support

2024-09-25 Thread Dan Carpenter
Hi Ryan, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Walklin/drm-sun4i-de2-de3-Change-CSC-argument/20240921-175532 base: https://git.kernel.org/pub/scm/lin

Re: [PATCH v2 14/22] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-25 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 05:05:43PM GMT, Abhinav Kumar wrote: > > > On 9/24/2024 4:25 PM, Dmitry Baryshkov wrote: > > On Tue, Sep 24, 2024 at 03:59:30PM GMT, Jessica Zhang wrote: > > > If the clone mode enabled status is changing, a modeset needs to happen > > > so that the resources can be reassi

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-09-25 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 05:14:49PM GMT, Jessica Zhang wrote: > > > On 9/24/2024 4:41 PM, Dmitry Baryshkov wrote: > > On Tue, Sep 24, 2024 at 03:59:32PM GMT, Jessica Zhang wrote: > > > Cache the CWB block mask in the DPU virtual encoder and configure CWB > > > according to the CWB block mask withi

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-25 Thread Jocelyn Falempe
On 24/09/2024 16:02, Alex Deucher wrote: On Fri, Sep 20, 2024 at 11:36 AM Jocelyn Falempe wrote: On 17/09/2024 15:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a L

Re: [PATCH v3 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-25 Thread Dmitry Baryshkov
On Wed, Sep 25, 2024 at 02:48:22PM GMT, Liankun Yang wrote: > When using type-c to type-c to connect to the monitor, > the sound plays normally. If you unplug the type-c and > connect the type-c to hdmi dongle to the monitor, there will be noise. > > By capturing the audio data, it is found that >

Re: [PATCH] drm/display/dsc: Refactor MST DSC Determination Policy

2024-09-25 Thread Dan Carpenter
Hi Fangzhi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Fangzhi-Zuo/drm-display-dsc-Refactor-MST-DSC-Determination-Policy/20240920-014114 base: git://anongit.fr

[PATCH v1 1/1] drm/mediatek: Fix wrong check of nvmem_cell_read

2024-09-25 Thread Liankun Yang
If the len is 0, kernel crash will occur when performing operations. Add the len check conditions to prevent kernel crash. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Signed-off-by: Liankun Yang --- drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- 1 file changed, 1 ins

Re: [PATCH v4] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-25 Thread 胡俊光

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-25 Thread Michel Dänzer
On 2024-09-24 16:02, Alex Deucher wrote: > On Fri, Sep 20, 2024 at 11:36 AM Jocelyn Falempe wrote: >> On 17/09/2024 15:21, Alex Deucher wrote: >>> On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on th

Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-25 Thread Jens Wiklander
Hi, On Tue, Sep 24, 2024 at 01:13:18PM -0500, Andrew Davis wrote: > On 9/23/24 1:33 AM, Dmitry Baryshkov wrote: > > Hi, > > > > On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens Wiklander wrote: > > > Hi, > > > > > > This patch set is based on top of Yong Wu's restricted heap patch set [1]. > > > It'

Re: [PATCH v2] drm/ci: uprev mesa, IGT and deqp-runner

2024-09-25 Thread Helen Mae Koike Fornazier
On Tue, 10 Sep 2024 10:19:24 -0300 Vignesh Raman wrote --- > Uprev mesa, IGT to the latest version and deqp-runner > to v0.20.0. Also update expectation files. > > Acked-by: Helen Koike helen.ko...@collabora.com> > Reviewed-by: Daniel Stone dani...@collabora.com> > Signed-o

[PATCH v3] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-25 Thread Tejas Vipin
Changes the elida-kd35t133 panel to use multi style functions for improved error handling. Reviewed-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov Signed-off-by: Tejas Vipin --- Changes in v3: - Added back bytes that were removed - Replaced mipi_dsi_dcs_write_buffer_multi with mipi_dsi

[PATCH v5 2/2] drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs

2024-09-25 Thread Jason-JH . Lin
Since some SoCs support premultiplied pixel formats but some do not, the blend_modes parameter is added to mtk_plane_init(), which is obtained from the mtk_ddp_comp_get_blend_modes function implemented in different OVL components. The OVL component can use driver data to set the blend mode capabil

[PATCH v5 1/2] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-25 Thread Jason-JH . Lin
OVL_CON_CLRFMT_MAN is a configuration for extending color format settings of DISP_REG_OVL_CON(n). It will change some of the original color format settings. Take the settings of (3 << 12) for example. - If OVL_CON_CLRFMT_MAN = 0 means OVL_CON_CLRFMT_RGBA. - If OVL_CON_CLRFMT_MAN = 1 means OVL_

[PATCH v5 0/2] Fix degradation problem of alpha blending series

2024-09-25 Thread Jason-JH . Lin
From: Jason-jh Lin Some SoCs not support pre-multiplied pixel formats and extending configuration of OVL pre-multiplied color formats, such as MT8173. Fix the SoC degradation problem by this sreies. --- Change in v5: Add fix patch for mtk_plane Change in v4: Add lost cases of mtk_ovl_fmt_conv

Re: [PATCH] MAINTAINERS: update Microchip's Atmel-HLCDC driver maintainers

2024-09-25 Thread Hari.PrasathGE
On 6/20/24 10:32 PM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Manikandan and Dharma. > > On Thu, Jun 20, 2024 at 03:28:56PM +0530, Manikandan Muralidharan wrote: >> Drop Sam Ravnborg and Boris Brezillon as they ar

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Murthy, Arun R
> > .../gpu/drm/i915/display/intel_histogram.c| 111 +- > > .../drm/i915/display/intel_histogram_reg.h| 25 > > 2 files changed, 105 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c > > b/drivers/gpu/drm/i915/display/i

Re: [PATCH] drm: xlnx: zynqmp_dpsub: also call drm_helper_hpd_irq_event

2024-09-25 Thread Laurent Pinchart
Hi Steffen, On Wed, Sep 25, 2024 at 09:54:18AM +0200, Steffen Dirkwinkel wrote: > On Tue, 2024-09-24 at 21:43 +0300, Laurent Pinchart wrote: > > On Mon, Sep 23, 2024 at 09:48:03AM +0200, li...@steffen.cc wrote: > > > From: Steffen Dirkwinkel > > > > > > With hpd going through the bridge as of co

RE: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-25 Thread Zeng, Oak
Hi Sima, > -Original Message- > From: Simona Vetter > Sent: Tuesday, September 24, 2024 5:25 AM > To: Zeng, Oak > Cc: Brost, Matthew ; intel- > x...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > thomas.hellst...@linux.intel.com; Auld, Matthew > ; dan...@ffwll.ch; airl...@gmai

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-25 Thread Philipp Zabel
On Di, 2024-09-24 at 12:47 +0200, Marek Vasut wrote: > On 9/4/24 11:05 AM, Philipp Zabel wrote: > > On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: > > > The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 > > > subsampling, turn it into boolean to select exactly that and update

Re: [PATCH v7 09/10] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps

2024-09-25 Thread Alex Hung
Mario and Melissa, This patch causes a regrerssion on 7900 XTX in an IGT test: amd_mem_leak's connector-suspend-resume. Is this patch necessary on this series or is it independent from other patches, i.e. can it be dropped from this series until fixed?? Cheers, Alex Hung On 9/18/24 15:38,

Re: [PATCH v7 09/10] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps

2024-09-25 Thread Mario Limonciello
Alex, Unfortunately I can't reproduce the regression on the APU I tried. However I do have a suspicion on a fix. Can you see if this helps? If it does, we can squash it in. diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c in

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 05:59, Maxime Ripard wrote: ... All I'm saying it generates an extra burden for current real world CI systems that run tests on a massive scale and even have paid maintainers. It's not trivial to sort out expected and unexpected warnings, and keep the filters updated every time the wa

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-25 Thread Guenter Roeck
On 9/25/24 06:05, Maxime Ripard wrote: [ ... ] We've had similar discussions in the past around unit tests that wasted too much cpu time with randomized combinatorial testing, and we've thrown those out too from drm. Test hygiene matters. We had that discussion because those tests could run fo

[PATCH] gpu: host1x: Fix boot regression for Tegra

2024-09-25 Thread Jon Hunter
Commit 4c27ac45e622 ("gpu: host1x: Request syncpoint IRQs only during probe") caused a boot regression for the Tegra186 device. Following this update the function host1x_intr_init() now calls host1x_hw_intr_disable_all_syncpt_intrs() during probe. However, host1x_intr_init() is called before runtim

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Nicolas Dufresne
Hi, Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. > Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to > memory. This only works for single stream, that is, one input from > one camera is deint

Re: radeon ARUBA NULL pointer dereference

2024-09-25 Thread Ewan Milne
Follow-up, qla2xxx appears to be fixed, most recent test was with: commit 684a64bf32b6e488004e0ad7f0d7e922798f65b6 (HEAD -> master, origin/master, origin/HEAD) Merge: f7fccaa77271 68898131d2df Author: Linus Torvalds Date: Tue Sep 24 15:44:18 2024 -0700 Merge tag 'nfs-for-6.12-1' of git://g

Re: NULL pointer dereference after ib test on ring 7 succeeded

2024-09-25 Thread Thomas Zimmermann
Hi Am 25.09.24 um 02:22 schrieb Arthur Marsh: After rebuilding current Linus git head with: dma-mapping: report unlimited DMA addressing in IOMMU DMA path b348b6d17fd1d5d89b86db602f02bea54a754bd8 I cannot yet apply this patch locally as a function is missing. I'll wait for -rc1 to do further

Re: [PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-25 Thread Jani Nikula
On Tue, 24 Sep 2024, Jessica Zhang wrote: > Add helper to check if the given CRTC state is in clone mode > > Signed-off-by: Jessica Zhang > --- > include/drm/drm_crtc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 8b48a19

Re: [PATCH v2 02/10] drm/bochs: Use helpers for struct drm_edid

2024-09-25 Thread Thomas Zimmermann
Hi Am 23.09.24 um 06:35 schrieb Dmitry Baryshkov: On Mon, Sep 02, 2024 at 12:53:40PM GMT, Thomas Zimmermann wrote: Implement a read function for struct drm_edid and read the EDID data with drm_edit_read_custom(). Update the connector data accordingly. The EDID data comes from the emulator itse

Re: [PATCH v2 06/22] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-09-25 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 05:37:30PM GMT, Jessica Zhang wrote: > > > On 9/24/2024 4:16 PM, Dmitry Baryshkov wrote: > > On Tue, Sep 24, 2024 at 03:59:22PM GMT, Jessica Zhang wrote: > > > From: Dmitry Baryshkov > > > > > > Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources > > >

Re:Re: [PATCH v3 00/15] VOP Support for rk3576

2024-09-25 Thread Andy Yan
Hi Michael, At 2024-09-24 17:34:52, "Michael Riesch" wrote: >Hi Andy, > >On 9/20/24 10:16, Andy Yan wrote: >> [...] > >A few minor nitpicks: > >> Andy Yan (15): >> drm/rockchip: vop2: Add debugfs support > >There is an extra space in the extended commit message ("...summary: >dump..." -> "...s

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-25 Thread Steven Price
On 23/09/2024 21:43, Adrián Larumbe wrote: > Hi Steve, > > On 23.09.2024 09:55, Steven Price wrote: >> On 20/09/2024 23:36, Adrián Larumbe wrote: >>> Hi Steve, thanks for the review. >> >> Hi Adrián, >> >>> I've applied all of your suggestions for the next patch series revision, so >>> I'll >>> o

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-25 Thread Murthy, Arun R
> > > +static int intel_histogram_enable(struct intel_crtc *intel_crtc) { > > > + struct intel_display *display = to_intel_display(intel_crtc); > > > + struct intel_histogram *histogram = intel_crtc->histogram; > > > + int pipe = intel_crtc->pipe; > > > + u64 res; > > > + u32 gbandthreshold; > > >

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-25 Thread Philipp Zabel
Hi, On Di, 2024-09-24 at 17:28 +0200, Marek Vasut wrote: > On 9/6/24 11:01 AM, Philipp Zabel wrote: [...] > > Instead of presenting two devices to userspace, it would be better to > > have a single video device that can distribute work to both IPUs. > > Why do you think so ? The scaler/colorspac

[PATCHv2 2/7] drm/i915/histogram: Add support for histogram

2024-09-25 Thread Arun R Murthy
Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This e

[PATCH 3/7] drm/xe: Add histogram support to Xe builds

2024-09-25 Thread Arun R Murthy
Histogram added as part of i915/display driver. Adding the same for xe as well. Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/xe/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index 1122765c711

[PATCHv4 4/7] drm/i915/histogram: histogram interrupt handling

2024-09-25 Thread Arun R Murthy
Upon enabling histogram an interrupt is trigerred after the generation of the statistics. This patch registers the histogram interrupt and handles the interrupt. v2: Added intel_crtc backpointer to intel_histogram struct (Jani) Removed histogram_wq and instead use dev_priv->unodered_eq (Jani)

[PATCH 6/7] drm/i915/histogram: histogram delay counter doesnt reset

2024-09-25 Thread Arun R Murthy
The delay counter for histogram does not reset and as a result the histogram bin never gets updated. Workaround would be to use save and restore histogram register. Wa: 14014889975 Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_histogram.c | 17 + .../gpu/dr

[PATCH 1/7] drm/i915/histogram: Define registers for histogram

2024-09-25 Thread Arun R Murthy
Add the register/bit definitions for global histogram. Signed-off-by: Arun R Murthy --- .../drm/i915/display/intel_histogram_reg.h| 54 +++ 1 file changed, 54 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_histogram_reg.h diff --git a/drivers/gpu/drm/i9

[PATCHv4 7/7] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Arun R Murthy
In Display 20+, new registers are added for setting index, reading histogram and writing the IET. v2: Removed duplicate code (Jani) v3: Moved histogram core changes to earlier patches (Jani/Suraj) v4: Rebased after addressing comments on patch 1 Signed-off-by: Arun R Murthy --- .../gpu/drm/i915

[PATCHv4 0/7] Display Global Histogram

2024-09-25 Thread Arun R Murthy
Display histogram is a hardware functionality where a statistics for 'x' number of frames is generated to form a histogram data. This is notified to the user via histogram event. Compositor will then upon sensing the histogram event will read the histogram data from KMD via crtc property. A library

[PATCHv4 5/7] drm/i915/histogram: Add crtc properties for global histogram

2024-09-25 Thread Arun R Murthy
CRTC properties have been added for enable/disable histogram, reading the histogram data and writing the IET data. "HISTOGRAM_EN" is the crtc property to enable/disable the global histogram and takes a value 0/1 accordingly. "Histogram" is a crtc property to read the binary histogram data. "Global

[PATCH 4/6] drm/meson: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`meson_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/meson/meson_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/dr

[PATCH 5/6] drm/panel: ili9322: Constify struct regmap_bus

2024-09-25 Thread Javier Carrasco
`ili9322_regmap_bus` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili932

[PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-25 Thread Melissa Wen
091a97e542cf ("drm/amd/display: Fix warning. Set MAX_SURFACES to 3") reduced the max number of surfaces since, at that time, there was no use for more. However, HW and driver evolves and there are now driver versions that allow two overlay planes (max_slave_planes). Moreover, commit 3cfd03b79425 ("

[PATCH 0/2] drm/amd/display: increase MAX_SURFACES in line with planes and streams

2024-09-25 Thread Melissa Wen
Hi! AFAIU, the driver is defining two different max number of surfaces: MAX_SURFACES (dc.h) and MAX_SURFACE_NUM (dc_types.h) Many years ago, MAX_SURFACES was set 3 just to prevent a stack size warning as in 091a97e542cf ("drm/amd/display: Fix warning. Set MAX_SURFACES to 3")[1]. But according to c

[PATCH 6/6] drm/sprd: Constify struct regmap_bus

2024-09-25 Thread Javier Carrasco
`regmap_txt_io` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/sprd/sprd_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd

[PATCH 2/2] drm/amd/display: add warnings for MAX_SURFACES mismatch

2024-09-25 Thread Melissa Wen
So that, in the future, when the max number of planes and streams increases, they might be synced with the number of surfaces to prevent array-index-out-of-bounds issues. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +++ 1 file changed, 20 ins

[PATCH 2/6] drm/fsl-dcu: Constify struct regmap_config

2024-09-25 Thread Javier Carrasco
`fsl_tcon_regmap_config` is not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers/g

  1   2   3   >