Re: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings

2024-09-24 Thread Rob Herring
On Mon, Sep 23, 2024 at 07:53:57PM +0200, Marek Vasut wrote: > On 9/23/24 3:57 PM, Lukasz Majewski wrote: > > Up till now the fsl,lcdif.yaml was requiring the "port" property as a > > must have to specify the display interface on iMX devices. > > > > However, it shall also be possible to specify t

[PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-24 Thread Jessica Zhang
Add helper to check if the given CRTC state is in clone mode Signed-off-by: Jessica Zhang --- include/drm/drm_crtc.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8b48a1974da3..ecb93e2c4afc 100644 --- a/include/drm/drm_crtc.h +++

[PATCH v2 06/22] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-09-24 Thread Jessica Zhang
From: Dmitry Baryshkov Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources from dpu_crtc_assign_resources(). Signed-off-by: Dmitry Baryshkov [quic_abhin...@quicinc.com: cleaned up formatting] Signed-off-by: Abhinav Kumar [quic_jessz...@quicinc.com: dropped clearing num_mixer

[PATCH v2 11/22] drm/msm/dpu: add CWB support to dpu_hw_wb

2024-09-24 Thread Jessica Zhang
From: Esha Bharadwaj Adjust the WB_MUX configuration to account for using dedicated CWB pingpong blocks. Signed-off-by: Esha Bharadwaj Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-09-24 Thread Jessica Zhang
Cache the CWB block mask in the DPU virtual encoder and configure CWB according to the CWB block mask within the writeback phys encoder Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 83 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.

[PATCH v2 22/22] drm/msm/dpu: Set possible clones for all encoders

2024-09-24 Thread Jessica Zhang
Set writeback encoders as possible clones for non-writeback encoders and vice versa. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c |

[PATCH v2 00/22] drm/msm/dpu: Add Concurrent Writeback Support for DPU 10.x+

2024-09-24 Thread Jessica Zhang
DPU supports a single writeback session running concurrently with primary display when the CWB mux is configured properly. This series enables clone mode for DPU driver and adds support for programming the CWB mux in cases where the hardware has dedicated CWB pingpong blocks. Currently, the CWB har

[PATCH v2 02/22] drm: Add valid clones check

2024-09-24 Thread Jessica Zhang
Check that all encoders attached to a given CRTC are valid possible_clones of each other. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic_helper.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_a

[PATCH v2 07/22] drm/msm/dpu: Add CWB entry to catalog for SM8650

2024-09-24 Thread Jessica Zhang
From: Esha Bharadwaj Add a new block for concurrent writeback mux to the SM8650 HW catalog Signed-off-by: Esha Bharadwaj Signed-off-by: Jessica Zhang --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 21 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 13 ++

[PATCH v2 03/22] drm/msm/dpu: get rid of struct dpu_rm_requirements

2024-09-24 Thread Jessica Zhang
From: Dmitry Baryshkov The struct dpu_rm_requirements was used to wrap display topology and hw resources, which meant INTF indices. As of commit ef58e0ad3436 ("drm/msm/dpu: get INTF blocks directly rather than through RM") the hw resources struct was removed, leaving struct dpu_rm_requirements co

[PATCH v2 19/22] drm/msm/dpu: Start frame done timer after encoder kickoff

2024-09-24 Thread Jessica Zhang
Starting the frame done timer before the encoder is finished kicking off can lead to unnecessary frame done timeouts when the device is experiencing heavy load (ex. when debug logs are enabled). Thus, create a separate API for starting the encoder frame done timer and call it after the encoder kic

[PATCH v2 04/22] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-09-24 Thread Jessica Zhang
From: Dmitry Baryshkov Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id in preparation for the next step. Signed-off-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 +-- drivers/gpu/drm

[PATCH v2 20/22] drm/msm/dpu: Skip trigger flush and start for CWB

2024-09-24 Thread Jessica Zhang
For concurrent writeback, the real time encoder is responsible for trigger flush and trigger start. Return early for trigger start and trigger flush for the concurrent writeback encoders. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 ++ 1 file

[PATCH v2 08/22] drm/msm/dpu: Specify dedicated CWB pingpong blocks

2024-09-24 Thread Jessica Zhang
Change pingpong index and names to distinguish between general use pingpong blocks and pingpong blocks dedicated for concurrent writeback Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 8 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h

[PATCH v2 15/22] drm/msm/dpu: Reserve resources for CWB

2024-09-24 Thread Jessica Zhang
Add support for RM to reserve dedicated CWB pingpongs and CWB muxes For concurrent writeback, even-indexed CWB muxes must be assigned to even-indexed LMs and odd-indexed CWB muxes for odd-indexed LMs. The same even/odd rule applies for dedicated CWB pingpongs. Track the CWB muxes in the global st

[PATCH v2 14/22] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-24 Thread Jessica Zhang
If the clone mode enabled status is changing, a modeset needs to happen so that the resources can be reassigned Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/driver

[PATCH v2 09/22] drm/msm/dpu: add devcoredumps for cwb registers

2024-09-24 Thread Jessica Zhang
From: Esha Bharadwaj Implement instance of snapshot function to dump new registers used for cwb Reviewed-by: Dmitry Baryshkov Signed-off-by: Esha Bharadwaj Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 + 1 file changed, 5 insertions(+) diff --git a/driver

[PATCH v2 18/22] drm/msm/dpu: Adjust writeback phys encoder setup for CWB

2024-09-24 Thread Jessica Zhang
Adjust QoS remapper, OT limit, and CDP parameters to account for concurrent writeback Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v2 10/22] drm/msm/dpu: Add dpu_hw_cwb abstraction for CWB block

2024-09-24 Thread Jessica Zhang
The CWB mux has its own registers and set of operations. Add dpu_hw_cwb abstraction to allow driver to configure the CWB mux. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/Makefile| 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cwb.c | 73 + drive

[PATCH v2 12/22] drm/msm/dpu: Add RM support for allocating CWB

2024-09-24 Thread Jessica Zhang
Add support for allocating the concurrent writeback mux as part of the WB allocation Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 17 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 ++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH v2 21/22] drm/msm/dpu: Reorder encoder kickoff for CWB

2024-09-24 Thread Jessica Zhang
Add a helper that will handle the correct order of the encoder kickoffs for concurrent writeback. For concurrent writeback, the realtime encoder must always kickoff last as it will call the trigger flush and start. This avoids the following scenario where the writeback encoder increments the pend

[PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-24 Thread Jessica Zhang
From: Dmitry Baryshkov All resource allocation is centered around the LMs. Then other blocks (except DSCs) are allocated basing on the LMs that was selected, and LM powers up the CRTC rather than the encoder. Moreover if at some point the driver supports encoder cloning, allocating resources fro

[PATCH v2 17/22] drm/msm/dpu: Support CWB in dpu_hw_ctl

2024-09-24 Thread Jessica Zhang
The CWB mux has a pending flush bit and *_active register. Add support for configuring them within the dpu_hw_ctl layer. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 13 ++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys

[PATCH v2 13/22] drm/msm/dpu: Add CWB to msm_display_topology

2024-09-24 Thread Jessica Zhang
Add the cwb_enabled flag to msm_display topology and adjust the toplogy to account for concurrent writeback Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 -- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 10 -- drivers/gpu/drm/msm/msm_drv.h|

Re: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings

2024-09-24 Thread Rob Herring
On Mon, Sep 23, 2024 at 03:57:44PM +0200, Lukasz Majewski wrote: > Up till now the fsl,lcdif.yaml was requiring the "port" property as a > must have to specify the display interface on iMX devices. > > However, it shall also be possible to specify the display only with > passing its timing paramet

Re: [PATCH] drm/vkms: Add missing check for CRTC initialization

2024-09-24 Thread Maíra Canal
Hi Louis, On 9/6/24 13:15, Louis Chauvet wrote: CRTC initialization call drm_mode_crtc_set_gamma_size without the proper checks, introduce this check to avoid issues. Signed-off-by: Louis Chauvet Applied to misc/kernel.git (drm-misc-next). Best Regards, - Maíra --- drivers/gpu/drm/vkms/

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-09-24 Thread Jessica Zhang
On 9/24/2024 4:41 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:32PM GMT, Jessica Zhang wrote: Cache the CWB block mask in the DPU virtual encoder and configure CWB according to the CWB block mask within the writeback phys encoder Signed-off-by: Jessica Zhang --- drivers/gpu/d

Re: [PATCH v2 14/22] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-24 Thread Abhinav Kumar
On 9/24/2024 4:25 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:30PM GMT, Jessica Zhang wrote: If the clone mode enabled status is changing, a modeset needs to happen so that the resources can be reassigned Sima's comment regarding crtc_state->mode_changed seems to be ignored...

NULL pointer dereference after ib test on ring 7 succeeded

2024-09-24 Thread Arthur Marsh
After rebuilding current Linus git head with: dma-mapping: report unlimited DMA addressing in IOMMU DMA path b348b6d17fd1d5d89b86db602f02bea54a754bd8 applied, the radeon module load gets further before hitting another NULL pointer dereference: [ 17.777472] [drm] radeon kernel modesetting enabl

Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-24 Thread Daniel Stone
Hi Jens, On Fri, 30 Aug 2024 at 08:04, Jens Wiklander wrote: > This patch set is based on top of Yong Wu's restricted heap patch set [1]. > It's also a continuation on Olivier's Add dma-buf secure-heap patch set [2]. > > The Linaro restricted heap uses genalloc in the kernel to manage the heap >

[Bug 204241] amdgpu fails to resume from suspend

2024-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH] MAINTAINERS: Add myself as VKMS Maintainer

2024-09-24 Thread Maíra Canal
Hi Louis, On 9/10/24 12:10, Louis Chauvet wrote: I've been actively working on VKMS to provide new features and participated in reviews and testing. To help Maìra with her work, add myself as co-maintainer of VKMS. Signed-off-by: Louis Chauvet I see that you're now a developer in the drm/mis

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-24 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

Re: [PATCH] MAINTAINERS: remove myself as a VKMS maintainer

2024-09-24 Thread Maíra Canal
Hi Siqueira, On 9/11/24 10:50, Rodrigo Siqueira wrote: I haven't been able to follow or review the work on the driver for a long time and I don't see the situation improving anytime soon. Hence, this commit removes me from the maintainers list. Signed-off-by: Rodrigo Siqueira Applied to misc

Re: [PATCH] drm/vkms: Suppress context imbalance sparse warning

2024-09-24 Thread Maíra Canal
Hi Louis, On 9/12/24 12:25, Louis Chauvet wrote: The functions `vkms_crtc_atomic_begin` and `vkms_crtc_atomic_flush` are responsible for locking and unlocking a mutex, respectively. Add the `__acquires` and `__releases` annotations to these functions to prevent the associated sparse warning abou

Re: [PATCH v2 08/22] drm/msm/dpu: Specify dedicated CWB pingpong blocks

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:24PM GMT, Jessica Zhang wrote: > Change pingpong index and names to distinguish between general use > pingpong blocks and pingpong blocks dedicated for concurrent writeback > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm865

Re: [PATCH v2 07/22] drm/msm/dpu: Add CWB entry to catalog for SM8650

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:23PM GMT, Jessica Zhang wrote: > From: Esha Bharadwaj > > Add a new block for concurrent writeback mux to the SM8650 HW catalog > > Signed-off-by: Esha Bharadwaj > Signed-off-by: Jessica Zhang > --- > .../gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h | 21 > ++

Re: [PATCH v2 11/22] drm/msm/dpu: add CWB support to dpu_hw_wb

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:27PM GMT, Jessica Zhang wrote: > From: Esha Bharadwaj > > Adjust the WB_MUX configuration to account for using dedicated CWB > pingpong blocks. > > Signed-off-by: Esha Bharadwaj > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 4

Re: [PATCH v2 12/22] drm/msm/dpu: Add RM support for allocating CWB

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:28PM GMT, Jessica Zhang wrote: > Add support for allocating the concurrent writeback mux as part of the > WB allocation > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 17 +++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h |

Re: [PATCH v2 13/22] drm/msm/dpu: Add CWB to msm_display_topology

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:29PM GMT, Jessica Zhang wrote: > Add the cwb_enabled flag to msm_display topology and adjust the toplogy > to account for concurrent writeback > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 -- > drivers/gpu/drm/msm/disp/d

Re: [PATCH] drm/v3d: Use v3d_perfmon_find(..)

2024-09-24 Thread Maíra Canal
Hi Christian, On 9/23/24 12:19, Christian Gmeiner wrote: From: Christian Gmeiner Replace the open coded v3d_perfmon_find(..) with the real thing. Signed-off-by: Christian Gmeiner Thanks for your patch! Reviewed-by: Maíra Canal Applied to misc/kernel.git (drm-misc-next). Best Regards, -

Re: [PATCH v2 06/22] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:22PM GMT, Jessica Zhang wrote: > From: Dmitry Baryshkov > > Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources > from dpu_crtc_assign_resources(). > > Signed-off-by: Dmitry Baryshkov > [quic_abhin...@quicinc.com: cleaned up formatting] > Signed-

Re: [PATCH v2 10/22] drm/msm/dpu: Add dpu_hw_cwb abstraction for CWB block

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:26PM GMT, Jessica Zhang wrote: > The CWB mux has its own registers and set of operations. Add dpu_hw_cwb > abstraction to allow driver to configure the CWB mux. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/Makefile| 1 + > drivers/gp

Re: [PATCH v2 14/22] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:30PM GMT, Jessica Zhang wrote: > If the clone mode enabled status is changing, a modeset needs to happen > so that the resources can be reassigned Sima's comment regarding crtc_state->mode_changed seems to be ignored... > > Signed-off-by: Jessica Zhang > --- > dri

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-24 Thread Dmitry Osipenko
On 9/23/24 21:18, Dmitry Osipenko wrote: > On 9/23/24 21:09, Dmitry Osipenko wrote: >>> Sure, I can do that if others prefer this way too. >> Note that in the other email I suggested to use strndup_user(), that >> will remove the name-length limitation, but then the name var will >> remain to be a

Re: [PATCH v2 15/22] drm/msm/dpu: Reserve resources for CWB

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:31PM GMT, Jessica Zhang wrote: > Add support for RM to reserve dedicated CWB pingpongs and CWB muxes > > For concurrent writeback, even-indexed CWB muxes must be assigned to > even-indexed LMs and odd-indexed CWB muxes for odd-indexed LMs. The same > even/odd rule app

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:32PM GMT, Jessica Zhang wrote: > Cache the CWB block mask in the DPU virtual encoder and configure CWB > according to the CWB block mask within the writeback phys encoder > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 8

Re: [PATCH v2 20/22] drm/msm/dpu: Skip trigger flush and start for CWB

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:36PM GMT, Jessica Zhang wrote: > For concurrent writeback, the real time encoder is responsible for > trigger flush and trigger start. Return early for trigger start and > trigger flush for the concurrent writeback encoders. > > Signed-off-by: Jessica Zhang > --- >

Re: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings

2024-09-24 Thread Marek Vasut
On 9/25/24 12:57 AM, Rob Herring wrote: On Mon, Sep 23, 2024 at 07:53:57PM +0200, Marek Vasut wrote: On 9/23/24 3:57 PM, Lukasz Majewski wrote: Up till now the fsl,lcdif.yaml was requiring the "port" property as a must have to specify the display interface on iMX devices. However, it shall als

Re: [PATCH v2 22/22] drm/msm/dpu: Set possible clones for all encoders

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:38PM GMT, Jessica Zhang wrote: > Set writeback encoders as possible clones for non-writeback encoders and > vice versa. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 > + > drivers/gpu/drm/msm/

Re: [PATCH v4] drm/vkms: Add documentation

2024-09-24 Thread Maíra Canal
Hi Louis, On 9/5/24 10:27, Louis Chauvet wrote: Add documentation around vkms_output and its initialization. Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Reviewed-by: José Expósito Signed-off-by: Louis Chauvet Applied to misc/ker

Re: [PATCH v2 06/22] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-09-24 Thread Jessica Zhang
On 9/24/2024 4:16 PM, Dmitry Baryshkov wrote: On Tue, Sep 24, 2024 at 03:59:22PM GMT, Jessica Zhang wrote: From: Dmitry Baryshkov Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources from dpu_crtc_assign_resources(). Signed-off-by: Dmitry Baryshkov [quic_abhin...@quicinc

Re: [PATCH v17 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-09-24 Thread Rob Herring (Arm)
On Tue, 24 Sep 2024 15:36:45 +0800, Sandor Yu wrote: > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge > driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ. > > The patch set compose of DRM bridge drivers and PHY driver. > > Both of them need by patch #1 and

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote: > On 9/24/24 04:54, Maxime Ripard wrote: > > +Guenter > > > > On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > > > On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > > > > The tests consistently trigger WARNs in

Re: [PATCH] firmware/sysfb: Disable sysfb for firmware buffers with unknown parent

2024-09-24 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > The sysfb framebuffer handling only operates on graphics devices > that provide the system's firmware framebuffer. If that device is > not known, assume that any graphics device has been initialized by > firmware. > > Fixes a problem on i915 where sysfb

Re: [PATCH 2/8] drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job

2024-09-24 Thread Tvrtko Ursulin
On 24/09/2024 15:20, Christian König wrote: Am 24.09.24 um 16:12 schrieb Tvrtko Ursulin: On 24/09/2024 14:55, Christian König wrote: I've pushed the first to drm-misc-next, but that one here fails to apply cleanly. This appears due 440d52b370b0 ("drm/sched: Fix dynamic job-flow control ra

Re: [PATCH v5 10/11] drm/msm/A6xx: Enable preemption for A750

2024-09-24 Thread Rob Clark
nit, lowercase "a6xx" in subject prefix (no need to resend just for this, I can fix it up when applying patches if needed.. but if you do resend pls fix that) BR -R On Tue, Sep 24, 2024 at 4:30 AM Antonino Maniscalco wrote: > > Initialize with 4 rings to enable preemption. > > For now only on A

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-24 Thread Alex Deucher
On Fri, Sep 20, 2024 at 11:36 AM Jocelyn Falempe wrote: > > On 17/09/2024 15:21, Alex Deucher wrote: > > On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: > >> > >> Add support for the drm_panic module, which displays a pretty user > >> friendly message on the screen when a Linux kernel panic occurs.

Re: [PATCH v7 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-09-24 Thread Maxime Ripard
Hi, On Sat, Sep 14, 2024 at 09:56:53PM GMT, Cristian Ciocaltea wrote: > The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1 > Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a > Samsung IP block. > > Add just the basic support for now, i.e. RGB output up

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-24 Thread Akhil P Oommen
On Tue, Sep 24, 2024 at 07:47:12AM -0700, Rob Clark wrote: > On Tue, Sep 24, 2024 at 4:54 AM Antonino Maniscalco > wrote: > > > > On 9/20/24 7:09 PM, Akhil P Oommen wrote: > > > On Wed, Sep 18, 2024 at 09:46:33AM +0200, Neil Armstrong wrote: > > >> Hi, > > >> > > >> On 17/09/2024 13:14, Antonino M

Re: [PATCH 2/6] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs

2024-09-24 Thread Conor Dooley
On Tue, Sep 24, 2024 at 06:31:52PM +0800, Macpaul Lin wrote: > The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due > to an excessively long 'interrupts' property. The error message was: > > infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0], >

Re: [PATCH 0/5] AMDGPU deadcode

2024-09-24 Thread Dr. David Alan Gilbert
* Alex Deucher (alexdeuc...@gmail.com) wrote: > On Sun, Sep 22, 2024 at 9:43 PM wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This is a bunch of deadcode removal in amdgpu; > > some of the functions are ones which were previously > > used but haven't been for a while, others are

Re: [PATCH] gpu: host1x: Request syncpoint IRQs only during probe

2024-09-24 Thread Jon Hunter
On 06/09/2024 09:38, Jon Hunter wrote: Hi Mikko, On 31/05/2024 08:07, Mikko Perttunen wrote: From: Mikko Perttunen Syncpoint IRQs are currently requested in a code path that runs during resume. Due to this, we get multiple overlapping registered interrupt handlers as host1x is suspended and

[PATCH v5 49/80] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of SHME

[PATCH v5 40/80] drm/sun4i: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The sun4i driver specifies as preferred color mode of 32. As this is the default if no format has been given, leave it out ent

[PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION v3: - add DRM_FBDEV_DMA_DRIVER_OPS macro Signed-off-by: Thomas Zimmermann

[PATCH v5 13/80] drm/hisilicon/kirin: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The kirin driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

[PATCH v5 41/80] drm/tidss: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The tidss driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out enti

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-24 Thread Simona Vetter
On Fri, Sep 06, 2024 at 06:41:18PM +, Zeng, Oak wrote: > There are fundamental design conflicts with what we have aligned, see inline. > > > -Original Message- > > From: Intel-xe On Behalf > > Of Matthew Brost > > Sent: Tuesday, August 27, 2024 10:49 PM > > To: intel...@lists.freedesk

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-24 Thread Simona Vetter
Apologies for the late reply ... On Wed, Sep 04, 2024 at 01:34:18PM +0200, Christian König wrote: > Hi Boris, > > Am 04.09.24 um 13:23 schrieb Boris Brezillon: > > > > > > Please read up here on why that stuff isn't allowed: > > > > > > https://www.kernel.org/doc/html/latest/driver-api/dma-buf.ht

Re: [PATCH v17 1/8] drm: bridge: Cadence: Create mhdp helper driver

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 10:41:26AM GMT, Alexander Stein wrote: > Hi Sandor, > > Am Dienstag, 24. September 2024, 09:36:46 CEST schrieb Sandor Yu: > > MHDP8546 mailbox access functions will be share to other mhdp driver > > and Cadence HDP-TX HDMI/DP PHY drivers. > > Create a new mhdp helper driver

Re: [PATCH v2 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 10:36, Liankun Yang ha scritto: When using type-c to type-c to connect to the monitor, the sound plays normally. If you unplug the type-c and connect the type-c to hdmi dongle to the monitor, there will be noise. By capturing the audio data, it is found that the data position is mess

Re: [PATCH v2] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-24 Thread Helge Deller
Hi Qianqiang, On 9/24/24 18:13, Qianqiang Liu wrote: syzbot has found a NULL pointer dereference bug in fbcon. This issue is caused by ops->putcs being a NULL pointer. We need to ensure it is initialized properly. Reported-by: syzbot+3d613ae53c0315026...@syzkaller.appspotmail.com Closes: https

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: > On Tue, 24 Sep 2024, Guenter Roeck wrote: > On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > > Yeah I think long-term we might want a kunit framework so that we can > > catch dmesg warnings we expect and test f

Re: [PATCH 5/5] drm/amdgpu: Remove unused amdgpu_i2c functions

2024-09-24 Thread Alex Deucher
Applied the series. Thanks! Alex On Sun, Sep 22, 2024 at 9:43 PM wrote: > > From: "Dr. David Alan Gilbert" > > amdgpu_i2c_add and amdgpu_i2c_init were added in 2015's commit > d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") > but never used. > > Remove them. > > Signed-off-by: Dr. David Alan

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Guenter Roeck
On 9/24/24 09:57, Maxime Ripard wrote: On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote: On Tue, 24 Sep 2024, Guenter Roeck wrote: On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: Yeah I think long-term we might want a kunit framework so that we can catch dmesg warnings w

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-24 Thread Raag Jadav
On Tue, Sep 24, 2024 at 01:23:13PM +0200, Simona Vetter wrote: > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in case

Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote: > On 9/23/24 1:33 AM, Dmitry Baryshkov wrote: > > Hi, > > > > On Fri, Aug 30, 2024 at 09:03:47AM GMT, Jens Wiklander wrote: > > > Hi, > > > > > > This patch set is based on top of Yong Wu's restricted heap patch set [1]. > > > It's also

Re: [PATCH v2 01/22] drm: add clone mode check for CRTC

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:17PM GMT, Jessica Zhang wrote: > Add helper to check if the given CRTC state is in clone mode > > Signed-off-by: Jessica Zhang > --- > include/drm/drm_crtc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_cr

Re: [PATCH v2 05/22] drm/msm/dpu: move resource allocation to CRTC

2024-09-24 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 03:59:21PM GMT, Jessica Zhang wrote: > From: Dmitry Baryshkov > > All resource allocation is centered around the LMs. Then other blocks > (except DSCs) are allocated basing on the LMs that was selected, and LM > powers up the CRTC rather than the encoder. > > Moreover if

Re: [PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-24 Thread zhaoxiong lv
On Wed, Sep 25, 2024 at 12:11 AM Jessica Zhang wrote: > > > > On 9/23/2024 7:13 PM, zhaoxiong lv wrote: > > On Tue, Sep 24, 2024 at 5:14 AM Jessica Zhang > > wrote: > >> > >> > >> > >> On 9/23/2024 6:42 AM, Zhaoxiong Lv wrote: > >>> In MTK chips, if the system starts suspending before the DRM ru

Re: [PATCH 6/6] dt-bindings: display: mediatek: dpi: Add mt8195 support in power domains

2024-09-24 Thread Macpaul Lin
On 9/24/24 19:48, AngeloGioacchino Del Regno wrote: Il 24/09/24 12:31, Macpaul Lin ha scritto: Add power domain binding to the mediatek DPI controller for MT8185. The dpi node in mt8195.dtsi was triggering a dtbs_check error: dp-intf@1c113000: power-domains: False schema does not allow [

Re: [PATCH 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-24 Thread Pin-yen Lin
Hi, On Wed, Sep 25, 2024 at 12:43 AM Doug Anderson wrote: > > Hi, > > On Mon, Sep 23, 2024 at 8:53 PM Pin-yen Lin wrote: > > > > The bridge might miss the display change events when it's powered off. > > This happens when a user changes the external monitor when the system > > is suspended and t

Re: [PATCH 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-24 Thread Pin-yen Lin
Hi, On Wed, Sep 25, 2024 at 1:48 AM Doug Anderson wrote: > > Hi, > > On Mon, Sep 23, 2024 at 8:53 PM Pin-yen Lin wrote: > > > > The bridge might miss the display change events when it's powered off. > > This happens when a user changes the external monitor when the system > > is suspended and th

Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 12:31, Macpaul Lin ha scritto: The display node in mt8195.dtsi was triggering a CHECK_DTBS error due to an excessively long 'clocks' property: display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long To resolve this issue, add "maxItems: 3" to the 'clocks' property in

Re: [PATCH 1/1] mm/migrate: Trylock device page in do_swap_page

2024-09-24 Thread Simona Vetter
On Fri, Sep 20, 2024 at 09:59:51PM +, Matthew Brost wrote: > On Fri, Sep 20, 2024 at 05:50:10PM -0400, Felix Kuehling wrote: > > > > On 2024-09-20 17:23, Matthew Brost wrote: > > > On Fri, Sep 20, 2024 at 04:26:50PM -0400, Felix Kuehling wrote: > > > > On 2024-09-18 11:10, Alistair Popple wrot

Re: [PATCH 6/6] dt-bindings: display: mediatek: dpi: Add mt8195 support in power domains

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 12:31, Macpaul Lin ha scritto: Add power domain binding to the mediatek DPI controller for MT8185. The dpi node in mt8195.dtsi was triggering a dtbs_check error: dp-intf@1c113000: power-domains: False schema does not allow [[44, 18]] Fixes: 5474d49b2f79 ("dt-bindings: display: me

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-24 Thread Maxime Ripard
+Guenter On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote: > On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > > The tests consistently trigger WARNs in drm_framebuffer code. I'm not > > sure what the point is with type of belts and suspenders tests. The > > warnings *are*

Re: [PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-24 Thread Jani Nikula
On Tue, 24 Sep 2024, George Rurikov wrote: > If the video card driver could not find the connector assigned to the > current video controller, or if the hardware status has changed so that > a pre-existing connector is no longer active, none of the state > connectors will meet the assignment crite

Re: [PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-24 Thread Jani Nikula
On Tue, 24 Sep 2024, Jani Nikula wrote: > On Tue, 24 Sep 2024, George Rurikov wrote: >> If the video card driver could not find the connector assigned to the >> current video controller, or if the hardware status has changed so that >> a pre-existing connector is no longer active, none of the sta

Re: [PATCH 4/5] drm/msm/dpu: Add SA8775P support

2024-09-24 Thread Mahadevan P
On 9/24/2024 4:42 PM, Mahadevan P wrote: On 9/12/2024 1:34 PM, Dmitry Baryshkov wrote: On Thu, Sep 12, 2024 at 12:44:36PM GMT, Mahadevan wrote: Add definitions for the display hardware used on the Qualcomm SA8775P platform. Signed-off-by: Mahadevan ---   .../msm/disp/dpu1/catalog/dpu_8_4_s

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-24 Thread Antonino Maniscalco
On 9/20/24 7:09 PM, Akhil P Oommen wrote: On Wed, Sep 18, 2024 at 09:46:33AM +0200, Neil Armstrong wrote: Hi, On 17/09/2024 13:14, Antonino Maniscalco wrote: This series implements preemption for A7XX targets, which allows the GPU to switch to an higher priority ring when work is pushed to it,

Re: [PATCH 1/6] arm64: dts: mt8195: Fix dtbs_check error for infracfg_ao node

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 12:31, Macpaul Lin ha scritto: The infracfg_ao node in mt8195.dtsi was causing a dtbs_check error. The error message was: syscon@10001000: compatible: ['mediatek,mt8195-infracfg_ao', 'syscon', 'simple-mfd'] is too long To resolve this, remove 'simple-mfd' from the

Re: [PATCH 5/6] arm64: dts: mt8195: Fix dtbs_check error for mutex node

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 12:31, Macpaul Lin ha scritto: The mutex node in mt8195.dtsi was triggering a dtbs_check error: mutex@1c101000: 'clock-names', 'reg-names' do not match any of the regexes: 'pinctrl-[0-9]+' This seems no need by inspecting the DT schemas and other reference board

Re: [PATCH 4/6] arm64: dts: mediatek: mt8395-genio-1200-evk: Fix dtbs_check error for phy

2024-09-24 Thread AngeloGioacchino Del Regno
Il 24/09/24 12:31, Macpaul Lin ha scritto: The ethernet-phy node in mt8395-genio-1200-evk.dts was triggering a dtbs_check error. The error message was: eth-phy0@1: $nodename:0: 'eth-phy0@1' does not match '^ethernet-phy(@[a-f0-9]+)?$' Fix this issue by replacing 'eth-phy' node t

Re: radeon ARUBA NULL pointer dereference

2024-09-24 Thread Thomas Zimmermann
(cc: DMA and x86 folks) Hi Am 24.09.24 um 04:08 schrieb Arthur Marsh: Using current Linus git head kernel, I was able to save the dmesg output: [ 17.218724] [drm] radeon kernel modesetting enabled. [ 17.218778] radeon :00:01.0: vgaarb: deactivate vga console [ 17.219509] Console: swi

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-24 Thread Marek Vasut
On 9/4/24 11:05 AM, Philipp Zabel wrote: On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 subsampling, turn it into boolean to select exactly that and update related code accordingly. Signed-off-by: Marek Vasut I'd prefer

[PATCH v5 78/80] drm/tegra: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH v5 18/80] drm/ili9486: Run DRM default client setup

2024-09-24 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani Acked-by: Javier Martinez Canilla

Re: [PATCH v1] docs/gpu: ci: update flake tests requirements

2024-09-24 Thread Vignesh Raman
Hi Dmitry, On 24/09/24 11:46, Dmitry Baryshkov wrote: On Tue, 24 Sept 2024 at 04:26, Vignesh Raman wrote: Update the documentation to require linking to a relevant GitLab issue for each new flake entry instead of an email report. Added specific GitLab issue URLs for i915, xe and other drivers

  1   2   3   4   >