Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

Hi, I probably went a bit fast on the commit message. It seems to me that the Fixes line would be probably better with below one instead. Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") The same fix is actually necessary for all planes (cursor / gdp / hqvdp), which is rel

Re: [RESEND PATCH v4] devres: Refactor using guards

Hello Greg, On Tue, Sep 10, 2024 at 03:15:21PM +0200, Andrea Calabrese wrote: Code refactoring using the recent guard and scoped_guard macros for automatic cleanup of the spinlocks. This does not change the effective behaviour of the kernel, but guarantees a cleaned-up exit from each lock, auto

[PULL] drm-intel-fixes

Hi Dave, Sima, It is late in the cycle and luckily the fix in this weeks PR is just something to satisfy static analyzers, nothing that can happen in reality, so pulling it is even optional. Regards, Tvrtko drm-intel-fixes-2024-09-12: - Prevent a possible int overflow in wq offsets [guc] (Nik

[PATCH v2] drm/msm: Fix some typos in comment

Fixed some spelling errors, the details are as follows: -in the code comments: collpase->collapse firwmare->firmware everwhere->everywhere Fixes: 2401a0084614 ("drm/msm: gpu: Add support for the GPMU") Fixes: 5a903a44a984 ("drm/msm/a6xx: Introduce GMU wrapper support") Fix

[PATCH v1] drm/msm/dpu: Fix some typos in comment

Fixed some spelling errors, the details are as follows: -in the code comments: collpase->collapse firwmare->firmware everwhere->everywhere Signed-off-by: Shen Lichuan --- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- driv

Re: [PATCH v3 06/10] drm/msm/A6xx: Use posamble to reset counters on preemption

On Wed, Sep 11, 2024 at 12:35:08AM +0200, Antonino Maniscalco wrote: > On 9/10/24 11:34 PM, Akhil P Oommen wrote: > > On Mon, Sep 09, 2024 at 05:07:42PM +0200, Antonino Maniscalco wrote: > > > On 9/6/24 10:08 PM, Akhil P Oommen wrote: > > > > On Thu, Sep 05, 2024 at 04:51:24PM +0200, Antonino Manis

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 11.09.24 um 20:06 schrieb Tejas Vipin: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since monitor HDMI information is available after EDID is parsed. Additionally rewrite the code the code to have fewer indentation levels. The problem is that the entire logic is outdat

Re: [PATCH v2] drm/panthor: Display FW version information

On Fri, 6 Sep 2024 10:40:25 +0100 Steven Price wrote: > The version number output when loading the firmware is actually the > interface version not the version of the firmware itself. Update the > message to make this clearer. > > However, the firmware binary has a git SHA embedded into it whic

Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

On Thu, Sep 12, 2024 at 12:44:33PM GMT, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan I don't think this was tested before submission. I observe obvious issues which should have been reported while testing dt bindings. I will n

Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

On Thu, Sep 12, 2024 at 12:44:34PM GMT, Mahadevan wrote: > Document the DPU for Qualcomm SA8775P platform. Please fix errors reported by DT tools before submission. > > Signed-off-by: Mahadevan > --- > .../display/msm/qcom,sa8775p-dpu.yaml | 120 ++ > 1 file changed, 12

Re: [PATCH 0/5] Add display support for Qualcomm SA8775P platform

On Thu, Sep 12, 2024 at 12:44:32PM GMT, Mahadevan wrote: > Add support for mdss and dpu driver on Qualcomm SA8775P platform. You can not support a driver. Also, MDSS, DPU. > > --- > This series depends on following series: > https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0...@qu

[PATCH v1] drm/amd/display: fix typo in the comment

Correctly spelled comments make it easier for the reader to understand the code. Replace 'maxium' with 'maximum' in the comment & replace 'diffculty' with 'difficulty' in the comment & replace 'suppluy' with 'supply' in the comment & replace 'Congiuration' with 'Configuration' in the comment & rep

[PATCH 0/5] Add display support for Qualcomm SA8775P platform

Add support for mdss and dpu driver on Qualcomm SA8775P platform. --- This series depends on following series: https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0...@quicinc.com/ --- Mahadevan (5): dt-bindings: display/msm: Document MDSS on SA8775P dt-bindings: display/msm: Docu

[PATCH 3/5] drm/msm: mdss: Add SA8775P support

Add support for MDSS on SA8775P. Signed-off-by: Mahadevan --- drivers/gpu/drm/msm/msm_mdss.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index faa88fd6eb4d..272207573dbb 100644 --- a/drivers/gpu/drm/msm/msm_mdss.

[PATCH 4/5] drm/msm/dpu: Add SA8775P support

Add definitions for the display hardware used on the Qualcomm SA8775P platform. Signed-off-by: Mahadevan --- .../msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 485 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 3 +- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 3 +- dri

[PATCH 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

Document the MDSS hardware found on the Qualcomm SA8775P platform. Signed-off-by: Mahadevan --- .../display/msm/qcom,sa8775p-mdss.yaml| 225 ++ 1 file changed, 225 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml dif

[PATCH 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

Document the DPU for Qualcomm SA8775P platform. Signed-off-by: Mahadevan --- .../display/msm/qcom,sa8775p-dpu.yaml | 120 ++ 1 file changed, 120 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-dpu.yaml diff --git a/Documenta

[PATCH 5/5] arm64: dts: qcom: sa8775p: add display dt nodes

Add mdss and mdp DT nodes for SA8775P. Signed-off-by: Mahadevan --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 85 +++ 1 file changed, 85 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 67ba124d20f8..d5d8e02fdb

Re: [PATCH 3/5] drm/msm: mdss: Add SA8775P support

On Thu, Sep 12, 2024 at 12:44:35PM GMT, Mahadevan wrote: > Add support for MDSS on SA8775P. Patch subject doesn't follow existing practice. > > Signed-off-by: Mahadevan > --- > drivers/gpu/drm/msm/msm_mdss.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/

Re: [PATCH 5/5] arm64: dts: qcom: sa8775p: add display dt nodes

On Thu, Sep 12, 2024 at 12:44:37PM GMT, Mahadevan wrote: > Add mdss and mdp DT nodes for SA8775P. > > Signed-off-by: Mahadevan > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 85 +++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dts

Re: [PATCH 4/5] drm/msm/dpu: Add SA8775P support

On Thu, Sep 12, 2024 at 12:44:36PM GMT, Mahadevan wrote: > Add definitions for the display hardware used on the > Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > .../msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 485 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

Re: [PATCH 0/5] Add display support for Qualcomm SA8775P platform

On Thu, Sep 12, 2024 at 12:44:32PM GMT, Mahadevan wrote: > Add support for mdss and dpu driver on Qualcomm SA8775P platform. > > --- > This series depends on following series: > https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0...@quicinc.com/ As such, it probably can not be merge

Re: [PATCH 1/3] drm: add DRM_SET_NAME ioctl

On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clien

[PATCH v2 2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jinjie Ru

[PATCH v2 4/5] drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9e532b3ad9a7 ("drm/tegra: dpaux: Disable interrupt when detached") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/tegr

[PATCH v2 1/5] drm/imx: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Jinjie Ruan --- v2: - Update the commit

[PATCH v2 5/5] drm/msm/adreno: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support") Reviewed-by: Dmitry Baryshkov Signed-off-by: Jinjie Ruan --- v2: - A

[PATCH v2 0/5] drm: Use IRQF_NO_AUTOEN flag in request_irq()

As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") said, reqeust_irq() and then disable_irq() is unsafe. In the small time gap between request_irq() and disable_irq(), interrupts can still come. IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents the a

[PATCH v2 3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only after adding the crtc") Reviewed-by: Dmitry Baryshkov Signed-off-by:

Re: [PATCH 3/3] drm/amdgpu: use drm_file name

On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote: In debugfs gem_info/vm_info files, timeout handler and page fault reports. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu

Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

On Thu, 12 Sep 2024 12:44:33 +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > .../display/msm/qcom,sa8775p-mdss.yaml| 225 ++ > 1 file changed, 225 insertions(+) > create mode 100644 > Do

Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

On Thu, 12 Sep 2024 12:44:34 +0530, Mahadevan wrote: > Document the DPU for Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > .../display/msm/qcom,sa8775p-dpu.yaml | 120 ++ > 1 file changed, 120 insertions(+) > create mode 100644 > Documentation/devicet

[PATCH] drm/mediatek: Fix potential NULL dereference in mtk_crtc_destroy()

In mtk_crtc_create(), if the call to mbox_request_channel() fails then we set the "mtk_crtc->cmdq_client.chan" pointer to NULL. In that situation, we do not call cmdq_pkt_create(). During the cleanup, we need to check if the "mtk_crtc->cmdq_client.chan" is NULL first before calling cmdq_pkt_destr

[PATCH] drm/doc: Update drm_bridge_connector path

Commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER module") recently moved the drm_bridge_connector file, but didn't update the doc resulting in a doc build warning. Update it for the new location. Fixes: 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER module")

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Hi > > Am 11.09.24 um 20:06 schrieb Tejas Vipin: >> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since >> monitor HDMI information is available after EDID is parsed. Additionally >> rewrite the code the code to have fewer indentati

[PULL] drm-misc-fixes

Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-09-12: An off-by-one fix for the CMA DMA-buf heap, An init fix for nouveau, a config dependency fix for stm, a syncobj leak fix, and two iommu fixes for tegra and rockchip. The following changes since commit 5a498d4d06d6d9bad76d8a

Re: linux-next: build warning after merge of the drm-misc-fixes tree

Hi, On Wed, Sep 11, 2024 at 06:07:41PM GMT, Stephen Rothwell wrote: > Hi all, > > On Wed, 4 Sep 2024 16:30:18 +1000 Stephen Rothwell > wrote: > > > > After merging the drm-misc-fixes tree, today's linux-next build (htmldocs) > > produced this warning: > > > > Error: Cannot open file drivers/gp

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Jani Nikula wrote: > On Thu, 12 Sep 2024, Thomas Zimmermann wrote: >> Hi >> >> Am 11.09.24 um 20:06 schrieb Tejas Vipin: >>> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since >>> monitor HDMI information is available after EDID is parsed. Additionally >>>

[PULL] drm-intel-next-fixes

Hi Dave & Sima, Just two fixes this week in drm-intel-next-fixes towards v6.12-rc1. CI baseline is bit upset afted drm-next, but not getting worse with the two patches at least. Regards, Joonas *** drm-intel-next-fixes-2024-09-12: - Add missing I915_FORMAT_MOD_4_TILED_BMG_CCS modifier for BMG

Re: [PATCH] drm/mediatek: Fix potential NULL dereference in mtk_crtc_destroy()

Il 12/09/24 10:44, Dan Carpenter ha scritto: In mtk_crtc_create(), if the call to mbox_request_channel() fails then we set the "mtk_crtc->cmdq_client.chan" pointer to NULL. In that situation, we do not call cmdq_pkt_create(). During the cleanup, we need to check if the "mtk_crtc->cmdq_client.ch

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 12.09.24 um 10:48 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Hi Am 11.09.24 um 20:06 schrieb Tejas Vipin: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since monitor HDMI information is available after EDID is parsed. Additionally rewrite the c

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 12.09.24 um 10:56 schrieb Jani Nikula: On Thu, 12 Sep 2024, Jani Nikula wrote: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Hi Am 11.09.24 um 20:06 schrieb Tejas Vipin: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since monitor HDMI information is available after

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Hi > > Am 12.09.24 um 10:48 schrieb Jani Nikula: >> On Thu, 12 Sep 2024, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 11.09.24 um 20:06 schrieb Tejas Vipin: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since monitor HDMI i

[PATCH] drm/qxl: Add drm_panic support

QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- Sorry for sending similar mails again and again. Please ignore the following my mails. Let me add dri-devel mailing list and Jocelyn who developped a drm_panic

Re: [PATCH 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

On 9/11/2024 4:04 PM, Dmitry Baryshkov wrote: On Wed, 11 Sept 2024 at 13:08, Soutrik Mukhopadhyay wrote: In order to support different HW versions, introduce aux_cfg array to move v4 specific aux configuration settings. Signed-off-by: Soutrik Mukhopadhyay --- drivers/phy/qualcomm/phy-qcom

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Am 12.09.24 um 10:56 schrieb Jani Nikula: >> Moreover, in this case .detect() only detects digital displays as >> reported by EDID. If you postpone that to .get_modes(), the probe helper >> will still report connected, and invent non-EDID fallback mo

Re: [PATCH 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

On 9/12/2024 7:15 AM, Bjorn Andersson wrote: On Wed, Sep 11, 2024 at 03:38:10PM +0530, Soutrik Mukhopadhyay wrote: In order to support different HW versions, introduce aux_cfg array to move v4 specific aux configuration settings. Signed-off-by: Soutrik Mukhopadhyay --- drivers/phy/qualcomm

Re: [PATCH 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

On 9/11/2024 4:10 PM, Dmitry Baryshkov wrote: On Wed, 11 Sept 2024 at 13:08, Soutrik Mukhopadhyay wrote: Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. Signed-off-by: Soutrik Mukhopadhyay --- drivers/phy/qualcomm/phy-qcom-edp.c | 47 + 1 fil

Re: [PATCH] drm/doc: Update drm_bridge_connector path

On Thu, Sep 12, 2024 at 10:45:40AM GMT, Maxime Ripard wrote: > Commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > module") recently moved the drm_bridge_connector file, but didn't update > the doc resulting in a doc build warning. Update it for the new location. > > Fixes: 9d

Re: [PATCH 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

On 9/11/2024 4:10 PM, Dmitry Baryshkov wrote: On Wed, 11 Sept 2024 at 13:08, Soutrik Mukhopadhyay wrote: Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. Signed-off-by: Soutrik Mukhopadhyay --- drivers/phy/qualcomm/phy-qcom-edp.c | 47 + 1 fi

Re: [PATCH] drm/doc: Update drm_bridge_connector path

On Thu, Sep 12, 2024 at 12:46:50PM GMT, Dmitry Baryshkov wrote: > On Thu, Sep 12, 2024 at 10:45:40AM GMT, Maxime Ripard wrote: > > Commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > > module") recently moved the drm_bridge_connector file, but didn't update > > the doc resultin

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

On 9/12/2024 1:32 AM, Bjorn Andersson wrote: On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: The Qualcomm SA8775P platform comes with a DisplayPort controller with a different base offset than the previous SoCs, add support for this in the DisplayPort driver. Signed-off-

Re: ✗ Fi.CI.IGT: failure for drm/dp_mst: Fix DSC decompression detection in Synaptics branch devices

On Tue, Sep 10, 2024 at 11:07:53PM +, Patchwork wrote: > == Series Details == > > Series: drm/dp_mst: Fix DSC decompression detection in Synaptics branch > devices > URL : https://patchwork.freedesktop.org/series/138419/ > State : failure Patch is pushed to drm-misc-fixes, thanks for the r

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 12.09.24 um 11:38 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Am 12.09.24 um 10:56 schrieb Jani Nikula: Moreover, in this case .detect() only detects digital displays as reported by EDID. If you postpone that to .get_modes(), the probe helper will still report con

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On 11/09/2024 12:23, Jani Nikula wrote: > On Tue, 10 Sep 2024, Marc Gonzalez wrote: >> On 10/09/2024 16:51, Dmitry Baryshkov wrote: >>> On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote: >>> Building with clang and and W=1 leads to warning about unused pll_cmp_to_fdata(). Fix by

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

On 11/09/2024 16:39, Ilia Mirkin wrote: On Wed, Sep 11, 2024 at 10:19 AM Jocelyn Falempe > wrote: On 06/09/2024 21:36, James Jones wrote: > Right, there are 3 iterations of block linear tiling actually. NV50 does > support scanout of block linear sur

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 12.09.24 um 11:30 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Hi Am 12.09.24 um 10:48 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Hi Am 11.09.24 um 20:06 schrieb Tejas Vipin: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hd

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On Thu, 12 Sep 2024, Marc Gonzalez wrote: > On 11/09/2024 12:23, Jani Nikula wrote: >> On Tue, 10 Sep 2024, Marc Gonzalez wrote: >>> On 10/09/2024 16:51, Dmitry Baryshkov wrote: On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote: > See also commit 6863f5643dd7 ("kbuild: allow Clan

Re: [PATCH v3 06/10] drm/msm/A6xx: Use posamble to reset counters on preemption

On 9/12/24 9:12 AM, Akhil P Oommen wrote: On Wed, Sep 11, 2024 at 12:35:08AM +0200, Antonino Maniscalco wrote: On 9/10/24 11:34 PM, Akhil P Oommen wrote: On Mon, Sep 09, 2024 at 05:07:42PM +0200, Antonino Maniscalco wrote: On 9/6/24 10:08 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:5

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Hi > > Am 12.09.24 um 11:38 schrieb Jani Nikula: >> On Thu, 12 Sep 2024, Thomas Zimmermann wrote: >>> Am 12.09.24 um 10:56 schrieb Jani Nikula: Moreover, in this case .detect() only detects digital displays as reported by EDID. If you post

Re: [NOT A REGRESSION] firmware: framebuffer-coreboot: duplicate device name "simple-framebuffer.0"

Brian Norris writes: Hello Brian, > (Tweaking subject; this indeed isn't related to the regression at all) > > Hi, > > On Mon, Sep 09, 2024 at 10:02:00AM +0200, Borislav Petkov wrote: >> Looking at your log, the first warn is in framebuffer_coreboot. Some mess in >> the sysfs platform devices re

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On 12/09/2024 13:15, Jani Nikula wrote: > On Thu, 12 Sep 2024, Marc Gonzalez wrote: >> On 11/09/2024 12:23, Jani Nikula wrote: >>> On Tue, 10 Sep 2024, Marc Gonzalez wrote: On 10/09/2024 16:51, Dmitry Baryshkov wrote: > On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote: >> See

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On Thu, Sep 12, 2024 at 02:14:10PM GMT, Marc Gonzalez wrote: > On 12/09/2024 13:15, Jani Nikula wrote: > > On Thu, 12 Sep 2024, Marc Gonzalez wrote: > >> On 11/09/2024 12:23, Jani Nikula wrote: > >>> On Tue, 10 Sep 2024, Marc Gonzalez wrote: > On 10/09/2024 16:51, Dmitry Baryshkov wrote: > >>>

Re: [EXT] Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

On Fri, Sep 06, 2024 at 02:50:08AM GMT, Sandor Yu wrote: > > On Tue, Sep 03, 2024 at 06:07:25AM GMT, Sandor Yu wrote: > > > > -Original Message- > > > > From: dri-devel On Behalf > > > > Of Maxime Ripard > > > > Sent: 2024年7月2日 21:25 > > > > To: Sandor Yu > > > > Cc: dmitry.barysh...@lina

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On 12/09/2024 14:28, Dmitry Baryshkov wrote: > On Thu, Sep 12, 2024 at 02:14:10PM GMT, Marc Gonzalez wrote: >> On 12/09/2024 13:15, Jani Nikula wrote: >>> On Thu, 12 Sep 2024, Marc Gonzalez wrote: On 11/09/2024 12:23, Jani Nikula wrote: > On Tue, 10 Sep 2024, Marc Gonzalez wrote: >> On

[PATCH] drm/tidss: Fix typos

Fix typos in comments. Reported-by: Matthew Wilcox Signed-off-by: Andrew Kreimer --- drivers/gpu/drm/tidss/tidss_dispc_regs.h | 2 +- drivers/gpu/drm/tidss/tidss_plane.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_dispc_regs.h b/drive

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On Thu, Sep 12, 2024 at 02:50:04PM GMT, Marc Gonzalez wrote: > On 12/09/2024 14:28, Dmitry Baryshkov wrote: > > On Thu, Sep 12, 2024 at 02:14:10PM GMT, Marc Gonzalez wrote: > >> On 12/09/2024 13:15, Jani Nikula wrote: > >>> On Thu, 12 Sep 2024, Marc Gonzalez wrote: > On 11/09/2024 12:23, Jani

Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused

On Thu, 12 Sep 2024, Dmitry Baryshkov wrote: > On Thu, Sep 12, 2024 at 02:50:04PM GMT, Marc Gonzalez wrote: >> On 12/09/2024 14:28, Dmitry Baryshkov wrote: >> > On Thu, Sep 12, 2024 at 02:14:10PM GMT, Marc Gonzalez wrote: >> >> On 12/09/2024 13:15, Jani Nikula wrote: >> >>> On Thu, 12 Sep 2024, Ma

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Hi Am 12.09.24 um 13:25 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Hi Am 12.09.24 um 11:38 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: Am 12.09.24 um 10:56 schrieb Jani Nikula: Moreover, in this case .detect() only detects digital displays as

[PATCH v3 1/4] drm/vkms: Switch to managed for connector

The current VKMS driver uses non-managed function to create connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_output.c | 13 - 1 file

[PATCH v3 0/4] drm/vkms: Switch all vkms object to DRM managed objects

To simplify the memory managment this series replace all manual drm object managment by drm-managed one. This way the VKMS code don't have to manage it directly and the DRM core will handle the object destruction. No functional changes are intended in this series. This series depends on [1] (fo

[PATCH v3 2/4] drm/vkms: Switch to managed for encoder

The current VKMS driver uses non-managed function to create encoders. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_output.c | 14 -- 1 file

[PATCH v3 4/4] drm/vkms: Switch to managed for writeback connector

The current VKMS driver uses non-managed function to create writeback connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_writeback.c | 13 ++--

[PATCH v3 3/4] drm/vkms: Switch to managed for crtc

The current VKMS driver uses managed function to create crtc, but don't use it to properly clean the crtc workqueue. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Hi > > Am 12.09.24 um 13:25 schrieb Jani Nikula: >> On Thu, 12 Sep 2024, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 12.09.24 um 11:38 schrieb Jani Nikula: On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Am 12.09.24 um 10:56 schrieb Jani Ni

[PATCH][next] accel/habanalabs/gaudi2: Make read-only array edma_queues_id static const

Don't populate the read-only array edma_queues_id on the stack at run time, instead make it static const. Signed-off-by: Colin Ian King --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/accel/habanalabs/gaudi2/gaud

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On Thu, Sep 12, 2024 at 01:08:06PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.09.24 um 11:30 schrieb Jani Nikula: > > On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 12.09.24 um 10:48 schrieb Jani Nikula: > >>> On Thu, 12 Sep 2024, Thomas Zimmermann wrote: > Hi >

Re: [PATCH 01/10] drm/ast: astdp: Inline ast_astdp_connector_init()

On 11/09/2024 13:51, Thomas Zimmermann wrote: Inline ast_astdp_connector_init() into its only caller. The helper currently only does half of the connector-init work and is trivial enough to be inlined. Also set the local variables for encoder and connector as late as possible, so that the compil

Re: [PATCH 02/10] drm/ast: astdp: Avoid upcasting to struct ast_device

On 11/09/2024 13:51, Thomas Zimmermann wrote: Several functions receive an instance of struct drm_device only to upcast it to struct ast_device. Improve type safety by passing the AST device directly. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmerman

Re: [PATCH 03/10] drm/ast: astdp: Replace power_on helpers

On 11/09/2024 13:51, Thomas Zimmermann wrote: Replace the helper for controlling power on the physical connector, ast_dp_power_on_off(), with ast_dp_set_phy_sleep(). The new name reflects the effect of the operation. Simplify the implementation. The call now controls sleeping, hence semantics are

Re: [PATCH 04/10] drm/ast: astdp: Replace ast_dp_set_on_off()

On 11/09/2024 13:51, Thomas Zimmermann wrote: Replace ast_dp_set_on_off() with ast_dp_set_enable(). The helper's new name reflects the performed operation. If enabling fails, the new helper prints a warning. The code that waits for the programmed effect to take place is now located in __ast_dp_wa

Re: [PATCH 05/10] drm/ast: dp501: Inline ast_dp501_connector_init()

On 11/09/2024 13:51, Thomas Zimmermann wrote: Inline ast_dp501_connector_init() into its only caller. The helper currently only does half of the connector-init work and is trivial enough to be inlined. Also set the local variables for encoder and connector as late as possible, so that the compil

Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

Hi, Christian, On Wed, 2024-09-04 at 12:47 +0200, Christian König wrote: > Am 04.09.24 um 10:54 schrieb Thomas Hellström: > > On Wed, 2024-09-04 at 10:50 +0200, Christian König wrote: > > > Am 04.09.24 um 09:08 schrieb Thomas Hellström: > > > > Resources of swapped objects remains on the TTM_PL_SY

Re: [PATCH 06/10] drm/ast: dp501: Avoid upcasting to struct ast_device

On 11/09/2024 13:51, Thomas Zimmermann wrote: Several functions receive an instance of struct drm_device only to upcast it to struct ast_device. Improve type safety by passing the AST device directly. Thanks, it looks good to me. One small comment below Reviewed-by: Jocelyn Falempe Signed-o

Re: [PATCH 07/10] drm/ast: sil164: Inline ast_sil164_connector_init()

On 11/09/2024 13:51, Thomas Zimmermann wrote: Inline ast_sil164_connector_init() into its only caller. The helper currently only does half of the connector-init work and is trivial enough to be inlined. While at it, remove the error message from the call to ast_ddc_create(). The function already

Re: [PATCH 08/10] drm/ast: vga: Inline ast_vga_connector_init()

On 11/09/2024 13:51, Thomas Zimmermann wrote: Inline ast_vga_connector_init() into its only caller. The helper currently only does half of the connector-init work and is trivial enough to be inlined. While at it, remove the error message from the call to ast_ddc_create(). The function already war

Re: [PATCH 09/10] drm/ast: Respect return value from CRTC init

On 11/09/2024 13:51, Thomas Zimmermann wrote: Return an error if CRTC initialization fails. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3 00/10] Preemption support for A7XX

On 9/6/24 9:58 PM, Akhil P Oommen wrote: On Thu, Sep 05, 2024 at 04:51:18PM +0200, Antonino Maniscalco wrote: This series implements preemption for A7XX targets, which allows the GPU to switch to an higher priority ring when work is pushed to it, reducing latency for high priority submissions.

Re: [PATCH 10/10] drm/ast: Avoid upcasting to struct ast_device

On 11/09/2024 13:51, Thomas Zimmermann wrote: Several functions receive an instance of struct drm_device only to upcast it to struct ast_device. Improve type safety by passing the AST device directly. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann

Re: [PATCH] drm/doc: Update drm_bridge_connector path

On Thu, Sep 12, 2024 at 11:59:57AM GMT, Maxime Ripard wrote: > On Thu, Sep 12, 2024 at 12:46:50PM GMT, Dmitry Baryshkov wrote: > > On Thu, Sep 12, 2024 at 10:45:40AM GMT, Maxime Ripard wrote: > > > Commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > > > module") recently moved

Re: linux-next: build warning after merge of the drm-misc-fixes tree

On Wed, Sep 11, 2024 at 06:07:41PM GMT, Stephen Rothwell wrote: > Hi all, > > On Wed, 4 Sep 2024 16:30:18 +1000 Stephen Rothwell > wrote: > > > > After merging the drm-misc-fixes tree, today's linux-next build (htmldocs) > > produced this warning: > > > > Error: Cannot open file drivers/gpu/drm

Re: [PATCH v3 2/4] drm/log: Introduce a new boot logger to draw the kmsg on the screen

On 2024-09-10, Jocelyn Falempe wrote: > drm_log is a simple logger that uses the drm_client API to print the > kmsg boot log on the screen. This is not a full replacement to fbcon, > as it will only print the kmsg. It will never handle user input, or a > terminal because this is better done in use

[syzbot] Monthly dri report (Sep 2024)

Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 0 new issues were detected and 0 were fixed. In total, 18 issues are still open and 31 have been

Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

On 9/12/24 12:49 PM, Thomas Zimmermann wrote: > Hi > > Am 11.09.24 um 20:06 schrieb Tejas Vipin: >> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since >> monitor HDMI information is available after EDID is parsed. Additionally >> rewrite the code the code to have fewer indent

[PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

This series fixes two binding schema errors in mediatek,dpi binding. The first patch adds the power-domain property to the binding, and the second patch adds the port node as it's required by the binding. Pin-yen Lin (2): dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

[PATCH 1/2] dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

The power-domains property is used by most DT nodes using mediatek,dpi bindings. Add this to the bindings to fix the schema check error. Signed-off-by: Pin-yen Lin --- .../bindings/display/mediatek/mediatek,dpi.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Document

[PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

Add the port node to fix the binding schema check. Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183") Signed-off-by: Pin-yen Lin Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202409110843.hm5w9upr-...@intel.com/ --- arch/arm64/boot/dts/mediatek/

[PATCH 1/3] drm/vkms: Switch to dynamic allocation for connector

A specific allocation for the connector is not strictly necessary at this point, but in order to implement dynamic configuration of VKMS (configFS), it will be easier to have one allocation per connector. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h| 1 - drivers/gpu/drm/

[PATCH 0/3] drm/vkms: Switch to allocated for drm objects

only be one per CRTC No functionnal changes are intented in this series. This series requires [1] to switch vkms objects to drm-managed objects. [1]: https://lore.kernel.org/all/20240912-google-vkms-managed-v3-0-7708d6ad2...@bootlin.com/ Signed-off-by: Louis Chauvet --- Louis Chauvet (3

[PATCH 3/3] drm/vkms: Switch to dynamic allocation for CRTC

specific allocation for the CRTC is not strictly necessary at this point, but in order to implement dynamic configuration of VKMS (configFS), it will be easier to have one allocation per CRTC. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_crtc.c | 28 ++---

  1   2   >