Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-04 Thread Thomas Zimmermann
Hi Linus Am 04.09.24 um 00:53 schrieb Linus Walleij: On Fri, Apr 19, 2024 at 10:35 AM Thomas Zimmermann wrote: Add support for damage handling and deferred I/O to fbdev-dma. This enables fbdev-dma to support all DMA-memory-based DRM drivers, even such with a dirty callback in their framebuffe

Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-04 Thread Thomas Zimmermann
Hi Am 04.09.24 um 08:43 schrieb Alexander Stein: Hi Linus, Am Mittwoch, 4. September 2024, 08:36:46 CEST schrieb Linus Walleij: On Wed, Sep 4, 2024 at 8:09 AM Alexander Stein wrote: Can you please check in which memory zone this VRAM is located. In my case it's important CMA is located in N

[PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-04 Thread Thomas Hellström
Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide "pinned" list to "unevictable" and move also resources of swapped-out objects to that list. An alternative would be to create an "UNEVICTABLE" priority to

[PATCH v4 0/2] drm/ttm: Really use a separate LRU list for swapped- and pinned objects

2024-09-04 Thread Thomas Hellström
Resources of swapped objects were never moved off their LRU list when swapped, and also resources of pinned objects might remain on their LRU list unless the driver moved them to the device pinned list after pinning. Rename the device "pinned" list to "unevictable" and ensure that resources of obj

[PATCH v4 2/2] drm/ttm: Move pinned objects off LRU lists when pinning

2024-09-04 Thread Thomas Hellström
The ttm_bo_pin() and ttm_bo_unpin() functions weren't moving their resources off the LRU list to the unevictable list. Make sure that happens so that pinned objects don't accidently linger on the LRU lists, and also make sure to move them back once they are unpinned. v2: - Removing from a bulk mo

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 21:43:48 +0200 Simona Vetter wrote: > On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > > - Add our job fence as DMA_RESV_USAGE_WRITE to all external objects > > (was previously DMA_RESV_USAGE_BOOKKEEP). I don't get why, given > > we're supposed to be fully

Re: [PATCH v2 1/2] drm/virtio: Defer the host dumb buffer creation

2024-09-04 Thread Gerd Hoffmann
Hi, > - } else { > - virtio_gpu_cmd_create_resource(vgdev, bo, params, > -objs, fence); > - virtio_gpu_object_attach(vgdev, bo, ents, nents); > + } else if (params->dumb) { > + /* Create the host resource in

Re: [PATCH v2 2/2] drm/virtio: Add support for XRGB8888 and BGRX8888

2024-09-04 Thread Gerd Hoffmann
On Tue, Sep 03, 2024 at 09:48:27AM GMT, Jocelyn Falempe wrote: > On big endian machine, fbdev wants BGRX, but gnome/wayland wants > XRGB, which wasn't possible because virtio-gpu could only support > one format. Now that it's fixed, it can support both. Reviewed-by: Gerd Hoffmann take ca

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-04 Thread Christian König
Am 03.09.24 um 10:13 schrieb Simona Vetter: [SNIP] So I think the issue is much, much bigger, and there's more. And the issue is I think a fundamental design issue of dma_fence itself, not individual users. IIRC both Alex and me pointed out this issue on the very first dma_fence code and nobody

Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-04 Thread Thomas Zimmermann
Hi Linus, Alexander, Attached is a patch to mitigate the problem and go back to the old behavior for pl111. Can you please test it on affected and unaffected systems and report the results? Best regards Thomas Am 04.09.24 um 00:53 schrieb Linus Walleij: On Fri, Apr 19, 2024 at 10:35 AM Thom

RE: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-04 Thread Pu, Hui
Hi Liu Ying, Thank you very much for guiding me with so detailed comments. V2 is coming. > Hi Paul, > > Thanks for your patch. > > On 09/04/2024, Paul Pu wrote: > > This changes the judgement of if needing to round up the width or not, > > from using the `dp_flow` to the plane's type. > > > >

RE: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-04 Thread Pu, Hui
> On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > > This changes the judgement of if needing to round up the width or not, > > from using the `dp_flow` to the plane's type. > > > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > > See `client_reg[]` in `ipu-common.c`

Re: [PATCH v5 1/4] drm/panthor: introduce job cycle and timestamp accounting

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 21:25:35 +0100 Adrián Larumbe wrote: > Enable calculations of job submission times in clock cycles and wall > time. This is done by expanding the boilerplate command stream when running > a job to include instructions that compute said times right before an after > a user CS.

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-04 Thread Christian König
Am 03.09.24 um 23:11 schrieb Simona Vetter: On Tue, Sep 03, 2024 at 03:46:43PM +0200, Christian König wrote: Hi Steven, Am 29.08.24 um 15:37 schrieb Steven Price: Hi Christian, Mihail should be able to give more definitive answers, but I think I can answer your questions. On 29/08/2024 10:40

Re: [PATCH v5 9/9] media: xilinx-tpg: use new of_graph functions

2024-09-04 Thread Kuninori Morimoto
Hi > Now we can use new port related functions for port parsing. Use it. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Tomi Valkeinen > --- I'm sorry, but this patch will get below warning drivers/media/platform/xilinx/xilinx-tpg.c: In function 'xtpg_parse_of': >> drivers/media/pla

Re: [PATCH v5 2/4] drm/panthor: add DRM fdinfo support

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 21:25:36 +0100 Adrián Larumbe wrote: > Drawing from the FW-calculated values in the previous commit, we can > increase the numbers for an open file by collecting them from finished jobs > when updating their group synchronisation objects. > > Display of fdinfo key-value pairs

Re: [PATCH v5 3/4] drm/panthor: enable fdinfo for memory stats

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 21:25:37 +0100 Adrián Larumbe wrote: > Implement drm object's status callback. > > Also, we consider a PRIME imported BO to be resident if its matching > dma_buf has an open attachment, which means its backing storage had already > been allocated. > > Signed-off-by: Adrián L

Re: [PATCH v5 4/4] drm/panthor: add sysfs knob for enabling job profiling

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 21:25:38 +0100 Adrián Larumbe wrote: > This commit introduces a DRM device sysfs attribute that lets UM control > the job accounting status in the device. The knob variable had been brought > in as part of a previous commit, but now we're able to fix it manually. > > As sysfs

[PATCH v3 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-04 Thread Jianeng Ceng
This is v3 of the MT8186 Chromebook device tree series. --- Changes in v3: - PATCH 0/2: Add the modify records. - PATCH 1/2: Modify lable to label. - Link to v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ Changes in v2: - PATCH 2/2: Modify the

[PATCH v3 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-04 Thread Jianeng Ceng
Add an entry for the MT8186 based Ponyta Chromebook (custom lable). Signed-off-by: Jianeng Ceng --- Changes in v3: - PATCH 1/2: Modify lable to label. - Link to v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjian...@huaqin.corp-partner.google.com/ Chage since V2: - No change. ---

Re: [PATCH] drm/amdgpu: enable -Wformat-truncation

2024-09-04 Thread Jani Nikula
On Tue, 03 Sep 2024, Hamza Mahfooz wrote: > It is enabled by W=1 and amdgpu has a clean build with it enabled. So, > to make sure we block future instances of it from showing up on > our driver, enable it by default for the module. Would prefer enabling it by default across the subsystem [1]. BR

Re: [PATCH v5 01/10] drm/v3d: Fix the MMU flush order

2024-09-04 Thread Iago Toral
Hi Maira, El jue, 29-08-2024 a las 10:05 -0300, Maíra Canal escribió: > We must first flush the MMU cache and then, flush the TLB, not the > other > way around. Currently, we can see a race condition between the MMU > cache > and the TLB when running multiple rendering processes at the same > time

Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-04 Thread Alexander Stein
Hi Thomas, Am Mittwoch, 4. September 2024, 09:41:12 CEST schrieb Thomas Zimmermann: > Hi Linus, Alexander, > > Attached is a patch to mitigate the problem and go back to the old > behavior for pl111. Can you please test it on affected and unaffected > systems and report the results? Thank you

[PATCH] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-04 Thread Dominique Martinet
This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we cannot output the exact frequency, enabling the imx8mp HDMI output to support more modes Signed-off-by: Dominique Martinet --- This completes the patch series sent by Adam Ford here: https://lkml.kernel.org/r/20240904023310

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Philipp Zabel
On Mi, 2024-09-04 at 10:54 +0300, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even if the plane is a PRIMARY one. > See `client_reg[]` in `ipu-common.c`. > > [0.60

RE: [PATCH 0/6] drm: conversions to struct drm_edid

2024-09-04 Thread Jani Nikula
On Wed, 04 Sep 2024, 대인기/Tizen Platform Lab(SR)/삼성전자 wrote: >> > drm/exynos: hdmi: use display_info for printing display dimensions >> > drm/exynos: hdmi: convert to struct drm_edid >> >> I'll wait for Inki to check these. > > You could push them to drm-misc-next. > > Acked-by : Inki Dae

Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-09-04 Thread Tvrtko Ursulin
On 21/08/2024 21:47, Alex Deucher wrote: On Tue, Aug 13, 2024 at 9:57 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the curre

[PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Paul Pu
This changes the judgement of if needing to round up the width or not, from using the `dp_flow` to the plane's type. The `dp_flow` can be -22(-EINVAL) even if the plane is a PRIMARY one. See `client_reg[]` in `ipu-common.c`. [0.605141] [drm:ipu_plane_init] channel 28, dp flow -22, possible_cr

Re: [PATCH v4 2/3] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-09-04 Thread Matthias Brugger
On 03/09/2024 11:39, CK Hu (胡俊光) wrote: Hi, Matthias: On Mon, 2024-09-02 at 17:31 +0200, Matthias Brugger wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. On 01/09/2024 16:32, Chun-Kuang Hu wrote: Use cmd

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-09-04 Thread Simona Vetter
On Tue, Sep 03, 2024 at 09:43:48PM +0200, Simona Vetter wrote: > On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > > - Add our job fence as DMA_RESV_USAGE_WRITE to all external objects > > (was previously DMA_RESV_USAGE_BOOKKEEP). I don't get why, given > > we're supposed to be

Re: [PATCH v2] gpu: ipu-v3: Add cleanup attribute for prg_node for auto cleanup

2024-09-04 Thread Philipp Zabel
On Do, 2024-07-04 at 13:21 +, Abhinav Jain wrote: > Add cleanup attribute for device node prg_node. > Remove of_node_put for device node prg_node as it is unnecessary now. > > Suggested-by: Julia Lawall > Signed-off-by: Abhinav Jain Thank you, Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Liu Ying
On 09/04/2024, Paul Pu wrote: > Cc: sta...@vger.kernel.org # 5.15+ Why 5.15+ ? I think it should be 6.3+ because below commit introduced in v6.3 moves ipuv3-plane.c from one directory to another, which makes this patch not being applicable to v6.2. commit 4b6cb2b67da8 ("drm/imx: move IPUv3 driver

[PATCH v3 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-04 Thread Jianeng Ceng
MT8186 ponyta, known as huaqin custom lable, is a MT8186 based laptop. It is based on the "corsola" design. It includes LTE, touchpad combinations. Signed-off-by: Jianeng Ceng --- Changes in v2: - PATCH 2/2: Modify the dtb name without rev2. - Link to v1:https://lore.kernel.org/all/2024090212550

Re: [PATCH v3 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-04 Thread Matthias Brugger
On 03/09/2024 14:09, Liankun Yang wrote: Update efuse data for MT8188 displayport. The DP monitor can not display when DUT connected to USB-c to DP dongle. Analysis view is invalid DP efuse data. Fixes: 350c3fe907fb ("drm/mediatek: dp: Add support MT8188 dp/edp function") Nit: no new-line

Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-04 Thread Christian König
Am 04.09.24 um 09:08 schrieb Thomas Hellström: Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide "pinned" list to "unevictable" and move also resources of swapped-out objects to that list. An alternativ

[PATCH] drm/bridge/tdp158: fix build failure

2024-09-04 Thread Jani Nikula
ARCH=arm build fails with: CC [M] drivers/gpu/drm/bridge/ti-tdp158.o ../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_enable’: ../drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration] 31

Re: [PATCH v5 0/2] Basic support for TI TDP158

2024-09-04 Thread Jani Nikula
On Tue, 03 Sep 2024, Jani Nikula wrote: > On Tue, 03 Sep 2024, Robert Foss wrote: >> On Mon, 12 Aug 2024 16:51:00 +0200, Marc Gonzalez wrote: >>> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. >>> >>> Like the TFP410, the TDP158 can be set up in 2 different ways: >>> 1) hard

Re: [PATCH] gpu: ipu-v3: image-convert: Drop unused single conversion request code

2024-09-04 Thread Philipp Zabel
On Sa, 2024-07-13 at 17:35 +0200, Marek Vasut wrote: > Neither ipu_image_convert_sync() nor ipu_image_convert() is used or call > from anywhere. Remove this unused code. > > Signed-off-by: Marek Vasut Thank you, Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH] drm/bridge/tdp158: fix build failure

2024-09-04 Thread Dmitry Baryshkov
On Wed, Sep 04, 2024 at 11:52:06AM GMT, Jani Nikula wrote: > ARCH=arm build fails with: > > CC [M] drivers/gpu/drm/bridge/ti-tdp158.o > ../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_enable’: > ../drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of > function ‘g

Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-09-04 Thread Philipp Zabel
On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: > The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 > subsampling, turn it into boolean to select exactly that and update > related code accordingly. > > Signed-off-by: Marek Vasut I'd prefer this to be an enum ipu_chroma_subs

Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-04 Thread Thomas Hellström
On Wed, 2024-09-04 at 10:50 +0200, Christian König wrote: > Am 04.09.24 um 09:08 schrieb Thomas Hellström: > > Resources of swapped objects remains on the TTM_PL_SYSTEM manager's > > LRU list, which is bad for the LRU walk efficiency. > > > > Rename the device-wide "pinned" list to "unevictable" a

RE: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Pu, Hui
> On 09/04/2024, Paul Pu wrote: > > Cc: sta...@vger.kernel.org # 5.15+ > > Why 5.15+ ? > > I think it should be 6.3+ because below commit introduced in v6.3 > moves ipuv3-plane.c from one directory to another, which makes > this patch not being applicable to v6.2. > commit 4b6cb2b67da8 ("drm/imx:

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Greg KH
On Wed, Sep 04, 2024 at 04:48:51PM +0800, Liu Ying wrote: > On 09/04/2024, Paul Pu wrote: > > Cc: sta...@vger.kernel.org # 5.15+ > > Why 5.15+ ? Because the commit referenced in Fixes: was backported there. If you want to be picky, just drop the "# 5.15+" and our tools will rely on the Fixes: ta

Re: [PATCH v1 1/1] drm/mm: Mark drm_mm_interval_tree*() functions with __maybe_unused

2024-09-04 Thread Jani Nikula
On Fri, 30 Aug 2024, Jani Nikula wrote: > On Thu, 29 Aug 2024, Andy Shevchenko > wrote: >> The INTERVAL_TREE_DEFINE() uncoditionally provides a bunch of helper >> functions which in some cases may be not used. This, in particular, >> prevents kernel builds with `make W=1` and CONFIG_WERROR=y: >>

Re: [PATCH] drm/mm: annotate drm_mm_node_scanned_block() with __maybe_unused

2024-09-04 Thread Jani Nikula
On Tue, 03 Sep 2024, Andy Shevchenko wrote: > On Tue, Sep 03, 2024 at 08:34:37PM +0300, Jani Nikula wrote: >> Clang build with CONFIG_DRM_DEBUG_MM=n, CONFIG_WERROR=y, and W=1 leads >> to: >> >> CC [M] drivers/gpu/drm/drm_mm.o >> ../drivers/gpu/drm/drm_mm.c:614:20: error: function >> 'drm_mm_n

RE: [1/5] drm: Introduce sharpness mode property

2024-09-04 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [1/5] drm: Introduce sharpness mode property Nit: Rename it to sharpness strength

Re: [PATCH] drm/bridge/tdp158: fix build failure

2024-09-04 Thread Jani Nikula
On Wed, 04 Sep 2024, Dmitry Baryshkov wrote: > On Wed, Sep 04, 2024 at 11:52:06AM GMT, Jani Nikula wrote: >> ARCH=arm build fails with: >> >> CC [M] drivers/gpu/drm/bridge/ti-tdp158.o >> ../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_enable’: >> ../drivers/gpu/drm/bridge/ti-tdp158.

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-09-04 Thread Simona Vetter
On Wed, Sep 04, 2024 at 09:09:53AM +0200, Boris Brezillon wrote: > On Tue, 3 Sep 2024 21:43:48 +0200 > Simona Vetter wrote: > > > On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > > > - Add our job fence as DMA_RESV_USAGE_WRITE to all external objects > > > (was previously DMA_

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Liu Ying
On 09/04/2024, Greg KH wrote: > On Wed, Sep 04, 2024 at 04:48:51PM +0800, Liu Ying wrote: >> On 09/04/2024, Paul Pu wrote: >>> Cc: sta...@vger.kernel.org # 5.15+ >> >> Why 5.15+ ? > > Because the commit referenced in Fixes: was backported there. Sorry, really? It doesn't seem to be backported.

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-04 Thread Steven Price
On 04/09/2024 08:49, Christian König wrote: > Am 03.09.24 um 23:11 schrieb Simona Vetter: >> On Tue, Sep 03, 2024 at 03:46:43PM +0200, Christian König wrote: >>> Hi Steven, >>> >>> Am 29.08.24 um 15:37 schrieb Steven Price: Hi Christian, Mihail should be able to give more definitive

[PATCH] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Thomas Zimmermann
Deferred I/O requires struct page for framebuffer memory, which is not guaranteed for all DMA ranges. We thus only install deferred I/O if we have a framebuffer that requires it. A reported bug affected the ipu-v3 and pl111 drivers, which have video memory in either Normal or HighMem zones [0

Re: [PATCH v4 16/18] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-09-04 Thread Tzung-Bi Shih
On Sat, Aug 31, 2024 at 09:06:54PM -0700, Stephen Boyd wrote: > We can imagine that logically the EC is a device that has some number of > DisplayPort (DP) connector inputs, some number of USB3 connector inputs, > and some number of USB type-c connector outputs. If you squint enough it > looks like

Re: [PATCH v4 17/18] platform/chrome: cros_ec_typec: Support DP muxing

2024-09-04 Thread Tzung-Bi Shih
On Sat, Aug 31, 2024 at 09:06:55PM -0700, Stephen Boyd wrote: > Most ARM based chromebooks with two usb-c-connector nodes and one DP > controller are muxing the DP lanes between the two USB ports. This is > done so that the type-c ports are at least equal in capability if not > functionality. Eithe

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-04 Thread Tzung-Bi Shih
On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > +static void cros_typec_inject_hpd(struct cros_typec_data *typec, > + struct ec_response_usb_pd_mux_info *resp, > + struct cros_typec_port *port) > +{ [...] > + /* > +

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-04 Thread Simona Vetter
On Wed, Sep 04, 2024 at 09:49:44AM +0200, Christian König wrote: > Am 03.09.24 um 23:11 schrieb Simona Vetter: > > On Tue, Sep 03, 2024 at 03:46:43PM +0200, Christian König wrote: > > > Hi Steven, > > > > > > Am 29.08.24 um 15:37 schrieb Steven Price: > > > > Hi Christian, > > > > > > > > Mihail

Re: [RFC PATCH 4/4] dma-buf: heaps: add Linaro restricted dmabuf heap support

2024-09-04 Thread Jens Wiklander
On Tue, Sep 3, 2024 at 7:50 PM T.J. Mercier wrote: > > On Fri, Aug 30, 2024 at 12:04 AM Jens Wiklander > wrote: > > > > Add a Linaro restricted heap using the linaro,restricted-heap bindings > > implemented based on the generic restricted heap. > > > > The bindings defines a range of physical res

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-04 Thread Simona Vetter
On Wed, Sep 04, 2024 at 09:40:36AM +0200, Christian König wrote: > Am 03.09.24 um 10:13 schrieb Simona Vetter: > > [SNIP] > > > > So I think the issue is much, much bigger, and there's more. And the > > > > issue is I think a fundamental design issue of dma_fence itself, not > > > > individual user

Re: [RFC PATCH 2/4] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2024-09-04 Thread Jens Wiklander
On Tue, Sep 3, 2024 at 7:50 PM T.J. Mercier wrote: > > On Fri, Aug 30, 2024 at 12:04 AM Jens Wiklander > wrote: > > > > From: Etienne Carriere > > > > Enable userspace to create a tee_shm object that refers to a dmabuf > > reference. > > > > Userspace registers the dmabuf file descriptor as in a

Re: linux-next: build failure after merge of the drm-misc tree

2024-09-04 Thread Jani Nikula
On Wed, 04 Sep 2024, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_enable': > drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration

Re: [PATCH] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Simona Vetter
On Wed, Sep 04, 2024 at 11:31:23AM +0200, Thomas Zimmermann wrote: > Deferred I/O requires struct page for framebuffer memory, which is > not guaranteed for all DMA ranges. We thus only install deferred I/O > if we have a framebuffer that requires it. > > A reported bug affected the ipu-v3 and pl1

Re: [PATCH] drm/i915/guc: prevent a possible int overflow in wq offsets

2024-09-04 Thread Tvrtko Ursulin
On 26/08/2024 11:45, Nikita Zhandarovich wrote: Hi, On 7/25/24 08:59, Nikita Zhandarovich wrote: It may be possible for the sum of the values derived from i915_ggtt_offset() and __get_parent_scratch_offset()/ i915_ggtt_offset() to go over the u32 limit before being assigned to wq offsets of u

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-04 Thread Simona Vetter
On Wed, Sep 04, 2024 at 11:46:54AM +0200, Simona Vetter wrote: > On Wed, Sep 04, 2024 at 09:40:36AM +0200, Christian König wrote: > > Am 03.09.24 um 10:13 schrieb Simona Vetter: > > > [SNIP] > > > > > So I think the issue is much, much bigger, and there's more. And the > > > > > issue is I think a

Re: [PATCH v4] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-09-04 Thread Boris Brezillon
On Fri, 30 Aug 2024 10:03:50 +0200 Mary Guillemard wrote: > Expose timestamp information supported by the GPU with a new device > query. > > Mali uses an external timer as GPU system time. On ARM, this is wired to > the generic arch timer so we wire cntfrq_el0 as device frequency. > > This new

Re: [PATCH] drm/i915: convert comma to semicolon

2024-09-04 Thread Jani Nikula
On Tue, 03 Sep 2024, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni Pushed to drm-intel-next, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-04 Thread Boris Brezillon
On Wed, 4 Sep 2024 11:46:54 +0200 Simona Vetter wrote: > On Wed, Sep 04, 2024 at 09:40:36AM +0200, Christian König wrote: > > Am 03.09.24 um 10:13 schrieb Simona Vetter: > > > [SNIP] > > > > > So I think the issue is much, much bigger, and there's more. And the > > > > > issue is I think a fu

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-04 Thread Boris Brezillon
On Wed, 4 Sep 2024 12:03:24 +0200 Simona Vetter wrote: > On Wed, Sep 04, 2024 at 11:46:54AM +0200, Simona Vetter wrote: > > On Wed, Sep 04, 2024 at 09:40:36AM +0200, Christian König wrote: > > > Am 03.09.24 um 10:13 schrieb Simona Vetter: > > > > [SNIP] > > > > > > So I think the issue is m

Re: [PATCH] drm/panthor: Restrict high priorities on group_create

2024-09-04 Thread Boris Brezillon
On Tue, 3 Sep 2024 16:49:55 +0200 Mary Guillemard wrote: > We were allowing any users to create a high priority group without any > permission checks. As a result, this was allowing possible denial of > service. > > We now only allow the DRM master or users with the CAP_SYS_NICE > capability to

[PATCH v2] dt-bindings: lcdif: Document the dmas/dma-names properties

2024-09-04 Thread Fabio Estevam
From: Fabio Estevam i.MX28 has an RX DMA channel associated with the LCDIF controller. Document the 'dmas' and 'dma-names' properties to fix the following dt-schema warnings: lcdif@8003: 'dma-names', 'dmas' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Fabio Estevam Re

Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-04 Thread Christian König
Am 04.09.24 um 10:54 schrieb Thomas Hellström: On Wed, 2024-09-04 at 10:50 +0200, Christian König wrote: Am 04.09.24 um 09:08 schrieb Thomas Hellström: Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide

Re: [PATCH] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Thomas Zimmermann
Hi Am 04.09.24 um 11:59 schrieb Simona Vetter: On Wed, Sep 04, 2024 at 11:31:23AM +0200, Thomas Zimmermann wrote: Deferred I/O requires struct page for framebuffer memory, which is not guaranteed for all DMA ranges. We thus only install deferred I/O if we have a framebuffer that requires it. A

Re: (subset) [PATCH v6 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Wed, 19 Jun 2024 16:46:36 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Mon, 22 Jul 2024 08:53:29 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: [PATCH] drm: vc4: Use of_property_present()

2024-09-04 Thread Dave Stevenson
Hi Rob On Tue, 3 Sept 2024 at 20:19, Rob Herring wrote: > > On Wed, Jul 31, 2024 at 2:13 PM Rob Herring (Arm) wrote: > > > > Use of_property_present() to test for property presence rather than > > of_find_property(). This is part of a larger effort to remove callers > > of of_find_property() and

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-04 Thread Boris Brezillon
On Wed, 4 Sep 2024 10:31:36 +0100 Steven Price wrote: > On 04/09/2024 08:49, Christian König wrote: > > Am 03.09.24 um 23:11 schrieb Simona Vetter: > >> On Tue, Sep 03, 2024 at 03:46:43PM +0200, Christian König wrote: > >>> Hi Steven, > >>> > >>> Am 29.08.24 um 15:37 schrieb Steven Price: >

Re: linux-next: build failure after merge of the drm-misc tree

2024-09-04 Thread Robert Foss
On Wed, Sep 4, 2024, 11:58 Jani Nikula wrote: > On Wed, 04 Sep 2024, Stephen Rothwell wrote: > > Hi all, > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/gpu/drm/bridge/ti-tdp158.c: In function 'tdp158_enable': > > driv

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-09-04 Thread Christian König
Hi Boris, Am 04.09.24 um 13:23 schrieb Boris Brezillon: Please read up here on why that stuff isn't allowed: https://www.kernel.org/doc/html/latest/driver-api/dma-buf.html#indefinite-dma-fences panthor doesn't yet have a shrinker, so all memory is pinned, which means memory management easy m

[RESEND 1/2] drm: fsl-dcu: Use dev_err_probe

2024-09-04 Thread Alexander Stein
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dr

[RESEND 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2024-09-04 Thread Alexander Stein
From: Matthias Schiffer The PIXCLK needs to be enabled in SCFG before accessing certain DCU registers, or the access will hang. Signed-off-by: Matthias Schiffer Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 14

[PATCH v2 08/11] drm/rockchip: vop2: Add uv swap for cluster window

2024-09-04 Thread Andy Yan
From: Andy Yan The Cluster windows of upcoming VOP on rk3576 also support linear YUV support, we need to set uv swap bit for it. As the VOP2_WIN_UV_SWA register defined on rk3568/rk3588 is 0x, so this register will not be touched on these two platforms. Signed-off-by: Andy Yan --- (no

[PATCH v2 01/11] drm/rockchip: vop2: Add debugfs support

2024-09-04 Thread Andy Yan
From: Andy Yan /sys/kernel/debug/dri/vop2/summary: dump vop display state /sys/kernel/debug/dri/vop2/regs: dump whole vop registers /sys/kernel/debug/dri/vop2/active_regs: only dump the registers of activated modules Signed-off-by: Andy Yan Reviewed-by: Sascha Hauer --- (no changes since v1

[PATCH v2 00/11] VOP Support for rk3576

2024-09-04 Thread Andy Yan
From: Andy Yan Thanks for the basic work from Collabora, I can bringup a HDMI display out on rk3576. The hdmi depends on WIP patch from Cristian[0] I test it with a 1080P/4K HDMI output with modetest and weston output. If there are some one want to have a try, I have a tree here[1] [0]https:/

[PATCH v2 05/11] drm/rockchip: vop2: Introduce vop hardware version

2024-09-04 Thread Andy Yan
From: Andy Yan There is a version number hardcoded in the VOP VERSION_INFO register, and the version number increments sequentially based on the production order of the SOC. So using this version number to distinguish different VOP features will simplify the code. Signed-off-by: Andy Yan ---

[PATCH v2 03/11] drm/rockchip: vop2: Support 32x8 superblock afbc

2024-09-04 Thread Andy Yan
From: Andy Yan This is the only afbc format supported by the upcoming VOP for rk3576. Add support for it. Signed-off-by: Andy Yan --- Changes in v2: - split it from main patch add support for rk3576 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 17 + 1 file changed, 13 ins

[PATCH v2 06/11] drm/rockchip: vop2: Register the primary plane and overlay plane separately

2024-09-04 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports, so make sure all VP find it's suitable primary plane, then register the remain windows as overlay plane will make code easier. Signed-off-by: Andy Yan --- (no changes since v1) drivers/gpu/drm/rockchip/r

[PATCH v2 04/11] drm/rockchip: vop2: Add platform specific callback

2024-09-04 Thread Andy Yan
From: Andy Yan The VOP interface mux, overlay, background delay cycle configuration of different SOC are much different. Add platform specific callback ops to let the core driver look cleaner and more refined. Signed-off-by: Andy Yan --- Changes in v2: - Add platform specific callback drive

[PATCH v2 10/11] drm/rockchip: vop2: Add support for rk3576

2024-09-04 Thread Andy Yan
From: Andy Yan VOP2 on rk3576: Three video ports: VP0 Max 4096x2160 VP1 Max 2560x1600 VP2 Max 1920x1080 2 4K Cluster windows with AFBC/RFBC, line RGB and YUV 4 Esmart windows with line RGB/YUV support: Esmart0/1: 4K Esmart2/3: 2k, or worked together as a single 4K plane at shared line buffer mod

[PATCH v2 02/11] drm/rockchip: vop2: Support for different layer selet configuration between VPs

2024-09-04 Thread Andy Yan
From: Andy Yan In the upcoming VOP for rk3576, every VP has it's own LAYER_SEL register, and the configuration value of each VP for the same window maybe different, so extend the layer_sel_id to array, let it can descption the layer select configuration value for different VP. Signed-off-by: And

[PATCH v2 07/11] drm/rockchip: vop2: Set plane possible crtcs by possible vp mask

2024-09-04 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a window cannot attach to all Video Ports, we introduce a possible_vp_mask for every window to indicate which Video Ports this window can attach to. Signed-off-by: Andy Yan --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c |

[PATCH v2 09/11] dt-bindings: display: vop2: Add rk3576 support

2024-09-04 Thread Andy Yan
From: Andy Yan Add vop found on rk3576. Signed-off-by: Andy Yan --- Changes in v2: - Add dt bindings .../devicetree/bindings/display/rockchip/rockchip-vop2.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b

[PATCH v3 0/3] Improve tc358767 debugging

2024-09-04 Thread Alexander Stein
Hi, this small series improves debugging the tc358767 driver by using dev_err_probe for additional information (patch 1) and print IRQ debug output only if hotplug status actually changed. Changes inv 3: * Collected Robert's and Dmitry' R-b Changes in v2: * Added patch for supporting write-only

[PATCH v3 1/3] drm/bridge: tc358767: Use dev_err_probe

2024-09-04 Thread Alexander Stein
The function calls preceding these returns can return -EPROBE_DEFER. So use dev_err_probe to add some information to /sys/kernel/debug/devices_deferred Signed-off-by: Alexander Stein Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/tc358767.c | 8 +--- 1 file changed, 5 insertions(+

[PATCH v3 2/3] drm/bridge: tc358767: Only print GPIO debug output if they actually occur

2024-09-04 Thread Alexander Stein
Currently the output the following output is printed upon each interrupt: tc358767 1-000f: GPIO0: This spams the kernel log while debugging an IRQ storm from the bridge. Only print the debug output if the GPIO hotplug event actually happened. Signed-off-by: Alexander Stein Reviewed-by: Robert Fo

[PATCH v3 3/3] drm/bridge: tc358767: Support write-only registers

2024-09-04 Thread Alexander Stein
Most registers are read-writable, but some are only RO or even WO. regmap does not support using readable_reg and wr_table when outputting in debugfs, so switch to writeable_reg. First check for RO or WO registers and fallback tc_readable_reg() for the leftover RW registers. Signed-off-by: Alexand

[PATCH v2 11/11] phy: phy-rockchip-samsung-hdptx: Don't request RST_PHY/RST_ROPLL/RST_LCPLL

2024-09-04 Thread Andy Yan
From: Andy Yan RST_PHY/RST_ROPLL/RST_LCPLL are used for debug only, and there are not exported on rk3576. Signed-off-by: Andy Yan --- (no changes since v1) .../phy/rockchip/phy-rockchip-samsung-hdptx.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/dr

Re: [PATCH v2] drm/panel: hx83112a: Transition to wrapped mipi_dsi functions

2024-09-04 Thread Javier Martinez Canillas
Abhishek Tamboli writes: Hello Abhishek, > Transition to mipi_dsi_dcs_write_seq_multi() macros for initialization > sequences. The previous mipi_dsi_dcs_write_seq() macros were > non-intuitive and use other wrapped MIPI DSI functions in the > driver code to simplify the code pattern. > > Reporte

Re: [PATCH] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Linus Walleij
Hi Thomas, quick response as always! :) On Wed, Sep 4, 2024 at 11:31 AM Thomas Zimmermann wrote: > Deferred I/O requires struct page for framebuffer memory, which is > not guaranteed for all DMA ranges. We thus only install deferred I/O > if we have a framebuffer that requires it. > > A reporte

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-04 Thread Thomas Hellström
Hi, Sima, On Mon, 2024-09-02 at 14:33 +0200, Daniel Vetter wrote: > Jumping in here in the middle, since I think it's a solid place to > drop my > idea of "align with core mm" gpusvm locking ... > > On Thu, Aug 29, 2024 at 08:56:23PM +, Matthew Brost wrote: > > On Thu, Aug 29, 2024 at 09:18:2

[PATCH v2] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Thomas Zimmermann
Deferred I/O requires struct page for framebuffer memory, which is not guaranteed for all DMA ranges. We thus only install deferred I/O if we have a framebuffer that requires it. A reported bug affected the ipu-v3 and pl111 drivers, which have video memory in either Normal or HighMem zones [0

[PATCH] drm: enable warnings on unused static inlines

2024-09-04 Thread Jani Nikula
We enable most W=1 warnings by default subsystem wide. Also enable warnings on unused static inlines when building with clang. See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build"). Cc: Nathan Chancellor Signed-off-by: Jani Nikula --- drivers

Re: [PATCH 1/2] ARM: dma-mapping: Pass device to arm_iommu_create_mapping()

2024-09-04 Thread Jason Gunthorpe
On Mon, Aug 12, 2024 at 03:02:01PM +0800, Lu Baolu wrote: > From: Robin Murphy > > All users of ARM IOMMU mappings create them for a particular device, so > change the interface to accept the device rather than forcing a vague > indirection through a bus type. This prepares for making a similar >

  1   2   >