Re: [PATCH v2 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-03 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:03PM +0800, Jianeng Ceng wrote: > MT8186 ponyta, known as huaqin custom lable, is a > MT8186 based laptop. It is based on the "corsola" design. > It includes LTE, touchpad combinations. > > Signed-off-by: Jianeng Ceng > --- > arch/arm64/boot/dts/mediatek/Makefile

Re: [PATCH v2 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-03 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:01PM +0800, Jianeng Ceng wrote: > This is v2 of the MT8186 Chromebook device tree series. > Where is the changelog? Why do you send the same patch as v2? Best regards, Krzysztof

Re: [PATCH v1 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-03 Thread Krzysztof Kozlowski
On Mon, Sep 02, 2024 at 08:55:02PM +0800, Jianeng Ceng wrote: > MT8186 ponyta, known as huaqin custom lable, is a > MT8186 based laptop. It is based on the "corsola" design. > It includes LTE, touchpad combinations. > > Signed-off-by: Jianeng Ceng > --- > arch/arm64/boot/dts/mediatek/Makefile

Re: [PATCH v3 3/3] drm/i915: Use device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:22:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Now that we have device wedged event supported by DRM core, make use > > of it. With this in place, userspace will be notified of wedged device > > on gt reset failure. > > > > Signed-o

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 18:57写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Data width for dsc engine is aligned with pipe, not with whole screen > > width. Because the width may be halved in DSI bonded case. > > Can't really parse this. Please forgive me for my bad English.

Re: [PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:07写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Add utility to get mixer number via CRTC handler > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 +++

Re: [PATCH v3 1/3] drm: Introduce device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:44:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in cases where the dev

Re: [PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:10写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Do not assume DSC number as 2. Because there are 4 DSC in > > quad pipe case. > > Please expand the commit message. You prefer brevity, but your > comments lack clarifications. Is below message OK?

Re: [PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:12写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > request more mixer for the case that hdisplay exceeding 4096 > > and DSC enabled. > > This doesn't seem to match the code. And it misses the _reason_ to do it. Right. The DSC limitation should be 256

Re: [PATCH 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-03 Thread Christian König
Am 02.09.24 um 17:41 schrieb Thomas Hellström: Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide "pinned" list to "unevictable" and move also resources of swapped-out objects to that list. An alternativ

Re: [PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:17写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Add the case to reserve multiple pair mixer for high resolution > > I think you already know what is missing here. Add the case to reserve multiple pair mixer for high resolution. Current code only s

Re: [PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:30写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Support 4 pipes and their configs at most. They are for 2 SSPP > > and their multi-rect mode. Because one SSPP can co-work with > > 2 mixer at most, 2 pair of mixer are needed for 2 SSPP in quad- > >

Re: [PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:38写道: > > > @@ -1033,13 +1030,10 @@ static int dpu_plane_atomic_check(struct drm_plane > > *plane, > > return -E2BIG; > > } > > > > - /* > > -* Use multirect for wide plane. We do not support d

Re: [PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:51写道: > > On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > > > Blend pipes by left and right. The first 2 pipes are for > > left half screen and the later 2 pipes are for right in quad > > pipe case. > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/ms

[PATCH v2 1/2] drm/virtio: Defer the host dumb buffer creation

2024-09-03 Thread Jocelyn Falempe
The host dumb buffer command needs a format, but the DRM_IOCTL_MODE_CREATE_DUMB only provides a buffer size. So wait for the DRM_IOCTL_MODE_ADDFB(2), to get the format, and create the host resources at this time. This will allow virtio-gpu to support multiple pixel formats. This problem was notic

[PATCH v2 2/2] drm/virtio: Add support for XRGB8888 and BGRX8888

2024-09-03 Thread Jocelyn Falempe
On big endian machine, fbdev wants BGRX, but gnome/wayland wants XRGB, which wasn't possible because virtio-gpu could only support one format. Now that it's fixed, it can support both. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/virtio/virtgpu_display.c | 6 -- drivers/gpu/drm

Re: [PATCH 2/2] drm/ttm: Move pinned objects off LRU lists when pinning

2024-09-03 Thread Christian König
Am 02.09.24 um 17:41 schrieb Thomas Hellström: The ttm_bo_pin() and ttm_bo_unpin() functions weren't moving their resources off the LRU list to the unevictable list. Make sure that happens so that pinned objects don't accidently linger on the LRU lists, and also make sure to move them back once

Re: [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-03 Thread Maxime Ripard
On Tue, Sep 03, 2024 at 12:12:02AM GMT, Cristian Ciocaltea wrote: > On 9/2/24 10:36 AM, Maxime Ripard wrote: > > On Sat, Aug 31, 2024 at 01:21:48AM GMT, Cristian Ciocaltea wrote: > >> On 8/27/24 11:58 AM, Maxime Ripard wrote: > >>> On Mon, Aug 19, 2024 at 01:29:29AM GMT, Cristian Ciocaltea wrote: >

[bug report] drm/msm: add msm8998 hdmi phy/pll support

2024-09-03 Thread Dan Carpenter
Hello Arnaud Vrac, Commit caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") from Jul 24, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:634 hdmi_8998_pll_prepare() info: return a literal instead of 'ret' drivers/gpu/drm/

Re: [PATCH v5 0/3] drm: fix two issues related to HDMI Connector implementation

2024-09-03 Thread Maxime Ripard
On Tue, 03 Sep 2024 05:01:55 +0300, Dmitry Baryshkov wrote: > Running IGT tests on Qualcomm Dragonboard820c uncovered two issues with > the HDMI Connector implementation and with its integration into the > drm_bridge_connector. Fix those issues. > > Note, I'm not fully satisfied with the drm_bridg

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-03 Thread Tomi Valkeinen
On 03/09/2024 10:40, Simona Vetter wrote: On Mon, Sep 02, 2024 at 03:31:28PM +0300, Tomi Valkeinen wrote: Hi, On 02/09/2024 13:50, Daniel Vetter wrote: On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: Hi, On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: On 25/07/2

Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-03 Thread Maxime Ripard
On Tue, Sep 03, 2024 at 06:07:25AM GMT, Sandor Yu wrote: > Hi Maxime, > > Thanks for your comments, > > > -Original Message- > > From: dri-devel On Behalf Of > > Maxime Ripard > > Sent: 2024年7月2日 21:25 > > To: Sandor Yu > > Cc: dmitry.barysh...@linaro.org; andrzej.ha...@intel.com; > > n

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:34, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 18:57写道: > > > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > > > Data width for dsc engine is aligned with pipe, not with whole screen > > > width. Because the width may be halved in DSI bonded case. > > > >

Re: [PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:48, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 19:10写道: > > > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > > > Do not assume DSC number as 2. Because there are 4 DSC in > > > quad pipe case. > > > > Please expand the commit message. You prefer brevity,

[PATCH v5 0/7] udmbuf bug fix and some improvements

2024-09-03 Thread Huan Yang
This patchset attempts to fix some errors in udmabuf and remove the upin_list structure. By this patchset, udmabuf remove page struct relay, only use pfn and folios. Some of this fix just gather the patches which I upload before. Any patch has passed the udmabuf self-test suite's tests. Suggeste

[PATCH v5 1/7] udmabuf: pre-fault when first page fault

2024-09-03 Thread Huan Yang
The current udmabuf mmap uses a page fault to populate the vma. However, the current udmabuf has already obtained and pinned the folio upon completion of the creation.This means that the physical memory has already been acquired, rather than being accessed dynamically. As a result, the page fault

[PATCH v5 2/7] udmabuf: change folios array from kmalloc to kvmalloc

2024-09-03 Thread Huan Yang
When PAGE_SIZE 4096, MAX_PAGE_ORDER 10, 64bit machine, page_alloc only support 4MB. If above this, trigger this warn and return NULL. udmabuf can change size limit, if change it to 3072(3GB), and then alloc 3GB udmabuf, will fail create. [ 4080.876581] [ cut here ] [ 4080.

[PATCH v5 3/7] udmabuf: fix vmap_udmabuf error page set

2024-09-03 Thread Huan Yang
Currently vmap_udmabuf set page's array by each folio. But, ubuf->folios is only contain's the folio's head page. That mean we repeatedly mapped the folio head page to the vmalloc area. Due to udmabuf can use hugetlb, if HVO enabled, tail page may not exist, so, we can't use page array to map, in

[PATCH v5 4/7] udmabuf: udmabuf_create pin folio codestyle cleanup

2024-09-03 Thread Huan Yang
This patch split pin folios into single function: udmabuf_pin_folios. When record folio and offset into udmabuf_folio and offsets, the outer loop of this patch iterates through folios, while the inner loop correctly sets the folio and corresponding offset into the udmabuf starting from the offset.

[PATCH v5 5/7] udmabuf: introduce udmabuf init and deinit helper

2024-09-03 Thread Huan Yang
After udmabuf is allocated, its resources need to be initialized, including various array structures. The current array structure has already been greatly expanded. Also, before udmabuf needs to be kfree, the occupied resources need to be released. This part is repetitive and maybe overlooked. T

[PATCH v5 6/7] udmabuf: remove udmabuf_folio

2024-09-03 Thread Huan Yang
Currently, udmabuf handles folio by creating an unpin list to record each folio obtained from the list and unpinning them when released. To maintain this approach, many data structures have been established. However, maintaining this type of data structure requires a significant amount of memory a

[PATCH v5 7/7] udmabuf: reuse folio array when pin folios

2024-09-03 Thread Huan Yang
When invoke memfd_pin_folios, we need offer an array to save each folio which we pinned. The currently way is dynamic alloc an array, get folios, save into udmabuf and then free. If the size is tiny, alloc from slab, is ok due to slab can cache it. Or, just PCP order can cover, also ok. But if s

Re: [PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:50, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 19:17写道: > > > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > > > Add the case to reserve multiple pair mixer for high resolution > > > > I think you already know what is missing here. > > Add the case to res

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-09-03 Thread Maxime Ripard
On Tue, Aug 06, 2024 at 05:26:21PM GMT, Daniel Vetter wrote: > On Tue, Aug 06, 2024 at 04:09:43PM +0200, Maxime Ripard wrote: > > On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > > > On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > > > > > > > On 01/07/2024 10:25,

Re: [PATCH 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-03 Thread Thomas Hellström
Hi, Christian, Thanks for reviewing. On Tue, 2024-09-03 at 09:49 +0200, Christian König wrote: > Am 02.09.24 um 17:41 schrieb Thomas Hellström: > > Resources of swapped objects remains on the TTM_PL_SYSTEM manager's > > LRU list, which is bad for the LRU walk efficiency. > > > > Rename the devic

Re: [PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:51, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 19:30写道: > > > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > > > Support 4 pipes and their configs at most. They are for 2 SSPP > > > and their multi-rect mode. Because one SSPP can co-work with > > > 2 mixe

Re: [PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:53, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 19:38写道: > > > > > @@ -1033,13 +1030,10 @@ static int dpu_plane_atomic_check(struct > > > drm_plane *plane, > > > return -E2BIG; > > > } > > > > > > - /* > > > -

Re: [PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-09-03 Thread Dmitry Baryshkov
On Tue, 3 Sept 2024 at 10:53, Jun Nie wrote: > > Dmitry Baryshkov 于2024年8月29日周四 19:51写道: > > > > On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > > > > > Blend pipes by left and right. The first 2 pipes are for > > > left half screen and the later 2 pipes are for right in quad > > > pipe case. >

Re: [PATCH -next v2] drm/imagination: Use memdup_user() helper

2024-09-03 Thread Matt Coster
On 02/09/2024 17:09, Markus Elfring wrote: >>> Switching to memdup_user(), which combines kmalloc() and copy_from_user(), >>> and it can simplfy code. >> >> Applied, thanks! >> >> [1/1] drm/imagination: Use memdup_user() helper >> commit: 2872a57c7ad427d428c6d12e95e55b32bdc8e3b8 > > Do you f

Re: [PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions

2024-09-03 Thread Javier Martinez Canillas
Abhishek Tamboli writes: Hello Abhishek > Use the new mipi_dsi_*_multi wrapped function in hx83112a_on > and hx83112a_disable function. > IMO commit messages should explain why the change is needed and not just what the patch is changing (for this one can just look at the diffstat). > Signed-o

Re: [git pull] drm fixes for 6.11-rc6

2024-09-03 Thread Thomas Hellström
On Mon, 2024-09-02 at 12:33 +0200, Christian König wrote: > Am 02.09.24 um 11:32 schrieb Thomas Hellström: > > On Mon, 2024-09-02 at 08:13 +1000, Dave Airlie wrote: > > > On Fri, 30 Aug 2024 at 12:32, Linus Torvalds > > > wrote: > > > > On Fri, 30 Aug 2024 at 14:08, Dave Airlie > > > > wrote: > >

Re: [PATCH v4 2/3] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-09-03 Thread 胡俊光

Re: [v2] drm/imagination: Use memdup_user() helper

2024-09-03 Thread Markus Elfring
Switching to memdup_user(), which combines kmalloc() and copy_from_user(), and it can simplfy code. By the way: Would it have been nicer to avoid a typo anyhow in such a change description? >>> Applied, thanks! >>> >>> [1/1] drm/imagination: Use memdup_user() helper >>> commit: 2

[RFC PATCH] drm/sched: Fix teardown leaks with waitqueue

2024-09-03 Thread Philipp Stanner
The GPU scheduler currently does not ensure that its pending_list is empty before performing various other teardown tasks in drm_sched_fini(). If there are still jobs in the pending_list, this is problematic because after scheduler teardown, no one will call backend_ops.free_job() anymore. This wo

[RFC PATCH] drm/sched: Fix teardown leaks with refcounting

2024-09-03 Thread Philipp Stanner
The GPU scheduler currently does not ensure that its pending_list is empty before performing various other teardown tasks in drm_sched_fini(). If there are still jobs in the pending_list, this is problematic because after scheduler teardown, no one will call backend_ops.free_job() anymore. This wo

[PATCH v2 0/2] drm/ttm: Really use a separate LRU list for swapped- and pinned objects

2024-09-03 Thread Thomas Hellström
Resources of swapped objects were never moved off their LRU list when swapped, and also resources of pinned objects might remain on their LRU list unless the driver moved them to the device pinned list after pinning. Rename the device "pinned" list to "unevictable" and ensure that resources of obj

[PATCH v2 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-03 Thread Thomas Hellström
Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide "pinned" list to "unevictable" and move also resources of swapped-out objects to that list. An alternative would be to create an "UNEVICTABLE" priority to

[PATCH v2 2/2] drm/ttm: Move pinned objects off LRU lists when pinning

2024-09-03 Thread Thomas Hellström
The ttm_bo_pin() and ttm_bo_unpin() functions weren't moving their resources off the LRU list to the unevictable list. Make sure that happens so that pinned objects don't accidently linger on the LRU lists, and also make sure to move them back once they are unpinned. v2: - Removing from a bulk mo

Re: WARNING: CPU: 0 PID: 8 at drivers/video/fbdev/core/fbmem.c:467 unregister_framebuffer+0x45/0x160

2024-09-03 Thread V, Narasimhan
[AMD Official Use Only - AMD Internal Distribution Only] Hi, From: Helge Deller Sent: Tuesday, September 3, 2024 01:48 AM To: V, Narasimhan; Thomas Zimmermann Cc: Linux Next Mailing List; Daniel Vetter; linux-fb...@vger.kernel.org; dri-devel@lists.freed

Re: WARNING: CPU: 0 PID: 8 at drivers/video/fbdev/core/fbmem.c:467 unregister_framebuffer+0x45/0x160

2024-09-03 Thread Helge Deller
On 9/3/24 11:56, V, Narasimhan wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi, From: Helge Deller Sent: Tuesday, September 3, 2024 01:48 AM To: V, Narasimhan; Thomas Zimmermann Cc: Linux Next Mailing List; Daniel Vetter; linux-fb...

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Marijn Suijten
On 2024-08-29 18:17:32, Jun Nie wrote: > Data width for dsc engine is aligned with pipe, not with whole screen > width. Because the width may be halved in DSI bonded case. > > The dsc width is not related to the timing with back front porch in > later stage, so update dsc timing earlier. > > Sign

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Call vga_switcheroo_client_fb_set() with the PCI device from the > instance of struct fb_info. All fbdev clients now run these calls. > For non-PCI devices or drivers without vga-switcheroo, this does > nothing. For i915 and radeon, it allows these drive

Re: [PATCH v3 03/81] drm/fbdev: Add memory-agnostic fbdev client

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add an fbdev client that can work with any memory manager. The > client implementation is the same as existing code in fbdev-dma or > fbdev-shmem. > > Provide struct drm_driver.fbdev_probe for the new client to allocate > the surface GEM buffer. The new callback replac

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Thomas Zimmermann
Hi Javier Am 03.09.24 um 12:18 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Call vga_switcheroo_client_fb_set() with the PCI device from the instance of struct fb_info. All fbdev clients now run these calls. For non-PCI devices or drivers without vga-switcheroo,

Re: [PATCH v2 0/8] DRM Rust abstractions and Nova

2024-09-03 Thread Simona Vetter
On Mon, Sep 02, 2024 at 06:40:00PM +0200, Daniel Vetter wrote: > On Wed, Jun 19, 2024 at 01:31:36AM +0200, Danilo Krummrich wrote: > > This patch series implements some basic DRM Rust abstractions and a stub > > implementation of the Nova GPU driver. > > > > Nova is intended to be developed upstre

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-03 Thread Simona Vetter
On Mon, Sep 02, 2024 at 04:18:33PM +0200, Christian König wrote: > Am 02.09.24 um 15:23 schrieb Daniel Vetter: > > On Mon, Sep 02, 2024 at 12:43:45PM +0200, Christian König wrote: > > > Am 30.08.24 um 23:43 schrieb Matthew Brost: > > > > On Fri, Aug 30, 2024 at 10:14:18AM +0200, Christian König wro

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-09-03 Thread Simona Vetter
On Mon, Sep 02, 2024 at 10:20:07PM +, Matthew Brost wrote: > On Mon, Sep 02, 2024 at 02:48:55PM +0200, Daniel Vetter wrote: > > On Thu, Aug 29, 2024 at 10:12:53PM +, Matthew Brost wrote: > > > On Thu, Aug 29, 2024 at 01:02:54PM +0200, Daniel Vetter wrote: > > > > On Thu, Aug 29, 2024 at 11:

Re: [RFC PATCH] drm/sched: Make sure drm_sched_fence_ops don't vanish

2024-09-03 Thread Simona Vetter
On Sat, Aug 31, 2024 at 09:13:52AM +0200, Boris Brezillon wrote: > Hi Matthew, > > On Fri, 30 Aug 2024 22:28:19 + > Matthew Brost wrote: > > > On Fri, Aug 30, 2024 at 12:40:57PM +0200, Boris Brezillon wrote: > > > dma_fence objects created by drm_sched might hit other subsystems, which > > >

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-03 Thread Simona Vetter
On Mon, Sep 02, 2024 at 03:31:28PM +0300, Tomi Valkeinen wrote: > Hi, > > On 02/09/2024 13:50, Daniel Vetter wrote: > > On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: > > > > On 25/07/2024 14:28, M

Re: [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and reimplement the old fb_probe callback on top of it. Provide an > initializer macro for struct drm_driver that sets the callback > according to the kernel configuration. > > This change allows the co

Re: [PATCH v2 3/8] rust: drm: add driver abstractions

2024-09-03 Thread Danilo Krummrich
On Mon, Sep 02, 2024 at 06:29:06PM +0200, Daniel Vetter wrote: > On Wed, Jun 19, 2024 at 01:31:39AM +0200, Danilo Krummrich wrote: > > Implement the DRM driver abstractions. > > > > The `Driver` trait provides the interface to the actual driver to fill > > in the driver specific data, such as the

Re: [PATCH v3 06/81] drm/arcgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fourcc() > > Signed-off-by: Thomas Zimmerma

Re: [PATCH v3 10/81] drm/aspeed: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The aspeed driver specifies a preferred color mode of 32. As this > is the default if no

Re: [PATCH v2 3/8] rust: drm: add driver abstractions

2024-09-03 Thread Asahi Lina
On 9/3/24 1:29 AM, Daniel Vetter wrote: > On Wed, Jun 19, 2024 at 01:31:39AM +0200, Danilo Krummrich wrote: >> Implement the DRM driver abstractions. >> >> The `Driver` trait provides the interface to the actual driver to fill >> in the driver specific data, such as the `DriverInfo`, driver feat

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-03 Thread Simona Vetter
On Tue, Sep 03, 2024 at 11:27:23AM +0300, Tomi Valkeinen wrote: > On 03/09/2024 10:40, Simona Vetter wrote: > > On Mon, Sep 02, 2024 at 03:31:28PM +0300, Tomi Valkeinen wrote: > > > Hi, > > > > > > On 02/09/2024 13:50, Daniel Vetter wrote: > > > > On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime R

Re: [PATCH v3 12/81] drm/fsl-dcu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Stefan Agner > Cc: Alison Wang

Re: [PATCH v2 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-09-03 Thread Danilo Krummrich
On Mon, Sep 02, 2024 at 06:15:42PM +0200, Daniel Vetter wrote: > On Wed, Jun 19, 2024 at 01:31:37AM +0200, Danilo Krummrich wrote: > > From: Asahi Lina > > > > DRM drivers need to be able to declare which driver-specific ioctls they > > support. Add an abstraction implementing the required types

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier > > Am 03.09.24 um 12:18 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >>> Call vga_switcheroo_client_fb_set() with the PCI device from the >>> instance of struct fb_info. All fbdev clients now run these calls. >>> For

Re: [PATCH v3 14/81] drm/hx8357d: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/hx8357d.c | 4 +++- > 1 f

Re: [PATCH v3 15/81] drm/ili9163: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ili9163.c | 4 +++- > 1 f

Re: [PATCH v4 0/2] Add Add elan-ekth6a12nay on the basis of elan-ekth6915

2024-09-03 Thread Jiri Kosina
On Thu, 22 Aug 2024, Jiri Kosina wrote: > > Jiri / Ben, > [ ... snip ... ] > > I think this series is ready for you to merge at your leisure. If > > there's anything blocking it then please yell. Thanks! :-) > > Hmm, for some reason the only mentions of this series in my inbox are your > Reviewe

Re: [PATCH v3 17/81] drm/ili9341: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ili9341.c | 4 +++- > 1 f

Re: [PATCH v3 18/81] drm/ili9486: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Kamlesh Gurudasani > --- > drivers/gpu/drm/tiny

Re: [PATCH v3 19/81] drm/imx/dcss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The dcss driver specifies a preferred color mode of 32. As this > is the default if no fo

Re: [PATCH v3 20/81] drm/imx/ipuv3: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Philipp Zabel > Cc: Shawn Guo >

Re: [PATCH v3 21/81] drm/imx/lcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-09-03 Thread Simona Vetter
On Tue, Sep 03, 2024 at 10:53:17AM +0200, Maxime Ripard wrote: > On Tue, Aug 06, 2024 at 05:26:21PM GMT, Daniel Vetter wrote: > > On Tue, Aug 06, 2024 at 04:09:43PM +0200, Maxime Ripard wrote: > > > On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > > > > On Mon, Jul 01, 2024 at 06:01:4

Re: [PATCH v3 23/81] drm/kmb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Anitha Chrisanthus > Cc: Edmund Dea > --- > dr

Re: [PATCH v3 24/81] drm/logicvc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The logicvc driver specifies a preferred color mode from the value > in struct drm_mode_c

Re: [PATCH v3 25/81] drm/mcde: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The mcde driver specifies a preferred color mode of 32. As this > is the default if no fo

Re: [PATCH v3 29/81] drm/mxsfb/lcdif: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The lcdif driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 30/81] drm/mxsfb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The mxsfb driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 33/81] drm/pl111: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/pl111/pl111_dr

Re: [PATCH v3 39/81] drm/sti: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The sti driver specifies a preferred color mode of 32. As this > is the default if no for

Re: [PATCH v3 41/81] drm/sun4i: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The sun4i driver specifies as preferred color mode of 32. As this > is the default if no

Re: [PATCH v3 42/81] drm/tidss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The tidss driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimm

Re: [PATCH v3 49/81] drm/fbdev-dma: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The old setup function drm_fbdev_dma_setup() is unused. Remove it and > its internal callbacks. New drivers should call drm_client_setup() > instead. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_fbdev_dma.c | 120 +--- >

Re: [PATCH v3 50/81] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and reimplement the old fb_probe callback on top of it. Provide an > initializer macro for struct drm_driver that sets the callback > according to the kernel configuration. > > This change allows the co

Re: [PATCH v4 03/18] usb: typec: Stub out typec_switch APIs when CONFIG_TYPEC=n

2024-09-03 Thread Heikki Krogerus
On Sat, Aug 31, 2024 at 09:06:41PM -0700, Stephen Boyd wrote: > Ease driver development by adding stubs for the typec_switch APIs when > CONFIG_TYPEC=n. Copy the same method used for the typec_mux APIs to be > consistent. > > Cc: Heikki Krogerus > Cc: Greg Kroah-Hartman > Cc: > Cc: Pin-yen Lin

Re: [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Thomas Zimmermann
Hi Am 03.09.24 um 13:08 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to t

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-03 Thread Maxime Ripard
On Mon, Sep 02, 2024 at 03:31:28PM GMT, Tomi Valkeinen wrote: > Hi, > > On 02/09/2024 13:50, Daniel Vetter wrote: > > On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: > > > > On 25/07/2024 14:28, Max

Re: [PATCH v4 04/18] usb: typec: Add device managed typec_mux_register()

2024-09-03 Thread Heikki Krogerus
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h > index efb5ed32b813..08431f0896d5 100644 > --- a/include/linux/usb/typec_mux.h > +++ b/include/linux/usb/typec_mux.h > @@ -99,6 +99,8 @@ int typec_mux_set(struct typec_mux *mux, struct > typec_mux_state *state); > > s

Re: [PATCH] drm/tegra: fix potential uninitialized variable use

2024-09-03 Thread Thierry Reding
On Mon, Sep 02, 2024 at 07:13:17PM GMT, Jani Nikula wrote: > It's likely either output->drm_edid or output->ddc is non-NULL, but > avoid the uninitialized variable usage anyway. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/r/ZtXLyXxew7z6H2bD@stanley.mountain > Fixes: 98365

Re: [PATCH v3 52/81] drm/cirrus: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The cirrus driver requests the same client pixel format as the value > stored in struct d

Re: [PATCH v3 53/81] drm/gm12u320: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede > --- > drivers/gpu/drm/tiny/gm12

Re: [PATCH v3 60/81] drm/udl: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Dave Airlie > Cc: Sean Paul > Cc: Thomas Zimmer

Re: [PATCH v3 61/81] drm/virtgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The virtgpu driver specifies a preferred color mode of 32. As this > is the default if no

Re: [PATCH v3 62/81] drm/vkms: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Rodrigo Siqueira > Cc: Melissa Wen > Cc: "Maíra

Re: [PATCH v3 63/81] drm/fbdev-shmem: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The old setup function drm_fbdev_shmem_setup() is unused. Remove it > and its internal callbacks. New drivers should call drm_client_setup() > instead. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_fbdev_shmem.c | 120 +-

  1   2   3   >