Re: [PATCH v2] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-13 Thread Heiko Stübner
Hi, Am Montag, 12. August 2024, 14:28:15 CEST schrieb Mary Guillemard: > Expose timestamp information supported by the GPU with a new device > query. > > Mali uses an external timer as GPU system time. On ARM, this is wired to > the generic arch timer so we wire cntfrq_el0 as device frequency. >

Re: [PATCH v4 1/3] drm: Add panel backlight quirks

2024-08-13 Thread Jani Nikula
On Mon, 12 Aug 2024, Thomas Weißschuh wrote: > Panels using a PWM-controlled backlight source without an do not have a > standard way to communicate their valid PWM ranges. > On x86 the ranges are read from ACPI through driver-specific tables. > The built-in ranges are not necessarily correct, or

Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

2024-08-13 Thread Luca Ceresoli
Hello Andi, On Thu, 8 Aug 2024 11:35:23 +0100 Andi Shyti wrote: > Hi Luca, > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luca Ceresoli wrote: > > When devm_drm_of_get_bridge() fails, the probe fails silently. Use > > dev_err_probe() instead to log an error or report the deferral reason, > > whi

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Andy Shevchenko
On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote: > On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: ... > > > +static int > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > > +{ > > > +

Re: [PATCH v2] gpu: ipu-v3: Add cleanup attribute for prg_node for auto cleanup

2024-08-13 Thread Shuah Khan
On 8/12/24 13:37, Abhinav Jain wrote: Hello, Can this be kindly reviewed? Thanks. You removed all the relevant information for people to be able to review the patch :) thanks, -- Shuah

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Mina Almasry
On Mon, Aug 12, 2024 at 8:15 PM Jakub Kicinski wrote: > BTW, Mina, the core should probably also check that XDP isn't installed > before / while the netmem is bound to a queue. Sorry if noob question, but what is the proper check for this? I tried adding this to net_devmem_bind_dmabuf_to_queue():

Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

2024-08-13 Thread Andy Shevchenko
On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote: > On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: > > On Mon, 22 Apr 2024, Andy Shevchenko > > wrote: > > > Update header inclusions to follow IWYU (Include What You Use) > > > principle. > > > > > > Signed-off-by: Andy

Re: [PATCH v2] gpu: ipu-v3: Add cleanup attribute for prg_node for auto cleanup

2024-08-13 Thread Abhinav Jain
On Tue, 13 Aug 2024 02:30:54 -0600, Shuah Khan wrote: > On 8/12/24 13:37, Abhinav Jain wrote: > > Hello, > > Can this be kindly reviewed? Thanks. > > You removed all the relevant information for people to be able to review the > patch :) > > thanks, > -- Shuah Sorry, here is the patch link and I a

[syzbot] Monthly dri report (Aug 2024)

2024-08-13 Thread syzbot
Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 1 new issues were detected and 0 were fixed. In total, 21 issues are still open and 31 have been

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Mina Almasry
On Tue, Aug 13, 2024 at 4:39 AM Mina Almasry wrote: > > On Mon, Aug 12, 2024 at 8:15 PM Jakub Kicinski wrote: > > BTW, Mina, the core should probably also check that XDP isn't installed > > before / while the netmem is bound to a queue. > > Sorry if noob question, but what is the proper check for

[PATCH v3 0/5] udmbuf bug fix and some improvements

2024-08-13 Thread Huan Yang
This patchset attempts to fix some errors in udmabuf and remove the upin_list structure. Some of this fix just gather the patches which I upload before. Patch 1,2,4,5 has passed the udmabuf self-test suite's tests. Suggested by Kasireddy, Vivek Patch5 modified the unpin function, therefore runni

[PATCH v3 3/5] fix vmap_udmabuf error page set

2024-08-13 Thread Huan Yang
Currently vmap_udmabuf set page's array by each folio. But, ubuf->folios is only contain's the folio's head page. That mean we repeatedly mapped the folio head page to the vmalloc area. Due to udmabuf can use hugetlb, if HVO enabled, tail page may not exist, so, we can't use page array to map, in

[PATCH v3 1/5] udmabuf: cancel mmap page fault, direct map it

2024-08-13 Thread Huan Yang
The current udmabuf mmap uses a page fault to populate the vma. However, the current udmabuf has already obtained and pinned the folio upon completion of the creation.This means that the physical memory has already been acquired, rather than being accessed dynamically. The current page fault metho

[PATCH v3 5/5] udmabuf: remove udmabuf_folio

2024-08-13 Thread Huan Yang
Currently, udmabuf handles folio by creating an unpin list to record each folio obtained from the list and unpinning them when released. To maintain this approach, many data structures have been established. However, maintaining this type of data structure requires a significant amount of memory a

[PATCH v3 4/5] udmabuf: codestyle cleanup

2024-08-13 Thread Huan Yang
There are some variables in udmabuf_create that are only used inside the loop. Therefore, there is no need to declare them outside the scope. This patch moved it into loop. It is difficult to understand the loop condition of the code that adds folio to the unpin_list. The outer loop of this patch

[PATCH v3 2/5] udmabuf: change folios array from kmalloc to kvmalloc

2024-08-13 Thread Huan Yang
When PAGE_SIZE 4096, MAX_PAGE_ORDER 10, 64bit machine, page_alloc only support 4MB. If above this, trigger this warn and return NULL. udmabuf can change size limit, if change it to 3072(3GB), and then alloc 3GB udmabuf, will fail create. [ 4080.876581] [ cut here ] [ 4080.

Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-13 Thread Luca Ceresoli
Hello, On Fri, 09 Aug 2024 17:34:49 +0200 Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. > > Signed-off-by: Luca Ceresoli

Re: [PATCH v2 3/9] ASoC: test-component: use new of_graph functions

2024-08-13 Thread Mark Brown
On Fri, Aug 09, 2024 at 04:22:38AM +, Kuninori Morimoto wrote: > Current test-component.c is using for_each_endpoint_of_node() > for parsing "port", because there was no "port" base loop before. > It has been assuming 1 port has 1 endpoint here. Acked-by: Mark Brown signature.asc Descriptio

Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-13 Thread Krzysztof Kozlowski
On 13/08/2024 05:44, Frank Li wrote: > On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote: >> On 08/13/2024, Frank Li wrote: >>> Replace additionalProperties with unevaluatedProperties because it ref to >>> panel-common.yaml. >> >> This would allow all properties in panel-common.yaml, which i

[PATCH v1 1/1] drm/panel: ili9341: Remove duplicate code

2024-08-13 Thread Andy Shevchenko
Remove duplicate code that is handled by tinyDRM, i.e. drivers/gpu/drm/tiny/ili9341.c. Suggested-by: Maxime Ripard Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 210 +-- 1 file changed, 3 insertions(+), 207 deletions(-) diff --git a/drivers/g

[PATCH] drm/bridge: lontium-lt8912b: Validate mode in drm_bridge_funcs::mode_valid()

2024-08-13 Thread Liu Ying
If the bridge is attached with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set, this driver won't initialize a connector and hence display mode won't be validated in drm_connector_helper_funcs::mode_valid(). So, move the mode validation from drm_connector_helper_funcs::mode_valid() to drm_bridge_funcs

Re: [RFC PATCH] ARM: dts: imx53-qsb: Add MCIMX-LVDS1 display module support

2024-08-13 Thread Liu Ying
On 07/30/2024, Liu Ying wrote: > On 07/29/2024, Liu Ying wrote: >> Hi Dmitry, >> >> On 07/27/2024, Dmitry Baryshkov wrote: >>> On Fri, Jul 26, 2024 at 02:50:12PM GMT, Liu Ying wrote: MCIMX-LVDS1[1] display module integrates a HannStar HSD100PXN1 LVDS display panel and a touch IC. Add an

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-08-13 Thread Greg KH
On Mon, Aug 05, 2024 at 04:36:28PM +0530, Abhishek Singh wrote: > > On 7/30/2024 12:46 PM, Greg KH wrote: > > On Tue, Jul 30, 2024 at 12:39:45PM +0530, Abhishek Singh wrote: > >> The user process on ARM closes the device node while closing the > >> session, triggers a remote call to terminate the

[PATCH] drm/buddy: fix issue that force_merge cannot free all roots

2024-08-13 Thread Lin . Cao
If buddy manager have more than one roots and each root have sub-block need to be free. When drm_buddy_fini called, the first loop of force_merge will merge and free all of the sub block of first root, which offset is 0x0 and size is biggest(more than have of the mm size). In subsequent force_merge

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Tue, Aug 13, 2024 at 11:27:22AM +0300, Andy Shevchenko wrote: > On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote: > > On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote: > > > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: > > ... > > > > > +static int > > >

[PATCH 2/2] drm/v3d: Appease lockdep while updating GPU stats

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Lockdep thinks our seqcount_t usage is unsafe because the update path can be both from irq and worker context: [ ] [ ] WARNING: inconsistent lock state [ ] 6.10.3-v8-16k-numa #159 Tainted: GWC [ ]

[PATCH 1/2] drm/v3d: Disable preemption while updating GPU stats

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We forgot to disable preemption around the write_seqcount_begin/end() pair while updating GPU stats: [ ] WARNING: CPU: 2 PID: 12 at include/linux/seqlock.h:221 __seqprop_assert.isra.0+0x128/0x150 [v3d] [ ] Workqueue: v3d_bin drm_sched_run_job_work [gpu_sched] <...snip.

Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

2024-08-13 Thread Jani Nikula
On Tue, 13 Aug 2024, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote: >> On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: >> > On Mon, 22 Apr 2024, Andy Shevchenko >> > wrote: >> > > Update header inclusions to follow IWYU (Include What You Us

Re: [PATCH 2/2] drm/v3d: Appease lockdep while updating GPU stats

2024-08-13 Thread Tvrtko Ursulin
On 12/08/2024 16:27, Maíra Canal wrote: Hi Tvrtko, On 8/12/24 06:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Lockdep thinks our seqcount_t usage is unsafe because the update path can be both from irq and worker context:   [ ]   [ ] WARNING: inconsistent

Re: [RFC] Adds support for ConfigFS to VKMS!

2024-08-13 Thread José Expósito
Hi Louis, On Fri, Aug 09, 2024 at 07:59:49PM +0200, Louis Chauvet wrote: > Hi everyone, > > I'm excited to share some good news! I've recently completed the addition > of a ConfigFS interface to VKMS, which allows to configure VKMS from > user-space, at runtime. You should be able to: > - Creat

[RFC PATCH 00/17] VKMS: Add configfs support

2024-08-13 Thread José Expósito
Hi everyone, This RFC implements support to configure VKMS using configfs. It allows to: - Create multiple devices - Configure multiple overlay planes, CRTCs, encoders and connectors - Enable or disable cursor plane and writeback connector for each CRTC - Hot-plug/unplug connectors afte

[RFC PATCH 02/17] drm/vkms: Move default_config creation to its own function

2024-08-13 Thread José Expósito
Extract the initialization of the default configuration to a function. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 17 + drivers/gpu/drm/vkms/vkms_config.h | 3 +++ drivers/gpu/drm/vkms/vkms_drv.c| 6 +- 3 files

[RFC PATCH 01/17] drm/vkms: Extract vkms_config header

2024-08-13 Thread José Expósito
Creating a new vkms_config structure will be more complex once we start adding more options. Extract the vkms_config structure to its own header and source files and add functions to create and delete a vkms_config and to initialize debugfs. Refactor, no functional changes. Signed-off-by: José E

[RFC PATCH 03/17] drm/vkms: Set device name from vkms_config

2024-08-13 Thread José Expósito
In order to be able to create multiple devices, the device name needs to be unique. Allow to set it in the VKMS configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 7 +-- drivers/gpu/drm/vkms/vkms_config.h | 3 ++- drivers/gpu/drm/vkms/vkms_drv.c| 2 +-

[RFC PATCH 05/17] drm/vkms: Use managed memory to create encoders

2024-08-13 Thread José Expósito
A future patch will allow to create multiple encoders. Use managed memory to simplify the code. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.h| 1 - drivers/gpu/drm/vkms/vkms_output.c | 45 -- 2 files changed, 3

[RFC PATCH 04/17] drm/vkms: Allow to configure multiple CRTCs

2024-08-13 Thread José Expósito
Add a list of CRTC configurations to vkms_config and add as many CRTCs as configured during output initialization. For backwards compatibility, create a single CRTC in the default configuration. Since writeback support, vblank and composer states are now per CRTC, extract all the fields to the vk

[RFC PATCH 06/17] drm/vkms: Allow to configure multiple encoders

2024-08-13 Thread José Expósito
Add a list of encoder configurations to vkms_config and add as many encoders as configured during output initialization. For backwards compatibility, create a single encoder in the default configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 50 ++

[RFC PATCH 07/17] drm/vkms: Use managed memory to create connectors

2024-08-13 Thread José Expósito
A future patch will allow to create multiple connectors. Use managed memory to simplify the code. Refactor, no functional changes. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.h| 5 --- drivers/gpu/drm/vkms/vkms_output.c | 53 +- 2 files change

[RFC PATCH 09/17] drm/vkms: Allow to configure multiple overlay planes

2024-08-13 Thread José Expósito
Add a list of overlay planes to vkms_config and add as many overlay planes as configured during output initialization. For backwards compatibility, add NUM_OVERLAY_PLANES to the default configuration. Note that a primary plane is created for each CRTC and it is not possible to configure it. A cur

[RFC PATCH 08/17] drm/vkms: Allow to configure multiple connectors

2024-08-13 Thread José Expósito
Add a list of connector configurations to vkms_config and add as many connector as configured during output initialization. For backwards compatibility, create a single connector in the default configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 40 +

[RFC PATCH 13/17] drm/vkms: Allow to configure multiple encoders via configfs

2024-08-13 Thread José Expósito
Create a default subgroup at /config/vkms/encoders to allow to create as many encoders as required. When the encoder is created the possible_crtcs subgroup is created allowing to link encoders and CRTCs. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 14 ++- drivers/gpu

[RFC PATCH 11/17] drm/vkms: Add and remove VKMS instances via configfs

2024-08-13 Thread José Expósito
Allow to create, enable, disable and destroy VKMS instances using configfs. For the moment, add one primary plane, one CRC, one encoder and one connector until we add support to configure them via configfs. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 32 + drive

[RFC PATCH 12/17] drm/vkms: Allow to configure multiple CRTCs via configfs

2024-08-13 Thread José Expósito
Create a default subgroup at /config/vkms/crtcs to allow to create as many CRTCs as required. When a CRTC is created, allow to configure the equivalent of the module parameters enable_cursor and enable_writeback. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 22 +++- d

[RFC PATCH 16/17] drm/vkms: Allow to configure the default device creation

2024-08-13 Thread José Expósito
Add a new module param to allow to create or not the default VKMS instance. Useful when combined with configfs to avoid having additional VKMS instances. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --gi

[RFC PATCH 17/17] drm/vkms: Remove completed task from the TODO list

2024-08-13 Thread José Expósito
Remove the configfs related TODO items from the "Runtime Configuration" section. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index ee71d1a569dd.

[RFC PATCH 15/17] drm/vkms: Allow to configure multiple planes via configfs

2024-08-13 Thread José Expósito
Create a default subgroup at /config/vkms/planes to allow to create as many overlay planes as required. When the plane is created the possible_crtcs subgroup is created allowing to link planes and CRTCs. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 13 ++- drivers/gpu

[RFC PATCH 10/17] drm/vkms: Allow to change connector status

2024-08-13 Thread José Expósito
Store the connector status in vkms_config_connector and use the stored value to update the connector status in the drm_connector_funcs.detect() function. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_config.c | 18 -- drivers/gpu/drm/vkms/vkms_config.h | 12 +

[RFC PATCH 14/17] drm/vkms: Allow to configure multiple encoders

2024-08-13 Thread José Expósito
Add a list of encoder configurations to vkms_config and add as many encoders as configured during output initialization. For backwards compatibility, create a single encoder in the default configuration. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 16 +++ drivers/gp

Re: State of affairs with Ilitek 9341 support

2024-08-13 Thread Andy Shevchenko
On Sat, Dec 23, 2023 at 11:00:32AM +0800, Dillon Min wrote: > On Mon, 11 Dec 2023 at 21:19, Andy Shevchenko > wrote: > > On Fri, Dec 08, 2023 at 09:18:20PM +0100, Noralf Trønnes wrote: > > > On 12/8/23 17:00, Andy Shevchenko wrote: > > > > Included authors and latest (non-white-space) contributor

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > + /* > > +* HW register value is accumulated count of pulses from > > +* PWM fan with the scale of 2 pulses per rotation. > > +*/ > > + rotations = p

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Andy Shevchenko
On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: ... > > > + /* > > > + * HW register value is accumulated count of pulses from > > > + * PWM fan with th

[PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n

2024-08-13 Thread Jani Nikula
The fault-inject.h users across the kernel need to add a lot of #ifdef CONFIG_FAULT_INJECTION to cater for shortcomings in the header. Make fault-inject.h self-contained for CONFIG_FAULT_INJECTION=n, and add stubs for DECLARE_FAULT_ATTR(), setup_fault_attr(), should_fail_ex(), and should_fail() to

[PATCH 2/3] drm/msm: clean up fault injection usage

2024-08-13 Thread Jani Nikula
With the proper stubs in place in linux/fault-inject.h, we can remove a bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. Cc: Andrew Morton Cc: Akinobu Mita Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/msm_debugfs.c | 2

[PATCH 3/3] drm/xe: clean up fault injection usage

2024-08-13 Thread Jani Nikula
With the proper stubs in place in linux/fault-inject.h, we can remove a bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. Cc: Andrew Morton Cc: Akinobu Mita Cc: Lucas De Marchi Cc: Thomas Hellström Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_debugfs.c

Re: [PATCH 2/3] drm/msm: clean up fault injection usage

2024-08-13 Thread Thomas Hellström
On Tue, 2024-08-13 at 15:12 +0300, Jani Nikula wrote: > With the proper stubs in place in linux/fault-inject.h, we can remove > a > bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. > > Cc: Andrew Morton > Cc: Akinobu Mita > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov

Re: [PATCH 3/3] drm/xe: clean up fault injection usage

2024-08-13 Thread Thomas Hellström
On Tue, 2024-08-13 at 15:12 +0300, Jani Nikula wrote: > With the proper stubs in place in linux/fault-inject.h, we can remove > a > bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. > > Cc: Andrew Morton > Cc: Akinobu Mita > Cc: Lucas De Marchi > Cc: Thomas Hellström > Cc: Rodrigo

Re: [PATCH 3/3] drm/xe: clean up fault injection usage

2024-08-13 Thread Ghimiray, Himal Prasad
On 13-08-2024 17:42, Jani Nikula wrote: With the proper stubs in place in linux/fault-inject.h, we can remove a bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. Cc: Andrew Morton Cc: Akinobu Mita Cc: Lucas De Marchi Cc: Thomas Hellström Cc: Rodrigo Vivi Signed-off-by: Jani

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote: > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > ... > > > > > + /* > > >

Re: [PATCH 2/3] drm/msm: clean up fault injection usage

2024-08-13 Thread Ghimiray, Himal Prasad
On 13-08-2024 17:42, Jani Nikula wrote: With the proper stubs in place in linux/fault-inject.h, we can remove a bunch of conditional compilation for CONFIG_FAULT_INJECTION=n. Cc: Andrew Morton Cc: Akinobu Mita Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Signed-off-by: Jani Nikul

Re: [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n

2024-08-13 Thread Ghimiray, Himal Prasad
On 13-08-2024 17:42, Jani Nikula wrote: The fault-inject.h users across the kernel need to add a lot of #ifdef CONFIG_FAULT_INJECTION to cater for shortcomings in the header. Make fault-inject.h self-contained for CONFIG_FAULT_INJECTION=n, and add stubs for DECLARE_FAULT_ATTR(), setup_fault_at

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Andy Shevchenko
On Tue, Aug 13, 2024 at 03:53:25PM +0300, Raag Jadav wrote: > On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > > On Fri, Aug 09, 2024 at 11:45

Re: [PATCH v3 0/5] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-08-13 Thread Heiko Stübner
Am Mittwoch, 7. August 2024, 13:07:22 CEST schrieb Cristian Ciocaltea: > The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI > 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite > different from those used in the previous generations of Rockchip SoCs. > > The cont

Re: [PATCH v2 3/9] drm/ast: astdp: Use struct drm_edid and helpers

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Convert ASTDP support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the re

Re: [PATCH v2 4/9] drm/ast: astdp: Transparently handle BMC support

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still generate

Re: [PATCH v2 6/9] drm/ast: dp501: Transparently handle BMC support

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still gener

Re: [PATCH v2 7/9] drm/ast: sil164: Transparently handle BMC support

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still gener

Re: [PATCH v2 8/9] drm/ast: vga: Transparently handle BMC support

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Permanently set the connector status to 'connected'. Return BMC modes for connector if no display is attached to the physical DP connector. Otherwise use EDID modes as before. If the status of the physical connector changes, the driver still gener

Re: [PATCH v2 9/9] drm/ast: Remove BMC output

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Ast's BMC connector tracks the status of an underlying physical connector and updates the BMC status accordingly. This functionality works around GNOME's settings app, which cannot handle multiple outputs on the same CRTC. The workaround is now ob

Re: [PATCH v2 5/9] drm/ast: dp501: Use struct drm_edid and helpers

2024-08-13 Thread Jocelyn Falempe
On 12/08/2024 11:30, Thomas Zimmermann wrote: Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Raag Jadav
On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: > > On 12/08/24 13:18, Raag Jadav wrote: > > From: Himal Prasad Ghimiray > > > > This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset > > uevent for now") as part of refactoring. > > > > Now that we have better uap

Re: [PATCH v2 9/9] drm/ast: Remove BMC output

2024-08-13 Thread Thomas Zimmermann
Hi Am 13.08.24 um 15:20 schrieb Jocelyn Falempe: On 12/08/2024 11:30, Thomas Zimmermann wrote: Ast's BMC connector tracks the status of an underlying physical connector and updates the BMC status accordingly. This functionality works around GNOME's settings app, which cannot handle multiple o

[PATCH 2/2] drm/amdgpu: Use drm_print_memory_stats helper from fdinfo

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo memory stats to use the common drm_print_memory_stats helper. This achieves alignment with the common keys as documented in drm-usage-stats.rst, adding specifically drm-total- key the driver was missing until now. Additionally I made the code stop skipping to

[PATCH 0/2] DRM fdinfo legacy drm-memory- clarification and amdgpu update

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Re-sending these two since they garnered little attention last time round. First patch clarifies what drm-memory- is, and that it is legacy, and second patch updates amdgpu to start emitting new keys together with the legacy (by using the common DRM helper). With that gputo

[PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the current resident buffer object memory (including shared). To prevent any confusion, document that drm-memo

[PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_cs_ioctl()

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that inside amdgpu_cs_parser_init() there is a second memset to clear the same on stack struct amdgpu_cs_parser. If we pull this memset one level out,

[PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_vm_pt_clear()

2024-08-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that later in amdgpu_vm_pt_clear() there is a second memset to clear the same on stack struct amdgpu_vm_update_params. If we replace this memset with

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > > > Hi Daniel, > > > > > > On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote: > > > > On Fri

Re: [PATCH] drm/amdgpu: Remove hidden double memset from amdgpu_vm_pt_clear()

2024-08-13 Thread Tvrtko Ursulin
On 13/08/2024 15:08, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When CONFIG_INIT_STACK_ALL_ZERO is set and so -ftrivial-auto-var-init=zero compiler option active, compiler fails to notice that later in amdgpu_vm_pt_clear() there is a second memset to clear the same on stack struct amdgpu_vm_

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jani Nikula
On Mon, 12 Aug 2024, Jani Nikula wrote: > On Mon, 12 Aug 2024, Jocelyn Falempe wrote: >> On 12/08/2024 15:49, Jani Nikula wrote: >>> On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the re

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Lucas De Marchi
On Mon, Aug 12, 2024 at 01:18:12PM GMT, Raag Jadav wrote: From: Himal Prasad Ghimiray This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have better uapi semantics and naming for the uevent, bring it back. With this in place

Re: [PATCH] drm/hisilicon: Remove unused delarations

2024-08-13 Thread Thomas Zimmermann
Am 12.08.24 um 14:35 schrieb Zhang Zekun: hibmc_mm_init() has been removed since commit 28645ae064d1 ("drm/hisilicon/hibmc: Remove hibmc_ttm.c"), but remain the declaration untouched in the header files. So, let's remove this unused declaration. Signed-off-by: Zhang Zekun Reviewed-by: Thom

Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

2024-08-13 Thread Andi Shyti
Hi Luca, On Tue, Aug 13, 2024 at 10:16:43AM +0200, Luca Ceresoli wrote: > On Thu, 8 Aug 2024 11:35:23 +0100 > Andi Shyti wrote: > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luca Ceresoli wrote: > > > When devm_drm_of_get_bridge() fails, the probe fails silently. Use > > > dev_err_probe() instead

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 04:39:47 -0400 Mina Almasry wrote: > On Mon, Aug 12, 2024 at 8:15 PM Jakub Kicinski wrote: > > BTW, Mina, the core should probably also check that XDP isn't installed > > before / while the netmem is bound to a queue. > > Sorry if noob question, but what is the proper check

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-13 Thread Jocelyn Falempe
On 13/08/2024 16:11, Jani Nikula wrote: On Mon, 12 Aug 2024, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: On 12/08/2024 15:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but th

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: > I'm getting lost, so repeating myself a bit. What I think > would be a good approach is if we get an error back from > the driver if it doesn't support netiov / providers. > > netdev_rx_queue_restart() { > ... > err = dev->queu

Re: [PATCH v3 0/5] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-08-13 Thread Cristian Ciocaltea
On 8/13/24 4:17 PM, Heiko Stübner wrote: > Am Mittwoch, 7. August 2024, 13:07:22 CEST schrieb Cristian Ciocaltea: >> The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI >> 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite >> different from those used in the previo

[PATCH v2 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true

2024-08-13 Thread Frank Li
Add property panel-timing: true to allow use 'panel-timing', which defined in panel-common.yaml. Fix below warning: arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetr

Re: [PATCH 6/6] drm/amdgpu: Re-validate evicted buffers v2

2024-08-13 Thread Tvrtko Ursulin
I was waiting for some replies elsewhere on this thread. Anwyay.. for the below, because I don't understand how come an important fix like this is not garnering more attention: On 04/06/2024 17:05, Christian König wrote: From: Tvrtko Ursulin Since you pretty much changed my logic you cou

Re: [PATCH] drm/edid: add non-desktop quirk to Pimax VR Headsets

2024-08-13 Thread Jani Nikula
On Thu, 25 Jul 2024, Sefa Eyeoglu wrote: > Hi Jani, > > I have asked someone with the actual hardware to attach their EDID blob > to the issue. There's only one so far, but that one does require the quirk. Acked-by: Jani Nikula > > Kind regards, > Sefa > > On Wed, 2024-07-24 at 10:22 +0300,

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Pavel Begunkov
On 8/13/24 15:39, Jakub Kicinski wrote: On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: I'm getting lost, so repeating myself a bit. What I think would be a good approach is if we get an error back from the driver if it doesn't support netiov / providers. netdev_rx_queue_restart() {

Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-13 Thread Rob Herring
On Fri, Aug 09, 2024 at 05:34:49PM +0200, Luca Ceresoli wrote: > Add bindings for the GE SUNH add-on connector. This is a physical, > hot-pluggable connector that allows to attach and detach at runtime an > add-on adding peripherals on non-discoverable busses. Overall, looks pretty good. > > Sig

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2024 16:11:15 +0100 Pavel Begunkov wrote: > On 8/13/24 15:39, Jakub Kicinski wrote: > > On Tue, 13 Aug 2024 03:31:13 +0100 Pavel Begunkov wrote: > >> I'm getting lost, so repeating myself a bit. What I think > >> would be a good approach is if we get an error back from > >> the dri

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2024-08-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Feicop1 (bofomol...@givehit.com) changed: What|Removed |Added CC||bofomol...@givehit.com

Re: [PATCH v3 1/4] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-08-13 Thread Rob Herring
On Mon, Aug 05, 2024 at 04:52:35PM +0100, Biju Das wrote: > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > SoC, but has only DPI interface. > > While at it, add missing required property port@1 for RZ/G2L and RZ/V2L > SoCs. Currently there is no user for the DPI interface

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: > On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: > > > > On 12/08/24 13:18, Raag Jadav wrote: > > > From: Himal Prasad Ghimiray > > > > > > This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset > > > ue

Re: [PATCH] drm/vmwgfx: Limit display layout ioctl array size to VMWGFX_NUM_DISPLAY_UNITS

2024-08-13 Thread Zack Rusin
On Thu, Aug 8, 2024 at 4:06 PM Ian Forbes wrote: > > Currently the array size is only limited by the largest kmalloc size which > is incorrect. This change will also return a more specific error message > than ENOMEM to userspace. > > Signed-off-by: Ian Forbes > --- > drivers/gpu/drm/vmwgfx/vmwg

Re: [PATCH] drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

2024-08-13 Thread Zack Rusin
On Fri, Aug 9, 2024 at 2:38 PM Ian Forbes wrote: > > Handle unlikely ENOMEN condition and other errors in > vmw_stdu_connector_atomic_check. > > Signed-off-by: Ian Forbes > Reported-by: Dan Carpenter > Fixes: 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves") > --- > drivers/g

[PULL] drm-intel-next

2024-08-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first drm-intel-next PR towards 6.12. drm-intel-next-2024-08-13: - Type-C programming fix for MTL+ (Gustavo) - Fix display clock workaround (Mitul) - Fix DP LTTPR detection (Imre) - Calculate vblank delay more accurately (Ville) - Make vrr_{enabling,disabling}(

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Ian Forbes
Remove `busy_places` now that it's unused. There's also probably a better place to put `map_count` in the struct layout to avoid false sharing with `cpu_writers`. I'd repack the whole struct if we're going to be adding and removing fields.

Re: [PATCH 1/2] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-13 Thread Zack Rusin
On Tue, Aug 13, 2024 at 1:29 PM Ian Forbes wrote: > > Remove `busy_places` now that it's unused. There's also probably a > better place to put `map_count` in the struct layout to avoid false > sharing with `cpu_writers`. I'd repack the whole struct if we're going > to be adding and removing fields

  1   2   >