[PULL] drm-misc-next

2024-08-09 Thread Thomas Zimmermann
Hi Dave, Sima, here's a fairly small PR for drm-misc-next for this this week. The controversial Power Saving Policy has been removed. Mgag200 finally has good support for the BMC output. CI added some more drivers. Best regards Thomas drm-misc-next-2024-08-09: drm-misc-next for v6.12: UAPI Chan

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Dave Airlie
Hi Krzysztof, You might want to familiarise yourself with the drm tree development procedures before weighing in, and snarky comments like the final one are not appreciated on this list or in this community. The drm next trees are never rebased (only in super rare emergencies), we never rebase ne

Re: [PATCH 1/9] of: property: add of_graph_get_next_port()

2024-08-09 Thread Tomi Valkeinen
Hi, On 09/08/2024 05:10, Kuninori Morimoto wrote: Hi Tomi Thank you for your review +/** + * of_graph_get_next_ports() - get next ports node. + * @parent: pointer to the parent device node + * @ports: current ports node, or NULL to get first + * + * Return: A 'ports' node pointer with refco

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 09:13, Dave Airlie wrote: > Hi Krzysztof, > > You might want to familiarise yourself with the drm tree development > procedures before weighing in, > and snarky comments like the final one are not appreciated on this > list or in this community. > > The drm next trees are never reba

Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-08-09 Thread Simon Horman
On Tue, Aug 06, 2024 at 08:39:34AM -0400, Willem de Bruijn wrote: > Markus Elfring wrote: > > >> … > > >>> +++ b/include/net/devmem.h > > >>> @@ -0,0 +1,115 @@ > > >> … > > >>> +#ifndef _NET_DEVMEM_H > > >>> +#define _NET_DEVMEM_H > > >> … > > >> > > >> I suggest to omit leading underscores from su

Re: [PATCH v4] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-09 Thread 胡俊光

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Joonas Lahtinen
Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) > On 08/08/2024 20:35, Krzysztof Kozlowski wrote: > > On 08/08/2024 10:45, Tvrtko Ursulin wrote: > >> > >> Hi Dave, Sima, > >> > >> A small bunch of fixes for the weekly cycle: > > > > ... > > > >> > >>

Re: [PATCH 1/8] drm/fbdev-helper: Do delayed switcheroo in lastclose helper

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:33AM +0200, Thomas Zimmermann wrote: > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from the fbdev lastclose helper, > so that the driver functions can finally be removed. > > The fbdev call is part of all l

Re: [PATCH 4/8] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:36AM +0200, Thomas Zimmermann wrote: > The output_poll_changed hook was only necessary before in-kernel > DRM clients existed, but is now obsolete. The client code handles > display otplugging internally. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vett

Re: [PATCH 5/8] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:37AM +0200, Thomas Zimmermann wrote: > Replace the callto drm_fb_helper_output_poll_changed() with a call > to drm_client_dev_hotplug(). It's equivalent in functionality, but > use the DRM client infrastructure. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Dani

Re: [PATCH 6/8] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:38AM +0200, Thomas Zimmermann wrote: > The function is unused. Remove it. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Without the next patch to remove ->lastclose there's some confusion text left in the DOC: section in drm_fb_helper.c, but no p

Re: [PATCH 8/8] drm: Remove struct drm_mode_config_funcs.output_poll_changed

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:40AM +0200, Thomas Zimmermann wrote: > The output_poll_changed hook in struct drm_mode_config_funcs is > unused. Remove it. The helper drm_client_dev_hotplug() implements > the callback's functionality. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote: > Hi, > > This patch series concludes on the memory mapping fixes and > improvements by allowing partial memory mapping for the cpu > memory as well. > > The partial memory mapping by adding an object offset was > implicitely included in

Re: [PATCH v4] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-09 Thread 胡俊光

Re: [PATCH v2 5/5] drm/panic: Add panic description

2024-08-09 Thread Daniel Vetter
On Wed, Aug 07, 2024 at 03:36:14PM +0200, Jocelyn Falempe wrote: > Now that kmsg dump callback has the description parameter, use it in > the user panic screen. > This is the string passed to panic(), like "VFS: Unable to mount root > fs on xxx" or "Attempted to kill init! exitcode=0". > It giv

Re: [PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-09 Thread Nirmoy Das
On 8/9/2024 2:06 AM, john.c.harri...@intel.com wrote: From: John Harrison The previous update to enable the workaround on ARL only changed two out of three places where the w/a needs to be enabled. That meant the GuC side was operational but not the KMD side. And as the KMD side is the trigger,

Re: [PATCH 1/8] drm/fbdev-helper: Do delayed switcheroo in lastclose helper

2024-08-09 Thread Thomas Zimmermann
Hi Am 09.08.24 um 10:44 schrieb Daniel Vetter: On Wed, Aug 07, 2024 at 10:41:33AM +0200, Thomas Zimmermann wrote: Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from the fbdev lastclose helper, so that the driver functions can finally be

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Nilawar, Badal
On 09-08-2024 11:45, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-09 Thread Andi Shyti
Hi Johna, On Thu, Aug 08, 2024 at 05:06:46PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The previous update to enable the workaround on ARL only changed two > out of three places where the w/a needs to be enabled. That meant the > GuC side was operational but not the KMD s

Re: [PATCH] drm/buddy: fix issue that force_merge cannot free all roots

2024-08-09 Thread Matthew Auld
Hi, On 08/08/2024 07:38, Lin.Cao wrote: If buddy manager have more than one roots and each root have sub-block need to be free. When drm_buddy_fini called, the first loop of force_merge will merge and free all of the sub block of first root, which offset is 0x0 and size is biggest(more than have

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 03:03:20PM +0530, Nilawar, Badal wrote: > > > On 09-08-2024 11:45, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensors > > i915-pci-0

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
Hi Badal, > > +static int > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + struct hwm_fan_info *fi = &ddat->fi; > > + u32 reg_val, pulses, time, time_now; > > + intel_wakeref_t wakeref; > > + long rotations; > > +

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-09 Thread Andi Shyti
Hi Sima, On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote: > On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote: > > This patch series concludes on the memory mapping fixes and > > improvements by allowing partial memory mapping for the cpu > > memory as well. > > > > The par

Re: [PATCH v6 2/3] drm/xe/migrate: Parameterize ccs and bo data clear in xe_migrate_clear()

2024-08-09 Thread Matthew Auld
On 19/07/2024 10:55, Nirmoy Das wrote: Parameterize clearing ccs and bo data in xe_migrate_clear() which higher layers can utilize. This patch will be used later on when doing bo data clear for igfx as well. v2: Replace multiple params with flags in xe_migrate_clear (Matt B) v3: s/CLEAR_BO_DATA

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 10:35, Joonas Lahtinen wrote: > Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) >> On 08/08/2024 20:35, Krzysztof Kozlowski wrote: >>> On 08/08/2024 10:45, Tvrtko Ursulin wrote: Hi Dave, Sima, A small bunch of fixes for the weekly cycle: >>> >>> ... >>>

Re: [PATCH v3 07/12] drm/imx: ldb: switch to drm_panel_bridge

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > Defer panel handling to drm_panel_bridge, unifying codepaths for the > panel and bridge cases. The MFD_SYSCON symbol is moved to select to > prevent Kconfig symbol loops. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Philipp Zabel

Re: [PATCH v3 09/12] drm/imx: add internal bridge handling display-timings DT node

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > i.MX DRM DT bindings allow using either a proper panel / bridge graph to > provide information about connected panels, or just a display-timings DT > node, describing just the timings and the flags. Add helper bridge > driver supporting th

Re: [PATCH v3 08/12] drm/imx: parallel-display: switch to drm_panel_bridge

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > Defer panel handling to drm_panel_bridge, unifying codepaths for the > panel and bridge cases. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v3 10/12] drm/imx: ldb: switch to imx_legacy_bridge / drm_bridge_connector

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > Use the imx_legacy bridge driver instead of handlign display modes via > the connector node. > > All existing usecases already support attaching using > the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, while the imx_legacy bridge > doesn't suppor

Re: [PATCH v3 11/12] drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > Use the imx_legacy bridge driver instead of handlign display modes via > the connector node. > > All existing usecases already support attaching using > the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, while the imx_legacy bridge > doesn't suppor

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > The IPUv3 DRM i.MX driver contains several codepaths for different > usescases: both LDB and paralllel-display drivers handle next-bridge, > panel and the legacy display-timings DT node on their own. > > Drop unused ddc-i2c-bus and edid h

Re: [PATCH v3 12/12] drm/imx: move imx_drm_connector_destroy to imx-tve

2024-08-09 Thread Philipp Zabel
On So, 2024-06-02 at 15:04 +0300, Dmitry Baryshkov wrote: > The imx-tve driver is the only remaining user of > imx_drm_connector_destroy(). Move the function to imx-tve.c > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 5/9] drm/ast: dp501: Use struct drm_edid and helpers

2024-08-09 Thread Jocelyn Falempe
On 06/08/2024 14:52, Thomas Zimmermann wrote: Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the

Re: [PATCH 1/9] drm/ast: Move code for physical outputs into separate files

2024-08-09 Thread Jocelyn Falempe
On 06/08/2024 14:51, Thomas Zimmermann wrote: Move the modesetting code for the various transmitter chips into their own source files before adding BMC support. No functional changes. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/

Re: [PATCH 2/9] drm/ast: astdp: Move locking into EDID helper

2024-08-09 Thread Jocelyn Falempe
On 06/08/2024 14:51, Thomas Zimmermann wrote: The modeset mutex protects EDID retrival from concurrent modeset operations. Acquire the lock in ast_astdp_read_edid(). Prepares the code for conversion to struct drm_edid. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andy Shevchenko
On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > Add hwmon support for fan1_input attribute, which will expose fan speed > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > $ sensors > i915-pci-0300 > Adapter: PCI adapter > in0: 653.00 mV > fan1:

Re: [PATCH 5/9] drm/ast: dp501: Use struct drm_edid and helpers

2024-08-09 Thread Thomas Zimmermann
Hi Am 09.08.24 um 13:36 schrieb Jocelyn Falempe: On 06/08/2024 14:52, Thomas Zimmermann wrote: Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore updat

Re: [PATCH 3/9] drm/ast: astdp: Use struct drm_edid and helpers

2024-08-09 Thread Thomas Zimmermann
Hi Am 06.08.24 um 14:51 schrieb Thomas Zimmermann: Convert ASTDP support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Andi Shyti
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-09 Thread Andi Shyti
Hi, On Wed, Aug 07, 2024 at 10:10:14AM +0100, Andi Shyti wrote: > From: Chris Wilson > > After we detect that mmio is returning all 0xff, we believe that the GPU > has dropped off the pci bus and is dead. Mark the device as wedged such > that we can propagate the failure back to userspace and wa

Re: [PATCH 11/12] tty/vt: conmakehash requires linux/limits.h

2024-08-09 Thread Masahiro Yamada
On Wed, Aug 7, 2024 at 8:10 AM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > macOS hosts do not provide the linux/limits.h header required for > conmakehash. To address this, ensure that usr/include is included in > the conmakehash HOSTCFLAGS. This will provide the necessary header

Re: [PATCH v6 12/12] drm/xe: Increase the XE_PL_TT watermark

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:13 +, Matthew Brost wrote: > On Mon, Aug 05, 2024 at 12:35:34PM -0600, Souza, Jose wrote: > > On Wed, 2024-07-03 at 17:38 +0200, Thomas Hellström wrote: > > > The XE_PL_TT watermark was set to 50% of system memory. > > > The idea behind that was unclear since the net ef

[PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the number of iterations from 10 to 9 but probably that's okay. Fixes: 2281475168d2 ("dr

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Thomas Zimmermann
Hi, thanks a lot for the bugfix. Am 09.08.24 um 14:33 schrieb Dan Carpenter: The test for "Link training failed" expect the loop to exit with "i" set to zero but it exits when "i" is set to -1. Change this from a post-op to a pre-op so that it exits with "i" set to zero. This changes the numb

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Jani Nikula
On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > Hi, > > thanks a lot for the bugfix. > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: >> The test for "Link training failed" expect the loop to exit with "i" >> set to zero but it exits when "i" is set to -1. Change this from a >> post-op to a pre-op

Re: [PATCH v6 10/12] drm/ttm: Use fault-injection to test error paths

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:43 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:11PM +0200, Thomas Hellström wrote: > > Use fault-injection to test partial TTM swapout and interrupted > > swapin. > > Return -EINTR for swapin to test the callers ability to handle and > > restart the swapin,

Re: [PATCH v6 12/12] drm/xe: Increase the XE_PL_TT watermark

2024-08-09 Thread Thomas Hellström
On Wed, 2024-08-07 at 23:44 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:13PM +0200, Thomas Hellström wrote: > > The XE_PL_TT watermark was set to 50% of system memory. > > The idea behind that was unclear since the net effect is that > > TT memory will be evicted to TTM_PL_SYSTEM me

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-09 Thread Mina Almasry
On Thu, Aug 8, 2024 at 10:24 PM Jakub Kicinski wrote: > > On Thu, 8 Aug 2024 16:36:24 -0400 Mina Almasry wrote: > > > How do you know that the driver: > > > - supports net_iov at all (let's not make implicit assumptions based > > >on presence of queue API); > > > - supports net_iov in curren

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Thomas Hellström
On Thu, 2024-08-08 at 01:37 +, Matthew Brost wrote: > On Wed, Jul 03, 2024 at 05:38:12PM +0200, Thomas Hellström wrote: > > Rather than relying on the TTM watermark accounting add a shrinker > > for xe_bos in TT or system memory. > > > > Leverage the newly added TTM per-page shrinking and shme

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > Use sysfs_emit_at() instead of snprintf() + custom logic. > Using sysfs_emit_at() is much more simple. > > Also, sysfs_emit() is already used in this function, so using > sysfs_emit_at() is more consistent. > > Also simplify th

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 05:42:32PM +0300, Dan Carpenter wrote: > On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > > Use sysfs_emit_at() instead of snprintf() + custom logic. > > Using sysfs_emit_at() is much more simple. > > > > Also, sysfs_emit() is already used in this funct

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen wrote: > Quoting Andi Shyti (2024-08-06 12:46:07) > > Hi Greg, > > > > same question without the stable mailing list not to trigger the > > automatic reply. > > > > > Andi Shyti (2): > > > drm/i915/gem: Adjust vma offset for framebuffer mmap offset

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

[PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Alex Deucher
In aperture_remove_conflicting_pci_devices(), match the pci device determine whether or not to call sysfb_disable(). This fixes cases where the pimary device is not VGA compatible which leads to the following problem: 1. A PCI device with a non-VGA class is the the boot display 2. That device is

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Christophe JAILLET
Le 09/08/2024 à 16:42, Dan Carpenter a écrit : On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: Use sysfs_emit_at() instead of snprintf() + custom logic. Using sysfs_emit_at() is much more simple. Also, sysfs_emit() is already used in this function, so using sysfs_emit_at() i

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 05:09:28PM +0200, Christophe JAILLET wrote: > Le 09/08/2024 à 16:42, Dan Carpenter a écrit : > > On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: > > > Use sysfs_emit_at() instead of snprintf() + custom logic. > > > Using sysfs_emit_at() is much more simpl

[PATCH v2] dt-bindings: display: st, stm32-ltdc: Document stm32mp25 compatible

2024-08-09 Thread Yannick Fertre
Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. New sources are possible for lcd clock (lvds / ref). Signed-off-by: Yannick Fertre --- Changes in v2: Rework clock property. .../bindings/display/st,stm32

Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-08-09 Thread Yannick FERTRE
Hi, we don't give enough attention to older SOCs like stm32f469. This is an error on our part. I think that to fix this point it would be necessary to define the clock hse as clock fix. I hope to be able to release a patch before the end of August Best regards Yannick Fertré Le 01/08/20

[PATCH] drm/v3d: Fix out-of-bounds read in `v3d_csd_job_run()`

2024-08-09 Thread Maíra Canal
When enabling UBSAN on Raspberry Pi 5, we get the following warning: [ 387.894977] UBSAN: array-index-out-of-bounds in drivers/gpu/drm/v3d/v3d_sched.c:320:3 [ 387.903868] index 7 is out of range for type '__u32 [7]' [ 387.909692] CPU: 0 PID: 1207 Comm: kworker/u16:2 Tainted: GWC

Re: [PATCH] MAINTAINERS: qaic: Drop Pranjal as reviewer

2024-08-09 Thread Carl Vanderlip
On 7/26/2024 8:53 AM, Jeffrey Hugo wrote: Pranjal's email address is bouncing. Signed-off-by: Jeffrey Hugo Reviewed-by: Carl Vanderlip

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine L

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Carl Vanderlip
On 8/5/2024 10:39 AM, Lizhi Hou wrote: > +static int aie2_init(struct amdxdna_dev *xdna) > +{ > +struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); > +struct amdxdna_dev_hdl *ndev; > +struct psp_config psp_conf; > +const struct firmware *fw; > +void __iomem * const *tbl; > +

Re: [PATCH] accel: drm_accel: remove incorrect comments

2024-08-09 Thread Carl Vanderlip
On 7/30/2024 11:42 PM, bajing wrote: > accel_minor_replace is of type void, so remove the explanation of the return value in the comments. > > Signed-off-by: bajing Reviewed-by: Carl Vanderlip

[PATCH v3 2/7] drm/bridge: add bridge notifier to be notified of bridge addition and removal

2024-08-09 Thread Luca Ceresoli
From: Paul Kocialkowski In preparation for allowing bridges to be added to and removed from a DRM card without destroying the whole card, add a DRM bridge notifier. Notified events are addition and removal to/from the global bridge list. Co-developed-by: Luca Ceresoli Signed-off-by: Luca Cereso

[PATCH v3 0/7] Add support for GE SUNH hot-pluggable connector

2024-08-09 Thread Luca Ceresoli
Hello, this series aims at supporting a Linux device with a connector to physically add and remove an add-on to/from the main device to augment its features at runtime, using device tree overlays. What's new in v3 (a lot!) = There are big changes compared to v2, in many a

[PATCH v3 3/7] drm/encoder: add drm_encoder_cleanup_from()

2024-08-09 Thread Luca Ceresoli
Supporting hardware whose final part of the DRM pipeline can be physically removed requires the ability to detach all bridges from a given point to the end of the pipeline. Introduce a variant of drm_encoder_cleanup() for this. Signed-off-by: Luca Ceresoli --- Changes in v3: none Changed in v

[PATCH v3 4/7] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges

2024-08-09 Thread Luca Ceresoli
This driver implements the point of a DRM pipeline where a connector allows removal of all the following bridges up to the panel. The DRM subsystem currently allows hotplug of the monitor but not preceding components. However there are embedded devices where the "tail" of the DRM pipeline, includi

[PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-09 Thread Luca Ceresoli
Add bindings for the GE SUNH add-on connector. This is a physical, hot-pluggable connector that allows to attach and detach at runtime an add-on adding peripherals on non-discoverable busses. Signed-off-by: Luca Ceresoli --- Changed in v3: - change the layout to only add subnodes, not properti

[PATCH v3 5/7] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes

2024-08-09 Thread Luca Ceresoli
When device tree nodes are added, the I2C core tries to probe client devices based on the classic DT structure: i2c@abcd { some-client@42 { compatible = "xyz,blah"; ... }; }; However for hotplug connectors described via device tree overlays there is additional level of indirection,

[PATCH v3 6/7] misc: add ge-addon-connector driver

2024-08-09 Thread Luca Ceresoli
Add a driver to support the runtime hot-pluggable add-on connector on the GE SUNH device. This connector allows connecting and disconnecting an add-on to/from the main device to augment its features. Connection and disconnection can happen at runtime at any moment without notice. Different add-on

[PATCH DO NOT APPLY v3 7/7] driver core: do not unblock consumers any drivers found

2024-08-09 Thread Luca Ceresoli
Quick summary: I have investigated a problem for a long time, I have a pretty good understanding, I tried various fixes but none except this is working. The goal of this patch is to discuss the problem to converge to the best solution. - Symptoms --

Re: [PATCH v2 0/2] Fix mmap memory boundary calculation

2024-08-09 Thread Jann Horn
On Fri, Aug 9, 2024 at 4:48 PM Jann Horn wrote: > On Tue, Aug 6, 2024 at 2:08 PM Joonas Lahtinen > wrote: > > Quoting Andi Shyti (2024-08-06 12:46:07) > > > Hi Greg, > > > > > > same question without the stable mailing list not to trigger the > > > automatic reply. > > > > > > > Andi Shyti (2): >

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-09 Thread Pavel Begunkov
On 8/9/24 15:10, Mina Almasry wrote: On Thu, Aug 8, 2024 at 10:24 PM Jakub Kicinski wrote: On Thu, 8 Aug 2024 16:36:24 -0400 Mina Almasry wrote: How do you know that the driver: - supports net_iov at all (let's not make implicit assumptions based on presence of queue API); - supports

Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c

2024-08-09 Thread Shuah Khan
On 8/8/24 21:23, Daniel Yang wrote: Fix the unexpected indentation errors. drm_connector.c has some kerneldoc comments that were missing newlines. This results in the following warnings when running make htmldocs: ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING:

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Matthew Auld
Hi, On 03/07/2024 16:38, Thomas Hellström wrote: Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, intro

[PATCH] drm/meson: add check to prevent dereference of NULL

2024-08-09 Thread Anastasia Belova
If devm_kzalloc gives NULL instead of allocating priv, execution goes to free_drm where priv is dereferenced calling meson_encoder_dsi_remove, meson_encoder_hdmi_remove and meson_encoder_cvbs_remove. Add NULL-check for priv. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signe

Re: [PATCH 11/12] tty/vt: conmakehash requires linux/limits.h

2024-08-09 Thread Daniel Gomez (Samsung)
f6aa043c7afa40a2103163a0ef06d179/drivers/tty/vt/conmakehash.c#L15 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/vt/conmakehash.c?h=1e391b34f6aa043c7afa40a2103163a0ef06d179#n15 This patch adds the header: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firm

Re: [PATCH v2] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

2024-08-09 Thread Rob Herring (Arm)
On Fri, 09 Aug 2024 17:13:14 +0200, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre >

Re: [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +enum aie2_msg_status { + AIE2_STATUS_SUCCESS = 0x0, + /* AIE Error codes */ + AIE2_STATUS_AIE_SATURATION_ERROR= 0x101, + AIE2_STATUS_AIE_FP_ERROR= 0x102, +

Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-08-09 Thread Rob Herring (Arm)
nh-addon-connector.example.dtb: /: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809-hotplug-drm-bridge-v3-1-b4

Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +int aie2_max_col = XRS_MAX_COL; +module_param(aie2_max_col, int, 0600); +MODULE_PARM_DESC(aie2_max_col, "Maximum column could be used"); I think you selected the wrong type. What happens if someone sets this to a negative value?

Re: [PATCH V2 05/10] accel/amdxdna: Add GEM buffer object management

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_create_bo - Create a buffer object. + * @flags: Buffer flags. MBZ. + * @type: Buffer type. + * @vaddr: User VA of buffer if applied. MBZ. + * @size: Size in bytes. + * @handle: Returned DRM buffer object handle. + */ +struct amdxd

Re: [PATCH v6 10/12] drm/ttm: Use fault-injection to test error paths

2024-08-09 Thread Matthew Brost
On Fri, Aug 09, 2024 at 03:53:20PM +0200, Thomas Hellström wrote: > On Wed, 2024-08-07 at 23:43 +, Matthew Brost wrote: > > On Wed, Jul 03, 2024 at 05:38:11PM +0200, Thomas Hellström wrote: > > > Use fault-injection to test partial TTM swapout and interrupted > > > swapin. > > > Return -EINTR f

Re: [PATCH V2 09/10] accel/amdxdna: Add query functions

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_query_hwctx - The data for single context. + * @context_id: The ID for this context. + * @start_col: The starting column for the partition assigned to this context. + * @num_col: The number of columns in the partition assigned to

Re: [PATCH] accel: drm_accel: remove incorrect comments

2024-08-09 Thread Jeffrey Hugo
On 7/31/2024 12:42 AM, bajing wrote: accel_minor_replace is of type void, so remove the explanation of the return value in the comments. Signed-off-by: bajing --- drivers/accel/drm_accel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_acc

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

2024-08-09 Thread Dan Carpenter
On Fri, Aug 09, 2024 at 04:43:51PM +0300, Jani Nikula wrote: > On Fri, 09 Aug 2024, Thomas Zimmermann wrote: > > Hi, > > > > thanks a lot for the bugfix. > > > > Am 09.08.24 um 14:33 schrieb Dan Carpenter: > >> The test for "Link training failed" expect the loop to exit with "i" > >> set to zero b

Re: [PATCH v6 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

2024-08-09 Thread Matthew Brost
On Fri, Aug 09, 2024 at 04:31:27PM +0200, Thomas Hellström wrote: > On Thu, 2024-08-08 at 01:37 +, Matthew Brost wrote: > > On Wed, Jul 03, 2024 at 05:38:12PM +0200, Thomas Hellström wrote: > > > Rather than relying on the TTM watermark accounting add a shrinker > > > for xe_bos in TT or system

[PATCH v10 00/16] drm/vkms: Reimplement line-per-line pixel conversion for plane reading

2024-08-09 Thread Louis Chauvet
This patchset is the second version of [1]. It is almost a complete rewrite to use a line-by-line algorithm for the composition. During the development of this series Pekka and Arthur found an issue in drm core. The YUV part of this series depend on the fix [9]. I'll let Arthur extract it and subm

[PATCH v10 01/16] drm/vkms: Code formatting

2024-08-09 Thread Louis Chauvet
Few no-op changes to remove double spaces and fix wrong alignments. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 10 +- drivers/gpu/drm/vkms/vkms_crtc.c | 6 ++ drivers/gpu/drm/vkms/vkms_drv.c

[PATCH v10 03/16] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-08-09 Thread Louis Chauvet
Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Signed-off-by: Louis Chauvet Acked-by: Pekka Paalanen --- drivers/gpu/drm/vkms/vkms_composer.c | 7 drivers/gpu/drm/vkms/vkms_drv.h | 15 - drivers/gpu/drm/vkms/vkms_f

[PATCH v10 02/16] drm/vkms: Use drm_frame directly

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo Remove intermidiary variables and access the variables directly from drm_frame. These changes should be noop. Signed-off-by: Arthur Grillo Acked-by: Pekka Paalanen Reviewed-by: Maíra Canal Reviewed-by: Louis Chauvet [Louis Chauvet: Applied review from Maíra] Signed-off-by

[PATCH v10 04/16] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-08-09 Thread Louis Chauvet
Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the compiler to check if the passed functions take the correct arguments. Such typedefs will help ensuring consistency across the code base in case of update of these prototypes. Rename input/output variable in a consistent way betw

[PATCH v10 06/16] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-08-09 Thread Louis Chauvet
Introduce the usage of block_h/block_w to compute the offset and the pointer of a pixel. The previous implementation was specialized for planes with block_h == block_w == 1. To avoid confusion and allow easier implementation of tiled formats. It also remove the usage of the deprecated format field

[PATCH v10 05/16] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-08-09 Thread Louis Chauvet
As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- drivers/gpu/drm/vkms/vkms_formats.c | 20 ++--

[PATCH v10 07/16] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-08-09 Thread Louis Chauvet
The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing different concepts (coordinate calculation and color management), extract the x_limit and x_dst computation outside of this helper. It also increases the maintainability by grouping the computation related to coordinates in the sa

[PATCH v10 10/16] drm/vkms: Remove useless drm_rotation_simplify

2024-08-09 Thread Louis Chauvet
As all the rotation are now supported by VKMS, this simplification does not make sense anymore, so remove it. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/

[PATCH v10 09/16] drm/vkms: Re-introduce line-per-line composition algorithm

2024-08-09 Thread Louis Chauvet
Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but rewritten back to pixel-by-pixel algorithm in [

[PATCH v10 08/16] drm/vkms: Introduce pixel_read_direction enum

2024-08-09 Thread Louis Chauvet
The pixel_read_direction enum is useful to describe the reading direction in a plane. It avoids using the rotation property of DRM, which not practical to know the direction of reading. This patch also introduce two helpers, one to compute the pixel_read_direction from the DRM rotation property, an

[PATCH v10 13/16] drm/vkms: Drop YUV formats TODO

2024-08-09 Thread Louis Chauvet
From: Arthur Grillo VKMS has support for YUV formats now. Remove the task from the TODO list. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentati

  1   2   >