Re: [PATCH] gpu: drm: use for_each_endpoint_of_node()

2024-08-07 Thread Tomi Valkeinen
On 30/07/2024 03:34, Kuninori Morimoto wrote: We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Acked-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 3 +--

Re: [PATCH 3/9] drm/meson: dw-hdmi: use generic clock helpers

2024-08-07 Thread Jerome Brunet
On Tue 06 Aug 2024 at 22:28, Martin Blumenstingl wrote: > On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: >> >> The Amlogic HDMI phy driver is not doing anything with the clocks >> besides enabling on probe. CCF provides generic helpers to do that. >> >> Use the generic clock helpers rathe

Re: [PATCH 5/9] drm/meson: dw-hdmi: split resets out of hw init.

2024-08-07 Thread Jerome Brunet
On Tue 06 Aug 2024 at 22:49, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: >> >> This prepares the migration to regmap usage. >> >> To properly setup regmap, the APB needs to be in working order. >> This is easier handled if the resets are not

[PATCH 1/2] PCI: Deprecate pcim_iomap_regions() in favor of pcim_iomap_region()

2024-08-07 Thread Philipp Stanner
pcim_iomap_regions() is a complicated function that uses a bit mask to determine the BARs the user wishes to request and ioremap. Almost all users only ever set a single bit in that mask, making that mechanism questionable. pcim_iomap_region() is now available as a more simple replacement. Make p

[PATCH 2/2] drm/ast: Request PCI BAR with devres

2024-08-07 Thread Philipp Stanner
ast currently ioremaps two PCI BARs using pcim_iomap(). It does not perform a request on the regions, however, which would make the driver a bit more robust. PCI now offers pcim_iomap_region(), a managed function which both requests and ioremaps a BAR. Replace pcim_iomap() with pcim_iomap_region(

[PATCH v1] drm/ci: uprev mesa

2024-08-07 Thread Vignesh Raman
Uprev mesa to adapt to the latest changes in mesa ci. Project 'anholt/deqp-runner' was moved to 'mesa/deqp-runner'. So update the link. Signed-off-by: Vignesh Raman --- v1: - Working pipeline link, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1242911 --- drivers/gpu/drm/

[PATCH 1/8] drm/fbdev-helper: Do delayed switcheroo in lastclose helper

2024-08-07 Thread Thomas Zimmermann
Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from the fbdev lastclose helper, so that the driver functions can finally be removed. The fbdev call is part of all lastclose handling that restores the DRM fbcon terminal. Only PCI devices with

[PATCH 0/8] drm/{amdgpu,nouveau}: Remove old fbdev hooks

2024-08-07 Thread Thomas Zimmermann
After switching all drivers' fbdev emulation to DRM client, the old fbdev hooks are now obsolete. Only amgdpu and nouveau still use them in a several places. Remove the hooks from the drivers and the DRM core. The series would ideally be merged at once via drm-misc-next. Thomas Zimmermann (8):

[PATCH 5/8] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

2024-08-07 Thread Thomas Zimmermann
Replace the callto drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It's equivalent in functionality, but use the DRM client infrastructure. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_vga.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 3/8] drm/nouveau: Do not set struct drm_driver.lastclose

2024-08-07 Thread Thomas Zimmermann
Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code within nouveau_vga_lastclose() is performed elsewhere in the DRM fbdev emulation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouvea

[PATCH 4/8] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

2024-08-07 Thread Thomas Zimmermann
The output_poll_changed hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The client code handles display otplugging internally. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 - drivers/gpu/drm/nouveau/nouveau_display.c | 1 -

[PATCH 2/8] drm/amdgpu: Do not set struct drm_driver.lastclose

2024-08-07 Thread Thomas Zimmermann
Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code within amdgpu_driver_lastclose_kms() is performed elsewhere in the DRM fbdev emulation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/

[PATCH 7/8] drm: Remove struct drm_driver.lastclose

2024-08-07 Thread Thomas Zimmermann
The lastclose callback in struct drm_driver is unused. Remove it. Also inline the now trivial drm_lastclose() and update documentation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_drv.c | 5 ++--- drivers/gpu/drm/drm_fb_helper.c | 18 + drivers/gpu/drm/drm_fil

[PATCH 8/8] drm: Remove struct drm_mode_config_funcs.output_poll_changed

2024-08-07 Thread Thomas Zimmermann
The output_poll_changed hook in struct drm_mode_config_funcs is unused. Remove it. The helper drm_client_dev_hotplug() implements the callback's functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_probe_helper.c | 10 +- include/drm/drm_mode_config.h | 16 ---

[PATCH 6/8] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

2024-08-07 Thread Thomas Zimmermann
The function is unused. Remove it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 15 --- include/drm/drm_fb_helper.h | 6 -- 2 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6667d

Re: [PATCH 2/2] drm/ast: Request PCI BAR with devres

2024-08-07 Thread Thomas Zimmermann
Am 07.08.24 um 10:30 schrieb Philipp Stanner: ast currently ioremaps two PCI BARs using pcim_iomap(). It does not perform a request on the regions, however, which would make the driver a bit more robust. PCI now offers pcim_iomap_region(), a managed function which both requests and ioremaps a

[PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Andi Shyti
From: Chris Wilson After we detect that mmio is returning all 0xff, we believe that the GPU has dropped off the pci bus and is dead. Mark the device as wedged such that we can propagate the failure back to userspace and wait for recovery. Signed-off-by: Chris Wilson Signed-off-by: Andi Shyti -

Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-08-07 Thread Jerome Brunet
On Tue 06 Aug 2024 at 23:03, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > [...] >> + }, { >> + .limit = 297000, >> + .regs = gxbb_3g_regs, >> + .reg_num = ARRAY_SIZE(gxbb_3g_regs) > Just as a s

Re: [PATCH 0/5] drm/panic: Cleanup and add panic description

2024-08-07 Thread Thomas Zimmermann
Am 23.07.24 um 11:11 schrieb Jocelyn Falempe: This small series removes unused export symbols, moves internal include to drm_crtc_internal.h, and adds the panic description, now that kmsg_dump provides this information. Jocelyn Falempe (5): drm/panic: Remove space before "!" in panic mes

Re: [PATCH 4/5] drm/panic: Move copyright notice to the top

2024-08-07 Thread Daniel Vetter
On Tue, Jul 23, 2024 at 11:11:33AM +0200, Jocelyn Falempe wrote: > Move the copyright notice to the top of drm_panic.h, and add the > missing Red Hat copyright notice. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Jocelyn Falempe Patches 1-4 are Reviewed-by: Daniel Vetter Cheers, Sima

Re: [PATCH 5/5] drm/panic: Add panic description

2024-08-07 Thread Daniel Vetter
On Tue, Jul 23, 2024 at 11:11:34AM +0200, Jocelyn Falempe wrote: > Now that kmsg dump callback has the description parameter, use it in > the user panic screen. > This is the string passed to panic(), like "VFS: Unable to mount root > fs on xxx" or "Attempted to kill init! exitcode=0". > It giv

Re: [PATCH 5/5] drm/panic: Add panic description

2024-08-07 Thread Jocelyn Falempe
On 07/08/2024 11:21, Daniel Vetter wrote: On Tue, Jul 23, 2024 at 11:11:34AM +0200, Jocelyn Falempe wrote: Now that kmsg dump callback has the description parameter, use it in the user panic screen. This is the string passed to panic(), like "VFS: Unable to mount root fs on xxx" or "Attempted

[PATCH v3 2/2] drm/panel: jd9365da: Modify the init code of Melfas

2024-08-07 Thread Zhaoxiong Lv
Modify the Melfas panel init code to satisfy the gamma value of 2.2 Acked-by: Jessica Zhang Signed-off-by: Zhaoxiong Lv --- Changes between V3 and V2: - 1. No changed. v2: https://lore.kernel.org/all/20240806034015.11884-3-lvzhaoxi...@huaqin.corp-partner.google.com/ Changes between V2 and V1:

[PATCH v3 1/2] drm/panel: jd9365da: Move "exit sleep mode" and "set display on" cmds

2024-08-07 Thread Zhaoxiong Lv
Move the "exit sleep mode" and "set display on" command from enable() to init() function. As mentioned in the patch: https://lore.kernel.org/all/20240624141926.5250-2-lvzhaoxi...@huaqin.corp-partner.google.com/ The Mediatek Soc DSI host has different modes in prepare() and enable() functions, pre

[PATCH v3 0/2] Modify the method of sending "exit sleep

2024-08-07 Thread Zhaoxiong Lv
This "exit sleep mode" and "set display on" command needs to be sent in LP mode, so move "exit sleep mode" and "set display on" command to the init() function. Modify the Melfas panel init code to satisfy the gamma value of 2.2. Changes between V3 and V2: - PATCH 1/2: Modify the commit message

[PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-07 Thread Andi Shyti
Hi, This patch series concludes on the memory mapping fixes and improvements by allowing partial memory mapping for the cpu memory as well. The partial memory mapping by adding an object offset was implicitely included in commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping boundaries c

[PATCH 1/2] drm/i915/gem: Do not look for the exact address in node

2024-08-07 Thread Andi Shyti
In preparation for the upcoming partial memory mapping feature, we want to make sure that when looking for a node we consider also the offset and not just the starting address of the virtual memory node. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 6 +++--- 1 file ch

[PATCH 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-08-07 Thread Andi Shyti
To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This adjustment compensates for instances when userspace mappings do not start from the beginning of the object. Based on a patch by Chris Wilson. Sign

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-07 Thread Dmitry Baryshkov
On August 5, 2024 9:27:39 AM GMT+07:00, Leonard Lausen wrote: >Dear Dmitry, > >Thank you for the patch. Unfortunately, the patch triggers a regression with >respect to DRM CRTC state handling. With the patch applied, suspending and >resuming a lazor sc7180 with external display connected, looses

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-07 Thread Dmitry Baryshkov
On August 6, 2024 2:19:46 AM GMT+07:00, Abhinav Kumar wrote: > > >On 8/2/2024 12:47 PM, Dmitry Baryshkov wrote: >> During suspend/resume process all connectors are explicitly disabled and >> then reenabled. However resume fails because of the connector_status check: >> >> [ 1185.831970] [dpu err

[PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Andi Shyti
By moving the pfn calculation to the set_address_limits() function we improve code readability. This way, set_address_limits() is responsible for calculating all memory mapping paramenters: "start", "end" and "pfn". This suggestion from Jonathan was made during the review of commit 8bdd9ef7e9b1 ("

Re: [PATCH] drm/i915: 2 GiB of relocations ought to be enough for anybody*

2024-08-07 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-05-21 13:12:01) > From: Tvrtko Ursulin > > Kernel test robot reports i915 can hit a warn in kvmalloc_node which has > a purpose of dissalowing crazy size kernel allocations. This was added in > 7661809d493b ("mm: don't allow oversized kvmalloc() calls"): > >/

Re: [PATCH 00/12] Enable build system on macOS hosts

2024-08-07 Thread Greg Kroah-Hartman
On Wed, Aug 07, 2024 at 01:09:14AM +0200, Daniel Gomez via B4 Relay wrote: > This patch set allows for building the Linux kernel for arm64 in macOS with > LLVM. Is this a requirement somewhere that this must work? It seems like an odd request, what workflows require cross-operating-system builds

Re: [PATCH 08/12] include: add elf.h support

2024-08-07 Thread Greg Kroah-Hartman
On Wed, Aug 07, 2024 at 01:09:22AM +0200, Daniel Gomez via B4 Relay wrote: > From: Daniel Gomez > > Add a copy of elf/elf.h header from the GNU C Library (glibc), version > glibc-2.40 into include/elf. Update Makefiles where elf.h header is used > to ensure the compiler can find all necessary hea

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-07 Thread Markus Elfring
If you temporarily find the circumstances too challenging for applications of scope-based resource management, I suggest to use the following statements instead (so that a bit of redundant code can be avoided). … > +++ b/drivers/accel/amdxdna/aie2_pci.c > @@ -0,0 +1,182 @@ … > +static int aie2_

[PATCH v3 0/5] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-08-07 Thread Cristian Ciocaltea
The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite different from those used in the previous generations of Rockchip SoCs. The controller supports the following features, among others: * Fixed Rate Link (FRL) *

[PATCH v3 1/5] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-07 Thread Cristian Ciocaltea
Add dt-binding schema containing the common properties for the Synopsys DesignWare HDMI QP TX controller. Note this is not a full dt-binding specification, but is meant to be referenced by platform-specific bindings for this IP core. Signed-off-by: Cristian Ciocaltea --- .../display/bridge/syno

[PATCH v3 2/5] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-08-07 Thread Cristian Ciocaltea
The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller IP supports the following features, among others: * Fixed Rate Link (FRL) * Display Stream Compression (DSC) * 4K@120Hz and 8K@60Hz video modes * Variable Refresh Rate (VRR) including Quick Media Switching (QMS), aka Cinema VRR * Fas

[PATCH v3 3/5] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-07 Thread Cristian Ciocaltea
Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller IP. Since this is a new IP block, quite different from those used in the previous generations of Rockchip SoCs, add a dedicated binding file. Signed-off-by: Cristian Ciocaltea --- .../display/rockchip/

[PATCH v3 4/5] drm/rockchip: Explicitly include bits header

2024-08-07 Thread Cristian Ciocaltea
Driver makes use of the BIT() macro, but relies on the bits header being implicitly included. Explicitly pull the header in to avoid potential build failures in some configurations. While at it, reorder include directives alphabetically. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/ro

[PATCH v3 5/5] drm/rockchip: Add basic RK3588 HDMI output support

2024-08-07 Thread Cristian Ciocaltea
The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a Samsung IP block. Add just the basic support for now, i.e. RGB output up to 4K@60Hz, without audio, CEC or any of the HDMI 2.1 specific features. Co-deve

Re: [PATCH 04/12] drm/xe: xe_gen_wa_oob: fix program_invocation_short_name for macos

2024-08-07 Thread Lucas De Marchi
On Wed, Aug 07, 2024 at 08:13:51AM GMT, Daniel Gomez wrote: On Tue, Aug 06, 2024 at 08:50:09PM GMT, Lucas De Marchi wrote: On Wed, Aug 07, 2024 at 01:09:18AM GMT, Daniel Gomez via B4 Relay wrote: > From: Daniel Gomez > > Use getprogname() [1] instead of program_invocation_short_name() [2] > for

Re: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Krzysztof Niemiec
On 2024-08-07 at 11:45:53 GMT, Andi Shyti wrote: > By moving the pfn calculation to the set_address_limits() > function we improve code readability. This way, > set_address_limits() is responsible for calculating all memory > mapping paramenters: "start", "end" and "pfn". > > This suggestion from

[PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-08-07 Thread Tomi Valkeinen
Hi, On 25/07/2024 14:28, Maxime Ripard wrote: On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote: On 02/07/2024 14:43, Maxime Ripard wrote: Hi Tomi, On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote: On 26/06/2024 18:07, Maxime Ripard wrote: On Wed, Jun 26, 2024 at 12:5

Re: [PATCH v1] drm/ci: uprev mesa

2024-08-07 Thread Daniel Stone
On Wed, 7 Aug 2024 at 09:21, Vignesh Raman wrote: > Uprev mesa to adapt to the latest changes in mesa ci. > Project 'anholt/deqp-runner' was moved to 'mesa/deqp-runner'. > So update the link. Reviewed-by: Daniel Stone

Re: [RFC PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

2024-08-07 Thread Michael Nazzareno Trimarchi
Hi Doug +cc Doug I have seen that you have done some re-working and investigation on drm stack, do you have some suggestion on this case? On Mon, Jun 24, 2024 at 8:53 PM Michael Trimarchi wrote: > > The shutdown function can be called when the display is already > unprepared. For example during

Re: [PATCH v1] drm/xe/uapi: Bring back reset uevent

2024-08-07 Thread Lucas De Marchi
On Tue, Aug 06, 2024 at 10:02:31AM GMT, Raag Jadav wrote: From: Lucas De Marchi Bring back uevent for gt reset failure with better uapi naming. With this in place we can receive failure event using udev. $ udevadm monitor --property --kernel monitor will print the received events for: KERNEL -

[PATCH v3 0/4] drm/msm: Further expose UBWC tiling parameters

2024-08-07 Thread Connor Abbott
After testing, there are more parameters that we're programming which affect how UBWC tiles are laid out in memory and therefore affect the Mesa implementation of VK_EXT_host_image_copy [1], which includes a CPU implementation of tiling and detiling images. In particular we have: 1. ubwc_mode, whi

[PATCH v3 3/4] drm/msm: Expose expanded UBWC config uapi

2024-08-07 Thread Connor Abbott
This adds extra parameters that affect UBWC tiling that will be used by the Mesa implementation of VK_EXT_host_image_copy. Signed-off-by: Connor Abbott --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 ++ include/uapi/drm/msm_drm.h | 2 ++ 2 files changed, 8 insertions(+) diff -

[PATCH v3 4/4] drm/msm: Fix UBWC macrotile_mode for a680

2024-08-07 Thread Connor Abbott
Make it match the MDSS settings for sc8180x and downstream. Note that without the previous commit that exposes the value of macrotile_mode to mesa, this will break mesa which expects the legacy default value of 0. Therefore we do *not* want to backport it. Signed-off-by: Connor Abbott --- drive

[PATCH v3 2/4] drm/msm: Expand UBWC config setting

2024-08-07 Thread Connor Abbott
According to downstream we should be setting RBBM_NC_MODE_CNTL to a non-default value on a663 and a680, we don't support a663 and on a680 we're leaving it at the wrong (suboptimal) value. Just set it on all GPUs. Similarly, plumb through level2_swizzling_dis which will be necessary on a663. ubwc_m

[PATCH v3 1/4] drm/msm: Update a6xx register XML

2024-08-07 Thread Connor Abbott
Update to Mesa commit 36a13d2b3b0 ("freedreno: fix a7xx perfcntr countables"). Signed-off-by: Connor Abbott --- drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 1118 - 1 file changed, 1097 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/registers/adreno/a

[PATCH 0/2] Trivial double space style fix

2024-08-07 Thread Andi Shyti
Hi, I was bothered a few times to see the double space in the parameters list so that I decided to replace once and for all all the double spaces that are not added on purpose to maintain some visual alignment in the code. Checkpatch doesn't have any rules for that because, indeed, this is used a

[PATCH 1/2] drm/i915: Replace double blank with single blank after comma in gem/ and gt/

2024-08-07 Thread Andi Shyti
Do not use double blanks, ", " in function parameters where it's not required by any alignment purpose. Replase it with a single blank, ", ". Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- d

[PATCH 2/2] drm/i915: Replace double blank with single blank after comma

2024-08-07 Thread Andi Shyti
Do not use double blanks, ", " in function parameters where it's not required by any alignment purpose. Replase it with a single blank, ", ". Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- d

Re: [PATCH 0/2] Trivial double space style fix

2024-08-07 Thread Jani Nikula
On Wed, 07 Aug 2024, Andi Shyti wrote: > Hi, > > I was bothered a few times to see the double space in the > parameters list so that I decided to replace once and for all all > the double spaces that are not added on purpose to maintain some > visual alignment in the code. > > Checkpatch doesn't h

Re: [PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Andi Shyti
Hi Raag, > +static umode_t > +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr) > +{ > + struct i915_hwmon *hwmon = ddat->hwmon; > + > + switch (attr) { > + case hwmon_fan_input: > + return i915_mmio_reg_valid(hwmon->rg.fan_speed) ? 0444 : 0; > + default: > +

[PATCH v2 0/5] drm/panic: Cleanup and add panic description

2024-08-07 Thread Jocelyn Falempe
This small series removes unused export symbols, moves internal include to drm_crtc_internal.h, and adds the panic description, now that kmsg_dump provides this information. v2: * Use a macro PANIC_MSG_LINES, instead of directly using the indice in drm_panic_set_description() (Sima) * Add drm

[PATCH v2 2/5] drm/panic: Remove useless export symbols

2024-08-07 Thread Jocelyn Falempe
drm_panic_[un]register() are called only from the core drm, so there is no need to export them. Suggested-by: Daniel Vetter Signed-off-by: Jocelyn Falempe Reviewed-by: Daniel Vetter Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_panic.c | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH v2 3/5] drm/panic: Move drm_panic_register prototype to drm_crtc_internal.h

2024-08-07 Thread Jocelyn Falempe
drm_panic_[un]register() are only used by the core drm, and are not intended to be called by other drm drivers, so move their prototypes to drm_crtc_internal.h. Suggested-by: Daniel Vetter Signed-off-by: Jocelyn Falempe Reviewed-by: Daniel Vetter Reviewed-by: Thomas Zimmermann --- drivers/gpu

[PATCH v2 1/5] drm/panic: Remove space before "!" in panic message

2024-08-07 Thread Jocelyn Falempe
There is no space between the last word, and the punctuation mark in English. Suggested-by: Diego Viola Signed-off-by: Jocelyn Falempe Reviewed-by: Daniel Vetter Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_panic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v2 4/5] drm/panic: Move copyright notice to the top

2024-08-07 Thread Jocelyn Falempe
Move the copyright notice to the top of drm_panic.h, and add the missing Red Hat copyright notice. Suggested-by: Thomas Zimmermann Signed-off-by: Jocelyn Falempe Reviewed-by: Daniel Vetter Reviewed-by: Thomas Zimmermann --- include/drm/drm_panic.h | 9 ++--- 1 file changed, 6 insertions(+

[PATCH v2 5/5] drm/panic: Add panic description

2024-08-07 Thread Jocelyn Falempe
Now that kmsg dump callback has the description parameter, use it in the user panic screen. This is the string passed to panic(), like "VFS: Unable to mount root fs on xxx" or "Attempted to kill init! exitcode=0". It gives a hint on why the panic occurred, without being too cryptic. Signed-off

Re: [PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-07 Thread Leo Li
On 2024-08-07 01:13, Mario Limonciello wrote: On 8/6/24 13:42, Sebastian Wick wrote: From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. Th

RE: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Wednesday, August 7, 2024 3:46 AM To: intel-gfx ; dri-devel Cc: Niemiec, Krzysztof ; Andi Shyti ; Cavitt, Jonathan Subject: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt() > > By moving the pfn calculation to the

RE: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Wednesday, August 7, 2024 2:10 AM To: intel-gfx ; dri-devel Cc: Chris Wilson ; Das, Nirmoy ; Cavitt, Jonathan ; Andi Shyti Subject: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable > > From: Chris Wilson > > After we detect

Re: [PATCH] drm/i915/dg2: Enable Wa_14019159160 for DG2

2024-08-07 Thread Andi Shyti
Hi John, On Mon, Aug 05, 2024 at 05:57:19PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The context switch hold out workaround also applies to DG2. > > Signed-off-by: John Harrison Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 08/12] include: add elf.h support

2024-08-07 Thread Greg Kroah-Hartman
On Wed, Aug 07, 2024 at 02:13:57PM +, Daniel Gomez wrote: > > Also, as this is not internal for the kernel, but rather for userspace > > builds, shouldn't the include/ path be different? > > Can you suggest an alternative path or provide documentation that could help > identify the correct loc

Re: [PATCH 00/12] Enable build system on macOS hosts

2024-08-07 Thread Greg Kroah-Hartman
On Wed, Aug 07, 2024 at 01:56:38PM +, Daniel Gomez wrote: > On Wed, Aug 07, 2024 at 01:01:08PM GMT, Greg Kroah-Hartman wrote: > > On Wed, Aug 07, 2024 at 01:09:14AM +0200, Daniel Gomez via B4 Relay wrote: > > > This patch set allows for building the Linux kernel for arm64 in macOS > > > with >

Re: [PATCH V2 09/16] drm/vc4: v3d: simplify clock retrieval

2024-08-07 Thread Maíra Canal
Hi Stefan, On 8/2/24 10:00, Stefan Wahren wrote: Hi Maíra, Am 02.08.24 um 14:56 schrieb Maíra Canal: Hi Stefan, On 7/31/24 13:41, Stefan Wahren wrote: Hi Maíra, Am 30.07.24 um 13:23 schrieb Maíra Canal: On 7/28/24 10:00, Stefan Wahren wrote: Common pattern of handling deferred probe can b

Patch "drm/vmwgfx: Fix a deadlock in dma buf fence polling" has been added to the 5.15-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Fix a deadlock in dma buf fence polling to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dr

Patch "drm/vmwgfx: Fix a deadlock in dma buf fence polling" has been added to the 6.1-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Fix a deadlock in dma buf fence polling to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm

Patch "drm/ast: astdp: Wake up during connector status detection" has been added to the 6.6-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: astdp: Wake up during connector status detection to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/ast: Fix black screen after resume" has been added to the 6.6-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Fix black screen after resume to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-ast-fix-blac

Patch "drm/vmwgfx: Fix a deadlock in dma buf fence polling" has been added to the 6.6-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Fix a deadlock in dma buf fence polling to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm

Patch "drm/ast: Fix black screen after resume" has been added to the 6.10-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Fix black screen after resume to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-ast-fix-bla

Patch "drm/ast: astdp: Wake up during connector status detection" has been added to the 6.10-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: astdp: Wake up during connector status detection to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/vmwgfx: Fix a deadlock in dma buf fence polling" has been added to the 6.10-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Fix a deadlock in dma buf fence polling to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dr

Patch "drm/vmwgfx: Fix handling of dumb buffers" has been added to the 6.10-stable tree

2024-08-07 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Fix handling of dumb buffers to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-vmwgfx-fi

Re: [PATCH V2 09/16] drm/vc4: v3d: simplify clock retrieval

2024-08-07 Thread Stefan Wahren
Hi Maíra, Am 07.08.24 um 16:31 schrieb Maíra Canal: Hi Stefan, On 8/2/24 10:00, Stefan Wahren wrote: Hi Maíra, Am 02.08.24 um 14:56 schrieb Maíra Canal: Hi Stefan, On 7/31/24 13:41, Stefan Wahren wrote: Hi Maíra, Am 30.07.24 um 13:23 schrieb Maíra Canal: On 7/28/24 10:00, Stefan Wahren w

Re: [PATCH v2] drm/i915: Explicitly cast divisor and use div_u64()

2024-08-07 Thread Andi Shyti
Hi Thorsten, > > /* This check is primarily to ensure that oa_period <= > > -* UINT32_MAX (before passing to do_div which only > > +* UINT32_MAX (before passing it to div_u64 which only > > * accepts a u32 denominator

[PATCH 6.10 022/123] drm/vmwgfx: Make sure the screen surface is ref counted

2024-08-07 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin [ Upstream commit 09f34a00272d2311f6e5d64ed8ad824ef78f7487 ] Fix races issues in virtual crc generation by making sure the surface the code uses for crc computation is properly ref

[PATCH 6.10 091/123] drm/vmwgfx: Fix a deadlock in dma buf fence polling

2024-08-07 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit e58337100721f3cc0c7424a18730e4f39844934f upstream. Introduce a version of the fence ops that on release doesn't remove the fence from the pending list, and thus doesn't requi

[PATCH 6.10 092/123] drm/vmwgfx: Fix handling of dumb buffers

2024-08-07 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit d6667f0ddf46c671d379cd5fe66ce0a54d2a743a upstream. Dumb buffers can be used in kms but also through prime with gallium's resource_from_handle. In the second case the dumb buf

[PATCH 6.10 093/123] drm/ast: astdp: Wake up during connector status detection

2024-08-07 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 0ce91928ec62d189b5c51816e325f02587b53118 upstream. Power up the ASTDP connector for connection status detection if the connector is not active. Keep it powered if a di

[PATCH 6.10 094/123] drm/ast: Fix black screen after resume

2024-08-07 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Jammy Huang commit 12c35c5582acb0fd8f7713ffa75f450766022ff1 upstream. Suspend will disable pcie device. Thus, resume should do full hw initialization again. Add some APIs to ast_drm_thaw() bef

[PATCH 6.6 106/121] drm/vmwgfx: Fix a deadlock in dma buf fence polling

2024-08-07 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit e58337100721f3cc0c7424a18730e4f39844934f upstream. Introduce a version of the fence ops that on release doesn't remove the fence from the pending list, and thus doesn't requir

[PATCH 6.1 32/86] drm/udl: Remove DRM_CONNECTOR_POLL_HPD

2024-08-07 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann [ Upstream commit 5aed213c7c6c4f5dcb1a3ef146f493f18fe703dc ] DisplayLink devices do not generate hotplug events. Remove the poll flag DRM_CONNECTOR_POLL_HPD, as it may not be

[PATCH 6.1 76/86] drm/vmwgfx: Fix a deadlock in dma buf fence polling

2024-08-07 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit e58337100721f3cc0c7424a18730e4f39844934f upstream. Introduce a version of the fence ops that on release doesn't remove the fence from the pending list, and thus doesn't requir

Re: [PATCH v2 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a

2024-08-07 Thread Rob Herring (Arm)
On Tue, 06 Aug 2024 17:44:54 -0400, Richard Acayan wrote: > This adds support for the speed-binned A615 GPU on SDM670. > > Changes since v1 (20240730013844.41951-6-mailingrad...@gmail.com): > - add Acked-by tag (1/4) > - add OPPs exclusive to some speed bins (3/4) > - enable GMU by default (3/4)

[PATCH 0/2] ALSA/DRM: vmalloc PCM buffer helper cleanup

2024-08-07 Thread Takashi Iwai
Hi, we still keep the legacy vmalloc ALSA PCM helper API since there is only a single user of it, namely, the DRM dw-hdmi bridge driver. In the past, I attempted to change the buffer management of the driver, but due to the lack of testing, it failed to get merged: https://lore.kernel.org/201912

[PATCH 1/2] drm/bridge: dw-hdmi: Move vmalloc PCM buffer management into the driver

2024-08-07 Thread Takashi Iwai
The dw-hdmi drm bridge driver is the only one who still uses the ALSA vmalloc helper API functions. A previous attempt to change the way of buffer management wasn't taken for this legacy stuff, as we had little chance for test and some risk of major breaking. Instead, this patch moves the vmalloc

[PATCH 2/2] ALSA: pcm: Drop PCM vmalloc buffer helpers

2024-08-07 Thread Takashi Iwai
As the last-standing user of PCM vmalloc buffer helper API took its own buffer management, we can finally drop those API functions, which were leftover after reorganization of ALSA memalloc code. Signed-off-by: Takashi Iwai --- include/sound/pcm.h | 42 - sound/co

Re: [PATCH 05/12] accessiblity/speakup: genmap and makemapdata require linux/version.h

2024-08-07 Thread Masahiro Yamada
genmap and makemapdata DO NOT require linux/version.h Removing bogus "#include " is the right fix. On Wed, Aug 7, 2024 at 8:10 AM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > Both genmap and makemapdata require the linux/version.h header. To > ensure successful builds on ma

[RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-07 Thread Faith Ekstrand
Previously, AMDGPU_GEM_CREATE_EXPLICIT_SYNC was used to disable implicit synchronization on BOs when explicit synchronization can be used. The problem is that this flag is per-BO and affects all amdgpu users in the system, not just the usermode drver which sets it. This can lead to some unintende

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-07 Thread Leonard Lausen
On 8/7/24 06:44, Dmitry Baryshkov wrote:> Could you please clarify, I was under the impression that currently whole suspend/resume is broken, so it's more than a dmesg message. 71174f362d67 specifically, or v6.9 more broadly regress in that we get "[dpu error]connector not connected 3" and "[drm

Re: [PATCH 06/12] selinux/genheaders: include bitsperlong and posix_types headers

2024-08-07 Thread Masahiro Yamada
On Thu, Aug 8, 2024 at 12:39 AM Nicolas Schier wrote: > > On Wed, Aug 07, 2024 at 01:09:20AM +0200, Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > > > The genheaders requires the bitsperlong.h and posix_types.h headers. > > To ensure these headers are found during compilation on macO

[PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-07 Thread Mary Guillemard
Expose system timestamp and frequency supported by the GPU with a new device query. Mali uses the generic arch timer as GPU system time so we currently wire cntvct_el0 and cntfrq_el0 respectively to a new device query. We could have directly read those values from userland but handling this here a

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-07 Thread Gurchetan Singh
On Tue, Aug 6, 2024 at 1:15 PM Rob Clark wrote: > On Tue, Aug 6, 2024 at 9:15 AM Gurchetan Singh > wrote: > > > > > > > > On Mon, Aug 5, 2024 at 2:14 AM Sergio Lopez Pascual > wrote: > >> > >> Dmitry Osipenko writes: > >> > >> > On 7/23/24 14:49, Sergio Lopez wrote: > >> >> There's an incresin

  1   2   >