Re: [PATCH v2] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

2024-07-29 Thread Daniel Vetter
On Mon, Jul 29, 2024 at 10:46:04AM +0800, Zenghui Yu wrote: > Even if a vgem device is configured in, we will skip the import_vgem_fd() > test almost every time. > > TAP version 13 > 1..11 > # Testing heap: system > # === > # Testing allocation and imp

[PATCH v2 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support

2024-07-29 Thread Steffen Trumtrar
The G070ACE-LH3 is a 7" TFT Color LCD module with WLED backlight. https://www.data-modul.com/sites/default/files/products/G070ACE-LH3-specification-12058417.pdf Signed-off-by: Steffen Trumtrar --- drivers/gpu/drm/panel/panel-simple.c | 35 +++ 1 file changed, 35

[PATCH v2 1/2] dt-bindings: display: simple: Document support for Innolux G070ACE-LH3

2024-07-29 Thread Steffen Trumtrar
Add Innolux G070ACE-LH3 7" WVGA (800x480) TFT LCD panel compatible string. Signed-off-by: Steffen Trumtrar Acked-by: Conor Dooley --- Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v2 0/2] drm/panel: simple: add Innolux G070ACE-LH3

2024-07-29 Thread Steffen Trumtrar
This series adds support for the Innolux G070ACE-LH3 to the panel-simple driver and adds the according compatible to the devicetree bindings. Signed-off-by: Steffen Trumtrar --- Changes in v2: - add acked-by - update [vh]blank min/max values - Link to v1: https://lore.kernel.org/r/20240712-b4-v

[PATCH] drm: Add the missing symbol '.'

2024-07-29 Thread oushixiong1025
From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/gpu/drm/drm_probe_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index bb49d552e671..285290067056 100644 --- a/drivers/gpu/drm/drm_prob

Re: [PATCH v5 2/2] drm/loongson: Add dummy gpu driver as a subcomponent

2024-07-29 Thread Markus Elfring
… > the driver is loaded, drm/loongson driver still need to wait all of needs to wait on …? … > design. Therefore, add a dummy driver for the GPU, … Is there a need to reconsider the categorisation and usability descriptions another bit for such

[PATCH] staging: fbtft: Fix mutex and spinlock without comment warning

2024-07-29 Thread Riyan Dhiman
Adhere to Linux kernel coding style Reported by checkpatch: CHECK: spinlock_t definition without comment CHECK: mutex definition without comment Signed-off-by: Riyan Dhiman --- drivers/staging/fbtft/fbtft.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fbtft.h b/d

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread kevin
> [adding a few people and lists to the recipients] > > Hi! Thx for your rpeort. > > On 27.07.24 18:07, ke...@holm.dev wrote: > > > > > Connecting two 4k displays with display port through a lenovo usb-c > > > > dock (type 40AS) to a Lenovo P14s Gen 2 (type 21A0) results in no > > > > image

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-29 Thread Piotr Zalewski
On Friday, July 26th, 2024 at 1:31 PM, Daniel Stone wrote: > Hi Piotr, Hi Daniel, sorry for delayed response. > > > static void vop2_dither_setup(struct drm_crtc *crtc, u32 *dsp_ctrl) > > @@ -2152,6 +2127,9 @@ static void vop2_crtc_atomic_enable(struct drm_crtc > > *crtc, > > > > vop2_post_co

panel-simple-dp-aux: "DP AUX done_probing() can't defer" on MT8186 w/ Collabora kernel

2024-07-29 Thread Alper Nebi Yasak
Hi, I have a MT8186 "Magneton" Chromebook that I'm trying to boot a kernel based on Collabora's for-kernelci branch [1], using a config from postmarketOS [2] (intended for that), on a Debian sid installation. This sometimes fails to enable the display with: > panel-simple-dp-aux aux-0-0058: DP AU

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-29 Thread Piotr Zalewski
On Friday, July 26th, 2024 at 10:55 AM, Andy Yan wrote: > Hi Piotr Hi Andy! > Thanks for your work. > > On 7/25/24 06:05, Piotr Zalewski wrote: > > > Add support for gamma LUT in VOP2 driver. The implementation is based on > > the one found in VOP driver and modified to be compatible with

Re: [PATCH v5 1/2] drm/loongson: Introduce component framework support

2024-07-29 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/loongson/loongson_drv.c > @@ -0,0 +1,298 @@ … > +static int loongson_drm_driver_probe(struct platform_device *pdev) > +{ … > + dev_info(&pdev->dev, "probed\n"); … > +} … Do you find such information really relevant? Regards, Markus

Re: [PATCH v2] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

2024-07-29 Thread Zenghui Yu
On 2024/7/29 15:01, Daniel Vetter wrote: On Mon, Jul 29, 2024 at 10:46:04AM +0800, Zenghui Yu wrote: > Even if a vgem device is configured in, we will skip the import_vgem_fd() > test almost every time. > > TAP version 13 > 1..11 > # Testing heap: system > # ==

Re: [PATCH v4 2/6] drm/gma500: Make I2C terminology more inclusive

2024-07-29 Thread Thomas Zimmermann
I merged this patch into drm-misc-next. Am 11.07.24 um 07:27 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbangi

Re: [PATCH v5 2/2] drm/loongson: Add dummy gpu driver as a subcomponent

2024-07-29 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/loongson/Makefile > @@ -17,6 +17,9 @@ loongson-y := \ > lsdc_probe.o \ > lsdc_ttm.o > > +loongson-y += \ > + loonggpu_pci_drv.o > + > loongson-y += loongson_device.o \ … Why do you propose to adjust the macro contents multiple times here? (Can it be suffi

Patch "drm/xe: Use write-back caching mode for system memory on DGFX" has been added to the 6.10-stable tree

2024-07-29 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/xe: Use write-back caching mode for system memory on DGFX to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i

[PATCH] MAINTAINERS: Add selftests to DMA-BUF HEAPS FRAMEWORK entry

2024-07-29 Thread Zenghui Yu
Include dmabuf-heaps selftests in the correct entry so that updates to it can be sent to the right place. Signed-off-by: Zenghui Yu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42decde38320..b7f24c9fb0e2 100644 --- a/MAINTAINERS +++ b/MAINTA

Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

2024-07-29 Thread Ricard Wanderlof
Hi, I submitted the patch below a while ago (two months) but as far as I can make out it has not been included. There was an initial concern from Dmitry Baryshkov which was subsequently addressed but no other objections. On Tue, 28 May 2024, Ricard Wanderlof wrote: > > Even though data is

RE: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Lin, Wayne
[Public] Hi, Thanks for the report. Patch fa57924c76d995 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()") is kind of correcting problems causing by commit: 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for mst mode validation") Sorry if it misses fixes tag

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Helge Deller
On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, as already done in the remove function. True. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") I think we can drop this "Fixes" tag, as it gives no real

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Linux regression tracking (Thorsten Leemhuis)
[+Greg +stable] On 29.07.24 10:16, Lin, Wayne wrote: > > Thanks for the report. > > Patch fa57924c76d995 ("drm/amd/display: Refactor function > dm_dp_mst_is_port_support_mode()") > is kind of correcting problems causing by commit: > 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for

[PATCH v5 00/12] spi: add driver for Intel discrete graphics

2024-07-29 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal SPI device. Expose device on auxiliary bus by i915 and Xe drivers and provide spi driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" series with connection to the Xe

[PATCH v5 02/12] spi: intel-dg: implement region enumeration

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler In intel-dg spi, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 190 +++

[PATCH v5 01/12] spi: add driver for intel graphics on-die spi device

2024-07-29 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS | 7 ++ drivers/spi/Kconfig | 11 +++ drivers/spi/Makefile |

[PATCH v5 03/12] spi: intel-dg: implement spi access functions

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler Implement spi_read(), spi_erase() and spi_write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 199 + 1 fil

[PATCH v5 04/12] spi: intel-dg: spi register with mtd

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 111

[PATCH v5 05/12] spi: intel-dg: implement mtd access handlers

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler Implement mtd read, erase, and write handlers. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-o

[PATCH v5 06/12] spi: intel-dg: align 64bit read and write

2024-07-29 Thread Alexander Usyskin
GSC SPI HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/spi/spi-intel-

[PATCH v5 07/12] spi: intel-dg: wake card on operations

2024-07-29 Thread Alexander Usyskin
Enable runtime PM in spi driver to notify graphics driver that whole card should be kept awake while spi operations are performed through this driver. CC: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 44 ++ 1 file changed,

[PATCH v5 08/12] drm/i915/spi: add spi device for discrete graphics

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler Enable access to internal spi on DGFX devices via a child device. The spi child device is exposed via auxiliary bus. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/Makefile| 4 ++ drive

[PATCH v5 09/12] drm/i915/spi: add intel_spi_region map

2024-07-29 Thread Alexander Usyskin
From: Tomas Winkler Add the dGFX spi region map and convey it via auxiliary device to the spi child device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 8 1 file changed, 8 insertions(

[PATCH v5 10/12] drm/i915/spi: add support for access mode

2024-07-29 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/spi/in

[PATCH v5 11/12] drm/xe/spi: add on-die spi device

2024-07-29 Thread Alexander Usyskin
Enable access to internal spi on DGFX with GSC/CSC devices via a child device. The spi child device is exposed via auxiliary bus. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 + drivers/gpu/drm/xe/xe_device_types.h |

[PATCH v5 12/12] drm/xe/spi: add support for access mode

2024-07-29 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 4 drivers/gpu/drm/xe/xe_heci_gsc.c | 5 +--- drivers/gpu/drm/xe/xe_spi.c | 33 ++

RE: [PATCH v2 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings

2024-07-29 Thread Biju Das
> +- port@1 > > Why do you use port@1 for the DPI output here, and not port@0 ? Currently the output is based on port number and port = 1 corresponds to DPI. See [1]. For consistency, I documented bindings for RZ/G2L family DU's similar to RZ/G2{H,M,N,E} DU [

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Linux regression tracking (Thorsten Leemhuis)
On 29.07.24 10:47, Christian Heusel wrote: > On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote: >> [+Greg +stable] >> >> On 29.07.24 10:16, Lin, Wayne wrote: >>> >>> Thanks for the report. >>> >>> Patch fa57924c76d995 ("drm/amd/display: Refactor function >>> dm_dp_mst_is_por

RE: [PATCH v2 5/9] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-07-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: Saturday, July 27, 2024 2:00 AM > Subject: Re: [PATCH v2 5/9] drm: renesas: rz-du: Add RZ/G2UL DU Support > > Hi Biju, > > Thank you for the patch. > > On Tue, Jul 09, 2024 at 02:51:43PM +0100,

RE: [PATCH v2 6/9] arm64: dts: renesas: r9a07g043u: Add vspd node

2024-07-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: Saturday, July 27, 2024 2:08 AM > Subject: Re: [PATCH v2 6/9] arm64: dts: renesas: r9a07g043u: Add vspd node > > Hi Biju, > > Thank you for the patch. > > On Tue, Jul 09, 2024 at 02:51:44PM +010

RE: [PATCH v2 8/9] arm64: dts: renesas: r9a07g043u: Add DU node

2024-07-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: Saturday, July 27, 2024 2:12 AM > Subject: Re: [PATCH v2 8/9] arm64: dts: renesas: r9a07g043u: Add DU node > > Hi Biju, > > Thank you for the patch. > > On Tue, Jul 09, 2024 at 02:51:46PM +0100,

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialized with or plainly take big enough values that, once shifted 8 bi

[PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Geert Uytterhoeven
When building with gcc-5: In function ‘decode_oa_format.isra.26’, inlined from ‘xe_oa_set_prop_oa_format’ at drivers/gpu/drm/xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to ‘__compiletime_assert_1336’ declared with attribute error: FIELD_GET: mask is

Re: [PATCH resend v4 00/11] Improve the copy of task comm

2024-07-29 Thread Jani Nikula
On Mon, 29 Jul 2024, Yafang Shao wrote: > Hello Andrew, > > Is it appropriate for you to apply this to the mm tree? > > Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the > length of task comm. Changes in the task comm could result in a destination > string that is overflow.

[PATCH 0/2] Use pcim_request_region() in vboxvideo

2024-07-29 Thread Philipp Stanner
Hi everyone, Now that we've got the simplified PCI devres API available we can slowly start using it in drivers and step by step phase the more problematic API out. vboxvideo currently does not have a region request, so it is a suitable first user. P. Philipp Stanner (2): PCI: Make pcim_reque

[PATCH 1/2] PCI: Make pcim_request_region() a public function

2024-07-29 Thread Philipp Stanner
pcim_request_region() is the managed counterpart of pci_request_region(). It is currently only used internally for PCI. It can be useful for a number of drivers and exporting it is a step towards deprecating more complicated functions. Make pcim_request_region a public function. Signed-off-by: P

[PATCH 2/2] drm/vboxvideo: Add PCI region request

2024-07-29 Thread Philipp Stanner
vboxvideo currently does not reserve its PCI BAR through a region request. Implement the request through the managed function pcim_request_region(). Signed-off-by: Philipp Stanner --- drivers/gpu/drm/vboxvideo/vbox_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/v

Re: [PATCH v2 1/2] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-07-29 Thread Jani Nikula
On Fri, 26 Jul 2024, Thomas Weißschuh wrote: > Instead of manually passing around 'struct edid *' and its size, > use 'struct drm_edid', which encapsulates a validated combination of > both. > > As the drm_edid_ can handle NULL gracefully, the explicit checks can be > dropped. > > Also save a few

Re: [PATCH v2 2/2] drm/radeon: convert bios_hardcoded_edid to drm_edid

2024-07-29 Thread Jani Nikula
On Fri, 26 Jul 2024, Alex Deucher wrote: > Applied the series. Thanks! Ah, replied to patch 1 before noticing this. Never mind about the bikeshedding. :) BR, Jani. -- Jani Nikula, Intel

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Christian Heusel
On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote: > [+Greg +stable] > > On 29.07.24 10:16, Lin, Wayne wrote: > > > > Thanks for the report. > > > > Patch fa57924c76d995 ("drm/amd/display: Refactor function > > dm_dp_mst_is_port_support_mode()") > > is kind of correcting p

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > @@ -0,0 +1,684 @@ … > static int sharp_memory_update_display(struct sharp_memory_device *smd, > +struct drm_framebuffer *fb, > +struct drm_rect clip, > +

Re: [PATCH v6 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-07-29 Thread Mostafa Saleh
Hi Rob, On Wed, Jul 17, 2024 at 09:36:21AM -0700, Rob Clark wrote: > From: Rob Clark > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > would be traversed for a given iova access. > > Signed-off-by: Rob Clark > Acked-by: Joerg Roedel > > --- > drivers/iommu/io-pg

Re: [PATCH resend v4 00/11] Improve the copy of task comm

2024-07-29 Thread Yafang Shao
On Mon, Jul 29, 2024 at 5:29 PM Jani Nikula wrote: > > On Mon, 29 Jul 2024, Yafang Shao wrote: > > Hello Andrew, > > > > Is it appropriate for you to apply this to the mm tree? > > > > Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the > > length of task comm. Changes in th

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Alex Lanzano
On Mon, Jul 29, 2024 at 01:00:47PM GMT, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > > @@ -0,0 +1,684 @@ > … > > static int sharp_memory_update_display(struct sharp_memory_device *smd, > > + struct drm_framebuffer *fb, > > +

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Konrad Dybcio
On 16.07.2024 1:56 PM, Konrad Dybcio wrote: > On 15.07.2024 10:04 PM, Akhil P Oommen wrote: >> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: >>> On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is >>> abstracted through SMEM, instead of being directly available in a

[PATCH 1/1] MAINTAINERS: Change habanalabs maintainer

2024-07-29 Thread Ofir Bitton
I will be leaving Intel soon, Yaron Avizrat will take the role of habanalabs driver maintainer. Signed-off-by: Ofir Bitton --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ed2d2dbcec81..a4b36590061e 100644 --- a/MAINTAINERS +++ b

[PATCH 0/1] Update on habanalabs maintainer status

2024-07-29 Thread Ofir Bitton
Hi Dave, Sima. As I am about to leave Intel during the next weeks, I'm stepping down from the maintainer role of the habanalabs driver. Yaron Avizrat from Intel will replace me as the new maintainer. Ofir Bitton (1): MAINTAINERS: Change habanalabs maintainer MAINTAINERS | 2 +- 1 file change

Re: [PATCH v5 00/12] spi: add driver for Intel discrete graphics

2024-07-29 Thread Mark Brown
On Mon, Jul 29, 2024 at 11:43:14AM +0300, Alexander Usyskin wrote: > V5: depend solely on AUXILIARY_BUS, not on COMPILE_TEST > disable spi driver on virtual function in Xe, no spi device there > V4: fix white-spaces > add check for discrete graphics missed in i915 intel_spi_fini > V3: re

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Krzysztof Kozlowski
On 29/07/2024 14:05, Alex Lanzano wrote: >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&smd->tx_mutex);”? >> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196 >> > > Ah, I didn't realize guarded mutexes were implemented

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread Thomas Zimmermann
Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards that use AST2600 use the VGA interface instead of the DP interface. In this case, it will use Virtual connector as the DP is disconnected

Re: [PATCH 0/5] drm/ast: Fix DP hotplugging and clean up

2024-07-29 Thread Thomas Zimmermann
Ping for review Am 17.07.24 um 16:24 schrieb Thomas Zimmermann: Here are a number of updates for ast's ASTDP transmitter code. So far the ast driver required the DisplayPort to be connected at boot. Later detection was not supported. Re-connecting the cable was also not supported. Once atomic_d

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread Thomas Zimmermann
Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards that use AST2600 use the VGA interface instead of the DP interface. In this case, it will use Virtual connector as the DP is disconnected

[PATCH] drm/nouveau: remove unused variable ret

2024-07-29 Thread Jani Nikula
Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled: ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function ‘nouveau_platform_probe’: ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable ‘ret’ [-Werror=unused-variable] 29 | int ret; | ^~~

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Konrad Dybcio
On 29.07.2024 2:13 PM, Konrad Dybcio wrote: > On 16.07.2024 1:56 PM, Konrad Dybcio wrote: >> On 15.07.2024 10:04 PM, Akhil P Oommen wrote: >>> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted t

Re: [PATCH v3 0/2] Basic support for TI TDP158

2024-07-29 Thread Marc Gonzalez
On 27/06/2024 13:13, Marc Gonzalez wrote: > Changes in v3: > - Add 'select DRM_PANEL_BRIDGE' in driver Kconfig > - Fix checkpatch errors > - log errors using dev_err (so save dev pointer) > - expand a few error messages > - expand commit messages with info from the datasheet > - mark regulators as

[PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Wolfram Sang
The old email address bounced. I found the newer one in MAINTAINERS, so update entries accordingly. Cc: Konrad Dybcio Signed-off-by: Wolfram Sang --- Against v6.11-rc1. Still needs ack from Konrad Dybcio MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAI

Re: [PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Wolfram Sang
Hi Konrad, > Already sent a series of fixups, but thanks for keeping track Welcome. Cool that you are at it! Happy hacking, Wolfram signature.asc Description: PGP signature

Re: [PATCH] drm/nouveau: remove unused variable ret

2024-07-29 Thread Danilo Krummrich
Hi Jani, On Mon, Jul 29, 2024 at 03:36:24PM +0300, Jani Nikula wrote: > Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled: > > ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function > ‘nouveau_platform_probe’: > ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Lucas De Marchi
On Mon, Jul 29, 2024 at 11:26:34AM GMT, Geert Uytterhoeven wrote: When building with gcc-5: In function ‘decode_oa_format.isra.26’, inlined from ‘xe_oa_set_prop_oa_format’ at drivers/gpu/drm/xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to ‘__compileti

Re: [PATCH v4 01/11] drm/amd/display: clean unused variables for hdmi freesync parser

2024-07-29 Thread Alex Hung
On 2024-07-28 19:32, Melissa Wen wrote: On 07/25, Alex Hung wrote: Hi Melissa, There are no commit messages in this patch. Also, do you think this can be merged with Patch 5 "drm/amd/display: remove redundant freesync parser for DP"? Hi Alex, Thanks for your feedback. I'll add a brief d

Re: [PATCH v4 09/11] drm/amd/display: get SAD from drm_eld when parsing EDID caps

2024-07-29 Thread Alex Hung
On 2024-07-28 20:02, Melissa Wen wrote: On 07/25, Alex Hung wrote: On 2024-07-05 21:35, Melissa Wen wrote: instead of parsing struct edid. A more informative commit message will be helpful. sure. I'll improve it in the next version. A soft reminder - a few other patches need improved

Re: [PATCH v2] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:00:00PM +0800, WangYuli wrote: > The struct assertion is failed because sparse cannot parse > `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. > GCC's output is still 1-byte-aligned. No harm to memory layout. > > The error can be filtered out by sparse-diff, bu

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Akhil P Oommen
On Mon, Jul 29, 2024 at 02:40:30PM +0200, Konrad Dybcio wrote: > > > On 29.07.2024 2:13 PM, Konrad Dybcio wrote: > > On 16.07.2024 1:56 PM, Konrad Dybcio wrote: > >> On 15.07.2024 10:04 PM, Akhil P Oommen wrote: > >>> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: > On recent

Re: [PATCH 3/3] dt-bindings: Batch-update Konrad Dybcio's email

2024-07-29 Thread Rob Herring (Arm)
On Fri, 26 Jul 2024 13:18:25 +0200, Konrad Dybcio wrote: > Use my @kernel.org address everywhere. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: > On 7/28/24 20:29, Christophe JAILLET wrote: > > If an error occurs after request_mem_region(), a corresponding > > release_mem_region() should be called, as already done in the remove > > function. > > True. > > > Fixes: 1da177e4c3f4

[PATCH v2] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread WangYuli
The struct assertion is failed because sparse cannot parse `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. GCC's output is still 1-byte-aligned. No harm to memory layout. The error can be filtered out by sparse-diff, but sometimes multiple lines queezed into one, making the sparse-diff

Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-07-29 Thread Yanjun Yang
On Fri, Jul 26, 2024 at 09:55:35AM +0200, Philippe CORNU wrote: > > > On 7/22/24 10:38, Yanjun Yang wrote: > > > > This patch (commit id:185f99b614427360) seems to break the dsi of > > stm32f469 chip. > > I'm not familiar with the drm and the clock framework, maybe it's > > because there is no >

[PATCH] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread WangYuli
The struct assertion is failed because sparse cannot parse `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. GCC's output is still 1-byte-aligned. No harm to memory layout. The error can be filtered out by sparse-diff, but sometimes multiple lines queezed into one, making the sparse-diff

Re: [PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Konrad Dybcio
On 29.07.2024 2:51 PM, Wolfram Sang wrote: > The old email address bounced. I found the newer one in MAINTAINERS, > so update entries accordingly. > > Cc: Konrad Dybcio > Signed-off-by: Wolfram Sang > --- Already sent a series of fixups, but thanks for keeping track https://lore.kernel.org/

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread kevin
July 29, 2024 at 11:15 AM, "Linux regression tracking (Thorsten Leemhuis)" wrote: > > On 29.07.24 10:47, Christian Heusel wrote: > > > > > On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote: > > > > > > > > [+Greg +stable] > > > > > > On 29.07.24 10:16, Lin, Wayne

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Nikita Zhandarovich
Hi, On 7/29/24 02:23, Christian König wrote: > Am 26.07.24 um 14:52 schrieb Alex Deucher: >> On Fri, Jul 26, 2024 at 3:05 AM Christian König >> wrote: >>> Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialize

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-07-29 Thread Connor Abbott
On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak wrote: > > On A5XX GPUs when preemption is used it's invietable to enter a soft > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > This appears as full UI lockup and not detected as GPU hang (because > it's not). This happens

[PATCH v2] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-29 Thread Nikita Zhandarovich
On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having benn called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this issue by moving conversion

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_r

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: S

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
Hi Stephen On 7/26/2024 5:24 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-07-25 15:03:19) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index a916b5f3b317..56ce5e4008f8 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_pa

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-29 Thread Lyude Paul
On Fri, 2024-07-26 at 15:40 +0200, Daniel Vetter wrote: > On Thu, Jul 25, 2024 at 03:35:18PM -0400, Lyude Paul wrote: > > On Tue, 2024-07-16 at 11:25 +0200, Daniel Vetter wrote: > > > On Mon, Jul 15, 2024 at 02:05:49PM -0300, Daniel Almeida wrote: > > > > Hi Sima! > > > > > > > > > > > > > > > >

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 14:30 schrieb Matthew Brost: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
On 7/27/2024 5:51 AM, Dmitry Baryshkov wrote: On Fri, 26 Jul 2024 at 01:04, Abhinav Kumar wrote: Currently the DP driver hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need to be taken into account. Replace the

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 16:21 schrieb Daniel Vetter: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [PATCH] drm/plane: Fix IS_ERR() vs NULL bug

2024-07-29 Thread Zack Rusin
On Sat, Jul 27, 2024 at 1:32 AM Dan Carpenter wrote: > > The drm_property_create_signed_range() function returns NULL on error, > it doesn't return error pointers. Change the IS_ERR() tests to check > for NULL. > > Fixes: 8f7179a1027d ("drm/atomic: Add support for mouse hotspots") > Signed-off-by

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-29 11:28:35) > > Thanks for the feedback. > > Your change looks valid. We can use this and drop the max_t usage. > > Let me push this with your Suggested-by credits. You can take my Signed-off-by: Stephen Boyd and either squash it in or make a follow-up.

Re: [PATCH v1 1/2] drm/panel: jd9365da: Move the sending location of the 11/29 command

2024-07-29 Thread Dmitry Baryshkov
On Mon, 29 Jul 2024 at 06:10, zhaoxiong lv wrote: > > On Sun, Jul 28, 2024 at 12:59 AM Dmitry Baryshkov > wrote: > > > > On Thu, Jul 25, 2024 at 04:32:44PM GMT, Zhaoxiong Lv wrote: > > > Move the 11/29 command from enable() to init() function > > > > > > As mentioned in the patch: > > > https://l

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Helge Deller
On 7/29/24 17:59, Dan Carpenter wrote: On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, as already done in the remove function. True.

Re: (subset) [PATCH 00/13] rockchip: Enable 4K@60Hz mode on RK3228, RK3328, RK3399 and RK356x

2024-07-29 Thread Heiko Stuebner
On Sat, 15 Jun 2024 17:03:51 +, Jonas Karlman wrote: > This prepares and enable use of HDMI2.0 modes, e.g. 4K@60Hz, on RK3228, > RK3328, RK3399 and RK356x. > > Patch 1-3 fixes some issues to help support use of high-resolution modes. > > Patch 4 fixes reading of EDID on RK3328 when using a fo

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Christophe JAILLET
Le 29/07/2024 à 22:09, Helge Deller a écrit : On 7/29/24 17:59, Dan Carpenter wrote: On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, a

[PATCH v3 1/2] dt-bindings: display: panel: samsung, atna45dc02: Document ATNA45DC02

2024-07-29 Thread Rob Clark
From: Rob Clark The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution. Signed-off-by: Rob Clark Acked-by: Conor Dooley --- .../bindings/display/panel/samsung,atna33xc20.yaml | 9 ++--- 1 file changed

Re: [PATCH 1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

2024-07-29 Thread Danila Tikhonov
On 7/29/24 06:09, Bjorn Andersson wrote: On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote: From: Eugene Lepshy Please make sure the subject prefix matches other changes in the same driver/files. Regards, Bjorn Thanks for the advice "drm/msm/a6xx: --//--" will be better? Bes

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:09:39PM +0200, Helge Deller wrote: > On 7/29/24 17:59, Dan Carpenter wrote: > > On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: > > > On 7/28/24 20:29, Christophe JAILLET wrote: > > > > If an error occurs after request_mem_region(), a corresponding > > > > r

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Dixit, Ashutosh
On Mon, 29 Jul 2024 06:21:20 -0700, Lucas De Marchi wrote: > Hi Lucas, > Reviewed-by: Lucas De Marchi > > That fixes the build, but question to Ashutosh: it's odd to tie the > format to a bspec. What happens on next platform if the HW changes? > Hopefully it doesn't change in an incompatible way

Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-29 Thread Dmitry Baryshkov
On Mon, Jul 29, 2024 at 04:59:14AM GMT, Murthy, Arun R wrote: > Gentle Reminder! > Any comments? First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property. > > Thanks and Regar

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-29 Thread Piotr Zalewski
Hi Andy On Monday, July 29th, 2024 at 4:35 AM, Andy Yan wrote: > > > > + > > > > +static void vop2_crtc_gamma_set(struct vop2 *vop2, struct drm_crtc > > > > *crtc, > > > > + struct drm_crtc_state *old_state) > > > > +{ > > > > + struct drm_crtc_state *state = crtc->state; > > > > + struct vop2_

  1   2   >