[PATCH] drm/scheduler: Use ternary operator in standardized manner

2024-07-15 Thread Philipp Stanner
drm_sched_init() omits the middle operand when using the ternary operator to set the timeout_wq if one has been passed. This is a non-standardized GNU extension to the C language [1]. It decreases code readability and might be read as a bug. Furthermore, it is not consistent with all other places

[PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing

2024-07-15 Thread Zhaoxiong Lv
Elan-ekth6a12nay requires reset to pull down time greater than 10ms, so the configuration post_power_delay_ms is 10, and the chipset initial time is required to be greater than 300ms, so the post_gpio_reset_on_delay_ms is set to 300. Changes between V6 and V5: - PATCH 1/2: Respin the series on top

[PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-15 Thread Zhaoxiong Lv
The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller has a reset gpio. The difference is that they have different post_power_delay_ms. Signed-off-by: Zhaoxiong Lv Acked-by: Conor Dooley --- Changes between V2 and V1: - 1. Respin the series on top of v6.10. v1: https://lore.

[PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing

2024-07-15 Thread Zhaoxiong Lv
Elan-ekth6a12nay requires reset to pull down time greater than 10ms, so the configuration post_power_delay_ms is 10, and the chipset initial time is required to be greater than 300ms, so the post_gpio_reset_on_delay_ms is set to 300. Signed-off-by: Zhaoxiong Lv Reviewed-by: Douglas Anderson ---

[PATCH] drm/test: fix the gem shmem test to map the sg table.

2024-07-15 Thread Dave Airlie
From: Dave Airlie The test here creates an sg table, but never maps it, when we get to drm_gem_shmem_free, the helper tries to unmap and this causes warnings on some platforms and debug kernels. For now, set the dma mask (to avoid swiotlb) and map the sgtable. Fixes: 93032ae634d4 ("drm/test: ad

Re: [PATCH v8 04/17] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-07-15 Thread Louis Chauvet
Le 13/07/24 - 11:38, Maíra Canal a écrit : > On 5/16/24 10:04, Louis Chauvet wrote: > > Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the > > compiler to check if the passed functions take the correct arguments. > > Such typedefs will help ensuring consistency across the code ba

Re: [PATCH v8 03/17] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-07-15 Thread Louis Chauvet
Le 13/07/24 - 11:35, Maíra Canal a écrit : > On 5/16/24 10:04, Louis Chauvet wrote: > > Add some documentation on pixel conversion functions. > > Update of outdated comments for pixel_write functions. > > > > Signed-off-by: Louis Chauvet > > Acked-by: Pekka Paalanen > > --- > > drivers/gpu/drm

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-07-15 Thread Tomi Valkeinen
On 02/07/2024 14:43, Maxime Ripard wrote: Hi Tomi, On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote: On 26/06/2024 18:07, Maxime Ripard wrote: On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote: On 26/06/2024 11:49, Maxime Ripard wrote: Hi, On Wed, Jun 19, 2024 at 12:0

Re: [PATCH] drm/stm: ltdc: check memory returned by devm_kzalloc()

2024-07-15 Thread Raphael Gallais-Pou
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea > --- > > Hi, > > T

Re: [PATCH] agp: uninorth: add missing MODULE_DESCRIPTION() macro

2024-07-15 Thread Daniel Vetter
On Thu, Jul 11, 2024 at 01:27:23PM -0600, Jeffrey Hugo wrote: > On 7/11/2024 12:19 PM, Jeff Johnson wrote: > > On 6/28/24 20:14, Jeff Johnson wrote: > > > On 6/15/2024 2:01 PM, Jeff Johnson wrote: > > > > With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: > > > > WARNING: modpost: missin

[PATCH] drm/test: fix the gem shmem test to map the sg table.

2024-07-15 Thread Dave Airlie
From: Dave Airlie The test here creates an sg table, but never maps it, when we get to drm_gem_shmem_free, the helper tries to unmap and this causes warnings on some platforms and debug kernels. This also sets a 64-bit dma mask, as I see an swiotlb warning if I stick with the default 32-bit one.

[PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld.

2024-07-15 Thread Philip Mueller
Signed-off-by: Philip Mueller --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 3860a8ce1e2d..903f4bfea7e8 100644 --- a/drivers/gpu/drm

[bug report] drm/vblank: Hard lockup in __disable_vblank()

2024-07-15 Thread Yu Liao
Hi, A hard lockup is happened when I do fuzz test with syzkaller. Kernel panic - not syncing: Hard LOCKUP CPU: 3 PID: 0 Comm: swapper/3 Not tainted 6.6.0+ #21 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: hrtimer

[PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-07-15 Thread Philip Mueller
This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. Signed-off-by: Philip Mueller --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_ori

Re: [PATCH 2/2] drm/amd/display: use drm_crtc_set_vblank_offdelay()

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 05:13:18PM -0400, Hamza Mahfooz wrote: > On 7/10/24 04:43, Daniel Vetter wrote: > > On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote: > > > On 7/9/24 06:09, Daniel Vetter wrote: > > > > On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote: > > > > > On

Re: [PATCH v3] accel/ivpu: Add missing MODULE_FIRMWARE metadata

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 12:23:06PM +0200, Jacek Lawrynowicz wrote: > Reviewed-by: Jacek Lawrynowicz I'm assuming you'll also apply this one? -Sima > > On 09.07.2024 13:54, Alexander F. Lent wrote: > > Modules that load firmware from various paths at runtime must declare > > those paths at compi

Re: [PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 04:19:53PM +0206, John Ogness wrote: > On 2024-07-10, Daniel Vetter wrote: > > console_lock is the outermost subsystem lock for a lot of subsystems, > > which means get/put_user must nest within. Which means it cannot be > > acquired somewhere deeply nested in other locks,

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 04:14:18PM +0200, Christian König wrote: > Am 10.07.24 um 15:57 schrieb Lei Liu: > > Use vm_insert_page to establish a mapping for the memory allocated > > by dmabuf, thus supporting direct I/O read and write; and fix the > > issue of incorrect memory statistics after mappin

Re: [PATCH v3] accel/ivpu: Add missing MODULE_FIRMWARE metadata

2024-07-15 Thread Jacek Lawrynowicz
Hi, On 15.07.2024 10:41, Daniel Vetter wrote: > On Wed, Jul 10, 2024 at 12:23:06PM +0200, Jacek Lawrynowicz wrote: >> Reviewed-by: Jacek Lawrynowicz > > I'm assuming you'll also apply this one? > -Sima Sure >> On 09.07.2024 13:54, Alexander F. Lent wrote: >>> Modules that load firmware from va

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-15 Thread Daniel Vetter
On Thu, Jul 11, 2024 at 02:01:18AM +0200, Danilo Krummrich wrote: > (+Sima) > > Hi Daniel, > > On 7/11/24 12:50 AM, Daniel Almeida wrote: > > Dump the state of the GPU. This feature is useful for debugging purposes. > > --- > > Hi everybody! > > > > For those looking for a branch instead, see [0

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-15 Thread Lei Liu
On 2024/7/11 22:25, Christian König wrote: Am 10.07.24 um 18:34 schrieb T.J. Mercier: On Wed, Jul 10, 2024 at 8:08 AM Lei Liu wrote: on 2024/7/10 22:48, Christian König wrote: Am 10.07.24 um 16:35 schrieb Lei Liu: on 2024/7/10 22:14, Christian König wrote: Am 10.07.24 um 15:57 schrieb Lei

Re: [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc

2024-07-15 Thread Raphael Gallais-Pou
On 6/24/24 04:41, Jiapeng Chong wrote: > The function are defined in the ltdc.c file, but not called > anywhere, so delete the unused function. > > drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn

Re: [PATCH 1/2] dma-buf: heaps: DMA_HEAP_IOCTL_ALLOC_READ_FILE framework

2024-07-15 Thread Daniel Vetter
On Thu, Jul 11, 2024 at 11:00:02AM +0200, Christian König wrote: > Am 11.07.24 um 09:42 schrieb Huan Yang: > > Some user may need load file into dma-buf, current > > way is: > >1. allocate a dma-buf, get dma-buf fd > >2. mmap dma-buf fd into vaddr > >3. read(file_fd, vaddr, fsz) > > Thi

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-15 Thread Steven Price
On 12/07/2024 15:35, Daniel Almeida wrote: > Hi Steven, thanks for the review! > >> >> This is defining the ABI to userspace and as such we'd need a way of >> exporting this for userspace tools to use. The C approach is a header in >> include/uabi. I'd also suggest making it obvious this enum can'

Re: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-07-15 Thread Raphael Gallais-Pou
On 2/16/24 13:50, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes(), > drm_universal_plane_init() and drm_encoder_init(). These functions > should not be called with parameters allocated with devm_kzalloc() > to avoid use-after-free issues [1]. > > Use allocations mana

Re: [PATCH v3] accel/ivpu: Add missing MODULE_FIRMWARE metadata

2024-07-15 Thread Jacek Lawrynowicz
Applied to drm-misc-next On 09.07.2024 13:54, Alexander F. Lent wrote: > Modules that load firmware from various paths at runtime must declare > those paths at compile time, via the MODULE_FIRMWARE macro, so that the > firmware paths are included in the module's metadata. > > The accel/ivpu drive

[PATCH 0/7] drm/probe-helpers: Work around multi-outputs-per-CRTC problem

2024-07-15 Thread Thomas Zimmermann
Old or simple hardware only supports a single CRTC with multiple conenctoed outputs. This breaks most userspace compositors, which only support a single output per CRTC. This currently happens with ast and mgag200 drivers. The drivers contain a work around that dynamically disables all but one conn

[PATCH 2/7] drm/probe-helper: Optionally report single connected output per CRTC

2024-07-15 Thread Thomas Zimmermann
For CRTCs with multiple outputs (i.e., encoders plus connectors), only report at most a single connected output to userspace. Make this configurable via CONFIG_DRM_REPORT_SINGLE_CONNECTED_CRTC_OUTPUT. Having multiple connected outputs on the same CRTC complicates display-mode and format selection,

[PATCH 1/7] drm/probe-helper: Call connector detect functions in single helper

2024-07-15 Thread Thomas Zimmermann
Move the logic to call the connector's detect helper into a single internal function. Reduces code dupliction. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_probe_helper.c | 33 +++--- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/

[PATCH 3/7] drm/ast: Set connector priorities

2024-07-15 Thread Thomas Zimmermann
Call drm_probe_helper_prioritize_connectors() to set connector priorities. Guarantees that only a single output is connected at a time. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/driv

[PATCH 5/7] drm/ast: Support ASTDP and VGA at the same time

2024-07-15 Thread Thomas Zimmermann
AST2600 can host VGA and DisplayPort outputs. Support both on the same device. As userspace can often only support a single output per CRTC, connectors are prioritized against each other by the probe helpers. Reported-by: Shixiong Ou Closes: https://lore.kernel.org/dri-devel/20240711090102.35221

[PATCH 7/7] drm/mgag200: Remove struct mgag200_bmc_connector

2024-07-15 Thread Thomas Zimmermann
Mgag200's BMC connector tracks the status of an underlying physical connector and set BMC status accordingly. This functionality has been moved into probe helpers. The BMC is always connected and the helpers compute the correct status. Hence, remove the driver's dedicated code. Signed-off-by: Thom

[PATCH 6/7] drm/mgag200: Set connector priorities

2024-07-15 Thread Thomas Zimmermann
Call drm_probe_helper_prioritize_connectors() to set connector priorities. Guarantees that only a single output is connected at a time. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_g200eh.c | 2 ++ drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 2 ++ drivers/gpu/drm/mgag200

[PATCH 4/7] drm/ast: Remove struct ast_bmc_connector

2024-07-15 Thread Thomas Zimmermann
Ast's BMC connector tracks the status of an underlying physical connector and set BMC status accordingly. This functionality has been moved into probe helpers. The BMC is always connected and the helpers compute the correct status. Hence, remove the driver's dedicated code. Signed-off-by: Thomas Z

[PATCH v2 0/4] MIPI DSI Controller support for SAM9X75 series

2024-07-15 Thread Manikandan Muralidharan
This patch series adds support for the Microchip's MIPI DSI Controller wrapper driver that uses the Synopsys DesignWare MIPI DSI host controller bridge for SAM9X75 SoC series. Changelogs are available in respective patches. Manikandan Muralidharan (4): dt-bindings: display: bridge: add sam9x75-

[PATCH v2 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

2024-07-15 Thread Manikandan Muralidharan
Add the 'sam9x75-mipi-dsi' compatible binding, which describes the Microchip's specific wrapper for the Synopsys DesignWare MIPI DSI HOST Controller for the sam9x75 series System-on-Chip (SoC) devices. Signed-off-by: Manikandan Muralidharan --- changes in v2: - List the clocks with description -

[PATCH v2 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

2024-07-15 Thread Manikandan Muralidharan
Add the Microchip's DSI controller wrapper driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Manikandan Muralidharan --- changes in v2: - use static const with global variables - replace dev_err with dev_err_probe - move clk_prepare_enable to simplify the er

[PATCH v2 3/4] MAINTAINERS: add SAM9X7 SoC's Microchip's MIPI DSI host wrapper driver

2024-07-15 Thread Manikandan Muralidharan
Add the Microchip's DSI controller wrapper driver that uses the Synopsys DesignWare MIPI DSI host controller bridge for the SAM9X7 SoC series to the MAINTAINERS entry. Signed-off-by: Manikandan Muralidharan --- changes in v3: - Drop T: section --- MAINTAINERS | 7 +++ 1 file changed, 7 inse

[PATCH v2 4/4] ARM: configs: at91: Enable Microchip's MIPI DSI Host Controller support

2024-07-15 Thread Manikandan Muralidharan
Enable the Microchip's DSI controller wrapper driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Manikandan Muralidharan --- arch/arm/configs/at91_dt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm

Re: [PATCH 4/4] drm/tidss: Add OLDI bridge support

2024-07-15 Thread Aradhya Bhatia
Hi Tomi, Thank you for reviewing the patches! On 27/06/24 18:41, Tomi Valkeinen wrote: > On 11/05/2024 22:30, Aradhya Bhatia wrote: >> Up till now, the OLDI support in tidss was integrated within the tidss >> dispc. >> This was fine till the OLDI was one-to-mapped with the DSS video-port >> (VP).

Re: [PATCH v9 00/53] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2024-07-15 Thread Łukasz Bartosik
On Sat, Jul 13, 2024 at 11:45 PM wrote: > > On Fri, Jul 12, 2024 at 9:44 AM Łukasz Bartosik wrote: > > > > On Wed, Jul 3, 2024 at 12:14 AM wrote: > > > > > > On Tue, Jul 2, 2024 at 4:01 PM Luis Chamberlain wrote: > > > > > > > > On Tue, Jul 02, 2024 at 03:56:50PM -0600, Jim Cromie wrote: > > >

Re: [PATCH 1/2] drm: Add might_fault to drm_modeset_lock priming

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 02:40:04PM +0200, Christian König wrote: > Am 10.07.24 um 13:58 schrieb Daniel Vetter: > > On Wed, 10 Jul 2024 at 13:39, Christian König > > wrote: > > > Am 10.07.24 um 11:31 schrieb Daniel Vetter: > > > > We already teach lockdep that dma_resv nests within drm_modeset_loc

[PATCH] drm/dp_mst: Simplify character output in drm_dp_mst_dump_topology()

2024-07-15 Thread Markus Elfring
From: Markus Elfring Date: Mon, 15 Jul 2024 13:12:10 +0200 Single characters should be put into a sequence. Thus use the corresponding function “seq_putc” for one selected call. This issue was transformed by using the Coccinelle software. Suggested-by: Christophe Jaillet Signed-off-by: Markus

Re: [PATCH v1 1/1] drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters

2024-07-15 Thread Dmitry Baryshkov
On Mon, 15 Jul 2024 at 06:19, Zhaoxiong Lv wrote: > > The current driver can only obtain the porch parameters > of boe-th101mb31ig002. Modify it to obtain the porch > parameters of the panel currently being used. > > Fixes: 24179ff9a2e4524 ("drm/panel: boe-th101mb31ig002 : Make it compatible > wi

[PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-15 Thread Markus Elfring
From: Markus Elfring Date: Mon, 15 Jul 2024 13:36:54 +0200 Single characters should be put into a sequence. Thus use the corresponding function “seq_putc” for one selected call. This issue was transformed by using the Coccinelle software. Suggested-by: Christophe Jaillet Signed-off-by: Markus

Re: linux-next: build warning after merge of the drm-intel tree

2024-07-15 Thread Maarten Lankhorst
Hey, Den 2024-07-15 kl. 06:21, skrev Golani, Mitulkumar Ajitkumar: > > On 15-07-2024 04:42, Stephen Rothwell wrote: >> Hi all, >> >> On Wed, 12 Jun 2024 14:11:10 +1000 Stephen Rothwell >> wrote: >>> After merging the drm-intel tree, today's linux-next build (htmldocs) >>> produced this warning:

[PATCH v2 0/4] drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel

2024-07-15 Thread Stephan Gerhold
The backlight of the Samsung ATNA45AF01 panel used in the Qualcomm X1E80100 CRD does not work correctly with the current display panel configuration and drivers: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel need

[PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the

[PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-15 Thread Stephan Gerhold
The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-sam

[PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-15 Thread Stephan Gerhold
The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger

[PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-15 Thread Stephan Gerhold
This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7d32fca6499

[PATCH v6 0/6] HDMI TX support in msm8998

2024-07-15 Thread Marc Gonzalez
DT bits required for HDMI TX support in qcom APQ8098 (MSM8998 cousin) --- Changes in v6: - Fold HDMI PHY driver submission into this series => [PATCH v2] drm/msm: add msm8998 hdmi phy/pll support => Link to v2: https://lore.kernel.org/all/20240704-hdmi-phy-v2-1-a7f5af202...@freebox.fr/ -

[PATCH v6 5/6] arm64: dts: qcom: msm8998: add HDMI GPIOs

2024-07-15 Thread Marc Gonzalez
MSM8998 GPIO pin controller reference design defines: - CEC: pin 31 - DDC: pin 32,33 - HPD: pin 34 Downstream vendor code for reference: https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi#L2324-2400 mdss_hdmi_

[PATCH v6 4/6] drm/msm: add msm8998 hdmi phy/pll support

2024-07-15 Thread Marc Gonzalez
From: Arnaud Vrac Add support for the HDMI PHY as present on the Qualcomm MSM8998 SoC. This code is mostly copy & paste of the vendor code from msm-4.4 kernel.lnx.4.4.r38-rel. Signed-off-by: Arnaud Vrac Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/msm/Makefile | 1 + d

[PATCH v6 2/6] dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998

2024-07-15 Thread Marc Gonzalez
HDMI TX block embedded in the APQ8098. Reviewed-by: Rob Herring (Arm) Reviewed-by: Conor Dooley Signed-off-by: Marc Gonzalez --- .../devicetree/bindings/display/msm/hdmi.yaml | 28 -- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetr

[PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Marc Gonzalez
Current driver already supports the msm8998 HDMI TX. We just need to add the compatible string. Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 24abcb7254c

[PATCH v6 6/6] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-15 Thread Marc Gonzalez
From: Arnaud Vrac Port device nodes from vendor code. Signed-off-by: Arnaud Vrac Reviewed-by: Dmitry Baryshkov Signed-off-by: Marc Gonzalez --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 100 +- 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/arch/a

[PATCH v6 1/6] dt-bindings: phy: add qcom,hdmi-phy-8998

2024-07-15 Thread Marc Gonzalez
HDMI PHY block embedded in the APQ8098. Acked-by: Rob Herring (Arm) Acked-by: Vinod Koul Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yam

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Johan Hovold
On Mon, Jul 15, 2024 at 02:15:38PM +0200, Stephan Gerhold wrote: > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > The panel should be handled through the samsung-atna33xc20 driver for > correct power up timings. Otherwise the backlight does not work correctly. > > We have exist

Re: [PATCH 1/2] dma-buf: heaps: DMA_HEAP_IOCTL_ALLOC_READ_FILE framework

2024-07-15 Thread Christian König
Am 15.07.24 um 11:11 schrieb Daniel Vetter: On Thu, Jul 11, 2024 at 11:00:02AM +0200, Christian König wrote: Am 11.07.24 um 09:42 schrieb Huan Yang: Some user may need load file into dma-buf, current way is: 1. allocate a dma-buf, get dma-buf fd 2. mmap dma-buf fd into vaddr 3. read

Re: [PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-15 Thread Johan Hovold
On Mon, Jul 15, 2024 at 02:15:39PM +0200, Stephan Gerhold wrote: > The backlight does not work correctly with the current display panel > configuration: It works after boot, but once the display gets disabled it > is not possible to get it back on. It turns out that the ATNA45AF01 panel > needs exa

Re: [PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-15 Thread Johan Hovold
On Mon, Jul 15, 2024 at 02:15:40PM +0200, Stephan Gerhold wrote: > This is needed for the display panel to work on the Qualcomm > sc7180-trogdor-homestar and x1e80100-crd. > > Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold

Re: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-15 Thread Neil Armstrong
On 15/07/2024 14:15, Stephan Gerhold wrote: The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Neil Armstrong
Hi, On 15/07/2024 14:15, Stephan Gerhold wrote: This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel th

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:15, Stephan Gerhold wrote: > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > > > The panel should be handled through the samsung-atna33xc20 driver for > > correct power up timings. Otherwise the

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Neil Armstrong
On 15/07/2024 14:54, Stephan Gerhold wrote: On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: On 15/07/2024 14:15, Stephan Gerhold wrote: This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct po

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Johan Hovold
On Mon, Jul 15, 2024 at 02:54:59PM +0200, Stephan Gerhold wrote: > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > > How will we handle current/old crd DT with new kernels ? > > I think this is answered in the commit message: > > > > We have existing users of this panel through

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
On Mon, Jul 15, 2024 at 03:01:57PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:54, Stephan Gerhold wrote: > > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > > > On 15/07/2024 14:15, Stephan Gerhold wrote: > > > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. >

Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-15 Thread Ilia Mirkin
On Mon, Jul 15, 2024 at 7:49 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Mon, 15 Jul 2024 13:36:54 +0200 > > Single characters should be put into a sequence. > Thus use the corresponding function “seq_putc” for one selected call. > > This issue was transformed by using the Coccinell

Re: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-15 Thread Doug Anderson
Hi, Reviewed-by: Douglas Anderson On Mon, Jul 15, 2024 at 5:16 AM Stephan Gerhold wrote: > > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > control over the DP AUX channel. While it works almost correctly with the > generic "edp-panel" compatible, the backlight needs

Re: [PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 5:16 AM Stephan Gerhold wrote: > > This is needed for the display panel to work on the Qualcomm > sc7180-trogdor-homestar and x1e80100-crd. > > Signed-off-by: Stephan Gerhold > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) I'd assume tha

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

2024-07-15 Thread Hans de Goede
Hi, On 7/15/24 6:57 AM, Philip Mueller wrote: > This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld. > > Signed-off-by: Philip Mueller Thanks, patch looks good to me: Reviewed-by: Hans de Goede I have pushed this to drm-misc-fixes now. Regards, Hans > --- > dri

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 6:02 AM Neil Armstrong wrote: > > On 15/07/2024 14:54, Stephan Gerhold wrote: > > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > >> On 15/07/2024 14:15, Stephan Gerhold wrote: > >>> This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > >>>

[PATCH] drm/gpuvm: fix missing dependency to DRM_EXEC

2024-07-15 Thread Danilo Krummrich
In commit 50c1a36f594b ("drm/gpuvm: track/lock/validate external/evicted objects") we started using drm_exec, but did not select DRM_EXEC in the Kconfig for DRM_GPUVM, fix this. Cc: Christian König Cc: Boris Brezillon Cc: Thomas Hellström Fixes: 50c1a36f594b ("drm/gpuvm: track/lock/validate ext

Re: [PATCH] drm/gpuvm: fix missing dependency to DRM_EXEC

2024-07-15 Thread Christian König
Am 15.07.24 um 15:51 schrieb Danilo Krummrich: In commit 50c1a36f594b ("drm/gpuvm: track/lock/validate external/evicted objects") we started using drm_exec, but did not select DRM_EXEC in the Kconfig for DRM_GPUVM, fix this. Cc: Christian König Cc: Boris Brezillon Cc: Thomas Hellström Fixes:

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread neil . armstrong
On 15/07/2024 15:51, Doug Anderson wrote: Hi, On Mon, Jul 15, 2024 at 6:02 AM Neil Armstrong wrote: On 15/07/2024 14:54, Stephan Gerhold wrote: On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: On 15/07/2024 14:15, Stephan Gerhold wrote: This reverts commit 8ebb1fc2e69ab8b89a

Re: [PATCH v1 0/1] Fix the way to get porch parameters

2024-07-15 Thread Doug Anderson
Hi, On Sun, Jul 14, 2024 at 8:18 PM Zhaoxiong Lv wrote: > > The current driver can only obtain the porch parameters > of boe-th101mb31ig002. Modify it to obtain the porch > parameters of the panel currently being used. > > Zhaoxiong Lv (1): > drm/panel: boe-th101mb31ig002 : Fix the way to get p

Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv wrote: > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > has a reset gpio. The difference is that they have different > post_power_delay_ms. > > Signed-off-by: Zhaoxiong Lv > Acked-by: Conor Dooley FWIW things have c

Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms.

Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 7:22 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms. >

Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 7:31 AM Conor Dooley wrote: > > On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > > wrote: > > > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > > has a rese

Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Dmitry Baryshkov
On Mon, Jul 15, 2024 at 02:21:16PM GMT, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. > > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitr

Re: [PATCH v6 4/6] drm/msm: add msm8998 hdmi phy/pll support

2024-07-15 Thread Dmitry Baryshkov
On Mon, Jul 15, 2024 at 02:21:17PM GMT, Marc Gonzalez wrote: > From: Arnaud Vrac > > Add support for the HDMI PHY as present on the Qualcomm MSM8998 SoC. > This code is mostly copy & paste of the vendor code from msm-4.4 > kernel.lnx.4.4.r38-rel. > > Signed-off-by: Arnaud Vrac > Signed-off-by:

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-15 Thread Maxime Ripard
On Thu, Jul 04, 2024 at 07:04:41PM GMT, Marc Gonzalez wrote: > On 01/07/2024 15:50, Maxime Ripard wrote: > > > The i2c register access (and the whole behaviour of the device) is > > constrained on the I2C_EN pin status, and you can't read it from the > > device, so it's also something we need to h

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Doug Anderson
Hi, On Mon, Jul 15, 2024 at 6:57 AM wrote: > > On 15/07/2024 15:51, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 15, 2024 at 6:02 AM Neil Armstrong > > wrote: > >> > >> On 15/07/2024 14:54, Stephan Gerhold wrote: > >>> On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > On

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-15 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: > On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > > On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: > > > On 01/07/2024 15:50, Maxime Ripard wrote: > > > > > > > On Thu, Jun 27, 2024 at 01:13:03PM GMT, Marc

[PATCH v2] drm/vkms: Fix cpu_to_le16()/le16_to_cpu() warnings

2024-07-15 Thread José Expósito
Building with Sparse enabled prints this warning for cpu_to_le16() calls: warning: incorrect type in assignment (different base types) expected unsigned short [usertype] got restricted __le16 [usertype] And this warning for le16_to_cpu() calls: warning: cast to restricted

Re: [PATCH] drm/vkms: Fix cpu_to_le16()/le16_to_cpu() warnings

2024-07-15 Thread José Expósito
On Sun, Jul 14, 2024 at 09:41:10PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.07.24 um 18:16 schrieb José Expósito: > > Building with Sparse enabled prints this warning for cpu_to_le16() > > calls: > > > > warning: incorrect type in assignment (different base types) > > expected

Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. Why is this required when the driver change suggests that this device is compatible with the existing 8974? > > Signed-off-by: Marc G

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2024-07-15 Thread José Expósito
On Fri, May 17, 2024 at 06:00:11PM +0200, Louis Chauvet wrote: > > > > Hi Louis, > > > > > > > > If you could share a RFC/WIP series it would be awesome! > > Hi all! > > I just uploaded my WIP series to github here [1]. Most of the work is > extracted from the current ConfigFS series, I just sp

Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote: > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > > Current driver already supports the msm8998 HDMI TX. > > We just need to add the compatible string. > > Why is this required when the driver change suggests that this

Re: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 02:15:37PM +0200, Stephan Gerhold wrote: > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > control over the DP AUX channel. While it works almost correctly with the > generic "edp-panel" compatible, the backlight needs special handling to > work corr

Re: [PATCH v2] drm/vkms: Fix cpu_to_le16()/le16_to_cpu() warnings

2024-07-15 Thread Thomas Zimmermann
Hi Am 15.07.24 um 17:16 schrieb José Expósito: Building with Sparse enabled prints this warning for cpu_to_le16() calls: warning: incorrect type in assignment (different base types) expected unsigned short [usertype] got restricted __le16 [usertype] And this warning for

RE: [PATCH] drm/test: fix the gem shmem test to map the sg table.

2024-07-15 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of Dave >Airlie >Sent: Monday, July 15, 2024 4:36 AM >To: dri-devel@lists.freedesktop.org >Subject: [PATCH] drm/test: fix the gem shmem test to map the sg table. > >From: Dave Airlie > >The test here creates an sg table, but never maps it, wh

Re: [PATCH v2 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 03:27:33PM +0530, Manikandan Muralidharan wrote: > + clocks: > +items: > + - description: > + Peripheral clock for the hardware block functionality > + - description: > + Generic clock to drive the D-PHY PLL block What is "generic" about thi

Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Dmitry Baryshkov
On Mon, 15 Jul 2024 at 18:28, Conor Dooley wrote: > > On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote: > > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > > > Current driver already supports the msm8998 HDMI TX. > > > We just need to add the compatible string. > > > >

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-15 Thread Dmitry Baryshkov
On Mon, 15 Jul 2024 at 17:42, Maxime Ripard wrote: > > On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: > > On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > > > On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: > > > > On 01/07/2024 15:50, Maxime Ripard wrot

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread neil . armstrong
On 15/07/2024 16:40, Doug Anderson wrote: Hi, On Mon, Jul 15, 2024 at 6:57 AM wrote: On 15/07/2024 15:51, Doug Anderson wrote: Hi, On Mon, Jul 15, 2024 at 6:02 AM Neil Armstrong wrote: On 15/07/2024 14:54, Stephan Gerhold wrote: On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong w

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-07-15 Thread Doug Anderson
Hi, On Fri, Jun 21, 2024 at 1:46 PM Doug Anderson wrote: > > Hi, > > On Fri, Jun 21, 2024 at 1:45 PM Douglas Anderson > wrote: > > > > At shutdown if you've got a _properly_ coded DRM modeset driver then > > you'll get these two warnings at shutdown time: > > > > Skipping disable of already d

[PATCH] drm/buddy: Fix drm_buddy_print() to work with printk printers

2024-07-15 Thread Michal Wajdeczko
If we try to use printk-based drm_printer, like drm_dbg_printer(), output from drm_buddy_print() will be split into several lines: [drm] chunk_size: 1024KiB, total: 7MiB, free: 7MiB, clear_free: 0MiB [drm] order- 2 [drm] free:4 MiB [drm] , blocks: 1 [drm] order- 1 [drm] free:

  1   2   >