Re: [PATCH] drm/nouveau: Use kmemdup_array() instead of kmemdup()

On Mon, Jun 17, 2024 at 05:55:33PM +0200, Danilo Krummrich wrote: > On 6/17/24 11:33, Dan Carpenter wrote: > > Use kmemdup_array() because we're allocating an array. > > > > The main difference between kmemdup() and kmemdup_array() is that the > > kmemdup_array() function has integer overflow chec

Re: [PATCH 04/15] net: hbl_cn: QP state machine

On Tue, Jun 18, 2024 at 05:50:15AM +, Omer Shpigelman wrote: > On 6/17/24 16:18, Leon Romanovsky wrote: > > [Some people who received this message don't often get email from > > l...@kernel.org. Learn why this is important at > > https://aka.ms/LearnAboutSenderIdentification ] > > > > On Thu

Re: [PATCH] fbdev: amifb: add missing MODULE_DESCRIPTION() macro

On Tue, Jun 18, 2024 at 5:14 AM Jeff Johnson wrote: > With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/amifb.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson Revie

Re: [PATCH] fbdev: c2p_planar: add missing MODULE_DESCRIPTION() macro

On Tue, Jun 18, 2024 at 5:05 AM Jeff Johnson wrote: > With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/video/fbdev/c2p_planar.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson

[PATCH v5 00/12] TTM shrinker helpers and xe buffer object shrinker

This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on two previous series, *and obsoletes these*. First https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg484425.html Second the previous TTM shrinker series https://lore.kernel.org/linux-mm/b74913

[PATCH v5 01/12] drm/ttm: Allow TTM LRU list nodes of different types

To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node might otherwise disappear from the list while the it

[PATCH v5 02/12] drm/ttm: Slightly clean up LRU list iteration

To make the transition to using lru hitches easier, simplify the ttm_resource_manager_next() interface to only take the cursor and reuse ttm_resource_manager_next() functionality from ttm_resource_manager_first(). Cc: Christian König Cc: Somalapuram Amaranath Cc: Matthew Brost Cc: Signed-off-b

[PATCH v5 04/12] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

To address the problem with hitches moving when bulk move sublists are lru-bumped, register the list cursors with the ttm_lru_bulk_move structure when traversing its list, and when lru-bumping the list, move the cursor hitch to the tail. This also means it's mandatory for drivers to call ttm_lru_bu

[PATCH v5 03/12] drm/ttm: Use LRU hitches

Have iterators insert themselves into the list they are iterating over using hitch list nodes. Since only the iterator owner can remove these list nodes from the list, it's safe to unlock the list and when continuing, use them as a starting point. Due to the way LRU bumping works in TTM, newly adde

[PATCH v5 06/12] drm/ttm: Use the LRU walker helper for swapping

Rework the TTM swapping to use the LRU walker helper. This helps fixing up the ttm_bo_swapout() interface to be consistent about not requiring any locking. For now mimic the current behaviour of using trylock only. We could be using ticket-locks here but defer that until it's deemed necessary. The

[PATCH v5 07/12] drm/ttm: Use the LRU walker for eviction

Use the LRU walker for eviction. This helps removing a lot of code with weird locking semantics. The functionality is slightly changed so that when trylocked buffer objects are exhausted, we continue to interleave walks with ticket-locks while there is still progress made. The list walks are not r

[PATCH v5 05/12] drm/ttm: Provide a generic LRU walker helper

Provide a generic LRU walker in TTM, in the spirit of drm_gem_lru_scan() but building on the restartable TTM LRU functionality. The LRU walker optionally supports locking objects as part of a ww mutex locking transaction, to mimic to some extent the current functionality in ttm. However any -EDEAD

[PATCH v5 09/12] drm/ttm/pool: Provide a helper to shrink pages

Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to back them up. In the future we could allow ttm_bac

[PATCH v5 10/12] drm/ttm: Use fault-injection to test error paths

Use fault-injection to test partial TTM swapout and interrupted swapin. Return -EINTR for swapin to test the callers ability to handle and restart the swapin, and on swapout perform a partial swapout to test that the swapin and release_shrunken functionality. Cc: Christian König Cc: Somalapuram A

[PATCH v5 12/12] drm/xe: Increase the XE_PL_TT watermark

The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_SYSTEM memor

[PATCH v5 08/12] drm/ttm: Add a virtual base class for graphics memory backup

Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination using a virtual base class. Also provide a sample implementation for shmem. While when settling on a preferred backup solution, one could perhaps skip the a

[PATCH v5 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos

Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, introduce and add shrinker support for purgeable ttm_tts.

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

Hi Doug, On Mon, 17 Jun 2024 19:12:05 -0700, Doug Anderson wrote: > On Mon, Jun 17, 2024 at 3:26 PM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 08:18:14PM GMT, Jean Delvare wrote: > > > The major difference is that one can't possibly enable ARCH_QCOM if > > > building on X86 for e

Re: [PATCH v6 06/24] dma-heap: Add proper kref handling on dma-buf heaps

> Add proper refcounting on the dma_heap structure. reference counting? > While existing heaps are built-in, we may eventually > have heaps loaded from modules, and we'll need to be > able to properly handle the references to the heaps You may occasionally put more than 52 characte

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

Hi Lucas, On Mon, Jun 17, 2024 at 05:29:24PM -0500, Lucas De Marchi wrote: > On Mon, Jun 17, 2024 at 08:38:20PM GMT, Andi Shyti wrote: > > On Mon, Jun 17, 2024 at 10:46:07AM -0500, Lucas De Marchi wrote: > > > On Mon, Jun 17, 2024 at 04:22:11PM GMT, Andi Shyti wrote: > > > > On Mon, Jun 17, 2024 a

[PATCH] staging: fbtft: Remove unnecessary parentheses

Remove unnecessary parentheses in `if` statements. Reported by checkpatch.pl Signed-off-by: Shiva Kiran K --- drivers/staging/fbtft/fb_ili9320.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 2 +- drivers/staging/fbtft/fbtft-bus.c | 2 +- drivers/staging/fbtft/fbtft-core.c | 2 +- 4 files change

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

On Mon, 2024-06-17 at 22:30 +0800, Icenowy Zheng wrote: > > Two consecutive writes to the same bus address are perfectly legal > > from > > the PCIe specification and can happen all the time, even without this > > specific hw workaround. > > Yes I know it, and I am not from Loongson, just some us

Re: [BUG] 6.10-rc3 [drm:amdgpu_fill_buffer [amdgpu]] *ERROR* Trying to clear memory with ring turned off [DUPLICATE]

On 6/12/24 21:15, Mirsad Todorovac wrote: > Hi, all! > > Running the vanilla torvalds tree kernel 6.10-rc3, there occurred an error in > boot with > amdgpu. > > Here is the complete output: > > kernel: [8.704024] WARNING: CPU: 24 PID: 689 at > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:137

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

On 6/13/24 16:01, Przemek Kitszel wrote: > [Some people who received this message don't often get email from > przemyslaw.kits...@intel.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On 6/13/24 10:21, Omer Shpigelman wrote: >> Add the hbl_cn driver which

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

On 6/14/24 00:49, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > >> +static int hbl_en_napi_poll(struct napi_struct *napi, int budget); >> +static int hbl_

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

On 6/13/24 22:18, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote: >> Add an RDMA dri

Re: [PATCH 04/15] net: hbl_cn: QP state machine

On 6/17/24 16:18, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:21:57AM +0300, Omer Shpigelman wrote: >> Add a common QP

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

On 6/15/24 03:05, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> +#define HBL_AUX2NIC(aux_dev) \ >> + ({ \ >> + struct hbl_aux_dev *__aux_dev = (aux_dev);

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

Hello Doug, On 11/04/24 10:12, Doug Anderson wrote: Hi, On Wed, Apr 10, 2024 at 4:42 AM Jayesh Choudhary wrote: Hello Doug, Thanks for the review. On 08/04/24 14:33, Doug Anderson wrote: Hi, On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: Due to integer calculations, the round

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

Hi TaoJiang, On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > From: Ming Qian > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know > whether the dma buffer is coherent or synchronized. > > The videobuf2-core will skip cache syncs as it think the DMA exporter > should take

RE: [RFC 0/7] drm/virtio: Import scanout buffers from other devices

Hi Gurchetan, > > On Thu, May 30, 2024 at 12:21 AM Kasireddy, Vivek > mailto:vivek.kasire...@intel.com> > wrote: > > > Hi Gurchetan, > > > > > On Fri, May 24, 2024 at 11:33 AM Kasireddy, Vivek > > mailto:vivek.kasire...@intel.com> >

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

On Mon, 2024-06-17 at 11:46 -0500, Bjorn Helgaas wrote: > On Mon, Jun 17, 2024 at 10:21:10AM +0200, Philipp Stanner wrote: > > On Fri, 2024-06-14 at 11:14 -0500, Bjorn Helgaas wrote: > > > On Fri, Jun 14, 2024 at 10:09:46AM +0200, Philipp Stanner wrote: > > ... > > > > > Apparently INTx is "old IR

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > but lima does not call any symbol from simpleondemand governor module. > > softdep module seems to be optional while our dependency is hard one, > can we just add MODULE

Re: [PATCH] drm/tidss: Add drm_panic support

Aradhya Bhatia writes: > Hi Javier, > > I tested the patch, and it was good to see the panic screen on SK-AM62. > Thanks for adding this feature in tidss. =) > > On 15/06/24 14:23, Javier Martinez Canillas wrote: >> Add support for the drm_panic module, which displays a pretty user >> friendly me

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: > On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > > > I see the problem that initramfs need to build a module dependency chain, > > but lima does not call any symbol from simpleondemand governor module. > > > > softdep module seems to be

[PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

During code inspection, it was found that due to integer calculations, the rounding off can cause errors in the final value propagated in the registers. Considering the example of 1080p (very common resolution), the mode->clock is 148500, dsi->lanes = 4, and bpp = 24, with the previous logic, the D

[PATCH v2 0/2] SN65DSI86 minor fixes

Hello All, These 2 patches add the atomic check hook for sn65dsi86 bridge and does a minor math fix for dsi rate calculation. According to the datasheet[0], for the max resolution, it says: Suitable for 60 fps 4K 4096 x 2304 resolution at 18 bpp color, and WUXGA 1920 x 1200 resolution with

[PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

Add the atomic_check hook to ensure that the parameters are within the valid range. As of now, dsi clock freqency is being calculated in bridge_enable but this needs to be checked in atomic_check which is called before bridge_enable so move this calculation to atomic_check and write the register va

[PATCH v1 0/3] drm/panel: st7701: Add Anbernic RG28XX panel support

Add support for the Anbernic RG28XX display panel, as used in the RG28XX handheld gaming device from Anbernic. The panel is connected via an RGB parallel interface for image transmission and an SPI interface for configuration. Since the current panel driver for the ST7701 variants only supports M

[PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel

The RG28XX panel is a panel specific to the Anbernic RG28XX. It is 2.8 inches in size (diagonally) with a resolution of 480x640. Signed-off-by: Hironori KIKUCHI --- .../display/panel/sitronix,st7701.yaml| 36 +-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH 1/4] dt-bindings: display: simple-bridge: add ti,tdp158

On Mon, Jun 17, 2024 at 10:37:18PM GMT, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 06:02:59PM GMT, Marc Gonzalez wrote: > > In default mode, this device works transparently. > > > > Signed-off-by: Marc Gonzalez > > --- > > Documentation/devicetree/bindings/display/bridge/simple-bridge.yam

[PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration

The ST7701 supports not only MIPI DSI, but also SPI as an interface for configuration. To support a panel connected via RGB parallel interface, add support for SPI using MIPI DBI helpers. Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/panel/Kconfig | 2 + drivers/gpu/drm/p

[PATCH v1 3/3] drm/panel: st7701: Add Anbernic RG28XX panel support

The Anbernic RG28XX is a handheld device with a 2.8 inch 480x640 display. Add support for the display. Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 151 ++ 1 file changed, 151 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-

Re: [PATCH 2/4] drm: bridge: simple-bridge: use dev pointer in probe

On Mon, Jun 17, 2024 at 06:03:00PM GMT, Marc Gonzalez wrote: > Prepare to factorize probe function. > > Signed-off-by: Marc Gonzalez ... And since we would need a separate binding file, we probably don't want to add things to simple-bridge that would not be part of its binding. Even more so whe

Re: [PATCH v3 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

On Mon, Jun 17, 2024 at 03:51:15PM GMT, Rob Clark wrote: > From: Rob Clark > > Move the CP_PROTECT settings into the hw catalog. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 247 + > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 257 +--

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > From: Rob Clark > > Introduce a6xx_info where we can stash gen specific stuff without > polluting the toplevel adreno_info struct. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +---

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

On Mon, Jun 17, 2024 at 07:12:05PM GMT, Doug Anderson wrote: > Hi, > > On Mon, Jun 17, 2024 at 3:26 PM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 08:18:14PM GMT, Jean Delvare wrote: > > > On Mon, 17 Jun 2024 14:55:22 +0300, Dmitry Baryshkov wrote: > > > > On Mon, Jun 17, 2024 at 01

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

On Tue, Jun 18, 2024 at 01:44:17PM GMT, Jayesh Choudhary wrote: > Add the atomic_check hook to ensure that the parameters are within the > valid range. > As of now, dsi clock freqency is being calculated in bridge_enable but > this needs to be checked in atomic_check which is called before > bridge

Re: [PATCH 04/15] net: hbl_cn: QP state machine

On Tue, Jun 18, 2024 at 07:58:55AM +, Omer Shpigelman wrote: > On 6/18/24 10:08, Leon Romanovsky wrote: > > On Tue, Jun 18, 2024 at 05:50:15AM +, Omer Shpigelman wrote: > >> On 6/17/24 16:18, Leon Romanovsky wrote: > >>> [Some people who received this message don't often get email from > >

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

On Tue, Jun 18, 2024 at 01:44:18PM GMT, Jayesh Choudhary wrote: > During code inspection, it was found that due to integer calculations, > the rounding off can cause errors in the final value propagated in the > registers. > Considering the example of 1080p (very common resolution), the mode->clock

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

Hi Conor, Sorry, I missed the news of you becoming a DT maintainer, so most of my previous points are obviously bogus. And congrats :) On Thu, Jun 06, 2024 at 12:51:33PM GMT, Conor Dooley wrote: > On Thu, Jun 06, 2024 at 01:23:03PM +0200, Maxime Ripard wrote: > > On Thu, Jun 06, 2024 at 11:37:31A

Re: Correct sequencing of usage of DRM writeback connector

Hi, On Mon, Jun 17, 2024 at 10:48:47PM UTC, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 05:36:34PM GMT, Hoosier, Matt wrote: > > >> >> >> There is a discussion ongoing over in the compositor world about > > >> >> >> the implication > > >> Hi, > > >> > > >> On Mon, Jun 17, 2024 at 05:16:36P

Re: [PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel

On 18/06/2024 10:15, Hironori KIKUCHI wrote: > The RG28XX panel is a panel specific to the Anbernic RG28XX. > It is 2.8 inches in size (diagonally) with a resolution of 480x640. > > Signed-off-by: Hironori KIKUCHI > --- > .../display/panel/sitronix,st7701.yaml| 36 +-- >

Re: [PATCH AUTOSEL 6.1 13/14] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

Hi! > [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] > > The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. > To make the code more robust, check the pointer parent. If this can happen, it should not WARN(). If this can not happen, we don't need the patch in sta

Re: [PATCH AUTOSEL 5.10 1/7] drm/amd/display: Exit idle optimizations before HDCP execution

Hi! > [WHY] > PSP can access DCN registers during command submission and we need > to ensure that DCN is not in PG before doing so. > > [HOW] > Add a callback to DM to lock and notify DC for idle optimization exit. > It can't be DC directly because of a potential race condition with the > link pr

Re: (subset) [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

On Fri, 16 Feb 2024 18:48:55 +, Dave Stevenson wrote: > Add this as a value for enum_drm_connector_tv_mode, represented > by the string "Mono", to generate video with no colour encoding > or bursts. Define it to have no pedestal (since only NTSC-M calls > for a pedestal). > > Change default mo

Re: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration

On 18/06/2024 10:15, Hironori KIKUCHI wrote: > The ST7701 supports not only MIPI DSI, but also SPI as an interface > for configuration. To support a panel connected via RGB parallel > interface, add support for SPI using MIPI DBI helpers. > > Signed-off-by: Hironori KIKUCHI ... > + > +static i

Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

Hi, On Fri, Feb 16, 2024 at 06:48:55PM GMT, Dave Stevenson wrote: > From: Nick Hollinghurst > > Add this as a value for enum_drm_connector_tv_mode, represented > by the string "Mono", to generate video with no colour encoding > or bursts. Define it to have no pedestal (since only NTSC-M calls >

Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure

Hi Markus, Le lundi 17 juin 2024 à 08:56 +0200, Markus Elfring a écrit : > … > > +++ b/drivers/iio/industrialio-buffer.c > … > >  static int iio_buffer_chrdev_release(struct inode *inode, struct > > file *filep) > >  { > … > >   wake_up(&buffer->pollq); > > > > + mutex_lock(&buffer->dmabufs_m

Re: [PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

Hi, On Fri, Feb 16, 2024 at 06:48:56PM GMT, Dave Stevenson wrote: > The VEC supports not producing colour bursts for monochrome output. > It also has an option for disabling the chroma input to remove > chroma from the signal. > > Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb > t

Re: [PATCH] nouveau: rip out busy fence waits

On Mon, Jun 17, 2024 at 05:11:34PM +0200, Danilo Krummrich wrote: > On 4/17/24 07:40, Dave Airlie wrote: > > From: Dave Airlie > > > > I'm pretty sure this optimisation is actually not a great idea, > > and is racy with other things waiting for fences. > > Yes, I tried to use it in the past on s

Re: [PATCH 3/3] drm/vc4: vec: Add the margin properties to the connector

On Fri, 16 Feb 2024 18:48:57 +, Dave Stevenson wrote: > All the handling for the properties was present, but they > were never attached to the connector to allow userspace > to change them. > > Add them to the connector. > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [RFC] GPU driver with separate "core" and "DRM" modules

On Tue, Jun 18, 2024 at 04:23:17AM +1000, Ben Skeggs wrote: > On 17/6/24 23:55, Daniel Vetter wrote: > > > On Fri, Jun 14, 2024 at 03:02:09AM +1000, Ben Skeggs wrote: > > > NVIDIA has been exploring ways to better support the effort for an > > > upstream kernel mode driver for GPUs that are capabl

Re: Correct sequencing of usage of DRM writeback connector

On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > > Hi > > > > On 6/17/2024 9:54 AM, Brian Starkey wrote: > > > Hi, > > > > > > On Mon, Jun 17, 2024 at 05:16:36PM +0200, Daniel Vetter wrote: > > > > On Mon, Jun 17, 2

Re: [PATCH RFC 5/5] drm/bridge: lt9611: switch to using the DRM HDMI codec framework

On Sat, Jun 15, 2024 at 08:53:34PM GMT, Dmitry Baryshkov wrote: > Make the Lontium LT9611 DSI-to-HDMI bridge driver use the DRM HDMI Codec > framework. This enables programming of Audio InfoFrames using the HDMI > Connector interface and also enables support for the missing features, > including th

Re: [PATCH] drm/fbdev-dma: Only set smem_start is enable per module option

On Mon, Jun 17, 2024 at 05:26:37PM +0200, Thomas Zimmermann wrote: > Only export struct fb_info.fix.smem_start if that is required by the > user and the memory does not come from vmalloc(). > > Setting struct fb_info.fix.smem_start breaks systems where DMA > memory is backed by vmalloc address spa

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

On Tue, 18 Jun 2024, André Almeida wrote: > Drivers have different capabilities on what plane types they can or > cannot perform async flips. Create a plane::async_flip field so each > driver can choose which planes they allow doing async flips. > > Signed-off-by: André Almeida > --- > include/d

Re: Correct sequencing of usage of DRM writeback connector

On Tue, 18 Jun 2024 at 12:33, Daniel Vetter wrote: > > On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > > > Hi > > > > > > On 6/17/2024 9:54 AM, Brian Starkey wrote: > > > > Hi, > > > > > > > > On Mon, Jun 17, 2024

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

Hello Dmitry, Thanks for the review. On 18/06/24 14:29, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 01:44:17PM GMT, Jayesh Choudhary wrote: Add the atomic_check hook to ensure that the parameters are within the valid range. As of now, dsi clock freqency is being calculated in bridge_enable

Re: [PATCH] drm/fbdev-dma: Only set smem_start is enable per module option

Hi Am 18.06.24 um 11:35 schrieb Daniel Vetter: On Mon, Jun 17, 2024 at 05:26:37PM +0200, Thomas Zimmermann wrote: Only export struct fb_info.fix.smem_start if that is required by the user and the memory does not come from vmalloc(). Setting struct fb_info.fix.smem_start breaks systems where DM

[PATCH v11 0/7] iio: new DMABUF based API v11

Hi Jonathan, Here's the v11 of my patchset that introduces DMABUF support to IIO. It addresses the few points that were raised in the review of the v10. It also adds Nuno as a co-developer. Changelog: - [3/7]: - Document .lock_queue / .unlock_queue buffer callbacks - Add small comment to

[PATCH v11 1/7] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()

This function can be used to initiate a scatter-gather DMA transfer, where the address and size of each segment is located in one entry of the dma_vec array. The major difference with dmaengine_prep_slave_sg() is that it supports specifying the lengths of each DMA transfer; as trying to override t

[PATCH v11 2/7] dmaengine: dma-axi-dmac: Implement device_prep_peripheral_dma_vec

Add implementation of the .device_prep_peripheral_dma_vec() callback. Signed-off-by: Paul Cercueil Co-developed-by: Nuno Sa Signed-off-by: Nuno Sa --- v3: New patch v5: Implement .device_prep_slave_dma_vec() instead of v3's .device_prep_slave_dma_array(). v6: Use new prototype for axi_dm

[PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

Add the necessary infrastructure to the IIO core to support a new optional DMABUF based interface. With this new interface, DMABUF objects (externally created) can be attached to a IIO buffer, and subsequently used for data transfer. A userspace application can then use this interface to share DM

[PATCH v11 4/7] iio: buffer-dma: Enable support for DMABUFs

Implement iio_dma_buffer_attach_dmabuf(), iio_dma_buffer_detach_dmabuf() and iio_dma_buffer_transfer_dmabuf(), which can then be used by the IIO DMA buffer implementations. Signed-off-by: Paul Cercueil Co-developed-by: Nuno Sa Signed-off-by: Nuno Sa --- v3: Update code to provide the functions

[PATCH v11 5/7] iio: buffer-dmaengine: Support new DMABUF based userspace API

Use the functions provided by the buffer-dma core to implement the DMABUF userspace API in the buffer-dmaengine IIO buffer implementation. Since we want to be able to transfer an arbitrary number of bytes and not necesarily the full DMABUF, the associated scatterlist is converted to an array of DM

[PATCH v11 6/7] Documentation: iio: Document high-speed DMABUF based API

Document the new DMABUF based API. Signed-off-by: Paul Cercueil Co-developed-by: Nuno Sa Signed-off-by: Nuno Sa --- v2: - Explicitly state that the new interface is optional and is not implemented by all drivers. - The IOCTLs can now only be called on the buffer FD returned by

[PATCH v11 7/7] Documentation: dmaengine: Document new dma_vec API

Document the dmaengine_prep_peripheral_dma_vec() API function, the device_prep_peripheral_dma_vec() backend function, and the dma_vec struct. Signed-off-by: Paul Cercueil --- v11: New patch --- Documentation/driver-api/dmaengine/client.rst | 9 + Documentation/driver-api/dmaengine/pr

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

Hello Dmitry, On 18/06/24 14:33, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 01:44:18PM GMT, Jayesh Choudhary wrote: During code inspection, it was found that due to integer calculations, the rounding off can cause errors in the final value propagated in the registers. Considering the examp

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: > > On Tue, 18 Jun 2024, André Almeida wrote: > > Drivers have different capabilities on what plane types they can or > > cannot perform async flips. Create a plane::async_flip field so each > > driver can choose which planes they allow doing async

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

On Tue, 18 Jun 2024 at 13:05, Jayesh Choudhary wrote: > > Hello Dmitry, > > On 18/06/24 14:33, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 01:44:18PM GMT, Jayesh Choudhary wrote: > >> During code inspection, it was found that due to integer calculations, > >> the rounding off can cause err

Re: [PATCH v7 3/3] drm/mediatek: Implement OF graphs support for display paths

Il 17/06/24 15:24, Michael Walle ha scritto: Hi Angelo, +/** + * mtk_drm_of_ddp_path_build_one - Build a Display HW Pipeline for a CRTC Path + * @dev: The mediatek-drm device + * @cpath:CRTC Path relative to a VDO or MMSYS + * @out_path: Pointer to an array that will contai

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

On Tue, 18 Jun 2024 at 12:56, Jayesh Choudhary wrote: > > Hello Dmitry, > > Thanks for the review. > > On 18/06/24 14:29, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 01:44:17PM GMT, Jayesh Choudhary wrote: > >> Add the atomic_check hook to ensure that the parameters are within the > >> val

[PATCH v8 0/3] drm/mediatek: Add support for OF graphs

Changes in v8: - Rebased on next-20240617 - Changed to allow probing a VDO with no available display outputs Changes in v7: - Fix typo in patch 3/3 Changes in v6: - Added EPROBE_DEFER check to fix dsi/dpi false positive DT fallback case - Dropped refcount of ep_out in mtk_drm_of_get_ddp_ep_c

[PATCH v8 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths per HW instance (so potentially up to six displays for multi-vdo SoCs). The MMSYS or VDOSYS is always the first component in the DDP pipeline, so it only supports an output port with multiple endpoints - where each endpoint def

[PATCH v8 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

The display IPs in MediaTek SoCs support being interconnected with different instances of DDP IPs (for example, merge0 or merge1) and/or with different DDP IPs (for example, rdma can be connected with either color, dpi, dsi, merge, etc), forming a full Display Data Path that ends with an actual dis

[PATCH v8 3/3] drm/mediatek: Implement OF graphs support for display paths

It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for 10 SoCs and this is going to grow larger and larger, and with new hacks like the introduction of mtk_drm_route which is a

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

Hello Qiang and Maxime, On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > but lima does not call any symbol from simp

Re: [PATCH v8 0/3] drm/mediatek: Add support for OF graphs

On Tue Jun 18, 2024 at 12:17 PM CEST, AngeloGioacchino Del Regno wrote: > The display IPs in MediaTek SoCs are *VERY* flexible and those support > being interconnected with different instances of DDP IPs (for example, > merge0 or merge1) and/or with different DDP IPs (for example, rdma can > be con

Re: [PATCH v3 1/5] drm/msm/adreno: Split up giant device table

On 6/18/24 00:51, Rob Clark wrote: From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 2/5] drm/msm/adreno: Split catalog into separate files

On 6/18/24 00:51, Rob Clark wrote: From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

On 6/18/24 00:51, Rob Clark wrote: From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

On 6/18/24 00:51, Rob Clark wrote: From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +-- drivers/gpu/drm/msm/adreno

Re: [PATCH v3 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

On 6/18/24 00:51, Rob Clark wrote: From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark --- I think a702 was skipped over Konrad

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

On Tue, Jun 18, 2024 at 11:04:09AM +0200, Maxime Ripard wrote: > Hi Conor, > > Sorry, I missed the news of you becoming a DT maintainer, so most of my > previous points are obviously bogus. And congrats :) I've been doing it for over a year, so news travels to some corners slowly I guess. I'm not

Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe

On 18/06/2024 00:28, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 06:03:01PM GMT, Marc Gonzalez wrote: > >> Once probe uses only devm functions, remove() becomes unnecessary. > > Breves vibrantesque sententiae > > With the hope of getting an expanded commit message: > > Reviewed-by: Dmitry

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

On 6/18/24 07:43, Christoph Hellwig wrote: On Mon, Jun 17, 2024 at 07:04:43PM +0100, Pavel Begunkov wrote: There should be no other memory source other than the page allocator and dmabuf. If you need different life time control for your zero copy proposal don't mix that up with the contol of th

Re: [PATCH AUTOSEL 6.1 13/14] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

Am 18.06.24 um 11:11 schrieb Pavel Machek: Hi! [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent. If this can happen, it should not WARN(). If this can not

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

On 18/06/2024 00:33, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > >> +if (sbridge->vcc) { >> +ret = regulator_enable(sbridge->vcc); >> +msleep(100); > > At least this should be documented or explained in the commit message.

Re: [PATCH] drm/vc4: remove all usages of of_node_put()

On 5/22/24 16:48, Amer Al Shanawany wrote: > On 27/04/2024 15.40, Amer Al Shanawany wrote: >> Use the scope-based cleanup feature to clean up 'struct device_node *' >> when they go out of scope, and remove all instances of of_node_put() >> within the same scope, to simplify function exit and avoid

  1   2   3   >