Re: [PATCH v6,02/24] v4l2: handle restricted memory flags in queue setup

2024-06-17 Thread 董云飞
Hi Andrzej, Thanks for your help to review this patch. Your suggestion is very reasonable, I will change it later. Best Regards, Yunfei Dong On Wed, 2024-05-22 at 14:20 +0200, Andrzej Pietrasiewicz wrote: > Hi Yunfei & Jeffrey, > > W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: > > From: Jeffrey

回复:WARNING in drm_mode_create_lease_ioctl

2024-06-17 Thread Ubisectech Sirius
> Cc'ing dri-devel > Does > https://lore.kernel.org/dri-devel/20240617035258.2774032-1-airl...@gmail.com/T/#u > help? > Thanks, > Dave. Hi. The issue does not appear after applied the patch. > On Mon, 17 Jun 2024 at 13:12, Ubisectech Sirius > wrote: >> >> Hello. >> We are Ubisectech Sirius T

Re: [PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-06-17 Thread 胡俊光

Re: [PATCH v6,08/24] media: mediatek: vcodec: add tee client interface to communiate with optee-os

2024-06-17 Thread 董云飞
Hi Andrzej, Thanks for your help to review this patch. On Wed, 2024-05-22 at 14:21 +0200, Andrzej Pietrasiewicz wrote: > Hi Yunfei & Jeffrey, > > W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: > > Open tee context to initialize the environment in order to > > communication > > with optee-os, then

Re: [PATCH v2 5/7] drm/panic: Convert to drm_fb_clip_offset()

2024-06-17 Thread Jocelyn Falempe
On 16/06/2024 11:12, Geert Uytterhoeven wrote: On Sun, Jun 16, 2024 at 11:08 AM Geert Uytterhoeven wrote: On Sat, Jun 15, 2024 at 12:55 PM kernel test robot wrote: kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to linu

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-06-17 Thread Tomi Valkeinen
Hi, On 16/06/2024 21:43, Laurent Pinchart wrote: On Thu, Jun 13, 2024 at 11:05:01AM -0400, Sean Anderson wrote: On 5/20/24 11:05, Sean Anderson wrote: On 5/20/24 05:40, Christophe JAILLET wrote: If zynqmp_dpsub_drm_init() fails, we must undo the previous drm_bridge_add() call. Fixes: be3f304

Re: [PATCH v2] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-06-17 Thread Tomi Valkeinen
Hi, On 24/05/2024 02:49, Anatoliy Klymenko wrote: Unconditionally enable the DPSUB layer in the corresponding atomic plane update callback. Setting the new display mode may require disabling and re-enabling the CRTC. This effectively resets DPSUB to the default state with all layers disabled. Th

Re: [PATCH v6, 10/24] media: mediatek: vcodec: send share memory data to optee

2024-06-17 Thread 董云飞
Hi Andrzej, Thanks for your help to review this patch. On Wed, 2024-05-22 at 14:22 +0200, Andrzej Pietrasiewicz wrote: > Hi Yunfei & Jeffrey, > > W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: > > Setting msg and vsi information to shared buffer, then call tee > > invoke > > function to send it t

Re: [PATCH v5 00/10] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-06-17 Thread Tomi Valkeinen
Hi Sean, On 03/05/2024 22:29, Sean Anderson wrote: This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it adds debugfs support. The intent is to enable compliance testing or to help debug signal-integrity issues. Last time I discussed converting the HPD work(s) to a

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-17 Thread 董云飞
Hi Andrzej, Thanks for your help to review this patch. On Wed, 2024-05-22 at 14:25 +0200, Andrzej Pietrasiewicz wrote: > Hi Yunfei, > > W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: > > Need to call dma heap interface to allocate/free secure memory when > > playing > > secure video. > > > > Sign

Re: [PATCH 09/13] drm/mediatek: Fix XRGB setting error in OVL

2024-06-17 Thread 胡俊光

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-17 Thread Alexandre Mergnat
On 14/06/2024 11:31, Mark Brown wrote: On Fri, Jun 14, 2024 at 09:27:43AM +0200, Alexandre Mergnat wrote: This serie aim to add the following audio support for the Genio 350-evk: - Playback - 2ch Headset Jack (Earphone) - 1ch Line-out Jack (Speaker) - 8ch HDMI Tx I seem to remember

Re: [PATCH v2 1/2] drm/bridge: tc358767: Add format negotiation hooks for DPI/DSI to (e)DP

2024-06-17 Thread Dmitry Baryshkov
On Wed, Nov 08, 2023 at 01:27:22PM GMT, Tomi Valkeinen wrote: > From: Aradhya Bhatia > > With new connector model, tc358767 will not create the connector, when > DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will > rely on format negotiation to setup the encoder format. > >

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 07:40:32AM GMT, Jan Kiszka wrote: > On 16.02.24 15:57, Marek Vasut wrote: > > On 2/16/24 10:10, Tomi Valkeinen wrote: > >> Ok. Does anyone have a worry that these patches make the situation > >> worse for the DSI case than it was before? Afaics, if the DSI lanes > >> are not

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-17 Thread Jocelyn Falempe
On 16/06/2024 14:43, Javier Martinez Canillas wrote: Jocelyn Falempe writes: Hello Jocelyn, The race condition between fbcon and drm_panic can only occurs if VT_CONSOLE is set. So update drm_panic dependency accordingly. This will make it easier for Linux distributions to enable drm_panic

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-06-17 Thread Philipp Stanner
On Fri, 2024-06-14 at 11:14 -0500, Bjorn Helgaas wrote: > On Fri, Jun 14, 2024 at 10:09:46AM +0200, Philipp Stanner wrote: > > On Thu, 2024-06-13 at 16:06 -0500, Bjorn Helgaas wrote: > > > On Thu, Jun 13, 2024 at 01:50:23PM +0200, Philipp Stanner wrote: > > > > pci_intx() is one of the functions th

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-17 Thread Geert Uytterhoeven
Hi Jocelyn, On Mon, Jun 17, 2024 at 10:16 AM Jocelyn Falempe wrote: > On 16/06/2024 14:43, Javier Martinez Canillas wrote: > > Jocelyn Falempe writes: > >> The race condition between fbcon and drm_panic can only occurs if > >> VT_CONSOLE is set. So update drm_panic dependency accordingly. > >> T

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-17 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > On 16/06/2024 14:43, Javier Martinez Canillas wrote: >> Jocelyn Falempe writes: >> >> Hello Jocelyn, >> >>> The race condition between fbcon and drm_panic can only occurs if >>> VT_CONSOLE is set. So update drm_panic dependency accordingly. >>> This will make it easie

[PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Jean Delvare
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. Signed-off-by: Jean Delvare Reviewed-by: Javier

[PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Jean Delvare
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. Signed-off-by: Jean Delvare Reviewed-by: Paul Ko

Re: [PATCH 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

2024-06-17 Thread Linus Walleij
On Thu, Jun 6, 2024 at 9:28 AM Primoz Fiser wrote: > Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel. > Datasheet can be found at [1]. > > [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf > > Signed-off-by: Primoz Fiser Reviewed-by: Linus Walleij Yours, Lin

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-06-17 Thread Laurent Pinchart
On Mon, Jun 17, 2024 at 10:43:44AM +0300, Tomi Valkeinen wrote: > On 16/06/2024 21:43, Laurent Pinchart wrote: > > On Thu, Jun 13, 2024 at 11:05:01AM -0400, Sean Anderson wrote: > >> On 5/20/24 11:05, Sean Anderson wrote: > >>> On 5/20/24 05:40, Christophe JAILLET wrote: > If zynqmp_dpsub_drm_

Re: [PATCH v2] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-17 Thread Linus Walleij
On Tue, Jun 11, 2024 at 7:28 PM Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off

Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A

2024-06-17 Thread Borislav Petkov
On Sat, Jun 15, 2024 at 06:25:11PM -0700, Alexey Makhalov wrote: > 0-DAY CI Kernel Test automation reported an issue: > >ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': >regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' >ld: drivers/base/regmap

Re: Design session notes: GPU acceleration in Xen

2024-06-17 Thread Jan Beulich
On 14.06.2024 18:35, Demi Marie Obenour wrote: > On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote: >> On 13.06.2024 20:43, Demi Marie Obenour wrote: >>> 2. Add support for `XEN_DOMCTL_memory_mapping` to use system RAM, not >>>just IOMEM. Mappings made with `XEN_DOMCTL_memory_mapping

Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency

2024-06-17 Thread Borislav Petkov
On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > VMWARE_HYPERCALL alternative will not work as intended without > VMware guest code initialization. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202406152104.fxakp1mb-...@intel.com/ > Signed

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-17 Thread Jocelyn Falempe
On 17/06/2024 10:25, Geert Uytterhoeven wrote: Hi Jocelyn, On Mon, Jun 17, 2024 at 10:16 AM Jocelyn Falempe wrote: On 16/06/2024 14:43, Javier Martinez Canillas wrote: Jocelyn Falempe writes: The race condition between fbcon and drm_panic can only occurs if VT_CONSOLE is set. So update d

Re: Linux 6.10-rc1

2024-06-17 Thread Pavel Machek
Hi! > > Let's bring in the actual gpu people.. Dave/Jani/others - does any of > > this sound familiar? Pavel says things have gotten much slower in > > 6.10: "something was very wrong with the performance, likely to do > > with graphics" > > Actually, maybe it's not graphics at all. Rafael just s

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-17 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > On 17/06/2024 10:25, Geert Uytterhoeven wrote: >> Hi Jocelyn, >> >> On Mon, Jun 17, 2024 at 10:16 AM Jocelyn Falempe wrote: >>> On 16/06/2024 14:43, Javier Martinez Canillas wrote: Jocelyn Falempe writes: > The race condition between fbcon and drm_panic can o

[PATCH] drm/nouveau: Use kmemdup_array() instead of kmemdup()

2024-06-17 Thread Dan Carpenter
Use kmemdup_array() because we're allocating an array. The main difference between kmemdup() and kmemdup_array() is that the kmemdup_array() function has integer overflow checking built it. The "args->in_sync.count" variable is a u32 so integer overflows would only be a concern on 32bit systems.

Re: [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory

2024-06-17 Thread 董云飞
Hi Andrzej, Thanks for your help to review this patch. On Wed, 2024-05-22 at 14:26 +0200, Andrzej Pietrasiewicz wrote: > Hi Yunfei, > > W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: > > Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order > > to > > support one plane memory. The buf

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 10:30:30AM GMT, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is

Re: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 10:33:36AM GMT, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is

Re: [PATCH v2 7/7] drm/panic: Add support for drawing a monochrome graphical logo

2024-06-17 Thread Jocelyn Falempe
On 13/06/2024 21:18, Geert Uytterhoeven wrote: Re-use the existing support for boot-up logos to draw a monochrome graphical logo in the DRM panic handler. When no suitable graphical logo is available, the code falls back to the ASCII art penguin logo. Note that all graphical boot-up logos ar

Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency

2024-06-17 Thread Borislav Petkov
On Mon, Jun 17, 2024 at 11:07:09AM +0200, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > > VMWARE_HYPERCALL alternative will not work as intended without > > VMware guest code initialization. > > > > Reported-by: kernel test robot > > Closes: > > http

[PATCH v3 01/10] drm/bridge: cdns-dsi: Fix OF node pointer

2024-06-17 Thread Aradhya Bhatia
Fix the OF node pointer passed to the of_drm_find_bridge() call to find the next bridge in the display chain. To find the next bridge in the pipeline, we need to pass "np" - the OF node pointer of the next entity in the devicetree chain. Passing "of_node" to of_drm_find_bridge will make the functi

[PATCH v3 00/10] drm/bridge: cdns-dsi: Fix the color-shift issue

2024-06-17 Thread Aradhya Bhatia
Hello all, This series provides some crucial fixes and improvements for the Cadence's DSI TX (cdns-dsi) controller found commonly in Texas Instruments' J7 family of SoCs as well as in AM62P. Along with that, this series aims to fix the color-shift issue that has been going on with the DSI control

[PATCH v3 05/10] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready

2024-06-17 Thread Aradhya Bhatia
Once the DSI Link and DSI Phy are initialized, the code needs to wait for Clk and Data Lanes to be ready, before continuing configuration. This is in accordance with the DSI Start-up procedure, found in the Technical Reference Manual of Texas Instrument's J721E SoC[0] which houses this DSI TX contr

[PATCH v3 03/10] drm/bridge: cdns-dsi: Fix the link and phy init order

2024-06-17 Thread Aradhya Bhatia
The order of init of DSI link and DSI phy is wrong. The DSI link needs to be configured before the DSI phy is getting configured. Otherwise, the D-Phy is unable to lock in on the incoming PLL Reference clock[0]. Fix the order of inits. [0]: See section 12.6.5.7.3 "Start-up Procedure" in J721E SoC

[PATCH v3 02/10] drm/bridge: cdns-dsi: Fix the phy_initialized variable

2024-06-17 Thread Aradhya Bhatia
Update the Phy initialized state to "not initialized" when the driver (and the hardware by extension) gets suspended. This will allow the Phy to get initialized again after resume. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge

[PATCH v3 04/10] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid()

2024-06-17 Thread Aradhya Bhatia
Allow the D-Phy config checks to use mode->clock instead of mode->crtc_clock during mode_valid checks, like everywhere else in the driver. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- 1

[PATCH v3 09/10] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-06-17 Thread Aradhya Bhatia
Move the bridge pre_enable call before crtc enable, and the bridge post_disable call after the crtc disable. The sequence of enable after this patch will look like: bridge[n]_pre_enable ... bridge[1]_pre_enable crtc_enable encoder_enable bridge[1]

[PATCH v3 08/10] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-06-17 Thread Aradhya Bhatia
Change the existing (and deprecated) bridge hooks, to the bridge atomic APIs. Add drm helpers for duplicate_state, destroy_state, and bridge_reset bridge hooks. Further add support for the input format negotiation hook. Reviewed-by: Dmitry Baryshkov Signed-off-by: Aradhya Bhatia --- .../gpu/d

[PATCH v3 10/10] drm/bridge: cdns-dsi: Use pre_enable/post_disable to enable/disable

2024-06-17 Thread Aradhya Bhatia
The cdns-dsi controller requires that it be turned on completely before the input DPI's source has begun streaming[0]. Not having that, allows for a small window before cdns-dsi enable and after cdns-dsi disable where the previous entity (in this case tidss's videoport) to continue streaming DPI vi

[PATCH v3 07/10] drm/mipi-dsi: Add helper to find input format

2024-06-17 Thread Aradhya Bhatia
Add a helper API that can be used by the DSI hosts to find the required input bus format for the given output dsi pixel format. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/drm_mipi_dsi.c | 37 ++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 38 ins

[PATCH v3 06/10] drm/bridge: cdns-dsi: Reset the DCS write FIFO

2024-06-17 Thread Aradhya Bhatia
Allow the DCS Write FIFO in the cdns-dsi controller to reset before any DCS packet is transmitted to the DSI sink device. The DCS FIFO reset is optional. Not all panels require it. But at least one of the DSI based panel that uses Ilitek ILI9881C (DSI to DPI bridge) doesn't work with without this

Re: [PATCH v6] drm/ci: add tests on vkms

2024-06-17 Thread Helen Koike
On 14/06/2024 13:54, Helen Koike wrote: On 14/06/2024 13:18, Vignesh Raman wrote: Add job that runs igt on top of vkms. Acked-by: Maíra Canal Acked-by: Helen Koike Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Hel

[PATCH v2] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-17 Thread Thomas Zimmermann
Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field, It sets the framebuffer address size and is unrelated to VGA. Section 4.4 of the Vesa VBE 2.0 specifications defines that bit 5 in the mode's

[PATCH 0/2] Fixes of AMD GFX7/8 hang on Loongson platforms

2024-06-17 Thread Icenowy Zheng
This patchset tries to fix some workaround code in amdgpu/radeon driver, that makes Loongson 3A+7A platform suffering from GPU crashes. Icenowy Zheng (2): drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content drm/radeon: repeat the same EOP packet for EOP workaround on CIK driv

[PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
The duplication of EOP packets for GFX7/8, with the former one have seq-1 written and the latter one have seq written, seems to confuse some hardware platform (e.g. Loongson 7A series PCIe controllers). Make the content of the duplicated EOP packet the same with the real one, only masking any poss

[PATCH 2/2] drm/radeon: repeat the same EOP packet for EOP workaround on CIK

2024-06-17 Thread Icenowy Zheng
Ths first EOP packet with a sequence number as seq-1 seems to confuse some PCIe hardware (e.g. Loongson 7A PCHs). Use the real sequence number instead. Fixes: a9c73a0e022c ("drm/radeon: workaround for CP HW bug on CIK") Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/radeon/cik.c | 7 ++-

Re: [PATCH 10/13] drm/mediatek: Fix XRGB setting error in Mixer

2024-06-17 Thread AngeloGioacchino Del Regno
Il 16/06/24 10:29, Hsiao Chien Sung via B4 Relay ha scritto: From: Hsiao Chien Sung Although the alpha channel in XRGB formats can be ignored, ALPHA_CON must be configured accordingly when using XRGB formats or it will still affects CRC generation. Fixes: d886c0009bd0 ("drm/mediatek: Add ETHDR

Re: [PATCH 11/13] drm/mediatek: Add new color format MACROs in OVL

2024-06-17 Thread AngeloGioacchino Del Regno
Il 16/06/24 10:29, Hsiao Chien Sung via B4 Relay ha scritto: From: Hsiao Chien Sung Define new color formats to hide the bit operation in the MACROs to make the switch statement more concise. Change the MACROs to align the naming rule in DRM. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu

Re: [PATCH 12/13] drm/mediatek: Support DRM plane alpha in OVL

2024-06-17 Thread AngeloGioacchino Del Regno
Il 16/06/24 10:29, Hsiao Chien Sung via B4 Relay ha scritto: From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 13/13] drm/mediatek: Support DRM plane alpha in Mixer

2024-06-17 Thread AngeloGioacchino Del Regno
Il 16/06/24 10:29, Hsiao Chien Sung via B4 Relay ha scritto: From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 09/13] drm/mediatek: Fix XRGB setting error in OVL

2024-06-17 Thread AngeloGioacchino Del Regno
Il 16/06/24 10:29, Hsiao Chien Sung via B4 Relay ha scritto: From: Hsiao Chien Sung CONST_BLD must be enabled for XRGB formats although the alpha channel can be ignored, or OVL will still read the value from memory. This error only affects CRC generation. Fixes: 119f5173628a ("drm/mediatek: Ad

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Jean Delvare
Hi Dmitry, Thanks for your feedback. On Mon, 17 Jun 2024 12:57:19 +0300, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 10:30:30AM GMT, Jean Delvare wrote: > > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > > is possible to test-build any driver which depends on OF on a

Re: [PATCH v2] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-17 Thread Thomas Zimmermann
Am 17.06.24 um 13:06 schrieb Thomas Zimmermann: Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field, It sets the framebuffer address size and is unrelated to VGA. Section 4.4 of the Vesa VBE

Re: [PATCH] drm/tidss: Add drm_panic support

2024-06-17 Thread Jocelyn Falempe
On 15/06/2024 10:53, Javier Martinez Canillas wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Thanks for enabling drm panic on another hardware. It looks good to me. Reviewed-by: Jocelyn Falempe

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-17 Thread Leon Romanovsky
On Mon, Jun 17, 2024 at 08:08:26AM +, Omer Shpigelman wrote: > On 6/13/24 16:01, Przemek Kitszel wrote: > > [Some people who received this message don't often get email from > > przemyslaw.kits...@intel.com. Learn why this is important at > > https://aka.ms/LearnAboutSenderIdentification ] >

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 01:23:48PM GMT, Jean Delvare wrote: > Hi Dmitry, > > Thanks for your feedback. > > On Mon, 17 Jun 2024 12:57:19 +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 10:30:30AM GMT, Jean Delvare wrote: > > > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectab

Re: [PATCH v3 01/10] drm/bridge: cdns-dsi: Fix OF node pointer

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:02PM GMT, Aradhya Bhatia wrote: > Fix the OF node pointer passed to the of_drm_find_bridge() call to find > the next bridge in the display chain. > > To find the next bridge in the pipeline, we need to pass "np" - the OF > node pointer of the next entity in the device

Re: [PATCH v3 02/10] drm/bridge: cdns-dsi: Fix the phy_initialized variable

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:03PM GMT, Aradhya Bhatia wrote: > Update the Phy initialized state to "not initialized" when the driver > (and the hardware by extension) gets suspended. This will allow the Phy > to get initialized again after resume. > > Fixes: e19233955d9e ("drm/bridge: Add Cadence

Re: [PATCH v3 07/10] drm/mipi-dsi: Add helper to find input format

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:08PM GMT, Aradhya Bhatia wrote: > Add a helper API that can be used by the DSI hosts to find the required > input bus format for the given output dsi pixel format. > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/drm_mipi_dsi.c | 37

Re: [PATCH v3 06/10] drm/bridge: cdns-dsi: Reset the DCS write FIFO

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:07PM GMT, Aradhya Bhatia wrote: > Allow the DCS Write FIFO in the cdns-dsi controller to reset before any > DCS packet is transmitted to the DSI sink device. > > The DCS FIFO reset is optional. Not all panels require it. But at > least one of the DSI based panel that

Re: [PATCH RFC 2/5] ASoC: hdmi-codec: pass data to get_dai_id too

2024-06-17 Thread Mark Brown
On Sat, Jun 15, 2024 at 08:53:31PM +0300, Dmitry Baryshkov wrote: > The upcoming DRM connector HDMI codec implementation is going to use > codec-specific data in the .get_dai_id to get drm_connector. Pass data > to the callback, as it is done with other hdmi_codec_ops callbacks. Acked-by: Mark Bro

Re: [PATCH 2/6] drm/ttm: Store the bo_kmap_type in struct iosys_map

2024-06-17 Thread Thomas Zimmermann
Hi Am 14.06.24 um 16:31 schrieb Christian König: Am 14.06.24 um 15:21 schrieb Thomas Zimmermann: For each instances of struct iosys_map set up by ttm_bo_vmap(), store the type of allocation in the instance. Use this information to unmap the memory in ttm_bo_vunmap(). This change simplifies the

Re: [PATCH 00/15] Introduce HabanaLabs network drivers

2024-06-17 Thread Alexander Lobakin
From: Omer Shpigelman Date: Thu, 13 Jun 2024 11:21:53 +0300 > This patch set implements the HabanaLabs network drivers for Gaudi2 ASIC > which is designed for scaling of AI neural networks training. > The patch set includes the common code which is shared by all Gaudi ASICs > and the Gaudi2 ASIC

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Christian König
Am 17.06.24 um 12:58 schrieb Icenowy Zheng: The duplication of EOP packets for GFX7/8, with the former one have seq-1 written and the latter one have seq written, seems to confuse some hardware platform (e.g. Loongson 7A series PCIe controllers). Make the content of the duplicated EOP packet the

Re: [PATCH] drm/tidss: Add drm_panic support

2024-06-17 Thread Aradhya Bhatia
Hi Javier, I tested the patch, and it was good to see the panic screen on SK-AM62. Thanks for adding this feature in tidss. =) On 15/06/24 14:23, Javier Martinez Canillas wrote: > Add support for the drm_panic module, which displays a pretty user > friendly message on the screen when a Linux kern

[PATCH] drm/i915/gem: Return SIGBUS for wrong mapping parameters

2024-06-17 Thread Andi Shyti
We normally issue a warning when incorrect memory parameters are provided. Typically, providing erroneous addresses to mmap, results in a segmentation fault, and the default behavior is to return VM_FAULT_SIGBUS. This can happen for example when remap_io_mapping() or remap_io_sg() return -EINVAL.

Re: [PATCH v2] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-17 Thread Helge Deller
On 6/17/24 13:30, Thomas Zimmermann wrote: Am 17.06.24 um 13:06 schrieb Thomas Zimmermann: Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field, It sets the framebuffer address size and is unr

Re: [PATCH v2] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-17 Thread Thomas Zimmermann
Hi Am 17.06.24 um 14:42 schrieb Helge Deller: On 6/17/24 13:30, Thomas Zimmermann wrote: Am 17.06.24 um 13:06 schrieb Thomas Zimmermann: Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field,

Re: [PATCH v2 7/7] drm/panic: Add support for drawing a monochrome graphical logo

2024-06-17 Thread Geert Uytterhoeven
Hi Jocelyn, On Mon, Jun 17, 2024 at 11:59 AM Jocelyn Falempe wrote: > On 13/06/2024 21:18, Geert Uytterhoeven wrote: > > Re-use the existing support for boot-up logos to draw a monochrome > > graphical logo in the DRM panic handler. When no suitable graphical > > logo is available, the code fall

Re: [PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-17 Thread Lucas De Marchi
On Sun, Jun 16, 2024 at 09:03:48AM GMT, Andi Shyti wrote: Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's supposed to return a pointer to the intel_memory_region structure. Sparse complains with the following messa

Re: [PATCH 2/6] drm/ttm: Store the bo_kmap_type in struct iosys_map

2024-06-17 Thread Christian König
Hi, Am 17.06.24 um 14:32 schrieb Thomas Zimmermann: Hi Am 14.06.24 um 16:31 schrieb Christian König: Am 14.06.24 um 15:21 schrieb Thomas Zimmermann: For each instances of struct iosys_map set up by ttm_bo_vmap(), store the type of allocation in the instance. Use this information to unmap the

Re: [PATCH v5 1/4] drm/sched: add device name to the drm_sched_process_job event

2024-06-17 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 14/06/2024 à 11:08, Christian König a écrit : Am 14.06.24 um 10:16 schrieb Pierre-Eric Pelloux-Prayer: Until the switch from kthread to workqueue, a userspace application could determine the source device from the pid of the thread sending the event. With workqueues this is not possib

Re: [PATCH v5 1/4] drm/sched: add device name to the drm_sched_process_job event

2024-06-17 Thread Christian König
Am 17.06.24 um 14:54 schrieb Pierre-Eric Pelloux-Prayer: Hi, Le 14/06/2024 à 11:08, Christian König a écrit : Am 14.06.24 um 10:16 schrieb Pierre-Eric Pelloux-Prayer: Until the switch from kthread to workqueue, a userspace application could determine the source device from the pid of the thr

Re: [PATCH 3/6] drm/ttm: Support partial buffer mappings for ttm_bo_vmap()

2024-06-17 Thread Thomas Zimmermann
Hi Am 14.06.24 um 16:33 schrieb Christian König: Am 14.06.24 um 15:21 schrieb Thomas Zimmermann: Add offset and size parameters to ttm_bo_vmap() to allow for partial mappings of a buffer object. This brings the functionality on par with ttm_bo_kmap(). Well the long term plan was to remove thi

Re: [PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-17 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] Hi! Top-posting for once, to make this easily accessible to everyone. Hmm, seem nobody took a look at below fix for a regression that seems to be caused by f3d9

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 14:35 +0200,Christian König写道: > Am 17.06.24 um 12:58 schrieb Icenowy Zheng: > > The duplication of EOP packets for GFX7/8, with the former one have > > seq-1 written and the latter one have seq written, seems to confuse > > some > > hardware platform (e.g. Loongson 7A series PCIe

Re: [PATCH v2 7/7] drm/panic: Add support for drawing a monochrome graphical logo

2024-06-17 Thread Jocelyn Falempe
On 17/06/2024 14:49, Geert Uytterhoeven wrote: Hi Jocelyn, On Mon, Jun 17, 2024 at 11:59 AM Jocelyn Falempe wrote: On 13/06/2024 21:18, Geert Uytterhoeven wrote: Re-use the existing support for boot-up logos to draw a monochrome graphical logo in the DRM panic handler. When no suitable gr

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Christian König
Am 17.06.24 um 15:03 schrieb Icenowy Zheng: 在 2024-06-17星期一的 14:35 +0200,Christian König写道: Am 17.06.24 um 12:58 schrieb Icenowy Zheng: The duplication of EOP packets for GFX7/8, with the former one have seq-1 written and the latter one have seq written, seems to confuse some hardware platform

Re: [PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-17 Thread Adam Ford
On Mon, Jun 17, 2024 at 8:00 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing the regression list, as it should be in the loop for regressions: > https://docs.kernel.org/admin-guide/reporting-regressions.html] > > Hi! Top-posting for once, to make this easily accessible to everyo

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-17 Thread Leon Romanovsky
On Thu, Jun 13, 2024 at 11:21:57AM +0300, Omer Shpigelman wrote: > Add a common QP state machine which handles the moving for a QP from one > state to another including performing necessary checks, draining > in-flight transactions, invalidating caches and error reporting. > > Signed-off-by: Omer

Re: [PATCH net-next v12 01/13] netdev: add netdev_rx_queue_restart()

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Add netdev_rx_queue_restart() function to netdev_rx_queue.h see nit below Reviewed-by: Pavel Begunkov Signed-off-by: David Wei Signed-off-by: Mina Almasry --- v11: - Fix not checking dev->queue_mgmt_ops (Pavel). - Fix ndo_queue_mem_free call that p

[PATCH AUTOSEL 6.9 38/44] drm/amdgpu/pptable: Fix UBSAN array-index-out-of-bounds

2024-06-17 Thread Sasha Levin
From: Tasos Sahanidis [ Upstream commit c6c4dd54012551cce5cde408b35468f2c62b0cce ] Flexible arrays used [1] instead of []. Replace the former with the latter to resolve multiple UBSAN warnings observed on boot with a BONAIRE card. In addition, use the __counted_by attribute where possible to hi

Re: [PATCH net-next v12 03/13] netdev: support binding dma-buf to netdevice

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from

Re: [PATCH v7 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-06-17 Thread Michael Walle
Hi Angelo, > +/** > + * mtk_drm_of_ddp_path_build_one - Build a Display HW Pipeline for a CRTC > Path > + * @dev: The mediatek-drm device > + * @cpath:CRTC Path relative to a VDO or MMSYS > + * @out_path: Pointer to an array that will contain the new pipeline > + * @out_path_

Re: drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-06-17 Thread Adam Ford
On Mon, Jun 17, 2024 at 1:17 AM Dominique MARTINET wrote: > > Adam Ford wrote on Sat, Feb 03, 2024 at 10:52:50AM -0600: > > From: Lucas Stach > > > > Add a simple wrapper driver for the DWC HDMI bridge driver that > > implements the few bits that are necessary to abstract the i.MX8MP > > SoC inte

Re: [PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-17 Thread Linux regression tracking (Thorsten Leemhuis)
On 17.06.24 15:14, Adam Ford wrote: > On Mon, Jun 17, 2024 at 8:00 AM Linux regression tracking (Thorsten > Leemhuis) wrote: >> >> [CCing the regression list, as it should be in the loop for regressions: >> https://docs.kernel.org/admin-guide/reporting-regressions.html] >> >> Hi! Top-posting for o

Re: [PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-17 Thread Adam Ford
On Mon, Jun 17, 2024 at 8:29 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 17.06.24 15:14, Adam Ford wrote: > > On Mon, Jun 17, 2024 at 8:00 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> > >> [CCing the regression list, as it should be in the loop for regressio

Re: [PATCH net-next v12 04/13] netdev: netdevice devmem allocator

2024-06-17 Thread Pavel Begunkov
On 6/13/24 02:35, Mina Almasry wrote: Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory regi

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Icenowy Zheng
在 2024-06-17星期一的 15:09 +0200,Christian König写道: > Am 17.06.24 um 15:03 schrieb Icenowy Zheng: > > 在 2024-06-17星期一的 14:35 +0200,Christian König写道: > > > Am 17.06.24 um 12:58 schrieb Icenowy Zheng: > > > > The duplication of EOP packets for GFX7/8, with the former one > > > > have > > > > seq-1 writt

Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency

2024-06-17 Thread Zack Rusin
On Mon, Jun 17, 2024 at 6:02 AM Borislav Petkov wrote: > > On Mon, Jun 17, 2024 at 11:07:09AM +0200, Borislav Petkov wrote: > > On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > > > VMWARE_HYPERCALL alternative will not work as intended without > > > VMware guest code initializati

Correct sequencing of usage of DRM writeback connector

2024-06-17 Thread Hoosier, Matt
Hi, There is a discussion ongoing over in the compositor world about the implication of this cautionary wording found in the documentation for the DRM_MODE_CONNECTOR_WRITEBACK connectors: > * "WRITEBACK_OUT_FENCE_PTR": > *Userspace can use this property to provide a pointer for the kerne

Re: [RFC] GPU driver with separate "core" and "DRM" modules

2024-06-17 Thread Daniel Vetter
On Fri, Jun 14, 2024 at 03:02:09AM +1000, Ben Skeggs wrote: > NVIDIA has been exploring ways to better support the effort for an > upstream kernel mode driver for GPUs that are capable of running GSP-RM > firmware, since the introduction[1] to Nova. > > Use cases have been identified for which sep

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-06-17 Thread Daniel Vetter
On Fri, Jun 14, 2024 at 11:01:45AM +0200, Daniel Vetter wrote: > On Thu, May 23, 2024 at 04:51:25PM +0200, Maxime Ripard wrote: > > Hi, > > > > Reviving this thread because I'm not sure what the outcome was. > > > > On Thu, Feb 29, 2024 at 11:52:12AM GMT, Daniel Vetter wrote: > > > > The only thi

Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content

2024-06-17 Thread Christian König
Am 17.06.24 um 15:43 schrieb Icenowy Zheng: 在 2024-06-17星期一的 15:09 +0200,Christian König写道: Am 17.06.24 um 15:03 schrieb Icenowy Zheng: 在 2024-06-17星期一的 14:35 +0200,Christian König写道: Am 17.06.24 um 12:58 schrieb Icenowy Zheng: The duplication of EOP packets for GFX7/8, with the former one ha

Re: [PATCH] drm/fbdev-dma: fix getting smem_start

2024-06-17 Thread Daniel Vetter
On Thu, Jun 13, 2024 at 12:18:55PM +0200, Thomas Zimmermann wrote: > Hi > > Am 13.06.24 um 12:14 schrieb Thomas Zimmermann: > > Hi > > > > Am 12.06.24 um 17:00 schrieb Daniel Vetter: > > > On Wed, Jun 12, 2024 at 10:37:14AM +0200, Thomas Zimmermann wrote: > > > > Hi Javier > > > > > > > > Am 12.

  1   2   3   >