Re: [PATCH] drm/fbdev-dma: fix getting smem_start

2024-06-11 Thread Thomas Zimmermann
Hi Am 11.06.24 um 03:00 schrieb Peng Fan: Subject: Re: [PATCH] drm/fbdev-dma: fix getting smem_start Hi Am 04.06.24 um 10:03 schrieb Peng Fan (OSS): From: Peng Fan If 'info->screen_buffer' locates in vmalloc address space, virt_to_page will not be able to get correct results. With CONFIG_DE

Re: [PATCH 2/2] drm/panel: Add Samsung AMS639RQ08 panel driver

2024-06-11 Thread neil . armstrong
On 09/06/2024 22:36, Danila Tikhonov wrote: Add the driver for Samsung AMS639RQ08 FHD Plus CMD mode panel support found in: - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael) Tested-by: Degd

Re: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

2024-06-11 Thread neil . armstrong
On 08/06/2024 11:17, Tejas Vipin wrote: From: Tejas Vipin Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a value and not as a reference. Please add a Fixes tag Signed-off-by: Tej

Re: [PATCH v3 00/24] drm/panel: Remove most store/double-check of prepared/enabled state

2024-06-11 Thread Neil Armstrong
Hi, On 05/06/2024 02:22, Douglas Anderson wrote: As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying

Re: (subset) [PATCH v3 00/24] drm/panel: Remove most store/double-check of prepared/enabled state

2024-06-11 Thread Neil Armstrong
Hi, On Tue, 04 Jun 2024 17:22:46 -0700, Douglas Anderson wrote: > As talked about in commit d2aacaf07395 ("drm/panel: Check for already > prepared/enabled in drm_panel"), we want to remove needless code from > panel drivers that was storing and double-checking the > prepared/enabled state. Even if

Re: [PATCH v8 09/16] drm/mediatek: Support "None" blending in OVL

2024-06-11 Thread 胡俊光

Re: [PATCH v8 08/16] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-11 Thread 胡俊光

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-11 Thread Christian König
Am 11.06.24 um 08:25 schrieb Christoph Hellwig: On Mon, Jun 10, 2024 at 02:38:18PM +0200, Christian König wrote: Well there is the fundamental problem that you can't use io_uring to implement the semantics necessary for a dma_fence. What is the exact problem there? It's an intentional design

RE: [PATCH] drm/fbdev-dma: fix getting smem_start

2024-06-11 Thread Peng Fan
> Subject: Re: [PATCH] drm/fbdev-dma: fix getting smem_start > > Hi > > Am 11.06.24 um 03:00 schrieb Peng Fan: > >> Subject: Re: [PATCH] drm/fbdev-dma: fix getting smem_start > >> > >> Hi > >> > >> Am 04.06.24 um 10:03 schrieb Peng Fan (OSS): > >>> From: Peng Fan > >>> > >>> If 'info->screen_buf

[PATCH v2] drivers/base/devres.c: refactor using guards

2024-06-11 Thread Andrea Calabrese
: Andrea Calabrese --- Difference from patch V1: devres_remove had a double deletion that caused a warn. Removed it and tested it accordingly to the instructions found on https://download.01.org/0day-ci/archive/20240611/202406111401.915dd40c-oliver.s...@intel.com diff --git a/drivers/base/devres.c b

[PATCH v6 0/3] drm/mediatek: Add support for OF graphs

2024-06-11 Thread AngeloGioacchino Del Regno
Changes in v6: - Added EPROBE_DEFER check to fix dsi/dpi false positive DT fallback case - Dropped refcount of ep_out in mtk_drm_of_get_ddp_ep_cid() - Fixed double refcount drop during path building - Removed failure upon finding a DT-disabled path as requested - Tested again on MT8195, MT8395

[PATCH v6 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-06-11 Thread AngeloGioacchino Del Regno
Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths per HW instance (so potentially up to six displays for multi-vdo SoCs). The MMSYS or VDOSYS is always the first component in the DDP pipeline, so it only supports an output port with multiple endpoints - where each endpoint def

[PATCH v6 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

2024-06-11 Thread AngeloGioacchino Del Regno
The display IPs in MediaTek SoCs support being interconnected with different instances of DDP IPs (for example, merge0 or merge1) and/or with different DDP IPs (for example, rdma can be connected with either color, dpi, dsi, merge, etc), forming a full Display Data Path that ends with an actual dis

[PATCH v6 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-06-11 Thread AngeloGioacchino Del Regno
It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for 10 SoCs and this is going to grow larger and larger, and with new hacks like the introduction of mtk_drm_route which is a

drm-ci: flaky tests for vkms driver testing

2024-06-11 Thread Vignesh Raman
Hi Maintainers, There are some flaky tests reported for vkms driver testing in drm-ci. # Board Name: vkms # Failure Rate: 50 # IGT Version: 1.28-g0df7b9b97 # Linux Version: 6.9.0-rc7 kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic kms_flip@basic-flip-vs-wf_vblank kms_flip@flip-vs-exp

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-11 Thread Maxime Ripard
On Mon, Jun 10, 2024 at 08:54:09PM GMT, Dmitry Baryshkov wrote: > On Mon, Jun 10, 2024 at 02:07:06PM +0200, Maxime Ripard wrote: > > Hi, > > > > +Hans > > > > On Mon, Jun 10, 2024 at 02:46:03PM GMT, Dmitry Baryshkov wrote: > > > On Mon, 10 Jun 2024 at 11:04, Maxime Ripard wrote: > > > > > > > >

[PATCH v3 1/2] dt-bindings: gpu: mali-bifrost: Add compatible for MT8188 SoC

2024-06-11 Thread AngeloGioacchino Del Regno
Add a compatible for the MediaTek MT8188 SoC, with an integrated ARM Mali G57 MC3 (Valhall-JM) GPU. Acked-by: Conor Dooley Reviewed-by: Chen-Yu Tsai Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 - 1 file changed, 4 insertion

[PATCH v3 0/2] drm/panfrost: Add MT8188 support

2024-06-11 Thread AngeloGioacchino Del Regno
Changes in v3: - Added comment stating that MT8188 uses same supplies as MT8183 as requested by Steven Changes in v2: - Fixed bindings to restrict number of power domains for MT8188's GPU to three like MT8183(b). This series adds support for MT8188's Mali-G57 MC3. AngeloGioacchino Del Re

[PATCH v3 2/2] drm/panfrost: Add support for Mali on the MT8188 SoC

2024-06-11 Thread AngeloGioacchino Del Regno
MediaTek MT8188 has a Mali-G57 MC3 (Valhall-JM): add a new compatible and platform data using the same supplies and the same power domain lists as MT8183 (one regulator, three power domains). Reviewed-by: Chen-Yu Tsai Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfr

Re: [PATCH v8 10/16] drm/mediatek: Support "None" blending in Mixer

2024-06-11 Thread 胡俊光

[PATCH v5] drm/ci: add tests on vkms

2024-06-11 Thread Vignesh Raman
Add job that runs igt on top of vkms. Acked-by: Maíra Canal Acked-by: Helen Koike Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Helen Koike --- v2: - do not mv modules to /lib/modules in the job definition, leave it to

Re: [PATCH v6 0/7] Add mediate-drm secure flow for SVP

2024-06-11 Thread 林睿祥

Re: [PATCH v2] drivers/base/devres.c: refactor using guards

2024-06-11 Thread Javier Martinez Canillas
Andrea Calabrese writes: Hello Andrea, > Refactored devres.c using lock guards and scoped locks. > Changed functions: > - devres_for_each_res > - devres_add > - devres_find > - devres_get > - devres_remove > - release_nodes > - release_all > - devres_open_group > - find_group > - devres_remove_g

Re: [PATCH] drm/fbdev-dma: fix getting smem_start

2024-06-11 Thread Thomas Zimmermann
Hi Am 11.06.24 um 10:23 schrieb Peng Fan: Subject: Re: [PATCH] drm/fbdev-dma: fix getting smem_start Hi Am 11.06.24 um 03:00 schrieb Peng Fan: Subject: Re: [PATCH] drm/fbdev-dma: fix getting smem_start Hi Am 04.06.24 um 10:03 schrieb Peng Fan (OSS): From: Peng Fan If 'info->screen_buffer

[PATCH] drm: Fix alignment of temporary stack ioctl buffers

2024-06-11 Thread carsten . haitzler
From: Carsten Haitzler In a few places (core drm + AMD kfd driver), the ioctl handling uses a temporary 128 byte buffer on the stack to copy to/from user. ioctl data can have structs with types of much larger sizes than a byte and a system may require alignment of types in these. At the same time

[PATCH v3] devres: Refactor using guards

2024-06-11 Thread Andrea Calabrese
Code refactoring using the recent guard and scoped_guard macros for automatic cleanup of the spinlocks. This does not change the effective behaviour of the kernel, but guarantees a cleaned-up exit from each lock, automatically avoiding potential deadlocks. Signed-off-by: Andrea Calabrese --- Cha

Re: [PATCH v8 11/16] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-11 Thread 胡俊光

Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-06-11 Thread Danilo Krummrich
On 5/18/24 01:26, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" 'init_exec' is unused since commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new init table parser") Remove it. Signed-off-by: Dr. David Alan Gilbert Acked-by: Danilo Krummrich To which series does t

Re: [PATCH v8 12/16] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-11 Thread 胡俊光

Re: [PATCH v2] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-06-11 Thread Danilo Krummrich
On 6/8/24 00:09, Vasily Khoruzhick wrote: If the card doesn't have display hardware, hpd_work and hpd_lock are left uninitialized which causes BUG when attempting to schedule hpd_work on runtime PM resume. Fix it by adding headless flag to DRM and skip any hpd if it's set. Fixes: ae1aadb1eb8d (

Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-06-11 Thread Dr. David Alan Gilbert
* Danilo Krummrich (d...@redhat.com) wrote: > On 5/18/24 01:26, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > 'init_exec' is unused since > > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > > init table parser") > > Remove it. > > > > Signed-off-by: D

Re: [PATCH v5] drm/ci: add tests on vkms

2024-06-11 Thread Vignesh Raman
Hi, Successful pipeline link, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1198487 Regards, Vignesh On 11/06/24 14:40, Vignesh Raman wrote: Add job that runs igt on top of vkms. Acked-by: Maíra Canal Acked-by: Helen Koike Signed-off-by: Vignesh Raman Acked-by: Jessica Zhan

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-11 Thread Dmitry Baryshkov
On Tue, 11 Jun 2024 at 11:54, Maxime Ripard wrote: > > On Mon, Jun 10, 2024 at 08:54:09PM GMT, Dmitry Baryshkov wrote: > > On Mon, Jun 10, 2024 at 02:07:06PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > +Hans > > > > > > On Mon, Jun 10, 2024 at 02:46:03PM GMT, Dmitry Baryshkov wrote: > > > >

[PATCH 00/15] accel/ivpu: Changes for 6.11

2024-06-11 Thread Jacek Lawrynowicz
Power usage and security fixes along with some cleanup. Andrzej Kacprowski (1): accel/ivpu: Increase autosuspend delay to 100ms on 40xx Jacek Lawrynowicz (6): accel/ivpu: Remove suspend_reschedule_counter accel/ivpu: Implement DCT handling accel/ivpu: Make selected params read-only acce

[PATCH 01/15] accel/ivpu: Add wp0_during_power_up WA

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Send workpoint 0 request during power up on 37xx. This is needed in rare case where WP0 was not sent during power down due to device hang. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 1 + drivers/accel/ivpu/ivp

[PATCH 02/15] accel/ivpu: Abort jobs of faulty context

2024-06-11 Thread Jacek Lawrynowicz
From: Maciej Falkowski Abort all jobs that belong to contexts generating MMU faults in order to avoid flooding host with MMU IRQs. Jobs are cancelled with: - SSID_RELEASE command when OS scheduling is enabled - DESTROY_CMDQ command when HW scheduling is enabled Signed-off-by: Maciej Falkows

[PATCH 03/15] accel/ivpu: Remove suspend_reschedule_counter

2024-06-11 Thread Jacek Lawrynowicz
Don't retry runtime suspend. It is now expected to succeed on the first try. After autosuspend_delay passed, FW should already be idle and ready for warm suspend. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 31 +++ drivers/accel/ivpu/ivpu_pm.h

[PATCH 04/15] accel/ivpu: Disable disable_clock_relinquish WA for LNL B0+

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" This WA is only needed for LNL revision A. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 2 ++ drivers/accel/ivpu/ivpu_hw.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/accel/ivp

[PATCH 06/15] accel/ivpu: Implement DCT handling

2024-06-11 Thread Jacek Lawrynowicz
When host system is under heavy load and the NPU is already running on the lowest frequency, PUNIT may request Duty Cycle Throttling (DCT). This will further reduce NPU power usage. PUNIT requests DCT mode using Survabilty IRQ and mailbox register. The driver then issues a JSM message to the FW th

[PATCH 08/15] accel/ivpu: Update FW BOOT API headers

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" This commit bumps BOOT API version to 3.24 Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/vpu_boot_api.h | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/vpu_boot_api.h b

[PATCH 10/15] accel/ivpu: Add test mode flag for disabling timeouts

2024-06-11 Thread Jacek Lawrynowicz
From: Maciej Falkowski Add new test mode flag that will disable all timeouts defined in timeout fields of struct ivpu_device. Remove also reschedule_suspend field as it is unused. Signed-off-by: Maciej Falkowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 2 +- drive

[PATCH 09/15] accel/ivpu: Make parts of FW image read-only

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Implement setting specified buffer ranges as read-only. In case if specified range is not 64K aligned and 64K contiguous MMU600 pages are turned on, split 64K mapping to allow 4K granularity for read-only configuration. Signed-off-by: Wachowski, Karol Signed-off-by: Jac

[PATCH 05/15] accel/ivpu: Disable clock relinquish for MMIO reset

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" It is required to disable NPU clock relinquish for the time of MMIO reset. Clock relinquish gets into default (enabled) state after MMIO reset is performed. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw_btrs.c | 2 ++

[PATCH 11/15] accel/ivpu: Disable MMU before checking for idle

2024-06-11 Thread Jacek Lawrynowicz
Disable MMU communication before checking if NPU is idle. NPU may otherwise be woken up when adding/removing contexts. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm

[PATCH 13/15] accel/ivpu: Increase autosuspend delay to 100ms on 40xx

2024-06-11 Thread Jacek Lawrynowicz
From: Andrzej Kacprowski The new HW is more power efficient and there is no need to enter the D0i3/D3 so quickly. Increasing autosuspend delay reduces latency in certain usage scenarios. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw.c | 5 ++

[PATCH 12/15] accel/ivpu: Synchronize device unbind with recovery work

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Do not allow unbinding device in the middle of recovery flow. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/dri

[PATCH 07/15] accel/ivpu: Make selected params read-only

2024-06-11 Thread Jacek Lawrynowicz
Make disable_mmu_cont_pages and force_snoop params read-only. It is unsafe to change these params after driver is loaded. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/dri

[PATCH 14/15] accel/ivpu: Remove duplicated debug messages

2024-06-11 Thread Jacek Lawrynowicz
Remove duplicated debug messages from ivpu_jsm_(un)register_db(). Debug messages are already printed one level higher. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_jsm_msg.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/accel/iv

[PATCH 15/15] accel/ivpu: Remove unused ivpu_rpm_get_if_active()

2024-06-11 Thread Jacek Lawrynowicz
This is now dead code and has to be removed. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 10 -- drivers/accel/ivpu/ivpu_pm.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c index e7aed16b1a36..59d3

[PATCH 01/17] backlight: Add BL_CORE_ constants for power states

2024-06-11 Thread Thomas Zimmermann
Duplicate FB_BLANK_ constants as BL_CORE_ constants in the backlight header file. Allows backlight drivers to avoid including the fbdev header file and removes a compile-time dependency between the two subsystems. The new BL_CORE constants have the same values as their FB_BLANK_ counterparts. Henc

[PATCH 04/17] backlight: corgi-lcd: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Only change the driver's backlight device, but leave the LCD device as-is. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/corgi_lcd.c

[PATCH 10/17] backlight: led-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/led_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 09/17] backlight: ktd253-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ktd253-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --gi

[PATCH 17/17] backlight: sky81452-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/sky81452-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 14/17] backlight: pcf50633-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pcf50633-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --

[PATCH 02/17] backlight: aat2870-backlight: Use blacklight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/aat2870_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 16/17] backlight: rave-sp-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/rave-sp-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 05/17] backlight: gpio-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/gpio_backlight.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --

[PATCH 03/17] backlight: ams369fb06: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ams369fg06.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletion

[PATCH 08/17] backlight: kb3886-bl: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/kb3886_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 12/17] backlight: mp3309c: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/mp3309c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 13/17] backlight: pandora-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pandora_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

[PATCH 06/17] backlight: ipaq-micro-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ipaq_micro_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dr

[PATCH 07/17] backlight: journada_bl: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/jornada720_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dr

[PATCH 15/17] backlight: pwm-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pwm_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 11/17] backlight: lm3533-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/lm3533_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

Re: [PATCH v13 06/12] drm/ttm/tests: Add tests with mock resource managers

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > Add mock resource manager to test ttm_bo_validate() with non-system > placements. Update KConfig entry to enable DRM Buddy allocator, used > by the mock manager. Update move function to do more than just assign > a resource. > > Signed-

Re: [PATCH v13 11/12] drm/ttm/tests: Correct modules' licenses

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > The test files are GPL and MIT, so update the definitions > accordingly. > > Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/ttm/tests/ttm_bo_test.c   | 2 +- >  drivers/gpu/drm/ttm/tests/

Re: [PATCH v13 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > Update the tests and helpers to use unsigned kernel types. > > Signed-off-by: Karolina Stolarek > Suggested-by: Thomas Hellström Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/ttm/tests/ttm_bo_test.c   | 12 ++--

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote: > > The modpost script is not happy > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in > > drivers/gpu/drm/drm_mipi_dbi.o > > > > because there is a missin

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Andi Shyti
Hi Rodrigo, ... > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > index 4fcba42cfe34..0437fd8217e0 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > @@ -7

Re: [PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-11 Thread Andi Shyti
Hi Daniele, thanks for checking this patch. > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > index 0eaa1064242c..1181043bc5e9 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > +++ b/drivers/gpu/drm

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:34 AM, Andy Shevchenko wrote: > On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote: >> On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote: >>> The modpost script is not happy >>> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in >>> drivers/gpu/drm/dr

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
On 4/25/24 05:56, Andy Shevchenko wrote: The modpost script is not happy WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_mipi_dbi.o because there is a missing module description. Add it to the module. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/drm_mipi_dbi

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Andy Shevchenko
On Tue, Jun 11, 2024 at 06:46:12AM -0700, Jeff Johnson wrote: > On 4/25/24 05:56, Andy Shevchenko wrote: ... > I'll remove this from my series No need, Maxime already applied, and I see 665415092eca ("drm: add missing MODULE_DESCRIPTION() macros") > Reviewed-by: Jeff Johnson But thanks. --

[PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
On x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_panel_orientation_quirks.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/i915/kvm

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Tvrtko Ursulin
On 10/06/2024 10:24, Nirmoy Das wrote: Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in the fw_domains_show() debugfs interface. Signe

Re: [PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:56 AM, Jeff Johnson wrote: > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/drm_panel_orientation_quirks.o > WARNING: modpost: miss

Re: [PATCH v2 1/3] drm/mgag200: Consolidate VGA output

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: The various models have common code for the VGA output's encoder and connector. Move everything into a single shared source file. Remove some obsolete initializer macros. No functional changes. Thanks for this patch, it removes some duplication,

Re: [PATCH v2 2/3] drm/mgag200: Add BMC output

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: The BMC output can be viewed via the BMC's web interface or a similar client. Represent it as virtual encoder and connector. It's attached to the same CRTC as the VGA connector. The connector's status depends on the physical connector's status. Th

Re: [PATCH v2 3/3] drm/mgag200: Set .detect_ctx() and enable connector polling

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: Set .detect_ctx() in struct drm_connector_helper_funcs to the common helper drm_connector_helper_detect_from_ddc() and enable polling for the connector. Mgag200 will now test for the monitor's presence by probing the DDC in regular intervals. I've

Re: [PATCH v2 1/5] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-06-11 Thread Luca Ceresoli
Hello Rob, thanks for the follow up. I still have a couple questions for you before I see a clear direction forward, see below. On Wed, 5 Jun 2024 08:45:31 -0600 Rob Herring wrote: [...] > > > > + # "base" overlay describing the common components on every add-on > > > > that > > > > + # are

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Nirmoy Das
On 6/11/2024 3:58 PM, Tvrtko Ursulin wrote: On 10/06/2024 10:24, Nirmoy Das wrote: Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in t

[PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-11 Thread Douglas Anderson
At shutdown if you've got a _properly_ coded DRM modeset driver then you'll get these two warnings at shutdown time: Skipping disable of already disabled panel Skipping unprepare of already unprepared panel These warnings are ugly and sound concerning, but they're actually a sign of a properl

Re: [PATCH v2 3/3] drm/mgag200: Set .detect_ctx() and enable connector polling

2024-06-11 Thread Thomas Zimmermann
Hi Jocelyn Am 11.06.24 um 16:41 schrieb Jocelyn Falempe: On 10/06/2024 16:06, Thomas Zimmermann wrote: Set .detect_ctx() in struct drm_connector_helper_funcs to the common helper drm_connector_helper_detect_from_ddc() and enable polling for the connector. Mgag200 will now test for the monitor

Re: [RFC PATCH 3/8] rust: drm: Add Device and Driver abstractions

2024-06-11 Thread Rob Herring
On Sat, Jun 8, 2024 at 11:16 PM Asahi Lina wrote: > > > > On 5/22/24 6:23 AM, Rob Herring wrote: > > On Mon, May 20, 2024 at 07:20:50PM +0200, Danilo Krummrich wrote: > >> From: Asahi Lina > >> > >> Add abstractions for DRM drivers and devices. These go together in one > >> commit since both are

Re: [PATCH v2] drm/panel : truly-nt35521: transition to mipi_dsi wrapped functions

2024-06-11 Thread Doug Anderson
Hi, On Tue, Jun 11, 2024 at 7:44 AM Tejas Vipin wrote: > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > sony tulip truly nt35521 panel. >

[PATCH 0/8] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

2024-06-11 Thread Jonas Karlman
This series ensure poweron/poweroff and CEC phys addr invalidation is happening under drm mode_config mutex lock, and also ensure EDID is updated (when the dw-hdmi connector is used) after a hotplug pulse. These changes has mainly been tested on Rockchip devices together with a forthcoming series

[PATCH 8/8] drm: bridge: dw_hdmi: Use display_info is_hdmi and has_audio

2024-06-11 Thread Jonas Karlman
drm_edid_connector_update() is being called from bridge connector ops and from detect and get_modes ops for dw-hdmi connector. Change to use is_hdmi and has_audio from display_info directly instead of keeping our own state in sink_is_hdmi and sink_has_audio. Also remove the old and unused edid st

[PATCH 3/8] drm: bridge: dw_hdmi: Fold poweron and setup functions

2024-06-11 Thread Jonas Karlman
Fold the poweron and setup functions into one function and use the adjusted_mode directly from the new crtc_state to remove the need of storing previous_mode. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 - 1 file changed, 8 insertions(+), 1

[PATCH 5/8] drm: bridge: dw_hdmi: Invalidate CEC phys addr from connector detect

2024-06-11 Thread Jonas Karlman
Wait until the connector detect ops is called to invalidate CEC phys addr instead of doing it directly from the irq handler. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/

[PATCH 4/8] drm: bridge: dw_hdmi: Remove previous_mode and mode_set

2024-06-11 Thread Jonas Karlman
With the use of adjusted_mode directly from the crtc_state there is no longer a need to store a copy in previous_mode, remove it and the now unneeded mode_set ops. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 19 +-- 1 file changed, 1 insertion(+),

[PATCH 7/8] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-06-11 Thread Jonas Karlman
Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH 1/8] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable

2024-06-11 Thread Jonas Karlman
Change to only call poweron/poweroff from atomic_enable/atomic_disable ops instead of trying to keep a bridge_is_on state and poweron/off in the hotplug irq handler. A benefit of this is that drm mode_config mutex is always held at poweron/off, something that may reduce the need for our own mutex.

[PATCH 6/8] drm: bridge: dw_hdmi: Remove cec_notifier_mutex

2024-06-11 Thread Jonas Karlman
With CEC phys addr invalidation moved away from the irq handler there is no longer a need for cec_notifier_mutex, remove it. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 2/8] drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode

2024-06-11 Thread Jonas Karlman
Use the passed mode instead of mixing use of passed mode and the stored previous_mode. The passed mode is currenly always the previous_mode. Also fix a small type and add a variable to help shorten a code line. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 -

Re: [PATCH] drm: Fix alignment of temporary stack ioctl buffers

2024-06-11 Thread T.J. Mercier
On Tue, Jun 11, 2024 at 2:35 AM wrote: > > From: Carsten Haitzler > > In a few places (core drm + AMD kfd driver), the ioctl handling uses a > temporary 128 byte buffer on the stack to copy to/from user. ioctl data > can have structs with types of much larger sizes than a byte and a > system may

Re: [PATCH v2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

2024-06-11 Thread Jessica Zhang
On 6/11/2024 7:05 AM, Tejas Vipin wrote: mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a value and not as a reference. Fixes: a2ab7cb169da ("drm/panel: himax-hx83102: use wrapped MIPI DCS functions") Signed-off-by: Tejas Vipin Hi Tejas, (for future reference, you

Re: [PATCH v2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

2024-06-11 Thread Doug Anderson
Hi, On Tue, Jun 11, 2024 at 7:05 AM Tejas Vipin wrote: > > mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a > value and not as a reference. > > Fixes: a2ab7cb169da ("drm/panel: himax-hx83102: use wrapped MIPI DCS > functions") > > Signed-off-by: Tejas Vipin Should be no

Re: [PATCH 5/6] drm/amdgpu: always enable move threshold for BOs

2024-06-11 Thread Tvrtko Ursulin
Hi Christian, On 04/06/2024 17:05, Christian König wrote: This should prevent buffer moves when the threshold is reached during CS. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 36 -- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 22 ++

  1   2   >