[GIT PULL] exynos-drm-fixes

2024-06-10 Thread Inki Dae
Hi Dave and Daniel, Two fixups - one for an regeression issue and other for memory leak - and one cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit eb55943aab89be99a26e34fc2175ebb3583a2778: Merge tag 'drm-misc-next-fixes-2024

Re: [bug report] drm/meson: fix unbind path if HDMI fails to bind

2024-06-10 Thread Neil Armstrong
Hi, On 08/06/2024 16:20, Dan Carpenter wrote: Hello Neil Armstrong, Commit 6a044642988b ("drm/meson: fix unbind path if HDMI fails to bind") from May 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/meson/meson_drv.c:377 meson_drv_bind_master

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-10 Thread Maxime Ripard
Hi, On Fri, Jun 07, 2024 at 04:22:59PM GMT, Dmitry Baryshkov wrote: > Turn drm_bridge_connector to using drmm_kzalloc() and > drmm_connector_init() and drop the custom destroy function. The > drm_connector_unregister() and fwnode_handle_put() are already handled > by the drm_connector_cleanup() an

Re: [PATCH v2] drm/mediatek: Log errors in probe with dev_err_probe()

2024-06-10 Thread AngeloGioacchino Del Regno
Il 07/06/24 01:52, Nícolas F. R. A. Prado ha scritto: Use dev_err_probe() to log errors in the probe function of all drm mediatek drivers. This avoids -EPROBE_DEFER return values from being logged as errors, like the following: mediatek-disp-rdma 1c002000.rdma: Failed to add component: -517

Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 22:36, Danila Tikhonov wrote: > The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode > AMOLED panel used in: > - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis) > - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci) > - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael)

Re: [PATCH v8 07/16] drm/mediatek: Support more 10bit formats in OVL

2024-06-10 Thread AngeloGioacchino Del Regno
Il 06/06/24 11:26, Shawn Sung ha scritto: From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v8 08/16] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-10 Thread AngeloGioacchino Del Regno
Il 06/06/24 11:26, Shawn Sung ha scritto: From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v8 05/16] drm/mediatek: Set DRM mode configs accordingly

2024-06-10 Thread AngeloGioacchino Del Regno
Il 06/06/24 11:26, Shawn Sung ha scritto: From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.I

Re: [PATCH v5 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-06-10 Thread AngeloGioacchino Del Regno
Il 06/06/24 07:29, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Wed, 2024-06-05 at 13:15 +0200, AngeloGioacchino Del Regno wrote: Il 05/06/24 03:38, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Tue, 2024-05-21 at 09:57 +0200, AngeloGioacchino Del Regno wrote: Document OF graph on MMSYS/VDOSYS: this supp

Re: [PATCH v5 1/9] drm/connector: hdmi: allow disabling Audio Infoframe

2024-06-10 Thread Maxime Ripard
On Fri, 7 Jun 2024 16:22:58 +0300, Dmitry Baryshkov wrote: > Add drm_atomic_helper_connector_hdmi_disable_audio_infoframe(), an API > to allow the driver disable sending the Audio Infoframe. This is to be > used by the drivers if setup of the infoframes is not tightly coupled > with the audio funct

Re: [PATCH] drm/tiny: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Hans de Goede
Hi, On 6/9/24 7:20 PM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/tiny/bochs.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tiny/cirrus.o > WARNING: modpost: missing MODULE_DESCRIPTI

Re: [PATCH v4 0/3] drm/mediatek: Add support for OF graphs

2024-06-10 Thread AngeloGioacchino Del Regno
Il 07/06/24 01:25, Nícolas F. R. A. Prado ha scritto: On Thu, May 16, 2024 at 10:11:01AM +0200, AngeloGioacchino Del Regno wrote: Changes in v4: - Fixed a typo that caused pure OF graphs pipelines multiple concurrent outputs to not get correctly parsed (port->id); - Added OVL_ADAPTOR sup

Re: [PATCH v5 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-06-10 Thread Maxime Ripard
On Fri, 7 Jun 2024 16:23:06 +0300, Dmitry Baryshkov wrote: > Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. > > While the HDMI block has special block to send HVS InfoFrame, use > GENERIC0 block instead. VENSPEC_INFO registers pack frame data in a way > that requires manual rep

Re: [PATCH] drm/fbdev-dma: fix getting smem_start

2024-06-10 Thread Thomas Zimmermann
Hi Am 04.06.24 um 10:03 schrieb Peng Fan (OSS): From: Peng Fan If 'info->screen_buffer' locates in vmalloc address space, virt_to_page will not be able to get correct results. With CONFIG_DEBUG_VM and CONFIG_DEBUG_VIRTUAL enabled on ARM64, there is dump below: Which graphics driver triggers

Re: [PATCH] drm/managed: Simplify if condition

2024-06-10 Thread Thomas Zimmermann
Am 05.06.24 um 13:50 schrieb Thorsten Blum: The if condition !A || A && B can be simplified to !A || B. Fixes the following Coccinelle/coccicheck warning reported by excluded_middle.cocci: WARNING !A || A && B is equivalent to !A || B Compile-tested only. Signed-off-by: Thorsten Bl

[PATCH v3 00/21] iommu: Refactoring domain allocation interface

2024-06-10 Thread Lu Baolu
The IOMMU subsystem has undergone some changes, including the removal of iommu_ops from the bus structure. Consequently, the existing domain allocation interface, which relies on a bus type argument, is no longer relevant: struct iommu_domain *iommu_domain_alloc(struct bus_type *bus) This ser

[PATCH v3 01/21] iommu: Add iommu_paging_domain_alloc() interface

2024-06-10 Thread Lu Baolu
Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from bus. The iommu subsystem no longer relies on bus for operations. So the bus parameter in iommu_domain_alloc() is no longer relevant. Add a new interface named iommu_paging_domain_alloc(), which explicitly indicates the allocati

[PATCH v3 02/21] iommufd: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
If the iommu driver doesn't implement its domain_alloc_user callback, iommufd_hwpt_paging_alloc() rolls back to allocate an iommu paging domain. Replace iommu_domain_alloc() with iommu_user_domain_alloc() to pass the device pointer along the path. Signed-off-by: Lu Baolu --- drivers/iommu/iommuf

[PATCH v3 03/21] vfio/type1: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
Replace iommu_domain_alloc() with iommu_paging_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/vfio/vfio_iommu_type1.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 3a0218171cfa..0960699e7554

[PATCH v3 04/21] vhost-vdpa: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
Replace iommu_domain_alloc() with iommu_paging_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/vhost/vdpa.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 63a53680a85c..e31ec9ebc4ce 100644 --- a/drivers/vho

[PATCH v3 05/21] drm/msm: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu Acked-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_iommu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff -

[PATCH v3 06/21] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
In nvkm_device_tegra_probe_iommu(), a paging domain is allocated for @dev and attached to it on success. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v3 07/21] gpu: host1x: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in host1x_iommu_attach() and is attached to host->dev. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/host1x/dev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.c b/driv

[PATCH v3 08/21] media: nvidia: tegra: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in tegra_vde_iommu_init() and is attached to vde->dev. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/media/platform/nvidia/tegra-vde/iommu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH v3 10/21] wifi: ath10k: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in ath10k_fw_init() and is attached to ar_snoc->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu Acked-by: Jeff Johnson --- drivers/net/wireless/ath/ath10k/snoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v3 09/21] media: venus: firmware: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in venus_firmware_init() and is attached to core->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/media/platform/qcom/venus/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

[PATCH v3 11/21] wifi: ath11k: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is attached to ab_ahb->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu Acked-by: Jeff Johnson --- drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- 1 file changed, 3 ins

[PATCH v3 12/21] remoteproc: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in rproc_enable_iommu() and is attached to rproc->dev.parent in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/remoteproc/remoteproc_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v3 13/21] soc/fsl/qbman: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
An iommu domain is allocated in portal_set_cpu() and is attached to pcfg->dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/soc/fsl/qbman/qman_portal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v3 14/21] RDMA/usnic: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
usnic_uiom_alloc_pd() allocates a paging domain for a given device. In this case, iommu_domain_alloc(dev->bus) is equivalent to  iommu_paging_domain_alloc(dev). Replace it as iommu_domain_alloc() has been deprecated. Signed-off-by: Lu Baolu Acked-by: Jason Gunthorpe --- drivers/infiniband/hw/us

[PATCH v3 15/21] iommu/vt-d: Add helper to allocate paging domain

2024-06-10 Thread Lu Baolu
The domain_alloc_user operation is currently implemented by allocating a paging domain using iommu_domain_alloc(). This is because it needs to fully initialize the domain before return. Add a helper to do this to avoid using iommu_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/iommu/intel/i

[PATCH v3 16/21] ARM: dma-mapping: Pass device to arm_iommu_create_mapping()

2024-06-10 Thread Lu Baolu
From: Robin Murphy All users of ARM IOMMU mappings create them for a particular device, so change the interface to accept the device rather than forcing a vague indirection through a bus type. This prepares for making a similar change to iommu_domain_alloc() itself. Signed-off-by: Robin Murphy

[PATCH v3 17/21] ARM: dma-mapping: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
Since arm_iommu_create_mapping() now accepts the device, let's replace iommu_domain_alloc() with iommu_paging_domain_alloc() to retire the former. Signed-off-by: Lu Baolu --- arch/arm/mm/dma-mapping.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/dma-mappi

[PATCH v3 18/21] drm/rockchip: Use iommu_paging_domain_alloc()

2024-06-10 Thread Lu Baolu
Commit <421be3ee36a4> ("drm/rockchip: Refactor IOMMU initialisation") has refactored rockchip_drm_init_iommu() to pass a device that the domain is allocated for. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to retire the former. Signed-off-by: Lu Baolu --- drivers/gpu/drm/rockch

[PATCH v3 19/21] drm/tegra: Remove call to iommu_domain_alloc()

2024-06-10 Thread Lu Baolu
Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from the bus structure. The iommu subsystem no longer relies on bus for operations. So iommu_domain_alloc() interface is no longer relevant. Normally, iommu_paging_domain_alloc() could be a replacement for iommu_domain_alloc() if th

[PATCH v3 20/21] iommu: Remove iommu_present()

2024-06-10 Thread Lu Baolu
The iommu_present() interface is no longer used in the tree anymore. Remove it to avoid dead code. Signed-off-by: Lu Baolu --- include/linux/iommu.h | 6 -- drivers/iommu/iommu.c | 25 - 2 files changed, 31 deletions(-) diff --git a/include/linux/iommu.h b/include/l

[PATCH v3 21/21] iommu: Remove iommu_domain_alloc()

2024-06-10 Thread Lu Baolu
The iommu_domain_alloc() interface is no longer used in the tree anymore. Remove it to avoid dead code. There is increasing demand for supporting multiple IOMMU drivers, and this is the last bus-based thing standing in the way of that. Signed-off-by: Lu Baolu --- include/linux/iommu.h | 6

Re: [PATCH 04/11] drm/exynos: hdmi: convert to struct drm_edid

2024-06-10 Thread Inki Dae
Hi, Jani Nikula, Thanks for your contribution and sorry for being late. Below are my comments. 2024년 5월 14일 (화) 오후 9:57, Jani Nikula 님이 작성: > > Prefer the struct drm_edid based functions for reading the EDID and > updating the connector. > > The functional change is that the CEC physical address

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-10 Thread Nirmoy Das
Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in the fw_domains_show() debugfs interface. Signed-off-by: Andi Shyti Needs a Fixes tag,

[PATCH v8 00/13] Make PCI's devres API more consistent

2024-06-10 Thread Philipp Stanner
This v8 is based on [1]. It contains the already applied patches in unchanged form; just for readability and consistency. Thx for taking the first set of patches! This series provides the enabled_cnt rework and some other minor fixes. See below. [1] https://git.kernel.org/pub/scm/linux/kernel/git

[PATCH v8 02/13] PCI: Add devres helpers for iomap table

2024-06-10 Thread Philipp Stanner
The pcim_iomap_devres.table administrated by pcim_iomap_table() has its entries set and unset at several places throughout devres.c using manual iterations which are effectively code duplications. Add pcim_add_mapping_to_legacy_table() and pcim_remove_mapping_from_legacy_table() helper functions a

[PATCH v8 03/13] PCI: Reimplement plural devres functions

2024-06-10 Thread Philipp Stanner
When the original PCI devres API was implemented, priority was given to the creation of a set of "plural functions" such as pcim_request_regions(). These functions have bit masks as parameters to specify which BARs shall get mapped. Most users, however, only use those to map 1-3 BARs. A complete s

[PATCH v8 05/13] PCI: Make devres region requests consistent

2024-06-10 Thread Philipp Stanner
Now that pure managed region request functions are available, the implementation of the hybrid-functions which are only sometimes managed can be made more consistent and readable by wrapping those always-managed functions. Implement pcim_request_region_exclusive() as a PCI-internal helper. Have t

[PATCH v8 06/13] PCI: Warn users about complicated devres nature

2024-06-10 Thread Philipp Stanner
The PCI region-request functions become managed functions when pcim_enable_device() has been called previously instead of pci_enable_device(). This has already caused a bug (in 8558de401b5f) by confusing users, who came to believe that all pci functions, such as pci_iomap_range(), suddenly are man

[PATCH v8 01/13] PCI: Add and use devres helper for bit masks

2024-06-10 Thread Philipp Stanner
The current derves implementation uses manual shift operations to check whether a bit in a mask is set. The code can be made more readable by writing a small helper function for that. Implement mask_contains_bar() and use it where applicable. Link: https://lore.kernel.org/r/20240605081605.18769-3

[PATCH v8 08/13] PCI: Move pinned status bit to struct pci_dev

2024-06-10 Thread Philipp Stanner
The bit describing whether the PCI device is currently pinned is stored in struct pci_devres. To clean up and simplify the PCI devres API, it's better if this information is stored in struct pci_dev. This will later permit simplifying pcim_enable_device(). Move the 'pinned' boolean bit to struct

[PATCH v8 09/13] PCI: Give pcim_set_mwi() its own devres callback

2024-06-10 Thread Philipp Stanner
Managing pci_set_mwi() with devres can easily be done with its own callback, without the necessity to store any state about it in a device-related struct. Remove the MWI state from struct pci_devres. Give pcim_set_mwi() a separate devres-callback. Signed-off-by: Philipp Stanner --- drivers/pci/

[PATCH v8 11/13] PCI: Remove legacy pcim_release()

2024-06-10 Thread Philipp Stanner
Thanks to preceding cleanup steps, pcim_release() is now not needed anymore and can be replaced by pcim_disable_device(), which is the exact counterpart to pcim_enable_device(). This permits removing further parts of the old PCI devres implementation. Replace pcim_release() with pcim_disable_devi

[PATCH v8 12/13] PCI: Add pcim_iomap_range()

2024-06-10 Thread Philipp Stanner
The only managed mapping function currently is pcim_iomap() which doesn't allow for mapping an area starting at a certain offset, which many drivers want. Add pcim_iomap_range() as an exported function. Signed-off-by: Philipp Stanner --- drivers/pci/devres.c | 44 +++

[PATCH v8 13/13] drm/vboxvideo: fix mapping leaks

2024-06-10 Thread Philipp Stanner
When the PCI devres API was introduced to this driver, it was wrongly assumed that initializing the device with pcim_enable_device() instead of pci_enable_device() will make all PCI functions managed. This is wrong and was caused by the quite confusing PCI devres API in which some, but not all, fu

[PATCH v8 07/13] PCI: Remove enabled status bit from pci_devres

2024-06-10 Thread Philipp Stanner
The PCI devres implementation has a separate boolean to track whether a device is enabled. However, that can easily be tracked through the function pci_is_enabled() which is agnostic. Using it allows for simplifying the PCI devres implementation. Replace the separate 'enabled' status bit from str

[PATCH v8 04/13] PCI: Deprecate two surplus devres functions

2024-06-10 Thread Philipp Stanner
pcim_iomap_table() should not be used anymore because it contributed to the PCI devres API being designed contrary to devres's design goals. pcim_iomap_regions_request_all() is a surplus, complicated function that can easily be replaced by using a pcim_* request function in combination with a pcim

[PATCH v8 10/13] PCI: Give pci_intx() its own devres callback

2024-06-10 Thread Philipp Stanner
pci_intx() is one of the functions that have "hybrid mode" (i.e., sometimes managed, sometimes not). Providing a separate pcim_intx() function with its own device resource and cleanup callback allows for removing further large parts of the legacy PCI devres implementation. As in the region-request

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-10 Thread Hans de Goede
Hi Tobias, On 5/31/24 9:04 PM, Tobias Jakobi wrote: > On 3/10/24 23:04, tjak...@math.uni-bielefeld.de wrote: > >> From: Tobias Jakobi >> >> Similar to the other Aya Neo devices this one features >> again a portrait screen, here with a native resolution >> of 1600x2560. >> >> Signed-off-by: Tobia

Re: [PATCH v8 08/13] PCI: Move pinned status bit to struct pci_dev

2024-06-10 Thread Philipp Stanner
On Mon, 2024-06-10 at 11:31 +0200, Philipp Stanner wrote: > The bit describing whether the PCI device is currently pinned is stored > in struct pci_devres. To clean up and simplify the PCI devres API, it's > better if this information is stored in struct pci_dev. > > This will later permit simplif

Re: (subset) [PATCH] drm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Maxime Ripard
On Thu, 06 Jun 2024 21:42:46 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tests/drm_kunit_helpers.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tests/drm_buddy_test.o > WARNI

Re: (subset) [PATCH] drm/panel: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Maxime Ripard
On Sun, 09 Jun 2024 09:53:21 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/panel/panel-abt-y030xx067a.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/panel/panel-auo-a030jtn01.o

Re: (subset) [PATCH] drm/tiny: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Maxime Ripard
On Sun, 09 Jun 2024 10:20:27 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/tiny/bochs.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/tiny/cirrus.o > WARNING: modpost: missing MODU

Re: (subset) [PATCH] drm/bridge: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Maxime Ripard
On Sun, 09 Jun 2024 10:06:17 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/bridge/lontium-lt9611.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/bridge/lontium-lt9611uxc.o > WAR

Re: (subset) [PATCH] drm: add missing MODULE_DESCRIPTION() macros

2024-06-10 Thread Maxime Ripard
On Sun, 09 Jun 2024 11:42:53 -0700, Jeff Johnson wrote: > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/drm_panel_orientation_quirks.o > WARNING:

Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

2024-06-10 Thread Maxime Ripard
On Sat, 24 Feb 2024 16:05:57 +0100, Ondřej Jirman wrote: > From: Ondrej Jirman > > This series refactors blender setup from individual planes to a common > place where it can be performed at once and is easier to reason about. > > In the process this fixes a few bugs that allowed blender pipes t

[PATCH v2] drm/bridge: it6505: remove unnecessary NULL checks

2024-06-10 Thread Dan Carpenter
Smatch complains correctly that the NULL checking isn't consistent: drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() error: we previously assumed 'pdata->pwr18' could be null (see line 2569) These the ->pwr18 pointer is allocated during probe using the devm_regulator_get() fu

[PATCH] drm/connector: hdmi: Fix kerneldoc warnings

2024-06-10 Thread Maxime Ripard
It looks like the documentation for the HDMI-related fields recently added to both the drm_connector and drm_connector_state structures trigger some warnings because of their use of anonymous structures: $ scripts/kernel-doc -none include/drm/drm_connector.h include/drm/drm_connector.h:1138: w

Re: [PATCH] drm/connector: hdmi: Fix kerneldoc warnings

2024-06-10 Thread Maxime Ripard
Hi, On Mon, Jun 10, 2024 at 01:12:00PM GMT, Maxime Ripard wrote: > It looks like the documentation for the HDMI-related fields recently > added to both the drm_connector and drm_connector_state structures > trigger some warnings because of their use of anonymous structures: > > $ scripts/kernel

Re: [PATCH] drm/komeda: check for error-valued pointer

2024-06-10 Thread Maxime Ripard
On Mon, Jun 10, 2024 at 11:20:56AM GMT, Amjad Ouled-Ameur wrote: > komeda_pipeline_get_state() may return an error-valued pointer, thus > check the pointer for negative or null value before dereferencing. > > Signed-off-by: Amjad Ouled-Ameur I've added a Fixes tag and applied to drm-misc-fixes,

Re: [PATCH] drm/bridge/panel: Fix runtime warning on panel bridge release

2024-06-10 Thread Maxime Ripard
On Mon, Jun 10, 2024 at 11:27:39AM GMT, Adam Miotk wrote: > Device managed panel bridge wrappers are created by calling to > drm_panel_bridge_add_typed() and registering a release handler for > clean-up when the device gets unbound. > > Since the memory for this bridge is also managed and linked t

Re: [PATCH v2] drm/bridge: it6505: remove unnecessary NULL checks

2024-06-10 Thread Robert Foss
On Mon, 10 Jun 2024 13:50:26 +0300, Dan Carpenter wrote: > Smatch complains correctly that the NULL checking isn't consistent: > > drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() > error: we previously assumed 'pdata->pwr18' could be null > (see line 2569) > > These the ->pw

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-10 Thread Tvrtko Ursulin
On 03/06/2024 17:20, Niemiec, Krzysztof wrote: The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does not provide valuable information, because it does not indicate that there is something necessarily wrong with either the driver or the

Re: [PATCH 10/14] drm/bridge: analogix_dp: move macro reset after link bandwidth setting

2024-06-10 Thread Robert Foss
On Tue, May 7, 2024 at 3:07 PM Robert Foss wrote: > > On Fri, May 3, 2024 at 5:13 PM Lucas Stach wrote: > > > > Setting the link bandwidth may change the PLL parameters, which will cause > > the PLL to go out of lock, so make sure to apply the MACRO_RST, which > > according to the comment is requ

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-10 Thread Dmitry Baryshkov
On Mon, 10 Jun 2024 at 11:04, Maxime Ripard wrote: > > Hi, > > On Fri, Jun 07, 2024 at 04:22:59PM GMT, Dmitry Baryshkov wrote: > > Turn drm_bridge_connector to using drmm_kzalloc() and > > drmm_connector_init() and drop the custom destroy function. The > > drm_connector_unregister() and fwnode_han

Re: [PATCH 11/14] drm/bridge: analogix_dp: don't wait for PLL lock too early

2024-06-10 Thread Robert Foss
On Fri, May 3, 2024 at 5:12 PM Lucas Stach wrote: > > The PLL will be reconfigured later, which may cause it to go out of lock > anyways, so there is no point in waiting for the PLL to lock here. Instead > we can continue execution of the link setup, which will properly set the > PLL parameters an

Re: [PATCH 12/14] drm/bridge: analogix_dp: simplify and correct PLL lock checks

2024-06-10 Thread Robert Foss
On Fri, May 3, 2024 at 5:12 PM Lucas Stach wrote: > > Move the wait loop into its own function, so it doesn't need to be > replicated in multiple locations. Also move the PLL lock checks between > setting the link bandwidth, which may cause the PLL to unlock, and the > MACRO_RST, which needs the P

Re: [PATCH 13/14] drm/bridge: analogix_dp: only read AUX status when an error occured

2024-06-10 Thread Robert Foss
On Fri, May 3, 2024 at 5:13 PM Lucas Stach wrote: > > All AUX error responses raise the AUX_ERR interrupt, so there is no > need to read the AUX status register in normal operation. Only read > the status when an error occured and we can expect a different status > than OK. > > Signed-off-by: Luca

Re: [PATCH 14/14] drm/bridge: analogix_dp: handle AUX transfer timeouts

2024-06-10 Thread Robert Foss
On Fri, May 3, 2024 at 5:12 PM Lucas Stach wrote: > > Timeouts on the AUX bus are to be expected in certain normal operating > conditions. There is no need to raise an error log or re-initialize the > whole AUX state machine. Simply acknowledge the AUX_ERR interrupt and > let upper layers know abo

Re: [PATCH] drm/edid: reduce DisplayID log spamming

2024-06-10 Thread Thomas Zimmermann
Am 06.06.24 um 14:35 schrieb Jani Nikula: Debug printing at DisplayID validation leads to lots of log spamming as it's called at DisplayID iterators during EDID parsing. Remove it, and replace with a less noisy message at connector EDID update. Signed-off-by: Jani Nikula Acked-by: Thomas Z

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-10 Thread Maxime Ripard
Hi, +Hans On Mon, Jun 10, 2024 at 02:46:03PM GMT, Dmitry Baryshkov wrote: > On Mon, 10 Jun 2024 at 11:04, Maxime Ripard wrote: > > > > Hi, > > > > On Fri, Jun 07, 2024 at 04:22:59PM GMT, Dmitry Baryshkov wrote: > > > Turn drm_bridge_connector to using drmm_kzalloc() and > > > drmm_connector_init

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-10 Thread Andi Shyti
Hi Tvrtko, On Mon, Jun 10, 2024 at 12:42:31PM +0100, Tvrtko Ursulin wrote: > On 03/06/2024 17:20, Niemiec, Krzysztof wrote: > > The test is trying to push the heartbeat frequency to the limit, which > > might sometimes fail. Such a failure does not provide valuable > > information, because it does

Re: [PATCH v2 3/3] drm/panic: Add a kmsg panic screen

2024-06-10 Thread Jocelyn Falempe
On 07/06/2024 11:16, Javier Martinez Canillas wrote: Jocelyn Falempe writes: Add a kmsg option, which will display the last lines of kmsg, and should be similar to fbcon. Add a drm.panic_screen module parameter, so you can choose between the different panic screens available. two options cu

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-10 Thread Jason Gunthorpe
On Mon, Jun 10, 2024 at 02:07:01AM +0100, Pavel Begunkov wrote: > On 6/10/24 01:37, David Wei wrote: > > On 2024-06-07 17:52, Jason Gunthorpe wrote: > > > IMHO it seems to compose poorly if you can only use the io_uring > > > lifecycle model with io_uring registered memory, and not with DMABUF > >

Re: [PATCH v2 7/9] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-06-10 Thread Aradhya Bhatia
Hi Dmitry, Thank you for reviewing the patches. On 31/05/24 04:51, Dmitry Baryshkov wrote: > On Thu, May 30, 2024 at 03:06:19PM +0530, Aradhya Bhatia wrote: >> Change the existing (and deprecated) bridge hooks, to the bridge >> atomic APIs. >> >> Add drm helpers for duplicate_state, destroy_state

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-10 Thread Christian König
Am 10.06.24 um 14:16 schrieb Jason Gunthorpe: On Mon, Jun 10, 2024 at 02:07:01AM +0100, Pavel Begunkov wrote: On 6/10/24 01:37, David Wei wrote: On 2024-06-07 17:52, Jason Gunthorpe wrote: IMHO it seems to compose poorly if you can only use the io_uring lifecycle model with io_uring registered

[syzbot] Monthly dri report (Jun 2024)

2024-06-10 Thread syzbot
Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 2 new issues were detected and 0 were fixed. In total, 18 issues are still open and 31 have been

Re: [PATCH 02/14] drm/rockchip: analogix_dp: add runtime PM handling

2024-06-10 Thread Heiko Stübner
Am Freitag, 3. Mai 2024, 17:11:17 CEST schrieb Lucas Stach: > Hook up the runtime PM suspend/resume paths to make the rockchip > glue behave more like the exynos one. The same suspend/resume > functions are used for system sleep via the runtime PM force > suspend/resume. > > Signed-off-by: Lucas S

Re: [PATCH 00/14] improve Analogix DP AUX channel handling

2024-06-10 Thread Heiko Stübner
Am Freitag, 3. Mai 2024, 17:11:15 CEST schrieb Lucas Stach: > Currently the AUX channel support in the Analogix DP driver is severely > limited as the AUX block of the bridge is only initialized when the video > link is to be enabled. This is okay for the purposes of link training, > but does not a

Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

2024-06-10 Thread Ondřej Jirman
On Mon, Jun 10, 2024 at 12:46:11PM GMT, Maxime Ripard wrote: > On Sat, 24 Feb 2024 16:05:57 +0100, Ondřej Jirman wrote: > > From: Ondrej Jirman > > > > This series refactors blender setup from individual planes to a common > > place where it can be performed at once and is easier to reason about.

Re: [PATCH 0/2] drm bridge: drop drm_bridge_chain_mode_fixup.

2024-06-10 Thread Robert Foss
On Fri, 31 May 2024 22:37:44 +0200, Sam Ravnborg wrote: > I had a few bridge related patches in an old branch. > > They were last posted here almost one year ago: > https://lore.kernel.org/dri-devel/20220717174454.46616-1-...@ravnborg.org/ > > The following two patches gets rid of drm_bridge_chai

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-10 Thread Tvrtko Ursulin
Hi Andi, On 10/06/2024 13:10, Andi Shyti wrote: Hi Tvrtko, On Mon, Jun 10, 2024 at 12:42:31PM +0100, Tvrtko Ursulin wrote: On 03/06/2024 17:20, Niemiec, Krzysztof wrote: The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does not prov

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-10 Thread Danilo Krummrich
On Sat, Jun 08, 2024 at 08:28:06AM +0900, FUJITA Tomonori wrote: > On Fri, 7 Jun 2024 19:55:49 +0200 > Danilo Krummrich wrote: > > > On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: > >> On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > >> > On Fri, Jun 07, 2024 at 02:36

[PATCH v4 0/3] Improve gpu_scheduler trace events

2024-06-10 Thread Pierre-Eric Pelloux-Prayer
v3: https://lists.freedesktop.org/archives/dri-devel/2024-June/456792.html Changes since v3: * trace device name instead of drm_device primary index * no pointer deref in the TP_printk anymore. Instead the fence context/seqno are saved in TP_fast_assign Pierre-Eric Pelloux-Prayer (3): drm/sched

[PATCH v4 1/3] drm/sched: add device name to the drm_sched_process_job event

2024-06-10 Thread Pierre-Eric Pelloux-Prayer
Until the switch from kthread to workqueue, a userspace application could determine the source device from the pid of the thread sending the event. With workqueues this is not possible anymore, so the event needs to contain the dev_name() to identify the device. Signed-off-by: Pierre-Eric Pelloux

[PATCH v4 2/3] drm/sched: cleanup gpu_scheduler trace events

2024-06-10 Thread Pierre-Eric Pelloux-Prayer
Print identifiers instead of pointers: * "fence=%p" is replaced by "fence=(context:%llu, seqno:%lld)" to have a coherent way to print the fence. A possible follow up change would be to use the same format in traces/../dma-fence.h. * "entity=%p" is removed because the fence's context is already an i

[PATCH v4 3/3] drm/sched: trace dependencies for gpu jobs

2024-06-10 Thread Pierre-Eric Pelloux-Prayer
Trace the fence dependencies similarly to how we print fences: ... , dependencies:{(context:606, seqno:38006)} This allows tools to analyze the dependencies between the jobs (previously it was only possible for fences traced by drm_sched_job_wait_dep). Since drm_sched_job and drm_run_job use th

[drm-misc:topic/rust-drm 9/20] warning: unresolved link to `new_device_data`

2024-06-10 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc topic/rust-drm head: 508348922df19178b613531fb6cc7beb624642ae commit: 28ea76b321b25ee422d9c9bd08f1bf605a9ae422 [9/20] rust: add device::Data config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240610/202406102138.eekfigxb

[PATCH v2 0/3] drm/mgag200: Detect connector status

2024-06-10 Thread Thomas Zimmermann
Detect the connector status by polling the DDC. Update the status at runtime. Add a dedicated BMC output to still display to the BMC while the VGA connector is not attached. This patchset fixes a long-standing problem where attaching the VGA display a runtime resulted in incorrect display modes.

[PATCH v2 3/3] drm/mgag200: Set .detect_ctx() and enable connector polling

2024-06-10 Thread Thomas Zimmermann
Set .detect_ctx() in struct drm_connector_helper_funcs to the common helper drm_connector_helper_detect_from_ddc() and enable polling for the connector. Mgag200 will now test for the monitor's presence by probing the DDC in regular intervals. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/

[PATCH v2 2/3] drm/mgag200: Add BMC output

2024-06-10 Thread Thomas Zimmermann
The BMC output can be viewed via the BMC's web interface or a similar client. Represent it as virtual encoder and connector. It's attached to the same CRTC as the VGA connector. The connector's status depends on the physical connector's status. The BMC is only connected if the physical connector i

[PATCH v2 1/3] drm/mgag200: Consolidate VGA output

2024-06-10 Thread Thomas Zimmermann
The various models have common code for the VGA output's encoder and connector. Move everything into a single shared source file. Remove some obsolete initializer macros. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile | 3 +- drivers/gpu/dr

Re: [PATCH] drm/bridge: tc358767: Fix comment in tc_edp_mode_valid

2024-06-10 Thread Robert Foss
On Fri, 31 May 2024 22:32:01 +0200, Marek Vasut wrote: > Fix comment copy-paste error in tc_edp_mode_valid(), this function > is validating DP/eDP clock, not DPI clock frequency. Update the > comment to match. No functional change. > > Applied, thanks! [1/1] drm/bridge: tc358767: Fix comment in

Re: [PATCH] drm/bridge: tc358767: Check if fully initialized before signalling HPD event via IRQ

2024-06-10 Thread Robert Foss
On Fri, 31 May 2024 22:33:12 +0200, Marek Vasut wrote: > Make sure the connector is fully initialized before signalling any > HPD events via drm_kms_helper_hotplug_event(), otherwise this may > lead to NULL pointer dereference. > > Applied, thanks! [1/1] drm/bridge: tc358767: Check if fully ini

Re: [PATCH] Revert "drm/amdgpu: init iommu after amdkfd device init"

2024-06-10 Thread Armin Wolf
Am 04.06.24 um 20:28 schrieb Deucher, Alexander: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Kuehling, Felix Sent: Tuesday, June 4, 2024 2:25 PM To: Armin Wolf ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; gre...@linuxfoundation.org; sa

  1   2   >