Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-06 Thread Jani Nikula
On Wed, 05 Jun 2024, Chris Bainbridge wrote: > On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: >> Hi Mario, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on drm-misc/drm-misc-next] >> [also build test ERROR on drm/drm-next drm-exynos/

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for PrimeView

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > The Prime View International (PVI) is a LCD panel manufacturer. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the pr

Re: [PATCH 2/3] dt-bindings: display: simple: Add PrimeView PM070WL4 panel

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > Add PrimeView PM070WL4 7.0" 800x480 TFT LCD panel compatible string. > > Signed-off-by: Primoz Fiser > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/dev

[PATCH] arm/komeda: Compile DEFINE_SHOW_ATTRIBUTE() only when CONFIG_DEBUG_FS is enabled

2024-06-06 Thread pengfuyuan
We do not call komeda_debugfs_init() and the debugfs core function declaration if CONFIG_DEBUG_FS is not defined, but we should not compile it either because the debugfs core function declaration is not included. Reported-by: k2ci Signed-off-by: pengfuyuan --- drivers/gpu/drm/arm/display/komeda

Re: [PATCH v7 07/13] PCI: Move dev-enabled status bit to struct pci_dev

2024-06-06 Thread Philipp Stanner
On Wed, 2024-06-05 at 16:11 -0500, Bjorn Helgaas wrote: > On Wed, Jun 05, 2024 at 10:15:59AM +0200, Philipp Stanner wrote: > > The bit describing whether the PCI device is currently enabled is > > stored > > in struct pci_devres. Besides this struct being subject of a > > cleanup > > process, struc

[PATCH 1/3] dt-bindings: Add vendor prefix for PrimeView

2024-06-06 Thread Primoz Fiser
The Prime View International (PVI) is a LCD panel manufacturer. Signed-off-by: Primoz Fiser --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings

[PATCH 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

2024-06-06 Thread Primoz Fiser
Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel. Datasheet can be found at [1]. [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf Signed-off-by: Primoz Fiser --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 inserti

[PATCH 2/3] dt-bindings: display: simple: Add PrimeView PM070WL4 panel

2024-06-06 Thread Primoz Fiser
Add PrimeView PM070WL4 7.0" 800x480 TFT LCD panel compatible string. Signed-off-by: Primoz Fiser --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Document

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add PrimeView

2024-06-06 Thread Primoz Fiser
The Prime View International (PVI) is a LCD panel manufacturer. Signed-off-by: Primoz Fiser --- Changes in v2: - fix subject line - sort alphabetically Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/

[PATCH v2 2/3] dt-bindings: display: simple: Add PrimeView PM070WL4 panel

2024-06-06 Thread Primoz Fiser
Add PrimeView PM070WL4 7.0" 800x480 TFT LCD panel compatible string. Signed-off-by: Primoz Fiser --- Changes in v2: - sort alphabetically .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/disp

[PATCH v2 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

2024-06-06 Thread Primoz Fiser
Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel. Datasheet can be found at [1]. [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf Signed-off-by: Primoz Fiser --- Changes in v2: - sort alphabetically drivers/gpu/drm/panel/panel-simple.c | 29 ++

Re: [PATCH] arm/komeda: Compile DEFINE_SHOW_ATTRIBUTE() only when CONFIG_DEBUG_FS is enabled

2024-06-06 Thread Jani Nikula
On Thu, 06 Jun 2024, pengfuyuan wrote: > We do not call komeda_debugfs_init() and the debugfs core function > declaration if CONFIG_DEBUG_FS is not defined, but we should not > compile it either because the debugfs core function declaration is > not included. > > Reported-by: k2ci > Signed-off-by

Re: [PATCH v2] [drm/meson] meson_plane: Add error handling v2(re-aligned)

2024-06-06 Thread neil . armstrong
On 29/11/2023 12:34, Haoran Liu wrote: This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init call. Signed-off-by: Haoran Liu

[PATCH] drm/omap: dss: Support all VOUT ports

2024-06-06 Thread Primoz Fiser
Allow function dss_dpi_select_source_dra7xx() to set the channel in the dra7xx DSS_CONTROL register for any VOUT port, not just VOUT1 (port 0). Signed-off-by: Primoz Fiser --- drivers/gpu/drm/omapdrm/dss/dss.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH v3 6/7] drm/drm_file: add display of driver's internal memory size

2024-06-06 Thread Tvrtko Ursulin
On 06/06/2024 02:49, Adrián Larumbe wrote: Some drivers must allocate a considerable amount of memory for bookkeeping structures and GPU's MCU-kernel shared communication regions. These are often created as a result of the invocation of the driver's ioctl() interface functions, so it is sensib

Re: [PATCH v2 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

2024-06-06 Thread Neil Armstrong
On 06/06/2024 10:01, Primoz Fiser wrote: Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel. Datasheet can be found at [1]. [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf Signed-off-by: Primoz Fiser --- Changes in v2: - sort alphabetically drivers/gpu/drm/

Re: [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-06 Thread Dmitry Baryshkov
On Thu, 6 Jun 2024 at 02:47, Abhinav Kumar wrote: > > > > On 6/5/2024 4:32 PM, Dmitry Baryshkov wrote: > > On Thu, 6 Jun 2024 at 02:19, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > >>> Split dpu_plane_atomic_check() function into two pieces: > >>>

Re: [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-06 Thread Dmitry Baryshkov
On Thu, 6 Jun 2024 at 11:53, Dmitry Baryshkov wrote: > > On Thu, 6 Jun 2024 at 02:47, Abhinav Kumar wrote: > > > > > > > > On 6/5/2024 4:32 PM, Dmitry Baryshkov wrote: > > > On Thu, 6 Jun 2024 at 02:19, Abhinav Kumar > > > wrote: > > >> > > >> > > >> > > >> On 3/13/2024 5:02 PM, Dmitry Baryshko

[PATCH RESEND v5] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2024-06-06 Thread Michael Walle
mtk_find_possible_crtcs() assumes that the main path will always have the CRTC with id 0, the ext id 1 and the third id 2. This is only true if the paths are all available. But paths are optional (see also comment in mtk_drm_kms_init()), e.g. the main path might not be enabled or available at all.

Re: [PATCH v2] [drm/meson] meson_plane: Add error handling v2(re-aligned)

2024-06-06 Thread Neil Armstrong
Hi, On Wed, 29 Nov 2023 03:34:05 -0800, Haoran Liu wrote: > This patch adds robust error handling to the meson_plane_create > function in drivers/gpu/drm/meson/meson_plane.c. The function > previously lacked proper handling for potential failure scenarios > of the drm_universal_plane_init call. >

[PATCH v8 01/16] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung When 9-bit alpha is enabled, its value will be converted from 0-255 to 0-256 (255 = not defined). This is designed for special HDR related calculation, which should be disabled by default, otherwise, alpha blending will not work correctly. Reviewed-by: AngeloGioacchino Del

[PATCH v8 11/16] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode on in OVL. Before this patch, only the "coverage" mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 40 + 1 file changed, 34 insertions(+), 6 deletions(-)

[PATCH v8 03/16] drm/mediatek: Add missing plane settings when async update

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v8 10/16] drm/mediatek: Support "None" blending in Mixer

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/me

[PATCH v8 02/16] drm/mediatek: Add OVL compatible name for MT8195

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH v8 16/16] drm/mediatek: Support CRC in OVL adaptor

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v8 09/16] drm/mediatek: Support "None" blending in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gp

[PATCH v8 12/16] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode in Mixer. Before this patch, only the coverage mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v8 06/16] drm/mediatek: Turn off the layers with zero width or height

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v8 04/16] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH v8 13/16] drm/mediatek: Support alpha blending in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v8 05/16] drm/mediatek: Set DRM mode configs accordingly

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v8 14/16] drm/mediatek: Support CRC in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 280 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 5

[PATCH v8 07/16] drm/mediatek: Support more 10bit formats in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 ++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/dr

[PATCH v8 15/16] drm/mediatek: Support CRC in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v8 08/16] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c in

[PATCH v8 00/16] Support IGT in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Based-on: commit 1613e604df0c ("Linux 6.10-rc1") This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from the hardware compon

Re: [PATCH v2 5/7] drm/msm/adreno: Add A702 support

2024-06-06 Thread Konrad Dybcio
On 23.05.2024 2:14 PM, Connor Abbott wrote: > On Fri, Feb 23, 2024 at 9:28 PM Konrad Dybcio > wrote: >> >> The A702 is a weird mix of 600 and 700 series.. Perhaps even a >> testing ground for some A7xx features with good ol' A6xx silicon. >> It's basically A610 that's been beefed up with some new

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a > number of handheld gaming devices made by Anbernic. By consensus a > vendor prefix is not provided as the panel OEM is unknown. Where has this consensus been found? I

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Neil Armstrong
On 06/06/2024 11:32, Maxime Ripard wrote: On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a number of handheld gaming devices made by Anbernic. By consensus a vendor prefix is not provided as the panel OEM is unknown.

Re: [PATCH] drm/mediatek: Don't print error if EDEFER_PROBE returned on component_add

2024-06-06 Thread AngeloGioacchino Del Regno
Il 05/06/24 18:50, Nícolas F. R. A. Prado ha scritto: Use dev_err_probe() in the component_add() error path to prevent printing an error when the probe is deferred. This was observed on mt8195 with the disp-rdma driver: mediatek-disp-rdma 1c002000.rdma: Failed to add component: -517 But the

[PATCH] drm/amd/display: Fix dml_print_mode_support() for USRRetrainingSupport

2024-06-06 Thread Thorsten Blum
The address of a struct field is usually not NULL, making this test always truthy. Test the boolean value instead. Fixes the following Coccinelle/coccicheck error reported by test_addr.cocci: ERROR: test of a variable/field address Compile-tested only. Signed-off-by: Thorsten Blum ---

[PATCH] drm/amd/display: clean up some inconsistent indenting

2024-06-06 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:529 dcn32_auto_dpm_test_log() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9294 Signed-off-by: Jiapeng Chong --- .../dis

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Ryan Walklin
On Thu, 6 Jun 2024, at 9:32 PM, Maxime Ripard wrote: Hi Maxime, thanks for reviewing. > Where has this consensus been found? As Neil notes Conor suggested it [1], and we did consider Hironori's suggestion [2] of using anbernic as the vendor prefix, although my (not strong) feeling at the time w

Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver

2024-06-06 Thread Cristian Ciocaltea
On 6/5/24 5:48 PM, Heiko Stübner wrote: > Am Samstag, 1. Juni 2024, 15:12:35 CEST schrieb Cristian Ciocaltea: >> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller supports >> the following features, among others: >> >> * Fixed Rate Link (FRL) >> * 4K@120Hz and 8K@60Hz video modes >> *

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-06 Thread Alexander Stein
Hi Marek, Am Mittwoch, 5. Juni 2024, 18:25:13 CEST schrieb Marek Vasut: > On 6/5/24 12:52 PM, Alexander Stein wrote: > > Hi Marek, > > Hi, > > [snip] > > Ah, right. That seems simple. But I noticed another thing: > > The TC9595 PLL is configured to 14733 while the lcdif configures > > the di

Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver

2024-06-06 Thread Heiko Stübner
Am Donnerstag, 6. Juni 2024, 11:53:23 CEST schrieb Cristian Ciocaltea: > On 6/5/24 5:48 PM, Heiko Stübner wrote: > > Am Samstag, 1. Juni 2024, 15:12:35 CEST schrieb Cristian Ciocaltea: > >> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller supports > >> the following features, among ot

[PULL] drm-misc-next

2024-06-06 Thread Maxime Ripard
Hi! Here's this week drm-misc-next PR. It has the fix for the v3d build issue, so it should be safe to merge it, together with last week's PR content. Thanks! Maxime drm-misc-next-2024-06-06: drm-misc-next for 6.10: UAPI Changes: Cross-subsystem Changes: - dma-buf: Warn when reserving 0 fen

[PATCH] drm/msm/a6xx: Fix A702 UBWC mode

2024-06-06 Thread Konrad Dybcio
.min_acc_len = 1; - gpu->ubwc_config.ubwc_mode = 2; + gpu->ubwc_config.ubwc_mode = 0; } } --- base-commit: ee78a17615ad0cfdbbc27182b1047cd36c9d4d5f change-id: 20240606-topic-a702_ubwcmode-dcc5fde0f330 Best regards, -- Konrad Dybcio

Re: [PATCH v5 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-06-06 Thread AngeloGioacchino Del Regno
Il 06/06/24 08:46, Chen-Yu Tsai ha scritto: On Wed, Jun 5, 2024 at 7:15 PM AngeloGioacchino Del Regno wrote: Il 05/06/24 03:38, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Tue, 2024-05-21 at 09:57 +0200, AngeloGioacchino Del Regno wrote: Document OF graph on MMSYS/VDOSYS: this supports up to thr

Re: [PATCH] arm/komeda: Compile DEFINE_SHOW_ATTRIBUTE() only when CONFIG_DEBUG_FS is enabled

2024-06-06 Thread Liviu Dudau
On Thu, Jun 06, 2024 at 11:20:58AM +0300, Jani Nikula wrote: > On Thu, 06 Jun 2024, pengfuyuan wrote: > > We do not call komeda_debugfs_init() and the debugfs core function > > declaration if CONFIG_DEBUG_FS is not defined, but we should not > > compile it either because the debugfs core function

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: > On 06/06/2024 11:32, Maxime Ripard wrote: > > On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a > > > number of handheld gaming devices made by Anbernic.

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2024 at 09:48:54PM GMT, Ryan Walklin wrote: > On Thu, 6 Jun 2024, at 9:32 PM, Maxime Ripard wrote: > Hi Maxime, thanks for reviewing. > > > Where has this consensus been found? > > As Neil notes Conor suggested it [1], and we did consider Hironori's > suggestion [2] of using anber

Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver

2024-06-06 Thread Cristian Ciocaltea
On 6/6/24 1:16 PM, Heiko Stübner wrote: > Am Donnerstag, 6. Juni 2024, 11:53:23 CEST schrieb Cristian Ciocaltea: >> On 6/5/24 5:48 PM, Heiko Stübner wrote: >>> Am Samstag, 1. Juni 2024, 15:12:35 CEST schrieb Cristian Ciocaltea: The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller sup

Re: [PATCH v13 5/9] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-06 Thread Jani Nikula
On Wed, 05 Jun 2024, Mitul Golani wrote: > Add target_rr_divider to structure representing AS SDP. > It is valid only in FAVT mode, sink device ignores the bit in AVT > mode. > > --v2: > - Update commit header and send patch to dri-devel. > > Signed-off-by: Mitul Golani > Reviewed-by: Arun R Murt

Re: [PATCH v12 12/13] media: imagination: Round to closest multiple for cropping region

2024-06-06 Thread Sebastian Fricke
Hey, On 04.06.2024 16:23, Devarsh Thakkar wrote: If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives

[PATCH] drivers/base/devres.c: refactor using guards

2024-06-06 Thread Andrea Calabrese
Refactored devres.c using lock guards and scoped locks. Changed functions: - devres_for_each_res - devres_add - devres_find - devres_get - devres_remove - release_nodes - release_all - devres_open_group - find_group - devres_remove_group - devres_release_group - devm_krealloc Signed-off-by: Andrea

[PATCH] drm/hisilicon: Fix a NULL pointer access when call hibmc_unload

2024-06-06 Thread oushixiong1025
From: Shixiong Ou If Calling hibmc_mm_init() failed in hibmc_load(), the hibmc_unload() will access a NULL pointer, as it don't call ww_mutex_init() to initialize mode_config.connection_mutex but try to lock it when calling drm_atomic_helper_shutdown() in hibmc_unload(). [ 50.939211][ 0] Unab

Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver

2024-06-06 Thread Luis de Arquer
On 6/5/24 16:48, Heiko Stübner wrote: Without this change, connecting to a DVI display does not work, and reading the EDID ends in the "i2c read error" below. I had a lot of problems initially with the vendor driver on my DVI display, and am aware that several changes were required. However,

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-06 Thread AngeloGioacchino Del Regno
Il 02/06/24 17:57, Andy Shevchenko ha scritto: Make two APIs look similar. Hence convert match_string() to be a 2-argument macro. In order to avoid unneeded churn, convert all users as well. There is no functional change intended. Signed-off-by: Andy Shevchenko For MediaTek Reviewed-by: Ange

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-06 Thread Gautham R. Shenoy
On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. > diff --git a/drivers/cpufreq/amd-pstate.

[PATCH] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-06 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When LPI2C send data, it is tx cmd register and tx data fifo. When LPI2C receive data, it is just a rx cmd register. LPI2C

Re: [PATCH 12/14] dt-bindings: display: rockchip,dw-hdmi: Add compatible for RK3588

2024-06-06 Thread Cristian Ciocaltea
On 6/6/24 2:22 AM, Rob Herring wrote: > On Sat, Jun 01, 2024 at 04:12:34PM +0300, Cristian Ciocaltea wrote: >> Document the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller >> found on Rockchip RK3588 SoC family. >> >> Since RK3588 uses different clocks than previous Rockchip SoCs and als

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Conor Dooley
On Thu, Jun 06, 2024 at 01:23:03PM +0200, Maxime Ripard wrote: > On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: > > On 06/06/2024 11:32, Maxime Ripard wrote: > > > On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > > > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD disp

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-06 Thread Konrad Dybcio
On 4.06.2024 4:40 PM, Will Deacon wrote: > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: >> On Thu, May 16, 2024 at 08:20:05PM GMT, Akhil P Oommen wrote: >>> On Thu, May 16, 2024 at 08:15:34AM -0500, Andrew Halaney wrote: If I understand correctly, you don't need any memory b

[PATCH] arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations

2024-06-06 Thread pengfuyuan
Since the debugfs functions have no-op stubs for CONFIG_DEBUG_FS=n, the compiler will optimize the rest away since they are no longer referenced. The benefit of removing the conditional compilation is that the build is actually tested for both CONFIG_DEBUG_FS configuration values. Assuming most de

Re: [PATCH v2 10/12] media: platform: mtk-mdp3: Get fine-grain control of cmdq_pkt_finalize()

2024-06-06 Thread Benjamin Gaignard
Le 22/02/2024 à 16:41, Chun-Kuang Hu a écrit : In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 3 ++- drivers/media/platform/mediatek/md

Re: [PATCH v13 5/9] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2024 at 02:38:45PM GMT, Jani Nikula wrote: > On Wed, 05 Jun 2024, Mitul Golani > wrote: > > Add target_rr_divider to structure representing AS SDP. > > It is valid only in FAVT mode, sink device ignores the bit in AVT > > mode. > > > > --v2: > > - Update commit header and send pat

[Bug 218900] amdgpu: Fatal error during GPU init

2024-06-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218900 Hanabishi (i.r.e.c.c.a.k.u.n+bugzilla.kernel@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-06-06 Thread Ville Syrjälä
On Thu, Jun 06, 2024 at 10:21:07AM +0300, Jani Nikula wrote: > On Wed, 05 Jun 2024, Chris Bainbridge wrote: > > On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: > >> Hi Mario, > >> > >> kernel test robot noticed the following build errors: > >> > >> [auto build test ERROR on dr

[PATCH] drm/edid: reduce DisplayID log spamming

2024-06-06 Thread Jani Nikula
Debug printing at DisplayID validation leads to lots of log spamming as it's called at DisplayID iterators during EDID parsing. Remove it, and replace with a less noisy message at connector EDID update. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 3 --- drivers/gpu/drm/drm_e

Re: [PATCH] arm/komeda: Remove all CONFIG_DEBUG_FS conditional compilations

2024-06-06 Thread Liviu Dudau
On Thu, Jun 06, 2024 at 08:08:42PM +0800, pengfuyuan wrote: > Since the debugfs functions have no-op stubs for CONFIG_DEBUG_FS=n, > the compiler will optimize the rest away since they are no longer referenced. > > The benefit of removing the conditional compilation is that the build > is actually

Re: [PATCH] drm/mediatek: Don't print error if EDEFER_PROBE returned on component_add

2024-06-06 Thread Jonathan Cameron
On Wed, 05 Jun 2024 12:50:25 -0400 Nícolas F. R. A. Prado wrote: > Use dev_err_probe() in the component_add() error path to prevent > printing an error when the probe is deferred. This was observed on > mt8195 with the disp-rdma driver: > > mediatek-disp-rdma 1c002000.rdma: Failed to add compo

[PATCH v3 1/4] drm/sched: store the drm_device instead of the device

2024-06-06 Thread Pierre-Eric Pelloux-Prayer
When tracing is enabled, being able to identify which device is sending events is useful; for this the next commit will extend events to include drm_device::primary::index. Since the device member is only used in the drm_* log macros, we can replace it by a drm_device pointer. Signed-off-by: Pier

[PATCH v3 2/4] drm/sched: add dev_index=xx to the drm_sched_process_job event

2024-06-06 Thread Pierre-Eric Pelloux-Prayer
Until the switch from kthread to workqueue, a userspace application could determine the device index from the pid of the thread sending this event. With workqueues this is not possible anymore, so the event needs to contain this information (the ring name alone is not enough, because they're not u

[PATCH v3 3/4] drm/sched: cleanup gpu_scheduler trace events

2024-06-06 Thread Pierre-Eric Pelloux-Prayer
Print identifiers instead of pointers: * "fence=%p" is replaced by "fence=(context:%llu, seqno:%lld)" to have a coherent way to print the fence. A possible follow up change would be to use the same format in traces/../dma-fence.h. * "entity=%p" is removed because the fence's context is already an i

[PATCH v3 0/4] Improve gpu_scheduler trace events

2024-06-06 Thread Pierre-Eric Pelloux-Prayer
Hi, This is the new version of my patch series aiming at improving the trace events around gpu jobs. The main ideas implemented are: trace dependencies between jobs and identify the GPU running jobs (because 'ring' is not a unique attribute). Changes from v2: * dropped all amdgpu changes. The goa

[PATCH v3 4/4] drm/sched: trace dependencies for gpu jobs

2024-06-06 Thread Pierre-Eric Pelloux-Prayer
Trace the fence dependencies similarly to how we print fences: ... , dependencies:{(context:606, seqno:38006)} This allows tools to analyze the dependencies between the jobs (previously it was only possible for fences traced by drm_sched_job_wait_dep). Since drm_sched_job and drm_run_job use th

[PATCH] backlight: lm3509_bl: Fix NULL vs IS_ERR() check in register() function

2024-06-06 Thread Dan Carpenter
The devm_backlight_device_register() doesn't return NULL, it returns error pointers. Update the error checking to match. Fixes: b72755f5b577 ("backlight: Add new lm3509 backlight driver") Signed-off-by: Dan Carpenter --- drivers/video/backlight/lm3509_bl.c | 5 +++-- 1 file changed, 3 insertion

Re: [PATCH v3 1/4] drm/sched: store the drm_device instead of the device

2024-06-06 Thread Christian König
Am 06.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer: When tracing is enabled, being able to identify which device is sending events is useful; for this the next commit will extend events to include drm_device::primary::index. That sounds like a rather bad idea since the primary index is rea

Re: [PATCH v3 3/4] drm/sched: cleanup gpu_scheduler trace events

2024-06-06 Thread Steven Rostedt
On Thu, 6 Jun 2024 15:06:24 +0200 Pierre-Eric Pelloux-Prayer wrote: > Print identifiers instead of pointers: > * "fence=%p" is replaced by "fence=(context:%llu, seqno:%lld)" to have a > coherent way to print the fence. A possible follow up change would be > to use the same format in traces/../dma

Re: [PATCH v3 3/4] drm/sched: cleanup gpu_scheduler trace events

2024-06-06 Thread Christian König
Am 06.06.24 um 15:19 schrieb Steven Rostedt: On Thu, 6 Jun 2024 15:06:24 +0200 Pierre-Eric Pelloux-Prayer wrote: Print identifiers instead of pointers: * "fence=%p" is replaced by "fence=(context:%llu, seqno:%lld)" to have a coherent way to print the fence. A possible follow up change would be

Re: [PATCH v3 1/4] drm/sched: store the drm_device instead of the device

2024-06-06 Thread Ville Syrjälä
On Thu, Jun 06, 2024 at 03:18:14PM +0200, Christian König wrote: > Am 06.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer: > > When tracing is enabled, being able to identify which device is sending > > events is useful; for this the next commit will extend events to include > > drm_device::primar

Re: [PATCH v12 12/13] media: imagination: Round to closest multiple for cropping region

2024-06-06 Thread Devarsh Thakkar
Hi Sebastian Thanks for the update. On 06/06/24 17:14, Sebastian Fricke wrote: > Hey, > > On 04.06.2024 16:23, Devarsh Thakkar wrote: >> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up >> (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest >> multiple of reque

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Neil Armstrong
On 06/06/2024 13:23, Maxime Ripard wrote: On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: On 06/06/2024 11:32, Maxime Ripard wrote: On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a number of handheld gam

Re: [PATCH v12 12/13] media: imagination: Round to closest multiple for cropping region

2024-06-06 Thread Andy Shevchenko
On Thu, Jun 06, 2024 at 01:44:59PM +0200, Sebastian Fricke wrote: > Hey, > > On 04.06.2024 16:23, Devarsh Thakkar wrote: > > If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up > > (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest > > multiple of requested value

[PATCH 6.1 219/473] fbdev: sh7760fb: allow modular build

2024-06-06 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit 51084f89d687e14d96278241e5200cde4b0985c7 ] There is no reason to prohibit sh7760fb from being built as a loadable module as suggested by Geert, so change the conf

[PATCH 6.6 314/744] fbdev: sh7760fb: allow modular build

2024-06-06 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit 51084f89d687e14d96278241e5200cde4b0985c7 ] There is no reason to prohibit sh7760fb from being built as a loadable module as suggested by Geert, so change the conf

Re: [PATCH v3 1/6] drm/ci: uprev mesa version

2024-06-06 Thread Helen Koike
On 28/05/2024 23:40, Vignesh Raman wrote: zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest

Re: [PATCH v3 2/6] drm/ci: add farm variable

2024-06-06 Thread Helen Koike
On 28/05/2024 23:40, Vignesh Raman wrote: Mesa uses structured logs for logging and debug purpose, https://mesa.pages.freedesktop.org/-/mesa/-/jobs/59165650/artifacts/results/job_detail.json Since drm-ci uses the mesa scripts, add the farm variable and update the device type for missing jobs.

Re: [PATCH v3 4/6] drm/ci: uprev IGT

2024-06-06 Thread Helen Koike
On 28/05/2024 23:40, Vignesh Raman wrote: test-list.txt and test-list-full.txt are not generated for cross-builds and they are required by drm-ci for testing arm32 targets. This is fixed in igt-gpu-tools. So uprev IGT to include the commit which fixes this issue. Also disable building xe drive

Re: [PATCH v3 5/6] drm/ci: skip driver specific tests

2024-06-06 Thread Helen Koike
On 28/05/2024 23:40, Vignesh Raman wrote: Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman Acked-by: Helen Koike --- v2: - Skip xe tests for amdgpu and virtio. v3: - No ch

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-06-06 Thread Helen Koike
On 29/05/2024 06:49, Vignesh Raman wrote: Hi Dmitry, On 29/05/24 13:30, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 08:10:49AM +0530, Vignesh Raman wrote: Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since so

[syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask

2024-06-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0e1980c40b6e Add linux-next specific files for 20240531 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=166086f298 kernel config: https://syzkaller.appspot.com/x/.config?x=d9c3ca4e54577b88 dashbo

Re: [PATCH v3 0/6] drm/ci: uprev mesa/IGT and generate testlist

2024-06-06 Thread Helen Koike
On 28/05/2024 23:40, Vignesh Raman wrote: Uprev mesa and IGT to the latest version and stop vendoring the testlist into the kernel. Instead, use the testlist from the IGT build to ensure we do not miss renamed or newly added tests. Update the xfails with the latest testlist run. Add farm vari

Re: [syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask

2024-06-06 Thread Mario Limonciello
On 6/6/2024 09:39, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:0e1980c40b6e Add linux-next specific files for 20240531 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=166086f298 kernel config: https://syzkaller.appspot.com/

Re: [PATCH 12/14] dt-bindings: display: rockchip,dw-hdmi: Add compatible for RK3588

2024-06-06 Thread Rob Herring
On Thu, Jun 6, 2024 at 5:51 AM Cristian Ciocaltea wrote: > > On 6/6/24 2:22 AM, Rob Herring wrote: > > On Sat, Jun 01, 2024 at 04:12:34PM +0300, Cristian Ciocaltea wrote: > >> Document the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller > >> found on Rockchip RK3588 SoC family. > >> > >

Re: [RFC PATCH 6/8] rust: drm: gem: Add GEM object abstraction

2024-06-06 Thread Daniel Almeida
Hi Danilo, Lina > On 20 May 2024, at 14:24, Danilo Krummrich wrote: > > From: Asahi Lina > > The DRM GEM subsystem is the DRM memory management subsystem used by > most modern drivers. Add a Rust abstraction to allow Rust DRM driver > implementations to use it. > > Signed-off-by: Asahi Lina

Re: [PATCH v4] drm/msm/a6xx: use __unused__ to fix compiler warnings for gen7_* includes

2024-06-06 Thread Dmitry Baryshkov
On Wed, Jun 05, 2024 at 11:34:15AM -0700, Abhinav Kumar wrote: > GCC diagnostic pragma method throws below warnings in some of the versions > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:16:9: warning: unknown > option after '#pragma GCC diagnostic' kind [-Wpragmas] > #pragma GCC diagnostic ign

Re: [PATCH] drm/msm/a6xx: Fix A702 UBWC mode

2024-06-06 Thread Dmitry Baryshkov
On Thu, Jun 06, 2024 at 01:10:49PM +0200, Konrad Dybcio wrote: > UBWC_MODE is a one-bit-wide field, so a value of 2 is obviously bogus. > > Replace it with the correct value (0). > > Fixes: 18397519cb62 ("drm/msm/adreno: Add A702 support") > Reported-by: Connor Abbott > Closes: > https://lore.k

  1   2   >