Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Thomas Hellström
Hi On Mon, 2024-06-03 at 08:55 +0200, Karolina Stolarek wrote: > Hi Thomas, > > On 29.05.2024 14:58, Thomas Hellström wrote: > > On Wed, 2024-05-15 at 13:24 +0200, Karolina Stolarek wrote: > > > Add mock resource manager to test ttm_bo_validate() with non- > > > system > > > placements. Update KC

Re: [PATCH] kernel/resource: optimize find_next_iomem_res

2024-06-03 Thread Ilpo Järvinen
On Sun, 2 Jun 2024, Andy Shevchenko wrote: > On Fri, May 31, 2024 at 02:31:45PM -0700, Chia-I Wu wrote: > > On Fri, May 31, 2024 at 1:57 AM Andy Shevchenko < > > andriy.shevche...@linux.intel.com> wrote: > > > On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote: > > ... > > > > P.S> I'm no

Re: [PATCH] kernel/resource: optimize find_next_iomem_res

2024-06-03 Thread Ilpo Järvinen
On Fri, 31 May 2024, Chia-I Wu wrote: > On Fri, May 31, 2024 at 1:57 AM Andy Shevchenko > > wrote: > On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote: > > We can skip children resources when the parent resource does not cover > > the range. > > > > This shou

Re: [PATCH v4 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-06-03 Thread Michael Walle
Hi Angelo, > >> Implement OF graphs support to the mediatek-drm drivers, allowing to > >> stop hardcoding the paths, and preventing this driver to get a huge > >> amount of arrays for each board and SoC combination, also paving the > >> way to share the same mtk_mmsys_driver_data between multiple

Re: [PATCH 4/6] drm/imagination: Add compatible string entry for Series6XT

2024-06-03 Thread Steven Price
On 03/06/2024 04:29, Chen-Yu Tsai wrote: > On Fri, May 31, 2024 at 7:18 PM Frank Binns wrote: >> >> On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: >>> The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part >>> of the Series6XT, another variation of the Rogue family of GPUs. >

Re: [PATCH v4 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-03 Thread Maxime Ripard
On Fri, 31 May 2024 23:07:28 +0300, Dmitry Baryshkov wrote: > The mode_set callback is deprecated, it doesn't get the > drm_bridge_state, just mode-related argumetns. Turn it into the > atomic_enable callback as suggested by the documentation. > > Signed-off-by: Dmitry Baryshkov > > [ ... ] Ack

Re: [PATCH v4 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-06-03 Thread Maxime Ripard
On Fri, 31 May 2024 23:07:30 +0300, Dmitry Baryshkov wrote: > Use connector->display_info.is_hdmi instead of manually using > drm_detect_hdmi_monitor(). > > Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to nvkm_i2c_aux.c and nvkm_i2c_aux.h

2024-06-03 Thread Karol Herbst
On Sun, Jun 2, 2024 at 1:01 AM Szőke Benjamin wrote: > > s=20181004; d=freemail.hu; > > h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding; > l=8472; bh=iw0a2TUtlt0KIetu+spJR9WLW1F3MPSfBbxxiBBkhDM=; > b=1

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 driver for the video interface present on the Google > Chameleon v3. The Chameleon v3 uses the video interface to capture > a single video source from a given HDMI or DP connector and write > the resulting frames to memory. > > Signed-off-by: Pa

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Karolina Stolarek
diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 2f590bae53f8..2a2585b37118 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -27,8 +27,42 @@ static int mock_move(struct

Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. > It is a part of the DisplayPort Intel FPGA IP Core, and supports > DisplayPort 1.4, HBR3 video capture and Multi-Stream Transport. > > Signed-off-by: Paweł Anikiel > --- > drivers/med

Re: [PATCH v3 2/2] drm: panel: nv3052c: Add WL-355608-A8 panel

2024-06-03 Thread Neil Armstrong
On 30/05/2024 23:12, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Limited information is available online however the panel timing values (below) have been obtained from the vendor BSP

Re: [PATCH v3 00/10] Add Chameleon v3 video support

2024-06-03 Thread Hans Verkuil
Hi Paweł, On 07/05/2024 17:54, Paweł Anikiel wrote: > Google Chameleon v3 is a testing device capable of emulating multiple > DisplayPort monitors, used for testing purposes. It is based on an Arria > 10 SoCFPGA. This patchset adds V4L2 drivers for two IP blocks used in the > device's FPGA: the

Re: [PATCH] MAINTAINERS: drm: Drop sam as panel reviewer

2024-06-03 Thread Neil Armstrong
Hi, On Thu, 30 May 2024 23:14:02 +0200, Sam Ravnborg wrote: > Drop myself as reviewer of panel patches, to reflect the reality. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] MAINTAINERS: drm: Drop sam as panel reviewer https://gitlab.fr

Re: [PATCH v3 0/2] Add WL-355608-A8 panel

2024-06-03 Thread Neil Armstrong
Hi, On Fri, 31 May 2024 09:12:12 +1200, Ryan Walklin wrote: > V3 of this patch with further cleanup to DT binding example code and > whitespace fixes in driver code. No functional change from V2. > > Original cover below. > -- > > The WL_355608_A8 panel is a VGA LCD display with an NV3052C-comp

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Neil Armstrong
Hi Christian, On 01/06/2024 15:12, Cristian Ciocaltea wrote: The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the Synopsys DesignWare HDMI TX controller used in the previous SoCs. It is HDMI 2.1 compliant and supports the following features, among others: . .. * SCDC I2C DDC a

Re: [PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-06-03 Thread Maxime Ripard
Hi, Sorry for not answering your mail on the previous version sooner. On Fri, May 31, 2024 at 11:07:24PM GMT, Dmitry Baryshkov wrote: > Allow passing NULL as audio infoframe as a way to disable Audio > Infoframe generation. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/dr

Re: [PATCH v4 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-06-03 Thread Maxime Ripard
Hi, On Fri, May 31, 2024 at 11:07:26PM GMT, Dmitry Baryshkov wrote: > +static int drm_bridge_connector_clear_infoframe(struct drm_connector > *connector, > + enum hdmi_infoframe_type type) > +{ > + struct drm_bridge_connector *bridge_connector = > +

[PATCH] drm/nouveau/i2c: rename aux.c and aux.h to auxch.c and auxch.h

2024-06-03 Thread egyszeregy
From: Benjamin Szőke The goal is to clean-up Linux repository from AUX file names, because the use of such file names is prohibited on other operating systems such as Windows, so the Linux repository cannot be cloned and edited on them. Signed-off-by: Benjamin Szőke --- drivers/gpu/drm/nouveau

Re: [PATCH v4 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-06-03 Thread Maxime Ripard
On Fri, 31 May 2024 23:07:29 +0300, Dmitry Baryshkov wrote: > Setup the HDMI connector on the MSM HDMI outputs. Make use of > atomic_check hook and of the provided Infoframe infrastructure. > > Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-06-03 Thread Maxime Ripard
Hi Jani, On Fri, May 31, 2024 at 09:43:16PM GMT, Jani Nikula wrote: > On Mon, 27 May 2024, Maxime Ripard wrote: > > Let me know what you think, > > Sorry to report that this series generates a bunch of kernel-doc > warnings in include/drm/drm_connector.h. Documenting nested struct > members does

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-06-03 Thread Jani Nikula
On Mon, 03 Jun 2024, Maxime Ripard wrote: > Hi Jani, > > On Fri, May 31, 2024 at 09:43:16PM GMT, Jani Nikula wrote: >> On Mon, 27 May 2024, Maxime Ripard wrote: >> > Let me know what you think, >> >> Sorry to report that this series generates a bunch of kernel-doc >> warnings in include/drm/drm_

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Thomas Hellström
On Mon, 2024-06-03 at 10:28 +0200, Karolina Stolarek wrote: > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > index 2f590bae53f8..2a2585b37118 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Karolina Stolarek
On 3.06.2024 11:30, Thomas Hellström wrote: On Mon, 2024-06-03 at 10:28 +0200, Karolina Stolarek wrote: diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 2f590bae53f8..2a2585b37118 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_hel

[PATCH v2 2/3] drm/panic: Add a set_pixel() callback to drm_scanout_buffer

2024-06-03 Thread Jocelyn Falempe
This allows drivers to draw the pixel, and handle tiling, or specific color formats. v2: * Use fg_color for blit() functions (Javier Martinez Canillas) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 120 +++- include/drm/drm_panic.h | 9 +

[PATCH v2 0/3] drm/panic: Add a kmsg dump screen

2024-06-03 Thread Jocelyn Falempe
Add a kmsg option, which will display the last lines of kmsg, and should be similar to fbcon. Add a drm.panic_screen module parameter, so you can choose between the different panic screens available. Two options currently, but more will be added later: * "user": a short message telling the user to

[PATCH v2 3/3] drm/panic: Add a kmsg panic screen

2024-06-03 Thread Jocelyn Falempe
Add a kmsg option, which will display the last lines of kmsg, and should be similar to fbcon. Add a drm.panic_screen module parameter, so you can choose between the different panic screens available. two options currently, but more will be added later: * "user": a short message telling the user to

[PATCH v2 1/3] drm/panic: only draw the foreground color in drm_panic_blit()

2024-06-03 Thread Jocelyn Falempe
The whole framebuffer is cleared, so it's useless to rewrite the background colored pixels. It allows to simplify the drawing functions, and prepare the work for the set_pixel() callback. v2: * keep fg16/fg24/fg32 as variable name for the blit function. * add drm_panic_is_pixel_fg() to avoid cod

Re: [PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 11:09:40AM +0200, Maxime Ripard wrote: > Hi, > > Sorry for not answering your mail on the previous version sooner. > > On Fri, May 31, 2024 at 11:07:24PM GMT, Dmitry Baryshkov wrote: > > Allow passing NULL as audio infoframe as a way to disable Audio > > Infoframe generati

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-03 Thread Dmitry Baryshkov
On Sun, Jun 02, 2024 at 08:25:39PM -0700, Chris Healy wrote: > On an i.MX53 QSB with HDMI daughter board, this patch series is: > > Tested-by: Chris Healy Thank you! I assume this is imx53-qsrb-hdmi ? > > HDMI output still works correctly and the bridges file reflects the changes: > > Before:

[PATCH v3 5/5] drm/tiny: panel-mipi-dbi: Support the pixel format property

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes Add support for these pixel format property values: - r5g6b5, RGB565 - b6x2g6x2r6x2, BGR666 BGR666 is presented to userspace as RGB888. The 2 LSB in each color are discarded by the controller. The pixel is sent on the wire using 8 bits per word (little endian) so the control

[PATCH v3 0/5] drm/tiny: panel-mipi-dbi: Support 18 bits per color RGB666

2024-06-03 Thread Noralf Trønnes via B4 Relay
Hi, The binding and driver patches have been reviewed and I appreciate if someone can take a look at the drm_mipi_dbi patches. The first patch removes some erroneous big endian code and the 2 other makes it possible to configure bits per word for the SPI pixel transfer. It's currently hardcoded fo

[PATCH v3 2/5] drm/mipi-dbi: Remove mipi_dbi_machine_little_endian()

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes mipi_dbi_machine_little_endian() should really have been called mipi_dbi_framebuffer_little_endian() because that's the function it performs. When I added support for these SPI displays I thought that the framebuffers on big endian machines were also big endian, but I have la

[PATCH v3 1/5] dt-bindings: display: panel: mipi-dbi-spi: Add a pixel format property

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes The MIPI DBI 2.0 specification (2005) lists only two pixel formats for the Type C Interface (SPI) and that is 3-bits/pixel RGB111 with 2 options for bit layout. For Type A and B (parallel) the following formats are listed: RGB332, RGB444, RGB565, RGB666 and RGB888 (some have

[PATCH v3 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes DRM_FORMAT_RGB888 is 24 bits per pixel and it would be natural to send it on the SPI bus using a 24 bits per word transfer. The problem with this is that not all SPI controllers support 24 bpw. Since DRM_FORMAT_RGB888 is stored in memory as little endian and the SPI bus is b

[PATCH v3 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes This prepares for supporting other pixel formats than RGB565. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 14 ++ include/drm/drm_mipi_dbi.h | 5 + 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/dr

Re: [PATCH 00/20] drm/bridge: tc358775: proper bridge bringup and code cleanup

2024-06-03 Thread Michael Walle
On Mon May 6, 2024 at 3:34 PM CEST, Michael Walle wrote: > This patchset fixes the bridge initialization according to the > datasheet. Not sure how that even worked before. Maybe because the > initialization was done prior to linux (?). > > The bridge has some peculiarities: > (1) The reset has to

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-03 Thread Alexander Stein
Hi Marek, Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut: > This line_pixel_subtract is no longer needed now that the bridge can > request and obtain specific pixel clock on input to the bridge, with > clock frequency that matches the Pixel PLL frequency. > > The line_pixel_subtract

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Andy Yan
Hi Neil: On 6/3/24 16:55, Neil Armstrong wrote: Hi Christian, On 01/06/2024 15:12, Cristian Ciocaltea wrote: The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the Synopsys DesignWare HDMI TX controller used in the previous SoCs. It is HDMI 2.1 compliant and supports the following

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-03 Thread Alexander Stein
Hi Marek, Am Freitag, 31. Mai 2024, 22:39:48 CEST schrieb Marek Vasut: > Use tc_pxl_pll_calc() to find out the exact clock frequency generated by the > Pixel PLL. Use the Pixel PLL frequency as adjusted_mode clock frequency and > pass it down the display pipeline to obtain exactly this frequency o

Re: [PATCH v11 6/8] drm/i915/display: Compute Adaptive sync SDP params

2024-06-03 Thread Nautiyal, Ankit K
On 6/3/2024 11:19 AM, Mitul Golani wrote: Compute params for Adaptive Sync SDP when Fixed Average Vtotal mode is enabled. --v2: Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit). --v3: - Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit). - check cmr

Re: [PATCH net-next v10 01/14] netdev: add netdev_rx_queue_restart()

2024-06-03 Thread Pavel Begunkov
On 5/30/24 21:16, Mina Almasry wrote: Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry --- ... diff --git a/net/core/netdev_rx_queue.c b/net/core/netdev_rx_queue.c new file mode 100644 index 0..b3899358e5a9c --- /de

Re: [PATCH] drm/vmwgfx: Don't destroy Screen Target when CRTC is enabled but inactive

2024-06-03 Thread Martin Krastev
On Fri, May 31, 2024 at 11:34 PM Ian Forbes wrote: > > drm_crtc_helper_funcs::atomic_disable can be called even when the CRTC is > still enabled. This can occur when the mode changes or the CRTC is set as > inactive. > > In the case where the CRTC is being set as inactive we only want to > blank t

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Heiko Stuebner
Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan: > Hi Neil: > > On 6/3/24 16:55, Neil Armstrong wrote: > > Hi Christian, > > > > On 01/06/2024 15:12, Cristian Ciocaltea wrote: > >> The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > >> Synopsys DesignWare HDMI TX controlle

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread neil . armstrong
Hi, On 03/06/2024 15:03, Heiko Stuebner wrote: Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan: Hi Neil: On 6/3/24 16:55, Neil Armstrong wrote: Hi Christian, On 01/06/2024 15:12, Cristian Ciocaltea wrote: The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the Synopsys Des

Re: [PATCH 00/20] iommu: Refactoring domain allocation interface

2024-06-03 Thread Jason Gunthorpe
On Wed, May 29, 2024 at 08:02:12PM +0800, Baolu Lu wrote: > > > drivers/infiniband/hw/usnic/usnic_uiom.c:   pd->domain = domain > > > = iommu_domain_alloc(dev->bus); > > > > > > This series leave those cases unchanged and keep iommu_domain_alloc() > > > for their usage. But new drivers should

[PATCH v13 00/12] Improve test coverage of TTM

2024-06-03 Thread Karolina Stolarek
Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare KUnit helpers to handle such scenarios and add a mock VRAM manager. This series a

[PATCH v13 01/12] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

2024-06-03 Thread Karolina Stolarek
BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Update ttm_bo_kunit_init() helper to accept dma_resv object so we can define buffer objects that share the same resv. Update calls to that helper accordingly. Fixes: 995279d280d

[PATCH v13 02/12] drm/ttm/tests: Delete unnecessary config option

2024-06-03 Thread Karolina Stolarek
DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/

[PATCH v13 03/12] drm/ttm/tests: Set DMA mask in KUnit device

2024-06-03 Thread Karolina Stolarek
In commit d393acce7b3f ("drm/tests: Switch to kunit devices"), DRM test helpers migrated away from using a dummy platform driver in favour of KUnit device. This means that DMA masks for the device are not set but are required by ttm_pool_alloc tests. Set the DMA mask for coherent mappings to unblo

[PATCH v13 04/12] drm/ttm/tests: Use an init function from the helpers lib

2024-06-03 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers

[PATCH v13 05/12] drm/ttm/tests: Test simple BO creation and validation

2024-06-03 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v13 06/12] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath --- drive

[PATCH v13 07/12] drm/ttm/tests: Add test cases dependent on fence signaling

2024-06-03 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .../gpu/drm/tt

[PATCH v13 08/12] drm/ttm/tests: Add eviction testing

2024-06-03 Thread Karolina Stolarek
Add tests for ttm_bo_validate that focus on BO eviction and swapout. Update device funcs definition with eviction-related callbacks. Add alternative funcs where evict_flags() routes eviction to a domain that can't allocate resources (dubbed "busy manager" in the tests). Extract the common path of t

[PATCH v13 09/12] drm/ttm/tests: Add tests for ttm_tt_populate

2024-06-03 Thread Karolina Stolarek
Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- drivers/gpu/

[PATCH v13 11/12] drm/ttm/tests: Correct modules' licenses

2024-06-03 Thread Karolina Stolarek
The test files are GPL and MIT, so update the definitions accordingly. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 +- drivers/gpu/drm/ttm/tests/

[PATCH v13 10/12] drm/ttm/tests: Add TODO file

2024-06-03 Thread Karolina Stolarek
List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/TODO | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu

[PATCH v13 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

2024-06-03 Thread Karolina Stolarek
Update the tests and helpers to use unsigned kernel types. Signed-off-by: Karolina Stolarek Suggested-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 12 ++-- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 6 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.

Re: [PATCH 01/20] drm/bridge: add dsi_lp11_notify mechanism

2024-06-03 Thread Michael Walle
[+ Marek ] Hi Dmitry, > > > Some bridges have very strict power-up reqirements. In this case, the > > > Toshiba TC358775. The reset has to be deasserted while *both* the DSI > > > clock and DSI data lanes are in LP-11 mode. After the reset is relased, > > > the bridge needs the DSI clock to actua

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Mina Almasry
On Fri, May 31, 2024 at 10:35 PM Christoph Hellwig wrote: > > On Thu, May 30, 2024 at 08:16:01PM +, Mina Almasry wrote: > > I'm unsure if the discussion has been resolved yet. Sending the series > > anyway to get reviews/feedback on the (unrelated) rest of the series. > > As far as I'm concern

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Paweł Anikiel
On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: > > On 07/05/2024 17:54, Paweł Anikiel wrote: > > Add v4l2 driver for the video interface present on the Google > > Chameleon v3. The Chameleon v3 uses the video interface to capture > > a single video source from a given HDMI or DP connector and

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-03 Thread Chris Healy
On Mon, Jun 3, 2024 at 3:12 AM Dmitry Baryshkov wrote: > > On Sun, Jun 02, 2024 at 08:25:39PM -0700, Chris Healy wrote: > > On an i.MX53 QSB with HDMI daughter board, this patch series is: > > > > Tested-by: Chris Healy > > Thank you! I assume this is imx53-qsrb-hdmi ? Yes > > > > > HDMI output

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Pavel Begunkov
On 6/3/24 15:17, Mina Almasry wrote: On Fri, May 31, 2024 at 10:35 PM Christoph Hellwig wrote: On Thu, May 30, 2024 at 08:16:01PM +, Mina Almasry wrote: I'm unsure if the discussion has been resolved yet. Sending the series anyway to get reviews/feedback on the (unrelated) rest of the ser

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 03/06/2024 16:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 driver for the video interface present on the Google >>> Chameleon v3. The Chameleon v3 uses the video interface to capture >>> a single video

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Mina Almasry
On Mon, Jun 3, 2024 at 7:52 AM Pavel Begunkov wrote: > > On 6/3/24 15:17, Mina Almasry wrote: > > On Fri, May 31, 2024 at 10:35 PM Christoph Hellwig > > wrote: > >> > >> On Thu, May 30, 2024 at 08:16:01PM +, Mina Almasry wrote: > >>> I'm unsure if the discussion has been resolved yet. Sendin

Re: [DO NOT MERGE v8 19/36] dt-bindings: interrupt-controller: renesas,sh7751-irl-ext: Add json-schema

2024-06-03 Thread Rob Herring
On Wed, May 29, 2024 at 05:01:05PM +0900, Yoshinori Sato wrote: > Renesas SH7751 external interrupt encoder json-schema. > > Signed-off-by: Yoshinori Sato > --- > .../renesas,sh7751-irl-ext.yaml | 57 +++ > 1 file changed, 57 insertions(+) > create mode 100644 > D

Re: [DO NOT MERGE v8 21/36] dt-bindings: serial: renesas,scif: Add scif-sh7751.

2024-06-03 Thread Rob Herring (Arm)
On Wed, 29 May 2024 17:01:07 +0900, Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato > Reviewed-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)

Re: [RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread John Stultz
On Mon, Jun 3, 2024 at 4:40 AM wrote: > > From: "Hailong.Liu" > > This help module use heap_flags to determine the type of dma-buf, > so that some mechanisms can be used to speed up allocation, such as > memory_pool, to optimize the allocation time of dma-buf. This feels like it's trying to intr

[PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-03 Thread Niemiec, Krzysztof
The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does not provide valuable information, because it does not indicate that there is something necessarily wrong with either the driver or the hardware. Remove the test to prevent random, unnec

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Maxime Ripard
On Mon, Jun 03, 2024 at 03:03:12PM GMT, Heiko Stuebner wrote: > Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan: > > Hi Neil: > > > > On 6/3/24 16:55, Neil Armstrong wrote: > > > Hi Christian, > > > > > > On 01/06/2024 15:12, Cristian Ciocaltea wrote: > > >> The RK3588 SoC family integrat

[PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-03 Thread Jeff Johnson
it(agp_via_cleanup); +MODULE_DESCRIPTION("VIA AGPGART routines"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Dave Jones"); --- base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586 change-id: 20240603-md-agp-68a9e38017af

Re: [PATCH 3/6] drm/vmwgfx: remove unused struct 'vmw_stdu_dma'

2024-06-03 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'vmw_stdu_dma' is unused since > commit 39985eea5a6d ("drm/vmwgfx: Abstract placement selection") > Remove it. Ping. > Signed-off-by: Dr. David Alan Gilbert > --- > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 5 ---

[linux-next:master] BUILD REGRESSION 861a3cb5a2a8480d361fa6708da24747d6fa72fe

2024-06-03 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 861a3cb5a2a8480d361fa6708da24747d6fa72fe Add linux-next specific files for 20240603 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406031357.4t4jtalq-...@intel.com https

Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-06-03 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'init_exec' is unused since > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > init table parser") > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Ping. > --- > drivers/gpu/drm/n

Re: [PATCH v10 1/8] x86/vmware: Introduce VMware hypercall API

2024-06-03 Thread Borislav Petkov
On Wed, May 29, 2024 at 05:44:32PM -0700, Alexey Makhalov wrote: > While most of the vmware_hypercall callers are executed after alternative > patching applied, there are small amount of hypercalls running before that. > Only for them we have the logic of analyzing vmware_hypercall_mode as a > defa

[PATCH] drm/xe/vm: Simplify if condition

2024-06-03 Thread Thorsten Blum
The if condition !A || A && B can be simplified to !A || B. Fixes the following Coccinelle/coccicheck warning reported by excluded_middle.cocci: WARNING !A || A && B is equivalent to !A || B Compile-tested only. Signed-off-by: Thorsten Blum --- drivers/gpu/drm/xe/xe_vm.c | 4 ++-- 1 f

Re: [RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread John Stultz
On Mon, Jun 3, 2024 at 10:21 AM Hailong Liu wrote: > On Mon, 03. Jun 09:01, John Stultz wrote: > > On Mon, Jun 3, 2024 at 4:40 AM wrote: > > > > > > From: "Hailong.Liu" > > > > > > This help module use heap_flags to determine the type of dma-buf, > > > so that some mechanisms can be used to spee

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-03 Thread Abhinav Kumar
On 4/22/2024 4:06 AM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 07:32:35PM -0700, Abhinav Kumar wrote: On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: The msm_kms_funcs::che

Re: [PATCH v2 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH v2 2/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layour in the plane state and drop this call from dpu_plane_sspp_update(). noticed a small typo (missed it in v1), layour --> layout. No need to resend,

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-03 Thread Abhinav Kumar
On 4/22/2024 5:22 AM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 07:37:44PM -0700, Abhinav Kumar wrote: On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to dpu_for

Re: [PATCH v2 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++-

Re: [PATCH v2 6/9] drm/msm/dpu: drop call to _dpu_crtc_setup_lm_bounds from atomic_begin

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The dpu_crtc_atomic_check() already calls _dpu_crtc_setup_lm_bounds(). There is no need to call it from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH] drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-03 Thread Janusz Krzysztofik
CI has been sporadically reporting the following issue triggered by igt@i915_selftest@live@hangcheck on ADL-P and similar machines: <6> [414.049203] i915: Running intel_hangcheck_live_selftests/igt_reset_evict_fence ... <6> [414.068804] i915 :00:02.0: [drm] GT0: GUC: submission enabled <6> [4

Re: [PATCH] drm: Combine identical if/elif code blocks

2024-06-03 Thread Thorsten Blum
On 16. May 2024, at 03:24, Luc Ma wrote: > On Wed, 15 May 2024 at 17:31, Thorsten Blum wrote: >> On 15. May 2024, at 11:22, Thorsten Blum wrote: >>> On 15. May 2024, at 09:43, Luc Ma wrote: On Tue, 14 May 2024 at 19:37, Thorsten Blum wrote: > > Merge the identical if/elif c

Re: [PATCH v3 2/5] drm/mipi-dbi: Remove mipi_dbi_machine_little_endian()

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:33PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > mipi_dbi_machine_little_endian() should really have been called > mipi_dbi_framebuffer_little_endian() because that's the function it > performs. When I added support for these SPI displays I t

Re: [PATCH v3 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:34PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > This prepares for supporting other pixel formats than RGB565. Yes, the patch is pretty simple, however could you please expand the commit message by describing write_memory_bpw introduction.

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing LM requirements. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff -

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar wrote: > > > > On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: > > Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing > > LM requirements. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c |

Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays

2024-06-03 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 11:01:12PM +0800, Junhao Xie wrote: > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv, > which cause weston assertions failed. > > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format: > Assertion `!weston_drm_format_array_find_format

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Abhinav Kumar
On 6/3/2024 2:16 PM, Dmitry Baryshkov wrote: On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar wrote: On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing LM requirements. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ms

Re: [PATCH v2 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-03 Thread Marek Vasut
On 6/3/24 2:18 PM, Alexander Stein wrote: Hi Marek, Hi, Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut: This line_pixel_subtract is no longer needed now that the bridge can request and obtain specific pixel clock on input to the bridge, with clock frequency that matches the Pixe

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-03 Thread Marek Vasut
On 6/3/24 2:45 PM, Alexander Stein wrote: Hi, @@ -1631,6 +1643,18 @@ static int tc_edp_atomic_check(struct drm_bridge *bridge, struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { + struct tc_data *tc

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 02:24:27PM -0700, Abhinav Kumar wrote: > > > On 6/3/2024 2:16 PM, Dmitry Baryshkov wrote: > > On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: > > > > Check in _dpu_crtc_setup_lm_bounds() that C

Re: [PATCH v2] drm/msm/dpu: fix encoder irq wait skip

2024-06-03 Thread Abhinav Kumar
On 5/9/2024 12:40 PM, Barnabás Czémán wrote: The irq_idx is unsigned so it cannot be lower than zero, better to change the condition to check if it is equal with zero. It could not cause any issue because a valid irq index starts from one. Fixes: 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices

Re: [PATCH v3 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:35PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > DRM_FORMAT_RGB888 is 24 bits per pixel and it would be natural to send it > on the SPI bus using a 24 bits per word transfer. The problem with this > is that not all SPI controllers support 24

Re: [PATCH] Revert "drm/amdgpu: init iommu after amdkfd device init"

2024-06-03 Thread Armin Wolf
Am 23.05.24 um 19:30 schrieb Armin Wolf: This reverts commit 56b522f4668167096a50c39446d6263c96219f5f. A user reported that this commit breaks the integrated gpu of his notebook, causing a black screen. He was able to bisect the problematic commit and verified that by reverting it the notebook

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-03 Thread Nathan Chancellor
Hi Palmer, On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > I get a handful of build errors along the lines of > > > linux/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:58:13: > error: stack frame size (2352) exceeds lim

  1   2   >