Re: [PATCH v5 2/9] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2024-05-28 Thread 林睿祥

Re: DRM Accel BoF at Linux Plumbers

2024-05-28 Thread Tomeu Vizoso
On Thu, May 23, 2024 at 8:35 AM Jacek Lawrynowicz wrote: > > Hi, > > On 21.05.2024 17:10, Jeffrey Hugo wrote: > > On 5/21/2024 8:41 AM, Tomeu Vizoso wrote: > >> On Tue, May 21, 2024 at 2:12 PM Daniel Vetter wrote: > >>> > >>> On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote: > Hi

Re: DRM Accel BoF at Linux Plumbers

2024-05-28 Thread Tomeu Vizoso
On Tue, May 21, 2024 at 2:12 PM Daniel Vetter wrote: > > On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote: > > Hi, > > > > I would like to use the chance at the next Plumbers to discuss the > > present challenges related to ML accelerators in mainline. > > > > I'm myself more oriented

Re: [PATCH v6 0/7] Add mediate-drm secure flow for SVP

2024-05-28 Thread 林睿祥

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-05-28 Thread Jocelyn Falempe
On 27/05/2024 15:34, Geert Uytterhoeven wrote: Add support for the drm_panic module, which displays a message on the screen when a kernel panic occurs. Thanks for your patch, I'm pleased that you find drm_panic useful. That looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: G

Re: [PATCH] drm: renesas: rcar-du: Add drm_panic support for non-vsp

2024-05-28 Thread Jocelyn Falempe
Hi, On 27/05/2024 15:35, Geert Uytterhoeven wrote: Add support for the drm_panic module for DU variants not using the VSP-compositor, to display a message on the screen when a kernel panic occurs. Thanks for your patch, I'm pleased that you find drm_panic useful. That looks good to me. Revie

Re: [PATCH v6,17/24] media: mediatek: vcodec: re-construct h264 driver to support svp mode

2024-05-28 Thread Chen-Yu Tsai
On Mon, May 27, 2024 at 1:58 PM Chen-Yu Tsai wrote: > > On Thu, May 16, 2024 at 8:21 PM Yunfei Dong wrote: > > > > Need secure buffer size to convert secure handle to secure > > pa in optee-os, re-construct the vsi struct to store each > > secure buffer size. > > > > Separate svp and normal wait

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Maxime Ripard
Hi, On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: > From: Arnaud Vrac > > The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > DVI 1.0 and HDMI 1.4b and 2.0b output signals. > > Since it's an I2C-programmable bridge, it could have a proper driver, > but the de

Re: [PATCH v5 0/6] Add DSC support to DSI video panel

2024-05-28 Thread neil . armstrong
On 27/05/2024 16:21, Jun Nie wrote: This is follow up update to Jonathan's patch set. Changes vs V4: - Polish width calculation with helper function - Split cfg2 compression bit into another patch Changes vs V3: - Rebase to latest msm-next-lumag branch. - Drop the slice_per_pkt change as it doe

Re: [RFC PATCH v3 13/21] drm/exec: Rework contended locking

2024-05-28 Thread Thomas Hellström
On Tue, 2024-05-28 at 08:51 +0200, Christian König wrote: > Hi Thomas, > > Am 28.05.24 um 08:36 schrieb Thomas Hellström: > > Hi, Christian. > > > > I'd appreciate if you could respond to the below, since it is a bit > > hard to try to design around a problem I don't believe exists, and > > come

[PATCH RESEND 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel

2024-05-28 Thread Gerald Loacker
At the jt240mhqs_hwt_ek_e3 panel, noticeable flickering occurs. This is addressed by patch 1, which adjusts the vertical timing. Patch 2 and 3 are two more minor fixes for timing and dimension. Signed-off-by: Gerald Loacker --- Gerald Loacker (3): drm/panel: sitronix-st7789v: fix timing for

[PATCH RESEND 2/3] drm/panel: sitronix-st7789v: tweak timing for jt240mhqs_hwt_ek_e3 panel

2024-05-28 Thread Gerald Loacker
Use the default timing parameters to get a refresh rate of about 60 Hz for a clock of 6 MHz. Signed-off-by: Gerald Loacker --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH RESEND 1/3] drm/panel: sitronix-st7789v: fix timing for jt240mhqs_hwt_ek_e3 panel

2024-05-28 Thread Gerald Loacker
Flickering was observed when using partial mode. Moving the vsync to the same position as used by the default sitronix-st7789v timing resolves this issue. Signed-off-by: Gerald Loacker --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH RESEND 3/3] drm/panel: sitronix-st7789v: fix display size for jt240mhqs_hwt_ek_e3 panel

2024-05-28 Thread Gerald Loacker
This is a portrait mode display. Change the dimensions accordingly. Signed-off-by: Gerald Loacker --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/pan

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-05-28 Thread Maxime Ripard
On Mon, 27 May 2024 15:57:49 +0200, Maxime Ripard wrote: > Here's a series that creates some extra infrastructure specifically > targeted at HDMI controllers. > > The idea behind this series came from a recent discussion on IRC during > which we discussed infoframes generation of i915 vs everythin

Re: [PATCH] drm/panel: sitronix-st7789v: Add check for of_drm_get_panel_orientation

2024-05-28 Thread Michael Riesch
Hi Chen Ni, On 5/28/24 05:08, Chen Ni wrote: > Add check for the return value of of_drm_get_panel_orientation() and > return the error if it fails in order to catch the error. > > Fixes: b27c0f6d208d ("drm/panel: sitronix-st7789v: add panel orientation > support") > Signed-off-by: Chen Ni > ---

Re: [PATCH v3 01/21] drm/ttm: Allow TTM LRU list nodes of different types

2024-05-28 Thread Christian König
Am 21.05.24 um 09:16 schrieb Thomas Hellström: To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node mig

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Maxime Ripard
On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > On 28/05/2024 09:43, Maxime Ripard wrote: > > Hi, > > > > On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: > > > From: Arnaud Vrac > > > > > > The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > > > DVI

Re: [PATCH v3 02/21] drm/ttm: Slightly clean up LRU list iteration

2024-05-28 Thread Christian König
Am 21.05.24 um 09:16 schrieb Thomas Hellström: To make the transition to using lru hitches easier, simplify the ttm_resource_manager_next() interface to only take the cursor and reuse ttm_resource_manager_next() functionality from ttm_resource_manager_first(). Cc: Christian König Cc: Somalapura

[PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-28 Thread Alexander Stein
Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible removed), it lines up with the other error paths in probe function. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/d

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Jun Nie
Dmitry Baryshkov 于2024年5月28日周二 08:48写道: > > On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > > data is valid for only half the active window if widebus > > is enabled > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 9 + > > 1 file change

Re: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-28 Thread Liu Ying
On 05/28/2024, Alexander Stein wrote: > Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible > removed), it lines up with the other error paths in probe function. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++- > 1 file chan

Re: (subset) [PATCH v3 0/7] Add DSI support for RK3128

2024-05-28 Thread Heiko Stuebner
On Thu, 9 May 2024 16:06:46 +0200, Alex Bee wrote: > This series aims to add support for the DesignWare MIPI DSI controller and > the Innoslicon D-PHY found in RK3128 SoCs. The code additions are rather > tiny: It only need some code in the Rockchip dw-mipi-dsi glue layer for > this SoC and do some

RE: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-28 Thread Manna, Animesh
+ drm-core maintainer Hi, Could you please have a look and ack this patch. Received r-b from Jouni on 0th patch for the whole patch series. Regards, Animesh > -Original Message- > From: Intel-gfx On Behalf Of > Animesh Manna > Sent: Monday, May 27, 2024 1:57 PM > To: intel-...@lists.

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
Hi, On Tue, 28 May 2024 08:40:20 + Zhi Wang wrote: > On 27/05/2024 22.18, Danilo Krummrich wrote: >> External email: Use caution opening links or attachments >> >> >> On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: >>> On Mon, 20 May 2024 19:24:19 +0200 >>> Danilo Krummrich wrot

Re: [PATCH v6 3/8] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation

2024-05-28 Thread AngeloGioacchino Del Regno
Il 26/05/24 01:08, Jason-JH.Lin ha scritto: Add cmdq_pkt_logic_command to support math operation. cmdq_pkt_logic_command can append logic command to the CMDQ packet, ask GCE to execute a arithmetic calculate instruction, such as add, subtract, multiply, AND, OR and NOT, etc. Note that all arith

Re: [PATCH v6 4/8] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler

2024-05-28 Thread AngeloGioacchino Del Regno
Il 26/05/24 01:08, Jason-JH.Lin ha scritto: 1. Add a loop flag for CMDQ packet struct. CMDQ helper will use a loop flag to mark CMDQ packet as lopping command and make current command buffer jumps to the beginning when GCE executes to the end of command buffer. 2. Add a looping task handle flow

Re: [PATCH v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-28 Thread AngeloGioacchino Del Regno
Il 26/05/24 01:08, Jason-JH.Lin ha scritto: 1. Add mboxes property to define a GCE loopping thread as a secure IRQ handler. The CMDQ secure driver requests a mbox channel and sends a looping command to the GCE thread. The looping command will wait for a secure packet done event signal from secure

Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-05-28 Thread AngeloGioacchino Del Regno
Il 26/05/24 17:04, Jason-JH Lin (林睿祥) ha scritto: Hi Angelo, Jassi, Could you help me apply this series? Thanks! That's not me, it's Jassi - green light from me, btw. Cheers, Angelo Regards, Jason-JH.Lin On Wed, 2024-01-24 at 09:57 +0100, AngeloGioacchino Del Regno wrote: Il 24/01/24 02:

Re: [PATCH v9 06/10] math.h: Add macros for rounding to closest value

2024-05-28 Thread Devarsh Thakkar
Hi Andy, Thanks for the review. On 28/05/24 02:02, Andy Shevchenko wrote: > On Sun, May 26, 2024 at 11:38:56PM +0530, Devarsh Thakkar wrote: ... >> +/** >> + * round_closest_up - round closest to be multiple of specified value >> (which is >> + *power of 2) with preference t

Re: [PATCH 3/9] drm/i915: Introduce plane->min_alignment() vfunc

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:36PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Different hardware generations have different scanout alignment > requirements. Introduce a new vfunc that will allow us to > make that distinction without horrible if-ladders. > > For now we directly plug i

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
On Mon, 27 May 2024 21:22:47 +0200 Danilo Krummrich wrote: >> > +/// Abstraction around a C firmware struct. >> > +/// >> > +/// This is a simple abstraction around the C firmware API. Just like >> > with the C API, firmware can >> > +/// be requested. Once requested the abstraction provides dir

Re: [RFC PATCH v3 13/21] drm/exec: Rework contended locking

2024-05-28 Thread Christian König
Am 28.05.24 um 10:07 schrieb Thomas Hellström: On Tue, 2024-05-28 at 08:51 +0200, Christian König wrote: 2) Any contended lock held at loop start is completely encapsulated in the ww transaction and can and will be unlocked when exiting it, so this patch doesn't introduce any additional problems

Re: [PATCH v6 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-28 Thread mrip...@kernel.org
On Tue, May 28, 2024 at 10:04:06AM GMT, Manna, Animesh wrote: > + drm-core maintainer > > Hi, > > Could you please have a look and ack this patch. > Received r-b from Jouni on 0th patch for the whole patch series. Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-28 Thread Devarsh Thakkar
Hi Andy, Thanks for the review. On 28/05/24 02:07, Andy Shevchenko wrote: [..] >> +#include >> +#include >> +#include > > + math.h (where abs()/DIV_ROUND_*()/etc come from?) > I believe I mentioned that. > I did compile and test this, so math.h was indirectly getting included via some othe

Re: [v7 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-05-28 Thread Linus Walleij
On Wed, May 15, 2024 at 3:46 AM Cong Yang wrote: > In V1, discussed with Doug and Linus [1], we need break out as separate > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02" > and in this series "BOE nv110wum-l60" "IVO t109nw41" panels use same > controller, they have som

Re: [v7 4/7] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-05-28 Thread Linus Walleij
On Wed, May 15, 2024 at 3:47 AM Cong Yang wrote: > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel with himax-hx83102 > controller. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Acked-by: Conor Dooley Reviewed-by: Linus Walleij Yours, Linus Wal

Re: [v7 6/7] dt-bindings: display: panel: Add compatible for IVO t109nw41

2024-05-28 Thread Linus Walleij
On Wed, May 15, 2024 at 3:47 AM Cong Yang wrote: > The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel with himax-hx83102 > controller. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Acked-by: Conor Dooley Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 02/17] drm/panel replay: Add edp1.5 Panel Replay bits and register

2024-05-28 Thread Hogander, Jouni
On Thu, 2024-05-16 at 11:53 +0300, Jouni Högander wrote: > Add PANEL_REPLAY_CONFIGURATION_2 register and some missing Panel > Replay > bits. Hello drm-core maintainers, Could you please consider providing your ack on this patch? I'm planning to merge it via drm-intel tree. I have already r-b tag.

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Different planes could have different alignment requirements > even for the same format/modifier. Collect the alignment > requirements across all planes capable of scanning out the > fb such that the alignmen

Re: [PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-28 Thread Devarsh Thakkar
On 28/05/24 02:08, Andy Shevchenko wrote: > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote: >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote: > > ... > >>> +MODULE_LICENSE("GPL"); >> >> modpost validator won't be happy about this, i.e. missing >> MODULE_DESC

Re: [PATCH 4/9] drm/i915: Introduce fb->min_alignment

2024-05-28 Thread Imre Deak
On Tue, May 28, 2024 at 02:27:58PM +0300, Imre Deak wrote: > [...] > > +} > > + > > static unsigned int > > intel_plane_fb_min_alignment(const struct intel_plane_state *plane_state) > > { > > struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane); > > - const struct drm_frameb

Re: [PATCH 02/17] drm/panel replay: Add edp1.5 Panel Replay bits and register

2024-05-28 Thread mrip...@kernel.org
On Tue, May 28, 2024 at 11:25:41AM GMT, Hogander, Jouni wrote: > On Thu, 2024-05-16 at 11:53 +0300, Jouni Högander wrote: > > Add PANEL_REPLAY_CONFIGURATION_2 register and some missing Panel > > Replay > > bits. > > Hello drm-core maintainers, > > Could you please consider providing your ack on t

Re: [PATCH 5/9] drm/i915: Split cursor alignment to per-platform vfuncs

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:38PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Split intel_cursor_alignment() into per-platform variants. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_cursor.c | 40 +++-- > drive

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-28 Thread Maxime Ripard
On Fri, May 24, 2024 at 04:38:13PM GMT, Aradhya Bhatia wrote: > Hi Maxime, > > On 21/05/24 18:45, Maxime Ripard wrote: > > Hi, > > > > On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: > /** > * @pre_enable: > * > @@ -285,6 +319,26 @@ s

Re: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-28 Thread Alexander Stein
Hi, thanks for your feedback. Am Dienstag, 28. Mai 2024, 12:02:29 CEST schrieb Liu Ying: > On 05/28/2024, Alexander Stein wrote: > > Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible > > removed), it lines up with the other error paths in probe function. > > > > Signed-off-

[PATCH] drm/amdkfd: select CONFIG_CRC16

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann The amdkfd support fails to link when CONFIG_CRC16 is disabled: aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function `kfd_topology_add_device': kfd_topology.c:(.text+0x3a4c): undefined reference to `crc16' This is a library module that needs to be select

[PATCH 1/4] [RESEND] drm/amd/display: dynamically allocate dml2_configuration_options structures

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann This structure is too large to fit on a stack, as shown by the newly introduced warnings from a recent code change: drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn32/dcn32_resource.c: In function 'dcn32_update_bw_bounding_box': drivers/gpu/drm/amd/amdgpu/../display/dc/

[PATCH 2/4] [RESEND] drm/amd/display: fix graphics_object_id size

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann The graphics_object_id structure is meant to fit into 32 bits, as it's passed by value in and out of functions. A recent change increased the size to 128 bits, so it's now always passed by reference, which is clearly not intended and ends up producing a compile-time warning:

[PATCH 3/4] drm/amd/display: avoid large on-stack structures

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann Putting excessively large objects on a function stack causes a warning about possibly overflowing the 8KiB of kernel stack: drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn401/dcn401_resource.c: In function 'dcn401_update_bw_bounding_box': drivers/gpu/drm/amd/amdgpu/../

[PATCH 4/4] drm/amd/display: Move 'struct scaler_data' off stack

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann The scaler_data structure is implicitly copied onto the stack twice by being returned from a function. This is usually a bad idea, but it was not flagged by the compiler until a recent addition that pushed it over the 1024 byte function stack limit: drivers/gpu/drm/amd/amdgpu

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Dmitry Baryshkov
On Tue, May 28, 2024 at 05:59:13PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2024年5月28日周二 08:48写道: > > > > On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > > > data is valid for only half the active window if widebus > > > is enabled > > > > > > Signed-off-by: Jun Nie > > > --- > > > d

Re: [PATCH v2] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Arnaud Vrac
On 28/05/2024 03:13, Dmitry Baryshkov wrote: On Mon, May 27, 2024 at 06:06:05PM +0200, Marc Gonzalez wrote: From: Arnaud Vrac The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting DVI 1.0 and HDMI 1.4b and 2.0b output signals. Since it's an I2C-programmable bridge, it could h

Re: [PATCH 0/2] Add WL-355608-A8 panel

2024-05-28 Thread Philippe Simons
Tested on my RG35XX-H, no issues Tested-by: Philippe Simons

Re: [PATCH 0/2] Add WL-355608-A8 panel

2024-05-28 Thread Philippe Simons
Tested on my RG35XX-H, no issues Tested-by: Philippe Simons

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Arnaud Vrac
On 28/05/2024 09:43, Maxime Ripard wrote: Hi, On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: From: Arnaud Vrac The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting DVI 1.0 and HDMI 1.4b and 2.0b output signals. Since it's an I2C-programmable bridge, it could h

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Zhi Wang
On 27/05/2024 22.18, Danilo Krummrich wrote: > External email: Use caution opening links or attachments > > > On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: >> On Mon, 20 May 2024 19:24:19 +0200 >> Danilo Krummrich wrote: >> >>> Add an abstraction around the kernels firmware API to re

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Zhi Wang
On 28/05/2024 13.17, FUJITA Tomonori wrote: > External email: Use caution opening links or attachments > > > Hi, > > On Tue, 28 May 2024 08:40:20 + > Zhi Wang wrote: > >> On 27/05/2024 22.18, Danilo Krummrich wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> O

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Arnaud Vrac
On 28/05/2024 11:17, Maxime Ripard wrote: On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: On 28/05/2024 09:43, Maxime Ripard wrote: Hi, On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: From: Arnaud Vrac The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver suppo

[PATCH] drm/panel: sitronix-st7789v: Add check for of_drm_get_panel_orientation

2024-05-28 Thread Chen Ni
Add check for the return value of of_drm_get_panel_orientation() and return the error if it fails in order to catch the error. Fixes: b27c0f6d208d ("drm/panel: sitronix-st7789v: add panel orientation support") Signed-off-by: Chen Ni --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 +++- 1

[PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

2024-05-28 Thread Ricard Wanderlof
Even though data is truncated to 24 bits, the I2S interface does accept 32 bit data (the slot widths according to the data sheet can be 16 or 32 bits) so let the hw_params callback reflect this, even if the lowest 8 bits are not used when 32 bits are specified. This is normally how 24 bit audio

Re: [PATCH 6/9] drm/i915: Split pre-skl platforms out from intel_surf_alignment()

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract the necessary chunks from intel_surf_alignment() > into per-platform variants for all pre-skl primary/sprite > planes. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/i9xx_pla

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
Hi Luis and Russ, I just noted I forgot to add you to this patch, sorry for that. Please find the full series and previous discussions in [1]. - Danilo [1] https://lore.kernel.org/rust-for-linux/20240520172059.181256-1-d...@redhat.com/ On Mon, May 20, 2024 at 07:24:19PM +0200, Danilo Krummric

Re: [PATCH 7/9] drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:40PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that all pre-skl platforms have their own .min_alignment() > functions the remainder of intel_surf_alignment() can be hoisted > into skl_univerals_plane.c (and renamed appropriately). > > Signed-off-by:

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 08:01:26PM +0900, FUJITA Tomonori wrote: > On Mon, 27 May 2024 21:22:47 +0200 > Danilo Krummrich wrote: > > >> > +/// Abstraction around a C firmware struct. > >> > +/// > >> > +/// This is a simple abstraction around the C firmware API. Just like > >> > with the C API, f

Re: [PATCH] drm/amdkfd: select CONFIG_CRC16

2024-05-28 Thread Lazar, Lijo
On 5/28/2024 5:20 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The amdkfd support fails to link when CONFIG_CRC16 is disabled: > > aarch64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_topology.o: in function > `kfd_topology_add_device': > kfd_topology.c:(.text+0x3a4c): undefined reference

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Greg KH
On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > However, if you have a driver that needs the firmware abstractions, I would be > surprised if there were any hesitations to already merge the minimum device > abstractions [1] and this one (once reviewed) without the rest. At least

[PATCH v2] drm/print: Introduce drm_line_printer

2024-05-28 Thread Michal Wajdeczko
This drm printer wrapper can be used to increase the robustness of the captured output generated by any other drm_printer to make sure we didn't lost any intermediate lines of the output by adding line numbers to each output line. Helpful for capturing some crash data. Signed-off-by: Michal Wajdec

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 02:45:02PM +0200, Greg KH wrote: > On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > > However, if you have a driver that needs the firmware abstractions, I would > > be > > surprised if there were any hesitations to already merge the minimum device > > ab

Re: [PATCH 8/9] drm/i915: Update plane alignment requirements for TGL+

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:41PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we still use the SKL+ PLANE_SURF alignment even > for TGL+ even though the hardware no longer needs it. > Introduce a separate tgl_plane_min_alignment() and update > it to more accurately reflect th

[PATCH] udmabuf: add CONFIG_MMU dependency

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann There is no !CONFIG_MMU version of vmf_insert_pfn(): arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault': udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn' Fixes: f7254e043ff1 ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling

[PATCH] drm/xe: replace format-less snprintf() with strscpy()

2024-05-28 Thread Arnd Bergmann
From: Arnd Bergmann Using snprintf() with a format string from task->comm is a bit dangerous since the string may be controlled by unprivileged userspace: drivers/gpu/drm/xe/xe_devcoredump.c: In function 'devcoredump_snapshot': drivers/gpu/drm/xe/xe_devcoredump.c:184:9: error: format not a strin

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Dmitry Baryshkov
On Tue, May 28, 2024 at 11:17:56AM +0200, Maxime Ripard wrote: > On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > > On 28/05/2024 09:43, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, May 27, 2024 at 06:03:56PM GMT, Marc Gonzalez wrote: > > > > From: Arnaud Vrac > > > > > > > > T

Re: [PATCH] udmabuf: add CONFIG_MMU dependency

2024-05-28 Thread David Hildenbrand
Am 28.05.24 um 15:31 schrieb Arnd Bergmann: From: Arnd Bergmann There is no !CONFIG_MMU version of vmf_insert_pfn(): arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault': udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn' Fixes: f7254e043ff1 ("udmabuf:

Re: [PATCH 9/9] drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff

2024-05-28 Thread Imre Deak
On Mon, May 13, 2024 at 08:59:42PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > I don't think the display hardware really has such chroma > plane tile row alignment requirements as outlined in > commit d156135e6a54 ("drm/i915/tgl: Make sure a semiplanar > UV plane is tile row size aligne

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 08:40:20AM +, Zhi Wang wrote: > On 27/05/2024 22.18, Danilo Krummrich wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: > >> On Mon, 20 May 2024 19:24:19 +0200 > >> Danilo Krummrich

[PATCH 2/2] drivers/gpu: Fix misalignment in comment block

2024-05-28 Thread Bruno Rocha Levi
This patch fixes a warning from checkpatch by ensuring the trailing */ is aligned with the rest of the *, improving readability. Co-developed-by: Lucas Antonio Signed-off-by: Lucas Antonio Signed-off-by: Bruno Rocha Levi --- drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 2 +- 1 file changed,

[PATCH 0/2] Fix alignment in comment blocks

2024-05-28 Thread Bruno Rocha Levi
Hi! This patchset fixes two alignment issues in comment blocks throughout the codebase. These changes fix codestyle warnings reported from checkpatch and are intended to improve code readability. Thanks, Bruno Rocha Levi (2): drm/vkms: Fix misalignment in comment block drivers/gpu: Fix misal

[PATCH 1/2] drm/vkms: Fix misalignment in comment block

2024-05-28 Thread Bruno Rocha Levi
From: Bruno Rocha Levi This change fixes a warning from checkpatch, it improves readability of a comment that was previously misaligned, by ensuring the trailing */ is on the same line as the opening /*. Co-developed-by: Lucas Antonio Signed-off-by: Lucas Antonio Signed-off-by: Bruno Rocha Lev

[drm-misc:drm-misc-next 29/29] drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c:213:17: error: implicit declaration of function 'drm_connector_hdmi_compute_mode_clock'; did you mean 'drm_hdmi_compute_mode_clock

2024-05-28 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 62545c719e26ec9f62efab7e9582deb73265b6d0 commit: ea64761a54a25fa2c27bae99b3c72dadfaa74d3e [29/29] drm/sun4i: hdmi: Switch to HDMI connector config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240528

Re: [PATCH RESEND, v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-28 Thread 林睿祥

[drm-misc:drm-misc-next 29/29] drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c:213:3: error: implicit declaration of function 'drm_connector_hdmi_compute_mode_clock' is invalid in C99

2024-05-28 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 62545c719e26ec9f62efab7e9582deb73265b6d0 commit: ea64761a54a25fa2c27bae99b3c72dadfaa74d3e [29/29] drm/sun4i: hdmi: Switch to HDMI connector config: arm-defconfig (https://download.01.org/0day-ci/archive/20240528

Re: [PATCH 1/2] drm/vkms: Fix misalignment in comment block

2024-05-28 Thread Louis Chauvet
Le 28/05/24 - 10:08, Bruno Rocha Levi a écrit : > From: Bruno Rocha Levi > > This change fixes a warning from checkpatch, it improves readability of a > comment that was previously misaligned, by ensuring the trailing */ is on > the same line as the opening /*. Hi, Do you mean same column? May

Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32 bits via I2S

2024-05-28 Thread Dmitry Baryshkov
On Tue, May 28, 2024 at 12:04:49PM +0200, Ricard Wanderlof wrote: > > Even though data is truncated to 24 bits, the I2S interface does > accept 32 bit data (the slot widths according to the data sheet > can be 16 or 32 bits) so let the hw_params callback reflect this, > even if the lowest 8 bits a

Re: [PATCH] drm/xe: replace format-less snprintf() with strscpy()

2024-05-28 Thread Thomas Hellström
On Tue, 2024-05-28 at 15:32 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Using snprintf() with a format string from task->comm is a bit > dangerous since the string may be controlled by unprivileged > userspace: > > drivers/gpu/drm/xe/xe_devcoredump.c: In function > 'devcoredump_snapsho

Re: [PATCH RESEND,v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-28 Thread Conor Dooley
On Tue, May 28, 2024 at 02:38:46PM +, Jason-JH Lin (林睿祥) wrote: > Hi Conor, > > On Mon, 2024-05-27 at 18:36 +0100, Conor Dooley wrote: > > On Sun, May 26, 2024 at 10:44:37PM +0800, Jason-JH.Lin wrote: > > > 1. Add mboxes property to define a GCE loopping thread as a secure > > > IRQ > > > hand

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Maxime Ripard
On Tue, May 28, 2024 at 04:50:10PM GMT, Dmitry Baryshkov wrote: > On Tue, May 28, 2024 at 11:17:56AM +0200, Maxime Ripard wrote: > > On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > > > On 28/05/2024 09:43, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Mon, May 27, 2024 at 06:03:

Re: [PATCH 1/2] dt-bindings: gpu: mali-bifrost: Add compatible for MT8188 SoC

2024-05-28 Thread Conor Dooley
On Mon, May 27, 2024 at 11:25:12AM +0200, AngeloGioacchino Del Regno wrote: > Add a compatible for the MediaTek MT8188 SoC, with an integrated > ARM Mali G57 MC3 (Valhall-JM) GPU. > > Signed-off-by: AngeloGioacchino Del Regno > Acked-by: Conor Dooley Chers, Conor. signature.asc Description:

Re: [PATCH v1] drm/bridge: simple-bridge: Add support for TI TDP158

2024-05-28 Thread Dmitry Baryshkov
On Tue, 28 May 2024 at 18:00, Maxime Ripard wrote: > > On Tue, May 28, 2024 at 04:50:10PM GMT, Dmitry Baryshkov wrote: > > On Tue, May 28, 2024 at 11:17:56AM +0200, Maxime Ripard wrote: > > > On Tue, May 28, 2024 at 10:05:50AM GMT, Arnaud Vrac wrote: > > > > On 28/05/2024 09:43, Maxime Ripard wrot

Re: (subset) [PATCH v3 0/7] Add DSI support for RK3128

2024-05-28 Thread Heiko Stuebner
On Thu, 9 May 2024 16:06:46 +0200, Alex Bee wrote: > This series aims to add support for the DesignWare MIPI DSI controller and > the Innoslicon D-PHY found in RK3128 SoCs. The code additions are rather > tiny: It only need some code in the Rockchip dw-mipi-dsi glue layer for > this SoC and do some

Re: [PATCH RESEND, v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-28 Thread 林睿祥

[PATCH] drm/sun4i: Fix compilation error

2024-05-28 Thread Maxime Ripard
Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") introduced a dependency that got renamed in a previous version, but wasn't properly updated in that driver. Fix the name of the function. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202405282205.eu

Re: [PATCH 2/2] drivers/gpu: Fix misalignment in comment block

2024-05-28 Thread Alex Deucher
Applied. Thanks! Alex On Tue, May 28, 2024 at 10:47 AM Bruno Rocha Levi wrote: > > This patch fixes a warning from checkpatch by ensuring the trailing */ is > aligned with the rest of the *, improving readability. > > Co-developed-by: Lucas Antonio > Signed-off-by: Lucas Antonio > Signed-off-

Re: [PATCH RESEND,v6 8/8] soc: mediatek: mtk-cmdq: Add secure cmdq_pkt APIs

2024-05-28 Thread 林睿祥

Re: [PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-05-28 Thread 林睿祥

[Bug 218900] amdgpu: Fatal error during GPU init

2024-05-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218900 Jean-Christophe Guillain (jean-christo...@guillain.net) changed: What|Removed |Added Bisected commit-id|db5d28c0bfe566908719bec8e25 |

Re: [PATCH v6 3/8] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation

2024-05-28 Thread 林睿祥

Re: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-28 Thread kernel test robot
Hi Alexander, kernel test robot noticed the following build warnings: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on linus/master v6.10-rc1 next-20240528] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH] drm/dp: Fix documentation warning

2024-05-28 Thread Douglas Anderson
On Sun, 19 May 2024 00:10:27 -0300, MarileneGarcia wrote: > It fixes the following warnings when > the kernel documentation is generated: > > ./include/drm/display/drm_dp_helper.h:126: > warning: Function parameter or struct member > 'mode' not described in 'drm_dp_as_sdp' > > [...] Applied, t

Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1

2024-05-28 Thread Doug Anderson
Hi, On Mon, May 6, 2024 at 8:54 AM Doug Anderson wrote: > > Hi, > > On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong > wrote: > > > > Hi Doug, thank you! > > We had reported this info to the CSOT to correct the vendor id. > > If they confirm to fix this with the same product ID, we will submit a > >

  1   2   3   >