Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Tomeu Vizoso
Hi Lucas, On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Hi Tomeu, > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > re

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-05-20 Thread 吴勇
On Thu, 2024-05-16 at 10:17 +0200, Christian König wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Am 15.05.24 um 13:23 schrieb Yong Wu: > > Introduce a FLAG for the restricted memory which means the memory >

Re: [PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-20 Thread Jani Nikula
On Fri, 17 May 2024, Sefa Eyeoglu wrote: > On Fri, 2024-05-17 at 16:52 +0200, Philipp Zabel wrote: >> On Fr, 2024-05-17 at 16:09 +0200, Sefa Eyeoglu wrote: >> > The Bigscreen Beyond VR headset is a non-desktop output and should >> > be >> > marked as such using an EDID quirk. >> > >> > Closes htt

Re: [PATCH v2 1/3] drm/print: Add generic drm dev printk function

2024-05-20 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > We already have some drm printk functions that need to duplicate > a code to get a similar format of the final result, for example: > > [ ] :00:00.0: [drm:foo] bar > [ ] :00:00.0: [drm] foo bar > [ ] :00:00.0: [drm] *ERROR* foo > > A

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 06:29, Liu Ying wrote: > > On 5/20/24 06:11, Dmitry Baryshkov wrote: > > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > >> fails to consider the case where adv7511->i2c_main->irq is z

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Tomeu Vizoso
On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Hi Tomeu, > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > If we expose a render node for NPUs without rendering capabilities, the > > userspace stack will offer it to compositors and applications for > > rendering, wh

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Liu Ying
On 5/20/24 17:08, Dmitry Baryshkov wrote: > On Mon, 20 May 2024 at 06:29, Liu Ying wrote: >> >> On 5/20/24 06:11, Dmitry Baryshkov wrote: >>> On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") fails to consi

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Andy Shevchenko
On Fri, May 17, 2024 at 01:53:47PM -0700, Daniel Latypov wrote: > On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko > wrote: ... > > > [devarsht: Rebase to 6.9 and change license to GPL] > > > > I'm not sure that you may change license. It needs the author's > > confirmation. > > Checking, this

[PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-05-20 Thread Christophe JAILLET
If zynqmp_dpsub_drm_init() fails, we must undo the previous drm_bridge_add() call. Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] drm/panel: lg-sw43408: Fix an error handling path in sw43408_probe()

2024-05-20 Thread Christophe JAILLET
If mipi_dsi_attach() fails, we must undo the drm_panel_add() call hidden in sw43408_add(), as already done in the remove function. Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/gpu/drm/panel/panel-lg-sw43408.

Re: [PATCH v4 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-20 Thread AngeloGioacchino Del Regno
Il 17/05/24 11:49, Michael Walle ha scritto: Hi Angelo, On Thu May 16, 2024 at 10:11 AM CEST, AngeloGioacchino Del Regno wrote: Implement OF graphs support to the mediatek-drm drivers, allowing to stop hardcoding the paths, and preventing this driver to get a huge amount of arrays for each boar

Re: [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()

2024-05-20 Thread AngeloGioacchino Del Regno
Il 17/05/24 23:36, Douglas Anderson ha scritto: The mipi_dsi_dcs_nop() function returns an error but we weren't checking it in boe_panel_prepare(). Add a check. This is highly unlikely to matter in practice. If the NOP failed then likely later MIPI commands would fail too. Found by code inspecti

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-05-20 Thread 吴勇
On Thu, 2024-05-16 at 11:59 +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/24 13:23, Yong Wu ha scritto: > > Introduce a FLAG for the restricted memory which means the memory > > is > > protected by TEE or hypervisor, then it's inaccessiable for kernel. > > > > Currently we don't use sg_dma_u

[PATCH] drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)

2024-05-20 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Lack of check for copy-on-write (COW) mapping in drm_gem_shmem_mmap allows users to call mmap with PROT_WRITE and MAP_PRIVATE flag causing a kernel panic due to BUG_ON in vmf_insert_pfn_prot: BUG_ON((vma->vm_flags & VM_PFNMAP) && is_cow_mapping(vma->vm_flags)); Return -E

Re: [PATCH v4 08/16] ASoC: mediatek: mt8365: Add DMIC DAI support

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add Digital Micro Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-dmic.c | 347 1 file changed, 347 insertions(+) diff --git a/sound/soc/med

Re: [PATCH v4 06/16] ASoC: mediatek: mt8365: Add I2S DAI support

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add I2S Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 854 + 1 file changed, 854 insertions(+) diff --git a/sound/soc/mediatek/mt83

Re: [PATCH v4 07/16] ASoC: mediatek: mt8365: Add ADDA DAI support

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add ADDA Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-adda.c | 315 1 file changed, 315 insertions(+) diff --git a/sound/soc/mediatek/mt8

Re: [PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM DAI support

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add Pulse Code Modulation Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-dai-pcm.c | 293 + 1 file changed, 293 insertions(+) diff --git a/sound

Re: [PATCH] drm/panel: lg-sw43408: Fix an error handling path in sw43408_probe()

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 11:34:31AM +0200, Christophe JAILLET wrote: > If mipi_dsi_attach() fails, we must undo the drm_panel_add() call hidden in > sw43408_add(), as already done in the remove function. > > Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") > Signed-off-by: Christophe

Re: [PATCH v4 10/16] ASoc: mediatek: mt8365: Add a specific soundcard for EVK

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, amerg...@baylibre.com ha scritto: From: Nicolas Belin Add a specific soundcard for mt8365-evk. It supports audio jack in/out, dmics, the amic and lineout. Signed-off-by: Nicolas Belin Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-mt6357.c | 348 ++

Re: [PATCH v4 11/16] ASoC: mediatek: mt8365: Add platform driver

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add mt8365 platform driver. Since you have to anyway send a v5: Add a driver for the Analog Front End (AFE) PCM blahblah MT8365 blahblah :-) after which Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > On Sat, May 18, 2024 at 12:24:27AM +0100, li...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > 'bridge_init' is unused, I think following: > >

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-20 Thread Dmitry Baryshkov
On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: > Fix a struct member name in &struct drm_dp_as_sdp. > Add Returns: kernel-doc syntax for 4 functions. > In the Returns: sections, spell "%true" and "%false" consistently. > > Fixes these kernel-doc warnings: > > drm_dp_helper.h:126: w

Re: [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Add audio clock wrapper and audio tuner control. Signed-off-by: Alexandre Mergnat --- sound/soc/mediatek/mt8365/mt8365-afe-clk.c | 443 + sound/soc/mediatek/mt8365/mt8365-afe-clk.h | 49 2 files changed, 492

Re: [PATCH] drm/mode: fix all kernel-doc warnings

2024-05-20 Thread Dmitry Baryshkov
On Wed, May 15, 2024 at 05:26:52PM -0700, Randy Dunlap wrote: > Add @width and @height descriptions for &struct drm_plane_size_hint > along with a reference to more info. > > Add a short description for &struct drm_mode_closefb. > > Change 7 macros not to be marked as kernel-doc notation to preve

Re: [PATCH v4 14/16] arm64: defconfig: enable mt8365 sound

2024-05-20 Thread AngeloGioacchino Del Regno
Il 26/04/24 19:22, Alexandre Mergnat ha scritto: Enable the MediaTek MT8365-EVK sound support. The audio feature is handled by the MT8365 SoC and the MT6357 PMIC codec audio. Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: > zlib.net is not allowing tarball download anymore and results > in below error in kernel+rootfs_arm32 container build, > urllib.error.HTTPError: HTTP Error 403: Forbidden > urllib.error.HTTPError: HTTP Error 415: Unsupported Media Typ

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread AngeloGioacchino Del Regno
Il 19/05/24 19:18, Alexandre Mergnat ha scritto: Hi Angelo, On 16/05/2024 10:11, AngeloGioacchino Del Regno wrote: +    oneOf: +  - required: +  - endpoint@0 +  - required: +  - endpoint@1 +  - required: +  - endpoint@2 I'm not sure this is what you expect

Re: [PATCH v2 2/6] drm/ci: generate testlist from build

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:58PM +0530, Vignesh Raman wrote: > Stop vendoring the testlist into the kernel. Instead, use the > testlist from the IGT build to ensure we do not miss renamed > or newly added tests. > > Signed-off-by: Vignesh Raman > --- > > v2: > - Fix testlist generation for a

Re: [PATCH v2 3/6] drm/ci: build virtual GPU driver as module

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:59PM +0530, Vignesh Raman wrote: > With latest IGT, the tests tries to load the module and it > fails. So build the virtual GPU driver for virtio as module. Why? If the test fails on module loading (if the driver is built-in) then it's the test that needs to be fixed,

Re: [PATCH v2 4/6] drm/ci: uprev IGT

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:55:00PM +0530, Vignesh Raman wrote: > test-list.txt and test-list-full.txt are not generated for > cross-builds and they are required by drm-ci for testing > arm32 targets. > > This is fixed in igt-gpu-tools. So uprev IGT to include the > commit which fixes this issue. D

Re: [PATCH v2 5/6] drm/ci: skip driver specific tests

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:55:01PM +0530, Vignesh Raman wrote: > Skip driver specific tests and skip kms tests for > panfrost driver since it is not a kms driver. > > Signed-off-by: Vignesh Raman > --- I didn't perform a through check, but generally looks good. Reviewed-by: Dmitry Baryshkov -

[PATCH v5 0/6] Link off between frames for edp

2024-05-20 Thread Animesh Manna
Link Off Between Active Frames (LOBF) allows an eDP link to be turned Off and On durning long VBLANK durations without enabling any of the PSR/PSR2/PR modes of operation. Bspec: 71477 Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise af

[PATCH v5 1/6] drm/i915/alpm: Move alpm parameters from intel_psr

2024-05-20 Thread Animesh Manna
ALPM can be enabled for non psr panel and currenly aplm-params are encapsulated under intel_psr struct, so moving out to intel_dp struct. Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 21 + drivers/gpu/drm/i915/display/intel_psr.c | 44 +---

[PATCH v5 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-05-20 Thread Animesh Manna
Move ALPM feature related code as it will be used for non-psr panel also thorugh LOBF feature. v1: Initial version. v2: Correct ordering in makefile. [Jani] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_alpm.c | 295 ++

[PATCH v5 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-20 Thread Animesh Manna
Link Off Between Active Frames, is a new feature for eDP that allows the panel to go to lower power state after transmission of data. This is a feature on top of ALPM, AS SDP. Add compute config during atomic-check phase. v1: RFC version. v2: Add separate flag for auxless-alpm. [Jani] v3: - intel_

[PATCH v5 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-20 Thread Animesh Manna
From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display

[PATCH v5 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-20 Thread Animesh Manna
For validation purpose add debugfs for LOBF. v1: Initial version. v2: Add aux-wake/less info along with lobf status. [Jouni] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++ drivers/gpu/drm/i915/display/intel_alpm.h | 2 + .../drm/i91

[PATCH v5 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-05-20 Thread Animesh Manna
Set the Link Off Between Frames Enable bit in ALPM_CTL register. Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise after cmmr feature enablement. Will add enabling sequence in a separate patch. v1: Initial version. v2: Condition check mo

Re: [PATCH v2 6/6] drm/ci: update xfails for the new testlist

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:55:02PM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Set the timeout of all i915 jobs to 1h30m since some jobs > takes more than 1 hour to complete. > > Signed-off-by: Vignesh Raman > --- > > v2:

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Sui Jingfeng
Hi, On 5/20/24 06:11, Dmitry Baryshkov wrote: On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") fails to consider the case where adv7511->i2c_main->irq is zero, i.e., no interrupt requested at all. Without interr

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > Hi, > > On 5/20/24 06:11, Dmitry Baryshkov wrote: > > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > >> fails to consider the case where adv7511->i2c_ma

[PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the current resident buffer object memory (including shared). To prevent any confusion, document that drm-memo

[PATCH 2/2] drm/amdgpu: Use drm_print_memory_stats helper from fdinfo

2024-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo memory stats to use the common drm_print_memory_stats helper. This achieves alignment with the common keys as documented in drm-usage-stats.rst, adding specifically drm-total- key the driver was missing until now. Additionally I made the code stop skipping to

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Daniel Stone
Hi, On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > > If we expose a render node for NPUs without rendering capabilities, the > > > userspace stack will offer it to co

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
Hi Andy, Daniel, On 18/05/24 01:44, Andy Shevchenko wrote: > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [..] > >> [devarsht: Rebase to 6.9 and change license to GPL] > > I'm not sure that you may change license. It needs the author's confirmation. > As per latest licensin

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Sui Jingfeng
Hi, On 5/20/24 19:13, Dmitry Baryshkov wrote: On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: Hi, On 5/20/24 06:11, Dmitry Baryshkov wrote: On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") fails to consid

Re: DRM Accel BoF at Linux Plumbers

2024-05-20 Thread Laurent Pinchart
Hi Tomeu, On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote: > Hi, > > I would like to use the chance at the next Plumbers to discuss the > present challenges related to ML accelerators in mainline. > > I'm myself more oriented towards edge-oriented deployments, and don't > know enoug

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I think this should be anyOf instead :-) I'll check later and send a v5. "anyOf" behavior works as expected on

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread AngeloGioacchino Del Regno
Il 20/05/24 13:49, Alexandre Mergnat ha scritto: On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I think this should be anyOf instead :-) I'll check later and s

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > Hi, > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > >> > >> Hi, > >> > >> On 5/20/24 06:11, Dmitry Baryshkov wrote: > >>> On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: >

Re: [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges")

2024-05-20 Thread Luca Ceresoli
Hello Daniel, On Thu, 16 May 2024 15:22:01 +0200 Daniel Vetter wrote: > Apologies for missing v1 ... > > On Fri, May 10, 2024 at 09:10:36AM +0200, Luca Ceresoli wrote: > > DRM hotplug bridge driver > > = > > > > DRM natively supports pipelines whose display can be remov

Re: [PATCH v5 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC version. > v2:

[PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-20 Thread Dmitry Baryshkov
Command mode panels provide TE signal back to the DSI host to signal that the frame display has completed and update of the image will not cause tearing. Usually it is connected to the first GPIO with the mdp_vsync function, which is the default. In such case the property can be skipped. Signed-of

[PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-20 Thread Dmitry Baryshkov
Command-mode DSI panels need to signal the display controlller when vsync happens, so that the device can start sending the next frame. Some devices (Google Pixel 3) use a non-default pin, so additional configuration is required. Add a way to specify this information in DT and handle it in the DSI

[PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-20 Thread Dmitry Baryshkov
Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 2 +- dr

[PATCH 6/7] drm/msm/dsi: parse vsync source from device tree

2024-05-20 Thread Dmitry Baryshkov
Allow board's device tree to specify the vsync source (aka TE source). If the property is omitted, the display controller driver will use the default setting. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c| 11 +++

[PATCH 7/7] drm/msm/dpu: support setting the TE source

2024-05-20 Thread Dmitry Baryshkov
Make the DPU driver use the TE source specified in the DT. If none is specified, the driver defaults to the first GPIO (mdp_vsync0). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-)

[PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling

2024-05-20 Thread Dmitry Baryshkov
Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 - 1 file changed, 37 deletions(-) di

[PATCH 5/7] drm/msm/dpu: rework vsync_source handling

2024-05-20 Thread Dmitry Baryshkov
The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu

[PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-05-20 Thread Dmitry Baryshkov
Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [PATCH v5 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > v1: Initial version. > v2: Add aux-wake/less info along with lobf status. [Jouni] > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++ > driver

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Andy Shevchenko
On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: > On 18/05/24 01:44, Andy Shevchenko wrote: > > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [..] > >> +#include > >> +#include > > > >> +#include > > > > Do you know why this header is included? > > It inc

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Jani Nikula
On Sun, 19 May 2024, Dmitry Baryshkov wrote: > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Simplify the flow by updating the EDID property when the EDID is read >> instead of a

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 15:25, Jani Nikula wrote: > > On Sun, 19 May 2024, Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > >> Prefer the struct drm_edid based functions for reading the EDID and > >> updating the connector. > >> > >> Simplify the flow by u

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Adam Ford
On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > > > Hi, > > > > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > >> > > >> Hi, > > >> > > >> On 5/20/24 06:11, Dmitry Baryshk

[PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread linux
From: "Dr. David Alan Gilbert" commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") has dropped all the users of the struct bridge_init from the exynos_dp_core, while retaining unused structure definition. Later on the driver was reworked and the definition migrated to the ana

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dr. David Alan Gilbert
* Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > > On Sat, May 18, 2024 at 12:24:27AM +0100, li...@treblig.org wrote: > > > > From: "Dr. David Alan Gilber

Re: [PATCH 10/11] drm/imx/tve: convert to struct drm_edid

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Dmitry Baryshkov wrote: > On Tue, May 14, 2024 at 03:55:16PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Signed-off-by: Jani Nikula >> >> --- >> >> Cc: Philipp Zabel >> Cc: Maarten Lankh

Re: [RESEND v7 00/37] Device Tree support for SH7751 based board

2024-05-20 Thread Yoshinori Sato
On Sat, 18 May 2024 18:08:30 +0900, John Paul Adrian Glaubitz wrote: > > Hi Yoshinori, > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > Sorry. previus mail is thread broken. > > > > This is an updated version of something I wrote about 7 years ago. > > Minimum support for R2D-plu

Re: [PATCH v11] drm/bridge: it6505: fix hibernate to resume no display issue

2024-05-20 Thread Markus Elfring
> … This patch has been implemented to prevent … Under which circumstances will imperative wordings be applied for another improved change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94 Regards, Markus

[Bug 218864] HP Envy x360: Graphical corruption over time without amdgpu.sg_display=0 kernel option

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218864 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Component|BIOS|Vide

[Bug 218864] HP Envy x360: Graphical corruption over time without amdgpu.sg_display=0 kernel option

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218864 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Hardware|All |AMD

[Bug 217607] null pointer dereference with NVIDIA installer on 5.15.118 and 5.15.119

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217607 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Status|NEW |RESOLVED Re

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
On 20/05/24 17:52, Andy Shevchenko wrote: > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: >> On 18/05/24 01:44, Andy Shevchenko wrote: >>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: > > [..] > [..] > Yes, and one should follow IWYU principle and not cargo

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Andy Shevchenko
On Mon, May 20, 2024 at 07:51:24PM +0530, Devarsh Thakkar wrote: > On 20/05/24 17:52, Andy Shevchenko wrote: > > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: > >> On 18/05/24 01:44, Andy Shevchenko wrote: > >>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [.

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-05-20 Thread Sean Anderson
On 5/20/24 05:40, Christophe JAILLET wrote: > If zynqmp_dpsub_drm_init() fails, we must undo the previous > drm_bridge_add() call. > > Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") > Signed-off-by: Christophe JAILLET > --- > Compile tested only > --- > drivers/gpu/drm/xlnx/zy

Re: [PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-20 Thread Alex Deucher
On Fri, May 17, 2024 at 4:42 AM Yang Li wrote: > > This patch updates the function documentation comment for > optc35_set_odm_combine to conform to the kernel-doc specification. > > Signed-off-by: Yang Li Thanks for the patch. Srini already fixed this last week. Alex > --- > drivers/gpu/drm/

Re: [PATCH 3/3] drm/amd/display: remove unused struct 'dc_reg_sequence'

2024-05-20 Thread Alex Deucher
Applied the series. Thanks! Alex On Fri, May 17, 2024 at 8:12 PM wrote: > > From: "Dr. David Alan Gilbert" > > 'dc_reg_sequence' was added in > commit 44788bbc309b ("drm/amd/display: refactor reg_update") > > but isn't actually used. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert >

Re: [PATCH] drm/komeda: remove unused struct 'gamma_curve_segment'

2024-05-20 Thread Liviu Dudau
On Thu, May 16, 2024 at 02:37:24PM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > 'gamma_curve_segment' looks like it has never been used. > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Liviu Dudau Thanks for the clean up! Best regards, Liviu > --- >

Re: [RESEND v7 00/37] Device Tree support for SH7751 based board

2024-05-20 Thread John Paul Adrian Glaubitz
Hi Yoshinori, On Mon, 2024-05-20 at 22:06 +0900, Yoshinori Sato wrote: > On Sat, 18 May 2024 18:08:30 +0900, > John Paul Adrian Glaubitz wrote: > > > > Hi Yoshinori, > > > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > > Sorry. previus mail is thread broken. > > > > > > This is

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
On 20/05/2024 13:55, AngeloGioacchino Del Regno wrote: Il 20/05/24 13:49, Alexandre Mergnat ha scritto: On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I thi

Re: [PATCH v4 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat Tested-by: Alexandre Mergnat On 16/05/2024 10:11, AngeloGioacchino Del Regno wrote: The display IPs in MediaTek SoCs support being interconnected with different instances of DDP IPs (for example, merge0 or merge1) and/or with different DDP IPs (for example, rdma

Re: [PATCH v4 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat Tested-by: Alexandre Mergnat On 16/05/2024 10:11, AngeloGioacchino Del Regno wrote: It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for 1

Re: [PATCH v2 1/5] dt-bindings: display: panel: mipi-dbi-spi: Add a pixel format property

2024-05-20 Thread Rob Herring (Arm)
On Sun, 12 May 2024 17:25:38 +0200, Noralf Trønnes wrote: > The MIPI DBI 2.0 specification (2005) lists only two pixel formats for > the Type C Interface (SPI) and that is 3-bits/pixel RGB111 with > 2 options for bit layout. > > For Type A and B (parallel) the following formats are listed: RGB33

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Doug Anderson
Hi, On Sun, May 19, 2024 at 2:01 AM Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > > Prefer the struct drm_edid based functions for reading the EDID and > > updating the connector. > > > > Simplify the flow by updating the EDID property when the EDID is

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-20 Thread Alex Deucher
On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote: > > Am 17.05.24 um 03:30 schrieb Barry Kauler: > > > Armin, Yifan, Prike, > > I will top-post, so you don't have to scroll down. > > After identifying the commit that causes black screen with my gpu, I > > posted the result to you guys, on May 9. >

[linux-next:master] BUILD REGRESSION 632483ea8004edfadd035de36e1ab2c7c4f53158

2024-05-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 632483ea8004edfadd035de36e1ab2c7c4f53158 Add linux-next specific files for 20240520 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202405202243.shvs2otq-...@intel.com https

[RFC PATCH 0/8] [RFC] DRM Rust abstractions and Nova

2024-05-20 Thread Danilo Krummrich
This patch series implements some basic DRM Rust abstractions and a stub implementation of the Nova GPU driver. Nova is intended to be developed upstream, starting out with just a stub driver to lift some initial required infrastructure upstream. A more detailed explanation can be found in [1]. T

[RFC PATCH 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the abstractio

[RFC PATCH 2/8] rust: Add a Sealed trait

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina Some traits exposed by the kernel crate may not be intended to be implemented by downstream modules. Add a Sealed trait to allow avoiding this using the sealed trait pattern. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/kernel/lib.rs | 5 + 1 file ch

[RFC PATCH 3/8] rust: drm: Add Device and Driver abstractions

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina Add abstractions for DRM drivers and devices. These go together in one commit since both are fairly tightly coupled types. A few things have been stubbed out, to be implemented as further bits of the DRM subsystem are introduced. Signed-off-by: Asahi Lina Co-developed-by: Dani

[RFC PATCH 4/8] rust: drm: implement `AsRef` for DRM device

2024-05-20 Thread Danilo Krummrich
Implement `AsRef` for `drm::device::Device` such that `dev_*` print macros can be used conveniently. Signed-off-by: Danilo Krummrich --- rust/kernel/drm/device.rs | 8 1 file changed, 8 insertions(+) diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index f72bab8dd42d.

[RFC PATCH 4/8] rust: drm: implement `AsRef` for DRM device

2024-05-20 Thread Danilo Krummrich
Implement `AsRef` for `drm::device::Device` such that `dev_*` print macros can be used conveniently. Signed-off-by: Danilo Krummrich --- rust/kernel/drm/device.rs | 8 1 file changed, 8 insertions(+) diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index f72bab8dd42d.

[RFC PATCH 5/8] rust: drm: file: Add File abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[RFC PATCH 6/8] rust: drm: gem: Add GEM object abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina The DRM GEM subsystem is the DRM memory management subsystem used by most modern drivers. Add a Rust abstraction to allow Rust DRM driver implementations to use it. Signed-off-by: Asahi Lina Co-developed-by: Danilo Krummrich Signed-off-by: Danilo Krummrich --- rust/bindings/

[RFC PATCH 7/8] rust: add firmware abstractions

2024-05-20 Thread Danilo Krummrich
Add an abstraction around the kernels firmware API to request firmware images. The abstraction provides functions to access the firmware buffer and / or copy it to a new buffer allocated with a given allocator backend. The firmware is released once the abstraction is dropped. Signed-off-by: Danil

[RFC PATCH 8/8] nova: add initial driver stub

2024-05-20 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to bui

Re: Device / Driver and PCI Rust abstractions

2024-05-20 Thread Danilo Krummrich
https://lore.kernel.org/rust-for-linux/20240520172554.182094-1-d...@redhat.com/

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-20 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

  1   2   >