Re: [PATCH 01/20] drm/drm_managed: try to improve the drmm DOC

2024-05-13 Thread Andrzej Hajda
On 10.05.2024 20:12, Matthew Auld wrote: Hopefully make it clearer when to use devm vs drmm. Signed-off-by: Matthew Auld Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_managed.c | 42 +++ 1 file changed, 42 insertions(+) diff -

Re: [PATCH v6 07/17] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-05-13 Thread Louis Chauvet
Le 22/04/24 - 14:07, Pekka Paalanen a écrit : > On Tue, 09 Apr 2024 15:25:25 +0200 > Louis Chauvet wrote: > > > Introduce the usage of block_h/block_w to compute the offset and the > > pointer of a pixel. The previous implementation was specialized for > > planes with block_h == block_w == 1. To

Re: [PATCH v6 09/17] drm/vkms: Introduce pixel_read_direction enum

2024-05-13 Thread Louis Chauvet
[...] > > +/** > > + * direction_for_rotation() - Get the correct reading direction for a > > given rotation > > + * > > + * @rotation: Rotation to analyze. It correspond the field > > @frame_info.rotation. > > + * > > + * This function will use the @rotation setting of a source plane to > > co

Re: [PATCH] drm/i915: Correct error handler

2024-05-13 Thread Nirmoy Das
On 5/11/2024 5:48 PM, Jiasheng Jiang wrote: Replace "slab_priorities" with "slab_dependencies" in the error handler to avoid memory leak. Nice catch. I would make the subject more like: drm/i915: Fix memory leak by correcting cache object name in error handler Fixes: 32eb6bcfdda9 ("drm/i

Re: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-13 Thread Hogander, Jouni
On Thu, 2024-05-09 at 11:01 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: /sys/kernel/debug/vgaswitcheroo directory missing

2024-05-13 Thread Jani Nikula
On Sat, 11 May 2024, Chris Clayton wrote: > Mmm, I see a patch has made it's way to mainline and can confirm that > it fixes the problems I tbothered you with in this thread. Which patch? Might be interesting for posterity. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH] drm: use "0" instead of "" for deprecated driver date

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Ville Syrjälä wrote: > On Fri, May 10, 2024 at 08:33:59PM +0300, Ville Syrjälä wrote: >> On Fri, May 10, 2024 at 12:09:51PM +0300, Jani Nikula wrote: >> > libdrm does not like the empty string for driver date. Use "0" instead, >> > which has been used by virtio previously. >>

[PATCH v7 00/17] drm/vkms: Reimplement line-per-line pixel conversion for plane reading

2024-05-13 Thread Louis Chauvet
This patchset is the second version of [1]. It is almost a complete rewrite to use a line-by-line algorithm for the composition. During the development of this series Pekka and Arthur found an issue in drm core. The YUV part of this series depend on the fix [9]. I'll let Arthur extract it and subm

[PATCH v7 03/17] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-05-13 Thread Louis Chauvet
Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Signed-off-by: Louis Chauvet Acked-by: Pekka Paalanen --- drivers/gpu/drm/vkms/vkms_composer.c | 7 drivers/gpu/drm/vkms/vkms_drv.h | 15 - drivers/gpu/drm/vkms/vkms_f

[PATCH v7 02/17] drm/vkms: Use drm_frame directly

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo Remove intermidiary variables and access the variables directly from drm_frame. These changes should be noop. Signed-off-by: Arthur Grillo Acked-by: Pekka Paalanen Reviewed-by: Maíra Canal Reviewed-by: Louis Chauvet [Louis Chauvet: Applied review from Maíra] Signed-off-by

[PATCH v7 01/17] drm/vkms: Code formatting

2024-05-13 Thread Louis Chauvet
Few no-op changes to remove double spaces and fix wrong alignments. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 10 +- drivers/gpu/drm/vkms/vkms_crtc.c | 6 ++ drivers/gpu/drm/vkms/vkms_drv.c

[PATCH v7 04/17] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-05-13 Thread Louis Chauvet
Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the compiler to check if the passed functions take the correct arguments. Such typedefs will help ensuring consistency across the code base in case of update of these prototypes. Rename input/output variable in a consistent way betw

[PATCH v7 05/17] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-05-13 Thread Louis Chauvet
Introduce two callbacks which does nothing. They are used in replacement of NULL and it avoid kernel OOPS if this NULL is called. If those callback are used, it means that there is a mismatch between what formats are announced by atomic_check and what is realy supported by atomic_update. Acked-by

[PATCH v7 07/17] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-05-13 Thread Louis Chauvet
Introduce the usage of block_h/block_w to compute the offset and the pointer of a pixel. The previous implementation was specialized for planes with block_h == block_w == 1. To avoid confusion and allow easier implementation of tiled formats. It also remove the usage of the deprecated format field

[PATCH v7 08/17] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-05-13 Thread Louis Chauvet
The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing different concepts (coordinate calculation and color management), extract the x_limit and x_dst computation outside of this helper. It also increases the maintainability by grouping the computation related to coordinates in the sa

[PATCH v7 11/17] drm/vkms: Remove useless drm_rotation_simplify

2024-05-13 Thread Louis Chauvet
As all the rotation are now supported by VKMS, this simplification does not make sense anymore, so remove it. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/

[PATCH v7 06/17] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-05-13 Thread Louis Chauvet
As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Reviewed-by: Pekka Paalanen Reviewed-by: Maíra Canal Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- drivers/gpu/drm/vkms/vkms_formats.c | 24

[PATCH v7 09/17] drm/vkms: Introduce pixel_read_direction enum

2024-05-13 Thread Louis Chauvet
The pixel_read_direction enum is useful to describe the reading direction in a plane. It avoids using the rotation property of DRM, which not practical to know the direction of reading. This patch also introduce two helpers, one to compute the pixel_read_direction from the DRM rotation property, an

[PATCH v7 10/17] drm/vkms: Re-introduce line-per-line composition algorithm

2024-05-13 Thread Louis Chauvet
Re-introduce a line-by-line composition algorithm for each pixel format. This allows more performance by not requiring an indirection per pixel read. This patch is focused on readability of the code. Line-by-line composition was introduced by [1] but rewritten back to pixel-by-pixel algorithm in [

[PATCH v7 12/17] drm/vkms: Add YUV support

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo Add support to the YUV formats bellow: - NV12/NV16/NV24 - NV21/NV61/NV42 - YUV420/YUV422/YUV444 - YVU420/YVU422/YVU444 The conversion from yuv to rgb is done with fixed-point arithmetic, using 32.32 fixed-point numbers and the drm_fixed helpers. To do the conversion, a spec

[PATCH v7 13/17] drm/vkms: Add range and encoding properties to the plane

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo Now that the driver internally handles these quantization ranges and YUV encoding matrices, expose the UAPI for setting them. Signed-off-by: Arthur Grillo [Louis Chauvet: retained only relevant parts, updated the commit message] Acked-by: Pekka Paalanen Signed-off-by: Louis

[PATCH v7 14/17] drm/vkms: Drop YUV formats TODO

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo VKMS has support for YUV formats now. Remove the task from the TODO list. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentati

[PATCH v7 17/17] drm/vkms: Add support for DRM_FORMAT_R*

2024-05-13 Thread Louis Chauvet
This add the support for: - R1/R2/R4/R8 R1 format was tested with [1] and [2]. [1]: https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5ca...@bootlin.com [2]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd...@bootlin.com/ Reviewed-by: Pekka Paalanen Signed-off-by

[PATCH v7 16/17] drm/vkms: Add how to run the Kunit tests

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo Now that we have KUnit tests, add instructions on how to run them. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.

[PATCH v7 15/17] drm/vkms: Create KUnit tests for YUV conversions

2024-05-13 Thread Louis Chauvet
From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor formating issues (whitespace, double line) - c

[PATCH] drm/bridge: adv7511: Attach next bridge without creating connector

2024-05-13 Thread Liu Ying
The connector is created by either this ADV7511 bridge driver or any DRM device driver/previous bridge driver, so this ADV7511 bridge driver should not let the next bridge driver create connector. If the next bridge is a HDMI connector, the next bridge driver would fail to attach bridge from displ

Re: [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach

2024-05-13 Thread Marek Szyprowski
On 13.05.2024 04:16, Marek Vasut wrote: > Initialize the bridge on attach already, to force lanes into LP11 > state, since attach does trigger attach of downstream bridges which > may trigger (e)DP AUX channel mode read. > > This fixes a corner case where DSIM with TC9595 attached to it fails > t

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2024-05-13 Thread José Expósito
On Fri, May 10, 2024 at 06:19:45PM +0200, Louis Chauvet wrote: > Le 09/05/24 - 18:18, Jim Shargo a écrit : > > Sima--thanks SO MUCH for going through with everything leaving a > > detailed review. I am excited to go through your feedback. > > > > It makes me extremely happy to see these patches ge

[RESEND PATCH v4 0/2] Add StarFive JH7110 SoC DSI support

2024-05-13 Thread Shengyang Chen
This series is the series that attempts to support the CDNS DSI driver used to converts DPI to DSI. CDNS DSI is embedded in StarFive JH7110 SoC. The series has been tested on the VisionFive 2 board. change since v3: - Rebased on tag v6.8-rc6. patch 2: - Replace clk API with clk_bulk_ API. - Repl

[PATCH v4 1/2] dt-bindings: display: bridge: cdns: Add display bridge support for dsi on StarFive JH7110 SoC

2024-05-13 Thread Shengyang Chen
From: Keith Zhao Add compatible to support dsi bridge on StarFive JH7110 SoC Signed-off-by: Keith Zhao Signed-off-by: Shengyang Chen Reviewed-by: Conor Dooley --- .../bindings/display/bridge/cdns,dsi.yaml | 56 ++- 1 file changed, 54 insertions(+), 2 deletions(-) diff --

[PATCH v4 2/2] drm/bridge: cdns-dsi: Add support for StarFive JH7110 SoC

2024-05-13 Thread Shengyang Chen
From: Keith Zhao Add display bridge support for dsi on StarFive JH7110 SoC. The mainly modification is followed: 1.Add extra clock and reset operation for JH7110. 2.Add callback for JH7110. Signed-off-by: Keith Zhao Signed-off-by: Shengyang Chen --- drivers/gpu/drm/bridge/cadence/Kco

Re: [PATCH v2 2/2] drm/tests: Add a unit test for range bias allocation

2024-05-13 Thread Matthew Auld
On 12/05/2024 08:59, Arunpravin Paneer Selvam wrote: Allocate cleared blocks in the bias range when the DRM buddy's clear avail is zero. This will validate the bias range allocation in scenarios like system boot when no cleared blocks are available and exercise the fallback path too. The resultin

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Maxime Ripard
On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > Hi, > > > > Le mardi 07 mai 2024 à 21:36 +0300, Laurent Pinchart a écrit : > > > Shorter term, we have a problem to solve, and the best option we have > > > found

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Laurent Pinchart
On Mon, May 13, 2024 at 10:29:22AM +0200, Maxime Ripard wrote: > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > > Hi, > > > > > > Le mardi 07 mai 2024 à 21:36 +0300, Laurent Pinchart a écrit : > > > > Shorter

Re: [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2024-05-13 Thread Aradhya Bhatia
Hi Laurent, Thank you for reviewing the patches! On 13-May-24 01:04, Laurent Pinchart wrote: > Hi Aradhya, > > Thank you for the patch. > > On Sun, May 12, 2024 at 01:00:53AM +0530, Aradhya Bhatia wrote: >> Add devicetree binding schema for AM625 OLDI Transmitters. >> >> Signed-off-by: Aradhya

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Maxime Ripard
On Tue, May 07, 2024 at 10:59:42PM +0300, Dmitry Baryshkov wrote: > On Tue, 7 May 2024 at 21:40, Laurent Pinchart > wrote: > > > > On Tue, May 07, 2024 at 06:19:18PM +0300, Dmitry Baryshkov wrote: > > > On Tue, 7 May 2024 at 18:15, Bryan O'Donoghue wrote: > > > > On 07/05/2024 16:09, Dmitry Barysh

Re: [PATCH v2] docs: document python version used for compilation

2024-05-13 Thread Jon Hunter
On 12/05/2024 00:52, Abhinav Kumar wrote: On 5/11/2024 3:32 PM, Dmitry Baryshkov wrote: The drm/msm driver had adopted using Python3 script to generate register header files instead of shipping pre-generated header files. Document the minimal Python version supported by the script. Per reque

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Andy Shevchenko
On Sun, May 12, 2024 at 07:46:58AM +0300, Alexey Dobriyan wrote: > I think > > roundup(x, 1 << n) Since it's about power-of-two, round_up() is better. > is more readable. -- With Best Regards, Andy Shevchenko

Re: [PATCH v10 05/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-05-13 Thread Hogander, Jouni
Hello Maintainers, Could you please ack this patch? I'm planning to merge it via drm-intel tree. BR, Jouni Högander On Fri, 2024-05-10 at 13:26 +0300, Jouni Högander wrote: > Add definitions for panel replay selective update > > v2: Remove unnecessary Cc from commit message > > Signed-off-by:

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Andy Shevchenko
On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: > On 10/05/24 20:45, Jani Nikula wrote: [...] > > Moreover, I think the naming of round_up() and round_down() should have > > reflected the fact that they operate on powers of 2. It's unfortunate > > that the difference to roundup()

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2024-05-13 Thread Marius Vlad
Hi all, On Mon, May 13, 2024 at 10:08:38AM +0200, José Expósito wrote: > On Fri, May 10, 2024 at 06:19:45PM +0200, Louis Chauvet wrote: > > Le 09/05/24 - 18:18, Jim Shargo a écrit : > > > Sima--thanks SO MUCH for going through with everything leaving a > > > detailed review. I am excited to go thro

Re: [PATCH] nouveau/firmware: using dma non-coherent interfaces for fw loading.

2024-05-13 Thread kernel test robot
Hi Dave, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.9 next-20240513] [cannot apply to drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v4 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-13 Thread Maxime Ripard
Hi, On Wed, May 08, 2024 at 01:51:46PM -0700, Douglas Anderson wrote: > Through a cooperative effort between Hsin-Yi Wang and Dmitry > Baryshkov, we have realized the dev_err() in the > mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the > kernel. Let's hoist this call into drm_m

RE: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

2024-05-13 Thread Johan Adolfsson
>-Original Message- >From: Krzysztof Kozlowski >Sent: den 22 april 2024 22:57 >To: Johan Adolfsson ; Neil Armstrong >; Jessica Zhang ; Sam >Ravnborg ; Maarten Lankhorst >; Maxime Ripard ; >Thomas Zimmermann ; David Airlie ; >Daniel Vetter ; Rob Herring ; Krzysztof >Kozlowski ; Con

Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

2024-05-13 Thread Krzysztof Kozlowski
On 13/05/2024 11:34, Johan Adolfsson wrote: > > >> -Original Message- >> From: Krzysztof Kozlowski >> Sent: den 22 april 2024 22:57 >> To: Johan Adolfsson ; Neil Armstrong >> ; Jessica Zhang ; Sam >> Ravnborg ; Maarten Lankhorst >> ; Maxime Ripard ; >> Thomas Zimmermann ; David Airl

Re: [PATCH 02/12] accel/ivpu: Add sched_mode module param

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 10.05.2024 18:30, Jeffrey Hugo wrote: > On 5/8/2024 7:20 AM, Jacek Lawrynowicz wrote: >> From: "Wachowski, Karol" >> >> This param will be used to enable/disable HWS (hardware scheduler). >> The HWS is a FW side feature and may not be available on all >> HW generations and FW versions. >>

Re: [PATCH 06/12] accel/ivpu: Implement support for hardware scheduler

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 10.05.2024 18:41, Jeffrey Hugo wrote: > On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote: >> +#define IVPU_FOCUS_PRESENT_TIMER_MS 1000 >> + >>   static char *ivpu_firmware; >>   module_param_named_unsafe(firmware, ivpu_firmware, charp, 0644); >>   MODULE_PARM_DESC(firmware, "NPU firmware binary

Re: [PATCH 07/12] accel/ivpu: Add resume engine support

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 10.05.2024 18:42, Jeffrey Hugo wrote: > On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote: >> From: "Wachowski, Karol" >> >> Create debugfs interface that triggers sending resume engine IPC >> command to VPU. > > Why?  Who would use this and for what purpose? This is used by our user space tes

Re: [PATCH 08/12] accel/ivpu: Add NPU profiling support

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 10.05.2024 18:46, Jeffrey Hugo wrote: > On 5/8/2024 7:21 AM, Jacek Lawrynowicz wrote: >> From: Tomasz Rusinowicz >> >> Implement time based Metric Streamer profiling UAPI. >> >> This is a generic mechanism allowing user mode tools to sample >> NPU metrics. These metrics are defined by the

Re: [PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 10.05.2024 18:55, Jeffrey Hugo wrote: > On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote: >> From: Tomasz Rusinowicz >> >> The driver tracks the time spent by NPU executing jobs >> and shares it through sysfs `npu_busy_time_us` file. >> It can be then used by user space applications to monitor

Re: [PATCH v3 09/10] media: dt-bindings: Add Intel Displayport RX IP

2024-05-13 Thread Paweł Anikiel
On Fri, May 10, 2024 at 11:24 PM Rob Herring wrote: > > On Tue, May 07, 2024 at 03:54:12PM +, Paweł Anikiel wrote: > > Add dt binding for the Intel Displayport receiver FPGA IP. > > It is a part of the DisplayPort Intel FPGA IP Core, and supports > > DisplayPort 1.4, HBR3 video capture and Mul

Re: [PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs

2024-05-13 Thread Tvrtko Ursulin
On 13/05/2024 11:22, Jacek Lawrynowicz wrote: Hi, On 10.05.2024 18:55, Jeffrey Hugo wrote: On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote: From: Tomasz Rusinowicz The driver tracks the time spent by NPU executing jobs and shares it through sysfs `npu_busy_time_us` file. It can be then used b

[PATCH] drm/i915/fbc: Add sizes to info message about reducing fb size

2024-05-13 Thread Paul Menzel
The info message currently does not contain any information, how much the stolen memory size should be increased. [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS. To be more

Re: [PATCH v3 05/10] media: dt-bindings: video-interfaces: Support DisplayPort MST

2024-05-13 Thread Paweł Anikiel
On Fri, May 10, 2024 at 11:16 PM Rob Herring wrote: > > On Tue, May 07, 2024 at 03:54:08PM +, Paweł Anikiel wrote: > > Add a DisplayPort bus type and a multi-stream-support property > > indicating whether the interface supports MST. > > > > Signed-off-by: Paweł Anikiel > > --- > > .../device

Re: [PATCH v6 07/17] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-05-13 Thread Pekka Paalanen
On Mon, 13 May 2024 09:15:13 +0200 Louis Chauvet wrote: > Le 22/04/24 - 14:07, Pekka Paalanen a écrit : > > On Tue, 09 Apr 2024 15:25:25 +0200 > > Louis Chauvet wrote: > > > > > Introduce the usage of block_h/block_w to compute the offset and the > > > pointer of a pixel. The previous impleme

RE: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-13 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Monday, May 13, 2024 1:02 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Murthy, Arun R > ; Nikula, Jani > Subject: Re: [PATCH v4 4/6] drm/i915/alpm: Add compute config for lobf >

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Devarsh Thakkar
Hi Andy, On 13/05/24 14:29, Andy Shevchenko wrote: > On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: >> On 10/05/24 20:45, Jani Nikula wrote: > > [...] > >>> Moreover, I think the naming of round_up() and round_down() should have >>> reflected the fact that they operate on power

Re: [Regression] 6.9.0: WARNING: workqueue: WQ_MEM_RECLAIM ttm:ttm_bo_delayed_delete [ttm] is flushing !WQ_MEM_RECLAIM events:qxl_gc_work [qxl]

2024-05-13 Thread Greg KH
On Wed, May 08, 2024 at 02:51:10PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 08.05.24 14:35, Anders Blomdell wrote: > > On 2024-05-07 07:04, Linux regression tracking (Thorsten Leemhuis) wrote: > >> On 06.05.24 16:30, David Wang wrote: > On 30.04.24 08:13, David Wang wr

Re: [PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs

2024-05-13 Thread Jacek Lawrynowicz
Hi, On 13.05.2024 12:45, Tvrtko Ursulin wrote: > > On 13/05/2024 11:22, Jacek Lawrynowicz wrote: >> Hi, >> >> On 10.05.2024 18:55, Jeffrey Hugo wrote: >>> On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote: From: Tomasz Rusinowicz The driver tracks the time spent by NPU executing jobs >

Re: [PATCH 0/4] drm/panthor: More reset fixes

2024-05-13 Thread Boris Brezillon
On Thu, 2 May 2024 20:38:08 +0200 Boris Brezillon wrote: > Hello, > > This is a collection of fixes for bugs found while chasing an > unrecoverable fault leading to a device unplug (because of some > other bugs that was introduced in my local dev branch). > > The first patch makes sure we imme

Re: [PATCH v4 0/5] drm/panthor: Collection of tiler heap related fixes

2024-05-13 Thread Boris Brezillon
On Thu, 2 May 2024 18:51:53 +0200 Boris Brezillon wrote: > This is a collection of tiler heap fixes for bugs/oddities found while > looking at incremental rendering. > > Ideally, we want to land those before 6.10 is released, so we don't need > to increment the driver version to reflect the ABI

[PATCH v2 00/12] accel/ivpu: Changes for 6.10

2024-05-13 Thread Jacek Lawrynowicz
There are couple of major new features in this patchset: * Hardware scheduler support (disabled by default) * Profiling support * Expose NPU busy time in sysfs Other then that, there are two small random fixes. v2: Included Jeffrey's v1 comments v1: https://lore.kernel.org/dri-devel/20240

[PATCH v2 01/12] accel/ivpu: Update VPU FW API headers

2024-05-13 Thread Jacek Lawrynowicz
Update JSM API to 3.16.0. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/vpu_jsm_api.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/accel/ivpu/vpu_jsm_api.h b/drivers/accel/ivpu/vpu_jsm_api.h index e46f3531211a..3

[PATCH v2 02/12] accel/ivpu: Add sched_mode module param

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" This param will be used to enable/disable HWS (hardware scheduler). The HWS is a FW side feature and may not be available on all HW generations and FW versions. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4

[PATCH v2 05/12] accel/ivpu: Add HWS JSM messages

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add JSM messages that will be used to implement hardware scheduler. Most of these messages are used to create and manage HWS specific command queues. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/ivp

[PATCH v2 04/12] accel/ivpu: Implement support for preemption buffers

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Allocate per-context preemption buffers that are required by HWS. There are two preemption buffers: * primary - allocated in user memory range (PIOVA accessible) * secondary - allocated in shave memory range Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawr

[PATCH v2 06/12] accel/ivpu: Implement support for hardware scheduler

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add support for HWS (hardware scheduler). It is disabled by default. The sched_mode module param can be used to enable it. Each context has multiple command queues with different priorities and HWS enables priority based execution on the HW/FW side. The driver in HWS mo

[PATCH v2 07/12] accel/ivpu: Add resume engine support

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Create debugfs interface that triggers sending resume engine IPC command to VPU. It is used to test engine resume functionality in driver user space tests. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 24

[PATCH v2 03/12] accel/ivpu: Create priority based command queues

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Create multiple command queues per engine with different priorities. The cmdqs are created on-demand and they support 4 priority levels. These priorities will later be used by the HWS (hardware scheduler). Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz

[PATCH v2 09/12] accel/ivpu: Add force snoop module parameter

2024-05-13 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add module parameter that enforces snooping for all NPU accesses, both through MMU PTEs mappings and through TCU page table walk override register bits for MMU page walks / configuration access. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz Reviewed-

[PATCH v2 08/12] accel/ivpu: Add NPU profiling support

2024-05-13 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Implement time based Metric Streamer profiling UAPI. This is a generic mechanism allowing user mode tools to sample NPU metrics. These metrics are defined by the FW and transparent to the driver. The user space can check for this feature by checking DRM_IVPU_CAP_METRIC_S

[PATCH v2 10/12] accel/ivpu: Configure fw logging using debugfs

2024-05-13 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Add fw_dyndbg file that can be used to control FW logging. Signed-off-by: Tomasz Rusinowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_de

[PATCH v2 12/12] accel/ivpu: Share NPU busy time in sysfs

2024-05-13 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz The driver tracks the time spent by NPU executing jobs and shares it through sysfs `npu_busy_time_us` file. It can be then used by user space applications to monitor device utilization. NPU is considered 'busy' starting with a first job submitted to firmware and ending wh

[PATCH v2 11/12] accel/ivpu: Increase reset counter when warm boot fails

2024-05-13 Thread Jacek Lawrynowicz
Failed warm boot causes a cold boot that looses FW state and is equivalent to a recovery or reset, so reset_counter should be incremented in order for this failure to be detected by tests. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/ivpu_pm.c | 1 + 1 file

Re: [RESEND 1/6] drm/nouveau: convert to using is_hdmi and has_audio from display info

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Lyude Paul wrote: > Reviewed-by: Lyude Paul Thanks, how do you want to handle merging this? BR, Jani. > > On Fri, 2024-05-10 at 18:08 +0300, Jani Nikula wrote: >> Prefer the parsed results for is_hdmi and has_audio in display info >> over >> calling drm_detect_hdmi_monito

[drm-misc:drm-misc-next 7/10] drivers/gpu/drm/omapdrm/omap_gem.c:757:42: sparse: sparse: cast truncates bits from constant value (10000 becomes 0)

2024-05-13 Thread kernel test robot
-20240513 (https://download.01.org/0day-ci/archive/20240513/202405132008.zkr6oycm-...@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240513/202405132008.zkr6oycm-...@intel.com/reproduce) If you fix the issue in a separate patch

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Jani Nikula
On Fri, 10 May 2024, Alex Deucher wrote: > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: >> >> I've sent this some moths ago, let's try again... >> >> BR, >> Jani. >> >> Jani Nikula (6): >> drm/nouveau: convert to using is_hdmi and has_audio from display info >> drm/radeon: convert to u

Re: [PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-05-13 Thread Adam Ford
On Tue, Apr 16, 2024 at 4:18 PM Adam Ford wrote: > > On Mon, Mar 4, 2024 at 6:49 PM Adam Ford wrote: > > > > The DSI to HDMI bridge supports hot-plut-detect, but the > > driver didn't previously support a shared IRQ GPIO. With > > the driver updated, the interrupt can be added to the bridge. > >

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Andy Shevchenko
On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote: > On 13/05/24 14:29, Andy Shevchenko wrote: > > On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: > >> On 10/05/24 20:45, Jani Nikula wrote: [...] > >>> Moreover, I think the naming of round_up() and round_down() shou

[PATCH 03/10] drm/mgag200: Store pointer to struct mga_device in struct mga_i2c_chan

2024-05-13 Thread Thomas Zimmermann
Avoid upcasting to struct mga_device in i2c code by storing the pointer directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 2 +- drivers/gpu/drm/mgag200/mgag200_i2c.c | 18 +- 2 files changed, 10 insertions(+), 10 deleti

[PATCH 10/10] drm/mgag200: Use drm_connector_helper_get_modes()

2024-05-13 Thread Thomas Zimmermann
Mgag200's .get_modes() function is identical to the common helper. Use the latter. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 4 +--- drivers/gpu/drm/mgag200/mgag200_mode.c | 17 - 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/

[PATCH 01/10] drm/mgag200: Set DDC timeout in milliseconds

2024-05-13 Thread Thomas Zimmermann
Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 milliseconds if HZ has been configured to a value of 1000. This corresponds to 2.2 milliseconds used by most other DRM drivers. Update mgag200 accordingly. Signed-off-by: Thomas Zimmermann F

[PATCH 07/10] drm/mgag200: Rename mgag200_i2c.c to mgag200_ddc.c

2024-05-13 Thread Thomas Zimmermann
Rename the source file according to its content. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile | 2 +- drivers/gpu/drm/mgag200/{mgag200_i2c.c => mgag200_ddc.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drive

[PATCH 05/10] drm/mgag200: Inline mgag200_i2c_init()

2024-05-13 Thread Thomas Zimmermann
The function mgag200_i2c_init() is an internal helper that sets up the i2c data structure. Inline its code into the only caller. Rearrange the individual steps to separate among i2c algorithm, adapter and fields in struct mga_i2c_chan. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200

[PATCH 02/10] drm/mgag200: Bind I2C lifetime to DRM device

2024-05-13 Thread Thomas Zimmermann
Managed cleanup with devm_add_action_or_reset() will release the I2C adapter when the underlying Linux device goes away. But the connector still refers to it, so this cleanup leaves behind a stale pointer in struct drm_connector.ddc. Bind the lifetime of the I2C adapter to the connector's lifetime

[PATCH 00/10] drm/mgag200: Refactor DDC code

2024-05-13 Thread Thomas Zimmermann
Clean up a the driver's DDC code, make it simpler, more robust, and mostly self contained. The patches in this patchset have previously been sent as part of rev 1 of [1]. Patches 1 and 2 fix long-standing problems in the DDC code. Patches 3 to 9 refactor the DDC code. The code then keeps its data

[PATCH 09/10] drm/mgag200: Acquire I/O-register lock in DDC code

2024-05-13 Thread Thomas Zimmermann
The modeset lock protects the DDC code from concurrent modeset operations, which use the same registers. Move that code from the connector helpers into the DDC helpers .pre_xfer() and .post_xfer(). Both, .pre_xfer() and .post_xfer(), enclose the transfer of data blocks over the I2C channel in the

[PATCH 08/10] drm/mgag200: Rename struct i2c_algo_bit_data callbacks

2024-05-13 Thread Thomas Zimmermann
Align the names of the algo-bit helpers with mgag200's convention of using an mgag200 prefix plus the struct's name plus the callback's name for such function symbols. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_ddc.c | 16 1 file changed, 8 insertions(+

[PATCH 06/10] drm/mgag200: Replace struct mga_i2c_chan with struct mgag200_ddc

2024-05-13 Thread Thomas Zimmermann
Rename struct mga_i2c_chan to struct mgag200_ddc, define it in the source file mgag200_i2c.c, and reorder its fields. Rename all related variables from i2c to ddc. Also rename the i2c adapter accordingly. Using the term 'ddc' documents the purpose of the code clearly. The old term 'i2c' could refe

[PATCH 04/10] drm/mgag200: Allocate instance of struct mga_i2c_chan dynamically

2024-05-13 Thread Thomas Zimmermann
Allocate instances of struct mga_i2c_chan in mgag200_ddc_create() and return a pointer to the contained i2c adapter. The callers of the function are now independent from struct mga_i2c_chan. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_ddc.h | 11 +++ drivers/

Re: [PATCH v2 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-13 Thread Neil Armstrong
On 09/05/2024 23:20, Dmitry Baryshkov wrote: Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Devarsh Thakkar
Hi Andy, On 13/05/24 17:55, Andy Shevchenko wrote: > On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote: >> On 13/05/24 14:29, Andy Shevchenko wrote: >>> On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: On 10/05/24 20:45, Jani Nikula wrote: > > [...] > - align na

Re: [PATCH v2 1/2] Add write DP phyd register from parse dts

2024-05-13 Thread AngeloGioacchino Del Regno
Il 10/05/24 13:04, Liankun Yang ha scritto: During the testing phase, screen flickering is observed when using displayport for screen casting. Relevant SSC register parameters are set in dts to address the screen flickering issue effectively and improve compatibility with different devices by adj

Re: [PATCH v7 6/8] math.h Add macros to round to closest specified power of 2

2024-05-13 Thread Andy Shevchenko
On Mon, May 13, 2024 at 06:34:19PM +0530, Devarsh Thakkar wrote: > On 13/05/24 17:55, Andy Shevchenko wrote: > > On Mon, May 13, 2024 at 04:55:58PM +0530, Devarsh Thakkar wrote: > >> On 13/05/24 14:29, Andy Shevchenko wrote: > >>> On Sat, May 11, 2024 at 11:11:14PM +0530, Devarsh Thakkar wrote: > >

Re: [PATCH 0/3] dt-bindings: display: panel: constrain 'reg'

2024-05-13 Thread Rob Herring
On Thu, May 09, 2024 at 11:42:50AM +0200, Krzysztof Kozlowski wrote: > Hi, > > Cleanups for display panel bindings. > > Rob, maybe you could take entire set if it applies? I based it on > linux-next, so letl me know if I need to rebase on your for-next. Applied. These 2 don't exist in my tree:

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 10:29 +0200, Maxime Ripard a écrit : > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > > Hi, > > > > > > Le mardi 07 mai 2024 à 21:36 +0300, Laurent Pinchart a écrit : > > > > Shorter te

Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-13 Thread AngeloGioacchino Del Regno
Il 13/05/24 08:15, CK Hu (胡俊光) ha scritto: On Fri, 2024-05-10 at 12:14 +0200, AngeloGioacchino Del Regno wrote: Il 10/05/24 11:34, CK Hu (胡俊光) ha scritto: On Thu, 2024-05-09 at 11:27 +0200, AngeloGioacchino Del Regno wrote: Il 09/05/24 07:42, CK Hu (胡俊光) ha scritto: On Wed, 2024-05-08 at 15:0

Re: [RFC PATCH 00/18] TTM interface for managing VRAM oversubscription

2024-05-13 Thread Friedrich Vock
Hi, On 02.05.24 16:23, Maarten Lankhorst wrote: Hey, [snip] For Xe, I've been loking at using cgroups. A small prototype is available at https://cgit.freedesktop.org/~mlankhorst/linux/log/?h=dumpcg To stimulate discussion, I've added amdgpu support as well. This should make it possible to is

Re: [RFC 0/5] Discussion around eviction improvements

2024-05-13 Thread Tvrtko Ursulin
On 09/05/2024 13:40, Tvrtko Ursulin wrote: On 08/05/2024 19:09, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Last few days I was looking at the situation with VRAM over subscription, what happens versus what perhaps should happen. Browsing through the driver and running some simple experim

Re: [PATCH v1 1/1] Support YUV422 for DPTX.

2024-05-13 Thread 杨连坤

  1   2   3   >