[PATCH v14 14/28] dept: Apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

2024-05-08 Thread Byungchul Park
Makes Dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 7725b7579b78..fe89282c3e96 100644 --- a/include/linux/wait_

[PATCH v14 26/28] fs/jbd2: Use a weaker annotation in journal handling

2024-05-08 Thread Byungchul Park
jbd2 journal handling code doesn't want jbd2_might_wait_for_commit() to be placed between start_this_handle() and stop_this_handle(). So it marks the region with rwsem_acquire_read() and rwsem_release(). However, the annotation is too strong for that purpose. We don't have to use more than try loc

[PATCH v14 09/28] dept: Add a mechanism to refill the internal memory pools on running out

2024-05-08 Thread Byungchul Park
Dept engine works in a constrained environment. For example, Dept cannot make use of dynamic allocation e.g. kmalloc(). So Dept has been using static pools to keep memory chunks Dept uses. However, Dept would barely work once any of the pools gets run out. So implemented a mechanism for the refill

[PATCH v14 10/28] dept: Record the latest one out of consecutive waits of the same class

2024-05-08 Thread Byungchul Park
The current code records all the waits for later use to track relation between waits and events in each context. However, since the same class is handled the same way, it'd be okay to record only one on behalf of the others if they all have the same class. Even though it's the ideal to search the

[PATCH v14 18/28] dept: Apply timeout consideration to swait

2024-05-08 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v14 03/28] dept: Add single event dependency tracker APIs

2024-05-08 Thread Byungchul Park
Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate (the simplest way): 1. Initaialize a map for the interesting wait. /*

[PATCH v14 21/28] dept: Apply timeout consideration to dma fence wait

2024-05-08 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

Re: [Linaro-mm-sig] Re: [PATCH] epoll: try to be a _bit_ better about file lifetimes

2024-05-08 Thread Christian Brauner
On Mon, May 06, 2024 at 04:29:44PM +0200, Christian König wrote: > Am 04.05.24 um 20:20 schrieb Linus Torvalds: > > On Sat, 4 May 2024 at 08:32, Linus Torvalds > > wrote: > > > Lookie here, the fundamental issue is that epoll can call '->poll()' > > > on a file descriptor that is being closed conc

Re: [Linaro-mm-sig] Re: [PATCH] epoll: try to be a _bit_ better about file lifetimes

2024-05-08 Thread Christian Brauner
On Wed, May 08, 2024 at 10:32:08AM +0200, Daniel Vetter wrote: > On Wed, May 08, 2024 at 07:55:08AM +0200, Christian König wrote: > > Am 07.05.24 um 21:07 schrieb Linus Torvalds: > > > On Tue, 7 May 2024 at 11:04, Daniel Vetter wrote: > > > > On Tue, May 07, 2024 at 09:46:31AM -0700, Linus Torvald

[PULL] drm-misc-next-fixes

2024-05-08 Thread Maarten Lankhorst
Hi Dave, Sima, drm-misc-next-fixes for v6.10-rc1. There was some discussion on certain cherry picks I did, specifically the one for hiding fbdev address. There is some potential to cause regressions on ARM by hiding the physical address, but I think it should be fine to move ahead. This is why

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Pavel Begunkov
On 5/8/24 00:32, Jason Gunthorpe wrote: On Tue, May 07, 2024 at 08:35:37PM +0100, Pavel Begunkov wrote: On 5/7/24 18:56, Jason Gunthorpe wrote: On Tue, May 07, 2024 at 06:25:52PM +0100, Pavel Begunkov wrote: On 5/7/24 17:48, Jason Gunthorpe wrote: On Tue, May 07, 2024 at 09:42:05AM -0700, Min

Re: [PATCH 1/2] drm: print top commit sha after loading the driver

2024-05-08 Thread Jani Nikula
On Wed, 08 May 2024, Farah Kassabri wrote: > On 4/29/2024 18:32, Lucas De Marchi wrote: >> On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote: >>> On Wed, 24 Apr 2024, Farah Kassabri wrote: Add the last driver sha to the existing log message which prints the drm device info. >>>

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Pavel Begunkov
On 5/8/24 08:16, Daniel Vetter wrote: On Tue, May 07, 2024 at 08:32:47PM -0300, Jason Gunthorpe wrote: On Tue, May 07, 2024 at 08:35:37PM +0100, Pavel Begunkov wrote: On 5/7/24 18:56, Jason Gunthorpe wrote: On Tue, May 07, 2024 at 06:25:52PM +0100, Pavel Begunkov wrote: On 5/7/24 17:48, Jason

Re: [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-05-08 Thread cong yang
Hi, Doug &Conor Doug Anderson 于2024年5月8日周三 00:40写道: > > Hi, > > On Tue, May 7, 2024 at 8:14 AM Rob Herring (Arm) wrote: > > > > > > On Tue, 07 May 2024 21:52:28 +0800, Cong Yang wrote: > > > In V1, discussed with Doug and Linus [1], we need break out as separate > > > driver for the himax83102-j

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-08 Thread cong yang
Hi, Doug Anderson 于2024年5月8日周三 07:35写道: > > Hi, > > On Tue, May 7, 2024 at 6:53 AM Cong Yang > wrote: > > > > +static int hx83102_enable_extended_cmds(struct hx83102 *ctx, bool enable) > > +{ > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > + > > + if (enable) >

RE: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-05-08 Thread David Laight
From: Christian König > Sent: 07 May 2024 15:05 ... > I actually have been telling people to (ab)use the epoll behavior to > check if two file descriptors point to the same underlying file when > KCMP isn't available. In what way? You can add both fd to the same epoll fd. Relying on the implicit E

Re: [PATCH v4 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-05-08 Thread cong yang
Hi, Doug Anderson 于2024年5月8日周三 07:35写道: > > Hi, > > On Tue, May 7, 2024 at 6:53 AM Cong Yang > wrote: > > > > +static int boe_nv110wum_init(struct hx83102 *ctx) > > +{ > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > + > > + msleep(60); > > + > > + hx83102

Re: [PATCH 1/2] drm: print top commit sha after loading the driver

2024-05-08 Thread Farah Kassabri
On 4/29/2024 18:32, Lucas De Marchi wrote: > On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote: >> On Wed, 24 Apr 2024, Farah Kassabri wrote: >>> Add the last driver sha to the existing log message >>> which prints the drm device info. >> >> The commit message fails to answer the most impo

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-05-08 Thread Christian König
Am 08.05.24 um 13:51 schrieb David Laight: From: Christian König Sent: 07 May 2024 15:05 ... I actually have been telling people to (ab)use the epoll behavior to check if two file descriptors point to the same underlying file when KCMP isn't available. In what way? Something like this: fd_

Re: [Regression] 6.9.0: WARNING: workqueue: WQ_MEM_RECLAIM ttm:ttm_bo_delayed_delete [ttm] is flushing !WQ_MEM_RECLAIM events:qxl_gc_work [qxl]

2024-05-08 Thread Anders Blomdell
On 2024-05-07 07:04, Linux regression tracking (Thorsten Leemhuis) wrote: On 06.05.24 16:30, David Wang wrote: On 30.04.24 08:13, David Wang wrote: And confirmed that the warning is caused by 07ed11afb68d94eadd4ffc082b97c2331307c5ea and reverting it can fix. The kernel warning still sh

Re: [PATCH v2] mailbox: mtk-cmdq: Fix sleeping function called from invalid context

2024-05-08 Thread AngeloGioacchino Del Regno
Il 08/05/24 11:51, Jason-JH.Lin ha scritto: When we run kernel with lockdebug option, we will get the BUG below: [ 106.692124] BUG: sleeping function called from invalid context at drivers/base/power/runtime.c:1164 [ 106.692190] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 3616, n

Re: [PATCH v3 5/6] drm/xe: Add helper to accumulate exec queue runtime

2024-05-08 Thread Lucas De Marchi
On Wed, May 08, 2024 at 09:34:59AM GMT, Tvrtko Ursulin wrote: On 07/05/2024 23:45, Lucas De Marchi wrote: From: Umesh Nerlige Ramappa Add a helper to accumulate per-client runtime of all its exec queues. This is called every time a sched job is finished. v2: - Use guc_exec_queue_free_job()

Re: [Regression] 6.9.0: WARNING: workqueue: WQ_MEM_RECLAIM ttm:ttm_bo_delayed_delete [ttm] is flushing !WQ_MEM_RECLAIM events:qxl_gc_work [qxl]

2024-05-08 Thread Linux regression tracking (Thorsten Leemhuis)
On 08.05.24 14:35, Anders Blomdell wrote: > On 2024-05-07 07:04, Linux regression tracking (Thorsten Leemhuis) wrote: >> On 06.05.24 16:30, David Wang wrote: On 30.04.24 08:13, David Wang wrote: >> And confirmed that the warning is caused by 07ed11afb68d94eadd4ffc082b97c2331307c5ea a

Re: [PATCH 07/11] drm/gma500: Use fbdev client helpers

2024-05-08 Thread Patrik Jakobsson
On Tue, May 7, 2024 at 2:04 PM Thomas Zimmermann wrote: > > Implement struct drm_client_funcs with the respective helpers and > remove the custom code from the emulation. The generic helpers are > equivalent in functionality. > > Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson > --

Re: [PATCH] drm: deprecate driver date

2024-05-08 Thread Jani Nikula
On Mon, 29 Apr 2024, Jani Nikula wrote: > The driver date serves no useful purpose, because it's hardly ever > updated. The information is misleading at best. > > As described in Documentation/gpu/drm-internals.rst: > > The driver date, formatted as MMDD, is meant to identify the date > of

Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-08 Thread AngeloGioacchino Del Regno
Il 08/05/24 09:19, CK Hu (胡俊光) ha scritto: On Tue, 2024-05-07 at 16:07 +0200, AngeloGioacchino Del Regno wrote: Il 07/05/24 08:59, CK Hu (胡俊光) ha scritto: On Thu, 2024-05-02 at 10:50 +0200, AngeloGioacchino Del Regno wrote: Il 25/04/24 04:23, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Tue, 2024-

[PATCH 00/12] accel/ivpu: Changes for 6.10

2024-05-08 Thread Jacek Lawrynowicz
There are couple of major new features in this patchset: * Hardware scheduler support (disabled by default) * Profiling support * Expose NPU busy time in sysfs Other then that, there are two small random fixes. Jacek Lawrynowicz (2): accel/ivpu: Update VPU FW API headers accel/ivpu: Inc

[PATCH 01/12] accel/ivpu: Update VPU FW API headers

2024-05-08 Thread Jacek Lawrynowicz
Update JSM API to 3.16.0. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/vpu_jsm_api.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/accel/ivpu/vpu_jsm_api.h b/drivers/accel/ivpu/vpu_jsm_api.h index e46f3531211a..33f462b1a25d 100644 --- a/dr

[PATCH 08/12] accel/ivpu: Add NPU profiling support

2024-05-08 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Implement time based Metric Streamer profiling UAPI. This is a generic mechanism allowing user mode tools to sample NPU metrics. These metrics are defined by the FW and transparent to the driver. The user space can check for this feature by checking DRM_IVPU_CAP_METRIC_S

[PATCH 07/12] accel/ivpu: Add resume engine support

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Create debugfs interface that triggers sending resume engine IPC command to VPU. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 24 1 file changed, 24 insertions(+) diff --git a/driver

[PATCH 02/12] accel/ivpu: Add sched_mode module param

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" This param will be used to enable/disable HWS (hardware scheduler). The HWS is a FW side feature and may not be available on all HW generations and FW versions. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4

[PATCH 04/12] accel/ivpu: Implement support for preemption buffers

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Allocate per-context preemption buffers that are required by HWS. There are two preemption buffers: * primary - allocated in user memory range (PIOVA accessible) * secondary - allocated in shave memory range Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawr

[PATCH 09/12] accel/ivpu: Add force snoop module parameter

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add module parameter that enforces snooping for all NPU accesses, both through MMU PTEs mappings and through TCU page table walk override register bits for MMU page walks / configuration access. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- driv

[PATCH 06/12] accel/ivpu: Implement support for hardware scheduler

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add support for HWS (hardware scheduler). It is disabled by default. The sched_mode module param can be used to enable it. Each context has multiple command queues with different priorities and HWS enables priority based execution on the HW/FW side. The driver in HWS mo

[PATCH 05/12] accel/ivpu: Add HWS JSM messages

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add JSM messages that will be used to implement hardware scheduler. Most of these messages are used to create and manage HWS specific command queues. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 1 + driver

[PATCH 03/12] accel/ivpu: Create priority based command queues

2024-05-08 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Create multiple command queues per engine with different priorities. The cmdqs are created on-demand and they support 4 priority levels. These priorities will later be used by the HWS (hardware scheduler). Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz

[PATCH 10/12] accel/ivpu: Configure fw logging using debugfs

2024-05-08 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Add fw_dyndbg file that can be used to control FW logging. Signed-off-by: Tomasz Rusinowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_de

[PATCH 10/12] accel/ivpu: Configure fw logging using debugfs

2024-05-08 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz Add fw_dyndbg file that can be used to control FW logging. Signed-off-by: Tomasz Rusinowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_de

[PATCH 11/12] accel/ivpu: Increase reset counter when warm boot fails

2024-05-08 Thread Jacek Lawrynowicz
Failed warm boot causes a cold boot that looses FW state and is equivalent to a recovery or reset, so reset_counter should be incremented in order for this failure to be detected by tests. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs

2024-05-08 Thread Jacek Lawrynowicz
From: Tomasz Rusinowicz The driver tracks the time spent by NPU executing jobs and shares it through sysfs `npu_busy_time_us` file. It can be then used by user space applications to monitor device utilization. NPU is considered 'busy' starting with a first job submitted to firmware and ending wh

Re: [PATCH 10/12] accel/ivpu: Configure fw logging using debugfs

2024-05-08 Thread Jacek Lawrynowicz
Hi, Please ignore this patch. It got here by mistake. There is another one sent as a part of a patchset. On 08.05.2024 15:25, Jacek Lawrynowicz wrote: > From: Tomasz Rusinowicz > > Add fw_dyndbg file that can be used to control FW logging. > > Signed-off-by: Tomasz Rusinowicz > Signed-off-by:

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Alex Deucher
On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Reviewed-by

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Jason Gunthorpe
On Wed, May 08, 2024 at 12:30:07PM +0100, Pavel Begunkov wrote: > > I'm not going to pretend to know about page pool details, but dmabuf > > is the way to get the bulk of pages into a pool within the net stack's > > allocator and keep that bulk properly refcounted while.> An object like > > dmabuf

Re: NXP i.MX8MM GPU performances

2024-05-08 Thread João Paulo Gonçalves
Hi Lucas, On Wed, May 08, 2024 at 10:16:24AM +0200, Lucas Stach wrote: > That's a problem. This will prevent TS from being used, which has a > large performance impact. But it shouldn't be necessary to disable it > on the i.MX8MM GPU, as all memory accesses aside from the initial MMU > commandstre

[PATCH 1/6] drm/v3d: Add Performance Counters descriptions for V3D 4.2 and 7.1

2024-05-08 Thread Maíra Canal
Add name, category and description for each one of the 93 performance counters available on V3D. Note that V3D 4.2 has 87 performance counters, while V3D 7.1 has 93. Therefore, there are two performance counters arrays. The index of the performance counter for each V3D version is represented by it

[PATCH 4/6] drm/v3d: Create new IOCTL to expose performance counters information

2024-05-08 Thread Maíra Canal
Userspace usually needs some information about the performance counters available. Although we could replicate this information in the kernel and user-space, let's use the kernel as the "single source of truth" to avoid issues in the future (e.g. list of performance counters is updated in user-spac

[PATCH 3/6] drm/v3d: Create a new V3D parameter for the maximum number of perfcnt

2024-05-08 Thread Maíra Canal
The maximum number of performance counters can change from version to version and it's important for userspace to know this value, as it needs to use the counters for performance queries. Therefore, expose the maximum number of performance counters to userspace as a parameter. Signed-off-by: Maíra

[PATCH 5/6] drm/v3d: Use V3D_MAX_COUNTERS instead of V3D_PERFCNT_NUM

2024-05-08 Thread Maíra Canal
V3D_PERFCNT_NUM represents the maximum number of performance counters for V3D 4.2, but not for V3D 7.1. This means that, if we use V3D_PERFCNT_NUM, we might go out-of-bounds on V3D 7.1. Therefore, use the number of performance counters on V3D 7.1 as the maximum number of counters. This will allow

[PATCH 6/6] drm/v3d: Deprecate the use of the Performance Counters enum

2024-05-08 Thread Maíra Canal
The Performance Counters enum used to identify the index of each performance counter and provide the total number of performance counters (V3D_PERFCNT_NUM). But, this enum is only valid for V3D 4.2, not for V3D 7.1. As we implemented a new flexible structure to retrieve performance counters inform

[PATCH 2/6] drm/v3d: Different V3D versions can have different number of perfcnt

2024-05-08 Thread Maíra Canal
Currently, even though V3D 7.1 has 93 performance counters, it is not possible to create counters bigger than 87, as `v3d_perfmon_create_ioctl()` understands that counters bigger than 87 are invalid. Therefore, create a device variable to expose the maximum number of counters for a given V3D versi

[PATCH 0/6] drm/v3d: Improve Performance Counters handling

2024-05-08 Thread Maíra Canal
This series has the intention to address two issues with Performance Counters on V3D: 1. Update the number of Performance Counters for V3D 7.1 V3D 7.1 has 93 performance counters, while V3D 4.2 has only 87. Although the series [1] enabled support for V3D 7.1, it didn’t replace the maximu

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan wrote: > > On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > series to fix drivers/i2c/[1], fi

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Daniel Vetter
On Wed, May 08, 2024 at 12:35:52PM +0100, Pavel Begunkov wrote: > On 5/8/24 08:16, Daniel Vetter wrote: > > On Tue, May 07, 2024 at 08:32:47PM -0300, Jason Gunthorpe wrote: > > > On Tue, May 07, 2024 at 08:35:37PM +0100, Pavel Begunkov wrote: > > > > On 5/7/24 18:56, Jason Gunthorpe wrote: > > > >

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Pavel Begunkov
On 5/8/24 15:25, Jason Gunthorpe wrote: On Wed, May 08, 2024 at 12:30:07PM +0100, Pavel Begunkov wrote: I'm not going to pretend to know about page pool details, but dmabuf is the way to get the bulk of pages into a pool within the net stack's allocator and keep that bulk properly refcounted wh

Re: [Linaro-mm-sig] Re: [PATCH] epoll: try to be a _bit_ better about file lifetimes

2024-05-08 Thread Daniel Vetter
On Wed, May 08, 2024 at 12:08:57PM +0200, Christian Brauner wrote: > On Mon, May 06, 2024 at 04:29:44PM +0200, Christian König wrote: > > Am 04.05.24 um 20:20 schrieb Linus Torvalds: > > > On Sat, 4 May 2024 at 08:32, Linus Torvalds > > > wrote: > > > > Lookie here, the fundamental issue is that e

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-08 Thread Daniel Vetter
On Wed, May 08, 2024 at 09:38:33AM +0100, Daniel Stone wrote: > On Wed, 8 May 2024 at 09:33, Daniel Vetter wrote: > > On Wed, May 08, 2024 at 06:46:53AM +0100, Daniel Stone wrote: > > > That would have the unfortunate side effect of making sandboxed apps > > > less efficient on some platforms, sin

Re: /sys/kernel/debug/vgaswitcheroo directory missing

2024-05-08 Thread Daniel Vetter
On Wed, May 08, 2024 at 09:02:02AM +0100, Chris Clayton wrote: > Hi, > > I'm running the latest development kernel - 6.9.0-rc7+ (HEAD is > dccb07f2914cdab2ac3a5b6c98406f765acab803.) > > As I say in $SUBJECT, the directory /sys/kernel/debug/vgaswitcheroo is > missing in this release. Perhaps mor

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Jason Gunthorpe
On Wed, May 08, 2024 at 04:44:32PM +0100, Pavel Begunkov wrote: > > like a weird and indirect way to get there. Why can't io_uring just be > > the entity that does the final free and not mess with the logic > > allocator? > > Then the user has to do a syscall (e.g. via io_uring) to return pages,

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Pavel Begunkov
On 5/8/24 16:58, Jason Gunthorpe wrote: On Wed, May 08, 2024 at 04:44:32PM +0100, Pavel Begunkov wrote: like a weird and indirect way to get there. Why can't io_uring just be the entity that does the final free and not mess with the logic allocator? Then the user has to do a syscall (e.g. via

Re: [Linaro-mm-sig] Re: [PATCH] epoll: try to be a _bit_ better about file lifetimes

2024-05-08 Thread Linus Torvalds
On Tue, 7 May 2024 at 12:07, Linus Torvalds wrote: > > That example thing shows that we shouldn't make it a FISAME ioctl - we > should make it a fcntl() instead, and it would just be a companion to > F_DUPFD. > > Doesn't that strike everybody as a *much* cleaner interface? I think > F_ISDUP would

Re: [PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9

2024-05-08 Thread Abhinav Kumar
On 5/8/2024 2:17 AM, Jon Hunter wrote: Building the kernel with python3 versions earlier than v3.9 fails with ... Traceback (most recent call last): File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in main() File "drivers/gpu/drm/msm/registers/gen_header.py", lin

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-08 Thread Abhinav Kumar
On 5/8/2024 1:43 AM, Jani Nikula wrote: On Tue, 07 May 2024, Abhinav Kumar wrote: Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), compilation is broken on machines having python versions older than 3.9 due to dependency on argparse.BooleanOptionalAction. Is it

Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-05-08 Thread Pavel Begunkov
On 5/8/24 16:51, Christoph Hellwig wrote: On Wed, May 08, 2024 at 12:35:52PM +0100, Pavel Begunkov wrote: all these, because e.g. ttm internally does have a page pool because depending upon allocator, that's indeed beneficial. Other drm drivers have more buffer-based concepts for opportunistical

Re: [Linaro-mm-sig] Re: [PATCH] epoll: try to be a _bit_ better about file lifetimes

2024-05-08 Thread Linus Torvalds
On Wed, 8 May 2024 at 09:19, Linus Torvalds wrote: > > So since we already have two versions of F_DUPFD (the other being > F_DUPFD_CLOEXEC) I decided that the best thing to do is to just extend > on that existing naming pattern, and called it F_DUPFD_QUERY instead. > > I'm not married to the name,

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-08 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 4:52 AM cong yang wrote: > > > > +static int starry_himax83102_j02_init(struct hx83102 *ctx) > > > +{ > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > > + > > > + hx83102_enable_extended_cmds(ctx, true); > > > + mipi_dsi_dcs_wri

[PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-05-08 Thread Konrad Dybcio
spin_until(!gpu_read(gpu, REG_A6XX_GBIF_HALT_ACK)); - gpu_write(gpu, REG_A6XX_RBBM_SECVID_TSB_CNTL, 0); if (adreno_is_a619_holi(adreno_gpu)) --- base-commit: 93a39e4766083050ca0ecd6a3548093a3b9eb60c change-id: 20240508-topic-adreno-a2d199cd4152 Best regards, -- Konrad Dybcio

[RFC 4/5] drm/amdgpu: Use preferred placement for VRAM+GTT

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Now that TTM has the preferred placement flag, extend the current workaround which assumes the GTT placement as fallback in the presence of the additional VRAM placement. By marking the VRAM placement as preferred we will make the buffer re- validation phase actually attempt

[RFC 3/5] drm/ttm: Add preferred placement flag

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently the fallback placement flag can achieve a hint that buffer should be migrated back to the non-fallback placement, however that only works while there is no memory pressure. As soon as we reach full VRAM utilisation, or worse overcommit, the logic is happy to leave b

[RFC 5/5] drm/amdgpu: Re-validate evicted buffers

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently the driver appears to be thinking that it will be attempting to re-validate the evicted buffers on the next submission if they are not in their preferred placement. That however appears not to be true for the very common case of buffers with allowed placements of V

[RFC 0/5] Discussion around eviction improvements

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Last few days I was looking at the situation with VRAM over subscription, what happens versus what perhaps should happen. Browsing through the driver and running some simple experiments. I ended up with this patch series which, as a disclaimer, may be completely wrong but as

[RFC 2/5] drm/amdgpu: Actually respect buffer migration budget

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Current code appears to live in a misconception that playing with buffer allowed and preferred placements can control the decision on whether backing store migration will be attempted or not. Both from code inspection and from empirical experiments I see that not being true,

[RFC 1/5] drm/amdgpu: Fix migration rate limiting accounting

2024-05-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin The logic assumed any migration attempt worked and therefore would over- account the amount of data migrated during buffer re-validation. As a consequence client can be unfairly penalised by incorrectly considering its migration budget spent. Fix it by looking at the before

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2024-05-08 Thread José Expósito
Hi everyone, I wasn't aware of these patches, but I'm really glad they are getting some attention, thanks a lot for your review Sima. Given that it's been a while since the patches were emailed, I'm not sure if the original authors of the patches could implement your comments. If not, I can work

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Florian Fainelli
On 5/7/24 04:44, Arnd Bergmann wrote: On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: On Mon, May 6, 2024, at 15:14, Daniel Vetter wrote: On Fri, May 03, 2024 at 01:22:10PM -0700, Florian Fainelli wrote: On 5/3/24 12:45, Arnd

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 09:47:50AM -0400, Alex Deucher wrote: > On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Replace the open coded drm_crtc_vblank_crtc() with the real > > thing. > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: "Pan, Xinhu

Re: [PATCH 3/5] drm/i915: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 12:12:32PM +0300, Jani Nikula wrote: > On Mon, 08 Apr 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the open coded drm_crtc_vblank_crtc() with the real > > thing. > > > > Cc: intel-...@lists.freedesktop.org > > Signed-off-by: Ville Syrjälä > > Review

Re: drm scheduler and wq flavours

2024-05-08 Thread Matthew Brost
On Tue, May 07, 2024 at 10:09:18AM +0100, Tvrtko Ursulin wrote: > > On 07/05/2024 00:23, Matthew Brost wrote: > > On Thu, May 02, 2024 at 03:33:50PM +0100, Tvrtko Ursulin wrote: > > > > > > Hi all, > > > > > > Continuing after the brief IRC discussion yesterday regarding work queues > > > being

Re: [RFC 1/5] drm/amdgpu: Fix migration rate limiting accounting

2024-05-08 Thread Friedrich Vock
On 08.05.24 20:09, Tvrtko Ursulin wrote: From: Tvrtko Ursulin The logic assumed any migration attempt worked and therefore would over- account the amount of data migrated during buffer re-validation. As a consequence client can be unfairly penalised by incorrectly considering its migration budg

[PULL] drm-intel-fixes

2024-05-08 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our last fixes for v6.9. drm-intel-fixes-2024-05-08: - Automate CCS Mode setting during engine resets (Andi) - Fix audio time stamp programming for DP (Chaitanya) - Fix parsing backlight BDB data (Karthikeyan) The following changes since commit dd5a440a31fae6e459c0d627

Re: [PATCH v8 00/35] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y regression

2024-05-08 Thread jim . cromie
On Mon, Apr 29, 2024 at 1:32 PM Jim Cromie wrote: > > hi Greg, Jason, DRM-folk, > > This patchset fixes the CONFIG_DRM_USE_DYNAMIC_DEBUG=y regression, > Fixes: bb2ff6c27bc9 ("drm: Disable dynamic debug as broken") > > this is v8. > Its also here: > https://github.com/jimc/linux/tree/dd-classmap-fi

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Arnd Bergmann
On Wed, May 8, 2024, at 20:37, Florian Fainelli wrote: > On 5/7/24 04:44, Arnd Bergmann wrote: >> On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: >>> On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: >> Right, let's wait for Florian to reply. From what he said earlier >> though, t

Re: /sys/kernel/debug/vgaswitcheroo directory missing

2024-05-08 Thread Chris Clayton
On 08/05/2024 16:54, Daniel Vetter wrote: > On Wed, May 08, 2024 at 09:02:02AM +0100, Chris Clayton wrote: >> Hi, >> >> I'm running the latest development kernel - 6.9.0-rc7+ (HEAD is >> dccb07f2914cdab2ac3a5b6c98406f765acab803.) >> >> As I say in $SUBJECT, the directory /sys/kernel/debug/vgasw

2024 X.Org Developers Conference - October 9-11, Montréal, Canada

2024-05-08 Thread Mark Filion
Hello! We're delighted to announce that the 2024 X.Org Developers Conference (XDC) will be taking place on October 9 to 11 in Montréal, Canada, co- located with the GStreamer Conference & Hackfest 2024 which will be running from October 7 to 10. Join us for a freedesktop week in Montréal! XDC is

Re: [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage

2024-05-08 Thread Ville Syrjälä
On Mon, Apr 08, 2024 at 08:04:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > I got fed up having to build multiple architectures when > doing subsystem wide refactoring. So I decided to attack > the low hanging COMPILE_TEST=y fruit. Here are the > results. All of these drivers now bui

[PATCH 1/2] drm: Allow mode object properties to be added after a device is registered

2024-05-08 Thread Mario Limonciello
When the colorspace property is registered on MST devices there is no `obj_free_cb` callback for it in drm_mode_object_add(). Don't show a warning trace for __drm_mode_object_add() calls for DRM_MODE_OBJECT_PROPERTY. Reported-and-tested-by: Tyler Schneider Closes: https://gitlab.freedesktop.org/

[PATCH 2/2] Revert "drm/amd/display: Temporary Disable MST DP Colorspace Property"

2024-05-08 Thread Mario Limonciello
MST colorspace property support was disabled due to a series of warnings that came up when the device was plugged in. As those warnings are fixed, revert commit 69a959610229 ("drm/amd/display: Temporary Disable MST DP Colorspace Property"). Reported-and-tested-by: Tyler Schneider Closes: https:/

Re: [PATCH 1/2] drm: Allow mode object properties to be added after a device is registered

2024-05-08 Thread Ville Syrjälä
On Wed, May 08, 2024 at 02:43:07PM -0500, Mario Limonciello wrote: > When the colorspace property is registered on MST devices there is > no `obj_free_cb` callback for it in drm_mode_object_add(). > > Don't show a warning trace for __drm_mode_object_add() calls for > DRM_MODE_OBJECT_PROPERTY. You

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Easwar Hariharan
On 5/8/2024 7:53 AM, Alex Deucher wrote: > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > wrote: >> >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: >>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >>> with more appropriate terms. Inspired by and following on to

Re: [PATCH v2] mailbox: mtk-cmdq: Fix sleeping function called from invalid context

2024-05-08 Thread Krzysztof Kozlowski
On 08/05/2024 11:51, Jason-JH.Lin wrote: > When we run kernel with lockdebug option, we will get the BUG below: > [ 106.692124] BUG: sleeping function called from invalid context at > drivers/base/power/runtime.c:1164 > [ 106.692190] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 3616,

Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate

2024-05-08 Thread Sam Ravnborg
Hi Arnd, > > I think if you want to do a new version, that is likely to run > into new problems, given that this part of fbdev is particularly > fragile and partly wrong. On the other hand, it would be nice to > have a patch to limit the use of the notifiers to the smallest > set of kernel config

Re: [PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9

2024-05-08 Thread Jon Hunter
On 08/05/2024 17:46, Abhinav Kumar wrote: On 5/8/2024 2:17 AM, Jon Hunter wrote: Building the kernel with python3 versions earlier than v3.9 fails with ...   Traceback (most recent call last):     File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in   main()     File "dr

[PATCH v4 0/9] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-05-08 Thread Douglas Anderson
The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros mipi_dsi_generic_write_seq() and mipi_dsi_dcs_write_seq() b

[PATCH v4 1/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-05-08 Thread Douglas Anderson
The mipi_dsi_dcs_write_seq() macro makes a call to mipi_dsi_dcs_write_buffer() which returns a type ssize_t. The macro then stores it in an int and checks to see if it's negative. This could theoretically be a problem if "ssize_t" is larger than "int". To see the issue, imagine that "ssize_t" is 3

[PATCH v4 2/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_generic_write_seq()

2024-05-08 Thread Douglas Anderson
The mipi_dsi_generic_write_seq() macro makes a call to mipi_dsi_generic_write() which returns a type ssize_t. The macro then stores it in an int and checks to see if it's negative. This could theoretically be a problem if "ssize_t" is larger than "int". To see the issue, imagine that "ssize_t" is

[PATCH v4 3/9] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

2024-05-08 Thread Douglas Anderson
We really don't expect these errors to be printed over and over again. When a driver hits the error it should bail out. Just use a normal error print. This gives a nice space savings for users of these functions: $ scripts/bloat-o-meter \ .../before/panel-novatek-nt36672e.ko \ .../after/panel

[PATCH v4 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-08 Thread Douglas Anderson
Through a cooperative effort between Hsin-Yi Wang and Dmitry Baryshkov, we have realized the dev_err() in the mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the kernel. Let's hoist this call into drm_mipi_dsi.c by adding a "chatty" version of the functions that includes the print

[PATCH v4 5/9] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-08 Thread Douglas Anderson
The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new macros that are more intuitive. These new macros are less optimal when an er

[PATCH v4 6/9] drm/panel: novatek-nt36672e: Switch to mipi_dsi_dcs_write_seq_multi()

2024-05-08 Thread Douglas Anderson
This is a mechanical conversion of the novatek-nt36672e driver to use the new mipi_dsi_dcs_write_seq_multi(). The new function is easier for clients to understand and using it also causes smaller code to be generated. Specifically: $ scripts/bloat-o-meter \ ...after/panel-novatek-nt36672e.ko \

[PATCH v4 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for initting panels

2024-05-08 Thread Douglas Anderson
Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. With the recently introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy but also saves space. Measuring before/after this change: $ scripts/bloat-o-meter \

[PATCH v4 9/9] drm/panel: innolux-p079zca: Don't use a table for initting panels

2024-05-08 Thread Douglas Anderson
Consensus on the mailing lists is that panels shouldn't use a table of init commands but should instead use init functions. We'll use the same concepts as the recently introduced mipi_dsi_generic_write_seq_multi() to make this clean/easy and also not bloat the driver too much. Measuring before/afte

  1   2   3   >