Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-25 Thread Junhao Xie
On 2024/4/25 14:02, Uwe Kleine-König wrote: > Hello, > > On Wed, Apr 24, 2024 at 11:29:07PM +0800, Xilin Wu via B4 Relay wrote: >> From: Junhao Xie >> >> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. >> [...] >> +MODULE_LICENSE("GPL"); > > Best regards > Uwe > Than

Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-25 Thread Friedrich Vock
On 25.04.24 08:58, Christian König wrote: Am 25.04.24 um 08:46 schrieb Friedrich Vock: On 25.04.24 08:32, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buffer priorities in response to changes in application demand and memory pressure. Yeah,

Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-25 Thread Christian König
Am 25.04.24 um 09:06 schrieb Friedrich Vock: On 25.04.24 08:58, Christian König wrote: Am 25.04.24 um 08:46 schrieb Friedrich Vock: On 25.04.24 08:32, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buffer priorities in response to changes in ap

[PATCH 0/3] drm/panthor: Collection of tiler heap related fixes

2024-04-25 Thread Boris Brezillon
Hello, This is a collection of tiler heap fixes for bugs/oddities found while looking at incremental rendering. We need to make sure those land before 6.10 is released (we still have plenty of time), so we don't need to increment the driver version to reflect the ABI changes. Regards, Boris An

[PATCH 1/3] drm/panthor: Fix tiler OOM handling to allow incremental rendering

2024-04-25 Thread Boris Brezillon
From: Antonino Maniscalco If the kernel couldn't allocate memory because we reached the maximum number of chunks but no render passes are in flight (panthor_heap_grow() returning -ENOMEM), we should defer the OOM handling to the FW by returning a NULL chunk. The FW will then call the tiler OOM ex

[PATCH 2/3] drm/panthor: Make sure the tiler initial/max chunks are consistent

2024-04-25 Thread Boris Brezillon
It doesn't make sense to have a maximum number of chunks smaller than the initial number of chunks attached to the context. Fix the uAPI header to reflect the new constraint, and mention the undocumented "initial_chunk_count > 0" constraint while at it. Fixes: 9cca48fa4f89 ("drm/panthor: Add the

[PATCH 3/3] drm/panthor: Relax the check on the tiler chunk size

2024-04-25 Thread Boris Brezillon
The field used to store the chunk size if 12 bits wide, and the encoding is chunk_size = chunk_header.chunk_size << 12, which gives us a theoretical [4k:8M] range. This range is further limited by implementation constraints, but those shouldn't be enforced kernel side. Fixes: 9cca48fa4f89 ("drm/pa

Re: [PATCH] gpu: drm: exynos: hdmi: eliminate uses of of_node_put()

2024-04-25 Thread Inki Dae
Good cleanup. Applied. :) Thanks, Inki Dae 2024년 4월 15일 (월) 오전 9:40, Shivani Gupta 님이 작성: > > Utilize the __free() cleanup handler within the hdmi_get_phy_io function > to automatically release the device node when it is out of scope. > This eliminates the manual invocation of of_node_put(), redu

Re: [RFC PATCH 10/18] drm/amdgpu: Don't add GTT to initial domains after failing to allocate VRAM

2024-04-25 Thread Friedrich Vock
On 25.04.24 08:25, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: This adds GTT to the "preferred domains" of this buffer object, which will also prevent any attempts at moving the buffer back to VRAM if there is space. If VRAM is full, GTT will already be chosen as a fallba

Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-25 Thread Friedrich Vock
On 25.04.24 09:15, Christian König wrote: Am 25.04.24 um 09:06 schrieb Friedrich Vock: On 25.04.24 08:58, Christian König wrote: Am 25.04.24 um 08:46 schrieb Friedrich Vock: On 25.04.24 08:32, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buf

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-25 Thread Neil Armstrong
Hi Dmitry, On 24/04/2024 11:12, Dmitry Baryshkov wrote: On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote: Core in mipi_dsi_driver_register() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/bridge/chipone-icn6211.

Re: [RFC PATCH 10/18] drm/amdgpu: Don't add GTT to initial domains after failing to allocate VRAM

2024-04-25 Thread Christian König
Am 25.04.24 um 09:39 schrieb Friedrich Vock: On 25.04.24 08:25, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: This adds GTT to the "preferred domains" of this buffer object, which will also prevent any attempts at moving the buffer back to VRAM if there is space. If VRAM i

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Neil Armstrong
On 25/04/2024 02:20, Douglas Anderson wrote: The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros mipi_dsi_gen

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-25 Thread Neil Armstrong
On 25/04/2024 02:57, Junhao Xie wrote: On 2024/4/25 03:37, Konrad Dybcio wrote: On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: From: Junhao Xie Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. Signed-off-by: Junhao Xie --- [...] +    return sn3112_write_reg(priv,

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-25 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 10:47, Neil Armstrong wrote: > > Hi Dmitry, > > On 24/04/2024 11:12, Dmitry Baryshkov wrote: > > On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote: > >> Core in mipi_dsi_driver_register() already sets the .owner, so driver > >> does not need to. > >> > >> S

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Jani Nikula
On Wed, 24 Apr 2024, Douglas Anderson wrote: > The consensus of many DRM folks is that we want to move away from DSI > drivers defining tables of init commands. Instead, we want to move to > init functions that can use common DRM functions. The issue thus far > has been that using the macros mipi_

[PATCH] drm/panthor: Make sure we handled the unknown group state properly

2024-04-25 Thread Boris Brezillon
When we check for state values returned by the FW, we only cover part of the 0:7 range. Make sure we catch FW inconsistencies by adding a default to the switch statement, and flagging the group state as unknown in that case. When an unknown state is detected, we trigger a reset, and consider the g

Re: [PATCH V2 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-04-25 Thread Marek Szyprowski
On 12.02.2024 00:09, Adam Ford wrote: > The P divider should be set based on the min and max values of > the fin pll which may vary between different platforms. > These ranges are defined per platform, but hard-coded values > were used instead which resulted in a smaller range available > on the i.

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-25 Thread Marek Szyprowski
On 12.02.2024 00:09, Adam Ford wrote: > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible. > If the HFP is rounded down, it ends up being t

Re: [PATCH] drm/panthor: Add defer probe for firmware load

2024-04-25 Thread Javier Martinez Canillas
Steven Price writes: Hello Steven, > On 13/04/2024 12:49, Andy Yan wrote: >> From: Andy Yan >> >> The firmware in the rootfs will not be accessible until we >> are in the SYSTEM_RUNNING state, so return EPROBE_DEFER until >> that point. >> This let the driver can load firmware when it is built

Re: [PATCH 2/3] drm/panthor: Make sure the tiler initial/max chunks are consistent

2024-04-25 Thread Steven Price
On 25/04/2024 08:18, Boris Brezillon wrote: > It doesn't make sense to have a maximum number of chunks smaller than > the initial number of chunks attached to the context. > > Fix the uAPI header to reflect the new constraint, and mention the > undocumented "initial_chunk_count > 0" constraint whi

Re: [PATCH 1/3] drm/panthor: Fix tiler OOM handling to allow incremental rendering

2024-04-25 Thread Steven Price
On 25/04/2024 08:18, Boris Brezillon wrote: > From: Antonino Maniscalco > > If the kernel couldn't allocate memory because we reached the maximum > number of chunks but no render passes are in flight > (panthor_heap_grow() returning -ENOMEM), we should defer the OOM > handling to the FW by return

Re: [PATCH 3/3] drm/panthor: Relax the check on the tiler chunk size

2024-04-25 Thread Steven Price
On 25/04/2024 08:18, Boris Brezillon wrote: > The field used to store the chunk size if 12 bits wide, and the encoding NIT: ^^ is > is chunk_size = chunk_header.chunk_size << 12, which gives us a > theoretical [4k:8M] range. This range is further limited by > im

Re: [PATCH] drm/panthor: Make sure we handled the unknown group state properly

2024-04-25 Thread Steven Price
On 25/04/2024 09:46, Boris Brezillon wrote: > When we check for state values returned by the FW, we only cover part of > the 0:7 range. Make sure we catch FW inconsistencies by adding a default > to the switch statement, and flagging the group state as unknown in that > case. > > When an unknown s

Re: [PATCH 1/3] drm/panthor: Fix tiler OOM handling to allow incremental rendering

2024-04-25 Thread Boris Brezillon
On Thu, 25 Apr 2024 10:28:49 +0100 Steven Price wrote: > On 25/04/2024 08:18, Boris Brezillon wrote: > > From: Antonino Maniscalco > > > > If the kernel couldn't allocate memory because we reached the maximum > > number of chunks but no render passes are in flight > > (panthor_heap_grow() retur

[PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found

2024-04-25 Thread Marek Szyprowski
When reading EDID fails and driver reports no modes available, the DRM core adds an artificial 1024x786 mode to the connector. Unfortunately some variants of the Exynos HDMI (like the one in Exynos4 SoCs) are not able to drive such mode, so report a safe 640x480 mode instead of nothing in case of t

Re: [PATCH 3/3] drm/panthor: Relax the check on the tiler chunk size

2024-04-25 Thread Boris Brezillon
On Thu, 25 Apr 2024 10:28:56 +0100 Steven Price wrote: > On 25/04/2024 08:18, Boris Brezillon wrote: > > The field used to store the chunk size if 12 bits wide, and the encoding > NIT: ^^ is > > > is chunk_size = chunk_header.chunk_size << 12, which gives us

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-04-25 Thread Helge Deller
On 4/25/24 01:49, Kees Cook wrote: On Wed, Mar 20, 2024 at 11:48:52PM +0100, Helge Deller wrote: On 3/20/24 23:35, Justin Stitt wrote: Hi, On Wed, Mar 20, 2024 at 12:56 AM Helge Deller wrote: On 3/19/24 00:46, Justin Stitt wrote: strncpy() is deprecated for use on NUL-terminated destinatio

Re: [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed

2024-04-25 Thread Helge Deller
On 4/16/24 08:51, Cai Xinchen wrote: The commit 04e5eac8f3ab("fbdev: savage: Error out if pixclock equals zero") checks the value of pixclock to avoid divide-by-zero error. However the function savagefb_probe doesn't handle the error return of savagefb_check_var. When pixclock is 0, it will cause

Re: [PATCH] video: fbdev: replacing of_node_put with __free(device_node)

2024-04-25 Thread Helge Deller
On 4/23/24 03:20, Abdulrasaq Lawani wrote: Replaced instance of of_node_put with __free(device_node) to simplify code and protect against any memory leaks due to future changes in the control flow. Suggested-by: Julia Lawall Signed-off-by: Abdulrasaq Lawani applied. Thanks! Helge --- dr

[PULL] drm-misc-fixes

2024-04-25 Thread Thomas Zimmermann
Hi Dave, Sima, here's the PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2024-04-25: Short summary of fixes pull: atomic-helpers: - Fix memory leak in drm_format_conv_state_copy() fbdev: - fbdefio: Fix address calculation gma500: - Fix crash during boot The following changes since

[PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend()

2024-04-25 Thread Boris Brezillon
We can use upd_ctx.timedout_mask directly, and the faulty_slots update in the flush_caches_failed situation is never used. Suggested-by: Suggested-by: Steven Price Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_sched.c | 10 +++--- 1 file changed, 3 insertions(+), 7 dele

Re: [PATCH 2/3] drm/panthor: Make sure the tiler initial/max chunks are consistent

2024-04-25 Thread Steven Price
On 25/04/2024 10:28, Steven Price wrote: > On 25/04/2024 08:18, Boris Brezillon wrote: >> It doesn't make sense to have a maximum number of chunks smaller than >> the initial number of chunks attached to the context. >> >> Fix the uAPI header to reflect the new constraint, and mention the >> undocu

[PATCH] MAINTAINERS: fix LG sw43408 panel driver drm-misc git URL

2024-04-25 Thread Jani Nikula
The drm-misc git repo has moved to Gitlab. Fix the URL. Cc: Sumit Semwal Cc: Caleb Connolly Signed-off-by: Jani Nikula --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6327dc12cb1..23997d2ea91c 100644 --- a/MAINTAINERS +++ b/M

Re: [PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend()

2024-04-25 Thread Erik Faye-Lund
On Thu, 2024-04-25 at 12:39 +0200, Boris Brezillon wrote: > We can use upd_ctx.timedout_mask directly, and the faulty_slots > update > in the flush_caches_failed situation is never used. > > Suggested-by: Suggested-by: Steven Price Whoops? :) > Signed-off-by: Boris Brezillon > --- >  drivers/g

Re: [PATCH V2] drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY

2024-04-25 Thread Laurent Pinchart
Hi Adam, Thank you for the patch. On Mon, Apr 22, 2024 at 05:33:52AM -0500, Adam Ford wrote: > When enabling i.MX8MP DWC HDMI driver, it automatically selects > PHY_FSL_SAMSUNG_HDMI_PHY, since it wont' work without the phy. > This may cause some Kconfig warnings during various build tests. > Fix

Re: [PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend()

2024-04-25 Thread Steven Price
On 25/04/2024 11:39, Boris Brezillon wrote: > We can use upd_ctx.timedout_mask directly, and the faulty_slots update > in the flush_caches_failed situation is never used. > > Suggested-by: Suggested-by: Steven Price I'm obviously too full of suggestions! ;) And you're doing a much better job of

[PATCH v2] drm/amd/display: re-indent dc_power_down_on_boot()

2024-04-25 Thread Dan Carpenter
These lines are indented too far. Clean the whitespace. Signed-off-by: Dan Carpenter --- v2: Delete another blank line (checkpatch.pl --strict). drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/c

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Christian Gmeiner
Hi Tomeu, > > If we expose a render node for NPUs without rendering capabilities, the > userspace stack will offer it to compositors and applications for > rendering, which of course won't work. > > Userspace is probably right in not questioning whether a render node > might not be capable of supp

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-25 Thread Robert Foss
On Mon, Apr 22, 2024 at 2:10 PM Jani Nikula wrote: > > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. > > v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe > > v2: Also fix ivpu and vmwgfx > > Reviewed-by: Andrzej Hajda > Acked-by: Maxim

Re: [PATCH V2] drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY

2024-04-25 Thread Robert Foss
On Mon, 22 Apr 2024 05:33:52 -0500, Adam Ford wrote: > When enabling i.MX8MP DWC HDMI driver, it automatically selects > PHY_FSL_SAMSUNG_HDMI_PHY, since it wont' work without the phy. > This may cause some Kconfig warnings during various build tests. > Fix this by implying the phy instead of select

Re: [PATCH v8 6/6] drm/{i915,xe}: Implement fbdev emulation as in-kernel client

2024-04-25 Thread Jani Nikula
On Tue, 23 Apr 2024, Thomas Zimmermann wrote: > Hi > > Am 23.04.24 um 13:36 schrieb Hogander, Jouni: >> On Tue, 2024-04-23 at 13:13 +0200, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 22.04.24 um 16:11 schrieb Hogander, Jouni: On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: > Re

Re: [PATCH 2/3] drm/panthor: Make sure the tiler initial/max chunks are consistent

2024-04-25 Thread Boris Brezillon
On Thu, 25 Apr 2024 11:43:39 +0100 Steven Price wrote: > On 25/04/2024 10:28, Steven Price wrote: > > On 25/04/2024 08:18, Boris Brezillon wrote: > >> It doesn't make sense to have a maximum number of chunks smaller than > >> the initial number of chunks attached to the context. > >> > >> Fix t

[PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

2024-04-25 Thread Andy Shevchenko
First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels. Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality. Taking into account the above, remove duplicative driver and

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-25 Thread Maxime Ripard
On Wed, Apr 24, 2024 at 08:20:32AM -0400, Rodrigo Vivi wrote: > On Wed, Apr 24, 2024 at 01:49:16PM +0200, Maxime Ripard wrote: > > On Tue, Apr 23, 2024 at 01:42:22PM -0400, Rodrigo Vivi wrote: > > > On Tue, Apr 23, 2024 at 02:25:06PM +0530, Aravind Iddamsetty wrote: > > > > > > > > On 23/04/24 02:

[PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-04-25 Thread Andy Shevchenko
The modpost script is not happy WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_mipi_dbi.o because there is a missing module description. Add it to the module. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/drm_mipi_dbi.c | 1 + 1 file changed, 1 insertion(+) dif

Re: [RFC PATCH 00/18] TTM interface for managing VRAM oversubscription

2024-04-25 Thread Marek Olšák
The most extreme ping-ponging is mitigated by throttling buffer moves in the kernel, but it only works without VM_ALWAYS_VALID and you can set BO priorities in the BO list. A better approach that works with VM_ALWAYS_VALID would be nice. Marek On Wed, Apr 24, 2024 at 1:12 PM Friedrich Vock wrote

Re: [RFC PATCH 00/18] TTM interface for managing VRAM oversubscription

2024-04-25 Thread Christian König
Yeah, and this patch set here is removing that functionality. Which is major concern from my side as well. Instead of removing it my long term plan was to move this into TTM ( the recent flags rework is going into that direction), so that both amdgpu and radeon can use the same code again *and

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-25 Thread Sui Jingfeng
On 2024/4/25 00:44, Andy Shevchenko wrote: On Wed, Apr 24, 2024 at 07:34:54PM +0300, Dmitry Baryshkov wrote: On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote: On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko wrote

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-25 Thread Andy Shevchenko
On Thu, Apr 25, 2024 at 09:42:53PM +0800, Sui Jingfeng wrote: > On 2024/4/25 00:44, Andy Shevchenko wrote: > > On Wed, Apr 24, 2024 at 07:34:54PM +0300, Dmitry Baryshkov wrote: > > > On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: > > > > On Wed, Apr 24, 2024 at 04:34:39PM +0300, D

Re: [PATCH] drm: ci: fix the xfails for apq8016

2024-04-25 Thread Helen Koike
On 08/04/2024 14:04, Abhinav Kumar wrote: Hi Helen Gentle reminder on this. If you are okay, we can land it via msm-next tree... Thanks Abhinav On 4/1/2024 1:48 PM, Abhinav Kumar wrote: After IGT migrating to dynamic sub-tests, the pipe prefixes in the expected fails list are incorrect.

[PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Andy Shevchenko
It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/panel/Kconfig| 2 +- drivers/gpu/

[PATCH v1 3/3] drm/panel: ili9341: Use predefined error codes

2024-04-25 Thread Andy Shevchenko
In one case the -1 is returned which is quite confusing code for the wrong device ID, in another the ret is returning instead of plain 0 that also confusing as readed may ask the possible meaning of positive codes, which are never the case there. Convert both to use explicit predefined error codes

[PATCH v1 0/3] drm/panel: ili9341: Obvious fixes

2024-04-25 Thread Andy Shevchenko
A few obvious fixes to the driver. Andy Shevchenko (3): drm/panel: ili9341: Correct use of device property APIs drm/panel: ili9341: Respect deferred probe drm/panel: ili9341: Use predefined error codes drivers/gpu/drm/panel/Kconfig| 2 +- drivers/gpu/drm/panel/panel-ilitek

[PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe

2024-04-25 Thread Andy Shevchenko
GPIO controller might not be available when driver is being probed. There are plenty of reasons why, one of which is deferred probe. Since GPIOs are optional, return any error code we got to the upper layer, including deferred probe. With that in mind, use dev_err_probe() in order to avoid spammin

Re: [PATCH] drm/panthor: Add defer probe for firmware load

2024-04-25 Thread Steven Price
Hi Javier, On 25/04/2024 10:22, Javier Martinez Canillas wrote: > Steven Price writes: > > Hello Steven, > >> On 13/04/2024 12:49, Andy Yan wrote: >>> From: Andy Yan >>> >>> The firmware in the rootfs will not be accessible until we >>> are in the SYSTEM_RUNNING state, so return EPROBE_DEFER u

[PULL] drm-misc-next

2024-04-25 Thread Maarten Lankhorst
Hi Dave, Sima, One more pull request for v6.10! Cheers, ~Maarten drm-misc-next-2024-04-25: drm-misc-next for v6.10-rc1: UAPI Changes: Cross-subsystem Changes: - Devicetree updates for rockchip (#sound-dai-cells) - Add dt bindings for new panels. - Change bridge/tc358775 dt bindings. Core Cha

Re: [PATCH v3 1/4] drm: add devm release action

2024-04-25 Thread Aravind Iddamsetty
On 25/04/24 18:22, Maxime Ripard wrote: > On Wed, Apr 24, 2024 at 08:20:32AM -0400, Rodrigo Vivi wrote: >> On Wed, Apr 24, 2024 at 01:49:16PM +0200, Maxime Ripard wrote: >>> On Tue, Apr 23, 2024 at 01:42:22PM -0400, Rodrigo Vivi wrote: On Tue, Apr 23, 2024 at 02:25:06PM +0530, Aravind Iddams

Re: [PATCH] drm/panthor: Add defer probe for firmware load

2024-04-25 Thread Javier Martinez Canillas
Steven Price writes: > Hi Javier, > > On 25/04/2024 10:22, Javier Martinez Canillas wrote: >> Steven Price writes: >> >> Hello Steven, >> >>> On 13/04/2024 12:49, Andy Yan wrote: From: Andy Yan The firmware in the rootfs will not be accessible until we are in the SYSTEM_RU

Re: [PATCH 1/1] drm/rockchip: vop2: Fix the port mux of VP2

2024-04-25 Thread Heiko Stübner
Am Montag, 22. April 2024, 12:19:05 CEST schrieb Andy Yan: > From: Andy Yan > > The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX. > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") > Signed-off-by: Andy Yan on a rk3588 with VP3 connected to a DSI display Tested-by: Heiko Stu

Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

2024-04-25 Thread Maxime Ripard
Hi, On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote: > First of all, the driver was introduced when it was already > two drivers available for Ilitek 9341 panels. > > Second, the most recent (fourth!) driver has incorporated this one > and hence, when enabled, it covers the provid

Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

2024-04-25 Thread Andy Shevchenko
On Thu, Apr 25, 2024 at 04:58:06PM +0200, Maxime Ripard wrote: > Hi, > > On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote: > > First of all, the driver was introduced when it was already > > two drivers available for Ilitek 9341 panels. > > > > Second, the most recent (fourth!) dri

Re: [PATCH v1 0/3] drm/panel: ili9341: Obvious fixes

2024-04-25 Thread Andy Shevchenko
On Thu, Apr 25, 2024 at 05:26:16PM +0300, Andy Shevchenko wrote: > A few obvious fixes to the driver. Note, despite the desire of removal Adafruit support from this driver, the older (read: stable) kernels will need this. -- With Best Regards, Andy Shevchenko

Re: [PATCH v4 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-04-25 Thread Sean Anderson
On 4/24/24 14:54, Tomi Valkeinen wrote: > Hi Sean, > > On 23/04/2024 20:18, Sean Anderson wrote: >> This series cleans up the zyqnmp_dp IRQ and locking situation. Once >> that's done, it adds debugfs support. The intent is to enable compliance >> testing or to help debug signal-integrity issues. >

Re: [PATCH 0/1] Fix the port mux of VP2

2024-04-25 Thread Heiko Stuebner
On Mon, 22 Apr 2024 18:19:04 +0800, Andy Yan wrote: > From: Andy Yan > > > The port mux bits of VP2 should be defined by RK3568_OVL_PORT_SET__PORT2_MUX, > this maybe a copy and paste error when this driver first introduced. > Hi Heiko: >Maybe thi is the problem you met when you porting the d

Re: [PATCH v9 1/8] x86/vmware: Correct macro names

2024-04-25 Thread Borislav Petkov
On Wed, Apr 24, 2024 at 04:14:06PM -0700, Alexey Makhalov wrote: > VCPU_RESERVED and LEGACY_X2APIC are not VMware hypercall commands. > These are bits in return value of VMWARE_CMD_GETVCPU_INFO command. > Change VMWARE_CMD_ prefix to GETVCPU_INFO_ one. And move bit-shift > operation to the macro bo

[GIT PULL] mediatek drm next for 6.10

2024-04-25 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Use devm_platform_get_and_ioremap_resource() in mtk_hdmi_ddc_probe() 2. Add GAMMA 12-bit LUT support for MT8188 3. Add 0 size check to mtk_drm_gem_obj 4. Init `ddp_comp` with devm_kcalloc() 5. Rename mtk_drm_* to mtk_* 6. Drop driver owner initialization 7. Fi

Re: [PATCH 2/4] WIP: drm: Introduce rvkms

2024-04-25 Thread Benno Lossin
On 22.04.24 03:54, Lyude Paul wrote: > On Wed, 2024-03-27 at 21:06 +, Benno Lossin wrote: >> On 22.03.24 23:03, Lyude Paul wrote: >>> + >>> +pub(crate) type Connector = connector::Connector; >>> + >>> +impl connector::DriverConnector for DriverConnector { >>> +type Initializer = impl PinIni

Re: [PATCH 1/4] WIP: rust: Add basic KMS bindings

2024-04-25 Thread Benno Lossin
On 22.04.24 03:47, Lyude Paul wrote: > On Wed, 2024-03-27 at 20:50 +, Benno Lossin wrote: >> Hi, >> >> I just took a quick look and commented on the things that stuck >> out to me. Some general things: >> - several `unsafe` blocks have missing SAFETY comments, >> - missing documentation and exa

Re: [PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Neil Armstrong
On 25/04/2024 16:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/pa

Re: [PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe

2024-04-25 Thread Neil Armstrong
On 25/04/2024 16:26, Andy Shevchenko wrote: GPIO controller might not be available when driver is being probed. There are plenty of reasons why, one of which is deferred probe. Since GPIOs are optional, return any error code we got to the upper layer, including deferred probe. With that in mind,

Re: [PATCH v1 3/3] drm/panel: ili9341: Use predefined error codes

2024-04-25 Thread Neil Armstrong
On 25/04/2024 16:26, Andy Shevchenko wrote: In one case the -1 is returned which is quite confusing code for the wrong device ID, in another the ret is returning instead of plain 0 that also confusing as readed may ask the possible meaning of positive codes, which are never the case there. Conver

Re: [PATCH 03/10] dt-bindings: display: panel: Add Synaptics TD4328

2024-04-25 Thread Rob Herring
On Wed, Apr 24, 2024 at 11:29:08PM +0800, Xilin Wu wrote: > Synaptics TD4328 is a display driver IC used to drive LCD DSI panels. > > Signed-off-by: Xilin Wu > --- > .../bindings/display/panel/synaptics,td4328.yaml | 69 > ++ > 1 file changed, 69 insertions(+) > > diff --

Re: [PATCH 08/10] dt-bindings: vendor-prefixes: Add AYN Technologies

2024-04-25 Thread Rob Herring
On Wed, Apr 24, 2024 at 11:29:13PM +0800, Xilin Wu wrote: > Add an entry for AYN Technologies (https://www.ayntec.com/) > > Signed-off-by: Xilin Wu > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/

[GIT PULL] etnaviv-fixes for 6.9

2024-04-25 Thread Lucas Stach
Hi Dave, Sima, please pull the following fixes for the upcoming -rc. One small fix to properly disable TX clock gating on cores where it is known to be broken. The other patch is a bit more controversial, as it reverts a UAPI change that was introduced in the last merge window to better support

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Doug Anderson
Hi, On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula wrote: > > > @@ -279,6 +281,8 @@ enum mipi_dsi_dcs_tear_mode { > > > > ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, > > const void *data, size_t len); > > +ssize_t mipi_dsi_dcs_write_buffer_chatty(s

Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

2024-04-25 Thread Andy Shevchenko
On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: > On Mon, 22 Apr 2024, Andy Shevchenko > wrote: > > Update header inclusions to follow IWYU (Include What You Use) > > principle. > > > > Signed-off-by: Andy Shevchenko > > Assuming it builds, and nothing depends on other stuff from k

Re: [PATCH v9 1/8] x86/vmware: Correct macro names

2024-04-25 Thread Alexey Makhalov
On 4/25/24 8:21 AM, Borislav Petkov wrote: On Wed, Apr 24, 2024 at 04:14:06PM -0700, Alexey Makhalov wrote: VCPU_RESERVED and LEGACY_X2APIC are not VMware hypercall commands. These are bits in return value of VMWARE_CMD_GETVCPU_INFO command. Change VMWARE_CMD_ prefix to GETVCPU_INFO_ one. And

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are using the 'seems' here exactly saying that you are not 100% sure. Please allow me to tell you the truth: Thi

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-25 Thread Janusz Krzysztofik
Hi Thomas, On Tuesday, 16 April 2024 18:40:12 CEST Rodrigo Vivi wrote: > On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: > > Hi Rodrigo, > > > > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: > > > On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 02:08, Sui Jingfeng wrote: Hi, On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are using the 'seems' here exactly saying that you are not 100% su

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-04-25 Thread Jeffrey Hugo
On 4/24/2024 12:37 AM, Tomeu Vizoso wrote: If we expose a render node for NPUs without rendering capabilities, the userspace stack will offer it to compositors and applications for rendering, which of course won't work. Userspace is probably right in not questioning whether a render node might n

Re: [RFC PATCH 02/18] drm/ttm: Add per-BO eviction tracking

2024-04-25 Thread Matthew Brost
On Thu, Apr 25, 2024 at 08:18:38AM +0200, Christian König wrote: > Am 24.04.24 um 18:56 schrieb Friedrich Vock: > > Make each buffer object aware of whether it has been evicted or not. > > That reverts some changes we made a couple of years ago. > > In general the idea is that eviction isn't some

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > On 2024/4/25 22:26, Andy Shevchenko wrote: > > It seems driver missed the point of proper use of device property APIs. > > Correct this by updating headers and calls respectively. > > You are using the 'seems' here exactly saying that

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: > On 2024/4/26 02:08, Sui Jingfeng wrote: Are you speaking to yourself? I'm totally lost. Please, if you want to give a constructive feedback, try to understand the topic from different aspects and then clearly express it. -- With Be

Re: [PATCH v2] drivers/i915/intel_bios: Fix parsing backlight BDB data

2024-04-25 Thread Karthikeyan Ramasubramanian
A kind reminder to review this change. On Wed, Feb 21, 2024 at 6:06 PM Karthikeyan Ramasubramanian wrote: > > Starting BDB version 239, hdr_dpcd_refresh_timeout is introduced to > backlight BDB data. Commit 700034566d68 ("drm/i915/bios: Define more BDB > contents") updated the backlight BDB data

[PATCH] drm/vmwgfx: Fix invalid reads in fence signaled events

2024-04-25 Thread Zack Rusin
Correctly set the length of the drm_event to the size of the structure that's actually used. The length of the drm_event was set to the parent structure instead of to the drm_vmw_event_fence which is supposed to be read. drm_read uses the length parameter to copy the event to the user space thus r

Re: [PATCH 2/2] drm/print: drop include seq_file.h

2024-04-25 Thread Noralf Trønnes
On 4/22/24 14:10, Jani Nikula wrote: > Never include where a forward declaration will suffice. > > Reviewed-by: Andrzej Hajda > Acked-by: Maxime Ripard > Link: > https://patchwork.freedesktop.org/patch/msgid/20240410141434.157908-2-jani.nik...@intel.com > Signed-off-by: Jani Nikula > --- >

[drm-misc:for-linux-next 2/2] drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c:366:9: error: implicit declaration of function 'seq_printf'; did you mean 'drm_printf'?

2024-04-25 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f commit: 9e2b84fb6cd7ee913aa61d461db65c1d6a08dcf2 [2/2] drm/print: drop include seq_file.h config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240426/202404260313.kfrxh

[drm-misc:for-linux-next 2/2] drivers/gpu/drm/omapdrm/omap_fb.c:325:2: error: implicit declaration of function 'seq_printf' is invalid in C99

2024-04-25 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f commit: 9e2b84fb6cd7ee913aa61d461db65c1d6a08dcf2 [2/2] drm/print: drop include seq_file.h config: arm-defconfig (https://download.01.org/0day-ci/archive/20240426/202404260318.h7uzpws

[PATCH 2/2] drm/rockchip: vop2: configure layers for vp3 on rk3588

2024-04-25 Thread Heiko Stuebner
From: Heiko Stuebner The rk3588 VOP2 has 4 video-ports, yet the driver currently only configures the first 3, as used on the rk3568. Add another block to configure the vp3 as well, if applicable. Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") Signed-off-by: Heiko Stuebner -

[PATCH 1/2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-04-25 Thread Heiko Stuebner
From: Heiko Stuebner The clock is in Hz while the value checked against is in kHz, so actual frequencies will never be able to be below to max value. Fix this by specifying the max-value in Hz too. Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") Signed-off-by: Heiko Stuebner

[PATCH 0/2] drm/rockchip: vop2: two fixes from working on DSI enablement

2024-04-25 Thread Heiko Stuebner
While working on enabling DSI support on rk3588 I stumbled across the issue of the display staying black while both the vop2 and dsi drivers were claiming to be running just fine. After a bit of checking I found that I got DSI output on VP3 when HDMI on VP0 was at least associated in the DTS, but

[PATCH] drm/vmwgfx: Fix Legacy Display Unit

2024-04-25 Thread Ian Forbes
Legacy DU was broken by the referenced fixes commit because the placement and the busy_placement no longer pointed to the same object. This was later fixed indirectly by commit a78a8da51b36c7a0c0c16233f91d60aac03a5a49 ("drm/ttm: replace busy placement with flags v6") in v6.9. Fixes: 39985eea5a6d (

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-25 Thread Adam Ford
On Thu, Apr 25, 2024 at 4:19 AM Marek Szyprowski wrote: > > On 12.02.2024 00:09, Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > > the available lanes if there is more than one lane. For certain > > timings and lane configurations, the HFP may not be

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are usi

[PULL] drm-xe-fixes

2024-04-25 Thread Lucas De Marchi
Hi Dave and Sima Please pull the drm-xe-fixes for this week targeting v6.9-rc6. Simple fixes not really visible to end users: 2 around error paths on drm managed allocations and 1 on PF/VF relay messages that are not enabled by default. thanks Lucas De Marchi drm-xe-fixes-2024-04-25: - Fix erro

Re: [PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

2024-04-25 Thread Ira Weiny
Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Acked-by: Dave Jiang Acked-by: Ira Weiny > Signed-off-by: Krzysztof Kozlowski > --- > > Depends on the first patch. > --- > drivers/nvdimm/virtio_pmem.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 03:12, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: On 2024/4/26 02:08, Sui Jingfeng wrote: Are you speaking to yourself? I'm totally lost. Please, if you want to give a constructive feedback, try to understand the topic from different

Re: [PATCH] drm/vmwgfx: Fix invalid reads in fence signaled events

2024-04-25 Thread Maaz Mombasawala
On 4/25/24 12:27, Zack Rusin wrote: > Correctly set the length of the drm_event to the size of the structure > that's actually used. > > The length of the drm_event was set to the parent structure instead of > to the drm_vmw_event_fence which is supposed to be read. drm_read > uses the length para

  1   2   >