[PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt()

2024-04-15 Thread Jiapeng Chong
No functional modification involved. ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 Signed-off-by: Jiapeng Chong --- Changes in v2: -Make the commit message more clearer. drivers/gpu/drm/xe/xe_i

Re: [PATCH] drm/bridge: sii902x: Fix mode_valid hook

2024-04-15 Thread Maxime Ripard
Hi, On Mon, Apr 08, 2024 at 01:44:35PM +0530, Jayesh Choudhary wrote: > Currently, mode_valid hook returns all mode as valid. Add the check > for the maximum and minimum pixel clock that the bridge can support > while validating a mode. > > Signed-off-by: Jayesh Choudhary > --- > drivers/gpu/dr

Re: [PATCH 00/18] backlight: Constify lcd_ops

2024-04-15 Thread Krzysztof Kozlowski
On 15/04/2024 08:56, Thomas Zimmermann wrote: > Hi > > for patches 16, 17 and 18: > > Reviewed-by: Thomas Zimmermann This does not work like this. Toolset will apply your review tag for EVERYTHING. You must provide tag under each individual patch. Best regards, Krzysztof

[PATCH] gpu: drm: exynos: hdmi: eliminate uses of of_node_put()

2024-04-15 Thread Shivani Gupta
Utilize the __free() cleanup handler within the hdmi_get_phy_io function to automatically release the device node when it is out of scope. This eliminates the manual invocation of of_node_put(), reducing the potential for memory leaks. The modification requires initializing the device node at the

Re: [PATCH v2 1/2] dt-bindings: panel-simple-dsi: add Khadas TS050 V2 panel bindings

2024-04-15 Thread Krzysztof Kozlowski
On 15/04/2024 05:14, Jacobe Zang wrote: > This add the bindings for the Khadas TS050 V2 1080x1920 5" LCD DSI panel > designed to work with the Khadas VIM3 and VIM3L Single Board Computers. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that thes

Re: [PATCH v2 0/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-15 Thread Krzysztof Kozlowski
On 15/04/2024 05:14, Jacobe Zang wrote: > Changes from v1 at [1]: > - Fix name from "newts050" to "ts050v2" > - Add specific description about controller change You must say that you ignored/dropped received tags. Best regards, Krzysztof

Re: [PATCH v2 0/5] drm/vmwgfx: vblank and crc generation support

2024-04-15 Thread Martin Krastev
On Fri, Apr 12, 2024 at 5:36 PM Martin Krastev wrote: > > On Fri, Apr 12, 2024 at 5:55 AM Zack Rusin wrote: > > > > vmwgfx didn't have support for vblank or crc generation which made it > > impossible to use a large number of IGT tests to properly test DRM > > functionality in the driver. > > > >

Re: (subset) [PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-04-15 Thread Maxime Ripard
On Wed, 10 Apr 2024 14:20:06 +0200, Sebastian Wick wrote: > When extending support for a driver-specific KMS property to additional > drivers, we should apply all the requirements for new properties and > make sure the semantics are the same and documented. > > v2: devs of the driver which introdu

Re: (subset) [PATCH] drm: vc4: Fix possible null pointer dereference

2024-04-15 Thread Maxime Ripard
On Tue, 09 Apr 2024 10:56:22 +0300, Aleksandr Mishin wrote: > In vc4_hdmi_audio_init() of_get_address() may return > NULL which is later dereferenced. Fix this bug by adding NULL check. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Applied to misc/kernel.git (drm-mis

Re: (subset) [PATCH] drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2

2024-04-15 Thread Maxime Ripard
On Fri, 05 Apr 2024 16:35:10 +0200, Arnd Bergmann wrote: > After my fix yesterday, I ran into another problem of the same kind: > > aarch64-linux-ld: drivers/gpu/drm/bridge/analogix/analogix_dp_core.o: in > function `drm_dp_dpcd_readb': > analogix_dp_core.c:(.text+0x194): undefined reference to `

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-15 Thread Pekka Paalanen
On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: > On 2024-04-12 11:31, Alex Deucher wrote: > > On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen > > wrote: > >> > >> On Fri, 12 Apr 2024 10:28:52 -0400 > >> Leo Li wrote: > >> > >>> On 2024-04-12 04:03, Pekka Paalanen wrote: > On Thu, 1

Re: [PATCH] drm/panthor: Add defer probe for firmware load

2024-04-15 Thread Steven Price
On 13/04/2024 12:49, Andy Yan wrote: > From: Andy Yan > > The firmware in the rootfs will not be accessible until we > are in the SYSTEM_RUNNING state, so return EPROBE_DEFER until > that point. > This let the driver can load firmware when it is builtin. The usual solution is that the firmware s

Re: [PATCH v2] drm: nv04: Fix out of bounds access

2024-04-15 Thread Danilo Krummrich
On 4/11/24 13:08, Mikhail Kobuk wrote: When Output Resource (dcb->or) value is assigned in fabricate_dcb_output(), there may be out of bounds access to dac_users array in case dcb->or is zero because ffs(dcb->or) is used as index there. The 'or' argument of fabricate_dcb_output() must be interpre

Re: [PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-15 Thread Danilo Krummrich
On 4/11/24 03:15, Dave Airlie wrote: From: Dave Airlie Running a lot of VK CTS in parallel against nouveau, once every few hours you might see something like this crash. BUG: kernel NULL pointer dereference, address: 0008 PGD 800114e6e067 P4D 800114e6e067 PUD 109046067 PMD

Re: [PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag

2024-04-15 Thread Maxime Ripard
Hi, On Wed, Apr 03, 2024 at 06:26:53PM +0800, Shawn Sung wrote: > From: "Jason-JH.Lin" > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate > a secure buffer to support secure video path feature. > > Signed-off-by: Jason-JH.Lin > Signed-off-by: Hsiao Chien Sung > --- > include

Re: [PATCH v5 2/9] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2024-04-15 Thread Maxime Ripard
On Wed, Apr 03, 2024 at 06:26:54PM +0800, Shawn Sung wrote: > From: "Jason-JH.Lin" > > Add secure buffer control flow to mtk_drm_gem. > > When user space takes DRM_MTK_GEM_CREATE_ENCRYPTED flag and size > to create a mtk_drm_gem object, mtk_drm_gem will find a matched size > dma buffer from secu

[PATCH] drm/nouveau: fix duplicate pointer to struct drm_device

2024-04-15 Thread Danilo Krummrich
nouveau_uvmm_ioctl_vm_init() already has a pointer to struct drm_device, no need to derive another one from struct drm_file. Fixes: 266f7618e761 ("drm/nouveau: separately allocate struct nouveau_uvmm") Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 3 +-- 1 file cha

[PATCH] drm/nouveau: use vmemdup_array_user() in u_memcpya()

2024-04-15 Thread Danilo Krummrich
Now that we have vmemdup_array_user(), make use of it. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_drv.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h index e239c6bf4a

[PATCH][next] drm/i915: remove redundant assignement to variable err

2024-04-15 Thread Colin Ian King
The variable err is being assigned a value 0 that is never read, the break statement escapes a do-while loop and then the code returns without referencing err. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:107

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC

Re: [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt()

2024-04-15 Thread Chauhan, Shekhar
On 4/15/2024 12:37, Jiapeng Chong wrote: No functional modification involved. ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. What i meant in the first review, was the commit description. The commit subject looks better now, but the issue remains the same: Line numbers will chang

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c  | 5 + >  drivers/gpu/drm/i915/display/intel_display_types.h | 1 + >  2 files

Re: [PATCH v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt()

2024-04-15 Thread Chauhan, Shekhar
On 4/15/2024 12:37, Jiapeng Chong wrote: No functional modification involved. ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. What i meant in the first review, was the commit description. The commit subject looks better now, but the issue remains the same: Line numbers will change

Re: [PATCH v2 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-15 Thread Hogander, Jouni
On Fri, 2024-04-12 at 21:22 +0530, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- >  drivers/gpu/drm/i915/display/intel_alpm.c | 47 > +++ >  drivers/gpu/drm/i915/display/intel_alpm.h |  2 + >  .../drm/i915/display

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-04-15 Thread zhiguojiang
在 2024/4/12 14:39, Christian König 写道: [Some people who received this message don't often get email from christian.koe...@amd.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Am 12.04.24 um 08:19 schrieb zhiguojiang: [SNIP] -> Here task 2220 do epoll agai

Re: [PATCH 1/5] drm/v3d: Don't increment `enabled_ns` twice

2024-04-15 Thread Tvrtko Ursulin
On 03/04/2024 21:24, Maíra Canal wrote: The commit 509433d8146c ("drm/v3d: Expose the total GPU usage stats on sysfs") introduced the calculation of global GPU stats. For the regards, it used the already existing infrastructure provided by commit 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo()

Re: [PATCH 3/5] drm/v3d: Create a struct to store the GPU stats

2024-04-15 Thread Tvrtko Ursulin
On 03/04/2024 21:24, Maíra Canal wrote: This will make it easier to instantiate the GPU stats variables and it will create a structure where we can store all the variables that refer to GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 14 ++ drivers/g

Re: [PATCH 4/5] drm/v3d: Create function to update a set of GPU stats

2024-04-15 Thread Tvrtko Ursulin
On 03/04/2024 21:24, Maíra Canal wrote: Given a set of GPU stats, that is, a `struct v3d_stats` related to a queue in a given context, create a function that can update all this set of GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_sched.c | 20 1 fi

Re: [PATCH v2 6/6] drm/v3d: Enable big and super pages

2024-04-15 Thread Tvrtko Ursulin
On 05/04/2024 19:29, Maíra Canal wrote: The V3D MMU also supports 64KB and 1MB pages, called big and super pages, respectively. In order to set a 64KB page or 1MB page in the MMU, we need to make sure that page table entries for all 4KB pages within a big/super page must be correctly configured

Re: [PATCH 5/5] drm/v3d: Fix race-condition between sysfs/fdinfo and interrupt handler

2024-04-15 Thread Tvrtko Ursulin
On 03/04/2024 21:24, Maíra Canal wrote: In V3D, the conclusion of a job is indicated by a IRQ. When a job finishes, then we update the local and the global GPU stats of that queue. But, while the GPU stats are being updated, a user might be reading the stats from sysfs or fdinfo. For example,

Re: [PATCH v2 2/6] drm/gem: Create a drm_gem_object_init_with_mnt() function

2024-04-15 Thread Tvrtko Ursulin
On 05/04/2024 19:29, Maíra Canal wrote: For some applications, such as applications that uses huge pages, we might want to have a different mountpoint, for which we pass mount flags that better match our usecase. Therefore, create a new function `drm_gem_object_init_with_mnt()` that allow us t

Re: [PATCH][next] drm/i915: remove redundant assignement to variable err

2024-04-15 Thread Andi Shyti
Hi Colin, On Mon, Apr 15, 2024 at 10:56:59AM +0100, Colin Ian King wrote: > The variable err is being assigned a value 0 that is never read, the > break statement escapes a do-while loop and then the code returns > without referencing err. The assignment is redundant and can be > removed. > > Cle

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-15 Thread Maxime Ripard
Hi Mark On Wed, Apr 10, 2024 at 07:06:39PM +0100, Mark Brown wrote: > On Wed, Apr 03, 2024 at 12:56:18PM +0200, Maxime Ripard wrote: > > Hi, > > > > Here's a series addressing the various regressions that were reported > > after the Kconfig rework for the DRM display helpers. > > > > Let me know

Re: [PATCH v2 4/6] drm/gem: Create shmem GEM object in a given mountpoint

2024-04-15 Thread Tvrtko Ursulin
On 05/04/2024 19:29, Maíra Canal wrote: Create a function `drm_gem_shmem_create_with_mnt()`, similar to `drm_gem_shmem_create()`, that has a mountpoint as a argument. This function will create a shmem GEM object in a given tmpfs mountpoint. This function will be useful for drivers that have a

[PATCH] drm/gma500: Remove lid code

2024-04-15 Thread Patrik Jakobsson
Due to a change in the order of initialization, the lid timer got started before proper setup was made. This resulted in a crash during boot. The lid switch is handled by gma500 through a timer that periodically polls the opregion for changes. These types of ACPI events shouldn't be handled by the

Re: [PATCH 2/5] drm/v3d: Create two functions to update all GPU stats variables

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: Currently, we manually perform all operations to update the GPU stats variables. Apart from the code repetition, this is very prone to errors, as we can see on the previous commit. Therefore, create two functions to manage updating all GPU stats varia

Re: [PATCH 1/5] drm/v3d: Don't increment `enabled_ns` twice

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: The commit 509433d8146c ("drm/v3d: Expose the total GPU usage stats on sysfs") introduced the calculation of global GPU stats. For the regards, it used the already existing infrastructure provided by commit 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo

Re: [PATCH 2/3] drm: drm_blend.c: Improve drm_plane_create_rotation_property kernel doc

2024-04-15 Thread Pekka Paalanen
On Tue, 09 Apr 2024 12:04:06 +0200 Louis Chauvet wrote: > The expected behavior of the rotation property was not very clear. Add > more examples to explain what is the expected result. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/drm_blend.c | 52 >

Re: [PATCH 4/5] drm/v3d: Create function to update a set of GPU stats

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: Given a set of GPU stats, that is, a `struct v3d_stats` related to a queue in a given context, create a function that can update all this set of GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_sched.c | 20 1

Re: [PATCH] drm/gma500: Remove lid code

2024-04-15 Thread Thomas Zimmermann
Hi Am 15.04.24 um 13:27 schrieb Patrik Jakobsson: Due to a change in the order of initialization, the lid timer got started before proper setup was made. This resulted in a crash during boot. The lid switch is handled by gma500 through a timer that periodically polls the opregion for changes. T

Re: [PATCH v2 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > Move ALPM feature related code as it will be used for > non-psr panel also thorugh LOBF feature. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_alpm.c | 292 +

Re: [PATCH v2 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h > b/drivers/gpu/drm/i915/display/intel_alpm.h > index c45d078e5a6b..c341d2c2b7f7 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > @@ -10,9

Re: [PATCH v2 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > Set the Link Off Between Frames Enable bit in ALPM_CTL register. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 5 + > drivers/gpu/drm/i915/display/intel_display_types.h | 1 + > 2 files changed, 6 ins

Re: [PATCH v2 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-15 Thread Jani Nikula
On Fri, 12 Apr 2024, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 47 +++ > drivers/gpu/drm/i915/display/intel_alpm.h | 2 + > .../drm/i915/display/intel_display_d

Re: [PATCH] drm/gma500: Remove lid code

2024-04-15 Thread Patrik Jakobsson
On Mon, Apr 15, 2024 at 1:45 PM Thomas Zimmermann wrote: > > Hi > > Am 15.04.24 um 13:27 schrieb Patrik Jakobsson: > > Due to a change in the order of initialization, the lid timer got > > started before proper setup was made. This resulted in a crash during > > boot. > > > > The lid switch is han

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-04-15 Thread Christian König
Am 15.04.24 um 12:35 schrieb zhiguojiang: 在 2024/4/12 14:39, Christian König 写道: [Some people who received this message don't often get email from christian.koe...@amd.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Am 12.04.24 um 08:19 schrieb zhiguojiang:

Re: [PATCH 3/3] drm/fourcc: Add documentation around drm_format_info

2024-04-15 Thread Pekka Paalanen
On Tue, 09 Apr 2024 12:04:07 +0200 Louis Chauvet wrote: > Let's provide more details about the drm_format_info structure because > its content may not be straightforward for someone not used to video > formats and drm internals. > > Signed-off-by: Louis Chauvet > --- > include/drm/drm_fourcc.h

Re: [PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

2024-04-15 Thread Somalapuram, Amaranath
On 3/22/2024 7:59 PM, Karolina Stolarek wrote: Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stol

Re: [PATCH net-next v9 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-04-15 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Fri, 12 Apr 2024 17:38:31 +0200 you wrote: > This patch adds XDP support to TI AM65 CPSW Ethernet driver. > > The following features are implemented: NETDEV_XDP_ACT_BASIC, > NETDEV_XDP_ACT_REDIRECT, and NETDEV_X

Re: [PATCH] drm: vop2: Do not divide height twice for YUV

2024-04-15 Thread Andy Yan
Hi, On 4/15/24 02:27, Detlev Casanova wrote: For the cbcr format, gt2 and gt4 are computed again after src_h has been divided by vsub. As src_h as already been divided by 2 before, introduce cbcr_src_h and cbcr_src_w to keep a copy of those values to be used for cbcr gt2 and gt4 computation. T

Patch "drm/ast: Fix soft lockup" has been added to the 6.8-stable tree

2024-04-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Fix soft lockup to the 6.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-ast-fix-soft-lockup.patch

Patch "drm/vmwgfx: Enable DMA mappings with SEV" has been added to the 6.8-stable tree

2024-04-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Enable DMA mappings with SEV to the 6.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-vmwgfx-ena

Re: [PATCH 01/18] backlight: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:35:59PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' passed in lcd_device_register() is not modified by core > backlight code, so it can be made const for code safety. This allows > drivers to also define the structure as const. > > Signed-off-by: Krzysztof Kozlo

Re: [PATCH 02/18] backlight: ams369fg06: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:00PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Patch "drm/ast: Fix soft lockup" has been added to the 6.6-stable tree

2024-04-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Fix soft lockup to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-ast-fix-soft-lockup.patch

Patch "drm/vmwgfx: Enable DMA mappings with SEV" has been added to the 6.6-stable tree

2024-04-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/vmwgfx: Enable DMA mappings with SEV to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-vmwgfx-ena

Re: [PATCH 03/18] backlight: corgi_lcd: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:01PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Patch "drm/ast: Fix soft lockup" has been added to the 6.1-stable tree

2024-04-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Fix soft lockup to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-ast-fix-soft-lockup.patch

Re: [PATCH 04/18] backlight: hx8357: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:02PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 05/18] backlight: ili922x: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:03PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 06/18] backlight: ili9320: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:04PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH] drm/sysfs: Add drm class-wide attribute to get active device clients

2024-04-15 Thread Tvrtko Ursulin
On 05/04/2024 18:59, Rob Clark wrote: On Wed, Apr 3, 2024 at 11:37 AM Adrián Larumbe wrote: Up to this day, all fdinfo-based GPU profilers must traverse the entire /proc directory structure to find open DRM clients with fdinfo file descriptors. This is inefficient and time-consuming. This p

Re: [PATCH 07/18] backlight: jornada720_lcd: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:05PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 08/18] backlight: l4f00242t03: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:06PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 09/18] backlight: lms283gf05: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:07PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 10/18] backlight: lms501kf03: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:08PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 11/18] backlight: ltv350qv: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:09PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v2 3/4] drm/i915/bios: switch to struct drm_edid and struct drm_edid_product_id

2024-04-15 Thread Jani Nikula
On Tue, 09 Apr 2024, Ville Syrjälä wrote: > On Tue, Apr 09, 2024 at 12:46:11PM +0300, Jani Nikula wrote: >> To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch >> to the struct drm_edid based function to extract product id, and use the >> drm printer function to debug log it. >

Re: [PATCH 12/18] backlight: otm3225a: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:10PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 13/18] backlight: platform_lcd: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:11PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 14/18] backlight: tdo24m: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:36:12PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 00/18] backlight: Constify lcd_ops

2024-04-15 Thread Daniel Thompson
On Sun, Apr 14, 2024 at 06:35:58PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Dependencies > > All further patches depend on the first patch. Therefore everything > could go via backlight tree (please ack) or via cross-tree pulls. Or > whatever maintainer choose, just coordinate this

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. While all of this is trivial, merely adding some includes, please consider acking the changes to your corner of the kernel. Thanks, Jani. > > Signed-off-by: Jani Ni

Re: [PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-15 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > We've accumulated enough Intel specific header files under include/drm > that they warrant a subdirectory of their own. Clean up the top drm > header directory by moving the Intel files under include/drm/intel. > > Since i915 is most impacted, I suggest me

Re: [PATCH v2 0/7] drm: debug logging improvements

2024-04-15 Thread Jani Nikula
On Mon, 08 Apr 2024, Jani Nikula wrote: > v2 of [1], dropping drm_mode_print() stuff altogether, and switching to > DRM_MODE_FMT/DRM_MODE_ARG() in a separate patch. Also add a few more drm > device based logging conversion patches, so the last patch makes more sense. Thanks for the reviews, pushe

[PATCH] drm/ttm: stop pooling cached NUMA pages v2

2024-04-15 Thread Christian König
From: Christian König We only pool write combined and uncached allocations because they require extra overhead on allocation and release. If we also pool cached NUMA it not only means some extra unnecessary overhead, but also that under memory pressure it can happen that pages from the wrong NUM

Re: [PATCH] drm/ttm: stop pooling cached NUMA pages v2

2024-04-15 Thread Felix Kuehling
On 2024-04-15 9:48, Christian König wrote: From: Christian König We only pool write combined and uncached allocations because they require extra overhead on allocation and release. If we also pool cached NUMA it not only means some extra unnecessary overhead, but also that under memory pressur

Re: [PATCH] drm/amdgpu: Add missing space to DRM_WARN() message

2024-04-15 Thread Alex Deucher
On Mon, Apr 15, 2024 at 4:40 AM Thorsten Blum wrote: > > s/,please/, please/ > > Signed-off-by: Thorsten Blum Reviewed-by: Alex Deucher And applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

2024 X.Org Foundation Election Results

2024-04-15 Thread Ricardo Garcia
The Board of Directors election concluded on 08 April 2024. There were 81 Members of the X.Org Foundation eligible to vote, and 61 Members cast votes. This is a 75.3% turn out. In the election of the Directors to the Board of the X.Org Foundation, the results were that Erik Faye-Lund, Simon Ser, M

Re: [PATCH] drm/ttm: stop pooling cached NUMA pages v2

2024-04-15 Thread Christian König
Am 15.04.24 um 15:53 schrieb Felix Kuehling: On 2024-04-15 9:48, Christian König wrote: From: Christian König We only pool write combined and uncached allocations because they require extra overhead on allocation and release. If we also pool cached NUMA it not only means some extra unnecessar

Re: [PATCH 3/3] drm/fourcc: Add documentation around drm_format_info

2024-04-15 Thread Bagas Sanjaya
On Tue, Apr 09, 2024 at 12:04:07PM +0200, Louis Chauvet wrote: > /** > * struct drm_format_info - information about a DRM format > + * > + * A drm_format_info describes how planes and pixels are stored in memory. > + * > + * Some format like YUV can have multiple planes, counted in @num_planes.

Re: Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Maxime Ripard
On Mon, 15 Apr 2024 16:09:22 +0300, Jani Nikula wrote: > On Wed, 10 Apr 2024, Jani Nikula wrote: > > Surprisingly many places depend on debugfs.h to be included via > > drm_print.h. Fix them. > > While all of this is trivial, merely adding some includes, please > > [ ... ] Acked-by: Maxime Ripa

Re: [PATCH 2/3] drm: drm_blend.c: Improve drm_plane_create_rotation_property kernel doc

2024-04-15 Thread Bagas Sanjaya
On Tue, Apr 09, 2024 at 12:04:06PM +0200, Louis Chauvet wrote: > @@ -266,8 +257,41 @@ EXPORT_SYMBOL(drm_plane_create_alpha_property); > * > * Rotation is the specified amount in degrees in counter clockwise > direction, > * the X and Y axis are within the source rectangle, i.e. the X/Y axis

[PATCH 6.8 123/172] drm/vmwgfx: Enable DMA mappings with SEV

2024-04-15 Thread Greg Kroah-Hartman
6.8-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit 4c08f01934ab67d1d283d5cbaa52b923abcfe4cd upstream. Enable DMA mappings in vmwgfx after TTM has been fixed in commit 3bf3710e3718 ("drm/ttm: Add a generic TTM memcpy move for p

[PATCH 6.8 126/172] drm/ast: Fix soft lockup

2024-04-15 Thread Greg Kroah-Hartman
6.8-stable review patch. If anyone has any objections, please let me know. -- From: Jammy Huang commit bc004f5038220b1891ef4107134ccae44be55109 upstream. There is a while-loop in ast_dp_set_on_off() that could lead to infinite-loop. This is because the register, VGACRI-Dx, che

Re: [PATCH 1/3] drm: drm_blend.c: Add precision in drm_rotation_simplify kernel doc

2024-04-15 Thread Bagas Sanjaya
On Tue, Apr 09, 2024 at 12:04:05PM +0200, Louis Chauvet wrote: > diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c > index 6e74de833466..8d4b317eb9d7 100644 > --- a/drivers/gpu/drm/drm_blend.c > +++ b/drivers/gpu/drm/drm_blend.c > @@ -321,6 +321,11 @@ EXPORT_SYMBOL(drm_plane_cr

Re: [PATCH] drm/ttm: stop pooling cached NUMA pages v2

2024-04-15 Thread Felix Kuehling
On 2024-04-15 10:08, Christian König wrote: Am 15.04.24 um 15:53 schrieb Felix Kuehling: On 2024-04-15 9:48, Christian König wrote: From: Christian König We only pool write combined and uncached allocations because they require extra overhead on allocation and release. If we also pool cached

Re: [PATCH] doc: dma-buf: fix grammar typo

2024-04-15 Thread Christian König
Am 14.04.24 um 15:07 schrieb Baruch Siach: Signed-off-by: Baruch Siach --- Documentation/driver-api/dma-buf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst index 0c153d79ccc4..29abf1eebf9f 100

[PATCH 6.6 088/122] drm/vmwgfx: Enable DMA mappings with SEV

2024-04-15 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Zack Rusin commit 4c08f01934ab67d1d283d5cbaa52b923abcfe4cd upstream. Enable DMA mappings in vmwgfx after TTM has been fixed in commit 3bf3710e3718 ("drm/ttm: Add a generic TTM memcpy move for p

[PATCH 6.6 091/122] drm/ast: Fix soft lockup

2024-04-15 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Jammy Huang commit bc004f5038220b1891ef4107134ccae44be55109 upstream. There is a while-loop in ast_dp_set_on_off() that could lead to infinite-loop. This is because the register, VGACRI-Dx, che

Re: [PATCH] drm/ttm: stop pooling cached NUMA pages v2

2024-04-15 Thread Christian König
Am 15.04.24 um 16:32 schrieb Felix Kuehling: On 2024-04-15 10:08, Christian König wrote: Am 15.04.24 um 15:53 schrieb Felix Kuehling: On 2024-04-15 9:48, Christian König wrote: From: Christian König We only pool write combined and uncached allocations because they require extra overhead on a

[bug report] drm/nouveau/disp/r535: initial support

2024-04-15 Thread Dan Carpenter
Hello Nouveau Devs, Commit 9e999023 ("drm/nouveau/disp/r535: initial support") from Sep 19, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c:1482 r535_disp_oneinit() error: potential NULL/IS_ERR bug 'ctrl' drivers/gpu/dr

[PATCH 6.1 48/69] drm/ast: Fix soft lockup

2024-04-15 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Jammy Huang commit bc004f5038220b1891ef4107134ccae44be55109 upstream. There is a while-loop in ast_dp_set_on_off() that could lead to infinite-loop. This is because the register, VGACRI-Dx, che

Re: [PATCH v12 0/9] drm/panic: Add a drm panic handler

2024-04-15 Thread Jocelyn Falempe
On 10/04/2024 10:12, Daniel Vetter wrote: On Tue, Apr 09, 2024 at 06:30:39PM +0200, Jocelyn Falempe wrote: drm/panic: Add a drm panic handler This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic.

[PATCH] drm/fb_dma: s/drm_panic_gem_get_scanout_buffer/drm_fb_dma_get_scanout_buffer

2024-04-15 Thread Maíra Canal
On version 11, Thomas suggested to change the name of the function and this request was applied on version 12, which is the version that landed. Although the name of the function changed on the C file, it didn't changed on the header file, leading to a compilation error as such: drivers/gpu/drm/im

Re: [PATCH] drm/fb_dma: s/drm_panic_gem_get_scanout_buffer/drm_fb_dma_get_scanout_buffer

2024-04-15 Thread Jocelyn Falempe
Hi, You're right, I messed up the rename, and I mostly test on x86, where I don't build the imx driver. Reviewed-by: Jocelyn Falempe Best regards, -- Jocelyn On 15/04/2024 17:09, Maíra Canal wrote: On version 11, Thomas suggested to change the name of the function and this request was ap

Re: [PATCH 3/5] drm/v3d: Create a struct to store the GPU stats

2024-04-15 Thread Chema Casanova
El 3/4/24 a las 22:24, Maíra Canal escribió: This will make it easier to instantiate the GPU stats variables and it will create a structure where we can store all the variables that refer to GPU stats. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 14 ++ driver

Re: [PATCH] doc: dma-buf: fix grammar typo

2024-04-15 Thread Baruch Siach
Hi Christian, On Mon, Apr 15 2024, Christian König wrote: > Am 14.04.24 um 15:07 schrieb Baruch Siach: >> Signed-off-by: Baruch Siach >> --- >> Documentation/driver-api/dma-buf.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/driver-api/dma-buf.rst

[PATCH RFC 2/2] pmdomain: ti-sci: Support retaining PD boot time state

2024-04-15 Thread Tomi Valkeinen
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts when referring to power domains. When this flag is set, the ti-sci driver will check if the PD is currently enabled in the HW, and if so, set the GENPD_FLAG_ALWAYS_ON flag so that the PD will stay enabled. The main issue I'm tr

[PATCH RFC 1/2] pmdomain: ti-sci: Fix duplicate PD referrals

2024-04-15 Thread Tomi Valkeinen
When the dts file has multiple referrers to a single PD (e.g. simple-framebuffer and dss nodes both point to the DSS power-domain) the ti-sci driver will create two power domains, both with the same ID, and that will cause problems as one of the power domains will hide the other one. Fix this chec

  1   2   >