Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

Hi Laurent, On Tue, Mar 26, 2024 at 12:03:38AM +0200, Laurent Pinchart wrote: > Hi Tommaso, > > On Mon, Mar 25, 2024 at 10:48:56PM +0100, Tommaso Merciai wrote: > > Hi Adam, Lucas, > > Thanks for this series. > > > > This series make HDMI work on evk. > > All is working properly on my side. > >

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

Hi all, Am 25.03.24 um 19:30 schrieb Hans de Goede: [snip] If the kernel already handles the custom protocol into generic HID, the work for userspace is not too hard because they can deal with a known protocol and can be cross-platform in their implementation. I'm mentioning that cross-platfor

Re: Build regressions/improvements in v6.9-rc1

On Mon, 25 Mar 2024, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.9-rc1[1] compared to v6.8[2]. Summarized: - build errors: +8/-8 + /kisskb/src/crypto/scompress.c: error: unused variable 'dst_page' [-Werror=unused-variable]: => 174:38

Re: [PATCH v6 12/13] drm/ast: Implement polling for VGA and SIL164 connectors

On Mon, 25 Mar 2024 21:06:57 +0100, Thomas Zimmermann wrote: > Implement polling for VGA and SIL164 connectors. Set the flag > DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the > monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx > for each type of connector by

Re: [PATCH net-next v4 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

On 2024-03-25 at 21:30:36, Julien Panis (jpa...@baylibre.com) wrote: > This patch introduces a member and the related accessors which can be > used to store descriptor specific additional information. This member > can store, for instance, an ID to differentiate a skb TX buffer type > from a xdpf T

Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

On Mon, 4 Mar 2024 18:09:52 +0800, Andy Yan wrote: > From: Andy Yan > > The Alpha blending for 30 bit RGB/BGR are not > functioning properly for rk3568/rk3588, so remove > it from the format list. > > > [...] Applied, thanks! [1/1] drm/rockchip: vop2: Remove AR30 and AB30 format support

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

Makes sense to me! Reviewed-by: Simon Ser

[PATCH] drm/panthor: Fix wrong kernel-doc format in the uAPI header

The kernel doc prefix is /** not /*. Reported-by: Stephen Rothwell Signed-off-by: Boris Brezillon --- include/uapi/drm/panthor_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 373df80f41ed..dadb05

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags

On Wed, 20 Mar 2024 14:12:31 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > Similar to other variants, the LTK050H3148W wants to run in video mode > when displaying data. So far only the Synopsis DSI driver was using this > panel and it is always switching to video mode, independent of t

Re: [PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

On Mon, Mar 25, 2024 at 07:02:13PM +0100, Boris Brezillon wrote: > On Mon, 25 Mar 2024 17:16:16 + > Liviu Dudau wrote: > > > On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote: > > > Make sure we set suspended=true last to avoid generating an irq storm > > > in the unlikely case

Re: [PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

On 3/21/2024 1:41 AM, Imre Deak wrote: Fix the calculation of the DSC line buffer depth. This is limited both by the source's and sink's maximum line buffer depth, but the former one was not taken into account. On all Intel platform's the source's maximum buffer depth is 13, so the overall limi

[PATCH][next] drm/panthor: Fix spelling mistake "readyness" -> "readiness"

There is a spelling mistake in a drm_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/panthor/panthor_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c index 6dbbc4cfbe7e.

Re: [PATCH] drm/panthor: Fix wrong kernel-doc format in the uAPI header

On Tue, Mar 26, 2024 at 10:30:55AM +0100, Boris Brezillon wrote: > The kernel doc prefix is /** not /*. > > Reported-by: Stephen Rothwell > Signed-off-by: Boris Brezillon Acked-by: Liviu Dudau Best regards, Liviu > --- > include/uapi/drm/panthor_drm.h | 4 ++-- > 1 file changed, 2 insertion

Re: [PATCH][next] drm/panthor: Fix spelling mistake "readyness" -> "readiness"

On Tue, Mar 26, 2024 at 10:02:19AM +, Colin Ian King wrote: > There is a spelling mistake in a drm_err message. Fix it. > > Signed-off-by: Colin Ian King Acked-by: Liviu Dudau Boris, can you also pick this one up when you're pushing your kernel doc fix? Best regards, Liviu > --- > drive

Re: [PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

On Tue, 26 Mar 2024 09:58:17 + Liviu Dudau wrote: > On Mon, Mar 25, 2024 at 07:02:13PM +0100, Boris Brezillon wrote: > > On Mon, 25 Mar 2024 17:16:16 + > > Liviu Dudau wrote: > > > > > On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote: > > > > Make sure we set suspende

Re: [PATCH][next] drm/panthor: Fix spelling mistake "readyness" -> "readiness"

On Tue, 26 Mar 2024 10:14:37 + Liviu Dudau wrote: > On Tue, Mar 26, 2024 at 10:02:19AM +, Colin Ian King wrote: > > There is a spelling mistake in a drm_err message. Fix it. > > > > Signed-off-by: Colin Ian King > > Acked-by: Liviu Dudau > > Boris, can you also pick this one up whe

[PATCH v2 00/12] drm/display: Convert helpers Kconfig symbols to depends on

Hi, Jani recently pointed out that the Kconfig symbols are a bit difficult to work with at the moment when they depend on each other, and that using depends on would be a better idea, but no one really did the work so far. So here it goes :) It's been tested by comparing the riscv defconfig, arm

[PATCH v2 01/12] drm/display: Make DisplayPort AUX bus Kconfig name consistent

While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort AUX bus implementation uses DRM_DP_AUX_BUS. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Reviewed-by: Jani Nikula Reviewed-by: Lucas De March

[PATCH v2 02/12] drm/display: Make DisplayPort tunnel debug Kconfig name consistent

While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort Tunnel debugging uses DRM_DISPLAY_DEBUG_DP_TUNNEL_STATE. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Reviewed-by: Jani Nikula Reviewed-by: L

[PATCH v2 04/12] drm/display: Make DisplayPort CEC-over-AUX Kconfig name consistent

While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort CEC tunnelling implementation uses CONFIG_DRM_DISPLAY_DP_AUX_CEC. Since the number of users is limited, we can easily rename it to make it consistent. Reviewed-by: Jani Nikula Reviewed-by: Lucas De Marchi S

[PATCH v2 05/12] drm/display: Reorder Kconfig symbols

The display kconfig helpers are not organized in any particular order, so let's move them around to create an alphabetical order. Reviewed-by: Jani Nikula Reviewed-by: Lucas De Marchi Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/Kconfig | 52

[PATCH v2 06/12] drm/display: Make all helpers visible and switch to depends on

All the helpers Kconfig symbols so far have relied on drivers selecting them, and that's what most drivers did. However, this creates an issue nowadays when helpers depend on each other, and select doesn't transitively select a dependency dependencies. Depends on doesn't have that limitation thou

[PATCH v2 07/12] drm: Switch DRM_DISPLAY_HELPER to depends on

Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH v2 08/12] drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on

Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH v2 09/12] drm: Switch DRM_DISPLAY_DP_HELPER to depends on

Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH v2 10/12] drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on

Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH v2 11/12] drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on

Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH v2 12/12] drm/bridge: it6505: Remove useless select

The IT6505 bridge Kconfig symbol selects a Kconfig symbol that doesn't exist. Remove it. Reviewed-by: Jani Nikula Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig in

[PATCH v2 03/12] drm/display: Make DisplayPort AUX Chardev Kconfig name consistent

While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort-AUX chardev interface uses DRM_DP_AUX_CHARDEV. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Reviewed-by: Jani Nikula Reviewed-by: Lucas De Ma

Re: [PATCH][next] drm/panthor: Fix spelling mistake "readyness" -> "readiness"

On Tue, 26 Mar 2024 10:02:19 + Colin Ian King wrote: > There is a spelling mistake in a drm_err message. Fix it. > > Signed-off-by: Colin Ian King Queued to drm-misc-next. > --- > drivers/gpu/drm/panthor/panthor_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH] drm/panthor: Fix wrong kernel-doc format in the uAPI header

On Tue, 26 Mar 2024 10:30:55 +0100 Boris Brezillon wrote: > The kernel doc prefix is /** not /*. > > Reported-by: Stephen Rothwell > Signed-off-by: Boris Brezillon Queued to drm-misc-next. > --- > include/uapi/drm/panthor_drm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

On Mon, 25 Mar 2024, Maxime Ripard wrote: > Yeah, I got bitten by that when rebasing my HDMI series. Maybe we could > enable them all by default to prevent any issue when bisecting? Someone's going to grumble about default y, too, but agreed. I saw you already sent the patches. BR, Jani. -- J

[PATCH v3 1/3] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

When mapping an IO region, the pseudo-file offset is dependent on the userspace architecture. panthor_device_mmio_offset() abstracts that away for us by turning a userspace MMIO offset into its kernel equivalent, but we were not updating vm_area_struct::vm_pgoff accordingly, leading us to attach th

[PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

There's no reason for _irq_suspend/resume() to be called after the device has been unplugged, and keeping this dev_enter/exit() section in _irq_suspend() is turns _irq_suspend() into a NOP when called from the _unplug() functions, which we don't want. v3: - New patch Fixes: 5fe909cae118 ("drm/pan

[PATCH v3 2/3] drm/panthor: Fix ordering in _irq_suspend()

Make sure we set suspended=true last to avoid generating an irq storm in the unlikely case where an IRQ happens between the suspended=true assignment and the _INT_MASK update. We also move the mask=0 assignment before writing to the _INT_MASK register to prevent the thread handler from unmasking t

Re: [PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

Hi Nirmoy, ... > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > index a2195e28b625..57a2dda2c3cc 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > @@ -276,7 +276,7 @@ static

Re: [PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

On Tue, 26 Mar 2024 12:12:05 +0100 Boris Brezillon wrote: > There's no reason for _irq_suspend/resume() to be called after the > device has been unplugged, and keeping this dev_enter/exit() > section in _irq_suspend() is turns _irq_suspend() into a NOP ^ s/is turns/tu

Re: [PATCH] drm/i915/gt: Reset queue_priority_hint on parking

Hi Janusz and Chris, > Fixes: 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") > Closes: https://gitlab.freedesktop.org/drm/intel/issues/10154 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Signed-off-by: Janusz Krzysztofik > Cc: Chris Wilson > Cc: # v5.4+ with the tags rearranged a

Re: [PATCH v7 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

Hi Janusz, On Tue, Mar 05, 2024 at 03:35:05PM +0100, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object when parking a GT believed to be idle. > > [161.359441] ODEBUG: free active (active state 0) object: 88

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

On Tue, Mar 26, 2024 at 2:46 AM Tommaso Merciai wrote: > > Hi Laurent, > > On Tue, Mar 26, 2024 at 12:03:38AM +0200, Laurent Pinchart wrote: > > Hi Tommaso, > > > > On Mon, Mar 25, 2024 at 10:48:56PM +0100, Tommaso Merciai wrote: > > > Hi Adam, Lucas, > > > Thanks for this series. > > > > > > This

Re: [PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

On Tue, Mar 26, 2024 at 01:11:33PM +0200, Jani Nikula wrote: > On Mon, 25 Mar 2024, Maxime Ripard wrote: > > Yeah, I got bitten by that when rebasing my HDMI series. Maybe we could > > enable them all by default to prevent any issue when bisecting? > > Someone's going to grumble about default y,

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

Hi Adam, On Tue, Mar 26, 2024 at 06:43:26AM -0500, Adam Ford wrote: > On Tue, Mar 26, 2024 at 2:46 AM Tommaso Merciai > wrote: > > > > Hi Laurent, > > > > On Tue, Mar 26, 2024 at 12:03:38AM +0200, Laurent Pinchart wrote: > > > Hi Tommaso, > > > > > > On Mon, Mar 25, 2024 at 10:48:56PM +0100, Tom

Re: [PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

Hi Andi, On 3/26/2024 12:12 PM, Andi Shyti wrote: Hi Nirmoy, ... diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c index a2195e28b625..57a2dda2c3cc 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_mma

Re: [RFC PATCH net-next v6 00/15] Device Memory TCP

On 2024/3/26 8:28, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 11:38 AM Mina Almasry wrote: >> >> On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote: >>> >>> On 2024/3/5 10:01, Mina Almasry wrote: >>> >>> ... >>> Perf - page-pool benchmark: --- ben

Re: [PATCH 08/11] drm/dp_mst: Factor out drm_dp_mst_port_is_logical()

On 3/21/2024 1:41 AM, Imre Deak wrote: Factor out a function to check if an MST port is logical, used by a follow-up i915 patch in the patchset. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++--- includ

Re: [PATCH 07/11] drm/dp: Add drm_dp_uhbr_channel_coding_supported()

On 3/21/2024 1:41 AM, Imre Deak wrote: Factor out a function to check for UHBR channel coding support used by a follow-up patch in the patchset. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak LGTM. Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c |

Re: [PATCH 07/12] drm: Switch DRM_DISPLAY_HELPER to depends on

: 5e842d55bad7794823a50f24fd645b58f2ef93ab patch link: https://lore.kernel.org/r/20240325-kms-kconfig-helpers-v1-7-bfec6949d9c3%40kernel.org patch subject: [PATCH 07/12] drm: Switch DRM_DISPLAY_HELPER to depends on config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240326/202403262127

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: > > Add clear page support in vram memory region. > > v1(Christian): > - Dont handle clear page as TTM flag since when moving the BO back > in from GTT again we don't need that. > - Make a specialized version of amdgpu_fill_bu

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. -

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: > > Hi Alex, > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam > > wrote: > >> Add clear page support in vram memory region. > >> > >> v1(Christian): > >>- Dont handle cle

Re: [PATCH v3 1/3] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

On Tue, Mar 26, 2024 at 12:12:03PM +0100, Boris Brezillon wrote: > When mapping an IO region, the pseudo-file offset is dependent on the > userspace architecture. panthor_device_mmio_offset() abstracts that > away for us by turning a userspace MMIO offset into its kernel > equivalent, but we were n

Re: [PATCH v3 2/3] drm/panthor: Fix ordering in _irq_suspend()

On Tue, Mar 26, 2024 at 12:12:04PM +0100, Boris Brezillon wrote: > Make sure we set suspended=true last to avoid generating an irq storm > in the unlikely case where an IRQ happens between the suspended=true > assignment and the _INT_MASK update. > > We also move the mask=0 assignment before writi

Re: [PATCH v3 3/3] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()

On Tue, Mar 26, 2024 at 12:12:05PM +0100, Boris Brezillon wrote: > There's no reason for _irq_suspend/resume() to be called after the > device has been unplugged, and keeping this dev_enter/exit() > section in _irq_suspend() is turns _irq_suspend() into a NOP > when called from the _unplug() functi

[PATCH] drm/amdgpu: add support of bios dump in devcoredump

dump the bios binary in the devcoredump. Signed-off-by: Sunil Khatri --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c ind

[PATCH 00/12] kbuild: enable some -Wextra warnings by default

From: Arnd Bergmann This is a follow-up on a couple of patch series I sent in the past, enabling -Wextra (aside from stuff that is explicitly disabled), -Wcast-function-pointer-strict and -Wrestrict. I have tested these on 'defconfig' and 'allmodconfig' builds across all architectures, as well a

[PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

From: Arnd Bergmann The -Woverride-init warn about code that may be intentional or not, but the inintentional ones tend to be real bugs, so there is a bit of disagreement on whether this warning option should be enabled by default and we have multiple settings in scripts/Makefile.extrawarn as wel

[PATCH 06/12] nouveau: fix function cast warning

From: Arnd Bergmann Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function type

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: > > On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin > wrote: > > > > Hi Alex, > > > > On 3/26/2024 7:08 PM, Alex Deucher wrote: > > > On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam > > > wrote: > > >> Add clear page support

[PATCH 0/6] drm/msm/dp: Spring cleaning

Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (6): drm/msm/dp: Drop unused dp_debug struct drm/msm/dp: Removed fixed nvid "support" drm/msm/dp: Remove unused defines and members

[PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Signed-off-by: Bjorn Andersson ---

[PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Signed-of

[PATCH 3/6] drm/msm/dp: Remove unused defines and members

From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm/msm/dp/dp_catalog.c | 1 - drive

[PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int. Signed-off-by: Bjorn Anderss

[PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean this

[PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove the traces o

Re: [PATCH 06/12] nouveau: fix function cast warning

On Tue, 2024-03-26 at 15:51 +0100, Arnd Bergmann wrote: > Calling a function through an incompatible pointer type causes breaks > kcfi, so clang warns about the assignment: > ... > +static void of_fini(void *p) > +{ > +   return kfree(p); > +} > + I don't know anything about kfci, but shoul

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

Thanks for the patch, Patch pushed for staging. Regards Shashank On 25/03/2024 00:23, Alex Deucher wrote: On Sat, Mar 23, 2024 at 4:47 PM Sharma, Shashank wrote: On 23/03/2024 15:52, Johannes Weiner wrote: On Thu, Mar 14, 2024 at 01:09:57PM -0400, Johannes Weiner wrote: Hello, On Fri,

Re: (subset) [PATCH 0/4] drm: xlnx: zynqmp: Add DP audio support

On Tue, 12 Mar 2024 11:41:01 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: (subset) [PATCH v2 0/4] drm: xlnx: zynqmp: Add DP audio support

On Tue, 19 Mar 2024 10:22:35 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

On Mar 26 2024, Werner Sembach wrote: > Hi all, > > Am 25.03.24 um 19:30 schrieb Hans de Goede: > > [snip] > > > > If the kernel already handles the custom protocol into generic HID, the > > > > work for userspace is not too hard because they can deal with a known > > > > protocol and can be cros

[PATCH v11 00/28] drm/connector: Create HDMI Connector infrastructure

Hi, Here's a series that creates some extra infrastructure specifically targeted at HDMI controllers. The idea behind this series came from a recent discussion on IRC during which we discussed infoframes generation of i915 vs everything else. Infoframes generation code still requires some decent

[PATCH v11 01/28] drm/connector: Introduce an HDMI connector initialization function

A lot of the various HDMI drivers duplicate some logic that depends on the HDMI spec itself and not really a particular hardware implementation. Output BPC or format selection, infoframe generation are good examples of such areas. This creates a lot of boilerplate, with a lot of variations, which

[PATCH v11 03/28] drm/tests: connector: Add tests for drmm_connector_hdmi_init

We just introduced a new initialization function for our connectors, so let's build a kunit test suite for it as well. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_connector_test.c | 123 + 1 file changed, 123 insertions(+)

[PATCH v11 04/28] drm/connector: hdmi: Create an HDMI sub-state

The next features we will need to share across drivers will need to store some parameters for drivers to use, such as the selected output format. Let's create a new connector sub-state dedicated to HDMI controllers, that will eventually store everything we need. Reviewed-by: Dave Stevenson Revie

[PATCH v11 02/28] drm/mode_object: Export drm_mode_obj_find_prop_id for tests

We'll need to use drm_mode_obj_find_prop_id() for kunit tests to make sure a given property has been properly created. Let's export it for tests only. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mode_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_mode_o

[PATCH v11 06/28] drm/tests: Add output bpc tests

Now that we're tracking the output bpc count in the connector state, let's add a few tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig| 1 + drivers/gpu/drm/tests/Makefile

[PATCH v11 05/28] drm/connector: hdmi: Add output BPC to the connector state

We'll add automatic selection of the output BPC in a following patch, but let's add it to the HDMI connector state already. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 20 drivers/gpu/drm/drm_atomic.c

[PATCH v11 07/28] drm/connector: hdmi: Add support for output format

Just like BPC, we'll add support for automatic selection of the output format for HDMI connectors. Let's add the needed defaults and fields for now. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hdmi_state_helper.c| 3 ++- drivers/gpu/drm/drm_ato

[PATCH v11 09/28] drm/display: hdmi: Add HDMI compute clock helper

A lot of HDMI drivers have some variation of the formula to calculate the TMDS character rate from a mode, but few of them actually take all parameters into account. Let's create a helper to provide that rate taking all parameters into account. Reviewed-by: Dave Stevenson Signed-off-by: Maxime R

[PATCH v11 10/28] drm/tests: Add HDMI TDMS character rate tests

The previous patch added an helper to compute the TMDS character rate on an HDMI connector. Let's add a few tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_connector_test.c | 325 + 1 fil

[PATCH v11 08/28] drm/tests: Add output formats tests

Now that we track the HDMI output format as part of the connector state, let's add a few tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_connector_test.c | 99 +- drivers/gpu/drm/tests/dr

[PATCH v11 12/28] drm/tests: Add TDMS character rate connector state tests

The previous patch stores in the connector state the expected TMDS character rate matching the configuration of the HDMI connector. Let's add a few tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_t

[PATCH v11 11/28] drm/connector: hdmi: Calculate TMDS character rate

Most HDMI drivers have some code to calculate the TMDS character rate, usually to adjust an internal clock to match what the mode requires. Since the TMDS character rates mostly depends on the resolution, whether we need to repeat pixels or not, the bpc count and the format, we can now derive it f

[PATCH v11 13/28] drm/connector: hdmi: Add custom hook to filter TMDS character rate

Most of the HDMI controllers have an upper TMDS character rate limit they can't exceed. On "embedded"-grade display controllers, it will typically be lower than what high-grade monitors can provide these days, so drivers will filter the TMDS character rate based on the controller capabilities. To

[PATCH v11 14/28] drm/tests: Add HDMI connector rate filter hook tests

The previous patch adds a new hook for HDMI connectors to filter out configurations based on the TMDS character rate. Let's add some tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 65

[PATCH v11 15/28] drm/connector: hdmi: Compute bpc and format automatically

Now that we have all the infrastructure needed, we can add some code that will, for a given connector state and mode, compute the best output format and bpc. The algorithm is equivalent to the one already found in i915 and vc4. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hdmi_s

[PATCH v11 16/28] drm/tests: Add HDMI connector bpc and format tests

The previous patch added the bpc and format an HDMI connector needs to be set up with for a given connector state. Let's add a few tests to make sure it works as expected. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 509 + drivers/gp

[PATCH v11 22/28] drm/tests: Add infoframes test

The previous patch added the generation of the infoframes matching an HDMI connector state. Let's add a few tests to make sure it works as expected. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_connector_test.c | 219 + 1 file changed, 219 insertions(+)

[PATCH v11 25/28] drm/vc4: tests: Remove vc4_dummy_plane structure

The vc4_dummy_plane structure was introduced as a mean to add mock-specific fields. However, we never really used it and it's still strictly equivalent to vc4_plane (which is in the same situation vs drm_plane), so we can simply remove the vc4_dummy_plane structure and make the mock code cleaner.

[PATCH v11 23/28] drm/connector: hdmi: Create Infoframe DebugFS entries

There has been some discussions recently about the infoframes sent by drivers and if they were properly generated. In parallel, there's been some interest in creating an infoframe-decode tool similar to edid-decode. Both would be much easier if we were to expose the infoframes programmed in the h

[PATCH v11 18/28] drm/tests: Add tests for Broadcast RGB property

This had a bunch of kunit tests to make sure our code to handle the Broadcast RGB property behaves properly. This requires bringing a bit of infrastructure to create mock HDMI connectors, with custom EDIDs. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_

[PATCH v11 17/28] drm/connector: hdmi: Add Broadcast RGB property

The i915 driver has a property to force the RGB range of an HDMI output. The vc4 driver then implemented the same property with the same semantics. KWin has support for it, and a PR for mutter is also there to support it. Both drivers implementing the same property with the same semantics, plus th

[PATCH v11 24/28] drm/vc4: hdmi: Switch to HDMI connector

The new HDMI connector infrastructure allows us to remove a lot of boilerplate, so let's switch to it. Acked-by: Sui Jingfeng Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/Kconfig| 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 644 + drivers/gpu/

[PATCH v11 20/28] drm/tests: Add RGB Quantization tests

The previous commit added the infrastructure to the connector state to track what RGB Quantization should be used in a given state for an HDMI connector. Let's add some kunit tests to make sure it works as expected. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/t

[PATCH v11 19/28] drm/connector: hdmi: Add RGB Quantization Range to the connector state

HDMI controller drivers will need to figure out the RGB range they need to configure based on a mode and property values. Let's expose that in the HDMI connector state so drivers can just use that value. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hd

[PATCH v11 21/28] drm/connector: hdmi: Add Infoframes generation

Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how drivers generate them, and which are actually sent. Now that we have everything needed to generate them in the HDMI connector state, we can gen

[PATCH v11 28/28] drm/sun4i: hdmi: Switch to HDMI connector

The new HDMI connector infrastructure allows to remove some boilerplate, especially to generate infoframes. Let's switch to it. Reviewed-by: Jernej Skrabec Acked-by: Sui Jingfeng Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/Kconfig | 1 + drivers/gpu/drm/sun4i/sun4i_hdmi_en

[PATCH v11 27/28] drm/rockchip: inno_hdmi: Switch to HDMI connector

The new HDMI connector infrastructure allows to remove some boilerplate, especially to generate infoframes. Let's switch to it. Reviewed-by: Heiko Stuebner Acked-by: Heiko Stuebner Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rockchip/Kconfig | 1 + drivers/gpu/drm/rockchip/inno_hdmi

[PATCH v11 26/28] drm/vc4: tests: Convert to plane creation helper

Now that we have a plane create helper for kunit mocked drivers, let's convert to it in vc4. Reviewed-by: Maíra Canal Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_mock_plane.c | 34 +++--- 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/d

2024 X.Org Foundation Membership deadline for voting in the election

The 2024 X.Org Foundation membership renewal period has been extended one additional week and elections will start the following week on 01 April 2024. Please note that only current members can vote in the upcoming election, and that the deadline for new memberships or renewals to vote in the

  1   2   3   >