[PATCH RESEND v3] drm/bridge: anx7625: Update audio status while detecting

2024-03-25 Thread Hsin-Te Yuan
Previously, the audio status was not updated during detection, leading to a persistent audio despite hot plugging events. To resolve this issue, update the audio status during detection. Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") Signed-off-by: Hsin-Te Yuan --- Changes i

Re: [PATCH v2] Fix duplicate C declaration warnings

2024-03-25 Thread Amogh
On Sat, 2024-03-23 at 20:43 +, Matthew Wilcox wrote: > On Sat, Mar 23, 2024 at 10:01:47PM +0530, Amogh Cheluvaraj wrote: > > Fix duplicate C declaration warnings at > > Documentation/gpu/drm-kms.rst that was found by > > compiling htmldocs > > I'm sure this removes the warning, but it removes

[PATCH] drm/ttm: remove unused paramter

2024-03-25 Thread Jesse Zhang
remove the unsed the paramter in the function ttm_bo_bounce_temp_buffer and ttm_bo_add_move_fence. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/ttm/ttm_bo.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.

Re: [PATCH v6 000/164] pwm: Improve lifetime tracking for pwm_chips

2024-03-25 Thread patchwork-bot+chrome-platform
Hello: This series was applied to chrome-platform/linux.git (for-kernelci) by Uwe Kleine-König : On Wed, 14 Feb 2024 10:30:47 +0100 you wrote: > Hello, > > this is v6 of the series introducing better lifetime tracking for > pwmchips that addresses (for now theoretic) lifetime issues of pwm > chi

Re: [PATCH v6 000/164] pwm: Improve lifetime tracking for pwm_chips

2024-03-25 Thread patchwork-bot+chrome-platform
Hello: This series was applied to chrome-platform/linux.git (for-next) by Uwe Kleine-König : On Wed, 14 Feb 2024 10:30:47 +0100 you wrote: > Hello, > > this is v6 of the series introducing better lifetime tracking for > pwmchips that addresses (for now theoretic) lifetime issues of pwm > chips.

[PATCH] drm/ast: Fix soft lockup

2024-03-25 Thread Jammy Huang
Avoid infinite-loop in ast_dp_set_on_off(). Signed-off-by: Jammy Huang --- drivers/gpu/drm/ast/ast_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c index ebb6d8ebd44e..1e9259416980 100644 --- a/drivers/gpu/drm/ast/ast_dp.c ++

Re: [PATCH v2] drm/panthor: Fix the CONFIG_PM=n case

2024-03-25 Thread Boris Brezillon
On Mon, 18 Mar 2024 16:31:17 +0100 Boris Brezillon wrote: > Putting a hard dependency on CONFIG_PM is not possible because of a > circular dependency issue, and it's actually not desirable either. In > order to support this use case, we forcibly resume at init time, and > suspend at unplug time.

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-25 Thread AngeloGioacchino Del Regno
Il 22/03/24 17:45, Christian Hewitt ha scritto: Increase the timeout value to prevent system logs on Amlogic boards flooding with power transition warnings: [ 13.047638] panfrost ffe4.gpu: shader power transition timeout [ 13.048674] panfrost ffe4.gpu: l2 power transition timeout [

Re: [PATCH] drm/amdgpu: fix deadlock while reading mqd from debugfs

2024-03-25 Thread Sharma, Shashank
[AMD Official Use Only - General] Hey Alex, Sure, I will pick it up and push it to staging. Regards Shashank From: Alex Deucher Sent: Monday, March 25, 2024 12:23 AM To: Sharma, Shashank Cc: Johannes Weiner ; Christian König ; Deucher, Alexander ; Koenig, Chri

[PATCH v8 0/8] usb: misc: onboard_hub: add support for XMOS XVF3500

2024-03-25 Thread Javier Carrasco
Note: This series could not be completely applied due to conflicts upstream (TI TUSB8020 was added), and a rebase to the next -rc1 was suggested. The series is therefore identical to the previous version (v7), but taking into account the new hub. The first patch of the series has already been appli

[PATCH v8 1/8] usb: misc: onboard_hub: use device supply names

2024-03-25 Thread Javier Carrasco
The current implementation uses generic names for the power supplies, which conflicts with proper name definitions in the device bindings. Add a per-device property to include real supply names and keep generic names for existing devices to keep backward compatibility. Acked-by: Matthias Kaehlcke

[PATCH v8 8/8] usb: misc: onboard_dev: add support for XMOS XVF3500

2024-03-25 Thread Javier Carrasco
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit multicore controller for voice processing. This device requires a specific power sequence, which consists of enabling the regulators that control the 3V3 and 1V0 device supplies, and a reset de-assertion after a delay of at l

[PATCH v8 3/8] drm: ci: arm64.config: update ONBOARD_USB_HUB to ONBOARD_USB_DEV

2024-03-25 Thread Javier Carrasco
The onboard_usb_hub driver has been updated to support non-hub devices, which has led to some renaming. Update to the new name (ONBOARD_USB_DEV) accordingly. Acked-by: Helen Koike Reviewed-by: Matthias Kaehlcke Signed-off-by: Javier Carrasco --- drivers/gpu/drm/ci/arm64.config | 4 ++-- 1 fil

[PATCH v8 5/8] ARM: multi_v7_defconfig: update ONBOARD_USB_HUB to ONBOAD_USB_DEV

2024-03-25 Thread Javier Carrasco
The onboard_usb_hub driver has been updated to support non-hub devices, which has led to some renaming. Update to the new name accordingly. Update to the new name (ONBOARD_USB_DEV) accordingly. Reviewed-by: Matthias Kaehlcke Signed-off-by: Javier Carrasco --- arch/arm/configs/multi_v7_defconfi

[PATCH v8 7/8] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor

2024-03-25 Thread Javier Carrasco
The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit multicore controller for voice processing. Add new bindings to define the device properties. [1] https://www.xmos.com/xvf3500/ Reviewed-by: Krzysztof Kozlowski Acked-by: Mark Brown Signed-off-by: Javier Carrasco --- ...

[PATCH v8 2/8] usb: misc: onboard_hub: rename to onboard_dev

2024-03-25 Thread Javier Carrasco
This patch prepares onboad_hub to support non-hub devices by renaming the driver files and their content, the headers and their references. The comments and descriptions have been slightly modified to keep coherence and account for the specific cases that only affect onboard hubs (e.g. peer-hub).

[PATCH v8 6/8] usb: misc: onboard_dev: add support for non-hub devices

2024-03-25 Thread Javier Carrasco
Most of the functionality this driver provides can be used by non-hub devices as well. To account for the hub-specific code, add a flag to the device data structure and check its value for hub-specific code. The 'always_powered_in_supend' attribute is only available for hub devices, keeping the d

[PATCH v8 4/8] arm64: defconfig: update ONBOARD_USB_HUB to ONBOARD_USB_DEV

2024-03-25 Thread Javier Carrasco
The onboard_usb_hub driver has been updated to support non-hub devices, which has led to some renaming. Update to the new name (ONBOARD_USB_DEV) accordingly. Reviewed-by: Matthias Kaehlcke Signed-off-by: Javier Carrasco --- arch/arm64/configs/defconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/2] drm/panel: Promote warn_dev to WARN for invalid calls in drm_panel.c

2024-03-25 Thread Jani Nikula
On Sat, 23 Mar 2024, Emilio Mendoza Reyes wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 Please use git format-patch and/or send-email to send patches, without the inline PGP. > > From: Emilio Mendoza Reyes > > This patch is the second of a set of two. > > In the kernel docs there i

Re: [PATCH] drm/i915/hwmon: Fix potential UAF on driver unbind

2024-03-25 Thread Jani Nikula
On Fri, 22 Mar 2024, Ville Syrjälä wrote: > On Fri, Mar 22, 2024 at 07:54:03PM +0100, Janusz Krzysztofik wrote: >> Hwmon is registered as a managed resource of i915. Its functionality >> depends of availability of i915 uncore. > > Instead of polluting all code with this junk I think > either fixi

Re: [PATCH] drm/panthor: Don't use virt_to_pfn()

2024-03-25 Thread Boris Brezillon
On Mon, 18 Mar 2024 15:11:42 + Robin Murphy wrote: > On 18/03/2024 2:51 pm, Steven Price wrote: > > virt_to_pfn() isn't available on x86 (except to xen) so breaks > > COMPILE_TEST builds. Avoid its use completely by instead storing the > > struct page pointer allocated in panthor_device_init(

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-25 Thread Steven Price
On 22/03/2024 16:45, Christian Hewitt wrote: > Increase the timeout value to prevent system logs on Amlogic boards flooding > with power transition warnings: > > [ 13.047638] panfrost ffe4.gpu: shader power transition timeout > [ 13.048674] panfrost ffe4.gpu: l2 power transition timeou

[RESEND PATCH] dt-bindings: display: sony, td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Krzysztof Kozlowski
Allow width and height properties from panel-common.yaml, already used on some boards: sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do not match any of the regexes: 'pinctrl-[0-9]+' Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Rob, could you pick up

[RESEND PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2024-03-25 Thread Krzysztof Kozlowski
Add schema with common properties shared among dual-link panel ICs. Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Krzysztof Kozlowski --- Changes since v3: 1. Re-phrase description of binding and ports (Laurent) v3: https://lore.kernel.org/all/20230823081500.84005-1-kr

[RESEND PATCH v4 2/3] dt-bindings: display: novatek, nt35950: define ports

2024-03-25 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition by referencing the panel-common-dual.yaml. Panels can be single- or dual-link, thus require only one port@0. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v3: 1. Rb tag Ch

[RESEND PATCH v4 3/3] dt-bindings: display: novatek, nt36523: define ports

2024-03-25 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition by referencing the panel-common-dual.yaml. Panels can be single- or dual-link, depending on the compatible, thus add if:then:else: block narrowing ports per variant. Signed-off-by: Krzysztof Kozlowski Review

[PATCH 2/2] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Boris Brezillon
panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() has been called, which is always the case when our panthor_xxx_unplug() helpers are called. Fix that by introducing a panthor_xxx_unplug() helper that does what panthor_xxx_irq_suspend() except it does it unconditionally. Fi

[PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Boris Brezillon
When mapping an IO region, the pseudo-file offset is dependent on the userspace architecture. panthor_device_mmio_offset() abstract that away for us by turning a userspace MMIO offset into its kernel equivalent, but we were not updating vm_area_struct::vm_pgoff accordingly, leading us to attach the

Re: [RESEND PATCH] dt-bindings: display: sony,td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Neil Armstrong
Hi, On 25/03/2024 11:32, Krzysztof Kozlowski wrote: Allow width and height properties from panel-common.yaml, already used on some boards: sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do not match any of the regexes: 'pinctrl-[0-9]+' Acked-by: Conor Dooley Signed-o

Re: [PATCH 1/2] video: backlight: make backlight_class constant

2024-03-25 Thread Daniel Thompson
On Tue, Mar 05, 2024 at 09:21:17AM -0300, Ricardo B. Marliere wrote: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the backlight_class structure to be declared at build time >

Re: [PATCH 2/2] video: backlight: lcd: make lcd_class constant

2024-03-25 Thread Daniel Thompson
On Tue, Mar 05, 2024 at 09:21:18AM -0300, Ricardo B. Marliere wrote: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the lcd_class structure to be declared at build time > placin

Re: [RESEND PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2024-03-25 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 11:36:09 +0100, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual-link panel ICs. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/3] dt-bindings: display: panel: add common dual-link schema

Re: [RESEND PATCH] dt-bindings: display: sony, td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 11:32:27 +0100, Krzysztof Kozlowski wrote: > Allow width and height properties from panel-common.yaml, already used > on some boards: > > sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do not > match any of the regexes: 'pinctrl-[0-9]+' > > Than

Re: [PATCH] [RESEND] drm/imagination: avoid -Woverflow warning

2024-03-25 Thread Matt Coster
On 22/03/2024 13:01, Arnd Bergmann wrote: > From: Arnd Bergmann > > The array size calculation in pvr_vm_mips_fini() appears to be incorrect > based on > taking the size of the pointer rather than the size of the array, which > manifests > as a warning about signed integer overflow: > > In fil

Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function

2024-03-25 Thread Dan Carpenter
On Sat, Mar 23, 2024 at 10:10:40PM +0100, Christophe JAILLET wrote: > > static int pvt_ts_dbgfs_create(struct pvt_device *pvt, struct device *dev) > > { > > - pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL); > > + pvt->dbgfs_dir = devm_debugfs_create_dir(dev, dev_name(dev), NULL);

Re: [PATCH v4 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

2024-03-25 Thread Daniel Thompson
^^^ Is there any reason this patch wasn't Cc:ed to LKML (it should have come up as part of scripts/get_maintainer.pl)? On Sun, Mar 10, 2024 at 02:52:56PM +0100, Patrick Gansterer wrote: > Add Device Tree bindings for Texas Instruments LM3509 - a > High Efficiency Boost for White LED's and/or OLED

[PATCH v11 0/7] drm/meson: add support for MIPI DSI Display

2024-03-25 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI glue on the same Amlogic SoCs. This is a follow-up of v5 now the DRM patches are applied, the clk & DT changes remains

[PATCH v11 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-03-25 Thread Neil Armstrong
In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2 - vclk_div1 - vclk2_div2_en - vclk2_div4_en - vclk2_div6_en - vclk2_div12_en - vclk2_div2 - vclk2_div4 -

[PATCH v11 4/7] drm/meson: gate px_clk when setting rate

2024-03-25 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7 +++ 1 fil

[PATCH v11 6/7] arm64: meson: khadas-vim3l: add TS050 DSI panel overlay

2024-03-25 Thread Neil Armstrong
This add dtbo overlay to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 4 + .../boot/dts/amlogic/meson-khadas-vim3-ts050.dtso | 108 + 2 files changed, 112 insertions

[PATCH v11 5/7] arm64: meson: g12-common: add the MIPI DSI nodes

2024-03-25 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH v11 2/7] clk: meson: add vclk driver

2024-03-25 Thread Neil Armstrong
The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK gate has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enable callback. The VCLK_DIV clocks as enable and reset bits used to disable and reset the divider, associated wit

[PATCH v11 7/7] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2024-03-25 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 384 ++

[PATCH v11 1/7] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2024-03-25 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Docu

Re: [PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Steven Price
On 25/03/2024 10:41, Boris Brezillon wrote: > When mapping an IO region, the pseudo-file offset is dependent on the > userspace architecture. panthor_device_mmio_offset() abstract that away > for us by turning a userspace MMIO offset into its kernel equivalent, > but we were not updating vm_area_st

Re: [PATCH 2/2] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Steven Price
On 25/03/2024 10:41, Boris Brezillon wrote: > panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() > has been called, which is always the case when our panthor_xxx_unplug() > helpers are called. Fix that by introducing a panthor_xxx_unplug() helper > that does what panthor_xxx_

Re: [PATCH 1/2] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Boris Brezillon
On Mon, 25 Mar 2024 11:12:40 + Steven Price wrote: > On 25/03/2024 10:41, Boris Brezillon wrote: > > When mapping an IO region, the pseudo-file offset is dependent on the > > userspace architecture. panthor_device_mmio_offset() abstract that away > > for us by turning a userspace MMIO offset

Re: [PATCH v4 2/2] backlight: Add new lm3509 backlight driver

2024-03-25 Thread Daniel Thompson
^^^ Also not copied to LKML... On Sun, Mar 10, 2024 at 02:52:57PM +0100, Patrick Gansterer wrote: > This is a general driver for LM3509 backlight chip of TI. > LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with > Dual Current Sinks. This driver supports OLED/White LED select

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-25 Thread Christian Hewitt
> On 25 Mar 2024, at 2:28 pm, Steven Price wrote: > > On 22/03/2024 16:45, Christian Hewitt wrote: >> Increase the timeout value to prevent system logs on Amlogic boards flooding >> with power transition warnings: >> >> [ 13.047638] panfrost ffe4.gpu: shader power transition timeout >> [

Re: [PATCH 2/2] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Boris Brezillon
On Mon, 25 Mar 2024 11:17:24 + Steven Price wrote: > On 25/03/2024 10:41, Boris Brezillon wrote: > > panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() > > has been called, which is always the case when our panthor_xxx_unplug() > > helpers are called. Fix that by introd

Re: [PATCH 2/2] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Steven Price
On 25/03/2024 11:43, Boris Brezillon wrote: > On Mon, 25 Mar 2024 11:17:24 + > Steven Price wrote: > >> On 25/03/2024 10:41, Boris Brezillon wrote: >>> panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() >>> has been called, which is always the case when our panthor_xxx_

Re: [PATCH v5 01/16] drm/vkms: Code formatting

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:44:55 +0100 Louis Chauvet wrote: > Few no-op changes to remove double spaces and fix wrong alignments. > > Signed-off-by: Louis Chauvet Reviewed-by: Pekka Paalanen Thanks, pq > --- > drivers/gpu/drm/vkms/vkms_composer.c | 10 +- > drivers/gpu/drm/vkms/vkms_c

Re: [PATCH v5 02/16] drm/vkms: Use drm_frame directly

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:44:56 +0100 Louis Chauvet wrote: > From: Arthur Grillo > > Remove intermidiary variables and access the variables directly from > drm_frame. These changes should be noop. > > Signed-off-by: Arthur Grillo > Signed-off-by: Louis Chauvet > --- Acked-by: Pekka Paalanen

Re: [PATCH v5 04/16] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:44:58 +0100 Louis Chauvet wrote: > Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the > compiler to check if the passed functions take the correct arguments. > Such typedefs will help ensuring consistency across the code base in > case of update of these

Re: [PATCH v5 05/16] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:44:59 +0100 Louis Chauvet wrote: > Introduce two callbacks which does nothing. They are used in replacement > of NULL and it avoid kernel OOPS if this NULL is called. > > If those callback are used, it means that there is a mismatch between > what formats are announced by

Re: [PATCH v5 06/16] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:00 +0100 Louis Chauvet wrote: > As the pixel_read and pixel_write function should never modify the input > buffer, mark those pointers const. > > Signed-off-by: Louis Chauvet Reviewed-by: Pekka Paalanen Thanks, pq > --- > drivers/gpu/drm/vkms/vkms_drv.h | 4

Re: [PATCH 4/8] media: platform: ti: use for_each_endpoint_of_node()

2024-03-25 Thread Dan Carpenter
On Mon, Mar 25, 2024 at 03:05:27AM +, Kuninori Morimoto wrote: > We already have for_each_endpoint_of_node(), don't use > of_graph_get_next_endpoint() directly. Replace it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/media/platform/ti/am437x/am437x-vpfe.c | 8 +++- > drivers/

Re: [PATCH v5 07/16] drm/vkms: Update pixels accessor to support packed and multi-plane formats.

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:01 +0100 Louis Chauvet wrote: > Introduce the usage of block_h/block_w to compute the offset and the > pointer of a pixel. The previous implementation was specialized for > planes with block_h == block_w == 1. To avoid confusion and allow easier > implementation of tiled

Re: [PATCH v5 08/16] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:02 +0100 Louis Chauvet wrote: > The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing > different concepts (coordinate calculation and color management), extract > the x_limit and x_dst computation outside of this helper. > It also increases the maintainab

[PATCH 00/12] drm/display: Convert helpers Kconfig symbols to depends on

2024-03-25 Thread Maxime Ripard
onfig | 8 +-- include/drm/display/drm_dp_helper.h | 2 +- 26 files changed, 155 insertions(+), 141 deletions(-) --- base-commit: 5e842d55bad7794823a50f24fd645b58f2ef93ab change-id: 20240325-kms-kconfig-helpers-f94991bdd6fa Best regards, -- Maxime Ripard

[PATCH 01/12] drm/display: Make DisplayPort AUX bus Kconfig name consistent

2024-03-25 Thread Maxime Ripard
While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort AUX bus implementation uses DRM_DP_AUX_BUS. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/br

[PATCH 02/12] drm/display: Make DisplayPort tunnel debug Kconfig name consistent

2024-03-25 Thread Maxime Ripard
While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort Tunnel debugging uses DRM_DISPLAY_DEBUG_DP_TUNNEL_STATE. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Signed-off-by: Maxime Ripard --- drive

[PATCH 03/12] drm/display: Make DisplayPort AUX Chardev Kconfig name consistent

2024-03-25 Thread Maxime Ripard
While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort-AUX chardev interface uses DRM_DP_AUX_BUS. Since the number of users is limited and it's a selected symbol, we can easily rename it to make it consistent. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/dis

[PATCH 05/12] drm/display: Reorder Kconfig symbols

2024-03-25 Thread Maxime Ripard
The display kconfig helpers are not organized in any particular order, so let's move them around to create an alphabetical order. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/Kconfig | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) di

[PATCH 04/12] drm/display: Make DisplayPort CEC-over-AUX Kconfig name consistent

2024-03-25 Thread Maxime Ripard
While most display helpers Kconfig symbols have the DRM_DISPLAY prefix, the DisplayPort CEC tunnelling implementation uses CONFIG_DRM_DISPLAY_DP_AUX_CEC. Since the number of users is limited, we can easily rename it to make it consistent. Signed-off-by: Maxime Ripard --- arch/parisc/configs/ge

[PATCH 08/12] drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on

2024-03-25 Thread Maxime Ripard
Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH 06/12] drm/display: Make all helpers visible and switch to depends on

2024-03-25 Thread Maxime Ripard
All the helpers Kconfig symbols so far have relied on drivers selecting them, and that's what most drivers did. However, this creates an issue nowadays when helpers depend on each other, and select doesn't transitively select a dependency dependencies. Depends on doesn't have that limitation thou

[PATCH 07/12] drm: Switch DRM_DISPLAY_HELPER to depends on

2024-03-25 Thread Maxime Ripard
Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH 11/12] drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on

2024-03-25 Thread Maxime Ripard
Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH 12/12] drm/bridge: it6505: Remove useless select

2024-03-25 Thread Maxime Ripard
The IT6505 bridge Kconfig symbol selects a Kconfig symbol that doesn't exist. Remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 6e6ec300ab16..d1fbf879

[PATCH 10/12] drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on

2024-03-25 Thread Maxime Ripard
Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

[PATCH 09/12] drm: Switch DRM_DISPLAY_DP_HELPER to depends on

2024-03-25 Thread Maxime Ripard
Most of our helpers have relied on being selected so far through Kconfig, but that creates issues when we have multiple layers of helpers with some depending on others. Indeed, select doesn't select a dependency's dependencies, and thus isn't super intuitive. Depends on however doesn't have that l

Re: [PATCH 2/2] drm/panel: Promote warn_dev to WARN for invalid calls in drm_panel.c

2024-03-25 Thread Emilio Mendoza Reyes
On Monday, March 25, 2024 5:37:52 AM EDT Jani Nikula wrote: > Please use git format-patch and/or send-email to send patches, without > the inline PGP. Yeah, sorry about that. I only noticed it was inline PGP after I sent the patches. I didn't know if it would be okay to resend right after since I d

[PATCH] drm/panel-edp: Add AUO B120XAN01.0

2024-03-25 Thread Pin-yen Lin
Add support for the AUO B120XAN01.0 panel. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index c4f851200aa2..1a4a1ffea2c1 100644 --- a/drivers/gpu/drm/pa

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-25 Thread AngeloGioacchino Del Regno
Il 25/03/24 12:36, Christian Hewitt ha scritto: On 25 Mar 2024, at 2:28 pm, Steven Price wrote: On 22/03/2024 16:45, Christian Hewitt wrote: Increase the timeout value to prevent system logs on Amlogic boards flooding with power transition warnings: [ 13.047638] panfrost ffe4.gpu: shade

Re: [PATCH v5 09/16] drm/vkms: Introduce pixel_read_direction enum

2024-03-25 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:03 +0100 Louis Chauvet wrote: > The pixel_read_direction enum is useful to describe the reading direction > in a plane. It avoids using the rotation property of DRM, which not > practical to know the direction of reading. > This patch also introduce two helpers, one to c

Re: [PATCH v5 01/16] drm/vkms: Code formatting

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: Few no-op changes to remove double spaces and fix wrong alignments. Signed-off-by: Louis Chauvet Reviewed-by: Maíra Canal Best Regards, - Maíra --- drivers/gpu/drm/vkms/vkms_composer.c | 10 +- drivers/gpu/drm/vkms/vkms_crtc.c | 6 ++-

Re: [PATCH v5 02/16] drm/vkms: Use drm_frame directly

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: From: Arthur Grillo Remove intermidiary variables and access the variables directly from drm_frame. These changes should be noop. Signed-off-by: Arthur Grillo Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 3 --- drivers/gp

Re: [PATCH v5 03/16] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: Add some documentation on pixel conversion functions. Update of outdated comments for pixel_write functions. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 7 drivers/gpu/drm/vkms/vkms_drv.h | 13 drivers/gp

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-25 Thread Akhil P Oommen
On Sun, Mar 24, 2024 at 12:57:43PM +0200, Dmitry Baryshkov wrote: > On Sun, 24 Mar 2024 at 12:30, Akhil P Oommen wrote: > > > > On Sat, Mar 23, 2024 at 12:57:02AM +0200, Dmitry Baryshkov wrote: > > > Generate DRM/MSM headers on the fly during kernel build. This removes a > > > need to push registe

Re: [PATCH v4 04/16] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-25 Thread Akhil P Oommen
On Sun, Mar 24, 2024 at 01:13:55PM +0200, Dmitry Baryshkov wrote: > On Sun, 24 Mar 2024 at 11:55, Akhil P Oommen wrote: > > > > On Sat, Mar 23, 2024 at 12:56:56AM +0200, Dmitry Baryshkov wrote: > > > The msm_gpummu.c implementation is used only on A2xx and it is tied to > > > the A2xx registers. R

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-25 Thread Paneer Selvam, Arunpravin
Hi Matthew, ping? Thanks, Arun. On 3/19/2024 3:10 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Tra

[PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-03-25 Thread Andi Shyti
To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This adjustment compensates for instances when userspace mappings do not start from the beginning of the object. Based on a patch by Chris Wilson . Sig

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-25 Thread Andy Shevchenko
On Sat, Mar 23, 2024 at 02:30:08AM +0800, Sui Jingfeng wrote: > On 2024/3/23 02:16, Andy Shevchenko wrote: > > On Sat, Mar 23, 2024 at 02:12:14AM +0800, Sui Jingfeng wrote: > > > On 2024/3/23 02:05, Andy Shevchenko wrote: > > > >Besides that, the kernel project rule is "we do not add > > > > th

[PATCH 0/5] Add Support for RK3326 GameForce Chi

2024-03-25 Thread Chris Morgan
From: Chris Morgan Add support for the GameForce Chi [1]. The GameForce Chi has the following hardware: Tested: - 3.5" dual lane 640x480 DSI display. - 15 GPIO based face buttons. - 2 ADC based face buttons. - 1 ADC joystick (left) connected to internal SARADC. - RGB LED arrays for key back

[PATCH 2/5] dt-bindings: display: Add GameForce Chi Panel

2024-03-25 Thread Chris Morgan
From: Chris Morgan The GameForce Chi panel is a panel specific to the GameForce Chi handheld device that measures 3.5" diagonally with a resolution of 640x480. Signed-off-by: Chris Morgan --- .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 2 ++ 1 file changed, 2 insertions(+

[PATCH 3/5] drm/panel: st7703: Add GameForce Chi Panel Support

2024-03-25 Thread Chris Morgan
From: Chris Morgan The GameForce Chi is a handheld device with a 3.5" 640x480 ST7703 based display panel. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-

[PATCH 1/5] dt-bindings: vendor-prefix: Add prefix for GameForce

2024-03-25 Thread Chris Morgan
From: Chris Morgan GameForce is a company that produces handheld game consoles. https://gameforce.fun/ Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes

[PATCH 5/5] arm64: dts: rockchip: Add GameForce Chi

2024-03-25 Thread Chris Morgan
From: Chris Morgan Add support for the GameForce Chi, which is a handheld gaming console from GameForce with a Rockchip RK3326 SoC. The device has a 640x480 3.5" dual-lane DSI display, one analog joystick connected to the SoC SARADC controller and a second analog joystick connected to an unknown

[PATCH 4/5] dt-bindings: arm: rockchip: Add GameForce Chi

2024-03-25 Thread Chris Morgan
From: Chris Morgan The GameForce Chi is a handheld gaming device from GameForce powered by the Rockchip RK3326 SoC. Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-25 Thread Dmitry Baryshkov
On Mon, 25 Mar 2024 at 15:33, Akhil P Oommen wrote: > > On Sun, Mar 24, 2024 at 12:57:43PM +0200, Dmitry Baryshkov wrote: > > On Sun, 24 Mar 2024 at 12:30, Akhil P Oommen > > wrote: > > > > > > On Sat, Mar 23, 2024 at 12:57:02AM +0200, Dmitry Baryshkov wrote: > > > > Generate DRM/MSM headers on

Re: [PATCH v11 0/7] drm/meson: add support for MIPI DSI Display

2024-03-25 Thread Rob Herring
d new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platfor

Re: [PATCH v5 04/16] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the compiler to check if the passed functions take the correct arguments. Such typedefs will help ensuring consistency across the code base in case of update of these prototypes. Rename input

[PATCH v2 2/3] drm/panthor: Fix ordering in _irq_suspend()

2024-03-25 Thread Boris Brezillon
Make sure we set suspended=true last to avoid generating an irq storm in the unlikely case where an IRQ happens between the suspended=true assignment and the _INT_MASK update. v2: - New patch Reported-by: Steven Price Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_device.h

[PATCH v2 1/3] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-03-25 Thread Boris Brezillon
When mapping an IO region, the pseudo-file offset is dependent on the userspace architecture. panthor_device_mmio_offset() abstracts that away for us by turning a userspace MMIO offset into its kernel equivalent, but we were not updating vm_area_struct::vm_pgoff accordingly, leading us to attach th

[PATCH v2 3/3] drm/panthor: Actually suspend IRQs in the unplug path

2024-03-25 Thread Boris Brezillon
panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug() has been called, which is always the case when our panthor_xxx_unplug() helpers are called. Fix that by introducing a panthor_xxx_unplug() helper that does what panthor_xxx_irq_suspend() except it does it unconditionally. v2

Re: [PATCH v5 05/16] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-03-25 Thread Maíra Canal
On 3/13/24 14:44, Louis Chauvet wrote: Introduce two callbacks which does nothing. They are used in replacement of NULL and it avoid kernel OOPS if this NULL is called. If those callback are used, it means that there is a mismatch between what formats are announced by atomic_check and what is re

Re: [PATCH v5 06/16] drm/vkms: Use const for input pointers in pixel_read an pixel_write functions

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: As the pixel_read and pixel_write function should never modify the input buffer, mark those pointers const. Signed-off-by: Louis Chauvet Reviewed-by: Maíra Canal Best Regards, - Maíra --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- drivers/gpu/

Re: [PATCH v5 09/16] drm/vkms: Introduce pixel_read_direction enum

2024-03-25 Thread Maíra Canal
On 3/13/24 14:45, Louis Chauvet wrote: The pixel_read_direction enum is useful to describe the reading direction in a plane. It avoids using the rotation property of DRM, which not practical to know the direction of reading. This patch also introduce two helpers, one to compute the pixel_read_dir

Re: [PATCH] drm/amdkfd: return negative error code in svm_ioctl()

2024-03-25 Thread Philip Yang
On 2024-03-25 02:31, Su Hui wrote: svm_ioctl() should return negative error code in default case. Fixes: 42de677f7999 ("drm/amdkfd: register svm range") Signed-off-by: Su Hui Good catch, ioctl should return -errno. I will apply it to drm-next.

  1   2   >