Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-06 Thread Pekka Paalanen
On Tue, 5 Mar 2024 14:51:49 +0100 Sebastian Wick wrote: > The initial idea of the Colorspace prop was that this maps 1:1 to > InfoFrames/SDP but KMS does not give user space enough information nor > control over the output format to figure out which variants can be used > for a given KMS commit.

Re: [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-03-06 Thread Tvrtko Ursulin
On 06/03/2024 01:56, Adrián Larumbe wrote: Debugfs isn't always available in production builds that try to squeeze every single byte out of the kernel image, but we still need a way to toggle the timestamp and cycle counter registers so that jobs can be profiled for fdinfo's drm engine and cycl

Re: [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-03-06 Thread Boris Brezillon
On Wed, 6 Mar 2024 01:56:36 + Adrián Larumbe wrote: > Debugfs isn't always available in production builds that try to squeeze > every single byte out of the kernel image, but we still need a way to > toggle the timestamp and cycle counter registers so that jobs can be > profiled for fdinfo's

Re: [PATCH v4 1/5] drm_edid: Add a function to get EDID base block

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > It's found that some panels have variants that they share the same panel id > although their EDID and names are different. Besides panel id, now we need > more information from the EDID base block to distinguish these panel > variants. > > Add drm_edid_re

[PATCH v13 02/27] dept: Implement Dept(Dependency Tracker)

2024-03-06 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v13 01/27] llist: Move llist_{head, node} definition to types.h

2024-03-06 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH v13 03/27] dept: Add single event dependency tracker APIs

2024-03-06 Thread Byungchul Park
Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate (the simplest way): 1. Initaialize a map for the interesting wait. /*

[PATCH v13 24/27] dept: Track PG_locked with dept

2024-03-06 Thread Byungchul Park
Makes Dept able to track PG_locked waits and events. It's going to be useful in practice. See the following link that shows dept worked with PG_locked and can detect real issues: https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.p...@lge.com/ Signed-off-by: Byungchul Pa

[PATCH v13 04/27] dept: Add lock dependency tracker APIs

2024-03-06 Thread Byungchul Park
Wrapped the base APIs for easier annotation on typical lock. Signed-off-by: Byungchul Park --- include/linux/dept_ldt.h | 77 1 file changed, 77 insertions(+) create mode 100644 include/linux/dept_ldt.h diff --git a/include/linux/dept_ldt.h b/include/li

[PATCH v13 10/27] dept: Apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

2024-03-06 Thread Byungchul Park
Makes Dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 7725b7579b78..fe89282c3e96 100644 --- a/include/linux/wait_

[PATCH v13 00/27] DEPT(Dependency Tracker)

2024-03-06 Thread Byungchul Park
I'm happy to see that DEPT reports a real problem in practice. See: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a4856...@i-love.sakura.ne.jp/#t https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.p...@lge.com/ I added a document describing DEPT, that woul

[PATCH v13 06/27] dept: Add proc knobs to show stats and dependency graph

2024-03-06 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 +++- kernel/dependency/dept_internal.h | 26 ++

[PATCH v13 15/27] dept: Apply sdt_might_sleep_{start, end}() to dma fence wait

2024-03-06 Thread Byungchul Park
Makes Dept able to track dma fence waits. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 8aa8f8cb7071..76dba11f0dab 100644 --- a/drivers/dma-buf/dma-fence.c +++

[PATCH v13 07/27] dept: Apply sdt_might_sleep_{start, end}() to wait_for_completion()/complete()

2024-03-06 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/include/linux/completion.h b/include/linux/completion.h inde

[PATCH v13 12/27] dept: Distinguish each work from another

2024-03-06 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH v13 08/27] dept: Apply sdt_might_sleep_{start,end}() to swait

2024-03-06 Thread Byungchul Park
Makes Dept able to track dependencies by swaits. Signed-off-by: Byungchul Park --- include/linux/swait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index d324419482a0..277ac74f61c3 100644 --- a/include/linux/swait.h +++ b/include/linux/sw

[PATCH v13 18/27] dept: Apply timeout consideration to swait

2024-03-06 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v13 05/27] dept: Tie to Lockdep and IRQ tracing

2024-03-06 Thread Byungchul Park
How to place Dept this way looks so ugly. But it's inevitable for now. The way should be enhanced gradually. Signed-off-by: Byungchul Park --- include/linux/irqflags.h| 7 +- include/linux/local_lock_internal.h | 1 + include/linux/lockdep.h | 102

[PATCH v13 25/27] dept: Print event context requestor's stacktrace on report

2024-03-06 Thread Byungchul Park
Currently, print nothing in place of [S] in report, which means stacktrace of event context's start if the event is not an unlock thing by typical lock but general event because it's not easy to specify the point in a general way, where the event context has started from. However, unfortunately it

[PATCH v13 16/27] dept: Track timeout waits separately with a new Kconfig

2024-03-06 Thread Byungchul Park
Waits with valid timeouts don't actually cause deadlocks. However, Dept has been reporting the cases as well because it's worth informing the circular dependency for some cases where, for example, timeout is used to avoid a deadlock but not meant to be expired. However, yes, there are also a lot o

[PATCH v13 17/27] dept: Apply timeout consideration to wait_for_completion()/complete()

2024-03-06 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 4 ++-- kernel/sched/completion.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v13 11/27] dept: Distinguish each syscall context from another

2024-03-06 Thread Byungchul Park
It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH v13 20/27] dept: Apply timeout consideration to hashed-waitqueue wait

2024-03-06 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to hashed-waitqueue wait, assuming an input 'ret' in ___wait_var_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v13 21/27] dept: Apply timeout consideration to dma fence wait

2024-03-06 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

[PATCH v13 14/27] cpu/hotplug: Use a weaker annotation in AP thread

2024-03-06 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. rwsem_acquire() implies: 1. might be a wai

[PATCH v13 13/27] dept: Add a mechanism to refill the internal memory pools on running out

2024-03-06 Thread Byungchul Park
Dept engine works in a constrained environment. For example, Dept cannot make use of dynamic allocation e.g. kmalloc(). So Dept has been using static pools to keep memory chunks Dept uses. However, Dept would barely work once any of the pools gets run out. So implemented a mechanism for the refill

[PATCH v13 23/27] dept: Make Dept able to work with an external wgen

2024-03-06 Thread Byungchul Park
There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH v13 27/27] dept: Add documentation for Dept

2024-03-06 Thread Byungchul Park
This document describes the concept of Dept. Signed-off-by: Byungchul Park --- Documentation/dependency/dept.txt | 735 ++ 1 file changed, 735 insertions(+) create mode 100644 Documentation/dependency/dept.txt diff --git a/Documentation/dependency/dept.txt b/Docume

[PATCH v13 22/27] dept: Record the latest one out of consecutive waits of the same class

2024-03-06 Thread Byungchul Park
The current code records all the waits for later use to track relation between waits and events in each context. However, since the same class is handled the same way, it'd be okay to record only one on behalf of the others if they all have the same class. Even though it's the ideal to search the

[PATCH v13 19/27] dept: Apply timeout consideration to waitqueue wait

2024-03-06 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to waitqueue wait, assuming an input 'ret' in ___wait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v13 09/27] dept: Apply sdt_might_sleep_{start, end}() to waitqueue wait

2024-03-06 Thread Byungchul Park
Makes Dept able to track dependencies by waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index 3473b663176f..ebeb4678859f 100644 --- a/include/linux/wait.h +++ b/include/lin

[PATCH v13 26/27] fs/jbd2: Use a weaker annotation in journal handling

2024-03-06 Thread Byungchul Park
jbd2 journal handling code doesn't want jbd2_might_wait_for_commit() to be placed between start_this_handle() and stop_this_handle(). So it marks the region with rwsem_acquire_read() and rwsem_release(). However, the annotation is too strong for that purpose. We don't have to use more than try loc

[PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Sunil Khatri
When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Add all such information in the last cached pagefault from an interrupt handler. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++--

Re: [PATCH v4 2/5] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > Create a type drm_edid_ident as the identity of an EDID. Currently it > contains panel id and monitor name. > > Create a function that can match a given EDID and an identity: > 1. Reject if the panel id doesn't match. > 2. If name is not null in identity,

Re: [PATCH v4 3/5] drm/edid: Match edid quirks with identity

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > Currently edid quirks are matched by panel id only. > > Modify it to match with identity so it's easier to be extended > for more complex matching if required. > > Suggested-by: Jani Nikula > Signed-off-by: Hsin-Yi Wang Reviewed-by: Jani Nikula > ---

Re: [PATCH v4 4/5] drm/panel-edp: Match edp_panels with panel identity

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > It's found that some panels have variants that they share the same panel id > although their EDID and names are different. When matching generic edp > panels, we should first match with both panel identity, which contains both > panel id and panel name. I

[PATCH v3] drm/bridge: anx7625: Update audio status while detecting

2024-03-06 Thread Hsin-Te Yuan
-- Changes in v3: - Add Fixes tag. - Link to v2: https://lore.kernel.org/r/20240306-anx7625-v2-1-7138e00b2...@chromium.org Changes in v2: - Add a space after the colons in the subject line. - Link to v1: https://lore.kernel.org/r/20240305-anx7625-v1-1-83ed3ccfa...@chromium.org --- drivers/gpu/

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are hw generation specific. You should probably ra

[PATCH v15 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-03-06 Thread Alexander Stein
The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge driver and Cadence HDP-TX PHY(HDMI/DP) driver for Freescale i.MX8MQ. The patch set compose of DRM bridge drivers and PHY driver. Both of them need by patch #1 and #2 to pass build. DRM bridges driver patches: #1: drm: bridge: C

[PATCH v15 1/8] drm: bridge: Cadence: Create mhdp helper driver

2024-03-06 Thread Alexander Stein
From: Sandor Yu MHDP8546 mailbox access functions will be share to other mhdp driver and Cadence HDP-TX HDMI/DP PHY drivers. Create a new mhdp helper driver and move all those functions into. cdns_mhdp_reg_write() is renamed to cdns_mhdp_dp_reg_write(), because it use the DPTX command ID DPTX_WR

[PATCH v15 2/8] phy: Add HDMI configuration options

2024-03-06 Thread Alexander Stein
From: Sandor Yu Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor

[PATCH v15 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

2024-03-06 Thread Alexander Stein
From: Sandor Yu Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. Signed-off-by: Sandor Yu Reviewed-by: Krzysztof Kozlowski --- .../display/bridge/cdns,mhdp8501.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bind

[PATCH v15 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-03-06 Thread Alexander Stein
From: Sandor Yu Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and activated by SOC's ROM code. Bo

[PATCH v15 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2024-03-06 Thread Alexander Stein
From: Sandor Yu Add bindings for Freescale iMX8MQ DP and HDMI PHY. Signed-off-by: Sandor Yu Reviewed-by: Rob Herring --- .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8

[PATCH v15 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

2024-03-06 Thread Alexander Stein
From: Sandor Yu Add Cadence HDP-TX DisplayPort and HDMI PHY driver for i.MX8MQ. Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. DisplayPort or HDMI PHY mode is configured in the driver. Signed-off-by: Sandor Yu Signed-off-by: Alexander Stein --

[PATCH v15 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline

2024-03-06 Thread Alexander Stein
This adds DCSS + MHDP + MHDP PHY nodes. PHY mode (DP/HDMI) is selected by the connector type connected to mhdp port@1 endpoint. Signed-off-by: Alexander Stein --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 68 +++ 1 file changed, 68 insertions(+) diff --git a/arch/arm64/boo

[PATCH v15 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support

2024-03-06 Thread Alexander Stein
Add HDMI connector and connect it to MHDP output. Enable peripherals for HDMI output. Signed-off-by: Alexander Stein --- .../dts/freescale/imx8mq-tqma8mq-mba8mx.dts | 20 +++ arch/arm64/boot/dts/freescale/mba8mx.dtsi | 11 ++ 2 files changed, 31 insertions(+) diff

Re: [PATCH v3] drm/bridge: anx7625: Update audio status while detecting

2024-03-06 Thread Jani Nikula
if b4 is used to apply the patches, it can automagically pick up the trailers from replies to the patch with the Fixes: trailer. > - Link to v2: > https://lore.kernel.org/r/20240306-anx7625-v2-1-7138e00b2...@chromium.org > > Changes in v2: > - Add a space after the colons in the s

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are h

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Thomas Zimmermann
Hi, sorry that I did not see the patch before. Am 27.02.24 um 23:19 schrieb Douglas Anderson: Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in udl_transfer.c), it advertises XRGB for compatibility. Let's add ARGB to that list. We had a heated discussi

[PATCH v3 0/3] arch/powerpc: Resolve backlight include dependencies

2024-03-06 Thread Thomas Zimmermann
After cleaning up in commit 11b4eedfc87d ("fbdev: Do not include in header"), building with CONFIG_PMAC_BACKLIGHT=y returns errors about missing declarations. Patches 1 and 2 resolve the errors. Patch 1 has been reviewed at [1]. Patch 3 removes another dependency between backlight and fbdev code.

[PATCH v3 2/3] macintosh/via-pmu-backlight: Include

2024-03-06 Thread Thomas Zimmermann
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from . Add it to via-pmu-backlight.c to get the necessary symbols. Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu7

[PATCH v3 1/3] fbdev/chipsfb: Include

2024-03-06 Thread Thomas Zimmermann
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from . Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/ Signed-off-by: Thomas Zimmermann Fix

[PATCH v3 3/3] arch/powerpc: Remove from backlight code

2024-03-06 Thread Thomas Zimmermann
Replace with a forward declaration in to resolve an unnecessary dependency. Remove pmac_backlight_curve_lookup() and struct fb_info from source and header files. The function and the framebuffer struct are unused. No functional changes. v3: * Add Fixes tag (Christophe) * fix typo

Re: [RFC PATCH net-next v6 00/15] Device Memory TCP

2024-03-06 Thread Yunsheng Lin
On 2024/3/6 3:38, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote: >> >> On 2024/3/5 10:01, Mina Almasry wrote: >> >> ... >> >>> >>> Perf - page-pool benchmark: >>> --- >>> >>> bench_page_pool_simple.ko tests with and without these changes: >>> https

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-06 Thread Yunsheng Lin
On 2024/3/6 5:17, Mina Almasry wrote: > On Tue, Mar 5, 2024 at 4:55 AM Yunsheng Lin wrote: >> >> On 2024/3/5 10:01, Mina Almasry wrote: >> >> ... >> >>> >>> The netdev_dmabuf_binding struct is refcounted, and releases its >>> resources only when all the refs are released. >>> >>> Signed-off-by: Wi

[PATCH] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path"

2024-03-06 Thread Luca Ceresoli
-- base-commit: a71e4adac20bfe852d269addfef340923ce23a4c change-id: 20240306-ti-sn65dsi83-regulator-imbalance-10e217fd302c Best regards, -- Luca Ceresoli

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2024-03-06 Thread Luca Ceresoli
gt; > > it seems > > > > > > > sn65dsi83_atomic_disable is not called in my case for some > > > > > > > reason. > > > > > > > > > > > > So you remove the module and atomic_disable is not called, after > &

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information a

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote: >> Hmm. As Hsin-Yi pointed out to me offline. Somehow we'll need to get >> the actual panel ID out. Right now in panel-edp.c we have: >> >> dev_warn(dev, >> "Unknown panel %s %#06x, using conservativ

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the

Re: [PATCH 1/3] drm/arm/komeda: Fix komeda probe failing if there are no links in the secondary pipeline

2024-03-06 Thread Liviu Dudau
Hi Faiz, On Mon, Feb 19, 2024 at 03:39:13PM +0530, Faiz Abbas wrote: > Since commit f7936d6beda9 ("drm/arm/komeda: Remove component framework and > add a simple encoder"), the devm_drm_of_get_bridge() call happens > regardless of whether any remote nodes are available on the pipeline. Fix > this b

[PATCH v3 1/6] drm/mst: read sideband messaging cap

2024-03-06 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 0/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
v3 of https://patchwork.freedesktop.org/series/129468/ Jani Nikula (6): drm/mst: read sideband messaging cap drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: abstract choosing the MST mode to use drm/i915/mst: use the MST mode detected previously drm/i915/mst: add

[PATCH v3 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-03-06 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

[PATCH v3 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-03-06 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 4/6] drm/i915/mst: use the MST mode detected previously

2024-03-06 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. v2: Rebase on drm_dp_mst_detect() returning the mode, not bool Cc: Arun R Mur

[PATCH v3 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-03-06 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCH v3 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the registe

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > When extending support for a driver-specific KMS property to additional > drivers, we should apply all the requirements for new properties and > make sure the semantics are the same and documented. > > Signed-off-by: Sebastian

Re: [PULL] drm-misc-fixes

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 01:54:30PM +, Matthew Auld wrote: > On 29/02/2024 13:37, Maxime Ripard wrote: > > Hi, > > > > Here's this week drm-misc fixes PR. > > > > There's two commits for files unders drivers/soc/qcom that don't have a > > maintainer Acked-by. Bjorn's Acked-by was provided

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > > On 3/6/2024 6:12 PM, Christian König wrote: > > Am 06.03.24 um 11:40 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 3:37 PM, Christian König wrote: > >>> Am 06.03.24 um 10:04 schrieb Sunil Khatri: > When an page fault interrupt is raise

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-06 Thread Pavel Begunkov
On 3/5/24 22:36, Mina Almasry wrote: On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote: On 2024-03-04 18:01, Mina Almasry wrote: +struct memory_provider_ops { + int (*init)(struct page_pool *pool); + void (*destroy)(struct page_pool *pool); + struct page *(*alloc_pages)(struct page_p

Re: [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-03-06 Thread Steven Price
On 06/03/2024 01:56, Adrián Larumbe wrote: > Debugfs isn't always available in production builds that try to squeeze > every single byte out of the kernel image, but we still need a way to > toggle the timestamp and cycle counter registers so that jobs can be > profiled for fdinfo's drm engine and

Re: [PATCH v3] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-03-06 Thread Dharma.B
On 05/03/24 3:31 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Mar 04, 2024 at 08:00:03PM +0530, Dharma Balasubiramani wrote: >> Convert the atmel,lcdc bindings to DT schema. >> Changes during conversion: add mis

[PATCH] staging: fbtft: Fix space before parenthesis as per checkpatch.pl

2024-03-06 Thread me
From: Uri Arev Errors reported by checkpatch.pl: ERROR: space prohibited before that close parenthesis ')' +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) ERROR: space prohibited before that close parenthesis ')' +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) CHECK: Unne

[PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Douglas Anderson
This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. Apparently there was a previous discussion about emulation of formats and it was decided XRGB was the only format to support for legacy userspace [1]. Remove ARGB. Userspace needs to be fixed to accept XRGB. [1] https://lor

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Thomas Zimmermann
Am 06.03.24 um 15:37 schrieb Douglas Anderson: This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. Apparently there was a previous discussion about emulation of formats and it was decided XRGB was the only format to support for legacy userspace [1]. Remove ARGB. Userspace ne

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Javier Martinez Canillas
Douglas Anderson writes: Hello Doug, > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB was the only format to support for legacy > userspace [1]. Remove ARGB. Userspace needs

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 22:58 schrieb Dmitry Osipenko: On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking in DRM's console emulation. Similar ch

Re: [PATCH v15 2/8] phy: Add HDMI configuration options

2024-03-06 Thread Maxime Ripard
Hi Alexander, On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > From: Sandor Yu > > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. > > The parameters added here are based on HDMI PHY > implementation pract

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Rob Clark
On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann wrote: > > Hi, > > sorry that I did not see the patch before. > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > Even though the UDL driver converts to RGB565 internally (see > > pixel32_to_be16() in udl_transfer.c), it advertises XRGB for >

Re: [RFC PATCH net-next v6 09/15] memory-provider: dmabuf devmem memory provider

2024-03-06 Thread Pavel Begunkov
On 3/6/24 02:42, Mina Almasry wrote: On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote: On 2024-03-04 18:01, Mina Almasry wrote: + if (pool->p.queue) + binding = READ_ONCE(pool->p.queue->binding); + + if (binding) { + pool->mp_ops = &dmabuf_devmem_ops; +

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an page fault

Re: [PATCH v3 5/5] arm64: dts: allwinner: a64: Run GPU at 432 MHz

2024-03-06 Thread Erico Nunes
On Mon, Mar 4, 2024 at 6:01 PM Frank Oltmanns wrote: > > The Allwinner A64's GPU has currently three operating points. However, > the BSP runs the GPU fixed at 432 MHz. In addition, at least one of the > devices using that SoC - the pinephone - shows unstabilities (see link) > that can be circumve

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 4:07 AM Thomas Zimmermann wrote: > > Hi, > > sorry that I did not see the patch before. > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > Even though the UDL driver converts to RGB565 internally (see > > pixel32_to_be16() in udl_transfer.c), it advertises XRGB

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Ville Syrjälä
On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote: > On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann wrote: > > > > Hi, > > > > sorry that I did not see the patch before. > > > > Am 27.02.24 um 23:19 schrieb Douglas Anderson: > > > Even though the UDL driver converts to RGB565 internally

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 6:38 AM Douglas Anderson wrote: > > This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475. > > Apparently there was a previous discussion about emulation of formats > and it was decided XRGB was the only format to support for legacy > userspace [1]. Remove AR

Re: [PATCH v7 2/6] drm/i915: Unregister in-kernel clients

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 17:25 schrieb Jani Nikula: On Tue, 05 Mar 2024, Rodrigo Vivi wrote: On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote: Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915

Re: [PATCH v15 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-03-06 Thread Maxime Ripard
Hi, On Wed, Mar 06, 2024 at 11:16:21AM +0100, Alexander Stein wrote: > +static int cdns_mhdp8501_read_hpd(struct cdns_mhdp8501_device *mhdp) > +{ > + u8 status; > + int ret; > + > + mutex_lock(&mhdp->mbox_mutex); > + > + ret = cdns_mhdp_mailbox_send(&mhdp->base, MB_MODULE_ID_GENERA

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-06 Thread Shuah Khan
Hi Stephen, On 3/1/24 15:30, Shuah Khan wrote: Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at

[rerere PATCH v2] nightly.conf: Update the drm-misc repo

2024-03-06 Thread Maxime Ripard
drm-misc has moved to gitlab now, so let's update the repo location. Signed-off-by: Maxime Ripard --- nightly.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/nightly.conf b/nightly.conf index b851af21929a..ab58579c8006 100644 --- a/nightly.conf +++ b/nightly.conf @@ -40,10 +40,15 @

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > On 3/6/2024 8:34 PM, Christian König wrote: > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > >>> > >>> On 3/6/2024 6:12 PM, Christian König wrote: > Am 06.03.24 um 11:40 schrie

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Thomas Zimmermann
Hi Am 06.03.24 um 16:05 schrieb Doug Anderson: Hi, On Wed, Mar 6, 2024 at 4:07 AM Thomas Zimmermann wrote: Hi, sorry that I did not see the patch before. Am 27.02.24 um 23:19 schrieb Douglas Anderson: Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in udl_tr

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-03-06 Thread Rob Clark
On Wed, Mar 6, 2024 at 7:06 AM Ville Syrjälä wrote: > > On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote: > > On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann > > wrote: > > > > > > Hi, > > > > > > sorry that I did not see the patch before. > > > > > > Am 27.02.24 um 23:19 schrieb Dougl

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 P

[PATCH v2 1/2] MAINTAINERS: Update drm-misc.git URL

2024-03-06 Thread Maxime Ripard
Now that the drm-misc tree has moved to Gitlab, adjust the MAINTAINERS git trees to reflect the location change. Signed-off-by: Maxime Ripard --- MAINTAINERS | 172 ++-- 1 file changed, 86 insertions(+), 86 deletions(-) diff --git a/MAINTAINERS b/

[PATCH v2 2/2] MAINTAINERS: Update drm-misc web page

2024-03-06 Thread Maxime Ripard
This URL gets redirected to the Intel landing page now. Let's switch the webpage to freedesktop. Signed-off-by: Maxime Ripard --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d4e33b3a3bc0..cdd3ddd6efb5 100644 --- a/MAINTAINERS ++

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgp

  1   2   3   >