[PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and compute command streamers simultaneously can cause GPU hangs due issues in firmware scheduling. Based

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Jani Nikula
On Wed, 07 Feb 2024, Lucas De Marchi wrote: > Now that include/linux/bits.h implements fixed-width GENMASK_*, use them > to implement the i915/xe specific macros. Converting each driver to use > the generic macros are left for later, when/if other driver-specific > macros are also generalized. > >

Re: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible

2024-02-08 Thread Krzysztof Kozlowski
On 07/02/2024 11:27, Dharma Balasubiramani wrote: > Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage > Differential Signaling (LVDS) Controller found on some Microchip's sam9x7 > series System-on-Chip (SoC) devices. This binding will be used to define > the properties and

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2024-02-08 Thread Christian Brauner
On Wed, Feb 07, 2024 at 03:34:59PM +0100, Paolo Bonzini wrote: > On Wed, Nov 22, 2023 at 1:49 PM Christian Brauner wrote: > > > > Ever since the evenfd type was introduced back in 2007 in commit > > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > > function only ever passe

Re: [PATCH] drm/mgag200: Add a workaround for low-latency

2024-02-08 Thread Jocelyn Falempe
On 07/02/2024 10:47, Thomas Zimmermann wrote: Hi Am 06.02.24 um 23:21 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectation on isolated core. After the v5.

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Thomas Hellström
Hi, On Thu, 2024-02-08 at 07:30 +0100, Christian König wrote: > Am 08.02.24 um 01:36 schrieb Dave Airlie: > > Just cc'ing some folks. I've also added another question. > > > > On Wed, 7 Feb 2024 at 21:08, Maíra Canal wrote: > > > Adding another point to this discussion, would it make sense to >

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-08 Thread Pekka Paalanen
On Wed, 7 Feb 2024 16:49:56 +0100 Louis Chauvet wrote: > Hello Pekka, Arthur, Maxime, Hi all > > > > >> Change the composition algorithm to iterate over pixels instead > > > > >> of lines. > > > > >> It allows a simpler management of rotation and pixel access for > > > > >> co

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Thomas Hellström
On Thu, 2024-02-08 at 10:38 +0100, Thomas Hellström wrote: > Hi, > > On Thu, 2024-02-08 at 07:30 +0100, Christian König wrote: > > Am 08.02.24 um 01:36 schrieb Dave Airlie: > > > Just cc'ing some folks. I've also added another question. > > > > > > On Wed, 7 Feb 2024 at 21:08, Maíra Canal > > >

Re: [PATCH v3 3/8] firmware/sysfb: Set firmware-framebuffer parent device

2024-02-08 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.8-rc3 next-20240208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Pekka Paalanen
On Wed, 07 Feb 2024 17:17:15 -0300 Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > Link: https://lore.kernel.org/all/202402

[PATCH v2] drm/mgag200: Add a workaround for low-latency

2024-02-08 Thread Jocelyn Falempe
We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectation on isolated core. After the v5.10, the real time tasks missed their <10us latency when something prints on the screen (fbcon or print

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-08 Thread Jani Nikula
On Wed, 07 Feb 2024, Mario Limonciello wrote: > Some manufacturers have intentionally put an EDID that differs from > the EDID on the internal panel on laptops. Drivers can call this > helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method. > > Signed-off-by: Mario Limonciello > --

Re: (subset) [PATCH] backlight: ktz8866: Correct the check for of_property_read_u32

2024-02-08 Thread Lee Jones
On Mon, 29 Jan 2024 20:28:29 +0800, Jianhua Lu wrote: > of_property_read_u32 returns 0 when success, so reverse the > return value to get the true value. > > Applied, thanks! [1/1] backlight: ktz8866: Correct the check for of_property_read_u32 commit: 7c0ff4ae24bf4589b5bb460e4b31817c61fa2

Re: (subset) [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-02-08 Thread Lee Jones
On Sun, 28 Jan 2024 15:49:04 +, Sean Young wrote: > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user > in the tree. > > Applied, thanks! [1/1] backlight: mp3309c: Use pwm_apply_might_sleep()

Re: (subset) [linux][PATCH v5 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-08 Thread Lee Jones
On Wed, 31 Jan 2024 09:05:23 +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with the sp

Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-08 Thread Lee Jones
On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with the sp

Re: (subset) [linux][PATCH v5 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Lee Jones wrote: > On Wed, 31 Jan 2024 09:05:23 +0530, Dharma Balasubiramani wrote: > > Convert the atmel,hlcdc binding to DT schema format. > > > > Align clocks and clock-names properties to clearly indicate that the LCD > > controller expects lvds_pll_clk when interfaced wi

Re: [RFC PATCH 1/3] dt-bindings: display: ti,am65x-dss: Add support for display sharing mode

2024-02-08 Thread Devarsh Thakkar
Hi Rob, Thanks for the review. On 19/01/24 19:25, Rob Herring wrote: > On Thu, Jan 18, 2024 at 7:59 AM Devarsh Thakkar wrote: >> >> Hi Rob, >> >> Thanks for the quick review. >> >> On 18/01/24 01:43, Rob Herring wrote: >>> On Tue, Jan 16, 2024 at 07:11:40PM +0530, Devarsh Thakkar wrote: Add

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Lee Jones
On Thu, 01 Feb 2024 16:47:41 +0200, Andy Shevchenko wrote: > A few ad-hoc cleanups and one patch to make driver OF-independent. > > Chagelog v2: > - renamed init to init_fn and typedef accordingly (Daniel) > - added tags (Daniel, Javier) > > Andy Shevchenko (4): > backlight: hx8357: Make use of

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Lee Jones
On Thu, 01 Feb 2024, Andy Shevchenko wrote: > A few ad-hoc cleanups and one patch to make driver OF-independent. > > Chagelog v2: > - renamed init to init_fn and typedef accordingly (Daniel) > - added tags (Daniel, Javier) > > Andy Shevchenko (4): > backlight: hx8357: Make use of device proper

[PATCH] dt-bindings: use capital "OR" for multiple licenses in SPDX

2024-02-08 Thread Krzysztof Kozlowski
Documentation/process/license-rules.rst and checkpatch expect the SPDX identifier syntax for multiple licenses to use capital "OR". Correct it to keep consistent format and avoid copy-paste issues. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/panel/visionox,r66451.yaml

Re: [RFC PATCH 3/3] arm64: dts: ti: k3-am62x: Add overlay to use DSS in display sharing mode

2024-02-08 Thread Devarsh Thakkar
Hi Tomi, Thanks for the review. On 23/01/24 13:59, Tomi Valkeinen wrote: > Hi, > > On 16/01/2024 15:41, Devarsh Thakkar wrote: >> This overlay needs to be used with display sharing supported device >> manager firmware only. >> >> Remote core running this firmware has write access to "common" reg

[PULL] drm-xe-fixes

2024-02-08 Thread Thomas Hellstrom
Dave, Sima The drm-xe-fixes pull for -rc4. Thanks, Thomas drm-xe-fixes-2024-02-08: Driver Changes: - Fix a loop in an error path - Fix a missing dma-fence reference - Fix a retry path on userptr REMAP - Workaround for a false gcc warning - Fix missing map of the usm batch buffer in the migrate

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Christian König
Am 08.02.24 um 10:43 schrieb Thomas Hellström: On Thu, 2024-02-08 at 10:38 +0100, Thomas Hellström wrote: Hi, On Thu, 2024-02-08 at 07:30 +0100, Christian König wrote: Am 08.02.24 um 01:36 schrieb Dave Airlie: Just cc'ing some folks. I've also added another question. On Wed, 7 Feb 2024 at 21

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Kamil Konieczny
Hi Arthur, On 2024-02-07 at 17:17:15 -0300, Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > Link: https://lore.kernel.org/all

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Thomas Hellström
On Thu, 2024-02-08 at 12:08 +0100, Christian König wrote: > Am 08.02.24 um 10:43 schrieb Thomas Hellström: > > On Thu, 2024-02-08 at 10:38 +0100, Thomas Hellström wrote: > > > Hi, > > > > > > On Thu, 2024-02-08 at 07:30 +0100, Christian König wrote: > > > > Am 08.02.24 um 01:36 schrieb Dave Airlie

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 01 Feb 2024, Andy Shevchenko wrote: > Allow to use driver on non-OF platforms and other cleanups. > > Changelog v2: > - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel) > - add tags (Daniel, Flavio) > - new patch 2 > > Andy Shevchenko (3): > backlight: mp3309c: Make u

[PATCH] fbcon: always restore the old font data in fbcon_do_set_font()

2024-02-08 Thread Jiri Slaby (SUSE)
Commit a5a923038d70 (fbdev: fbcon: Properly revert changes when vc_resize() failed) started restoring old font data upon failure (of vc_resize()). But it performs so only for user fonts. It means that the "system"/internal fonts are not restored at all. So in result, the very first call to fbcon_do

Re: [PATCH v2] drm/mgag200: Add a workaround for low-latency

2024-02-08 Thread Thomas Zimmermann
Am 08.02.24 um 10:51 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectation on isolated core. After the v5.10, the real time tasks missed their <10us latency

[PULL] drm-misc-fixes

2024-02-08 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-02-08: A null pointer dereference fix for v3d, a TTM pool initialization fix, several fixes for nouveau around register size, DMA buffer leaks and API consistency, a multiple fixes for ivpu around MMU setup, initialization and fir

Re: [PATCH v3 3/8] firmware/sysfb: Set firmware-framebuffer parent device

2024-02-08 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-tip/drm-tip linus/master v6.8-rc3 next-20240208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Arunpravin Paneer Selvam
Hi Christian, On 2/8/2024 12:27 PM, Christian König wrote: Am 07.02.24 um 18:44 schrieb Arunpravin Paneer Selvam: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the r

[PULL] drm-intel-fixes

2024-02-08 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes drm-intel-fixes, which is just the gvt-fixes PR for this week. Regards, Joonas *** drm-intel-fixes-2024-02-08: - Just includes gvt-fixes-2024-02-05 The following changes since commit 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478: Linux 6.8-rc3 (2024-02-04 12:20:36 +000

Re: [PATCH v2 3/6] clk: sunxi-ng: nkm: Support minimum and maximum rate

2024-02-08 Thread Maxime Ripard
On Mon, Feb 05, 2024 at 04:22:26PM +0100, Frank Oltmanns wrote: > According to the Allwinner User Manual, the Allwinner A64 requires > PLL-MIPI to run at 500MHz-1.4GHz. Add support for that to ccu_nkm. > > Signed-off-by: Frank Oltmanns > --- > drivers/clk/sunxi-ng/ccu_nkm.c | 13 + >

[PATCH] drm/amd/display: Fix missing NULL check in dcn21_set_backlight_level()

2024-02-08 Thread Nikita Zhandarovich
On the off chance 'panel_cntl' ends up being not properly initialized, dcn21_set_backlight_level() may hit NULL pointer dereference while changing embedded panel backlight levels. Prevent this issue by using some of the existing checks for the similar purpose. At the same time clean up redundant t

Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-02-08 Thread Devarsh Thakkar
Hi Maxime, Thanks a lot for checking on this. On 26/01/24 17:45, Maxime Ripard wrote: > Hi, > > Thanks a lot for working on that. > > On Tue, Jan 16, 2024 at 07:11:41PM +0530, Devarsh Thakkar wrote: >> Display subsystem present in TI Keystone family of devices supports sharing >> of display bet

Re: Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-08 Thread Maxime Ripard
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: > On Wed, 07 Feb 2024, Mario Limonciello wrote: > > Some manufacturers have intentionally put an EDID that differs from > > the EDID on the internal panel on laptops. Drivers can call this > > helper to attempt to fetch the EDID from th

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-02-08 Thread Adam Ford
On Mon, Jan 29, 2024 at 2:17 AM Frieder Schrempf wrote: > > On 25.01.24 19:44, Adam Ford wrote: > > On Mon, Dec 11, 2023 at 9:33 PM Adam Ford wrote: > >> > >> When using video sync pulses, the HFP, HBP, and HSA are divided between > >> the available lanes if there is more than one lane. For cert

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Juha-Pekka Heikkila
Hi Arthur, I was taking brief look. Generally things look ok. Few comments below. On 7.2.2024 22.17, Arthur Grillo wrote: Create a benchmark for the VKMS driver. Use a KMS layout with deliberate odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT frames flipping framebuffer

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in som

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abel Vesa
On 24-01-29 17:11:25, Dmitry Baryshkov wrote: > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > Add support for MDSS on X1E80100. > > > > Signed-off-by: Abel Vesa > > --- > > drivers/gpu/drm/msm/msm_mdss.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Dmitry Baryshkov
On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: > > On 24-01-29 17:11:25, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > > > Add support for MDSS on X1E80100. > > > > > > Signed-off-by: Abel Vesa > > > --- > > > drivers/gpu/drm/msm/msm_mdss.c | 10 ++ >

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abel Vesa
On 24-02-08 15:42:04, Dmitry Baryshkov wrote: > On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: > > > > On 24-01-29 17:11:25, Dmitry Baryshkov wrote: > > > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > > > > > Add support for MDSS on X1E80100. > > > > > > > > Signed-off-by: Abel Vesa > >

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Arunpravin Paneer Selvam
Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Mario Limonciello
On 2/8/2024 06:06, Arunpravin Paneer Selvam wrote: Hi Christian, On 2/8/2024 12:27 PM, Christian König wrote: Am 07.02.24 um 18:44 schrieb Arunpravin Paneer Selvam: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the pro

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Kamil Konieczny
Hi Arthur, On 2024-02-07 at 17:17:15 -0300, Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > Link: https://lore.kernel.org/all

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem t

Re: [PATCH v4 01/14] drm/panthor: Add uAPI

2024-02-08 Thread Liviu Dudau
Hi Boris, Minor spelling issues to raise in the documentation text uAPI: On Mon, Jan 22, 2024 at 05:30:32PM +0100, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > >

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
Hi Boris, On Mon, Jan 22, 2024 at 05:30:34PM +0100, Boris Brezillon wrote: > The panthor driver is designed in a modular way, where each logical > block is dealing with a specific HW-block or software feature. In order > for those blocks to communicate with each other, we need a central > panthor_

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add a new query to the GuC submission interface version. > > Mesa intends to use this information to check for old firmware versions > with a known bug where using the render and compute command streamers > simul

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 01 Feb 2024 17:14:12 +0200, Andy Shevchenko wrote: > Allow to use driver on non-OF platforms and other cleanups. > > Changelog v2: > - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel) > - add tags (Daniel, Flavio) > - new patch 2 > > [...] Applied, thanks! [1/3] backli

Re: [PATCH] dt-bindings: backlight: qcom-wled: Fix bouncing email addresses

2024-02-08 Thread Lee Jones
On Fri, 02 Feb 2024, Jeffrey Hugo wrote: > Bjorn is no longer at Linaro. Update his email address to @kernel to > match the .mailmap entry. > > The servers for @codeaurora are long retired and messages sent there > will bounce. Update Kiran's email address to match the .mailmap entry. > > This

Re: Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-08 Thread Jani Nikula
On Thu, 08 Feb 2024, Maxime Ripard wrote: > On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: >> On Wed, 07 Feb 2024, Mario Limonciello wrote: >> > Some manufacturers have intentionally put an EDID that differs from >> > the EDID on the internal panel on laptops. Drivers can call this

[PATCH] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-08 Thread Matthew Auld
Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König --- drivers/gpu/drm/tests/drm_buddy_test.c | 89 ++ 1 file change

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 14:17, Matthew Auld wrote: On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playin

[PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-08 Thread Dmitry Baryshkov
We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout message and trigger the devcore snapshot capture. S

[PATCH v4 1/4] drm/msm/mdss: generate MDSS data for MDP5 platforms

2024-02-08 Thread Dmitry Baryshkov
Older (mdp5) platforms do not use per-SoC compatible strings. Instead they use a single compat entry 'qcom,mdss'. To facilitate migrating these platforms to the DPU driver provide a way to generate the MDSS / UBWC data at runtime, when the DPU driver asks for it. It is not possible to generate thi

[PATCH v4 0/4] drm/msm: provide migration path from MDP5 to DPU driver

2024-02-08 Thread Dmitry Baryshkov
Over the last several years the DPU driver has been actively developed, while the MDP5 is mostly in the maintenance mode. This results in some features being available only in the DPU driver. For example, bandwidth scaling, writeback support, properly supported bonded DSI aka dual DSI support, DSC

[PATCH v4 4/4] drm/msm/dpu: add support for SDM660 and SDM630 platforms

2024-02-08 Thread Dmitry Baryshkov
Bring in hardware support for the SDM660 and SDM630 platforms, which belong to the same DPU generation as MSM8998. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provided. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad

[PATCH v4 3/4] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2024-02-08 Thread Dmitry Baryshkov
For some of the platforms (e.g. SDM660, SDM630, MSM8996, etc.) it is possible to support this platform via the DPU driver (e.g. to provide support for DP, multirect, etc). Add a modparam to be able to switch between these two drivers. All platforms supported by both drivers are by default handled

[PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-08 Thread Dmitry Baryshkov
Existing MDP5 devices have slightly different bindings. The main register region is called `mdp_phys' instead of `mdp'. Also vbif register regions are a part of the parent, MDSS device. Add support for handling this binding differences. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dis

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 14:30:02 + Liviu Dudau wrote: > > +int panthor_device_init(struct panthor_device *ptdev) > > +{ > > + struct resource *res; > > + struct page *p; > > + int ret; > > + > > + ptdev->coherent = device_get_dma_attr(ptdev->base.dev) == > > DEV_DMA_COHERENT; > > + > > +

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-08 Thread Ville Syrjälä
On Wed, Feb 07, 2024 at 11:02:27PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:48:53PM +0200, Imre Deak wrote: > > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > > > [...] > > > > +static int > > > > +drm_dp_tunnel_atomic_check_group_bw(struct drm_dp_tunnel_group_state

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 14:30:02 + Liviu Dudau wrote: > > +#ifdef CONFIG_PM > > +int panthor_device_resume(struct device *dev) > > +{ > > + struct panthor_device *ptdev = dev_get_drvdata(dev); > > + int ret, cookie; > > + > > + if (atomic_read(&ptdev->pm.state) != PANTHOR_DEVICE_PM_STATE_SUS

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > On 08/02/2024 14:30, Souza, Jose wrote: > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Add a new query to the GuC submission interface version. > > > > > > Mesa intends to use this inf

[PATCH v4 3/5] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

2024-02-08 Thread Dmitry Baryshkov
The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the INTF and WB are statically allocated to each encoder/phys_enc, drop the atomic_mode_set callback and set the IRQs during encoder init. For the CMD panel usecase some of IRQ indexes depend on the selected resources. Move setti

[PATCH v4 5/5] drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check()

2024-02-08 Thread Dmitry Baryshkov
Writeback was the last user of dpu_encoder_phys_ops's atomic_check() callback. As the code was moved to the dpu_writeback.c, the callback becomes unused. Drop it now. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 ---

[PATCH v4 2/5] drm/msm/dpu: split _dpu_encoder_resource_control_helper()

2024-02-08 Thread Dmitry Baryshkov
Follow the _dpu_encoder_irq_control() change and split the _dpu_encoder_resource_control_helper() into enable and disable parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 45 +++-- drivers/gpu/drm/msm/dis

[PATCH v4 0/5] drm/msm/dpu: remove dpu_encoder_phys_ops::atomic_mode_set callback

2024-02-08 Thread Dmitry Baryshkov
dpu_writeback.h | 3 +- 9 files changed, 274 insertions(+), 224 deletions(-) --- base-commit: b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d change-id: 20240208-fd_remove_phys_ops_atomic_mode_set-ab706706b374 Best regards, -- Dmitry Baryshkov

[PATCH v4 1/5] drm/msm/dpu: split irq_control into irq_enable and _disable

2024-02-08 Thread Dmitry Baryshkov
The single helper for both enable and disable cases is too complicated, especially if we start adding more code to these helpers. Split it into irq_enable and irq_disable cases. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 3

[PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-08 Thread Dmitry Baryshkov
dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 54 ---

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-08 Thread Kousik Sanagavarapu
On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: > The comments explaining the function "drm_dp_mst_atom_check_mgr()" had > uneven indentation which made "make htmldocs" complain: > > Documentation/gpu/drm-kms-helpers:296: > ./drivers/gpu/drm/display/drm_dp_mst_topo

[PATCH v4] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2024-02-08 Thread Dmitry Baryshkov
_total -= hdisplay; if (wide_bus_enabled && !(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO)) --- base-commit: b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d change-id: 20240208-fd_document_dsc_pclk_rate-da6a62919876 Best regards, -- Dmitry Baryshkov

Re: Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-08 Thread Maxime Ripard
On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: > On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote: > > The component helper functions are the glue, which is used to bind multiple > > GPU cores to a virtual master platform device. Which is fine and works well > > for the

Re: [PATCH] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-08 Thread Arunpravin Paneer Selvam
On 2/8/2024 8:06 PM, Matthew Auld wrote: Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. That's really quick :) Reviewed-by: Arunpravin Paneer Selvam References:https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc:

Re: [PATCH v3 1/2] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
On 1/31/2024 11:59 PM, Matthew Auld wrote: On 30/01/2024 20:30, Arunpravin Paneer Selvam wrote: Hi Matthew, On 12/21/2023 12:51 AM, Matthew Auld wrote: Hi, On 14/12/2023 13:42, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED

[PATCH v6 2/3] drm/amdgpu: Enable clear page functionality

2024-02-08 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

[PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

[PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-08 Thread Arunpravin Paneer Selvam
Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/drm_buddy.c | 67 +++-- include/

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > On Thu, 8 Feb 2024 14:30:02 + > Liviu Dudau wrote: > > > > +int panthor_device_init(struct panthor_device *ptdev) > > > +{ > > > + struct resource *res; > > > + struct page *p; > > > + int ret; > > > + > > > + ptdev->coherent

Re: [PATCH v5 1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
On 1/31/2024 11:52 PM, Matthew Auld wrote: On 30/01/2024 19:48, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as cl

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 15:55:36 + Liviu Dudau wrote: > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > On Thu, 8 Feb 2024 14:30:02 + > > Liviu Dudau wrote: > > > > > > +int panthor_device_init(struct panthor_device *ptdev) > > > > +{ > > > > + struct resource *r

Re: [PATCH v4 00/14] drm: Add a driver for CSF-based Mali GPUs

2024-02-08 Thread Liviu Dudau
On Mon, Jan 22, 2024 at 05:30:31PM +0100, Boris Brezillon wrote: > Hello, Hi, > > This is the 4th version of the kernel driver for Mali CSF-based GPUs. > > A branch based on drm-misc-next and containing all the dependencies > that are not yet available in drm-misc-next here[1], and another [2]

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

2024-02-08 Thread Darrick J. Wong
On Wed, Feb 07, 2024 at 05:56:21PM -0800, Andrew Morton wrote: > On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" > wrote: > > > On Thu, Jan 11, 2024 at 10:45:53PM +, Matthew Wilcox wrote: > > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > > On Wed, 10 Jan 2024 12

Re: [PATCH v4 04/14] drm/panthor: Add the GPU logical block

2024-02-08 Thread Steven Price
On 22/01/2024 16:30, Boris Brezillon wrote: > Handles everything that's not related to the FW, the MMU or the > scheduler. This is the block dealing with the GPU property retrieval, > the GPU block power on/off logic, and some global operations, like > global cache flushing. > > v4: > - Expose COR

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
On Thu, Feb 08, 2024 at 05:00:23PM +0100, Boris Brezillon wrote: > On Thu, 8 Feb 2024 15:55:36 + > Liviu Dudau wrote: > > > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > > On Thu, 8 Feb 2024 14:30:02 + > > > Liviu Dudau wrote: > > > > > > > > +int panthor_device

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Daniel Vetter
On Wed, Feb 07, 2024 at 08:08:42AM -0300, Maíra Canal wrote: > Adding another point to this discussion, would it make sense to somehow > create a generic structure that all drivers, including shmem drivers, could > use it? So the issue is a bit that at least the userptr for shmem drivers I've see

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 16:18:48 + Liviu Dudau wrote: > On Thu, Feb 08, 2024 at 05:00:23PM +0100, Boris Brezillon wrote: > > On Thu, 8 Feb 2024 15:55:36 + > > Liviu Dudau wrote: > > > > > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > > > On Thu, 8 Feb 2024 14:30:02

[pull] amdgpu drm-fixes-6.8

2024-02-08 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit d0399da9fb5f8e3d897b9776bffee2d3bfe20210: drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL (2024-02-06 12:47:43 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 5:46 AM, Abel Vesa wrote: On 24-02-08 15:42:04, Dmitry Baryshkov wrote: On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: On 24-01-29 17:11:25, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: Add support for MDSS on X1E80100. Signed-off-by: Abel Vesa --

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote: > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > Someone may wish to address this: > > WARNING: DT compatible string "himax,hx8369" appears un-documented -- check > ./Documentation/devicetree/bindings/ > #58: FILE: drivers/video/back

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote: > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > ... > > > Someone may wish to address this: > > > > WARNING: DT compatible string "himax,hx8369" appears un-documented -- check > > ./Doc

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > > backlight: mp3309c: Utilise temporary variable for struct device (1) > Set no longer applies. Please rebase, thanks. I got a contradictory messages: 1) email that says that all h

Re: [PATCH v4] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 7:23 AM, Dmitry Baryshkov wrote: Provide actual documentation for the pclk and hdisplay calculations in the case of DSC compression being used. Signed-off-by: Dmitry Baryshkov --- Changes since v3: - refresh rate -> transfer time (Abhinav) Changes since v2: - Followed suggestion

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > ... > > > > backlight: mp3309c: Utilise temporary variable for struct device > > (1) > > > Set no longer applies. Please rebase, thank

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-08 Thread John Harrison
On 2/8/2024 00:41, Tvrtko Ursulin wrote: On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: > On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > > On 08/02/2024 14:30, Souza, Jose wrote: > > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > Add a new query to the

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > > > > backlight: mp3309c: Utilise temporary variable for struct device

  1   2   >