[PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-01-31 Thread Qiang Ma
Problem: The computer in the bios initialization process, unplug the HDMI display, wait until the system up, plug in the HDMI display, did not enter the hotplug interrupt function, the display is not bright. Fix: After the above problem occurs, and the hpd ack interrupt bit is 1, the interrupt sho

Re: [PATCH v4 0/4] arm64: rockchip: Pine64 PineTab2 support

2024-01-31 Thread Heiko Stübner
Am Dienstag, 30. Januar 2024, 20:36:22 CET schrieb Manuel Traut: > Hi Dang, > > On Sat, Jan 27, 2024 at 06:35:50PM +0700, Dang Huynh wrote: > > Hi Manuel, > > > > Since the BOE patches have been accepted to next, you do not need to > > include > > it in this patch series. > > sorry, I thought

[PATCH v3 08/24] hwtracing: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/hwtracing/coresight/coresight-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-pl

[PATCH v3 16/24] media: xilinx-tpg: use of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We can now use of_graph_get_next_endpoint(), let's use it. Signed-off-by: Kuninori Morimoto --- drivers/media/platform/xilinx/xilinx-tpg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.

[PATCH v3 00/24] of: property: add port base loop

2024-01-31 Thread Kuninori Morimoto
Hi Rob This is v3 of port base loop patch-set We have "endpoint" base functions - of_graph_get_next_endpoint() - of_graph_get_endpoint_count() - for_each_endpoint_of_node() But to handling "port" base things, it is not useful. We want to have "port" base functions, too.

[PATCH v3 23/24] fbdev: omapfb: use of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We can now use of_graph_get_next_endpoint(), let's use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dpi.c| 3 ++- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 22 +-- drivers/video/fbdev/omap2/omapfb/dss/sdi.c| 3 ++- include/video/om

[PATCH v3 09/24] staging: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 2 +- drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 2 +- drivers/staging/media/tegra

[PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/media/i2c/adv7343.c | 2 +- drivers/media/i2c/adv748x/adv748x-core.c | 2 +- drivers/media/i2c/adv7604.c | 2 +- drivers/media/

[PATCH v3 07/24] gpu: drm: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/gpu/drm/armada/armada_drv.c | 2 +- drivers/gpu/drm/bridge/tc358767.c | 2 +- drivers/gpu/drm/drm_of.c

[PATCH v3 21/24] fbdev: omapfb: use of_graph_get_remote_port()

2024-01-31 Thread Kuninori Morimoto
We already have of_graph_get_remote_port(), Let's use it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/om

Re: [PATCH v3 02/24] of: property: use unsigned int return on of_graph_get_endpoint_count()

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 07:05, Kuninori Morimoto wrote: > > The return type and the variable of of_graph_get_endpoint_count() > should be unsigned. Tidyup it. 'the variable'? I'd have added a few words telling that return type can be unsigned because there is no error reporting for this function.

Re: [PATCH v3 07/24] gpu: drm: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 07:05, Kuninori Morimoto wrote: > > of_graph_get_next_endpoint() is now renamed to > of_graph_get_next_device_endpoint(). Switch to it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/gpu/drm/armada/armada_drv.c | 2 +- > drivers/gpu/drm/bridge/tc358

[PATCH v3 10/24] ASoC: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/ak4613.c | 2 +- sound/soc/generic/audio-graph-card2.c | 2 +- sound/soc/generic/simple-card-utils.c | 6 +++--- sound/soc/generic/t

[PATCH v3 15/24] drm: omapdrm: use of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We can now use of_graph_get_next_endpoint(), let's use it. Signed-off-by: Kuninori Morimoto --- drivers/gpu/drm/omapdrm/dss/dpi.c | 2 +- drivers/gpu/drm/omapdrm/dss/sdi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/

[PATCH v3 13/24] of: property: use of_graph_get_next_port() on of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We have of_graph_get_next_port(), use it on of_graph_get_next_endpoint(). Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen --- drivers/of/property.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/property.c

[PATCH v3 06/24] media: platform: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/media/platform/atmel/atmel-isi.c | 4 ++-- drivers/media/platform/intel/pxa_camera.c| 2 +- drivers/media/platform/microc

[PATCH v3 12/24] of: property: add port base loop

2024-01-31 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_device_endpoint() - of_graph_get_device_endpoint_count() - for_each_device_endpoint_of_node() Here, for_each_device_endpoint_of_node() loop finds each endpoints ports { port@0 { (1)

[PATCH v3 18/24] ASoC: audio-graph-card2: use of_graph_get_next_port()

2024-01-31 Thread Kuninori Morimoto
Now we can use of_graph_get_next_port() for port parsing. Use it on audio-graph-card2 driver. Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-card2.c | 29 --- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/sound/soc/generic/audio-graph-

[PATCH v3 04/24] video: fbdev: switch to use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/amba-clcd.c | 2 +- drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 2 +- drivers/video/fbdev/pxafb.c

[PATCH v3 20/24] ASoC: test-component: use for_each_port_of_node()

2024-01-31 Thread Kuninori Morimoto
Current test-component.c is using for_each_endpoint_of_node() for parsing, but it should use "port" base loop instead of "endpoint", because properties are "port" base instead of "endpoint". Signed-off-by: Kuninori Morimoto --- sound/soc/generic/test-component.c | 2 +- 1 file changed, 1 inserti

[PATCH v3 17/24] ASoC: audio-graph-card: use of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We can now use of_graph_get_next_endpoint(), let's use it. Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 83e3ba773fbd

[PATCH v3 19/24] ASoC: audio-graph-card2: use of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We can now use of_graph_get_next_endpoint(), let's use it. Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-card2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c index b2bd5b70a

[PATCH v3 11/24] of: remove of_graph_get_next_endpoint() define

2024-01-31 Thread Kuninori Morimoto
All driver are using new of_graph_get_next_device_endpoint(), remove of_graph_get_next_endpoint() macro. Signed-off-by: Kuninori Morimoto --- include/linux/of_graph.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h index 80b7a579e96a..f

[PATCH v3 22/24] fbdev: omapfb: use of_graph_get_next_port()

2024-01-31 Thread Kuninori Morimoto
Now we can use of_graph_get_next_port() for port parsing. Use it on omapfb. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 48 +-- drivers/video/fbdev/omap2/omapfb/dss/dss.c| 9 ++-- include/video/omapfb_dss.h| 4 --

[PATCH v3 01/24] of: property: add missing kerneldoc for of_graph_get_endpoint_count()

2024-01-31 Thread Kuninori Morimoto
of_graph_get_endpoint_count() doesn't have kerneldoc. Add it. Signed-off-by: Kuninori Morimoto --- drivers/of/property.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index afdaefbd03f6..4e879faa1710 100644 --- a/drivers/of/property.c +++

[PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()

2024-01-31 Thread Kuninori Morimoto
We already have of_graph_get_next_device_endpoint(), but it is not intuitive to use. (X) node { (Y) ports { port@0 { endpoint { remote-endpoint = ...; };}; (A1)port@1 { endpoint { remote-endpoint = ...; }; (A2)

[PATCH v3 03/24] of: property: rename of_graph_get_next_endpoint() to of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
Current of_graph_get_next_endpoint() will get next endpoint. ports { port@0 { endpoint@0 {...}; (A) endpoint@1 {...}; }; port@1 { (B) endpoint {...}; };

[PATCH v3 02/24] of: property: use unsigned int return on of_graph_get_endpoint_count()

2024-01-31 Thread Kuninori Morimoto
The return type and the variable of of_graph_get_endpoint_count() should be unsigned. Tidyup it. Signed-off-by: Kuninori Morimoto --- drivers/of/property.c| 2 +- include/linux/of_graph.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/of/property.c b/drivers

[PATCH v3 24/24] fbdev: omapfb: use of_graph_get_next_device_endpoint()

2024-01-31 Thread Kuninori Morimoto
omapdss_of_get_first_endpoint() is same as of_graph_get_next_device_endpoint(xxx, NULL). Replcase it. Signed-off-by: Kuninori Morimoto --- drivers/video/fbdev/omap2/omapfb/dss/dsi.c| 3 ++- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 20 +-- drivers/video/fbdev/omap2/oma

Re: [PATCH v2] drm/msm/gem: Fix double resv lock aquire

2024-01-31 Thread Dmitry Osipenko
On 1/31/24 04:15, Rob Clark wrote: > From: Rob Clark > > Since commit 56e5abba8c3e ("dma-buf: Add unlocked variant of vmapping > functions"), the resv lock is already held in the prime vmap path, so > don't try to grab it again. > > v2: This applies to vunmap path as well > > Fixes: 56e5abba8c3

Re: [PATCH RESEND v7 3/7] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

2024-01-31 Thread Lee Jones
On Mon, 29 Jan 2024, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > The register address of the XLCDC IP used in SAM9X7 SoC family > are different from the previous HLCDC. Defining those address > space with valid macros. > > Signed-off-by: Durai Manickam KR > [manikanda...@micro

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the

Re: [Linaro-mm-sig] Re: [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-31 Thread Daniel Vetter
On Tue, Jan 30, 2024 at 02:09:45PM +0100, Christian König wrote: > Am 30.01.24 um 11:40 schrieb Daniel Vetter: > > On Tue, Jan 30, 2024 at 10:48:23AM +0100, Paul Cercueil wrote: > > > Le mardi 30 janvier 2024 à 10:23 +0100, Christian König a écrit : > > > >  I would say we start with the DMA-API b

Re: [PATCH] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-01-31 Thread Thomas Zimmermann
Hi Zack Am 30.01.24 um 20:38 schrieb Zack Rusin: On Fri, Jan 12, 2024 at 4:20 PM Ian Forbes wrote: SVGA requires surfaces to fit within graphics memory (max_mob_pages) which means that modes with a final buffer size that would exceed graphics memory must be pruned otherwise creation will fail

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue, Jan 23, 2024 at 06:09:05AM +

Re: Making drm_gpuvm work across gpu devices

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 09:12:39AM +1000, David Airlie wrote: > On Wed, Jan 31, 2024 at 8:29 AM Zeng, Oak wrote: > > > > Hi Christian, > > > > > > > > Nvidia Nouveau driver uses exactly the same concept of SVM with HMM, GPU > > address in the same process is exactly the same with CPU virtual addr

[drm-drm-misc:drm-misc-next v2] dt-bindings: nt35510: document 'port' property

2024-01-31 Thread Dario Binacchi
Allow 'port' property (coming from panel-common.yaml) to be used in DTS: st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Dario Binacchi Cc: Alexandre Torgue --- Changes in v2: - Rework the patch to drop errors found b

dri-devel@lists.freedesktop.org

2024-01-31 Thread Keith Zhao
> -邮件原件- > 发件人: Maxime Ripard > 发送时间: 2023年12月6日 16:56 > 收件人: Keith Zhao > 抄送: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; linux-ri...@lists.infradead.org; > tzimmerm...@suse.de; airl...@gmail.com; krzysztof.kozlowski...@linaro.org; > Wil

dri-devel@lists.freedesktop.org

2024-01-31 Thread Keith Zhao
> -邮件原件- > 发件人: Maxime Ripard > 发送时间: 2023年12月6日 16:56 > 收件人: Keith Zhao > 抄送: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; linux-ri...@lists.infradead.org; > tzimmerm...@suse.de; airl...@gmail.com; krzysztof.kozlowski...@linaro.org; > Wil

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the

Re: [PATCH] drm/msm/gem: Fix double resv lock aquire

2024-01-31 Thread Christian König
Am 30.01.24 um 23:35 schrieb Rob Clark: From: Rob Clark Since commit 56e5abba8c3e ("dma-buf: Add unlocked variant of vmapping functions"), the resv lock is already held in the prime vmap path, so don't try to grab it again. Fixes: 56e5abba8c3e ("dma-buf: Add unlocked variant of vmapping functi

[Bug 218435] UBSAN: array-index-out-of-bounds in radeon_atombios.c:2620:43

2024-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218435 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Kernel V

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-31 Thread Zhang, Julia
On 2024/1/30 22:23, Christian König wrote: > Am 30.01.24 um 12:16 schrieb Daniel Vetter: >> On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: >>> On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: As vram objects don't have backing pages and thus can't implement d

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > > > External email : Please do not click links or open attachments until > > > you have verified the sender

[PATCHv2 2/2] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-31 Thread Arun R Murthy
With a value of '0' read from MSTM_CAP register MST to be enabled. DP2.1 SCR updates the spec for 128/132b DP capable supporting only one stream and not supporting single stream sideband MSG. The underlying protocol will be MST to enable use of MTP. Signed-off-by: Arun R Murthy --- drivers/gpu/d

[PATCHv2 1/2] drm/display/dp: Check for MSTM_CAP before MSTM_CTRL write

2024-01-31 Thread Arun R Murthy
With DP2.1, multistream packetization and the underneth MST protocol will be required for SST. So check for MSTM_CAP to see if MST is really required and skip the MSTM_CTRL write so that we ensure that only the underneth protocol and the multistream packetization will be enabled and sink will not b

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the wrong git

Re: [PATCH v2 1/4] drm/mediatek: dsi: Use GENMASK() for register mask definitions

2024-01-31 Thread AngeloGioacchino Del Regno
Il 26/12/23 11:46, Fei Shao ha scritto: Hi Angelo, On Wed, Dec 20, 2023 at 9:57 PM AngeloGioacchino Del Regno wrote: Change magic numerical masks with usage of the GENMASK() macro to improve readability. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno -

Re: [PATCH v2 2/4] drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()

2024-01-31 Thread AngeloGioacchino Del Regno
Il 26/12/23 11:48, Fei Shao ha scritto: Hi Angelo, On Wed, Dec 20, 2023 at 9:57 PM AngeloGioacchino Del Regno wrote: Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact(): merge the two in one mtk_dsi_ps_control() function by adding one function parameter `config_vact` which,

Re: Re: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread mrip...@kernel.org
Hi, On Wed, Jan 31, 2024 at 05:27:14AM +, Jason-JH Lin (林睿祥) wrote: > > On Sun, 2024-01-28 at 10:24 +0100, Maxime Ripard wrote: > > On Thu, Jan 25, 2024 at 07:17:21PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 23, 2024 at 06:09:05AM +, Jason-JH Lin (林睿祥) wrote: > > > > Hi Maxime, Danie

Re: [PATCH AUTOSEL 6.1 04/53] drm: Fix color LUT rounding

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 30, 2024 at 06:00:18PM -0500, Sasha Levin wrote: > On Mon, Jan 22, 2024 at 06:50:00PM +0200, Ville Syrjälä wrote: > >On Mon, Jan 22, 2024 at 10:08:05AM -0500, Sasha Levin wrote: > >> From: Ville Syrjälä > >> > >> [ Upstream commit c6fbb6bca10838485b820e8a26c23996f77ce580 ] > > > >Why i

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 12:26:45PM +0200, Dmitry Baryshkov wrote: > On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > > > > > External email : Please d

[PATCH v3 0/7] MediaTek DRM - DSI driver cleanups

2024-01-31 Thread AngeloGioacchino Del Regno
Changes in v3: - Rebased over next-20240131 - Added bitfield.h inclusion in patch 3 - Added three more cleanup commits to the mix to simplify the probe function and remove gotos. Changes in v2: - Rebased over next-20231213 This series performs some cleanups for mtk_dsi, enhancing human

[PATCH v3 7/7] drm/mediatek: dsi: Compress of_device_id entries and add sentinel

2024-01-31 Thread AngeloGioacchino Del Regno
All entries fit in 82 columns, which is acceptable: compress all of the mtk_dsi_of_match[] entries to a single line for each. While at it, also add the usual sentinel comment to the last entry. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 17 ++

[PATCH v3 5/7] drm/mediatek: dsi: Register DSI host after acquiring clocks and PHY

2024-01-31 Thread AngeloGioacchino Del Regno
Registering the dsi host with its ops before getting dsi->regs is simply wrong: even though there's nothing (for now) asynchronously calling those ops before the end of the probe function, installing ops that are using iospace(s) and clocks before even initializing those is too fragile. Register t

[PATCH v3 1/7] drm/mediatek: dsi: Use GENMASK() for register mask definitions

2024-01-31 Thread AngeloGioacchino Del Regno
Change magic numerical masks with usage of the GENMASK() macro to improve readability. While at it, also fix the DSI_PS_SEL mask to include all bits instead of just a subset of them. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediat

[PATCH v3 2/7] drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()

2024-01-31 Thread AngeloGioacchino Del Regno
Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact(): merge the two in one mtk_dsi_ps_control() function by adding one function parameter `config_vact` which, when true, writes the VACT related registers. Reviewed-by: Fei Shao Signed-off-by: AngeloGioacchino Del Regno --- dri

[PATCH v3 4/7] drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ

2024-01-31 Thread AngeloGioacchino Del Regno
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable, expressed in Hz to retrieve a value in MHz: instead of open-coding, use the HZ_PER_MHZ definition, available in linux/units.h. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 1 file ch

[PATCH v3 6/7] drm/mediatek: dsi: Simplify with dev_err_probe and remove gotos

2024-01-31 Thread AngeloGioacchino Del Regno
Most of the functions that are called in the probe callback are devm managed, or all but mipi_dsi_host_register(): simplify the probe function's error paths with dev_err_probe() and remove the lonely instance of `goto err_unregister_host` by just directly calling the mipi_dsi_host_unregister() func

[PATCH v3 3/7] drm/mediatek: dsi: Use bitfield macros where useful

2024-01-31 Thread AngeloGioacchino Del Regno
Instead of open coding bitshifting for various register fields, use the bitfield macro FIELD_PREP(): this allows to enhance the human readability, decrease likeliness of mistakes (and register field overflowing) and also to simplify the code. The latter is especially seen in mtk_dsi_rxtx_control(),

Future handling of complex RGB devices on Linux

2024-01-31 Thread Werner Sembach
Hi, so I combined Hans last draft, with the discussion since then and the comments from the OpenRGB maintainers from here https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916 and my own experience and came up witrh this rough updated draft for the new uapi: Future handling of complex RGB

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread AngeloGioacchino Del Regno
Il 03/08/23 21:33, Mark Brown ha scritto: On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: I agree with you, in fact the speaker is indeed doing this way. But about the hdmi that on the board, I did not find a defination link snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to repl

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread 俞家鑫

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread AngeloGioacchino Del Regno
Il 31/01/24 13:25, Jiaxin Yu (俞家鑫) ha scritto: On Wed, 2024-01-31 at 12:42 +0100, AngeloGioacchino Del Regno wrote: Il 03/08/23 21:33, Mark Brown ha scritto: On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: I agree with you, in fact the speaker is indeed doing this way. But ab

Re: [PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf

2024-01-31 Thread Jani Nikula
On Fri, 12 Jan 2024, Alex Deucher wrote: > On Wed, Jan 10, 2024 at 12:39 PM Jani Nikula wrote: >> >> This will trade the W=1 warning -Wformat-overflow to >> -Wformat-truncation. This lets us enable -Wformat-overflow subsystem >> wide. >> >> Cc: Alex Deucher >> Cc: Christian König >> Cc: Pan, Xi

Re: [PATCH 4/6] drm/imx: prefer snprintf over sprintf

2024-01-31 Thread Jani Nikula
On Fri, 12 Jan 2024, Philipp Zabel wrote: > Hi Jani, > > On Mi, 2024-01-10 at 19:39 +0200, Jani Nikula wrote: >> This will trade the W=1 warning -Wformat-overflow to >> -Wformat-truncation. This lets us enable -Wformat-overflow subsystem >> wide. >> >> Cc: Philipp Zabel >> Signed-off-by: Jani Nik

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > their max

Re: [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

2024-01-31 Thread Jani Nikula
On Wed, 10 Jan 2024, Jani Nikula wrote: > Fix the W=1 warning -Wunused-but-set-variable. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouv...@lists.freedesktop.org > Signed-off-by: Jani Nikula Ping? > --- > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- > 1 fi

Re: [PATCH 2/6] drm/nouveau/svm: remove unused but set variables

2024-01-31 Thread Jani Nikula
On Wed, 10 Jan 2024, Jani Nikula wrote: > Fix the W=1 warning -Wunused-but-set-variable. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouv...@lists.freedesktop.org > Signed-off-by: Jani Nikula Ping? > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 10 +++--- > 1 fil

dri-devel@lists.freedesktop.org

2024-01-31 Thread Maxime Ripard
On Wed, Jan 31, 2024 at 09:33:06AM +, Keith Zhao wrote: > > > > -邮件原件- > > 发件人: Maxime Ripard > > 发送时间: 2023年12月6日 16:56 > > 收件人: Keith Zhao > > 抄送: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > > linux-ker...@vger.kernel.org; linux-ri...@lists.infradead.org; > > tz

Re: [PATCH v4 2/7] dma-buf: heaps: Initialize a restricted heap

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:20:09PM +0800, Yong Wu wrote: > Initialize a restricted heap. Currently just add a null heap, Prepare for > the later patches. > > Signed-off-by: Yong Wu > --- > drivers/dma-buf/heaps/Kconfig | 9 > drivers/dma-buf/heaps/Makefile | 3 +- > dri

Re: [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()

2024-01-31 Thread Luca Ceresoli
Hello Kuninori Morimoto, On Wed, 31 Jan 2024 05:06:36 + Kuninori Morimoto wrote: > To handle endpoint more intuitive, create of_graph_get_next_endpoint() > > of_graph_get_next_endpoint(port1, NULL); // A1 > of_graph_get_next_endpoint(port1, A1); // A2 > of_graph_get_next

Re: [PATCH v4 3/7] dma-buf: heaps: restricted_heap: Add private heap ops

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:20:10PM +0800, Yong Wu wrote: > Add "struct restricted_heap_ops". For the restricted memory, totally there > are two steps: > a) memory_alloc: Allocate the buffer in kernel; > b) memory_restrict: Restrict/Protect/Secure that buffer. > The memory_alloc is mandatory while m

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 02:50:16PM +0200, Hogander, Jouni wrote: > [...] > > + > > +struct drm_dp_tunnel_group; > > + > > +struct drm_dp_tunnel { > > + struct drm_dp_tunnel_group *group; > > + > > + struct list_head node; > > + > > + struct kref kref; > > +#ifdef CONFIG_DRM_DISPLA

Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-31 Thread Rob Herring
On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote: > Most Rockchip hdmi nodes are part of a power domain. > Add a power-domains property. Fix example. > > Signed-off-by: Johan Jonker > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 --- > 1 file changed, 8 in

Re: [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: deprecate port property

2024-01-31 Thread Rob Herring
On Tue, Jan 30, 2024 at 06:18:49PM +, Conor Dooley wrote: > On Tue, Jan 30, 2024 at 03:55:43PM +0100, Johan Jonker wrote: > > The hdmi-connector nodes are now functional and the new way to model > > hdmi nodes with, so deprecate the port property and > > This doesn't really explain what makes

Re: [PATCH v4 3/7] dma-buf: heaps: restricted_heap: Add private heap ops

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:23:07PM -0800, John Stultz wrote: > On Fri, Jan 12, 2024 at 4:13 PM Jeffrey Kardatzke > wrote: > > On Fri, Jan 12, 2024 at 3:51 PM John Stultz wrote: > > > > > > On Fri, Jan 12, 2024 at 3:27 PM Jeffrey Kardatzke > > > wrote: > > > > On Fri, Jan 12, 2024 at 2:52 PM Jo

Re: [PATCH] dma-buf: heaps: Don't track CMA dma-buf pages under RssFile

2024-01-31 Thread Sumit Semwal
Hi TJ, On Thu, 18 Jan 2024 at 15:32, Christian König wrote: > Am 17.01.24 um 19:11 schrieb T.J. Mercier: > > DMA buffers allocated from the CMA dma-buf heap get counted under > RssFile for processes that map them and trigger page faults. In > addition to the incorrect accounting reported to user

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-31 Thread Christian König
Am 31.01.24 um 11:20 schrieb Zhang, Julia: On 2024/1/30 22:23, Christian König wrote: Am 30.01.24 um 12:16 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: [SNIP] Hi Sima, Christian, Yeah, that is really just speculative. All importers need to set the pe

Re: [PATCH] backlight: ktz8866: Correct the check for of_property_read_u32

2024-01-31 Thread Daniel Thompson
On Mon, Jan 29, 2024 at 08:28:29PM +0800, Jianhua Lu wrote: > of_property_read_u32 returns 0 when success, so reverse the > return value to get the true value. > > Fixes: f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 > backlight") > Signed-off-by: Jianhua Lu Reviewed-by: Dan

Re: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-01-31 Thread Daniel Thompson
On Sun, Jan 28, 2024 at 03:49:04PM +, Sean Young wrote: > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user > in the tree. > > Signed-off-by: Sean Young Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Lucas De Marchi
+Jani On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq -> inte

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Jani Nikula
On Wed, 31 Jan 2024, Lucas De Marchi wrote: > +Jani > > On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: >>intel_power_domains_init has been called twice in xe_device_probe: >>xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) >>xe_device_probe -> xe_display_

[PATCH v3] drm/msm/gem: Fix double resv lock aquire

2024-01-31 Thread Rob Clark
From: Rob Clark Since commit 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations"), the resv lock is already held in the prime vmap path, so don't try to grab it again. v2: This applies to vunmap path as well v3: Fix fixes commit Fixes: 79e2cf2e7a19 ("drm/gem: Take reservat

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-01-31 Thread Jason Gunthorpe
On Tue, Jan 30, 2024 at 09:55:18PM +, Jon Hunter wrote: > > On 30/01/2024 16:15, Jason Gunthorpe wrote: > > This was added in commit c95469aa5a18 ("gpu: host1x: Set DMA ops on device > > creation") with the note: > > > > Currently host1x-instanciated devices have their dma_ops left to NU

Re: [drm-drm-misc:drm-misc-next v2] dt-bindings: nt35510: document 'port' property

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 10:28:44AM +0100, Dario Binacchi wrote: > Allow 'port' property (coming from panel-common.yaml) to be used in DTS: > > st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of > the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Dario Binacchi > Cc: Al

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > th

[PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Geert Uytterhoeven
Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA board staging code"), there are no more users of the legacy SuperH Mobile LCDC framebuffer driver on Renesas ARM platforms. All former users on these platforms have been converted to the SH-Mobile DRM driver, using DT. Sugge

RE: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-01-31 Thread Flavio Suligoi
Hi Sean, I've just tested your change on my board that uses the mp3309c. All ok, thanks! ... > Subject: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() > > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: > Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This i

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA > board staging code"), there are no more users of the legacy SuperH > Mobile LCDC framebuffer driver on Renesas ARM platforms. All former > users on these platforms have been conv

Re: [PATCH 18/19] drm/i915/dp: Suspend/resume DP tunnels

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:49PM +0200, Imre Deak wrote: > Suspend and resume DP tunnels during system suspend/resume, disabling > the BW allocation mode during suspend, re-enabling it after resume. This > reflects the link's BW management component (Thunderbolt CM) disabling > BWA during suspend

dri-devel@lists.freedesktop.org

2024-01-31 Thread Maxime Ripard
On Wed, Jan 31, 2024 at 08:57:21AM +, Keith Zhao wrote: > > > +static const struct vs_dc_info dc8200_info = { > > > + .name = "DC8200", > > > + .panel_num = 2, > > > + .plane_num = 8, > > > + .planes = dc_hw_planes_rev0, > > > + .layer

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Wolfram Sang
On Wed, Jan 31, 2024 at 05:08:23PM +0100, Geert Uytterhoeven wrote: > Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA > board staging code"), there are no more users of the legacy SuperH > Mobile LCDC framebuffer driver on Renesas ARM platforms. All former > users on these

Re: [linux][PATCH v5 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:23AM +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with

Re: [PATCH 18/19] drm/i915/dp: Suspend/resume DP tunnels

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 06:18:22PM +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 12:28:49PM +0200, Imre Deak wrote: > > Suspend and resume DP tunnels during system suspend/resume, disabling > > the BW allocation mode during suspend, re-enabling it after resume. This > > reflects the link's

Re: [linux][PATCH v5 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:21AM +0530, Dharma Balasubiramani wrote: > Convert the existing DT binding to DT schema of the Atmel's HLCDC display > controller. I feel like I recall a request to only have a complete example in the mfd binding but nowhere else. Otherwise, Reviewed-by: Conor Dooley

Re: [PATCH 4/5] drm/msm/dp: Try looking for link-frequencies into the port@0's endpoint first

2024-01-31 Thread Abel Vesa
On 24-01-29 17:08:29, Dmitry Baryshkov wrote: > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > From: Abhinav Kumar > > > > On platforms where the endpoint used is on port@0, looking for port@1 > > instead results in just ignoring the max link-frequencies altogether. > > Look at port@0 fir

Re: [PATCH 4/5] drm/msm/dp: Try looking for link-frequencies into the port@0's endpoint first

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 19:04, Abel Vesa wrote: > > On 24-01-29 17:08:29, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > > > From: Abhinav Kumar > > > > > > On platforms where the endpoint used is on port@0, looking for port@1 > > > instead results in just igno

Re: [linux][PATCH v5 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:22AM +0530, Dharma Balasubiramani wrote: > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > format. > > Signed-off-by: Dharma Balasubiramani > Reviewed-by: Conor Dooley Same comment about the examples here FWIW. > +examples: > + - | > +

  1   2   >