Re: [PATCH] drm/exec, drm/gpuvm: Prefer u32 over uint32_t

2024-01-22 Thread Thomas Hellström
Hi, On 1/19/24 16:32, Jani Nikula wrote: On Fri, 19 Jan 2024, Lucas De Marchi wrote: On Fri, Jan 19, 2024 at 10:05:57AM +0100, Thomas Hellström wrote: The relatively recently introduced drm/exec utility was using uint32_t in its interface, which was then also carried over to drm/gpuvm. Prefe

[PATCH 0/3] LVDS Controller Support for SAM9X7 SoC

2024-01-22 Thread Dharma Balasubiramani
This patch series introduces LVDS controller support for the SAM9X7 SoC. The LVDS controller is designed to work with Microchip's sam9x7 series System-on-Chip (SoC) devices, providing Low Voltage Differential Signaling capabilities. Dharma Balasubiramani (3): dt-bindings: display: bridge: add sa

[PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-22 Thread Dharma Balasubiramani
Add the 'sam9x7-lvds' compatible binding, which describes the Low Voltage Differential Signaling (LVDS) Controller found on Microchip's sam9x7 series System-on-Chip (SoC) devices. This binding will be used to define the properties and configuration for the LVDS Controller in DT. Signed-off-by: Dha

[PATCH 2/3] drm/bridge: add lvds controller support for sam9x7

2024-01-22 Thread Dharma Balasubiramani
Add a new LVDS controller driver for sam9x7 which does the following: - Prepares and enables the LVDS Peripheral clock - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself to the global bridge list. - Identifies its output endpoint as panel and adds it to the encoder display pipe

[PATCH 3/3] MAINTAINERS: add SAM9X7 SoC's LVDS controller

2024-01-22 Thread Dharma Balasubiramani
Add the newly added LVDS controller for the SAM9X7 SoC to the existing MAINTAINERS entry. Signed-off-by: Dharma Balasubiramani --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a7c4cf8201e0..24a266d20df6 100644 --- a/MAINTAINERS +++ b/MAI

Re: BUG [RESEND]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-22 Thread Ma, Jun
Perhaps similar to the problem I encountered earlier, you can try the following patch https://lists.freedesktop.org/archives/amd-gfx/2024-January/103259.html Regards, Ma Jun On 1/21/2024 3:54 AM, Mirsad Todorovac wrote: > Hi, > > The last email did not pass to the most of the recipients due to

Re: [PATCH 2/8] dt-bindings: dsi-controller-main: Document missing msm8976 compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > When all dsi-ctrl compats were added msm8976 was missed, include it too. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/8] dt-bindings: msm: qcom,mdss: Include ommited fam-b compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > During conversion 28nm-hpm-fam-b compat got lost, add it. Please add Fixes tag and put this commit as first in your patchset or even as separate one. Best regards, Krzysztof

Re: [PATCH 5/8] dt-bindings: drm/msm/gpu: Document AON clock for A506/A510

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > Adreno 506(MSM8953) and Adreno 510(MSM8976) require > Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-22 Thread Conor Dooley
On Mon, Jan 22, 2024 at 03:38:41AM +, dharm...@microchip.com wrote: > Hi Conor, > On 19/01/24 5:33 pm, Conor Dooley - M52691 wrote: > > On Fri, Jan 19, 2024 at 03:32:49AM +, dharm...@microchip.com wrote: > >> On 18/01/24 9:10 pm, Conor Dooley wrote: > >>> On Thu, Jan 18, 2024 at 02:56:12PM

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-22 Thread Christian König
Am 22.01.24 um 04:32 schrieb Xianrong Zhou: The vmf_insert_pfn_prot could cause unnecessary double faults on a device pfn. Because currently the vmf_insert_pfn_prot does not make the pfn writable so the pte entry is normally read-only or dirty catching. What? How do you got to this conclusion?

Re: [PATCH v2 0/9] accel/ivpu fixes for 6.8

2024-01-22 Thread Jacek Lawrynowicz
Applied to drm-misc-fixes On 15.01.2024 14:44, Jacek Lawrynowicz wrote: > Various driver fixes: > - Fixes for infinite loops, missing locks and DMA-API debug warnings > - Deprecate DRM_IVPU_PARAM_CONTEXT_PRIORITY > - Improve diagnostic messages > > v2 includes changes from v1 review comments a

[Bug 198551] amdgpu error on shutdown or gpu intense game

2024-01-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198551 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Sat, Jan 20, 2024 at 10:26:43PM +0100, Duje Mihanović wrote: > The ExpressWire protocol is shared between at least KTD2692 and KTD2801 > with slight differences such as timings and the former not having a > defined set of pulses for enabling the protocol (possibly because it > does not support P

Re: [BUG][BISECTED] Freeze at loading init ramdisk

2024-01-22 Thread Uwe Kleine-König
On Thu, Jan 18, 2024 at 09:04:05PM +0100, Mirsad Todorovac wrote: > > > On 1/18/24 08:45, Uwe Kleine-König wrote: > > Hello Mirsad, > > > > On Wed, Jan 17, 2024 at 07:47:49PM +0100, Mirsad Todorovac wrote: > > > On 1/16/24 01:32, Mirsad Todorovac wrote: > > > > On the Ubuntu 22.04 LTS Jammy plat

Re: [PATCH v3 3/3] backlight: Add Kinetic KTD2801 backlight support

2024-01-22 Thread Daniel Thompson
On Sat, Jan 20, 2024 at 10:26:45PM +0100, Duje Mihanović wrote: > KTD2801 is a LED backlight driver IC found in samsung,coreprimevelte. > The brightness can be set using PWM or the ExpressWire protocol. Add > support for the KTD2801. > > Signed-off-by: Duje Mihanović As Linus W. said, this is loo

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-22 Thread Christian König
Am 19.01.24 um 15:13 schrieb Paul Cercueil: These functions should be used by device drivers when they start and stop accessing the data of DMABUF. It allows DMABUF importers to cache the dma_buf_attachment while ensuring that the data they want to access is available for their device when the DM

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-22 Thread Daniel Thompson
On Sun, Jan 21, 2024 at 03:48:05PM +0200, Andy Shevchenko wrote: > On Mon, Jan 15, 2024 at 09:20:46AM +0100, Javier Martinez Canillas wrote: > > Andy Shevchenko writes: > > ... > > > > +typedef int (*hx8357_init)(struct lcd_device *); > > > > This kind of typedef usage is frowned upon in the Linux

Re: [PATCH v3 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-01-22 Thread AngeloGioacchino Del Regno
Il 19/01/24 17:44, Conor Dooley ha scritto: Rob, On Fri, Jan 19, 2024 at 02:32:22PM +0800, Jason-JH.Lin wrote: Add mediatek,gce-props.yaml for common GCE properties that is used for both mailbox providers and consumers. We place the common property "mediatek,gce-events" in this binding currentl

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-22 Thread Daniel Thompson
On Sun, Jan 21, 2024 at 03:49:23PM +0200, Andy Shevchenko wrote: > On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote: > > Andy Shevchenko writes: > > ... > > > > + {} > > > > While at it, maybe add the { /* sentinel */ } convention to the last entry ? > > Maybe. Is it a comm

Re: [PATCH] drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()

2024-01-22 Thread Sascha Hauer
On Fri, Jan 19, 2024 at 11:08:40AM -0800, Harshit Mogalapalli wrote: > Unlock before returning on the error path. > > Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") > Signed-off-by: Harshit Mogalapalli Reviewed-by: Sascha Hauer Thanks for fixing this. Sascha > --- > This

Re: [PATCH v3] drm: Check output polling initialized before disabling

2024-01-22 Thread Shradha Gupta
Hi all, to me it seems like the patch has uncovered a genuine warning in drm_helper_probe_single_connector_modes() function. Before calling drm_kms_helper_poll_enable() there should be check to see if mode_config.poll_enabled is set similar to the new suspend/resume changes in the patch. Is this

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-22 Thread Paul Cercueil
Hi Christian, Le lundi 22 janvier 2024 à 11:35 +0100, Christian König a écrit : > Am 19.01.24 um 15:13 schrieb Paul Cercueil: > > These functions should be used by device drivers when they start > > and > > stop accessing the data of DMABUF. It allows DMABUF importers to > > cache > > the dma_buf_

[PATCH v2 01/47] vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta()

2024-01-22 Thread Jiri Slaby (SUSE)
Since commit 74d58cd48a8f ("USB: sisusbvga: remove console support"), vgacon_scrolldelta() is the only user of vc_scrolldelta_helper(). Inline the helper into vgacon_scrolldelta() and drop it. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.

[PATCH v2 07/47] tty: vt: pass vc_resize_user as a parameter

2024-01-22 Thread Jiri Slaby (SUSE)
It is pretty unfortunate to set vc_data::vc_resize_user in two callers of vc_do_resize(). vc_resize_user is immediately reset there (while remembering it). So instead of this back and forth, pass 'from_user' as a parameter. Notes on 'int user': * The name changes from 'user' to 'from_user' on some

[PATCH v2 00/47] tty: vt: cleanup and documentation

2024-01-22 Thread Jiri Slaby (SUSE)
Push the console code (vt.c, vt.h, console.h, ...) into a bit more maintainable state. Especially all around consw structure and document it. CSI parser is also a bit cleaned up. More to follow some time in the next round. [v2] See respective patches for changes. The major changes: * vesa.h intr

[PATCH v2 02/47] fbcon: make display_desc a static array in fbcon_startup()

2024-01-22 Thread Jiri Slaby (SUSE)
display_desc is a pointer to a RO string. Instead, switch display_desc to a static array as we are used to. It BTW saves unnecessary 8B on the stack. Signed-off-by: Jiri Slaby (SUSE) Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- driv

[PATCH v2 20/47] tty: vt: make init parameter of consw::con_init() a bool

2024-01-22 Thread Jiri Slaby (SUSE)
The 'init' parameter of consw::con_init() is true for the first call of the hook on a particular console. So make the parameter a bool. And document the hook. Signed-off-by: Jiri Slaby (SUSE) Reviewed-by: Geert Uytterhoeven Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: Daniel Vetter Cc: li

[PATCH v2 22/47] tty: vt: remove checks for count in consw::con_clear() implementations

2024-01-22 Thread Jiri Slaby (SUSE)
'count' in consw::con_clear() is guaranteed to be positive. csi_X() (the only caller) takes the minimum of the vc parameter (which is at least 1) and count of characters till the end of the line. The latter is computed as a subtraction of vc->vc_cols (count) and vc->state.x (offset). So for the wor

[PATCH v2 28/47] fbdev/core: simplify cursor_state setting in fbcon_ops::cursor()

2024-01-22 Thread Jiri Slaby (SUSE)
There is a switch decicing if cursor should be drawn or not. The whole switch can be simplified to one line. Do this cleanup as a preparatory work for the next patch. There, all the CM_* constants are removed. Signed-off-by: Jiri Slaby (SUSE) Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@v

[PATCH v2 29/47] tty: vt: remove CM_* constants

2024-01-22 Thread Jiri Slaby (SUSE)
There is no difference between CM_MOVE and CM_DRAW. Either of them enables the cursor. CM_ERASE then disables cursor. So get rid of all of them and use simple "bool enable". Note that this propagates down to the fbcon code. And document the hook. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Dell

[PATCH v2 19/47] tty: vt: make consw::con_debug_*() return void

2024-01-22 Thread Jiri Slaby (SUSE)
The return value of con_debug_enter() and con_debug_leave() is ignored on many fronts. So just don't propagate errors (the current implementations return 0 anyway) and make the return type a void. Signed-off-by: Jiri Slaby (SUSE) Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.or

[PATCH v2 31/47] tty: vt: stop using -1 for blank mode in consw::con_blank()

2024-01-22 Thread Jiri Slaby (SUSE)
-1 is the same as VESA_VSYNC_SUSPEND in all con_blank() implementations. So we can remove this special case from vgacon now too. Despite con_blank() of fbcon looks complicated, the "if (!fbcon_is_inactive(vc, info))" branch is not taken as we set "ops->graphics = 1;" few lines above. So what matte

[PATCH v2 21/47] tty: vt: sanitize arguments of consw::con_clear()

2024-01-22 Thread Jiri Slaby (SUSE)
In consw::con_clear(): * Height is always 1, so drop it. * Offsets and width are always unsigned values, so re-type them as such. This needs a new __fbcon_clear() in the fbcon code to still handle height which might not be 1 when called internally. Note that tests for negative count/width are lef

[PATCH v2 33/47] tty: vt: use VESA blanking constants

2024-01-22 Thread Jiri Slaby (SUSE)
There are VESA blanking constants defined in vesa.h. So use them in the console code instead of constant values. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-par...@vger.kernel.org ---

[PATCH v2 32/47] tty: vt: define a common enum for VESA blanking constants

2024-01-22 Thread Jiri Slaby (SUSE)
There are currently two places with VESA blanking constants definitions: fb.h and console.h. Extract/unify the two to a separate header (vesa.h). Given the fb's is in an uapi header, create the common header in uapi too. Note that instead of macros, an enum (vesa_blank_mode) is created. But the m

[PATCH v2 24/47] tty: vt: eliminate unneeded consw::con_putc() implementations

2024-01-22 Thread Jiri Slaby (SUSE)
All these consw::con_putc() implementations do the same as consw::con_putcs() (only for one charattr) or even call consw::con_putcs() on their own. Drop them, as thanks to the new con_putc() helper in the previous patch, the console code performs this already -- exactly if consw::con_putc() is mis

[PATCH v2 38/47] tty: vt: change consw::con_set_origin() return type

2024-01-22 Thread Jiri Slaby (SUSE)
The return value of consw::con_set_origin() is only true/false, meaining if vc->vc_origin is set to vc->vc_screenbuf or not. So switch the type and returned values accordingly. And document the hook. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-deve

[PATCH v2 27/47] consoles: use if instead of switch-case in consw::con_cursor()

2024-01-22 Thread Jiri Slaby (SUSE)
This is only a preparation for the following cleanup patch to make it easier. Provided CM_ERASE is the only different, use 'if' instead of 'switch+case' in all those. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- driver

[PATCH v2 37/47] tty: vt: make consw::con_font_default()'s name const

2024-01-22 Thread Jiri Slaby (SUSE)
It's a name after all and that is not supposed to be changed. So make it const to make this obvious. Signed-off-by: Jiri Slaby (SUSE) Cc: "James E.J. Bottomley" Cc: Daniel Vetter Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-par...@vger.kernel.org --- drivers/vi

[PATCH v2 30/47] tty: vt: make consw::con_switch() return a bool

2024-01-22 Thread Jiri Slaby (SUSE)
The non-zero (true) return value from consw::con_switch() means a redraw is needed. So make this return type a bool explicitly instead of int. The latter might imply that -Eerrors are expected. They are not. And document the hook. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J

[PATCH v2 25/47] tty: vt: sanitize consw::con_putc() parameters

2024-01-22 Thread Jiri Slaby (SUSE)
Make parameters of consw::con_putc() saner: * x and y are unsigned now, as they cannot be negative, and * ca is made u16, as it is composed of two 8bit values (character and attribute). See the con_putcs() hook, u16/ushort is worked on there. And document the hook. Signed-off-by: Jiri Slaby (SU

[PATCH v2 34/47] tty: vt: use enum constants for VESA blanking modes

2024-01-22 Thread Jiri Slaby (SUSE)
Use the new enum for VESA constants. This improves type checking in consw::con_blank(). Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: Daniel Vetter Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-par...@vger.kernel.org --- Notes

[PATCH v2 35/47] tty: vt: make types around consw::con_blank() bool

2024-01-22 Thread Jiri Slaby (SUSE)
Both the mode_switch parameter and the return value (a redraw needed) are true/false. So switch them to bool, so that users won't return -Eerrors or anything else. And document the hook. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: Daniel Vetter Cc: linux-f

[PATCH v2 36/47] tty: vt: make font of consw::con_font_set() const

2024-01-22 Thread Jiri Slaby (SUSE)
Provided the font parameter of consw::con_font_set() is not supposed to be changed, make it const. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: Daniel Vetter Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-par...@vger.kernel.org

[PATCH v2 39/47] fbcon: remove consw::con_screen_pos()

2024-01-22 Thread Jiri Slaby (SUSE)
fbcon_screen_pos() performs the same as the default implementation. The only difference in the default implementation is that is considers both vc->vc_origin and vc->vc_visible_origin. But given fbcon's softscroll code was already removed in commit 50145474f6ef (fbcon: remove soft scrollback code),

[PATCH v2 42/47] fbcon: remove fbcon_getxy()

2024-01-22 Thread Jiri Slaby (SUSE)
Again, fbcon_getxy() is the same as the default implementation since the softscroll removal in commit 50145474f6ef (fbcon: remove soft scrollback code). Drop that. Signed-off-by: Jiri Slaby (SUSE) Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop

Re: [Linaro-mm-sig] Re: [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec()

2024-01-22 Thread Vinod Koul
Hi Paul, On 08-01-24, 13:20, Paul Cercueil wrote: > Hi Vinod, > > Le jeudi 21 décembre 2023 à 20:44 +0530, Vinod Koul a écrit : > > On 19-12-23, 18:50, Paul Cercueil wrote: > > > This function can be used to initiate a scatter-gather DMA > > > transfer, > > > where the address and size of each s

Re: (subset) [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

2024-01-22 Thread Krzysztof Kozlowski
On Fri, 05 Jan 2024 07:53:01 +0100, Artur Weber wrote: > After more investigation, I've found that it's not the panel driver > config that needs to be modified to invert the data polarity, but > the FIMD config. > > Add the missing invert-vclk option that is required to get the display > to work

[PATCH v3] drm/stm: Avoid use-after-free issues with crtc and plane

2024-01-22 Thread Katya Orlova
ltdc_load() calls functions drm_crtc_init_with_planes(), drm_universal_plane_init() and drm_encoder_init(). These functions should not be called with parameters allocated with devm_kzalloc() to avoid use-after-free issues [1]. Use allocations managed by the DRM framework. Found by Linux Verificat

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-22 Thread Luca Weiss
On Fri Jan 12, 2024 at 11:26 AM CET, wrote: > On 12/01/2024 11:23, Linus Walleij wrote: > > On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss > > wrote: > > > >> Since there's zero indication Truly is involved in this panel in my > >> documentation - much less the number 5P65 - I'm not going to add t

[PATCH v3 0/2] Small runtime PM API changes

2024-01-22 Thread Sakari Ailus
Hi folks, Here's a small but a different set of patches for making two relatively minor changes to runtime PM API. I restarted version numbering as this is meaningfully different from the previous set. pm_runtime_get_if_active() loses its second argument as it only made sense to have ign_usage_co

[PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
There are two ways to opportunistically increment a device's runtime PM usage count, calling either pm_runtime_get_if_active() or pm_runtime_get_if_in_use(). The former has an argument to tell whether to ignore the usage count or not, and the latter simply calls the former with ign_usage_count set

[PATCH 1/3] accel/ivpu: Fix dev open/close races with unbind

2024-01-22 Thread Jacek Lawrynowicz
- Add context_list_lock to synchronize user context addition/removal - Use drm_dev_enter() to prevent unbinding the device during ivpu_open() and vpu address allocation Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 110 +- drivers/ac

[PATCH 0/3] accel/ivpu fixes for 6.8-rc1

2024-01-22 Thread Jacek Lawrynowicz
Stability fixes for reset, recovery and unbind. Jacek Lawrynowicz (3): accel/ivpu: Fix dev open/close races with unbind accel/ivpu: Improve stability of ivpu_submit_ioctl() accel/ivpu: Improve recovery and reset support drivers/accel/ivpu/ivpu_debugfs.c | 20 +++- drivers/accel/ivpu/ivpu_

[PATCH 3/3] accel/ivpu: Improve recovery and reset support

2024-01-22 Thread Jacek Lawrynowicz
- Synchronize job submission with reset/recovery using reset_lock - Always print recovery reason and call diagnose_failure() - Don't allow for autosupend during recovery - Prevent immediate autosuspend after reset/recovery - Prevent force_recovery for issuing TDR when device is suspended

[PATCH 2/3] accel/ivpu: Improve stability of ivpu_submit_ioctl()

2024-01-22 Thread Jacek Lawrynowicz
- Wake up the device as late as possible - Remove job reference counting in order to simplify the code - Don't put jobs that are not fully submitted on submitted_jobs_xa in order to avoid potential races with reset/recovery Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_job.c | 1

Re: [PATCH v2] accel/ivpu: Disable PLL after VPU IP reset during FLR

2024-01-22 Thread Jacek Lawrynowicz
Applied to drm-misc-fixes On 24.10.2023 18:53, Stanislaw Gruszka wrote: > From: Jacek Lawrynowicz > > IP reset has to followed by ivpu_pll_disable() to properly enter > reset state. > > Fixes: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR") > Cc: sta...@vger.kernel.org > Signed-off-by:

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-22 Thread Christian König
Am 22.01.24 um 12:01 schrieb Paul Cercueil: Hi Christian, Le lundi 22 janvier 2024 à 11:35 +0100, Christian König a écrit : Am 19.01.24 um 15:13 schrieb Paul Cercueil: These functions should be used by device drivers when they start and stop accessing the data of DMABUF. It allows DMABUF impor

[PATCH v4 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-22 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GPU tile believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.

[PATCH v4 2/3] Manually revert "drm/i915: Fix a VMA UAF for multi-gt platform"

2024-01-22 Thread Janusz Krzysztofik
This reverts changes introduced by commit f56fe3e91787, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v4 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-01-22 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/

[PATCH AUTOSEL 6.7 04/88] drm: Fix color LUT rounding

2024-01-22 Thread Sasha Levin
From: Ville Syrjälä [ Upstream commit c6fbb6bca10838485b820e8a26c23996f77ce580 ] The current implementation of drm_color_lut_extract() generates weird results. Eg. if we go through all the values for 16->8bpc conversion we see the following pattern: inout (count) 0 - 7f -> 0 (

[PATCH AUTOSEL 6.7 08/88] drm/msm/a690: Fix reg values for a690

2024-01-22 Thread Sasha Levin
From: Danylo Piliaiev [ Upstream commit 07e6de738aa6f0e873463e9ca88bdb7081c4bfd4 ] KGSL doesn't support a690 so all reg values were the same as on a660. Now we know the values and they are different from the windows driver. This fixes hangs on D3D12 games and some CTS tests. Signed-off-by: Dan

[PATCH AUTOSEL 6.7 12/88] drm/bridge: anx7625: Fix Set HPD irq detect window to 2ms

2024-01-22 Thread Sasha Levin
From: Xin Ji [ Upstream commit e3af7053de3f685c96158373bc234b2feca1f160 ] Polling firmware HPD GPIO status, set HPD irq detect window to 2ms after firmware HPD GPIO initial done Signed-off-by: Xin Ji Reviewed-by: Robert Foss Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org

[PATCH AUTOSEL 6.7 11/88] drm/panel-edp: Add override_edid_mode quirk for generic edp

2024-01-22 Thread Sasha Levin
From: Hsin-Yi Wang [ Upstream commit 9f7843b515811aea6c56527eb195b622e9c01f12 ] Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Si

[PATCH AUTOSEL 6.7 13/88] drm/amd/display: Fix tiled display misalignment

2024-01-22 Thread Sasha Levin
From: Meenakshikumar Somasundaram [ Upstream commit c4b8394e76adba4f50a3c2696c75b214a291e24a ] [Why] When otg workaround is applied during clock update, otgs of tiled display went out of sync. [How] To call dc_trigger_sync() after clock update to sync otgs again. Reviewed-by: Nicholas Kazlausk

[PATCH AUTOSEL 6.7 18/88] drm/amd/display: Fix MST PBN/X.Y value calculations

2024-01-22 Thread Sasha Levin
From: Ilya Bakoulin [ Upstream commit 94bbf802efd0a8f13147d6664af6e653637340a8 ] Changing PBN calculation to be more in line with spec. We don't need to inflate PBN_NATIVE value by the 1.006 margin, since that is already taken care of in the get_pbn_per_slot function. Tested-by: Daniel Wheeler

[PATCH AUTOSEL 6.7 19/88] drm/amd/display: Fix disable_otg_wa logic

2024-01-22 Thread Sasha Levin
From: Nicholas Susanto [ Upstream commit 2ce156482a6fef349d2eba98e5070c412d3af662 ] [Why] When switching to another HDMI mode, we are unnecesarilly disabling/enabling FIFO causing both HPO and DIG registers to be set at the same time when only HPO is supposed to be set. This can lead to a syste

[PATCH AUTOSEL 6.7 20/88] drm/amd/display: Fix Replay Desync Error IRQ handler

2024-01-22 Thread Sasha Levin
From: Dennis Chan [ Upstream commit dd5c6362ddcd8bdb07704faff8648593885ecfa1 ] In previous case, Replay didn't identify the IRQ type, This commit fixes the issues for the interrupt. Tested-by: Daniel Wheeler Reviewed-by: Robin Chen Acked-by: Rodrigo Siqueira Signed-off-by: Dennis Chan Signe

[PATCH AUTOSEL 6.7 17/88] drm/amd/display: initialize all the dpm level's stutter latency

2024-01-22 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 885c71ad791c1709f668a37f701d33e6872a902f ] Fix issue when override level bigger than default. Levels 5, 6, and 7 had zero stutter latency, this is because override level being initialized after stutter latency inits. Tested-by: Daniel Wheeler Reviewed-by: S

[PATCH AUTOSEL 6.7 21/88] drm/amd/display: add support for DTO genarated dscclk

2024-01-22 Thread Sasha Levin
From: Wenjing Liu [ Upstream commit 08a32addf17317b9fac55be9b31275cbf6e41fb7 ] Current implementation will choose to use refclk as dscclk. This is not recommended by hardware team as refclk is a fixed value which could cause unnecessary power consumption or it could be not enough for large DSC t

[PATCH AUTOSEL 6.7 22/88] drm/amd/display: Fix writeback_info never got updated

2024-01-22 Thread Sasha Levin
From: Alex Hung [ Upstream commit c09919e6ea5fefd49d8b7b54aa5b222937163108 ] [WHY] wb_enabled field is set to false before it is used, and the following code will never be executed. [HOW] Setting wb_enable to false after all removal work is completed. Tested-by: Daniel Wheeler Reviewed-by: Ha

[PATCH AUTOSEL 6.7 24/88] drm/drm_file: fix use of uninitialized variable

2024-01-22 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit 1d3062fad9c7313fff9970a88e0538a24480ffb8 ] smatch reports: drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'. 'supported_status' is only set in one code path. I'm not familiar with the code to say if th

[PATCH AUTOSEL 6.7 25/88] drm/framebuffer: Fix use of uninitialized variable

2024-01-22 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit f9af8f0c1dc567a5a6a6318ff324c45d80d4a60f ] smatch reports: drivers/gpu/drm/drm_framebuffer.c:654 drm_mode_getfb2_ioctl() error: uninitialized symbol 'ret'. 'ret' is possibly not set when there are no errors, causing the error above. I can't say if that e

[PATCH AUTOSEL 6.7 23/88] drm/amd/display: Fix writeback_info is not removed

2024-01-22 Thread Sasha Levin
From: Alex Hung [ Upstream commit ab37b88ed9de9de8d582683f7ea17059f1251a7f ] [WHY] Counter j was not updated to present the num of writeback_info when writeback pipes are removed. [HOW] update j (num of writeback info) under the correct condition. Tested-by: Daniel Wheeler Reviewed-by: Harry

[PATCH AUTOSEL 6.7 26/88] drm/mipi-dsi: Fix detach call without attach

2024-01-22 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit 90d50b8d85834e73536fdccd5aa913b30494fef0 ] It's been reported that DSI host driver's detach can be called without the attach ever happening: https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ After reading the code, I think this is what

[PATCH AUTOSEL 6.7 32/88] drm/msm/dp: Add DisplayPort controller for SM8650

2024-01-22 Thread Sasha Levin
From: Neil Armstrong [ Upstream commit 1b2d98bdd7b7c64265732f5f0dace4c52c9ba8a8 ] The Qualcomm SM8650 platform comes with a DisplayPort controller with a different base offset than the previous SM8550 SoC, add support for this in the DisplayPort driver. Signed-off-by: Neil Armstrong Reviewed-b

[PATCH AUTOSEL 6.7 50/88] drm/amd/display: For prefetch mode > 0, extend prefetch if possible

2024-01-22 Thread Sasha Levin
From: Alvin Lee [ Upstream commit dd4e4bb28843393065eed279e869fac248d03f0f ] [Description] For mode programming we want to extend the prefetch as much as possible (up to oto, or as long as we can for equ) if we're not already applying the 60us prefetch requirement. This is to avoid intermittent

[PATCH AUTOSEL 6.7 44/88] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2024-01-22 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit 16ac5b21b31b439f03cdf44c153c5f5af94fb3eb ] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time and at driver unbind time. Among other things, this means that if a panel

[PATCH AUTOSEL 6.7 52/88] drm/amdkfd: fix mes set shader debugger process management

2024-01-22 Thread Sasha Levin
From: Jonathan Kim [ Upstream commit bd33bb1409b494558a2935f7bbc7842def957fcd ] MES provides the driver a call to explicitly flush stale process memory within the MES to avoid a race condition that results in a fatal memory violation. When SET_SHADER_DEBUGGER is called, the driver passes a memo

[PATCH AUTOSEL 6.7 54/88] drm/msm/dpu: enable writeback on SM8450

2024-01-22 Thread Sasha Levin
From: Dmitry Baryshkov [ Upstream commit eaa647cdbf2e357b4a14903f2f1e47ed9c4f8df3 ] Enable WB2 hardware block, enabling writeback support on this platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Patchwork: https://patchwork.freedesktop.org/patch/570187/ Link: https://lore

[PATCH AUTOSEL 6.7 56/88] drm/msm/dpu: fix writeback programming for YUV cases

2024-01-22 Thread Sasha Levin
From: Abhinav Kumar [ Upstream commit 79caf2f2202b9eaad3a5a726e4b33807f67d0f1b ] For YUV cases, setting the required format bits was missed out in the register programming. Lets fix it now in preparation of adding YUV formats support for writeback. changes in v2: - dropped the fixes tag as

[PATCH AUTOSEL 6.7 51/88] drm/amd/display: Force p-state disallow if leaving no plane config

2024-01-22 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 9a902a9073c287353e25913c0761bfed49d75a88 ] [Description] - When we're in a no plane config, DCN is always asserting P-State allow - This creates a scenario where the P-State blackout can start just as VUPDATE takes place and transitions the DCN config to a

[PATCH AUTOSEL 6.7 53/88] drm/msm/dpu: enable writeback on SM8350

2024-01-22 Thread Sasha Levin
From: Dmitry Baryshkov [ Upstream commit c2949a49dfe960e952400029e14751dceff79d38 ] Enable WB2 hardware block, enabling writeback support on this platform. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Patchwork: https://patchwork.freedesktop.org/patch/570188/ Link: https://lore

[PATCH AUTOSEL 6.7 55/88] drm/msm/dpu: Ratelimit framedone timeout msgs

2024-01-22 Thread Sasha Levin
From: Rob Clark [ Upstream commit 2b72e50c62de60ad2d6bcd86aa38d4ccbdd633f2 ] When we start getting these, we get a *lot*. So ratelimit it to not flood dmesg. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten Patchwork: https://patchwork.freedesktop.org/patch/57

[PATCH AUTOSEL 6.7 63/88] accel/habanalabs: add support for Gaudi2C device

2024-01-22 Thread Sasha Levin
From: Oded Gabbay [ Upstream commit 42422993cf28d456778ee9168d73758ec037cd51 ] Gaudi2 with PCI revision ID with the value of '3' represents Gaudi2C device and should be detected and initialized as Gaudi2. Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin --- drivers/accel/habanalabs/comm

[PATCH AUTOSEL 6.7 57/88] drm/msm/dpu: Add mutex lock in control vblank irq

2024-01-22 Thread Sasha Levin
From: Paloma Arellano [ Upstream commit 45284ff733e4caf6c118aae5131eb7e7cf3eea5a ] Add a mutex lock to control vblank irq to synchronize vblank enable/disable operations happening from different threads to prevent race conditions while registering/unregistering the vblank irq callback. v4: -Rem

[PATCH AUTOSEL 6.7 67/88] drm/amd/display: fix usb-c connector_type

2024-01-22 Thread Sasha Levin
From: Allen Pan [ Upstream commit 0d26644bc57d8737c8e2fb3145366f7d0b941935 ] [why] BIOS switches to use USB-C connector type 0x18, but VBIOS's objectInfo table not supported yet. driver needs to patch it based on enc_cap from system integration info table. Reviewed-by: Charlene Liu Acked-by: W

[PATCH AUTOSEL 6.7 58/88] drm/amdgpu: fix ftrace event amdgpu_bo_move always move on same heap

2024-01-22 Thread Sasha Levin
From: "Wang, Beyond" [ Upstream commit 94aeb4117343d072e3a35b9595bcbfc0058ee724 ] Issue: during evict or validate happened on amdgpu_bo, the 'from' and 'to' is always same in ftrace event of amdgpu_bo_move where calling the 'trace_amdgpu_bo_move', the comment says move_notify is called before m

[PATCH AUTOSEL 6.7 68/88] drm/amd/display: Fix lightup regression with DP2 single display configs

2024-01-22 Thread Sasha Levin
From: Michael Strauss [ Upstream commit 5a82b8d6c05f9b30828ede1b103b9ee5cb5c912e ] [WHY] Previous fix for multiple displays downstream of DP2 MST hub caused regression [HOW] Match sink IDs instead of sink struct addresses Reviewed-by: Nicholas Kazlauskas Reviewed-by: Charlene Liu Acked-by: W

[PATCH AUTOSEL 6.7 64/88] accel/habanalabs: fix EQ heartbeat mechanism

2024-01-22 Thread Sasha Levin
From: Farah Kassabri [ Upstream commit d1958dce5ab6a3e089c60cf474e8c9b7e96e70ad ] Stop rescheduling another heartbeat check when EQ heartbeat check fails as it generates confusing logs in dmesg that the heartbeat fails. Signed-off-by: Farah Kassabri Reviewed-by: Oded Gabbay Signed-off-by: Ode

[PATCH AUTOSEL 6.7 65/88] accel/habanalabs/gaudi2: fix undef opcode reporting

2024-01-22 Thread Sasha Levin
From: Dafna Hirschfeld [ Upstream commit 0ec346779644039c4c05cfa7f071b1a24e54d8d9 ] currently the undefined opcode event bit in set only for lower cp and only if 'write_enable' is true. It should be set anyway and for all streams in order to report that event to userspace. Signed-off-by: Dafna

[PATCH AUTOSEL 6.7 66/88] drm/amd/display: make flip_timestamp_in_us a 64-bit variable

2024-01-22 Thread Sasha Levin
From: Josip Pavic [ Upstream commit 6fb12518ca58412dc51054e2a7400afb41328d85 ] [Why] This variable currently overflows after about 71 minutes. This doesn't cause any known functional issues but it does make debugging more difficult. [How] Make it a 64-bit variable. Reviewed-by: Aric Cyr Acked

[PATCH AUTOSEL 6.7 75/88] drm/amdgpu: Let KFD sync with VM fences

2024-01-22 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit ec9ba4821fa52b5efdbc4cdf0a77497990655231 ] Change the rules for amdgpu_sync_resv to let KFD synchronize with VM fences on page table reservations. This fixes intermittent memory corruption after evictions when using amdgpu_vm_handle_moved to update page tab

[PATCH AUTOSEL 6.7 76/88] drm/amd/display: Fixing stream allocation regression

2024-01-22 Thread Sasha Levin
From: Relja Vojvodic [ Upstream commit 292c2116b2ae84c7e799ae340981e60551b18f5e ] For certain dual display configs that had one display using a 1080p mode, the DPM level used to drive the configs regressed from DPM 0 to DPM 3. This was caused by a missing check that should have only limited the

[PATCH AUTOSEL 6.7 74/88] drm/amd/display: Fix minor issues in BW Allocation Phase2

2024-01-22 Thread Sasha Levin
From: Meenakshikumar Somasundaram [ Upstream commit aa5dc05340eb97486a631ce6bccb8d020bf6b56b ] [Why] Fix minor issues in BW Allocation Phase2. [How] - In set_usb4_req_bw_req(), link->dpia_bw_alloc_config.response_ready flag should be reset before writing DPCD REQUEST_BW. - Fix the granularity

[PATCH AUTOSEL 6.7 69/88] drm/amd/display: Only clear symclk otg flag for HDMI

2024-01-22 Thread Sasha Levin
From: Alvin Lee [ Upstream commit dff45f03f508c92cd8eb2050e27b726726b8ae0b ] [Description] There is a corner case where the symclk otg flag is cleared when disabling the phantom pipe for subvp (because the phantom and main pipe share the same link). This is undesired because we need the maintain

[PATCH AUTOSEL 6.7 77/88] Re-revert "drm/amd/display: Enable Replay for static screen use cases"

2024-01-22 Thread Sasha Levin
From: Ivan Lipski [ Upstream commit d6398866a6b47e92319ef6efdb0126a4fbb7796a ] This reverts commit 44e60b14d5a72f91fd0bdeae8da59ae37a3ca8e5. Since, it causes a regression in which eDP displays with PSR support, but no Replay support (Sink support <= 0x03), fail to enable PSR and consequently al

[PATCH AUTOSEL 6.7 78/88] drm/amdgpu: Fix possible NULL dereference in amdgpu_ras_query_error_status_helper()

2024-01-22 Thread Sasha Levin
From: Srinivasan Shanmugam [ Upstream commit b8d55a90fd55b767c25687747e2b24abd1ef8680 ] Return invalid error code -EINVAL for invalid block id. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1183 amdgpu_ras_query_error_status_helper() error: we previously assumed 'info' could be nu

  1   2   3   4   >