Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: Hello Andy, > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Include mod_devicetable.h explicitly to replace the dropped of.h > which included mod_devicetable.h indirectly. > > Signed-off-by: Andy Shevchenko > --- >

Re: [PATCH] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-01-15 Thread Thomas Zimmermann
Hi Am 12.01.24 um 21:38 schrieb Ian Forbes: SVGA requires surfaces to fit within graphics memory (max_mob_pages) which means that modes with a final buffer size that would exceed graphics memory must be pruned otherwise creation will fail. Additionally, device commands which use multiple graphi

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: > Move OF table near to the user. > > While at it, drop comma at terminator entry. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/hx8357.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/vi

Re: [PATCH v1 3/4] backlight: hx8357: Make use of dev_err_probe()

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: > Simplify the error handling in probe function by switching from > dev_err() to dev_err_probe(). > > Signed-off-by: Andy Shevchenko > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread Maxime Ripard
Hi, On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote: > > Am 08.01.2024 um 19:32 schrieb Andrew Davis : > > > > Add SGX GPU device entry to base OMAP4 dtsi file. > > > > Signed-off-by: Andrew Davis > > --- > > arch/arm/boot/dts/ti/omap/omap4.dtsi | 9 + > > 1 file cha

Re: [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: > We have a temporary variable to keep pointer to struct device. > Utilise it inside the ->probe() implementation. > > Signed-off-by: Andy Shevchenko > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 0/4] Fixing live video input in ZynqMP DPSUB

2024-01-15 Thread Maxime Ripard
On Fri, Jan 12, 2024 at 03:42:18PM -0800, Anatoliy Klymenko wrote: > Patches 1/4,2/4,3/4 are minor fixes. > > DPSUB requires input live video format to be configured. > Patch 4/4: The DP Subsystem requires the input live video format to be > configured. In this patch we are assuming that the CRTC'

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-01-15 Thread Neil Armstrong
Hi Luca, On 11/01/2024 13:38, Luca Weiss wrote: Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding bridge/panel.o to drm_kms_helper object, we need to select DRM_KMS_HELPER to make sure the file is actually getting built. Otherwise with certain defconfigs e.g. devm_drm_of_get_bridge wi

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: fix deferred dsi host probe breaks dsi device probe

2024-01-15 Thread neil . armstrong
Hi, On 12/01/2024 19:07, Farouk Bouabid wrote: dw-mipi-dsi based drivers such as dw-mipi-dsi-rockchip or dw_mipi_dsi-stm depend on dw_mipi_dsi_probe() to initialize the dw_mipi_dsi driver structure (dmd pointer). This structure is only initialized once dw_mipi_dsi_probe() returns, creating the l

Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

2024-01-15 Thread Neil Armstrong
Hi, On Fri, 12 Jan 2024 22:00:47 +0800, Jianhua Lu wrote: > After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock > limits") > merged, 120Hz is working on xiaomi,elish panels, so feature it. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-m

Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread H. Nikolaus Schaller
Hi, > Am 15.01.2024 um 09:25 schrieb Maxime Ripard : > > Hi, > > On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote: >>> Am 08.01.2024 um 19:32 schrieb Andrew Davis : >>> >>> Add SGX GPU device entry to base OMAP4 dtsi file. >>> >>> Signed-off-by: Andrew Davis >>> --- >>> ar

Flaky tests for msm sdm845

2024-01-15 Thread Vignesh Raman
Hi Maintainers, There are some flaky tests reported for sdm845 msm driver testing in drm-ci with commit https://patchwork.kernel.org/project/linux-arm-msm/patch/20240108195016.156583-1-robdcl...@gmail.com/ === msm:sdm845 === # Board Name: msm:sdm845 # Failure Rate: 50 # IGT Version: 1.28-gd2a

[PATCH] drm/rockchip: inno_hdmi: Explicitly include drm_atomic.h

2024-01-15 Thread Alex Bee
Commit d3e040f450ec ("drm/rockchip: inno_hdmi: Get rid of mode_set") started using drm_atomic_get_new_connector_state and drm_atomic_get_new_crtc_state which are defined in drm_atomic.h Building does currently only work if CONFIG_OF and CONFIG_DRM_PANEL_BRIDGE are enabled since this will include dr

Re: [DO NOT MERGE v6 21/37] dt-bindings: serial: renesas, scif: Add scif-sh7751.

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [DO NOT MERGE v6 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema

2024-01-15 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Thanks for your patch! > --- > .../bindings/display/smi,sm501.yaml | 417 ++ > 1 file changed, 417 insertions(+) > create mode 100644 Documentation/devicetree/bindings/

Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread Andreas Kemnade
Hi, On Mon, 15 Jan 2024 09:55:00 +0100 "H. Nikolaus Schaller" wrote: > > There's no reason to disable it in the DT: the hardware block would > > still be there and it's rendering to memory so it still could be useful. > > Well, if you know that the board does not have a dm3730 but a dm3725 w

Re: [PATCH] drm/ttm: fix ttm pool initialization for no-dma-device drivers

2024-01-15 Thread Christian König
Am 13.01.24 um 22:33 schrieb Fedor Pchelkin: QXL driver doesn't use any device for DMA mappings or allocations so dev_to_node() will panic inside ttm_device_init() on NUMA systems: general protection fault, probably for non-canonical address 0xdc7a: [#1] PREEMPT SMP KASAN NOPTI

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: fix deferred dsi host probe breaks dsi device probe

2024-01-15 Thread Heiko Stübner
Am Montag, 15. Januar 2024, 09:45:10 CET schrieb neil.armstr...@linaro.org: > Hi, > > On 12/01/2024 19:07, Farouk Bouabid wrote: > > dw-mipi-dsi based drivers such as dw-mipi-dsi-rockchip or dw_mipi_dsi-stm > > depend on dw_mipi_dsi_probe() to initialize the dw_mipi_dsi driver > > structure (dmd p

[PATCH 0/3] video: Simplify Kconfig options

2024-01-15 Thread Thomas Zimmermann
Replace CONFIG_VIDEO_CMDLINE and CONFIG_VIDEO_NOMODESET by the single option CONFIG_VIDEO. Select the latter for DRM or fbdev. Both original options used to be selected in most cases, so this change simplifies the Kconfig rules. Since commit ca6c080eef42 ("arch/parisc: Detect primary video device

[PATCH 1/3] video/cmdline: Introduce CONFIG_VIDEO for video= parameter

2024-01-15 Thread Thomas Zimmermann
Add CONFIG_VIDEO for common code in drivers/video/. Use the option to select helpers for the video= parameter. Replaces CONFIG_VIDEO_CMDLINE. Other common code in drivers/video/ can be moved behind CONFIG_VIDEO, which will simplify the Kconfig rules. Signed-off-by: Thomas Zimmermann --- drivers

[PATCH 2/3] video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE

2024-01-15 Thread Thomas Zimmermann
The function __video_get_options() only exists for compatibility with old fbdev drivers that cannot be refactored easily. Hide it behind CONFIG_FB_CORE. Signed-off-by: Thomas Zimmermann --- drivers/video/cmdline.c | 2 ++ include/video/cmdline.h | 2 ++ 2 files changed, 4 insertions(+) diff --g

[PATCH 3/3] video/nomodeset: Select nomodeset= parameter with CONFIG_VIDEO

2024-01-15 Thread Thomas Zimmermann
Enable support for nomodeset= parameter via CONFIG_VIDEO. Both, DRM and fbdev, already select this option. Remove the existing option CONFIG_VIDEO_NOMODESET. Simplifies the Kconfig rules. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 1 - drivers/staging/sm750fb/Kconf

Re: Failed to create a rescuer kthread for the amdgpu-reset-dev workqueue

2024-01-15 Thread Thomas Perrot
Hello Christian, On Fri, 2024-01-12 at 09:17 +0100, Christian König wrote: > Well the driver load is interrupted for some reason. > > Have you set any timeout for modprobe? > We don't set a modprobe timeout. Kind regards, Thomas > Regards, > Christian. > > Am 12.01.24 um 09:11 schrieb Thomas

Re: [PATCH] drm/amdgpu: Remove usage of the deprecated ida_simple_xx() API

2024-01-15 Thread Christian König
Am 14.01.24 um 16:14 schrieb Christophe JAILLET: ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range() is inclusive. So a -1 has been added when neede

[PATCH v1] drm/ci: Update xfails for newly added msm tests

2024-01-15 Thread Vignesh Raman
msm tests are added to testlist.txt, so update the xfails for jobs in msm stage. Signed-off-by: Vignesh Raman --- Depends on https://patchwork.kernel.org/project/linux-arm-msm/patch/20240108195016.156583-1-robdcl...@gmail.com/ --- .../gpu/drm/ci/xfails/msm-apq8016-fails.txt | 3 +- .../g

Re: Failed to create a rescuer kthread for the amdgpu-reset-dev workqueue

2024-01-15 Thread Christian König
Am 15.01.24 um 11:17 schrieb Thomas Perrot: Hello Christian, On Fri, 2024-01-12 at 09:17 +0100, Christian König wrote: Well the driver load is interrupted for some reason. Have you set any timeout for modprobe? We don't set a modprobe timeout. Well you somehow abort probing the driver. Th

Re: [PATCH] drm/ci: Add msm tests

2024-01-15 Thread Vignesh Raman
Hi Rob, On 12/01/24 22:44, Rob Clark wrote: On Fri, Jan 12, 2024 at 7:57 AM Rob Clark wrote: On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman wrote: Hi Rob, On 09/01/24 01:20, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable

Re: [PATCH v3 05/14] drm/panthor: Add GEM logical block

2024-01-15 Thread Boris Brezillon
On Thu, 7 Dec 2023 16:38:33 + Steven Price wrote: > > + > > + ret = panthor_vm_unmap_range(vm, bo->va_node.start, > > +panthor_kernel_bo_size(bo)); > > + if (ret) > > + goto out_free_bo; > > + > > + panthor_vm_free_va(vm, &bo->va_node); > > +

[RESEND PATCH v9 0/2] Add displays support for bsh-smm-s2/pro boards

2024-01-15 Thread Dario Binacchi
The series adds drivers for the displays used by bsh-smm-s2/pro boards. The patches for the ili9805 and r63353 LCD panels, which have already been merged into the mainline, do not work without the patch [1/2] "drm: bridge: samsung-dsim: enter display mode in the enable() callback". Changes in v9:

[RESEND PATCH v9 1/2] drm: bridge: samsung-dsim: enter display mode in the enable() callback

2024-01-15 Thread Dario Binacchi
The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the

[RESEND PATCH v9 2/2] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2024-01-15 Thread Dario Binacchi
The patch completes the setting of CLKLANE_STOP for the imx8m{m,n,p} platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v9: - Updated commit message - Drop [3/3] arm64: dts: imx8mn-bsh-smm-s2/pro: add

Re: [PATCH v3 07/14] drm/panthor: Add the MMU/VM logical block

2024-01-15 Thread Boris Brezillon
Hi Steve, On Fri, 8 Dec 2023 14:28:05 + Steven Price wrote: > > +/** > > + * alloc_pt() - Custom page table allocator > > + * @cookie: Cookie passed at page table allocation time. > > + * @size: Size of the page table. This size should be fixed, > > + * and determined at creation time based

Re: [PATCH v4 0/8] Add MT8195 HDMI support

2024-01-15 Thread AngeloGioacchino Del Regno
Il 29/05/23 16:30, Guillaume Ranquet ha scritto: Add support for HDMI Tx on MT8195. This includes a split of the current "legacy" hdmi driver into a common library of functions and two dedicated compilation units with specific code for mt8167 and another for the "v2" mt8195 SoC. Support for the

Re: [PATCH v3 09/14] drm/panthor: Add the heap logical block

2024-01-15 Thread Boris Brezillon
On Fri, 8 Dec 2023 16:27:39 + Steven Price wrote: > On 04/12/2023 17:33, Boris Brezillon wrote: > > Tiler heap growing requires some kernel driver involvement: when the > > tiler runs out of heap memory, it will raise an exception which is > > either directly handled by the firmware if some f

Re: [PATCH v3 01/14] drm/panthor: Add uAPI

2024-01-15 Thread Boris Brezillon
On Mon, 18 Dec 2023 13:20:07 + Chris Diamand wrote: > > +/** > > + * struct drm_panthor_group_submit - Arguments passed to > > DRM_IOCTL_PANTHOR_VM_BIND > > + */ > > +struct drm_panthor_group_submit { > > + /** @group_handle: Handle of the group to queue jobs to. */ > > + __u32 group_han

Re: [PATCH v3 08/14] drm/panthor: Add the FW logical block

2024-01-15 Thread Boris Brezillon
On Mon, 18 Dec 2023 21:25:16 + Chris Diamand wrote: > On 04/12/2023 17:33, Boris Brezillon wrote: > > Contains everything that's FW related, that includes the code dealing > > with the microcontroller unit (MCU) that's running the FW, and anything > > related to allocating memory shared betwe

[PATCH] Documentation/gpu: Reference articles on Linux graphics stack

2024-01-15 Thread Thomas Zimmermann
Add two articles on LWN about the Linux graphics stack to DRM's list of external references. The articles document the graphics output as a whole, including the kernel side. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/introduction.rst | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [PATCH] Documentation/gpu: Reference articles on Linux graphics stack

2024-01-15 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH RESEND v9 1/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2024-01-15 Thread Somalapuram, Amaranath
On 1/11/2024 8:29 PM, Christian König wrote: I've gone ahead and pushed this one to drm-misc-next. Going to take a look at the rest as well. @Amar could you run another test round with those? And maybe ping Kenny if we can integrate them into the CI. Thanks, Christian. Look's good: Rega

Re: [PATCH] drm/bridge: synopsys: dw-mipi-dsi: fix deferred dsi host probe breaks dsi device probe

2024-01-15 Thread neil . armstrong
On 15/01/2024 11:07, Heiko Stübner wrote: Am Montag, 15. Januar 2024, 09:45:10 CET schrieb neil.armstr...@linaro.org: Hi, On 12/01/2024 19:07, Farouk Bouabid wrote: dw-mipi-dsi based drivers such as dw-mipi-dsi-rockchip or dw_mipi_dsi-stm depend on dw_mipi_dsi_probe() to initialize the dw_mipi

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-15 Thread Paul Cercueil
Hi Daniel / Sima, Le mardi 09 janvier 2024 à 14:01 +0100, Daniel Vetter a écrit : > On Tue, Jan 09, 2024 at 12:06:58PM +0100, Paul Cercueil wrote: > > Hi Daniel / Sima, > > > > Le lundi 08 janvier 2024 à 20:19 +0100, Daniel Vetter a écrit : > > > On Mon, Jan 08, 2024 at 05:27:33PM +0100, Paul Cer

Re: [PATCH] Documentation/gpu: Reference articles on Linux graphics stack

2024-01-15 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add two articles on LWN about the Linux graphics stack to DRM's > list of external references. The articles document the graphics > output as a whole, including the kernel side. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Be

Re: [PATCH v3 08/14] drm/panthor: Add the FW logical block

2024-01-15 Thread Boris Brezillon
On Wed, 20 Dec 2023 15:12:15 + Liviu Dudau wrote: > > +static int panthor_fw_load_section_entry(struct panthor_device *ptdev, > > +const struct firmware *fw, > > +struct panthor_fw_binary_iter *iter, > > +

Re: [PATCH v3 11/14] drm/panthor: Add the driver frontend block

2024-01-15 Thread Boris Brezillon
On Wed, 20 Dec 2023 16:24:17 + Liviu Dudau wrote: > > +/** > > + * panthor_get_uobj_array() - Copy a user object array into a kernel > > accessible object array. > > + * @in: The object array to copy. > > + * @min_stride: Minimum array stride. > > + * @obj_size: Kernel object size. > > + * >

Re: [PATCH v3 10/14] drm/panthor: Add the scheduler logical block

2024-01-15 Thread Boris Brezillon
On Mon, 11 Dec 2023 16:27:36 + Steven Price wrote: > On 04/12/2023 17:33, Boris Brezillon wrote: > > This is the piece of software interacting with the FW scheduler, and > > taking care of some scheduling aspects when the FW comes short of slots > > scheduling slots. Indeed, the FW only expos

Re: [PATCH v3 10/14] drm/panthor: Add the scheduler logical block

2024-01-15 Thread Boris Brezillon
On Tue, 19 Dec 2023 12:50:21 +0100 Ketil Johnsen wrote: > On 04/12/2023 18:33, Boris Brezillon wrote: > > > > > +static void > > +panthor_queue_put_syncwait_obj(struct panthor_queue *queue) > > +{ > > + if (queue->syncwait.kmap) { > > + struct iosys_map map = > > IOSYS_MAP_INIT_VA

[PATCH 1/2] dt-bindings: display: ti, am65x-dss: Add support for common1 region

2024-01-15 Thread Devarsh Thakkar
TI keystone display subsystem present in AM65 and other SoCs such as AM62 support two separate register spaces namely "common" and "common1" which can be used by two separate hosts to program the display controller as described in respective Technical Reference Manuals [1]. The common1 register sp

Re: [PATCH v3 10/14] drm/panthor: Add the scheduler logical block

2024-01-15 Thread Boris Brezillon
On Wed, 20 Dec 2023 20:59:43 +0100 Ketil Johnsen wrote: > > +/** > > + * cs_slot_sync_queue_state_locked() - Synchronize the queue slot priority > > + * @ptdev: Device. > > + * @csg_id: Group slot. > > + * @cs_id: Queue slot. > > + * > > + * Queue state is updated on group suspend or STATUS_UPDAT

[PATCH v3 3/6] drm/stm: ltdc: add lvds pixel clock

2024-01-15 Thread Raphael Gallais-Pou
The STM32MP25x display subsystem presents a mux which feeds the loopback pixel clock of the current bridge in use into the LTDC. This mux is only accessible through sysconfig registers which is not yet available in the STM32MP25x common clock framework. While waiting for a complete update of the c

[PATCH v3 0/6] Introduce STM32 LVDS driver

2024-01-15 Thread Raphael Gallais-Pou
This serie introduces a new DRM bridge driver for STM32MP257 platforms based on Arm Cortex-35. It also adds an instance in the device-tree and handle the inclusion of the driver within the DRM framework. First patch adds a new panel compatible in the panel-lvds driver, which is used by default on t

[PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-15 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v3: - Clarify commit dependency - Fix includes in the example - Fix

[PATCH v3 2/6] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-01-15 Thread Raphael Gallais-Pou
The Low-Voltage Differential Signaling (LVDS) Display Interface Transmitter handles the LVDS protocol: it maps the pixels received from the upstream Pixel-DMA LCD-TFT Display Controller (LTDC) onto the LVDS PHY. It is composed of three sub blocks: * LVDS host: handles the LVDS protocol (FP

[PATCH v3 6/6] arm64: dts: st: add display support on stm32mp257f-ev

2024-01-15 Thread Raphael Gallais-Pou
This patch enables the following IPs on stm32mp257f-ev : * LTDC * LVDS * WSVGA LVDS panel (1024x600) * Panel backlight * Ilitek touchescreen Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 79 ++ 1 file changed, 79 insertions(+)

[PATCH v3 5/6] arm64: dts: st: add lvds support on stm32mp255

2024-01-15 Thread Raphael Gallais-Pou
This patch adds LVDS support on stm32mp255. The LVDS is used on STM32MP2 as a display interface. LVDS PLL clock is binded to the LTDC input clock. Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - Change the compatible to show SoC specificity Changes in v2: - Move patch t

[PATCH v3 4/6] arm64: dts: st: add ltdc support on stm32mp251

2024-01-15 Thread Raphael Gallais-Pou
The LCD-TFT Display Controller (LTDC) handles display composition, scaling and rotation. It provides a parallel digital RGB flow to be used by display interfaces. Signed-off-by: Raphael Gallais-Pou --- arch/arm64/boot/dts/st/stm32mp251.dtsi | 12 1 file changed, 12 insertions(+) di

[PATCH v2] drm/nouveau: convert to using is_hdmi and has_audio from display info

2024-01-15 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Conveniently, this also removes the need to use edid_blob_ptr. v2: Reverse a backwards if condition (Ilia) Cc: Karol Herbst Cc: Lyude Paul Cc

[PATCH v2 0/9] accel/ivpu fixes for 6.8

2024-01-15 Thread Jacek Lawrynowicz
Various driver fixes: - Fixes for infinite loops, missing locks and DMA-API debug warnings - Deprecate DRM_IVPU_PARAM_CONTEXT_PRIORITY - Improve diagnostic messages v2 includes changes from v1 review comments and drops IRQ infinite loop patch. Jacek Lawrynowicz (4): accel/ivpu: Fix for missi

[PATCH v2 1/9] accel/ivpu: Dump MMU events in case of VPU boot timeout

2024-01-15 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Add ivpu_mmu_evtq_dump() function that dumps existing MMU events from MMU event queue. Call this function if VPU boot failed. Previously MMU events were only checked in interrupt handler, but if VPU failed to boot due to MMU faults, those faults were missed because of in

[PATCH v2 2/9] accel/ivpu: Call diagnose failure in ivpu_mmu_cmdq_sync()

2024-01-15 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Check for possible failure reasons in the buttress. Some errors (like external abort) should have corresponding buttress errors registers set indicating the real reason of failure. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hu

[PATCH v2 3/9] accel/ivpu: Add debug prints for MMU map/unmap operations

2024-01-15 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" It is common need to be able to see IOVA/physical to VPU addresses mappings. Especially when debugging different kind of memory related issues. Lack of such logs forces user to modify and recompile KMD manually. This commit adds those logs under MMU debug mask which can

[PATCH v2 4/9] accel/ivpu: Add diagnostic messages when VPU fails to boot or suspend

2024-01-15 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Make boot/suspend failure debugging easier by dumping FW logs and error registers. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/ivpu_drv.c | 5 +++-- drivers/accel/ivpu/ivpu_pm.c | 4 +++- 2 files

[PATCH v2 5/9] accel/ivpu: Fix for missing lock around drm_gem_shmem_vmap()

2024-01-15 Thread Jacek Lawrynowicz
drm_gem_shmem_vmap/vunmap requires dma resv lock to be held. This was missed during conversion to shmem helper. Fixes: 8d88e4cdce4f ("accel/ivpu: Use GEM shmem helper for all buffers") Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/ivpu_gem.c | 5 + 1 file

[PATCH v2 6/9] accel/ivpu: Free buffer sgt on unbind

2024-01-15 Thread Jacek Lawrynowicz
Call dma_unmap() on all buffers before the VPU is unbinded to avoid "device driver has pending DMA allocations while released from device" warning when DMA-API debug is enabled. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/ivpu_gem.c | 14 -- 1 f

[PATCH v2 7/9] accel/ivpu: Disable buffer sharing among VPU contexts

2024-01-15 Thread Jacek Lawrynowicz
This was not supported properly. A buffer was imported to another VPU context as a separate buffer object with duplicated sgt. Both exported and imported buffers could be DMA mapped causing a double mapping on the same device. Buffers imported from another VPU context will now just increase refere

[PATCH v2 9/9] accel/ivpu: Deprecate DRM_IVPU_PARAM_CONTEXT_PRIORITY param

2024-01-15 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" DRM_IVPU_PARAM_CONTEXT_PRIORITY has been deprecated because it has been replaced with DRM_IVPU_JOB_PRIORITY levels set with submit IOCTL and was unused anyway. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 11

[PATCH v2 8/9] accel/ivpu: Improve buffer object debug logs

2024-01-15 Thread Jacek Lawrynowicz
Make debug logs more readable and consistent: - don't print handle as it is not always available for all buffers - use hashed ivpu_bo ptr as main buffer identifier - remove unused fields from ivpu_bo_print_info() Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_gem.c | 63 +

[DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs

2024-01-15 Thread Devarsh Thakkar
This adds common1 register space for AM62x and AM65x SoC's which are using TI's Keystone display hardware and supporting it as described in Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml. This region is documented in respective Technical Reference Manuals [1]. [1]: AM62x TRM: http

[PATCH 0/2] Add common1 register space for TI Keystone displays

2024-01-15 Thread Devarsh Thakkar
Add common1 register space for SoC's supporting TI Keystone displays present in AM65x and AM62x SoCs. This is required to support use-cases where Linux may want to use common1 region instead of common region with the latter being controlled by another processing core. The enumeration of common1 re

Re: [DO NOT MERGE v6 09/37] dt-bindings: timer: renesas, tmu: add renesas, tmu-sh7750

2024-01-15 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:23 AM Yoshinori Sato wrote: > Add SH7750 TMU entry. > > I wanted to replace interrupts and interrupt-names in the if compatible is > "renesas,tmu-7750", but it seems that I can't rewrite it as expected. > This resulted in a redundant conditional statement. >

Re: [DO NOT MERGE v6 25/37] dt-bindings: vendor-prefixes: Add iodata

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Add IO DATA DEVICE INC. > https://www.iodata.com/ > > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v3 is still valid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [DO NOT MERGE v6 01/37] sh: passing FDT address to kernel startup.

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:23 AM Yoshinori Sato wrote: > R4 is caller saved in SH ABI. > Save it so it doesn't get corrupted until it's needed for initialization. > > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v3 is still valid. Gr{oetje,eeting}s,

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2024-01-15 Thread Boris Brezillon
Hi Faith, Sorry for the late reply, I only got back to panthor very recently. On Mon, 11 Dec 2023 12:18:04 -0600 Faith Ekstrand wrote: > On Mon, 2023-12-11 at 09:52 +0100, Boris Brezillon wrote: > > Hi, > > > > On Sun, 10 Dec 2023 13:58:51 +0900 > > Tatsuyuki Ishi wrote: > > > > > > On Dec

Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-15 Thread Rob Herring
On Mon, 15 Jan 2024 14:20:04 +0100, Raphael Gallais-Pou wrote: > Add "st,stm32mp25-lvds" compatible. > > Signed-off-by: Raphael Gallais-Pou > --- > Depends on: "dt-bindings: stm32: add clocks and reset binding for > stm32mp25 platform" by Gabriel Fernandez > > Changes in v3: >

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Sebastian Wick
On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > The i915 driver has a property to force the RGB range of an HDMI output. > The vc4 driver then implemented the same property with the same > semantics. KWin has support for it, and a PR for mutter is also there to > support it. > > B

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > > The vc4 driver then implemented the same property with the same > > semantics. KWin has s

Re: Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread Maxime Ripard
On Mon, Jan 15, 2024 at 09:55:00AM +0100, H. Nikolaus Schaller wrote: > Hi, > > > Am 15.01.2024 um 09:25 schrieb Maxime Ripard : > > > > Hi, > > > > On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote: > >>> Am 08.01.2024 um 19:32 schrieb Andrew Davis : > >>> > >>> Add SGX GPU

[PATCH 01/10] pci: add new set of devres functions

2024-01-15 Thread Philipp Stanner
PCI's devres API is not extensible to ranged mappings and has bug-provoking features. Improve that by providing better alternatives. When the original devres API for PCI was implemented, priority was given to the creation of a set of "pural functions" such as pcim_request_regions(). These function

[PATCH 00/10] Make PCI's devres API more consistent

2024-01-15 Thread Philipp Stanner
¡Hola! PCI's devres API suffers several weaknesses: 1. There are functions prefixed with pcim_. Those are always managed counterparts to never-managed functions prefixed with pci_ – or so one would like to think. There are some apparently unmanaged functions (all region-request / release

[PATCH 03/10] pci: warn users about complicated devres nature

2024-01-15 Thread Philipp Stanner
The PCI region-request functions become managed functions when pcim_enable_device() has been called previously instead of pci_enable_device(). This has already caused bugs by confusing users, who came to believe that all pci functions, such as pci_iomap(), suddenly are managed that way. This is n

[PATCH 02/10] pci: deprecate iomap-table functions

2024-01-15 Thread Philipp Stanner
The old plural devres functions tie PCI's devres implementation to the iomap-table mechanism which unfortunately is not extensible. As the purlal functions are almost never used with more than one bit set in their bit-mask, deprecating them and encouraging users to use the new singular functions i

[PATCH 04/10] pci: devres: make devres region requests consistent

2024-01-15 Thread Philipp Stanner
Now that pure managed region request functions are available, the implementation of the hybrid-functions which are only sometimes managed can be made more consistent and readable by wrapping those always-managed functions. Implement a new pcim_ function for exclusively requested regions. Have the

[PATCH 07/10] pci: devres: give mwi its own callback

2024-01-15 Thread Philipp Stanner
managing mwi with devres can easily be done with its own callback, without the necessity to store any state about it in a device-related struct. Remove the mwi state from the devres-struct. Make the devres-mwi functions set a separate devres-callback. Signed-off-by: Philipp Stanner --- drivers/

[PATCH 05/10] pci: move enabled status bit to pci_dev struct

2024-01-15 Thread Philipp Stanner
The bit describing whether the PCI device is currently enabled is stored in the devres-struct. Besides this struct being subject of a cleanup process, the device-struct is in general the right place to store this information, since it is not devres-specific. Move the 'enabled' boolean bit to struc

[PATCH 06/10] pci: move pinned status bit to pci_dev struct

2024-01-15 Thread Philipp Stanner
The bit describing whether the PCI device is currently pinned is stored in the PCI devres struct. To clean up and simplify the pci-devres API, it's better if this information is stored in the pci_dev struct, because it allows for checking that device's pinned-status directly through the device stru

[PATCH 08/10] pci: devres: give pci(m)_intx its own callback

2024-01-15 Thread Philipp Stanner
pci_intx() is one of the functions that have "hybrid mode" (i.e., sometimes managed, sometimes not). Providing a separate pcim_intx() function with its own device resource and cleanup callback allows for removing further large parts of the legacy pci-devres implementation. As in the region-request

[PATCH 09/10] pci: devres: remove legacy pcim_release()

2024-01-15 Thread Philipp Stanner
Thanks to preceding cleanup steps, pcim_release() is now not needed anymore and can be replaced by pcim_disable_device(), which is the exact counterpart to pcim_enable_device(). This permits removing further parts of the old devres API. Replace pcim_release() with pcim_disable_device(). Remove the

[PATCH 10/10] drm/vboxvideo: fix mapping leaks

2024-01-15 Thread Philipp Stanner
When the managed PCI-API was introduced to this driver, it was falsly assumed that initializing the device with pcim_enable_device() instead of pci_enable_device() will make all PCI functions managed. This is wrong and was caused by the quite confusing devres API for PCI: The function pci_iomap_ra

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-15 Thread Sebastian Wick
On Thu, Jan 11, 2024 at 05:17:46PM +, Andri Yngvason wrote: > mið., 10. jan. 2024 kl. 13:26 skrifaði Daniel Stone : > > > > > > This thing here works entirely differently, and I think we need somewhat > > > new semantics for this: > > > > > > - I agree it should be read-only for userspace, so i

Re: [PATCH v2 0/7] Add YUV formats to VKMS

2024-01-15 Thread Sebastian Wick
On Wed, Jan 10, 2024 at 02:44:00PM -0300, Arthur Grillo wrote: > This patchset aims to add support for additional buffer YUV formats. > More specifically, it adds support to: > > Semi-planar formats: > > - NV12 > - NV16 > - NV24 > - NV21 > - NV61 > - NV42 > > Planar formats: > > - YUV440 > - YU

Re: [PATCH v3] drm/ci: add tests on vkms

2024-01-15 Thread Helen Koike
Hi, Thanks for picking this up. On 02/01/2024 06:41, Vignesh Raman wrote: From: Helen Koike Add job that runs igt on top of vkms. Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Helen Koike --- v2: - do not mv modules

Re: [PATCH v1] drm/ci: add sc7180-trogdor-kingoftown

2024-01-15 Thread Helen Koike
On 04/01/2024 05:14, Vignesh Raman wrote: Add job that executes the IGT test suite for sc7180-trogdor-kingoftown. This commit also updates xfails for sc7180-trogdor-lazor-limozeen. Signed-off-by: Vignesh Raman lgtm Acked-by: Helen Koike Thanks Helen --- See pipeline: https://gitlab.

Re: [PATCH v1] drm/ci: Update xfails for newly added msm tests

2024-01-15 Thread Helen Koike
On 15/01/2024 07:17, Vignesh Raman wrote: msm tests are added to testlist.txt, so update the xfails for jobs in msm stage. Signed-off-by: Vignesh Raman --- Depends on https://patchwork.kernel.org/project/linux-arm-msm/patch/20240108195016.156583-1-robdcl...@gmail.com/ --- .../gpu/drm/ci

Re: [PATCH] drm/ci: Add msm tests

2024-01-15 Thread Helen Koike
On 15/01/2024 07:22, Vignesh Raman wrote: Hi Rob, On 12/01/24 22:44, Rob Clark wrote: On Fri, Jan 12, 2024 at 7:57 AM Rob Clark wrote: On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman wrote: Hi Rob, On 09/01/24 01:20, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Maxime Ripard
On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > > The vc4 driver then implemented the same property with the same > > semantics. KWin has s

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Maxime Ripard
On Mon, Jan 15, 2024 at 03:37:20PM +0100, Sebastian Wick wrote: > On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > > On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > > > The i915 driver has a property to force the RGB range of an HDMI output. > > > The vc4 driver th

Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

2024-01-15 Thread Rob Herring
On Mon, Jan 15, 2024 at 02:20:04PM +0100, Raphael Gallais-Pou wrote: > Add "st,stm32mp25-lvds" compatible. > > Signed-off-by: Raphael Gallais-Pou > --- > Depends on: "dt-bindings: stm32: add clocks and reset binding for > stm32mp25 platform" by Gabriel Fernandez > > Changes in v3: >

[PATCH v2 0/4] New DRM properties for output color format

2024-01-15 Thread Andri Yngvason
After some discussion, we decided to drop the "active color format" property and rename the "preferred color format" property to "force color format". The user can probe available color formats in combination with other properties using TEST_ONLY commits. v1: https://lore.kernel.org/dri-devel/2

[PATCH v2 1/4] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2024-01-15 Thread Andri Yngvason
From: Werner Sembach Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB whe

[PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-15 Thread Andri Yngvason
From: Werner Sembach Add a new general drm property "force color format" which can be used by userspace to tell the graphics driver which color format to use. Possible options are: - auto (default/current behaviour) - rgb - ycbcr444 - ycbcr422 (supported by neither amdgpu or i915

[PATCH v2 3/4] drm/amd/display: Add handling for new "force color format" property

2024-01-15 Thread Andri Yngvason
From: Werner Sembach This commit implements the "force color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach Co-Developed-by: Andri Yngvason Signed-off-by: Andri Yngvason Tested-by: Andri Yngvason --- Changes in v2: - Renamed to "force color format" from "preferr

  1   2   >