Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

2024-01-08 Thread Linus Walleij
On Wed, Jan 3, 2024 at 2:31 PM Tomi Valkeinen wrote: > Two small fixes to sii902x for crashes. > > Signed-off-by: Tomi Valkeinen These look good to me! Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/2] platform_device: add devres function region-reqs

2024-01-08 Thread Philipp Stanner
Hi On Fri, 2024-01-05 at 20:11 +0100, Uwe Kleine-König wrote: > On Fri, Jan 05, 2024 at 06:22:18PM +0100, Philipp Stanner wrote: > > Some drivers want to use (request) a region exclusively but > > nevertheless > > create several mappings within that region. > > > > Currently, there is no managed

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-08 Thread Hans Verkuil
On 04/01/2024 21:05, Jeffrey Kardatzke wrote: > On Mon, Dec 11, 2023 at 3:05 AM Hans Verkuil wrote: >> >> On 06/12/2023 09:15, Yunfei Dong wrote: >>> From: Jeffrey Kardatzke >>> >>> Adds documentation for V4L2_MEMORY_FLAG_SECURE. >>> >>> Signed-off-by: Jeffrey Kardatzke >>> Signed-off-by: Yunfei

[Bug 218347] Crash. amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2024-01-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218347 --- Comment #3 from Rik (riks...@gmail.com) --- Are you sure? Because in the help I read: Video(DRI - Intel) intel-gfx-b...@lists.freedesktop.org Please file new drm/i915 bugs at https://bugs.freedesktop.org. Product: DRI. Component: DRM/Int

Re: [PATCH] drm/vc4: don't check if plane->state->fb == state->fb

2024-01-08 Thread Maxime Ripard
On Fri, 5 Jan 2024 14:58:36 -0300, Maíra Canal wrote: > Currently, when using non-blocking commits, we can see the following > kernel warning: > > [ 110.908514] [ cut here ] > [ 110.908529] refcount_t: underflow; use-after-free. > > [ ... ] Acked-by: Maxime Ripard Th

Re: [PATCH 0/2] drm: remove drm_connector_helper_get_modes_from_ddc()

2024-01-08 Thread Thomas Zimmermann
Hi, for the series: Reviewed-by: Thomas Zimmermann Thanks for cleaning up. Best regards Thomas Am 05.01.24 um 17:57 schrieb Jani Nikula: Convert mgag200 to use struct drm_edid directly, and drop drm_connector_helper_get_modes_from_ddc(), as suggested by Thomas. This supersedes [1]. BR, Ja

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-08 Thread Thomas Zimmermann
Hi, thanks for the fix. Am 06.01.24 um 04:29 schrieb Randy Dunlap: Remove the @funcs entry from struct drm_vram_mm to quieten the kernel-doc warning. Use the "define" kernel-doc keyword and an '\' line continuation to fix another kernel-doc warning. drm_gem_vram_helper.h:129: warning: missing

[PATCH] drm/xe: clean up type of GUC_HXG_MSG_0_ORIGIN

2024-01-08 Thread Dan Carpenter
The GUC_HXG_MSG_0_ORIGIN definition should be unsigned. Currently it is defined as INT_MIN. This doesn't cause a problem currently but it's still worth cleaning up. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/xe/abi/guc_messages_abi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] drm/mgag200: Fix caching setup for remapped video memory

2024-01-08 Thread Thomas Zimmermann
Hi Am 05.01.24 um 11:41 schrieb Jocelyn Falempe: Hi, On 05/01/2024 09:25, Thomas Zimmermann wrote: I/O video memory for the framebuffer supports write-combine caching mode. Simplify the driver's code that sets up the caching mode.   * Map video memory with ioremap_wc(), which automatically se

Re: [PATCH] fbdev/sis: Remove dependency on screen_info

2024-01-08 Thread Helge Deller
On 1/3/24 13:13, Thomas Zimmermann wrote: When built-in, the sis driver tries to detect the current display mode from the global screen_info state. That state is only for architecture and firmware code. Drivers should not use it directly as it's not guaranteed to contain valid information. Remov

[drm-misc:drm-misc-next 6/21] drivers/gpu/drm/rockchip/inno_hdmi.c:499:15: error: call to undeclared function 'drm_atomic_get_new_connector_state'; ISO C99 and later do not support implicit function d

2024-01-08 Thread kernel test robot
/20240108/202401081720.utgazgba-...@intel.com/config) compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project 7e186d366d6c7def0543acc255931f617e76dff0) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240108/202401081720.utgazgba-...@intel.com/reproduce) If

[PATCH v2 0/2] platform_device: add new devres function

2024-01-08 Thread Philipp Stanner
Changes in v2: - Fix wrong function name in docstring (Uwe) - Change devres function name so it becomes obvious that it's requesting Patch #1 adds a new devres function that I found could be useful for the driver dcss in drm. Patch #2 makes that driver use the new function. I compiled this succes

[PATCH v2 1/2] platform_device: add devres function region-reqs

2024-01-08 Thread Philipp Stanner
Some drivers want to use (request) a region exclusively but nevertheless create several mappings within that region. Currently, there is no managed devres function to request a region without mapping it. Add the function devm_platform_get_resource(). Signed-off-by: Philipp Stanner --- drivers/

[PATCH v2 2/2] drm/dcss: request memory region

2024-01-08 Thread Philipp Stanner
The driver's memory regions are currently just ioremap()ed, but not reserved through a request. That's not a bug, but having the request is a little more robust. Implement the region-request through the corresponding managed devres-function. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/im

Re: [PATCH 1/4] drm/hyperv: Remove firmware framebuffers with aperture helper

2024-01-08 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Replace use of screen_info state with the correct interface from > the aperture helpers. The state is only for architecture and firmware > code. It is not guaranteed to contain valid data. Drivers are thus > not allowed to use it. > > For removing confli

Re: [PATCH 2/4] fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers

2024-01-08 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Replace use of screen_info state with the correct interfaces from > the aperture helpers. The state is only for architecture and firmware > code. It is not guaranteed to contain valid data. Drivers are thus > not allowed to use it. > > For removing conflicting firmware

Re: [PATCH] fbdev/intelfb: Remove driver

2024-01-08 Thread Helge Deller
On 1/5/24 10:10, Thomas Zimmermann wrote: From looking at the PCI IDs, every device supported by intelfb is also supported by i915. Anyone still using intelfb should please move on to i915, which does everything intelfb does but better. Removing intelfb is motivated by the driver's excessive us

Re: [PATCH 1/4] drm/hyperv: Remove firmware framebuffers with aperture helper

2024-01-08 Thread Helge Deller
On 1/8/24 10:26, Javier Martinez Canillas wrote: Thomas Zimmermann writes: Hello Thomas, Replace use of screen_info state with the correct interface from the aperture helpers. The state is only for architecture and firmware code. It is not guaranteed to contain valid data. Drivers are thus no

Re: [PATCH 3/4] firmware/sysfb: Clear screen_info state after consuming it

2024-01-08 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > After consuming the global screen_info_state in sysfb_init(), the > created platform device maintains the firmware framebuffer. Clear > screen_info to avoid conflicting access. Subsequent kexec reboots > now ignore the firmware framebuffer. > > Signed-off-by: Thomas Zi

Re: [PATCH 4/4] fbdev/hyperv_fb: Do not clear global screen_info

2024-01-08 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Do not clear the global instance of screen_info. If necessary, clearing > fields in screen_info should be done by architecture or firmware code > that maintains the firmware framebuffer. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe

2024-01-08 Thread Alexander Stein
Hi Francesco, thanks for the feedback. Am Donnerstag, 4. Januar 2024, 20:28:08 CET schrieb Francesco Dolcini: > On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote: > > On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote: > > > This simplifies the code and gives addition

Re: [PATCH v2 1/2] platform_device: add devres function region-reqs

2024-01-08 Thread Uwe Kleine-König
Hello Philipp, the Subject is incomprehensible (to me). Maybe make it: platform_device: Add devm function to simplify mem and io requests ? On Mon, Jan 08, 2024 at 10:20:42AM +0100, Philipp Stanner wrote: > Some drivers want to use (request) a region exclusively but nevertheless > creat

Re: [PATCH v2 1/2] platform_device: add devres function region-reqs

2024-01-08 Thread Philipp Stanner
On Mon, 2024-01-08 at 10:37 +0100, Uwe Kleine-König wrote: > Hello Philipp, > > the Subject is incomprehensible (to me). Maybe make it: > > platform_device: Add devm function to simplify mem and io > requests > > ? > > On Mon, Jan 08, 2024 at 10:20:42AM +0100, Philipp Stanner wrote: > >

[PATCH libdrm 1/2] amdgpu: fix parameter of amdgpu_cs_ctx_create2

2024-01-08 Thread Zhenneng Li
In order to pass the correct priority parameter to the kernel, we must change priority type from uint32_t to int32_t. Signed-off-by: Zhenneng Li --- amdgpu/amdgpu.h| 2 +- amdgpu/amdgpu_cs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgp

[PATCH libdrm 2/2] amdgpu: change proirity value to be consistent with kernel

2024-01-08 Thread Zhenneng Li
In libdrm-amdgpu and amdgpu kernel driver, there are only such priority level: AMDGPU_CTX_PRIORITY_VERY_LOW, AMDGPU_CTX_PRIORITY_LOW, AMDGPU_CTX_PRIORITY_NORMAL, AMDGPU_CTX_PRIORITY_HIGH, AMDGPU_CTX_PRIORITY_VERY_HIGH If priority value is not the one of the above data, the kernel will treat it as

[v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD DSI

2024-01-08 Thread Ritesh Kumar
Document Novatek NT36672E FHD+ LCD DSI panel. Signed-off-by: Ritesh Kumar --- v2: Fixed review comments from Krzysztof - renamed to novatek,nt36672e, since the binding is for the IC and not the panel. - moved additionalProperties after required. --- .../display/panel/novatek

[v2 2/2] drm/panel: Add support for Novatek NT36672E panel driver

2024-01-08 Thread Ritesh Kumar
Add support for the 1080x2408 Novatek NT36672E video mode DSI panel driver. Signed-off-by: Ritesh Kumar --- v2: Fixed review comments from Krzysztof - renamed the panel driver file to reflect that this is a novatek IC. - adjusted internal function names to reflect the same. - c

[v2 0/2] Add support for Novatek NT36672E LCD DSI panel

2024-01-08 Thread Ritesh Kumar
Add support for the 1080x2408 Novatek NT36672E LCD DSI mode panel found on the Qualcomm QCM6490 MTP board. The driver will come with the uncompressed video mode support. --- v2: Fixed review comments from Krzysztof - renamed to novatek,nt36672e, since the driver is for the IC and no

Re: [v2 1/2] dt-bindings: display: panel: Add Novatek NT36672E LCD DSI

2024-01-08 Thread Krzysztof Kozlowski
On 08/01/2024 10:59, Ritesh Kumar wrote: > Document Novatek NT36672E FHD+ LCD DSI panel. > > Signed-off-by: Ritesh Kumar > > --- > v2: Fixed review comments from Krzysztof Please use standard email subjects, so with the PATCH keyword in the title. `git format-patch` helps here to create proper

Re: [PATCH 7/7] drm/vkms: Create KUnit tests for YUV conversions

2024-01-08 Thread Maxime Ripard
Hi Arthur, On Fri, Jan 05, 2024 at 01:35:08PM -0300, Arthur Grillo wrote: > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c > b/drivers/gpu/drm/vkms/vkms_formats.c > index b654b6661a20..11df990a0fa9 100644 > --- a/drivers/gpu/drm/vkms/vkms_formats.c > +++ b/drivers/gpu/drm/vkms/vkms_formats.c >

[Bug 111271] Black stripe on screen with MGAG200 (PowerEdge R320) and modesetting

2024-01-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111271 Roland Kletzing (devz...@web.de) changed: What|Removed |Added CC||devz...@web.de --- Com

Re: [PATCH v7 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

2024-01-08 Thread Maxime Ripard
Hi, On Thu, Jan 04, 2024 at 05:00:49PM +0100, Jocelyn Falempe wrote: > This was initialy done for imx6, but should work on most drivers > using drm_fb_dma_helper. > > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/drm_fb_dma_helper.c | 55 + > include/drm/drm

Re: [PATCH v7 3/9] drm/plane: Add drm_for_each_primary_visible_plane macro

2024-01-08 Thread Jocelyn Falempe
Hi checkpatch maintainers, This patch gives me the following checkpatch error: ERROR: Macros with complex values should be enclosed in parentheses #30: FILE: include/drm/drm_plane.h:959: +#define drm_for_each_primary_visible_plane(plane, dev) \ + list_for_each_entry((plane), &(dev)->mode_c

[Bug 203201] [mgag200] Unable to do mmap call on mgadrmfb device - Returns -EINVAL

2024-01-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203201 Roland Kletzing (devz...@web.de) changed: What|Removed |Added CC||devz...@web.de --- Com

Re: [PATCH v4 2/6] drm/tests: managed: Rename the suite name to match other DRM tests

2024-01-08 Thread Maxime Ripard
On Fri, Jan 05, 2024 at 11:13:20AM +0100, Michał Winiarski wrote: > DRM tests use "_" rather than "-" as word separator. Rename the test > suite to match other tests. > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/tests/drm_managed_test.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v7 3/9] drm/plane: Add drm_for_each_primary_visible_plane macro

2024-01-08 Thread Joe Perches
On Mon, 2024-01-08 at 11:24 +0100, Jocelyn Falempe wrote: > Hi checkpatch maintainers, > > This patch gives me the following checkpatch error: > > ERROR: Macros with complex values should be enclosed in parentheses > #30: FILE: include/drm/drm_plane.h:959: > +#define drm_for_each_primary_visible_

Re: [PATCH v4 3/6] drm/tests: managed: Remove the waitqueue usage

2024-01-08 Thread Maxime Ripard
On Fri, Jan 05, 2024 at 11:13:21AM +0100, Michał Winiarski wrote: > DRM managed release (drm_managed_release) is called as part of devres > release (devres_release_all), which is not async. > The release action should have already been executed once > drm_kunit_helper_free_device exits, meaning tha

Re: [PATCH v4 4/6] drm/tests: managed: Add comments and expect fail messages

2024-01-08 Thread Maxime Ripard
On Fri, Jan 05, 2024 at 11:13:22AM +0100, Michał Winiarski wrote: > Add comments explaining the intention behind the test and certain > implementation details related to device lifetime. > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/tests/drm_managed_test.c | 11 ++- > 1 fi

Re: [PATCH v2] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2024-01-08 Thread Maxime Ripard
On Sat, Dec 23, 2023 at 03:59:33PM +0530, Dipam Turkar wrote: > I needed some help regarding introducing a separate test for testing if the > function still works if called a second time as suggested. Wouldn't we need > to call it on the same object we called in the first time. So, that will > brin

Re: [PATCH v3 1/1] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2024-01-08 Thread Maxime Ripard
On Sat, Jan 06, 2024 at 07:31:18PM +0530, Dipam Turkar wrote: > --- > drivers/gpu/drm/tests/drm_connector_test.c | 20 > 1 file changed, 20 insertions(+) You're missing your commit message, Signed-off-by and version changes here. > diff --git a/drivers/gpu/drm/tests/drm_conn

Re: [PATCH v4 5/6] drm/tests: managed: Extract device initialization into test init

2024-01-08 Thread Maxime Ripard
On Fri, Jan 05, 2024 at 11:13:23AM +0100, Michał Winiarski wrote: > It simplifies the process of extending the test suite with additional > test cases without unnecessary duplication. > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/tests/drm_managed_test.c | 37 +++---

Re: [PATCH v2 1/2] platform_device: add devres function region-reqs

2024-01-08 Thread Uwe Kleine-König
On Mon, Jan 08, 2024 at 10:45:31AM +0100, Philipp Stanner wrote: > On Mon, 2024-01-08 at 10:37 +0100, Uwe Kleine-König wrote: > > Other than that I indifferent if this is a good idea. There are so many > > helpers around these functions ... > > Around which, the devres functions in general? There

[PATCH v3 0/4] usb: gadget: functionfs: DMABUF import interface

2024-01-08 Thread Paul Cercueil
everybody is happy with its part of the cake, we can merge them all at once. This is obviously for 5.9, and based on next-20240108. Changelog: - [3/4]: - Inline to_ffs_dma_fence() which was called only once. - Simplify ffs_dma_resv_lock() - Add comment explaining why we unre

[PATCH v3 1/4] usb: gadget: Support already-mapped DMA SGs

2024-01-08 Thread Paul Cercueil
Add a new 'sg_was_mapped' field to the struct usb_request. This field can be used to indicate that the scatterlist associated to the USB transfer has already been mapped into the DMA space, and it does not have to be done internally. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/udc/core.c

[PATCH v3 2/4] usb: gadget: functionfs: Factorize wait-for-endpoint code

2024-01-08 Thread Paul Cercueil
This exact same code was duplicated in two different places. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/function/f_fs.c | 48 +- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/

[PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Paul Cercueil
This patch introduces three new ioctls. They all should be called on a data endpoint (ie. not ep0). They are: - FUNCTIONFS_DMABUF_ATTACH, which takes the file descriptor of a DMABUF object to attach to the endpoint. - FUNCTIONFS_DMABUF_DETACH, which takes the file descriptor of the DMABUF to

[PATCH v3 4/4] Documentation: usb: Document FunctionFS DMABUF API

2024-01-08 Thread Paul Cercueil
Add documentation for the three ioctls used to attach or detach externally-created DMABUFs, and to request transfers from/to previously attached DMABUFs. Signed-off-by: Paul Cercueil --- v3: New patch --- Documentation/usb/functionfs.rst | 36 1 file changed, 36

[PATCH] drm: Clean-up superfluously selecting VT_HW_CONSOLE_BINDING

2024-01-08 Thread Lukas Bulwahn
As config FRAMEBUFFER_CONSOLE already selects VT_HW_CONSOLE_BINDING, there is no need for any drm driver to repeat that rule for selecting. Remove those duplications of selecting VT_HW_CONSOLE_BINDING. Signed-off-by: Lukas Bulwahn --- drivers/gpu/drm/ingenic/Kconfig | 1 - drivers/gpu/drm/mcde/

Re: [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec()

2024-01-08 Thread Paul Cercueil
Hi Vinod, Le jeudi 21 décembre 2023 à 20:44 +0530, Vinod Koul a écrit : > On 19-12-23, 18:50, Paul Cercueil wrote: > > This function can be used to initiate a scatter-gather DMA > > transfer, > > where the address and size of each segment is located in one entry > > of > > the dma_vec array. > >

[PATCH AUTOSEL 6.6 8/8] nouveau: fix disp disabling with GSP

2024-01-08 Thread Sasha Levin
From: Dave Airlie [ Upstream commit 7854ea0e408d7f2e8faaada1773f3ddf9cb538f5 ] This func ptr here is normally static allocation, but gsp r535 uses a dynamic pointer, so we need to handle that better. This fixes a crash with GSP when you use config=disp=0 to avoid disp problems. Signed-off-by:

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Christian König
Am 08.01.24 um 13:00 schrieb Paul Cercueil: This patch introduces three new ioctls. They all should be called on a data endpoint (ie. not ep0). They are: - FUNCTIONFS_DMABUF_ATTACH, which takes the file descriptor of a DMABUF object to attach to the endpoint. - FUNCTIONFS_DMABUF_DETACH, whic

[PATCH AUTOSEL 6.1 5/5] nouveau: fix disp disabling with GSP

2024-01-08 Thread Sasha Levin
From: Dave Airlie [ Upstream commit 7854ea0e408d7f2e8faaada1773f3ddf9cb538f5 ] This func ptr here is normally static allocation, but gsp r535 uses a dynamic pointer, so we need to handle that better. This fixes a crash with GSP when you use config=disp=0 to avoid disp problems. Signed-off-by:

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Daniel Vetter
On Mon, Jan 08, 2024 at 01:00:55PM +0100, Paul Cercueil wrote: > This patch introduces three new ioctls. They all should be called on a > data endpoint (ie. not ep0). They are: > > - FUNCTIONFS_DMABUF_ATTACH, which takes the file descriptor of a DMABUF > object to attach to the endpoint. > > -

Re: [PATCH] drm: Clean-up superfluously selecting VT_HW_CONSOLE_BINDING

2024-01-08 Thread Daniel Vetter
On Mon, Jan 08, 2024 at 01:17:57PM +0100, Lukas Bulwahn wrote: > As config FRAMEBUFFER_CONSOLE already selects VT_HW_CONSOLE_BINDING, there > is no need for any drm driver to repeat that rule for selecting. > > Remove those duplications of selecting VT_HW_CONSOLE_BINDING. This is only tree since

Re: [PATCH 0/2] drm: remove drm_connector_helper_get_modes_from_ddc()

2024-01-08 Thread Jani Nikula
On Mon, 08 Jan 2024, Thomas Zimmermann wrote: > Hi, > > for the series: > > Reviewed-by: Thomas Zimmermann > > Thanks for cleaning up. Thanks for the review, pushed to drm-misc-next. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH v5 5/8] iio: core: Add new DMABUF interface infrastructure

2024-01-08 Thread Daniel Vetter
On Tue, Dec 19, 2023 at 06:50:06PM +0100, Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new > optional DMABUF based interface. > > With this new interface, DMABUF objects (externally created) can be > attached to a IIO buffer, and subsequently used for data t

[PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-08 Thread Lukas Bulwahn
The config HW_CONSOLE is always identical to the config VT and is not visible in the kernel's build menuconfig. So, CONFIG_HW_CONSOLE is redundant. Replace all references to CONFIG_HW_CONSOLE with CONFIG_VT and remove CONFIG_HW_CONSOLE. Signed-off-by: Lukas Bulwahn --- I think this patch is best

Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices

2024-01-08 Thread Jason Gunthorpe
On Mon, Jan 08, 2024 at 02:02:57PM +0800, Yan Zhao wrote: > On Fri, Jan 05, 2024 at 03:55:51PM -0400, Jason Gunthorpe wrote: > > On Fri, Jan 05, 2024 at 05:12:37PM +0800, Yan Zhao wrote: > > > This series allow user space to notify KVM of noncoherent DMA status so as > > > to let KVM honor guest me

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-08 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2024 at 02:41:02PM +0100, Lukas Bulwahn wrote: > The config HW_CONSOLE is always identical to the config VT and is not > visible in the kernel's build menuconfig. So, CONFIG_HW_CONSOLE is > redundant. > > Replace all references to CONFIG_HW_CONSOLE with CONFIG_VT and remove > CONFI

Re: [PATCH] drm/xe: clean up type of GUC_HXG_MSG_0_ORIGIN

2024-01-08 Thread Lucas De Marchi
On Mon, Jan 08, 2024 at 12:05:57PM +0300, Dan Carpenter wrote: The GUC_HXG_MSG_0_ORIGIN definition should be unsigned. Currently it is defined as INT_MIN. This doesn't cause a problem currently but it's still worth cleaning up. Signed-off-by: Dan Carpenter it seems there are a few more plac

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-08 Thread Geert Uytterhoeven
On Mon, Jan 8, 2024 at 2:41 PM Lukas Bulwahn wrote: > The config HW_CONSOLE is always identical to the config VT and is not > visible in the kernel's build menuconfig. So, CONFIG_HW_CONSOLE is > redundant. > > Replace all references to CONFIG_HW_CONSOLE with CONFIG_VT and remove > CONFIG_HW_CONSOL

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-08 Thread Javier Martinez Canillas
Lukas Bulwahn writes: Hello Lukas, > The config HW_CONSOLE is always identical to the config VT and is not > visible in the kernel's build menuconfig. So, CONFIG_HW_CONSOLE is > redundant. > > Replace all references to CONFIG_HW_CONSOLE with CONFIG_VT and remove > CONFIG_HW_CONSOLE. > > Signed-o

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Paul Cercueil
Hi Daniel (Sima?), Le lundi 08 janvier 2024 à 13:39 +0100, Daniel Vetter a écrit : > On Mon, Jan 08, 2024 at 01:00:55PM +0100, Paul Cercueil wrote: > > This patch introduces three new ioctls. They all should be called > > on a > > data endpoint (ie. not ep0). They are: > > > > - FUNCTIONFS_DMABUF

Re: Automatically update drm CI dependencies?

2024-01-08 Thread Helen Koike
On 20/12/2023 08:11, Bagas Sanjaya wrote: On 12/19/23 23:43, Helen Koike wrote: Hi, On 14/12/2023 06:38, Bagas Sanjaya wrote: Hi all, I'm referring to dependabot PR on torvalds.git GitHub mirror [1]. I know that PRs submitted there are not accepted (the repo is essentially read-only mirror

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-01-08 Thread Alexander Stein
Hi Adam, thanks for pushing this forward. Am Samstag, 6. Januar 2024, 23:19:05 CET schrieb Adam Ford: > From: Lucas Stach > > This adds the driver for the Samsung HDMI PHY found on the > i.MX8MP SoC. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > --- > V2: Fixed some whitespace

Re: [PATCH V7 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-01-08 Thread Alexander Stein
Hi Adam, thanks for pushing this forward. Am Samstag, 6. Januar 2024, 22:51:45 CET schrieb Adam Ford: > From: Lucas Stach > > This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a > full timing generator and can switch between different video sources. On > the i.MX8MP howeve

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-01-05 12:39:31) > > On 04/01/2024 21:23, Andi Shyti wrote: > >>> +void intel_gt_apply_ccs_mode(struct intel_gt *gt) > >>> +{ > >>> + mutex_lock(>->ccs.mutex); > >>> + __intel_gt_apply_ccs_mode(gt); > >>> + mutex_unlock(>->ccs.mutex); > >>> +} > >>> + > >>> +vo

Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices

2024-01-08 Thread Daniel Vetter
On Mon, Jan 08, 2024 at 10:02:50AM -0400, Jason Gunthorpe wrote: > On Mon, Jan 08, 2024 at 02:02:57PM +0800, Yan Zhao wrote: > > On Fri, Jan 05, 2024 at 03:55:51PM -0400, Jason Gunthorpe wrote: > > > On Fri, Jan 05, 2024 at 05:12:37PM +0800, Yan Zhao wrote: > > > > This series allow user space to n

[PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

2024-01-08 Thread Alexander Stein
The bridge type was set to default (Unknown). Set proper bridge type. With this fixed, debugfs output imx8mp looks proper. $ cat /sys/kernel/debug/dri/1/encoder-0/bridges bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] type: [0] Unknown OF: /soc@0/bus@32c0/display-bridge@

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Daniel Vetter
On Mon, Jan 08, 2024 at 03:21:21PM +0100, Paul Cercueil wrote: > Hi Daniel (Sima?), > > Le lundi 08 janvier 2024 à 13:39 +0100, Daniel Vetter a écrit : > > On Mon, Jan 08, 2024 at 01:00:55PM +0100, Paul Cercueil wrote: > > > This patch introduces three new ioctls. They all should be called > > > o

Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices

2024-01-08 Thread Jason Gunthorpe
On Mon, Jan 08, 2024 at 04:25:02PM +0100, Daniel Vetter wrote: > On Mon, Jan 08, 2024 at 10:02:50AM -0400, Jason Gunthorpe wrote: > > On Mon, Jan 08, 2024 at 02:02:57PM +0800, Yan Zhao wrote: > > > On Fri, Jan 05, 2024 at 03:55:51PM -0400, Jason Gunthorpe wrote: > > > > On Fri, Jan 05, 2024 at 05:1

Re: [PATCH v3 3/4] usb: gadget: functionfs: Add DMABUF import interface

2024-01-08 Thread Paul Cercueil
Le lundi 08 janvier 2024 à 16:29 +0100, Daniel Vetter a écrit : > On Mon, Jan 08, 2024 at 03:21:21PM +0100, Paul Cercueil wrote: > > Hi Daniel (Sima?), > > > > Le lundi 08 janvier 2024 à 13:39 +0100, Daniel Vetter a écrit : > > > On Mon, Jan 08, 2024 at 01:00:55PM +0100, Paul Cercueil wrote: > > >

Re: [PATCH libdrm 1/2] amdgpu: fix parameter of amdgpu_cs_ctx_create2

2024-01-08 Thread Christian König
Am 08.01.24 um 10:40 schrieb Zhenneng Li: In order to pass the correct priority parameter to the kernel, we must change priority type from uint32_t to int32_t. Hui what? Why should it matter if the parameter is signed or not? That doesn't seem to make sense. Regards, Christian. Signed-off-

Re: [PATCH][next] drm/xe: Fix spelling mistake "gueue" -> "queue"

2024-01-08 Thread Lucas De Marchi
On Tue, 02 Jan 2024 09:20:14 +, Colin Ian King wrote: > There is a spelling mistake in a drm_info message. Fix it. > > Applied to drm-xe-next branch, thanks! [1/1] drm/xe: Fix spelling mistake "gueue" -> "queue" commit: a3e6b7b90ce1ff725d7585cbd2c9279e6e39b914 Best regards, -- Luc

Re: [PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

2024-01-08 Thread Neil Armstrong
On 08/01/2024 16:25, Alexander Stein wrote: The bridge type was set to default (Unknown). Set proper bridge type. With this fixed, debugfs output imx8mp looks proper. $ cat /sys/kernel/debug/dri/1/encoder-0/bridges bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] type: [0] Unknown

Re: (subset) linux-next: build failure after merge of the pwm tree

2024-01-08 Thread Lee Jones
On Fri, 05 Jan 2024, Stephen Rothwell wrote: > Hi all, > > On Thu, 4 Jan 2024 12:50:28 + Sean Young wrote: > > > > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > > > On Thu, Dec 21, 2023 at 07:34:57P

Re: [PATCH linux-next] drm/nouveau/disp: switch to use kmemdup() helper

2024-01-08 Thread Danilo Krummrich
Hi Yang, On 12/14/23 13:03, yang.gua...@zte.com.cn wrote: From: Yang Guang Use kmemdup() helper instead of open-coding to simplify the code. Signed-off-by: Chen Haonan Please add your "Signed-off-by" tag to this patch. If the above is intended to indicate that Chan was involved in creatin

Re: [PATCH] drm/nouveau/fifo: remove duplicated including

2024-01-08 Thread Danilo Krummrich
Hi Wang, there is another patch [1] to fix this, which already made it upstream. - Danilo [1] https://patchwork.freedesktop.org/patch/msgid/20231122004926.84933-1-yang@linux.alibaba.com On 12/15/23 11:02, Wang Jinchao wrote: rm second including of chid.h Signed-off-by: Wang Jinchao ---

Re: [PATCH 1/2] drm: update drm_show_memory_stats() for dma-bufs

2024-01-08 Thread Rob Clark
On Thu, Dec 7, 2023 at 10:02 AM Alex Deucher wrote: > > Show buffers as shared if they are shared via dma-buf as well > (e.g., shared with v4l or some other subsystem). > > Signed-off-by: Alex Deucher > Cc: Rob Clark Reviewed-by: Rob Clark > --- > drivers/gpu/drm/drm_file.c | 2 +- > 1 file

Re: [PATCH] drm/nouveau/bios/init: drop kernel-doc notation

2024-01-08 Thread Danilo Krummrich
On 12/16/23 21:11, Randy Dunlap wrote: The "/**" comments in this file are not kernel-doc comments. They are used on static functions which can have kernel-doc comments, but that is not the primary focus of kernel-doc comments. Since these comments are incomplete for kernel-doc notation, remove t

Re: [PATCH] drm/amd/display: cleanup inconsistent indenting in amdgpu_dm_color

2024-01-08 Thread Rodrigo Siqueira Jordao
On 1/5/24 15:02, Melissa Wen wrote: smatch warnings: amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401051643.ppdbmg1u-...@intel.com/ Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/displ

Re: [PATCH 1/4] drm/nouveau/disp: don't misuse kernel-doc comments

2024-01-08 Thread Danilo Krummrich
On 1/1/24 00:36, Randy Dunlap wrote: Change kernel-doc "/**" comments to common "/*" comments to prevent kernel-doc warnings: crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Sets up registers for the given mod

Re: [PATCH v2] drm/amdkfd: fixes for HMM mem allocation

2024-01-08 Thread Felix Kuehling
On 2024-01-07 08:07, Dafna Hirschfeld wrote: Fix err return value and reset pgmap->type after checking it. Fixes: c83dee9b6394 ("drm/amdkfd: add SPM support for SVM") Reviewed-by: Felix Kuehling Signed-off-by: Dafna Hirschfeld --- v2: remove unrelated DOC fix and add 'Fixes' tag. Thank you

Re: [PATCH v3 3/4] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2024-01-08 Thread Carl Vanderlip
On 1/5/2024 4:38 PM, Dmitry Baryshkov wrote: On Sat, 6 Jan 2024 at 02:04, Carl Vanderlip wrote: On 1/5/2024 3:34 PM, Dmitry Baryshkov wrote: diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 50b65ffc24b1..ef57586fbeca 100644 --- a/drivers/gpu/drm/msm/msm_drv

Re: [PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-08 Thread Danilo Krummrich
On 1/4/24 21:16, Jani Nikula wrote: Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freed

Re: [PATCH v3 2/4] drm/panel: Add driver for BOE TH101MB31IG002-28A panel

2024-01-08 Thread Jessica Zhang
On 1/2/2024 8:15 AM, Manuel Traut wrote: From: Alexander Warnecke The BOE TH101MB31IG002-28A panel is a WXGA panel. It is used in Pine64 PineTab2 and PineTab-V. Signed-off-by: Alexander Warnecke Signed-off-by: Manuel Traut --- drivers/gpu/drm/panel/Kconfig | 11 +

[PATCH RFC v2 07/11] ARM: dts: AM437x: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base AM437x dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/am4372.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/ti/omap/am4372.dtsi b/arch/arm/boot/dts/ti/omap/am4372.dtsi index 9d2c064534f7d..5fd1b380ece62 100

[PATCH RFC v2 05/11] ARM: dts: omap5: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base OMAP5 dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/omap5.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/ti/omap/omap5.dtsi b/arch/arm/boot/dts/ti/omap/omap5.dtsi index bac6fa8387936..6a

[PATCH RFC v2 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2024-01-08 Thread Andrew Davis
The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from multiple vendors. Describe how the SGX GPU is integrated in these SoC, including register space and interrupts. Clocks, reset, and power domain information is SoC specific. Signed-off-by: Andrew Davis --- .../bindings/gpu/img

[PATCH RFC v2 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue

2024-01-08 Thread Andrew Davis
Signed-off-by: Andrew Davis --- .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++-- MAINTAINERS | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,po

[PATCH RFC v2 10/11] ARM: dts: sun6i: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base sun6i-a31 dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/allwinner/sun6i-a31.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/allwinner/sun6i-a31.dtsi b/arch/arm/boot/dts/allwinner/sun6i-a31.dtsi index 5cce4918f84

[PATCH RFC v2 09/11] arm64: dts: ti: k3-am654-main: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base AM654 dtsi file. Signed-off-by: Andrew Davis --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index fcea544656360..64b52c8d

[PATCH RFC v2 06/11] ARM: dts: AM33xx: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base AM33xx dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/am33xx.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/ti/omap/am33xx.dtsi b/arch/arm/boot/dts/ti/omap/am33xx.dtsi index 5b9e01a8aa5d5

[PATCH RFC v2 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base DRA7x dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/dra7.dtsi | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi index 6509c742fb58c..852764

[PATCH RFC v2 11/11] MIPS: DTS: jz4780: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base jz4780 dtsi file. Signed-off-by: Andrew Davis --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index 18a85ce38..5ea6833

[PATCH RFC v2 00/11] Device tree support for Imagination Series5 GPU

2024-01-08 Thread Andrew Davis
for Series6+, but otherwise most is the same as we have been using in our vendor tree for many years. Thanks, Andrew Based on next-20240108. [0]: https://lkml.org/lkml/2020/4/24/1222 [1]: https://github.com/openpvrsgx-devgroup Changes for RFC v2: - Added patch to rename Rogue+ binding to img

[PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entry to base OMAP4 dtsi file. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/omap4.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/ti/omap/omap4.dtsi b/arch/arm/boot/dts/ti/omap/omap4.dtsi index 2bbff9032be3e..55

[PATCH RFC v2 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU

2024-01-08 Thread Andrew Davis
Add SGX GPU device entries to base OMAP3 dtsi files. Signed-off-by: Andrew Davis --- arch/arm/boot/dts/ti/omap/am3517.dtsi | 11 ++- arch/arm/boot/dts/ti/omap/omap34xx.dtsi | 11 ++- arch/arm/boot/dts/ti/omap/omap36xx.dtsi | 9 + 3 files changed, 17 insertions(+), 14 d

Re: [PATCH v3 3/4] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2024-01-08 Thread Dmitry Baryshkov
On Mon, 8 Jan 2024 at 19:57, Carl Vanderlip wrote: > > > > On 1/5/2024 4:38 PM, Dmitry Baryshkov wrote: > > On Sat, 6 Jan 2024 at 02:04, Carl Vanderlip wrote: > >> > >> > >> On 1/5/2024 3:34 PM, Dmitry Baryshkov wrote: > >>> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv

Re: [PATCH 7/7] drm/vkms: Create KUnit tests for YUV conversions

2024-01-08 Thread Arthur Grillo
On 08/01/24 07:15, Maxime Ripard wrote: > Hi Arthur, > > On Fri, Jan 05, 2024 at 01:35:08PM -0300, Arthur Grillo wrote: >> diff --git a/drivers/gpu/drm/vkms/vkms_formats.c >> b/drivers/gpu/drm/vkms/vkms_formats.c >> index b654b6661a20..11df990a0fa9 100644 >> --- a/drivers/gpu/drm/vkms/vkms_for

  1   2   >