Re: [PATCH] drm/vmwgfx: Unmap the surface before resetting it on a plane state

On 12/23/23 21:25, Zack Rusin wrote: > Switch to a new plane state requires unreferencing of all held surfaces. > In the work required for mob cursors the mapped surfaces started being > cached but the variable indicating whether the surface is currently > mapped was not being reset. This leads to

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

Hello Manuel, a few more things I noticed: On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > From: Alexander Warnecke > > + leds { > + compatible = "gpio-leds"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&flash_led_en_h>; > + > +

[PATCH v2 00/39] drm/bridge: switch to struct drm_edid

Convert all of drm/bridge to the new struct drm_edid infrastructure. It's safer than struct edid, because it contains meta information about the allocated size of the EDID, instead of relying on the size (number of extensions) originating from outside of the kernel. Among all of drm, I think bridg

[PATCH v2 01/39] drm/bridge: add ->edid_read hook and drm_bridge_edid_read()

Add new struct drm_edid based ->edid_read hook and drm_bridge_edid_read() function to call the hook. v2: Include drm/drm_edid.h Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 46 +++- include/drm/drm_bridge.h | 33 ++ 2

[PATCH v2 02/39] drm/bridge: switch to drm_bridge_read_edid()

Prefer using the struct drm_edid based functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge_connector.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c index 3acd

[PATCH v2 03/39] drm/bridge: chrontel-ch7033: switch to drm_bridge_read_edid()

Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 ++-- 1 file changed, 6 insertions(+), 6 del

[PATCH v2 04/39] drm/bridge: lt8912b: use drm_bridge_read_edid()

Prefer using the struct drm_edid based functions. cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 12 ++-- 1 file changed, 6

[PATCH v2 05/39] drm/bridge: lt8912b: clear the EDID property on failures

If EDID read fails, clear the EDID property. Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 06/39] drm/bridge: lt8912b: use ->edid_read callback

Prefer using the struct drm_edid based functions. Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 8 1 file changed, 4 inse

[PATCH v2 08/39] drm: bridge: simple-bridge: use drm_bridge_edid_read()

Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/simple-bridge.c | 16 1 file changed, 8 insertions(+), 8 d

[PATCH v2 07/39] drm/bridge: lt9611uxc: use drm_bridge_read_edid()

Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 10 +- 1 file changed, 5 insertions(+), 5 del

[PATCH v2 09/39] drm: bridge: simple-bridge: clear the EDID property on failures

If EDID read fails, clear the EDID property. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/simple-bridge.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH v2 10/39] drm/bridge: tfp410: use drm_bridge_edid_read()

Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-tfp410.c | 16 1 file changed, 8 insertions(+), 8 delet

[PATCH v2 11/39] drm/bridge: tfp410: clear the EDID property on failures

If EDID read fails, clear the EDID property. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v2 12/39] drm/meson: switch to drm_bridge_edid_read()

Prefer using the struct drm_edid based functions. Not ideal, should use source physical address from connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v2 13/39] drm/bridge: remove drm_bridge_get_edid() in favour of drm_bridge_edid_read()

All users of drm_bridge_get_edid() have been converted to use drm_bridge_edid_read(). Remove drm_bridge_get_edid(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 28 ++-- include/drm/drm_bridge.h | 2 -- 2 files changed, 2 insertions(+), 28 deletions(

[PATCH v2 15/39] drm/bridge: cdns-mhdp8546: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu

[PATCH v2 16/39] drm/bridge: cdns-mhdp8546: clear the EDID property on failures

If EDID read fails, clear the EDID property. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp85

[PATCH v2 14/39] drm/bridge: anx7625: switch to ->edid_read callback

Prefer using the struct drm_edid based callback. v2: Fix build (goto out;) Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/analogix/anx7625.c | 30 --- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/

[PATCH v2 17/39] drm/bridge: display-connector: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/display-connector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connec

[PATCH v2 19/39] drm: bridge: it66121: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ite-it66121.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c ind

[PATCH v2 18/39] drm/bridge: it6505: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ite-it6505.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index

[PATCH v2 20/39] drm/bridge: lt9611: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c ind

[PATCH v2 21/39] drm/bridge: lt9611uxc: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611

[PATCH v2 22/39] drm/bridge: megachips: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- .../bridge/megachips-stdp-ge-b850v3-fw.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/

[PATCH v2 23/39] drm/bridge: nxp-ptn3460: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3

[PATCH v2 24/39] drm/bridge: sii902x: use display info is_hdmi

Use the pre-parsed information instead of parsing EDID again. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/sii902x.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 2bdc5b439beb..2f876b

[PATCH v2 25/39] drm/bridge: sii902x: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/sii902x.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c

[PATCH v2 26/39] drm/mediatek/dp: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/mediatek/mtk_dp.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_

[PATCH v2 27/39] drm/mediatek/hdmi: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hd

[PATCH v2 28/39] drm/msm/hdmi: fix indent

Remove the excess leading tabs. Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c index f5e01471b0b0..f28c61570533

Re: [PATCH v2 00/39] drm/bridge: switch to struct drm_edid

On Wed, 03 Jan 2024, Jani Nikula wrote: > Convert all of drm/bridge to the new struct drm_edid > infrastructure. It's safer than struct edid, because it contains meta > information about the allocated size of the EDID, instead of relying on > the size (number of extensions) originating from outsid

[PATCH v2 29/39] drm/msm/hdmi: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdm

[PATCH v2 30/39] drm/omap/hdmi4: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c

[PATCH v2 31/39] drm/omap/hdmi5: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index e661

[PATCH v2 32/39] drm: xlnx: zynqmp_dpsub: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index a0606fab0e22..24213

[PATCH v2 33/39] drm: adv7511: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 47 +--- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/br

[PATCH v2 34/39] drm: bridge: dw_hdmi: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridg

[PATCH v2 35/39] drm: bridge: dw_hdmi: clear the EDID property and CEC address on failures

If EDID read fails, clear the EDID property and CEC address. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 8ce85e973b38..65

[PATCH v2 36/39] drm/bridge: tc358767: update the EDID property

The EDID property should be updated between reading the EDID and adding the modes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/tc358767.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index eb0d82a91cb9..da2ae

[PATCH v2 37/39] drm/bridge: tc358767: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/tc358767.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index da2a

[PATCH v2 38/39] drm/bridge: ti-sn65dsi86: switch to ->edid_read callback

Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 62c

[PATCH v2 39/39] drm/bridge: remove ->get_edid callback

There are no more users of the ->get_edid callback left. They've all been converted to ->edid_read. Remove the callback, and the fallback in drm_bridge_edid_read(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 19 --- include/drm/drm_bridge.h | 30 ---

Re: [PATCH 0/2] drm/bridge: start moving towards struct drm_edid

On Fri, 22 Dec 2023, Jani Nikula wrote: > Okay, I rebased and pushed [1]. Probably doesn't make sense to send a > patch bomb like that right now... And here are the patches: https://patchwork.freedesktop.org/series/128149/ BR, Jani. > > BR, > Jani. > > > [1] https://gitlab.freedesktop.org/jan

[PATCH 1/4] drm/hyperv: Remove firmware framebuffers with aperture helper

Replace use of screen_info state with the correct interface from the aperture helpers. The state is only for architecture and firmware code. It is not guaranteed to contain valid data. Drivers are thus not allowed to use it. For removing conflicting firmware framebuffers, there are aperture helper

[PATCH 0/4] hyperv, sysfb: Do not use screen_info in drivers

The global screen_info state is only meant for architecture and firmware code. Replace its use in hyperv graphics drivers with the correct aperture helpers. Patches 1 and 2 update hyperv-drm and hyperv-fb to use the correct aperture helpers instead of screen_info for removing existing firmware fra

[PATCH 2/4] fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers

Replace use of screen_info state with the correct interfaces from the aperture helpers. The state is only for architecture and firmware code. It is not guaranteed to contain valid data. Drivers are thus not allowed to use it. For removing conflicting firmware framebuffers, there are aperture helpe

[PATCH 3/4] firmware/sysfb: Clear screen_info state after consuming it

After consuming the global screen_info_state in sysfb_init(), the created platform device maintains the firmware framebuffer. Clear screen_info to avoid conflicting access. Subsequent kexec reboots now ignore the firmware framebuffer. Signed-off-by: Thomas Zimmermann --- drivers/firmware/sysfb.c

[PATCH 4/4] fbdev/hyperv_fb: Do not clear global screen_info

Do not clear the global instance of screen_info. If necessary, clearing fields in screen_info should be done by architecture or firmware code that maintains the firmware framebuffer. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/hyperv_fb.c | 9 + 1 file changed, 1 insertion(+

Re: [PATCH v2 02/39] drm/bridge: switch to drm_bridge_read_edid()

Hi Jani > drm/bridge: switch to drm_bridge_read_edid() Did you mean drm_bridge_edid_read(), here and in the other patches? (Personally, I'd prefer read_edid over edid_read. The former is common style and easier to read.) Best regards Thomas Am 03.01.24 um 11:08 schrieb Jani Nikula: Prefer

Re: [PATCH] drm/vmwgfx: Unmap the surface before resetting it on a plane state

Great catch! That was a nasty one. Reviewed-by: Martin Krastev Regards, Martin On Sun, Dec 24, 2023 at 7:29 AM Zack Rusin wrote: > Switch to a new plane state requires unreferencing of all held surfaces. > In the work required for mob cursors the mapped surfaces started being > cached but the

RE: [PATCH 1/7] drm: Add eDP 1.5 early transport definition

> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Monday, December 18, 2023 7:50 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH 1/7] drm: Add eDP 1.5 early transport definition > > Add DP_PSR_ENABLE_SU_REGION_ET

[PULL] drm-misc-fixes

Hi Dave, Daniel, Happy new year! ~Maarten drm-misc-fixes-2024-01-03: drm-misc-fixes for v6.7 final: - 2 small qaic fixes. - Fixes for overflow in aux xfer. - Fix uninitialised gamma lut in gmag200. - Small compiler warning fix for backports of a ps8640 fix. The following changes since commit 6c

Re: [PATCH v2 02/39] drm/bridge: switch to drm_bridge_read_edid()

On Wed, 03 Jan 2024, Thomas Zimmermann wrote: > Hi Jani > > > drm/bridge: switch to drm_bridge_read_edid() > > Did you mean drm_bridge_edid_read(), here and in the other patches? Ah, yeah, I did. > (Personally, I'd prefer read_edid over edid_read. The former is common > style and easier to rea

[PATCH] drm/xe: circumvent bogus stringop-overflow warning

From: Arnd Bergmann gcc-13 warns about an array overflow that it sees but that is prevented by the "asid % NUM_PF_QUEUE" calculation: drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler': include/linux/fortify-string.h:57:33: error: writing 16 bytes into a region of size

[PATCH] fbdev/sis: Remove dependency on screen_info

When built-in, the sis driver tries to detect the current display mode from the global screen_info state. That state is only for architecture and firmware code. Drivers should not use it directly as it's not guaranteed to contain valid information. Remove the mode-detection code from sis. Drivers

Re: [PATCH v4 6/6] x86/vmware: Add TDX hypercall support

On Thu, Dec 28, 2023 at 11:24:21AM -0800, Alexey Makhalov wrote: > From: Alexey Makhalov > > VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. > Add __tdx_hypercall path to support TDX guests. > > No change in high bandwidth hypercalls, as only low bandwidth > ones are supported fo

AD107M (197), black screen

Hi all, i am testing current mainline (6.7.rc8), on a lenovo legion, with AD107M (chipset 197000a1). Looks like somewhere at driver probe, screen turns black and stays forever. If any hint, welcome. I can help debugging, rebuilding and testing in case. Regards, Angelo Dureghello

Re: [PATCH -next] drm/xe: Remove unneeded semicolon

Hi, Yang, On Wed, 2024-01-03 at 09:15 +0800, Yang Li wrote: > ./drivers/gpu/drm/xe/xe_rtp.c:168:2-3: Unneeded semicolon > Could you please reformulate using imperative "Remove..." rather than citing a style alert? With that, Reviewed-by: Thomas Hellström > Signed-off-by: Yang Li > --- >  dr

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

On Tue, Jan 02, 2024 at 07:07:56PM +0100, Ondřej Jirman wrote: > Hello Manuel, Hello Ondřej, > On Tue, Jan 02, 2024 at 05:15:47PM +0100, Manuel Traut wrote: > > From: Alexander Warnecke > > > > [...] > > > > + > > + backlight: backlight { > > + compatible = "pwm-backlight"; > > +

[PATCH 0/2] drm/bridge: sii902x: Crash fixes

changed, 29 insertions(+), 13 deletions(-) --- base-commit: 0c75d52190b8bfa22cdb66e07148aea599c4535d change-id: 20240103-si902x-fixes-468d7153b8ee Best regards, -- Tomi Valkeinen

[PATCH 1/2] drm/bridge: sii902x: Fix probing race issue

A null pointer dereference crash has been observed rarely on TI platforms using sii9022 bridge: [ 53.271356] sii902x_get_edid+0x34/0x70 [sii902x] [ 53.276066] sii902x_bridge_get_edid+0x14/0x20 [sii902x] [ 53.281381] drm_bridge_get_edid+0x20/0x34 [drm] [ 53.286305] drm_bridge_connector_

[PATCH 2/2] drm/bridge: sii902x: Fix audio codec unregistration

The driver never unregisters the audio codec platform device, which can lead to a crash on module reloading, nor does it handle the return value from sii902x_audio_codec_init(). Signed-off-by: Tomi Valkeinen Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") Cc: Jyri Sarha

AD107M (197), black screen

Hi all, i am testing current mainline (6.7.rc8), on a lenovo legion, with AD107M (chipset 197000a1). Looks like somewhere at driver probe, screen turns black and stays forever. If any hint, welcome. I can help debugging, rebuilding and testing in case. Regards, Angelo Dureghello

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

Hi Jonas and Ondřej, > >> +&sfc { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&fspi_dual_io_pins>; > >> + status = "okay"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + flash@0 { > >> + compatible = "jedec,spi-nor"; > >> + reg = <0>; > >> +

Re: [PATCH v9 09/25] drm/modes: Move named modes parsing to a separate function

Hi Dave, Happy new year :) On Tue, Jan 02, 2024 at 03:12:26PM +, Dave Stevenson wrote: > Hi Maxime > > On Mon, 14 Nov 2022 at 13:00, Maxime Ripard wrote: > > > > The current construction of the named mode parsing doesn't allow to extend > > it easily. Let's move it to a separate function so

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

On Tue, 2023-12-26 at 13:30 -0500, Rodrigo Vivi wrote: > On Fri, Dec 22, 2023 at 12:36:39PM +0100, Thomas Hellström wrote: > > Add the xe repo to drm-tip and the dim tools. > > For now use the sha1 of the first drm-xe-next pull request for drm- > > tip, > > since that branch tip is currently adapte

Re: [PATCH v9 09/25] drm/modes: Move named modes parsing to a separate function

Hi Maxime On Wed, 3 Jan 2024 at 13:33, Maxime Ripard wrote: > > Hi Dave, > > Happy new year :) And to you. > On Tue, Jan 02, 2024 at 03:12:26PM +, Dave Stevenson wrote: > > Hi Maxime > > > > On Mon, 14 Nov 2022 at 13:00, Maxime Ripard wrote: > > > > > > The current construction of the name

[PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()

From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

Re: [PATCH] drm/amdkfd: fixes for HMM mem allocation

On Sun, Dec 31, 2023 at 9:39 AM Dafna Hirschfeld wrote: > > Few fixes to amdkfd and the doc of > devm_request_free_mem_region. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 6 +++--- > kernel/resource.c| 2 +- > 2 files changed, 4

Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

Hi Manuel, On 2024-01-03 14:40, Manuel Traut wrote: > Hi Jonas and Ondřej, > +&sfc { + pinctrl-names = "default"; + pinctrl-0 = <&fspi_dual_io_pins>; + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compati

Re: [PATCH] drm/amd/pm/smu7: fix a memleak in smu7_hwmgr_backend_init

Applied. Thanks! On Mon, Dec 25, 2023 at 5:18 AM Zhipeng Lu wrote: > > The hwmgr->backend, (i.e. data) allocated by kzalloc is not freed in > the error-handling paths of smu7_get_evv_voltages and > smu7_update_edc_leakage_table. However, it did be freed in the > error-handling of phm_initializa_

Re: [RFC PATCH] drm/amd/display: fix bandwidth validation failure on DCN 2.1

On 12/29/23 11:25, Melissa Wen wrote: IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of the test execution, during atomic check, because DC rejects the bandwidth state for a fb sizing 64x64. The test was previously working with the deprecated dc_commit_state(). Now using dc

Re: [PATCH 08/11] nouveau/gsp: don't free ctrl messages on errors

Hi Dave, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dave-Airlie/nouveau-gsp-drop-some-acpi-related-debug/20231222-180432 base: git://anongit.freedesktop.org/dr

Re: [PATCH] drm/amd/display: avoid stringop-overflow warnings for dp_decide_lane_settings()

Applied. Thanks! On Mon, Dec 25, 2023 at 5:30 AM Randy Dunlap wrote: > > > > On 11/22/23 14:13, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc prints a warning about a possible array overflow for a couple of > > callers of dp_decide_lane_settings() after commit 1b56c90018f0 ("Makefile

Re: [syzbot] [dri?] WARNING in drm_prime_destroy_file_private (2)

Am 28.12.23 um 03:57 schrieb Qi Zheng: On 2023/12/28 04:51, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:    5254c0cbc92d Merge tag 'block-6.7-2023-12-22' of git://git.. git tree:   upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=10cc6995e800

Re: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection

On 2023-12-26 10:38, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Dec 2023 08:44:37 +0100 > > The kfree() function was called in one case by the > drm_property_create() function during error handling > even if the passed data structure member contained a null pointer. > This issue

Re: [RFC PATCH] drm/amd/display: fix bandwidth validation failure on DCN 2.1

On Wed, Jan 03, 2024 at 09:44:18AM -0500, Hamza Mahfooz wrote: > On 12/29/23 11:25, Melissa Wen wrote: > > IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of > > the test execution, during atomic check, because DC rejects the > > bandwidth state for a fb sizing 64x64. The test

Re: [PATCH] drivers/accel/habanalabs: Remove unnecessary braces from if statement

On 28/12/2023 23:08, Malkoot Khan wrote: The coding style in the Linux kernel prefers not to use braces for single-statement if conditions. This patch removes the unnecessary braces from an if statement in the file drivers/accel/habanalabs/common/command_submission.c, which also resolves a coding

Re: [PATCH v4 2/6] x86/vmware: Introduce VMware hypercall API

On Thu, Dec 28, 2023 at 11:24:17AM -0800, Alexey Makhalov wrote: > From: Alexey Makhalov > > Introduce vmware_hypercall family of functions. It is a common > implementation to be used by the VMware guest code and virtual > device drivers in architecture independent manner. > > The API consists o

Re: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection

>> The kfree() function was called in one case by the >> drm_property_create() function during error handling >> even if the passed data structure member contained a null pointer. >> This issue was detected by using the Coccinelle software. >> >> Thus use another label. … >> +++ b/drivers/gpu/drm/d

Re: [PATCH v9 09/25] drm/modes: Move named modes parsing to a separate function

On Wed, 3 Jan 2024 at 14:02, Dave Stevenson wrote: > > Hi Maxime > > On Wed, 3 Jan 2024 at 13:33, Maxime Ripard wrote: > > > > Hi Dave, > > > > Happy new year :) > > And to you. > > > On Tue, Jan 02, 2024 at 03:12:26PM +, Dave Stevenson wrote: > > > Hi Maxime > > > > > > On Mon, 14 Nov 2022 a

Re: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection

On 2024-01-03 17:24, Markus Elfring wrote: > >> Out of curiosity, what exactly did Coccinelle report? > > Some SmPL scripts from my own selection tend to point questionable > implementation details out. That doesn't answer my question. Without seeing the actual Coccinelle report, I'll assume t

Re: [PATCH linux-next v2] drm/panel: Simplify with dev_err_probe()

On 12/25/2023 6:26 AM, chenguanxi11...@163.com wrote: From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu/

Re: [PATCH linux-next] drm/panel: samsung: Simplify with dev_err_probe()

On 1/3/2024 6:17 AM, chenguanxi11...@163.com wrote: From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu/dr

Re: [1/3] drm: property: One function call less in drm_property_create() after error detection

>>> Out of curiosity, what exactly did Coccinelle report? >> >> Some SmPL scripts from my own selection tend to point questionable >> implementation details out. > > That doesn't answer my question. It should. > Without seeing the actual Coccinelle report, There is no “official” report accordi

[PATCH] drm/rockchip: analogix_dp: get encoder port ID from DT

The VOP2 driver needs this port ID to properly configure the display data routing. Signed-off-by: Lucas Stach --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/ana

Re: [PATCH] drm/msm/a7xx: Fix LLC typo

On Tue, Jan 2, 2024 at 12:12 PM Konrad Dybcio wrote: > > On 2.01.2024 20:33, Rob Clark wrote: > > From: Rob Clark > > > > We'd miss actually activating LLC. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v2 23/39] drm/bridge: nxp-ptn3460: switch to ->edid_read callback

Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.7-rc8 next-20240103] [cannot apply to drm

Re: [PATCH v1 1/1] drm/virtio: Spelling fixes

On 12/19/23 18:19, Andy Shevchenko wrote: > While making a spelling mistake myself for `git grep kvalloc` > I found that the only file has such a typo. Fix it and update > to the standard de facto of how we refer to the functions. > Also spell usr-out as user-out, it seems this driver uses its > ow

Re: [PATCH 1/1] drm/virtio: Implement RESOURCE_GET_LAYOUT ioctl

On 12/21/23 13:00, Julia Zhang wrote: > From: Daniel Stone > > Add a new ioctl to allow the guest VM to discover how the guest > actually allocated the underlying buffer, which allows buffers to > be used for GL<->Vulkan interop and through standard window systems. > It's also a step towards prop

Re: [PATCH 08/11] nouveau/gsp: don't free ctrl messages on errors

On Thu, 4 Jan 2024 at 00:47, Dan Carpenter wrote: > > Hi Dave, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Dave-Airlie/nouveau-gsp-drop-some-acpi-rela

[git pull] drm fixes for 6.8

Hi Linus, These were from over the holiday period, mainly i915, a couple of qaic, bridge and an mgag200. I have a set of nouveau fixes that I'll send after this, that might be too rich for you at this point. I expect there might also be some more regular fixes before 6.8, but they should be mino

Re: [PATCH] [v2] drm/vmwgfx: fix a memleak in vmw_gmrid_man_get_node

On Mon, Dec 4, 2023 at 4:15 AM Zhipeng Lu wrote: > > When ida_alloc_max fails, resources allocated before should be freed, > including *res allocated by kmalloc and ttm_resource_init. > > Fixes: d3bcb4b02fe9 ("drm/vmwgfx: switch the TTM backends to self alloc") > Signed-off-by: Zhipeng Lu > --- >

Re: [PATCH] drm/vmwgfx: fix kernel-doc Excess struct member 'base'

On Fri, Dec 15, 2023 at 6:56 PM Randy Dunlap wrote: > > Fix a new kernel-doc warning reported by kernel test robot: > > vmwgfx_surface.c:55: warning: Excess struct member 'base' description in > 'vmw_user_surface' > > The other warning is not correct: it is confused by "__counted_by". > Kees has

Re: [PATCH V2] drivers: gpu: drm: vmwgfx: fixed typos

On Fri, Dec 15, 2023 at 1:21 AM Randy Dunlap wrote: > > Hi-- > > On 12/14/23 22:01, Ghanshyam Agrawal wrote: > > Fixed multiple typos in vmwgfx_execbuf.c > > > > Signed-off-by: Ghanshyam Agrawal > > --- > > V2: > > Fixed some more typos suggested by codespell > > and the community. > > > > V1: >

Re: [PATCH v2 34/39] drm: bridge: dw_hdmi: switch to ->edid_read callback

Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.7-rc8 next-20240103] [cannot apply to drm

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

On Wed, Jan 03, 2024 at 02:50:57PM +0100, Thomas Hellström wrote: On Tue, 2023-12-26 at 13:30 -0500, Rodrigo Vivi wrote: On Fri, Dec 22, 2023 at 12:36:39PM +0100, Thomas Hellström wrote: > Add the xe repo to drm-tip and the dim tools. > For now use the sha1 of the first drm-xe-next pull request

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

  1   2   >