Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 08:56, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 07:10]: >> On 04/12/2023 19:22, Andrew Davis wrote: >>> @@ -56,6 +76,43 @@ allOf: >>>properties: >>> clocks: >>>maxItems: 1 >>> + required: >>> +- clocks >>> +- clock-names >

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-05 Thread Boris Brezillon
Hi Clément, On Mon, 4 Dec 2023 19:09:54 +0100 Clément Péron wrote: > Hi Boris, > > On Mon, 4 Dec 2023 at 18:33, Boris Brezillon > wrote: > > > > Hello, > > > > This is the 3rd version of the kernel driver for Mali CSF-based GPUs. > > > > With all the DRM dependencies being merged (drm-sched si

[Bug 218221] Nouveau GSP fail on command cli:0xc1d0000

2023-12-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218221 --- Comment #3 from marc barbier (mmarc...@gmail.com) --- (In reply to airlied from comment #2) > Can't remember my bz, but all those errors are fine, I've sent patches > to clean them up so we don't report them in dmesg anymore. > > On Tue, 5 De

Re: [PATCH v3 06/10] drm/panel: Add Synaptics R63353 panel driver

2023-12-05 Thread Neil Armstrong
Hi Dario, On 30/11/2023 15:16, Dario Binacchi wrote: From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Adjust the timing

Re: [PATCH v3 08/10] drm/panel: Add Ilitek ILI9805 panel driver

2023-12-05 Thread Neil Armstrong
Hi Dario, On 30/11/2023 15:16, Dario Binacchi wrote: From: Michael Trimarchi The GPM1790A0 panel is based on the Ilitek ILI9805 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) MAINTAINERS

Re: [PATCH v3 09/10] drm/panel: ilitek-ili9805: add support for Tianma TM041XDHG01 panel

2023-12-05 Thread Neil Armstrong
On 30/11/2023 15:16, Dario Binacchi wrote: From: Michael Trimarchi Tianma TM041XDHG01 utilizes the Ilitek ILI9805 controller. Add this panel's initialzation sequence and timing to ILI9805 driver. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) dr

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:03]: > What does runtime PM have to do with it? If runtime PM enables clocks, > these are real signals and not optional. Runtime PM propagates to the parent device. Regards, Tony

Re: [PATCH 2/2] drm/panel: simple: Add BOE BP101WX1-100 panel

2023-12-05 Thread Neil Armstrong
On 27/11/2023 06:15, Tony Lindgren wrote: This panel is found on Motorola mapphone tablets from mz615 to mz617. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-

Re: [PATCH 3/3] drm/panel: ilitek-ili9881c: Add Ampire AM8001280G LCD panel

2023-12-05 Thread Neil Armstrong
On 23/11/2023 18:08, Philipp Zabel wrote: Add support for Ampire AM8001280G LCD panels. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 223 ++ 1 file changed, 223 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c

Re: [PATCH 1/3] drm/panel: ilitek-ili9881c: make use of prepare_prev_first

2023-12-05 Thread Neil Armstrong
On 23/11/2023 18:08, Philipp Zabel wrote: From: Marco Felsch The panel.prepare() call requires an initialized MIPI-DSI host, so set the prepare_prev_first flag to indicate that the host must be initialized first. Signed-off-by: Marco Felsch Signed-off-by: Philipp Zabel --- drivers/gpu/drm/

Re: [PATCH 2/2] drm/panel-simple: add Evervision VGG644804 panel entry

2023-12-05 Thread Neil Armstrong
On 23/11/2023 11:24, Michael Walle wrote: Timings taken from the datasheet, although sometimes there are just typical values and it's not clear if they are no min and max values or if you must use the typical value exactly. To make things worse, there is no back porch but only a combined sync and

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 09:10, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 08:03]: >> What does runtime PM have to do with it? If runtime PM enables clocks, >> these are real signals and not optional. > > Runtime PM propagates to the parent device. Then it is not really relevant to the hardware t

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
Hi Andrew, > Am 04.12.2023 um 19:22 schrieb Andrew Davis : > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > multiple vendors. Great and thanks for the new attempt to get at least the Device Tree side upstream. Really appreciated! > Describe how the SGX GPU is integra

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : > > On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: >> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from >> multiple vendors. Describe how the SGX GPU is integrated in these SoC, >> including register space and

Re: [PATCH 1/2] dt-bindings: display: simple: Add boe,bp101wx1-100 panel

2023-12-05 Thread Neil Armstrong
Hi, On Mon, 27 Nov 2023 07:15:43 +0200, Tony Lindgren wrote: > This panel is found on Motorola mapphone tablets mz615 to mz617. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] dt-bindings: display: simple: Add boe,bp101wx1-100 panel htt

Re: [PATCH V2 00/10] rockchip: Add Powkiddy X55

2023-12-05 Thread Neil Armstrong
Hi, On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porc

Re: [PATCH 1/2] dt-bindings: display: simple: add Evervision VGG644804 panel

2023-12-05 Thread Neil Armstrong
Hi, On Thu, 23 Nov 2023 11:24:03 +0100, Michael Walle wrote: > Add Evervision VGG644804 5.7" 640x480 LVDS panel compatible string. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] dt-bindings: display: simple: add Evervision VGG644804 panel

Re: [PATCH 0/3] drm/panel: ilitek-ili9881c: Support Ampire AM8001280G LCD panel

2023-12-05 Thread Neil Armstrong
Hi, On Thu, 23 Nov 2023 18:08:04 +0100, Philipp Zabel wrote: > Add support for Ampire AM8001280G LCD panels to the Ilitek ILI9881C > driver. > > Also set prepare_prev_first, to make sure that the DSI host controller > is initialized to LP-11 before the panel is powered up. Tested to work > with s

Re: [PATCH V2 00/10] rockchip: Add Powkiddy X55

2023-12-05 Thread Neil Armstrong
On 05/12/2023 09:26, Neil Armstrong wrote: Hi, On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: From: Chris Morgan Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming console. Changes since V1: - Corrected a bug with the DRM mode flags for the video driver. - Ad

Re: [PATCH] drm/bridge: nxp-ptn3460: fix i2c_master_send() error checking

2023-12-05 Thread Neil Armstrong
On 04/12/2023 17:59, Dan Carpenter wrote: On Mon, Dec 04, 2023 at 02:53:05PM +0100, Neil Armstrong wrote: On 04/12/2023 13:29, Dan Carpenter wrote: The i2c_master_send/recv() functions return negative error codes or the number of bytes that were able to be sent/received. This code has two prob

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:16]: > On 05/12/2023 09:10, Tony Lindgren wrote: > > * Krzysztof Kozlowski [231205 08:03]: > >> What does runtime PM have to do with it? If runtime PM enables clocks, > >> these are real signals and not optional. > > > > Runtime PM propagates to the parent device

Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

2023-12-05 Thread Neil Armstrong
Hi, On Mon, 04 Dec 2023 08:27:36 +0100, Arnd Bergmann wrote: > A dependency on this feature was recently introduced: > > x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable': > tc358768.c:(.text+0xbe3dae): undefined reference to > `drm_display_mode_to_videomode' > > Make sure th

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

2023-12-05 Thread Tvrtko Ursulin
On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the caller of gen8_engine_reset_prepare() decide if a failure in gen8_engine_reset_prepare is an error

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-05 Thread Pekka Paalanen
On Mon, 4 Dec 2023 10:21:03 +0100 Maxime Ripard wrote: > Hi > > On Fri, Dec 01, 2023 at 06:03:48PM +0200, Pekka Paalanen wrote: > > On Fri, 1 Dec 2023 14:20:55 +0100 > > Maxime Ripard wrote: > > > > > On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: ... > > Is it really "g

Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123

2023-12-05 Thread Maxime Ripard
Loosen FB atomic checks"). Fortunately for us, it's already been reverted yesterday for some unrelated reason, so it should be fixed in next-20231205 onward. Maxime signature.asc Description: PGP signature

Re: [PATCH RFC v7 07/10] drm/atomic: Loosen FB atomic checks

2023-12-05 Thread Maxime Ripard
Hi, On Fri, Oct 27, 2023 at 03:32:57PM -0700, Jessica Zhang wrote: > Loosen the requirements for atomic and legacy commit so that, in cases > where pixel_source != FB, the commit can still go through. > > This includes adding framebuffer NULL checks in other areas to account for > FB being NULL w

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 09:30, Tony Lindgren wrote: > * Krzysztof Kozlowski [231205 08:16]: >> On 05/12/2023 09:10, Tony Lindgren wrote: >>> * Krzysztof Kozlowski [231205 08:03]: What does runtime PM have to do with it? If runtime PM enables clocks, these are real signals and not optional. >>> >>

Re: [PATCH v3 13/14] dt-bindings: gpu: mali-valhall-csf: Add support for Arm Mali CSF GPUs

2023-12-05 Thread Boris Brezillon
On Mon, 04 Dec 2023 13:29:17 -0600 Rob Herring wrote: > On Mon, 04 Dec 2023 18:33:06 +0100, Boris Brezillon wrote: > > From: Liviu Dudau > > > > Arm has introduced a new v10 GPU architecture that replaces the Job Manager > > interface with a new Command Stream Frontend. It adds firmware driven

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-05 Thread Boris Brezillon
Hi Steve, I forgot to mention that I intentionally dropped your R-b, because there was a gazillion of changes all over the place, and I thought it deserved a fresh review. Regards, Boris On Mon, 4 Dec 2023 18:32:53 +0100 Boris Brezillon wrote: > Hello, > > This is the 3rd version of the ker

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

2023-12-05 Thread Nirmoy Das
Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the caller of gen8_engine_reset_prepare() decid

Re: [PATCH 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous

2023-12-05 Thread Pekka Paalanen
On Mon, 4 Dec 2023 13:17:06 +0100 Maxime Ripard wrote: > The current documentation of drm_atomic_state says that it's the "global > state object". This is confusing since, while it does contain all the > objects affected by an update and their respective states, if an object > isn't affected by

[PATCH] drm/tests: Switch to kunit devices

2023-12-05 Thread Maxime Ripard
Kunit recently gained helpers to create test managed devices. This means that we no longer have to roll our own helpers in KMS and we can reuse them. Signed-off-by: Maxime Ripard --- David, feel free to integrate that patch into your series and merge it whenever and wherever you see fit. --- d

Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123

2023-12-05 Thread Dan Carpenter
_state_rounding3 > > - drm_test_check_plane_state_rounding4 > > - drm_test_check_plane_state_upscaling > > I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB > atomic checks"). > > Fortunately for us, it's already been reverted yeste

[PATCH v2] drm/i915/gt: Convert reset prepare failure log to trace

2023-12-05 Thread Nirmoy Das
gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Convert the log to a trace log for debugging without triggering unnecessary concerns in CI or for end-users during non-fatal scenarios. v2: Improve c

Re: [PATCH v2] drm/i915/gt: Convert reset prepare failure log to trace

2023-12-05 Thread John Harrison
On 12/5/2023 00:52, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Convert the log to a trace log for debugging without triggering unnecessary concerns in CI or for end-users du

Re: [PATCH 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous

2023-12-05 Thread Pekka Paalanen
On Tue, 5 Dec 2023 10:51:06 +0200 Pekka Paalanen wrote: > On Mon, 4 Dec 2023 13:17:06 +0100 > Maxime Ripard wrote: > > > The current documentation of drm_atomic_state says that it's the "global > > state object". This is confusing since, while it does contain all the > > objects affected by an

Re: [PATCH v3 12/14] drm/rockchip: vop2: Add debugfs support

2023-12-05 Thread Sascha Hauer
On Thu, Nov 30, 2023 at 08:24:49PM +0800, Andy Yan wrote: > From: Andy Yan > > /sys/kernel/debug/dri/vop2/summary: dump vop display state > /sys/kernel/debug/dri/vop2/regs: dump whole vop registers > /sys/kernel/debug/dri/vop2/active_regs: only dump the registers of > activated modules > > Sign

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-12-05 Thread Krzysztof Kozlowski
On 28/11/2023 21:58, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: >> >> On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: >>> Merging >>> === >>> I propose to take entire patchset through my tree (Samsung SoC), because: > ^^^

amdgpu header files (was: Re: [git pull] drm for 6.7-rc1)

2023-12-05 Thread Geert Uytterhoeven
On Tue, 31 Oct 2023, Dave Airlie wrote: This is the main drm pull request for 6.7. Highlights: - AMD adds some more upcoming HW platforms Alex Deucher (24): drm/amdgpu: update to the latest GC 11.5 headers Candice Li (8): drm/amd: Add umc v12_0_0 ip headers Lang Yu (57):

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Krzysztof Kozlowski
On 05/12/2023 10:02, Andreas Kemnade wrote: > On Tue, 5 Dec 2023 09:45:44 +0100 > Krzysztof Kozlowski wrote: > >>> Sure the clock nodes can be there for the child IP, but they won't do >>> anything. And still need to be managed separately by the device driver if >>> added. >> >> So if OS does n

Re: [PATCH v3 11/14] drm/rockchip: vop2: Add support for rk3588

2023-12-05 Thread Sascha Hauer
On Thu, Nov 30, 2023 at 08:24:39PM +0800, Andy Yan wrote: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support > 4 4K Esmart windows with l

Re: [PATCH] drm/i915/display: Use i915_gem_object_get_dma_address to get dma address

2023-12-05 Thread Hogander, Jouni
On Mon, 2023-12-04 at 14:49 +0100, Maarten Lankhorst wrote: > Works better for xe like that. obj is no longer const. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Jouni Högander > --- >  drivers/gpu/drm/i915/display/intel_cursor.c | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(

Re: [PATCH V2 00/10] rockchip: Add Powkiddy X55

2023-12-05 Thread Heiko Stübner
Am Dienstag, 5. Dezember 2023, 09:28:24 CET schrieb Neil Armstrong: > On 05/12/2023 09:26, Neil Armstrong wrote: > > Hi, > > > > On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > >> From: Chris Morgan > >> > >> Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > >> co

Re: [PATCH v3 06/14] drm/panthor: Add the devfreq logical block

2023-12-05 Thread Clément Péron
Hi Boris, On Mon, 4 Dec 2023 at 18:33, Boris Brezillon wrote: > > Every thing related to devfreq in placed in panthor_devfreq.c, and > helpers that can be called by other logical blocks are exposed through > panthor_devfreq.h. > > This implementation is loosely based on the panfrost implementatio

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 10:27:56 +0100 Krzysztof Kozlowski wrote: > On 05/12/2023 10:02, Andreas Kemnade wrote: > > On Tue, 5 Dec 2023 09:45:44 +0100 > > Krzysztof Kozlowski wrote: > > > >>> Sure the clock nodes can be there for the child IP, but they won't do > >>> anything. And still need to be

Re: [PATCH v3 11/14] drm/rockchip: vop2: Add support for rk3588

2023-12-05 Thread Andy Yan
Hi Sascha: On 12/5/23 17:29, Sascha Hauer wrote: On Thu, Nov 30, 2023 at 08:24:39PM +0800, Andy Yan wrote: From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV suppo

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 09:45:44 +0100 Krzysztof Kozlowski wrote: > > Sure the clock nodes can be there for the child IP, but they won't do > > anything. And still need to be managed separately by the device driver if > > added. > > So if OS does not have runtime PM, the bindings are wrong? Binding

Re: [PATCH v3 11/14] drm/rockchip: vop2: Add support for rk3588

2023-12-05 Thread Sascha Hauer
On Tue, Dec 05, 2023 at 05:44:03PM +0800, Andy Yan wrote: > Hi Sascha: > > On 12/5/23 17:29, Sascha Hauer wrote: > > On Thu, Nov 30, 2023 at 08:24:39PM +0800, Andy Yan wrote: > > > From: Andy Yan > > > > > > VOP2 on rk3588: > > > > > > Four video ports: > > > VP0 Max 4096x2160 > > > VP1 Max 409

[RFC][PATCH v6 0/5] drm/panic: Add a drm panic handler

2023-12-05 Thread Jocelyn Falempe
drm/panic: Add a drm panic handler This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comment

[PATCH v6 1/5] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

2023-12-05 Thread Jocelyn Falempe
This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. v5: * Change the drawing API, use drm_fb_blit_from_r1() to draw the font. * Also add drm_fb_fill() to fill area with background color. v6: * fix __le32 conversion warning found by the kernel

[PATCH v6 2/5] drm/panic: Add a drm panic handler

2023-12-05 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis) *

[PATCH v6 5/5] drm/ast: Add drm_panic support

2023-12-05 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_drv

[PATCH v6 4/5] drm/mgag200: Add drm_panic support

2023-12-05 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 25 + 1 file c

[PATCH v6 3/5] drm/simpledrm: Add drm_panic support

2023-12-05 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drive

Re: (subset) [PATCH V2 00/10] rockchip: Add Powkiddy X55

2023-12-05 Thread Heiko Stuebner
On Mon, 4 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porch and

Re: (subset) [PATCH V2 00/10] rockchip: Add Powkiddy X55

2023-12-05 Thread Heiko Stuebner
On Mon, 4 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porch and

Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2023-12-05 Thread Linus Walleij
Hi Yoshinori, thanks for your patch! On Tue, Dec 5, 2023 at 10:46 AM Yoshinori Sato wrote: > + renesas,icr-irlm: > +type: boolean > +description: If true ICR.IRLM=1 That's a bit hard to understand. I suppose it's something that need to sometimes be changed for a system so would be goo

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

2023-12-05 Thread Tvrtko Ursulin
On 05/12/2023 08:50, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the c

Re: [DO NOT MERGE v5 14/37] clk: Compatible with narrow registers

2023-12-05 Thread Uwe Kleine-König
Hello, On Tue, Dec 05, 2023 at 06:45:33PM +0900, Yoshinori Sato wrote: > @@ -675,13 +681,17 @@ struct clk_div_table { > * CLK_DIVIDER_BIG_ENDIAN - By default little endian register accesses are > used > * for the divider register. Setting this flag makes the register accesses > * big e

Re: [v3 0/6] DRM driver for verisilicon

2023-12-05 Thread Sui Jingfeng
HI, This series are very interesting and nice! On 2023/12/4 20:33, Keith Zhao wrote: This patch is a drm driver for Starfive Soc JH7110, 'SoC' : System on Chip, no more 'Soc' or 'soc' please. I am sending Drm driver part and HDMI driver part. 'DRM' or 'drm' nor Drm. DRM: Direct Renderin

Re: [PATCH v2] drm/i915/gt: Convert reset prepare failure log to trace

2023-12-05 Thread Nirmoy Das
Hi John, On 12/5/2023 10:10 AM, John Harrison wrote: On 12/5/2023 00:52, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Convert the log to a trace log for debugging without tr

Re: [PATCH v4 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend

2023-12-05 Thread Boris Brezillon
On Mon, 4 Dec 2023 12:42:12 +0100 AngeloGioacchino Del Regno wrote: > Changes in v4: > - Added checks for is_suspended bits in hardirqs > - Added GPU suspended bit (and handling of it) > - Reordered panfrost_drv_comp_bits entries > - Commit description fixes > > Changes in v3: > - Removed

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

2023-12-05 Thread Nirmoy Das
Hi Tvrtko, On 12/5/2023 11:05 AM, Tvrtko Ursulin wrote: On 05/12/2023 08:50, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases

Re: [PATCH] drm/gpuvm: Let drm_gpuvm_bo_put() report when the vm_bo object is destroyed

2023-12-05 Thread Boris Brezillon
On Tue, 5 Dec 2023 02:46:32 +0100 Danilo Krummrich wrote: > On 12/4/23 16:14, Boris Brezillon wrote: > > Some users need to release resources attached to the vm_bo object when > > it's destroyed. In Panthor's case, we need to release the pin ref so > > BO pages can be returned to the system when

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

2023-12-05 Thread Tvrtko Ursulin
On 05/12/2023 10:44, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 11:05 AM, Tvrtko Ursulin wrote: On 05/12/2023 08:50, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set R

[PATCH v4 00/10] Add displays support for bsh-smm-s2/pro boards

2023-12-05 Thread Dario Binacchi
The series adds drivers for the displays used by bsh-smm-s2/pro boards. This required applying some patches to the samsung-dsim driver and the drm_bridge.c module. Changes in v4: - Set the reset gpio to low in a single operation - Remove duplicated code for prepare/unprepare callbacks - Add 'Revie

[PATCH v4 01/10] drm/bridge: Fix bridge disable logic

2023-12-05 Thread Dario Binacchi
As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" f

[PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-05 Thread Dario Binacchi
The patch fixes the code for finding the next bridge with the "pre_enable_prev_first" flag set to false. In case this condition is not verified, i. e. there is no subsequent bridge with the flag set to false, the whole bridge list is traversed, invalidating the "next" variable. The use of a new it

[PATCH v4 03/10] drm: bridge: samsung-dsim: enter display mode in the enable() callback

2023-12-05 Thread Dario Binacchi
The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the

[PATCH v4 05/10] dt-bindings: display: panel: Add synaptics r63353 panel controller

2023-12-05 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- (no changes since v3) Changes in v3: - Add 'Reviewed-by' tag of Krzysztof Kozlowski. - Replace "synaptics,r63353" comp

[PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver

2023-12-05 Thread Dario Binacchi
From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v4: - Set the reset gpio to low in a single operation - Remove duplicated code for prepare/unprepare c

[PATCH v4 07/10] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-12-05 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "ilitek,ili9805" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v3) Changes in v3: - Drop power-supply Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set por

[PATCH v4 04/10] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2023-12-05 Thread Dario Binacchi
The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++- 1 file change

[PATCH v4 08/10] drm/panel: Add Ilitek ILI9805 panel driver

2023-12-05 Thread Dario Binacchi
From: Michael Trimarchi The GPM1790A0 panel is based on the Ilitek ILI9805 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v4: - Remove duplicated code for prepare/unprepare callbacks MAINTAINERS

[PATCH v4 09/10] drm/panel: ilitek-ili9805: add support for Tianma TM041XDHG01 panel

2023-12-05 Thread Dario Binacchi
From: Michael Trimarchi Tianma TM041XDHG01 utilizes the Ilitek ILI9805 controller. Add this panel's initialzation sequence and timing to ILI9805 driver. Signed-off-by: Michael Trimarchi Reviewed-by: Neil Armstrong Signed-off-by: Dario Binacchi --- Changes in v4: - Add Reviewed-by tag of Ne

Re: [PATCH v2 1/2] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH 5/6] drm/amdgpu: Auto-validate DMABuf imports in compute VMs

2023-12-05 Thread kernel test robot
1-20231203 (https://download.01.org/0day-ci/archive/20231205/202312051955.xacucivn-...@intel.com/config) compiler: powerpc-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051955.xacucivn-...@intel.com/reproduce) If you fix the

[PATCH] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time

2023-12-05 Thread Geert Uytterhoeven
From: Douglas Anderson Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. This is important because drm_helper_force_disable_all() will cause panels to get disabled cleanly which may be important for their p

Re: [v3 3/6] drm/vs: Register DRM device

2023-12-05 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:33, Keith Zhao wrote: > > Implement drm device registration interface > > Signed-off-by: Keith Zhao > --- > MAINTAINERS | 1 + > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-05 Thread Dmitry Osipenko
On 12/4/23 15:55, Maxime Ripard wrote: >> Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I >> guess. DRM subsys and majority of kernel uses common _locked postfix. We should retain the old naming scheme by using _locked() in DRM. It's not worthwhile changing the name to a much

Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123

2023-12-05 Thread Maxime Ripard
k_plane_state_upscaling > > > > I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB > > atomic checks"). > > > > Fortunately for us, it's already been reverted yesterday for some > > unrelated reason, so it should be fixed i

Re: [RFT PATCH v2 1/4] drm/msm/dpu: enable writeback on SM8150

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > On 04/12/2023 10:38, Maxime Ripard wrote: > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > The drm_atomic_helper_check_wb_encoder_state() function doesn't use > > > encoder for anything other than getting

Re: [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Dmitry Baryshkov
On Tue, 5 Dec 2023 at 13:48, Maxime Ripard wrote: > > On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > > On 04/12/2023 10:38, Maxime Ripard wrote: > > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > > The drm_atomic_helper_check_wb_encoder_state() funct

Re: [v3 0/6] DRM driver for verisilicon

2023-12-05 Thread Sui Jingfeng
Hi, On 2023/12/4 20:33, Keith Zhao wrote: This patch is a drm driver for Starfive Soc JH7110, I am sending Drm driver part and HDMI driver part. We used GEM framework for buffer management, and for buffer allocation,we use DMA APIs. the Starfive HDMI servers as interface between a LCD Controll

[Bug 218221] Nouveau GSP fail on command cli:0xc1d0000

2023-12-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218221 marc barbier (mmarc...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time

2023-12-05 Thread Laurent Pinchart
Hi Geert and Doug, Thank you for the patch. On Tue, Dec 05, 2023 at 12:30:02PM +0100, Geert Uytterhoeven wrote: > From: Douglas Anderson > > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time. > This is i

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-12-05 Thread Thierry Reding
On Tue, Nov 28, 2023 at 09:58:41PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > > Merging > > > === > > > I propose to take entire patchset through my tree (Samsung So

[PATCH 0/4] Support panels used by MT8173 Chromebooks in edp-panel

2023-12-05 Thread Pin-yen Lin
This series contains 4 patches: 1. Add a new panel delay to support some BOE panels 2. Sort the panel entries as a clean up. This one does not depend on other patches in this series and can be merged separately. 3. Add panel entries used by Mediatek MT8173 Chromebooks. 4. Add panels missing data

[PATCH 1/4] drm/panel-edp: Add powered_on_to_enable delay

2023-12-05 Thread Pin-yen Lin
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/pane

[PATCH 2/4] drm/edp-panel: Sort the panel entries

2023-12-05 Thread Pin-yen Lin
Move the order of CMN 0x14e5 to make the list sorted. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 819fe8115c08..e0a18e17d3a2 1006

[PATCH 3/4] drm/edp-panel: Add panels delay entries

2023-12-05 Thread Pin-yen Lin
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index e0a18e17d3a2..475257

[PATCH 4/4] drm/panel-edp: Add some panels with conservative timings

2023-12-05 Thread Pin-yen Lin
These panels are used by Mediatek MT8173 Chromebooks but we can't find the corresponding data sheets, and these panels used to work on v4.19 kernel without any specified delays. Therefore, instead of having them use the default conservative timings, update them with less-conservative timings from

dri-devel@lists.freedesktop.org

2023-12-05 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:33, Keith Zhao wrote: > > add 2 crtcs and 8 planes in vs-drm > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Makefile |9 +- > drivers/gpu/drm/verisilicon/vs_crtc.c | 208 + > drivers/gpu/drm/verisilicon/vs_crtc.h | 42 + > drivers/gpu/dr

Re: [DO NOT MERGE v5 35/37] sh: RTS7751R2D Plus OF defconfig

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > arch/sh/configs/rts7751r2dplus-of_defconfig | 93 + This is very similar to the landisk config, so it may be easier to just have one of them that works for both, as well as future ones

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-05 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:33, Keith Zhao wrote: > > add hdmi driver as encoder and connect > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 8 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfive_hdmi.c | 849

Re: [DO NOT MERGE v5 10/37] sh: Common PCI Framework driver support.

2023-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > + > +#if defined(CONFIG_PCI) && !defined(CONFIG_GENERIC_IOMAP) > +void pci_iounmap(struct pci_dev *dev, void __iomem *addr) > +{ > + iounmap(addr); > +} > +EXPORT_SYMBOL(pci_iounmap); This definition does not work for addresses that are re

[PATCH] drm/debugfs: fix potential NULL pointer dereference

2023-12-05 Thread Marek Szyprowski
ne snd_pcm genet(+) gpu_sched snd_timer snd bcm2711_thermal soundcore drm_dma_helper CPU: 1 PID: 221 Comm: systemd-udevd Not tainted 6.7.0-rc4-next-20231205 #14267 Hardware name: BCM2711 PC is at drm_debugfs_encoder_add+0x6c/0x98 LR is at 0x0 ... drm_debugfs_encoder_add from drm_encoder_regist

Re: [REGRESSION]: nouveau: Asynchronous wait on fence

2023-12-05 Thread Thorsten Leemhuis
Karol, Lyude, and Daniel: On 29.11.23 01:37, Owen T. Heisler wrote: > On 11/21/23 14:23, Owen T. Heisler wrote: >> On 11/21/23 09:16, Linux regression tracking (Thorsten Leemhuis) wrote: >>> On 15.11.23 07:19, Owen T. Heisler wrote: On 10/31/23 04:18, Linux regression tracking (Thorsten Leemh

Re: [v3 6/6] drm/vs: simple encoder

2023-12-05 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:33, Keith Zhao wrote: > > add simple encoder for dsi bridge This doesn't look like a proper commit message. > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Makefile| 4 +- > drivers/gpu/drm/verisilicon/vs_drv.c| 2 + > drivers/gpu/

  1   2   3   >