Re: [PATCH v3] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-12-04 Thread Thomas Zimmermann
Hi Am 03.12.23 um 21:57 schrieb Alyssa Ross: Thomas Zimmermann writes: Invoke drm_plane_helper_funcs.end_fb_access before drm_atomic_helper_commit_hw_done(). The latter function hands over ownership of the plane state to the following commit, which might free it. Releasing resources in end_fb

[PATCH] drm/vmwgfx: fix a memleak in vmw_gmrid_man_get_node

2023-12-04 Thread Zhipeng Lu
When ida_alloc_max fails, resources allocated before should be freed, including *res allocated by kmalloc and ttm_resource_init. Fixes: d3bcb4b02fe9 ("drm/vmwgfx: switch the TTM backends to self alloc") Signed-off-by: Zhipeng Lu --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 2 ++ 1 file ch

[PATCH] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: d70229f70447 ("drm/radeon/kms: add dpm support for

[PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for

Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Christian König
Am 03.12.23 um 18:16 schrieb Zhipeng Lu: The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c1

[PATCH v4] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-12-04 Thread Thomas Zimmermann
Invoke drm_plane_helper_funcs.end_fb_access before drm_atomic_helper_commit_hw_done(). The latter function hands over ownership of the plane state to the following commit, which might free it. Releasing resources in end_fb_access then operates on undefined state. This bug has been observed with non

Re: [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-04 Thread Maxime Ripard
On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > The drm_atomic_helper_check_wb_encoder_state() function doesn't use > encoder for anything other than getting the drm_device instance. The > function's description talks about checking the writeback connector > state, not the encod

Re: [PATCH] drm/qxl: remove unused declaration

2023-12-04 Thread Maxime Ripard
On Fri, 10 Nov 2023 13:50:31 +0800, heminhong wrote: > Some functions are never used by the driver, > removing the functions declaration, it can be reducing program size, > and improving code readability and maintainability. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH RESEND] drm/drv: propagate errors from drm_modeset_register_all()

2023-12-04 Thread Maxime Ripard
On Sun, 03 Dec 2023 01:55:52 +0300, Dmitry Baryshkov wrote: > In case the drm_modeset_register_all() function fails, its error code > will be ignored. Instead make the drm_dev_register() bail out in case of > such an error. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: Friendly ping. I think this patch was forgotten.//回复: [PATCH] drm/qxl: remove unused declaration

2023-12-04 Thread mripard
Applied, thanks for the reminder signature.asc Description: PGP signature

Re: [PATCH v5 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-12-04 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 10:20:40AM -0500, Harry Wentland wrote: > > > On 2023-11-30 06:34, Daniel Vetter wrote: > > On Tue, 28 Nov 2023 at 23:11, Harry Wentland wrote: > >> > >> On 2023-11-16 14:57, Melissa Wen wrote: > >>> Hello, > >>> > >>> This series extends the current KMS color management

Re: [PATCH RESEND 1/5] drm/atomic: add private obj state to state dump

2023-12-04 Thread Maxime Ripard
On Sun, 3 Dec 2023 03:05:28 +0300, Dmitry Baryshkov wrote: > The drm_atomic_print_new_state() already prints private object state via > drm_atomic_private_obj_print_state(). Add private object state dumping > to __drm_state_dump(), so that it is also included into drm_state_dump() > output and into

[PATCH v2] drm/panel-edp: Add SDC ATNA45AF01

2023-12-04 Thread Abel Vesa
Add support for the SDC ATNA45AF01 panel. Signed-off-by: Abel Vesa --- Changes in v2: - moved the panel entry in the proper place, as suggested by Doug - Link to v1: https://lore.kernel.org/r/20231201-x1e80100-drm-panel-edp-v1-1-ef9def711...@linaro.org --- drivers/gpu/drm/panel/panel-edp.c | 2

Re: [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-04 Thread Maxime Ripard
Hi, On Sun, Dec 03, 2023 at 02:53:13PM +0300, Dmitry Baryshkov wrote: > Each of connectors and CRTCs used by the DRM device provides debugfs > directory, which is used by several standard debugfs files and can > further be extended by the driver. Add such generic debugfs directories > for encoder.

Re: (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-04 Thread Maxime Ripard
On Sun, Dec 03, 2023 at 08:10:31PM +0200, Dmitry Baryshkov wrote: > On Sun, 3 Dec 2023 at 14:15, Simon Ser wrote: > > > > On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov > > wrote: > > > > > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > > > > > Some drivers support ha

Re: [PATCH v5 3/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v5)

2023-12-04 Thread David Hildenbrand
On 04.12.23 09:16, Christoph Hellwig wrote: On Thu, Nov 30, 2023 at 06:41:11AM +, Kasireddy, Vivek wrote: I see your concern. The word "file" does make it look like this API works with all kinds of files although it is meant to specifically work with files that belong to shmemfs or hugetlbfs

[PATCH v2 1/8] drm/plane-helper: Move drm_plane_helper_atomic_check() into udl

2023-12-04 Thread Thomas Zimmermann
The udl driver is the only caller of drm_plane_helper_atomic_check(). Move the function into the driver. No functional changes. v2: * fix documenation (Sui) Signed-off-by: Thomas Zimmermann Acked-by: Sui Jingfeng --- drivers/gpu/drm/drm_crtc_helper.c | 7 ++- drivers/gpu/drm/drm_

[PATCH v2 4/8] drm/shmobile: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven --- drivers/gpu/drm/renesas/shmobile/shmob_

[PATCH v2 8/8] drm/xlnx: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v2 0/8] drm/plane-helpers: Minor clean ups

2023-12-04 Thread Thomas Zimmermann
Move drm_plane_helper_atomic_check() into udl, which is the only driver using it. Remove several unnecessary include statements for . v2: * fix documentation (Sui) Thomas Zimmermann (8): drm/plane-helper: Move drm_plane_helper_atomic_check() into udl drm/amdgpu: Do not include drm/

[PATCH v2 3/8] drm/loongson: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_plane.c | 1 - 1 fil

[PATCH v2 2/8] drm/amdgpu: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH v2 7/8] drm/simpledrm: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/tiny/simpledrm.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2 5/8] drm/solomon: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130

[PATCH v2 6/8] drm/ofdrm: Do not include

2023-12-04 Thread Thomas Zimmermann
Remove unnecessary include statements for . The file contains helpers for non-atomic code and should not be required by most drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/tiny/ofdrm.c | 1 - 1 file changed, 1 deletion(-) diff --g

Fwd: [PATCH 3/4] fbdev/vesafb: Replace references to global screen_info by local pointer

2023-12-04 Thread Thomas Zimmermann
cc'ing mailing lists Weitergeleitete Nachricht Betreff: Re: [PATCH 3/4] fbdev/vesafb: Replace references to global screen_info by local pointer Datum: Fri, 01 Dec 2023 09:54:51 +0100 Von: Javier Martinez Canillas An: Thomas Zimmermann Thomas Zimmermann writes: Get the g

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2023-12-04 Thread Javier Martinez Canillas
Jean Delvare writes: Hello Jean, > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > Si

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-04 Thread Maxime Ripard
Hi On Fri, Dec 01, 2023 at 06:03:48PM +0200, Pekka Paalanen wrote: > On Fri, 1 Dec 2023 14:20:55 +0100 > Maxime Ripard wrote: > > > On Fri, Dec 01, 2023 at 12:06:48PM +0200, Pekka Paalanen wrote: > > > On Fri, 1 Dec 2023 10:25:09 +0100 > > > Maxime Ripard wrote: > > > > > > > On Fri, Dec 01,

[PATCH v2 0/4] fbdev: Remove global screen_info in efifb/vesafb

2023-12-04 Thread Thomas Zimmermann
Replace the global instance of screen_info with the per-device instance that is set by the sysfb code. The use of the global screen_info should be limited and ideally be pushed into per-architecture code. v2: * comment on devm_kmemdup() usage (Javier) Thomas Zimmermann (4): fbdev/efifb:

[PATCH v2 2/4] fbdev/efifb: Use screen_info pointer from device

2023-12-04 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas Z

[PATCH v2 1/4] fbdev/efifb: Replace references to global screen_info by local pointer

2023-12-04 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/efifb.c | 113 ++-- 1 file changed, 58 insertions(+), 55

[PATCH v2 4/4] fbdev/vesafb: Use screen_info pointer from device

2023-12-04 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas

[PATCH v2 3/4] fbdev/vesafb: Replace references to global screen_info by local pointer

2023-12-04 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/vesafb.c | 66 +++- 1 file changed, 35 insertions(+), 31

Re: [PATCH v2 05/10] drm/bridge: tc358775: make standby GPIO optional

2023-12-04 Thread Michael Walle
The stby pin is optional. It is only needed for power-up and down sequencing. It is not needed, if the power rails cannot by dynamically enabled. Because the GPIO is not optional, remove the error message. I just noticed a typo: "is *now* optional. -michael

Re: [PATCH v2 01/10] dt-bindings: display: bridge: tc358775: make stby gpio and vdd supplies optional

2023-12-04 Thread Michael Walle
For a normal operation, the vdd supplies nor the stby GPIO is needed. There are boards, where these voltages are statically enabled during board power-up. This means supply is still required. You mean using fixed-regulator? I didn't consider that. But yes, you're right. -michael

Re: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-12-04 Thread Christian König
Am 04.12.23 um 00:32 schrieb Alistair Popple: Christian König writes: Am 01.12.23 um 06:48 schrieb Zeng, Oak: [SNIP] Besides memory eviction/oversubscription, there are a few other pain points when I use hmm: 1) hmm doesn't support file-back memory, so it is hard to share memory b/t proces

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-12-04 Thread Javier Martinez Canillas
Rob Herring writes: Hello Rob, > On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas [...] >> >> I don't have a better idea than this patch but maybe Thomas or Sima do? >> > >> > At SUSE, we've carried such a patch in our repos for some time. It works >> > around the double-framebuffer pro

Re: [PATCH v2 7/8] drm/simpledrm: Do not include

2023-12-04 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Remove unnecessary include statements for . > The file contains helpers for non-atomic code and should not be > required by most drivers. No functional changes. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Sui Jingfeng > --- Reviewed-by: Javier Martinez Canil

Re: [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs

2023-12-04 Thread Jani Nikula
On Fri, 01 Dec 2023, Hans de Goede wrote: > soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent > and use devm_gpiod_get() for all GPIOs. > > This allows removing the intel_dsi_vbt_gpio_cleanup() function, > which only function was to put the GPIO-descriptors. > > Signed-off-by:

Re: [PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765

2023-12-04 Thread Michael Walle
>> The tc358775 bridge is pin compatible with earlier tc358765 according to >> the tc358774xbg_datasheet_en_20190118.pdf documentation. Compared to the >> tc358765, the tc358775 supports a STBY GPIO and higher data rates. >> >> The tc358765 has a register bit for video event mode vs video pulse mod

Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

2023-12-04 Thread Neil Armstrong
On 04/12/2023 08:27, Arnd Bergmann wrote: From: Arnd Bergmann A dependency on this feature was recently introduced: x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable': tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode' Make sure this is alwa

Re: fbcon on one of multiple displays

2023-12-04 Thread Javier Martinez Canillas
Eric Nelson writes: Hello Eric, > Hi all, > > Is there a way to configure a framebuffer console on a specific display > on a machine with multiple displays? > Have you looked at https://www.kernel.org/doc/Documentation/fb/fbcon.txt ? There is a sysfb interface to bind / unbind fbdev devices t

[PATCH v2 1/4] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2023-12-04 Thread Raphael Gallais-Pou
Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/s

[PATCH v2 0/4] Update STM DSI PHY driver

2023-12-04 Thread Raphael Gallais-Pou
This patch series aims to add several features of the dw-mipi-dsi phy driver that are missing or need to be updated. First patch update a PM macro. Second patch adds runtime PM functionality to the driver. Third patch adds a clock provider generated by the PHY itself. As explained in the commit

[PATCH v2 2/4] drm/stm: dsi: add pm runtime ops

2023-12-04 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS and removed

[PATCH v2 3/4] drm/stm: dsi: expose DSI PHY internal clock

2023-12-04 Thread Raphael Gallais-Pou
DSISRC __ __\_ |\ pll4_p_ck ->| 1 |dsi_k ck_dsi_phy ->| 0 | |/ A DSI clock is missing in the clock framework. Looking at the clk_summary, it appears that 'ck_dsi_phy' is not implem

[PATCH v2 4/4] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2023-12-04 Thread Raphael Gallais-Pou
In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent clock, which means that it is an APB peripheral clock. Swap the clocks in the DSI peripheral clock reference. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp157.dtsi | 2 +- arch/arm/boot/dts/st

Re: [PATCH v1 1/1] drm/i915/display: Don't use "proxy" headers

2023-12-04 Thread Jani Nikula
On Wed, 29 Nov 2023, Andy Shevchenko wrote: > The driver uses math.h and not util_macros.h. > > Signed-off-by: Andy Shevchenko Thanks, pushed to drm-intel-next. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [RFC PATCH 2/6] mm/gmem: add arch-independent abstraction to track address mapping status

2023-12-04 Thread David Hildenbrand
On 02.12.23 15:50, Pedro Falcato wrote: On Fri, Dec 1, 2023 at 9:23 AM David Hildenbrand wrote: On 28.11.23 13:50, Weixi Zhu wrote: This patch adds an abstraction layer, struct vm_object, that maintains per-process virtual-to-physical mapping status stored in struct gm_mapping. For example, a

Re: [PATCH] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Amos Jianjun Kong
On Mon, Dec 4, 2023 at 5:55 PM Zhipeng Lu wrote: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > following error-handling path. However, in the error-handling of > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > resulting in a memleak in this function

Re: [PATCH v2 6/6] x86/vmware: Add TDX hypercall support

2023-12-04 Thread Borislav Petkov
On Fri, Dec 01, 2023 at 03:24:52PM -0800, Alexey Makhalov wrote: > +#ifdef CONFIG_INTEL_TDX_GUEST > +/* __tdx_hypercall() is not exported. So, export the wrapper */ > +void vmware_tdx_hypercall_args(struct tdx_module_args *args) > +{ > + __tdx_hypercall(args); > +} > +EXPORT_SYMBOL_GPL(vmware_t

Re: [PATCH v2 1/6] x86/vmware: Move common macros to vmware.h

2023-12-04 Thread Borislav Petkov
On Fri, Dec 01, 2023 at 03:24:47PM -0800, Alexey Makhalov wrote: > Move VMware hypercall macros to vmware.h as a preparation step > for the next commit. No functional changes besides exporting "next commit" in git is ambiguous. Get rid of such formulations. -- Regards/Gruss, Boris. https://

Re: [PATCH v2 2/6] x86/vmware: Introduce vmware_hypercall API

2023-12-04 Thread Borislav Petkov
On Fri, Dec 01, 2023 at 03:24:48PM -0800, Alexey Makhalov wrote: > Introducing vmware_hypercall family of functions as a common > implementation to be used by the VMware guest code and virtual > device drivers in architecture independent manner. > > By analogy with KVM hypercall API, vmware_hyperc

Re: Kernel problem with multiseat on one card

2023-12-04 Thread Gert Vanhaerents
Hi Kernel list, I'm the IT person of a school, earlier we used multiseatcomputers for the school, i have maded with a XGL implementation and it works fine but not so fantastic. The school wants that i build new computers but the XGL project is too outdated so i can't use it anymore. How ca

Re: Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread alexious
> Am 03.12.23 um 18:16 schrieb Zhipeng Lu: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > > following error-handling path. However, in the error-handling of > > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > > resulting in a memleak in this function.

[PATCH] [v2] drm/radeon/dpm: fix a memleak in sumo_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for

[PATCH] [v2] drm/vmwgfx: fix a memleak in vmw_gmrid_man_get_node

2023-12-04 Thread Zhipeng Lu
When ida_alloc_max fails, resources allocated before should be freed, including *res allocated by kmalloc and ttm_resource_init. Fixes: d3bcb4b02fe9 ("drm/vmwgfx: switch the TTM backends to self alloc") Signed-off-by: Zhipeng Lu --- Changelog: v2: Adding {} to correct the if statement --- driv

[PATCH] [v2] drm/radeon/trinity_dpm: fix a memleak in trinity_parse_power_table

2023-12-04 Thread Zhipeng Lu
The rdev->pm.dpm.ps allocated by kcalloc should be freed in every following error-handling path. However, in the error-handling of rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, resulting in a memleak in this function. Fixes: d70229f70447 ("drm/radeon/kms: add dpm support for

Re: Kernel problem with multiseat on one card

2023-12-04 Thread Gert Vanhaerents
Op 2/12/2023 om 14:18 schreef Bagas Sanjaya: On Thu, Nov 30, 2023 at 11:48:24AM +0100, Gert Vanhaerents wrote: Hi Kernel list, I'm the IT person of a school, earlier we used multiseatcomputers for the school, i have maded with a XGL implementation and it works fine but not so fantastic. The sc

Re: [Nouveau] Kernel problem with multiseat on one card

2023-12-04 Thread Gert Vanhaerents
Op 2/12/2023 om 16:28 schreef Timur Tabi: On Sat, 2023-12-02 at 20:18 +0700, Bagas Sanjaya wrote: When i install the proprietary Nvidia drivers, i have the following: [MASTER] pci::08:00.0      │ ├─/sys/devices/pci:00/:00:03.1/:08:00.0/drm/card0      │ │ [MASTER] dr

Re: [Nouveau] Kernel problem with multiseat on one card

2023-12-04 Thread Gert Vanhaerents
Op 4/12/2023 om 9:51 schreef Gert Vanhaerents: Op 2/12/2023 om 16:28 schreef Timur Tabi: On Sat, 2023-12-02 at 20:18 +0700, Bagas Sanjaya wrote: When i install the p

Re: [PATCH v4 1/4] drm/msm/mdss: switch mdss to use devm_of_icc_get()

2023-12-04 Thread Konrad Dybcio
On 2.12.2023 23:42, Dmitry Baryshkov wrote: > Stop using hand-written reset function for ICC release, use > devm_of_icc_get() instead. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v4 3/4] drm/msm/mdss: inline msm_mdss_icc_request_bw()

2023-12-04 Thread Konrad Dybcio
On 2.12.2023 23:42, Dmitry Baryshkov wrote: > There are just two places where we set the bandwidth: in the resume and > in the suspend paths. Drop the wrapping function > msm_mdss_icc_request_bw() and call icc_set_bw() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio

Re: [PATCH v2] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions

2023-12-04 Thread Jani Nikula
On Thu, 30 Nov 2023, Khaled Almahallawy wrote: > DP2.1 Specs added new DPCDs definitions for square pattern configs[1] > These new definitions are used for UHBR Source Transmitter > Equalizations tests[2]. Add the 3 new values for square pattern. > > v2: rebase > > [1]: DP2.1 Specs - 2.12.3.6.5 Sq

Re: [PATCH v3 3/3] drm/panfrost: Synchronize and disable interrupts before powering off

2023-12-04 Thread AngeloGioacchino Del Regno
Il 01/12/23 12:14, Boris Brezillon ha scritto: On Fri, 1 Dec 2023 11:40:27 +0100 AngeloGioacchino Del Regno wrote: To make sure that we don't unintentionally perform any unclocked and/or unpowered R/W operation on GPU registers, before turning off clocks and regulators we must make sure that

Re: [PATCH v3 3/3] drm/panfrost: Synchronize and disable interrupts before powering off

2023-12-04 Thread AngeloGioacchino Del Regno
Il 01/12/23 13:34, Steven Price ha scritto: On 01/12/2023 11:14, Boris Brezillon wrote: On Fri, 1 Dec 2023 11:40:27 +0100 AngeloGioacchino Del Regno wrote: To make sure that we don't unintentionally perform any unclocked and/or unpowered R/W operation on GPU registers, before turning off clo

Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-12-04 Thread Konrad Dybcio
On 26.10.2023 21:16, Konrad Dybcio wrote: > > > On 10/23/23 22:20, Rob Clark wrote: >> On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio >> wrote: >>> >>> >>> >>> On 10/23/23 21:42, Rob Clark wrote: On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio wrote: > > New GPUs still use the

[PATCH v4 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend

2023-12-04 Thread AngeloGioacchino Del Regno
Changes in v4: - Added checks for is_suspended bits in hardirqs - Added GPU suspended bit (and handling of it) - Reordered panfrost_drv_comp_bits entries - Commit description fixes Changes in v3: - Removed useless GPU_INT_CLEAR write in suspend path - Changed to clear suspend bits in job/mmu

[PATCH v4 1/3] drm/panfrost: Ignore core_mask for poweroff and disable PWRTRANS irq

2023-12-04 Thread AngeloGioacchino Del Regno
Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost is partial, as this driver currently supports using only one core group and that's reflected on all parts of

[PATCH v4 2/3] drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device

2023-12-04 Thread AngeloGioacchino Del Regno
In preparation for adding a IRQ synchronization mechanism for PM suspend, add gpu_irq and mmu_irq variables to struct panfrost_device and change functions panfrost_gpu_init() and panfrost_mmu_init() to use those. Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Signed-off-by: AngeloGioacch

[PATCH v4 3/3] drm/panfrost: Synchronize and disable interrupts before powering off

2023-12-04 Thread AngeloGioacchino Del Regno
To make sure that we don't unintentionally perform any unclocked and/or unpowered R/W operation on GPU registers, before turning off clocks and regulators we must make sure that no GPU, JOB or MMU ISR execution is pending: doing that requires to add a mechanism to synchronize the interrupts on susp

[PATCH 1/5] drm/atomic: Move the drm_atomic_state field doc inline

2023-12-04 Thread Maxime Ripard
Some fields of drm_atomic_state have been documented in-line, but some were documented in the main kerneldoc block before the structure. Since the former is the preferred option in DRM, let's move all the fields to an inline documentation. Signed-off-by: Maxime Ripard --- include/drm/drm_atomic

[PATCH 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous

2023-12-04 Thread Maxime Ripard
The current documentation of drm_atomic_state says that it's the "global state object". This is confusing since, while it does contain all the objects affected by an update and their respective states, if an object isn't affected by this update it won't be part of it. Thus, it's not truly a "globa

[PATCH 2/5] drm/atomic: Remove inexistent reference

2023-12-04 Thread Maxime Ripard
The num_connectors field documentation mentions a connector_states field that has never been part of this structure. Signed-off-by: Maxime Ripard --- include/drm/drm_atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h i

[PATCH 5/5] drm/todo: Add entry to rename drm_atomic_state

2023-12-04 Thread Maxime Ripard
The name of the structure drm_atomic_state is confusing. Let's add an entry to our todo list to rename it. Signed-off-by: Maxime Ripard --- Documentation/gpu/todo.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst i

[PATCH 3/5] drm/atomic: Rework the object doc a bit

2023-12-04 Thread Maxime Ripard
The doc for the planes, crtcs, connectors and private_objs fields mention that they are pointers to an array of structures with per-$OBJECT data. While these fields are indeed pointers to an array, each item of that array contain a pointer to the object structure affected by the update, and its ol

Re: [PATCH] drm/doc: Define KMS atomic state set

2023-12-04 Thread Maxime Ripard
On Fri, Dec 01, 2023 at 08:09:22PM +0200, Ville Syrjälä wrote: > > When I was working on Weston atomic KMS support many years ago, I > > created a framework that emitted KMS property changes only when they > > actually needed changing. By review feedback (*), all that machinery was > > dropped in a

[PATCH next] drm/v3d: Fix missing error code in v3d_submit_cpu_ioctl()

2023-12-04 Thread Harshit Mogalapalli
Smatch warns: drivers/gpu/drm/v3d/v3d_submit.c:1222 v3d_submit_cpu_ioctl() warn: missing error code 'ret' When there is no job type or job is submitted with wrong number of BOs it is an error path, ret is zero at this point which is incorrect return. Fix this by changing it to -EI

Re: [PATCH RESEND 0/6] drm: simplify support for transparent DRM bridges

2023-12-04 Thread Greg Kroah-Hartman
On Sun, Dec 03, 2023 at 02:43:27PM +0300, Dmitry Baryshkov wrote: > Greg, could you please ack the last patch to be merged through the > drm-misc tree? You have acked patch 3, but since that time I've added > patches 4-6. That is up to the typec maintainer to ack, not me! thanks, greg k-h

[PATCH] accel/ivpu/37xx: Fix interrupt_clear_with_0 WA initialization

2023-12-04 Thread Jacek Lawrynowicz
From: Andrzej Kacprowski Using PCI Device ID/Revision to initialize the interrupt_clear_with_0 workaround is problematic - there are many pre-production steppings with different behavior, even with the same PCI ID/Revision Instead of checking for PCI Device ID/Revision, check the VPU buttress in

Re: [PATCH RESEND 0/6] drm: simplify support for transparent DRM bridges

2023-12-04 Thread Dmitry Baryshkov
On Mon, 4 Dec 2023 at 14:21, Greg Kroah-Hartman wrote: > > On Sun, Dec 03, 2023 at 02:43:27PM +0300, Dmitry Baryshkov wrote: > > Greg, could you please ack the last patch to be merged through the > > drm-misc tree? You have acked patch 3, but since that time I've added > > patches 4-6. > > That is

[PATCH] drm/bridge: nxp-ptn3460: fix i2c_master_send() error checking

2023-12-04 Thread Dan Carpenter
The i2c_master_send/recv() functions return negative error codes or the number of bytes that were able to be sent/received. This code has two problems. 1) Instead of checking if all the bytes were sent or received, it checks that at least one byte was sent or received. 2) If there was a partial

[v3 2/6] riscv: dts: starfive: jh7110: display subsystem

2023-12-04 Thread Keith Zhao
Add the dc controller and hdmi node for the Starfive JH7110 SoC. Signed-off-by: Keith Zhao --- .../jh7110-starfive-visionfive-2.dtsi | 134 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 49 +++ 2 files changed, 183 insertions(+) diff --git a/arch/riscv/boot/dts

[v3 1/6] dt-bindings: display: Add yamls for JH7110 display system

2023-12-04 Thread Keith Zhao
StarFive SoCs JH7110 display system: dc controller, hdmi controller, encoder, vout syscon. add the path of yaml file in MAINTAINERS Signed-off-by: Keith Zhao --- .../starfive/starfive,display-subsystem.yaml | 104 .../starfive/starfive,dsi-encoder.yaml| 92 +++

[v3 6/6] drm/vs: simple encoder

2023-12-04 Thread Keith Zhao
add simple encoder for dsi bridge Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile| 4 +- drivers/gpu/drm/verisilicon/vs_drv.c| 2 + drivers/gpu/drm/verisilicon/vs_simple_enc.c | 195 drivers/gpu/drm/verisilicon/vs_simple_enc.h | 23 +++

[v3 5/6] drm/vs: Add hdmi driver

2023-12-04 Thread Keith Zhao
add hdmi driver as encoder and connect Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Kconfig | 8 + drivers/gpu/drm/verisilicon/Makefile| 1 + drivers/gpu/drm/verisilicon/starfive_hdmi.c | 849 drivers/gpu/drm/verisilicon/starfive_hdmi.h | 304

[v3 3/6] drm/vs: Register DRM device

2023-12-04 Thread Keith Zhao
Implement drm device registration interface Signed-off-by: Keith Zhao --- MAINTAINERS | 1 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/verisilicon/Kconfig | 13 + drivers/gpu/drm/verisi

dri-devel@lists.freedesktop.org

2023-12-04 Thread Keith Zhao
add 2 crtcs and 8 planes in vs-drm Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile |9 +- drivers/gpu/drm/verisilicon/vs_crtc.c | 208 + drivers/gpu/drm/verisilicon/vs_crtc.h | 42 + drivers/gpu/drm/verisilicon/vs_dc.c| 1192 drivers

[v3 0/6] DRM driver for verisilicon

2023-12-04 Thread Keith Zhao
This patch is a drm driver for Starfive Soc JH7110, I am sending Drm driver part and HDMI driver part. We used GEM framework for buffer management, and for buffer allocation,we use DMA APIs. the Starfive HDMI servers as interface between a LCD Controller and a HDMI bus. A HDMI TX consists of on

[bug report] drm/amdgpu: Workaround to skip kiq ring test during ras gpu recovery

2023-12-04 Thread Dan Carpenter
Hello Stanley.Yang, The patch b1338a8e71ac: "drm/amdgpu: Workaround to skip kiq ring test during ras gpu recovery" from Oct 17, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:604 amdgpu_get_xgmi_hive() warn: sleepi

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-04 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 04:47:05PM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 16:15:27 +0100 > Maxime Ripard wrote: > > > > Now, let's assume we drop the _locked() suffix on > > > drm_gem_shmem_v[un]map(), but keep it on other helpers that need both > > > variants. This results in an inc

Re: [PATCH v1 3/3] drm/bridge: lt8912b: Add power supplies

2023-12-04 Thread Robert Foss
On Wed, Nov 15, 2023 at 1:14 PM Francesco Dolcini wrote: > > From: Stefan Eichenberger > > Add supplies to the driver that can be used to turn the Lontium lt8912b > on and off. It can have up to 7 independent supplies, we add them all > and enable/disable them with bulk_enable/disable. > > Signed

Re: [PATCH v1 1/3] drm/bridge: lt8912b: Add suspend/resume support

2023-12-04 Thread Robert Foss
On Wed, Nov 15, 2023 at 1:14 PM Francesco Dolcini wrote: > > From: Stefan Eichenberger > > Add support for suspend and resume. The lt8912b will power off when > going into suspend and power on when resuming. > > Signed-off-by: Stefan Eichenberger > Signed-off-by: Francesco Dolcini > --- > driv

[PATCH 0/7] drm: revert solid fill support

2023-12-04 Thread Dmitry Baryshkov
Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. Merging it was a fault of mine. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Revert this patchset until userspace obligati

[PATCH 1/7] Revert "drm/atomic: Loosen FB atomic checks"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit f1e75da5364e780905d9cd6043f9c74cdcf84073. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

[PATCH 2/7] Revert "drm/atomic: Move framebuffer checks to helper"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit 4ba6b7a646321e740c7f2d80c90505019c4e8fce. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

[PATCH 4/7] Revert "drm/atomic: Add pixel source to plane state dump"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit 8283ac7871a959848e09fc6593b8c12b8febfee6. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

[PATCH 7/7] Revert "drm: Introduce pixel_source DRM plane property"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit e50e5fed41c7eed2db4119645bf3480ec43fec11. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

[PATCH 6/7] Revert "drm: Introduce solid fill DRM plane property"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit 85863a4e16e77079ee14865905ddc3ef9483a640. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

[PATCH 3/7] Revert "drm/atomic: Add solid fill data to plane state dump"

2023-12-04 Thread Dmitry Baryshkov
This reverts commit e86413f5442ee094e66b3e75f2d3419ed0df9520. Altough the Solid Fill planes patchset got all reviews and acknowledgements, it doesn't fulfill requirements for the new uABI. It has neither corresponding open-source userspace implementation nor the IGT tests coverage. Reverting this

  1   2   3   >