Re: [PATCH v2 1/6] dt-bindings: display: Add yamls for JH7110 display system

2023-11-29 Thread Krzysztof Kozlowski
On 29/11/2023 04:13, Keith Zhao wrote: > > > On 2023/10/25 20:50, Krzysztof Kozlowski wrote: >> On 25/10/2023 12:39, Keith Zhao wrote: >>> StarFive SoCs JH7110 display system: >> >> A nit, subject: drop second/last, redundant "yamls for". The >> "dt-bindings" prefix is already stating that these

RE: [RFC PATCH 0/6] Supporting GMEM (generalized memory management) for external memory devices

2023-11-29 Thread zhuweixi
Glad to hear that more sharable code is desirable. IMHO, for a common MM subsystem, it is more beneficial for GMEM to extend core MM instead of building a separate one. As stated in the beginning of my RFC letter, MM systems are large and similar. Even a sophisticated one like Linux MM that has

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
Hi, On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > wrote: > > Geert Uytterhoeven writes: > > > The Imagination Technologies PowerVR Series 6 GPU is currently only > > > supported on Texas Instruments K3 AM62x SoCs.

Re: [PATCH v2 10/12] drm/rockchip: vop2: Add support for rk3588

2023-11-29 Thread Andy Yan
Hi Sascha, On 11/27/23 19:19, Sascha Hauer wrote: Hi Andy, Looks good overall, two small things inside. On Wed, Nov 22, 2023 at 08:55:44PM +0800, Andy Yan wrote: +#define vop2_output_if_is_hdmi(x) (x == ROCKCHIP_VOP2_EP_HDMI0 || x == ROCKCHIP_VOP2_EP_HDMI1) +#define vop2_output_if_is_dp(x)

[PATCH v2 RESEND] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-29 Thread xiazhengqiao
For the "starry, 2081101qfh032011-53g" panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G MIPI-DSI panel") Signed-off-by: xiazhengqiao Reviewed-by: Jess

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: >> On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas >> wrote: >> > Geert Uytterhoeven writes: >> > > The Imagination Technologies PowerVR Series 6 GPU is currently only >>

Re: [RFC PATCH 2/6] mm/gmem: add arch-independent abstraction to track address mapping status

2023-11-29 Thread linear cannon
On 11/28/23 07:50, Weixi Zhu wrote: This patch adds an abstraction layer, struct vm_object, that maintains per-process virtual-to-physical mapping status stored in struct gm_mapping. For example, a virtual page may be mapped to a CPU physical page or to a device physical page. Struct vm_object

Re: [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support

2023-11-29 Thread Sascha Hauer
On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote: >Hi Sascha: > >thanks for you review. > >On 11/27/23 18:13, Sascha Hauer wrote: > > On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote: > > From: Andy Yan [1] > > /sys/kernel/debug/dri/vop2/summary: dump vop displa

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-29 Thread Neil Armstrong
On 08/11/2023 16:58, Laurent Pinchart wrote: On Wed, Nov 08, 2023 at 04:34:39PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 04:26:34PM +0100, Greg Kroah-Hartman wrote: On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Ha

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > > wrote: > > > Geert Uytterhoeven writes: > > > > The Imagination Technologies PowerVR Series 6 GP

[PATCH v6] Documentation/gpu: VM_BIND locking document

2023-11-29 Thread Thomas Hellström
Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm-bind

Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-29 Thread Sean Young
On Fri, Nov 24, 2023 at 02:31:18PM +0100, Thierry Reding wrote: > On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote: > > In order to introduce a pwm api which can be used from atomic context, > > we will need two functions for applying pwm changes: > > > > int pwm_apply_cansleep(struc

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
Hi Ville, On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > On Tue, 28 Nov 2023, Maxime Ripard wrote: > > > > All the drm_connector_init variants ta

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: >> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: >> > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas >> > wrote: >> > > Geert Uytterhoeven writes: >> >

[PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()

2023-11-29 Thread Sean Young
In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_might_sleep(struct pwm *, struct pwm_state *); int pwm_apply_atomic(struct pwm *, struct pwm_state *); This commit just deals with renaming pwm

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 10:11:26AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > > > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: > > > > On Tue, 28 Nov

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas > > > wrote: > > > > Ge

Re: [PATCH] [drm/meson] meson_plane: Add error handling

2023-11-29 Thread neil . armstrong
Hi, Thanks for your patch! On 29/11/2023 10:21, Haoran Liu wrote: This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init call.

Re: [PATCH] drm/sched: Fix compilation issues with DRM priority rename

2023-11-29 Thread Sverdlin, Alexander
Hi Luben, thanks for the patch! On Sat, 2023-11-25 at 14:22 -0500, Luben Tuikov wrote: > Fix compilation issues with DRM scheduler priority rename MIN to LOW. > > Signed-off-by: Luben Tuikov > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202311252109.wgbjss

[PATCH] drm/panel: nt36523: fix return value check in nt36523_probe()

2023-11-29 Thread Yang Yingliang
From: Yang Yingliang mipi_dsi_device_register_full() never returns NULL pointer, it will return ERR_PTR() when it fails, so replace the check with IS_ERR(). Fixes: 0993234a0045 ("drm/panel: Add driver for Novatek NT36523") Signed-off-by: Yang Yingliang --- drivers/gpu/drm/panel/panel-novatek-n

[PATCH] [drm/meson] meson_plane: Add error handling

2023-11-29 Thread Haoran Liu
This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init call. Signed-off-by: Haoran Liu --- drivers/gpu/drm/meson/meson_plane.c

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Maxime Ripard wrote: > Hi Ville, > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: >> > On Tue, Nov 28, 2023 at 02:54:02PM +0200, Jani Nikula wrote: >> > > On Tue, 28 Nov 2023, Maxime Ripard wr

Re: [PATCH v3 07/11] drm/mediatek: Support alpha blending in VDOSYS0

2023-11-29 Thread 宋孝謙

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > pm_runtime_resume_and_get() already drops the runtime PM usage counter > > in the error case. So a call to pm_runtime_put_sync() can be dropped.

Re: [PATCH 0/3] drm/bridge: ti-sn65dsi86: Some updates

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 02:45:33AM +0200, Laurent Pinchart wrote: > On Fri, Nov 24, 2023 at 09:56:55AM +0100, Neil Armstrong wrote: > > On 23/11/2023 18:54, Uwe Kleine-König wrote: > > > Hello, > > > > > > this is a series I created while starring at the ti-sn65dsi86 driver in > >

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Javier, On Wed, Nov 29, 2023 at 10:13 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > >> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > >> > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canil

[PATCH] [drm/sti] sti_compositor: Add error handlingin sti_compositor_bind

2023-11-29 Thread Haoran Liu
Previously, the function sti_compositor_bind did not properly handle potential failure scenarios of drm_vblank_init, which could lead to unexpected behavior. This update adds a check for the return value of drm_vblank_init. Signed-off-by: Haoran Liu --- drivers/gpu/drm/sti/sti_compositor.c | 7 +

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 10:23 AM Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > > > On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote: > > > > On Tue, Nov 28, 2023 a

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify using pm_runtime_resume_and_get()

2023-11-29 Thread Laurent Pinchart
Hi Uwe, On Wed, Nov 29, 2023 at 10:51:37AM +0100, Uwe Kleine-König wrote: > On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > > pm_runtime_resume_and_get() already drops the runtime PM usage counter > > > in

Re: [PATCH 1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD status stable"

2023-11-29 Thread Robert Foss
On Mon, 20 Nov 2023 17:10:36 +0800, Xin Ji wrote: > This reverts commit 330140d7319fcc4ec68bd924ea212e476bf12275 > > 200ms delay will cause panel display image later than backlight > turn on, revert this patch. > > Applied, thanks! [1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD statu

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Pekka Paalanen
On Tue, 28 Nov 2023 15:49:08 +0200 Ville Syrjälä wrote: > Should we perhaps start to use the (arguably hideous) > - void f(struct foo *bar) > + void f(struct foo bar[static 1]) > syntax to tell the compiler we don't accept NULL pointers? > > Hmm. Apparently that has the same problem as using a

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Ville Syrjälä
On Wed, Nov 29, 2023 at 12:12:59PM +0200, Pekka Paalanen wrote: > On Tue, 28 Nov 2023 15:49:08 +0200 > Ville Syrjälä wrote: > > > Should we perhaps start to use the (arguably hideous) > > - void f(struct foo *bar) > > + void f(struct foo bar[static 1]) > > syntax to tell the compiler we don't a

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Dmitry Osipenko
On 11/29/23 10:53, Boris Brezillon wrote: > On Wed, 29 Nov 2023 01:05:14 +0300 > Dmitry Osipenko wrote: > >> On 11/28/23 15:37, Boris Brezillon wrote: >>> On Tue, 28 Nov 2023 12:14:42 +0100 >>> Maxime Ripard wrote: >>> Hi, On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezill

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 11:10:51AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 29, 2023 at 10:23 AM Maxime Ripard wrote: > > On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > > > On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote: > > > > On Tue, Nov 28, 2023 at 08:16:18PM

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 13:47:21 +0300 Dmitry Osipenko wrote: > On 11/29/23 10:53, Boris Brezillon wrote: > > On Wed, 29 Nov 2023 01:05:14 +0300 > > Dmitry Osipenko wrote: > > > >> On 11/28/23 15:37, Boris Brezillon wrote: > >>> On Tue, 28 Nov 2023 12:14:42 +0100 > >>> Maxime Ripard wrote: > >

Re: [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support

2023-11-29 Thread Andy Yan
Hi Sascha: On 11/29/23 16:52, Sascha Hauer wrote: On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote: Hi Sascha: thanks for you review. On 11/27/23 18:13, Sascha Hauer wrote: On Wed, Nov 22, 2023 at 08:56:01PM +0800, Andy Yan wrote: From: Andy Yan [1] /sys/kernel/

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 11:50 AM Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 11:10:51AM +0100, Geert Uytterhoeven wrote: > > On Wed, Nov 29, 2023 at 10:23 AM Maxime Ripard wrote: > > > On Wed, Nov 29, 2023 at 09:58:12AM +0100, Geert Uytterhoeven wrote: > > > > On Wed, Nov 29, 2023

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Maxime Ripard wrote: > > Hi Ville, > > > > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: > >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripard wrote: > >> > On Tue, Nov 28, 2023 at 02:54:02P

RE: [bug report] backlight: mp3309c: Add support for MPS MP3309C

2023-11-29 Thread Flavio Suligoi
Hi Dan, Can I add the "Reported-by" tag, with your name, in my 2nd vers of the commit to fix this bug? Thanks and regards, Flavio > -Original Message- > From: Flavio Suligoi > Sent: Tuesday, November 28, 2023 9:24 AM > To: Dan Carpenter > Cc: dri-devel@lists.freedesktop.org > Subject

[PATCH] drm/imagination: Fixed clang warnings for initial upstreamed patches.

2023-11-29 Thread Donald Robson
Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202311241752.3ilyyfca-...@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202311250632.givex7mu-...@intel.com/ Closes: https:

[PATCH v2] [drm/meson] meson_plane: Add error handling v2(re-aligned)

2023-11-29 Thread Haoran Liu
This patch adds robust error handling to the meson_plane_create function in drivers/gpu/drm/meson/meson_plane.c. The function previously lacked proper handling for potential failure scenarios of the drm_universal_plane_init call. Signed-off-by: Haoran Liu --- drivers/gpu/drm/meson/meson_plane.c

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 12:08:17PM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, Nov 29, 2023 at 11:50 AM Maxime Ripard wrote: > > On Wed, Nov 29, 2023 at 11:10:51AM +0100, Geert Uytterhoeven wrote: > > > On Wed, Nov 29, 2023 at 10:23 AM Maxime Ripard wrote: > > > > On Wed, Nov 29, 2

[PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Arnd Bergmann
From: Arnd Bergmann This warning option is now enabled by default, causing a few build regressions in combination with the newly added pvr driver: drivers/gpu/drm/imagination/pvr_device.c:130:6: error: no previous prototype for 'pvr_device_process_active_queues' [-Werror=missing-prototypes] 1

[PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Arnd Bergmann
From: Arnd Bergmann The array size calculation in pvr_vm_mips_fini() appears to be incorrect based on taking the size of the pointer rather than the size of the array, which manifests as a warning about signed integer overflow: In file included from include/linux/kernel.h:16,

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Jani Nikula
On Wed, 29 Nov 2023, Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: >> On Wed, 29 Nov 2023, Maxime Ripard wrote: >> > Hi Ville, >> > >> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville Syrjälä wrote: >> >> On Tue, Nov 28, 2023 at 02:29:40PM +0100, Maxime Ripa

Re: [bug report] backlight: mp3309c: Add support for MPS MP3309C

2023-11-29 Thread Dan Carpenter
On Wed, Nov 29, 2023 at 11:12:29AM +, Flavio Suligoi wrote: > Hi Dan, > > Can I add the "Reported-by" tag, with your name, in my 2nd vers of > the commit to fix this bug? Yeah. Thanks! If the bug report is sent to a public mailing list then there is no need to ask. regards, dan carpenter

Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Donald Robson
Hello Arnd, Thanks for the patch. I'm slightly concerned that we've not seen this warning when building here. I guess we need to check our CI settings... Reviewed-by: Donald Robson On Wed, 2023-11-29 at 12:33 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The array size calculation

[PATCH v8 0/8] Improve test coverage of TTM

2023-11-29 Thread Karolina Stolarek
Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of ttm_buffer_object also includes locking and unlocking the objec

[PATCH v8 1/8] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

2023-11-29 Thread Karolina Stolarek
Test initialization of ttm_resource using different memory domains. Add tests for a system memory manager and functions that can be tested without a fully-featured resource manager. Update ttm_bo_kunit_init() to initialize BO's kref and a genuine GEM drm object. Export ttm_resource_alloc for test p

[PATCH v8 2/8] drm/ttm/tests: Add tests for ttm_tt

2023-11-29 Thread Karolina Stolarek
Test initialization, creation and destruction of ttm_tt instances. Export ttm_tt_destroy and ttm_tt_create symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by: Amaranath Somalapuram --- drivers/gpu/drm/ttm/tests/Makefile| 1 + dri

[PATCH v8 6/8] drm/ttm/tests: Test simple BO creation and validation

2023-11-29 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Christian Köni

[PATCH v8 4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2023-11-29 Thread Karolina Stolarek
Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file

[PATCH v8 8/8] drm/ttm/tests: Add test cases dependent on fence signaling

2023-11-29 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 308

[PATCH v8 5/8] drm/ttm/tests: Use an init function from the helpers lib

2023-11-29 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm/t

[PATCH v8 7/8] drm/ttm/tests: Add tests with mock resource managers

2023-11-29 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by: Amar

[PATCH v8 3/8] drm/ttm/tests: Add tests for ttm_bo functions

2023-11-29 Thread Karolina Stolarek
Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Andi Shyti --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c |

Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Arnd Bergmann
On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote: > Hello Arnd, > > Thanks for the patch. I'm slightly concerned that we've not seen this > warning when > building here. I guess we need to check our CI settings... > > Reviewed-by: Donald Robson This was previously enabled only when building

Re: [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Donald Robson
Hello Arnd, Thanks for this. However, I fixed these in a patch a few minutes before you sent yours. I'm not sure what normally happens in these circumstances, but as my patch has the kernel robot tags and a few additional fixes, I think we should probably use that one. Thanks, Donald On Wed

Re: [PATCH] drm/imagination: Fixed clang warnings for initial upstreamed patches.

2023-11-29 Thread Maxime Ripard
Hi Donald, On Wed, Nov 29, 2023 at 11:20:14AM +, Donald Robson wrote: > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202311242159.hh8mwiam-...@intel.com/ > Closes: > https://lore.kernel.org/oe-kbuild-all/202311241752.3ilyyfca-...@intel.com/ > Closes: > h

Re: [EXTERNAL] Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning

2023-11-29 Thread Donald Robson
On Wed, 2023-11-29 at 13:04 +0100, Arnd Bergmann wrote: > *** CAUTION: This email originates from a source not known to Imagination > Technologies. Think before you click a link or open an attachment *** > > On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote: > > Hello Arnd, > > > > Thanks for

Re: [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Arnd Bergmann
On Wed, Nov 29, 2023, at 13:07, Donald Robson wrote: > Hello Arnd, > > Thanks for this. However, I fixed these in a patch a few minutes > before you sent > yours. I'm not sure what normally happens in these circumstances, but > as my patch has > the kernel robot tags and a few additional fixes,

[PATCH v6 00/10] drm: ci: fixes

2023-11-29 Thread Vignesh Raman
The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. v2: - Use fdtoverlay command to merge overlay dtbo with the base dtb instead of modifying

[PATCH v6 01/10] drm: ci: igt_runner: Remove todo

2023-11-29 Thread Vignesh Raman
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver. We do not test non-atomic drivers, so remove the todo. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - No changes v4: - No changes v5: - No changes v6: - No changes --- drivers/gpu/d

[PATCH v6 03/10] drm: ci: arm64.config: Enable DA9211 regulator

2023-11-29 Thread Vignesh Raman
Mediatek mt8173 board fails to boot with DA9211 regulator disabled. Enable CONFIG_REGULATOR_DA9211=y in arm64.config to fix mt8173 boot issue. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - Remove CONFIG_RTC_DRV_MT6397=y as it is already enabled in defconfig

[PATCH v6 02/10] drm: ci: Force db410c to host mode

2023-11-29 Thread Vignesh Raman
Force db410c to host mode to fix network issue which results in failure to mount root fs via NFS. See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 Use apq8016-sbc-usb-host.dtb which allows the USB controllers to work in host mode. Acked-by: Helen

[PATCH v6 04/10] drm: ci: Enable new jobs

2023-11-29 Thread Vignesh Raman
Enable the following jobs, as the issues noted in the TODO comments have been resolved. This will ensure that these jobs are now included and executed as part of the CI/CD pipeline. msm:apq8016: TODO: current issue: it is not fiding the NFS root. Fix and remove this rule. mediatek:mt8173: TODO: c

[PATCH v6 06/10] drm: ci: mediatek: Set IGT_FORCE_DRIVER for mt8173

2023-11-29 Thread Vignesh Raman
Expected driver for mt8173 is "mediatek" and for mt8183 it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as the expected driver for mt8173. Signed-off-by: Vignesh Raman --- v5: - Added a new patch in the series to set IGT_FORCE_DRIVER to 'mediatek' for mt8173 v6: - Use GPU_VERSION inst

[PATCH v6 05/10] drm: ci: Use scripts/config to enable/disable configs

2023-11-29 Thread Vignesh Raman
Instead of modifying files in git to enable/disable configs, use scripts/config on the .config file which will be used for building the kernel. Acked-by: Helen Koike Suggested-by: Jani Nikula Signed-off-by: Vignesh Raman --- v2: - Added a new patch in the series to use scripts/config to enab

[PATCH v6 07/10] drm: ci: virtio: Make artifacts available

2023-11-29 Thread Vignesh Raman
There were no artifacts available for virtio job. So make the artifacts available in the pipeline job. Signed-off-by: Vignesh Raman --- v5: - Added a new patch in the series to make artifacts available for virtio jobs v6: - No changes --- drivers/gpu/drm/ci/test.yml | 2 ++ 1 file changed

[PATCH v6 09/10] drm/doc: ci: Add IGT version details for flaky tests

2023-11-29 Thread Vignesh Raman
Document the IGT version in the flaky tests reporting template. Signed-off-by: Vignesh Raman --- v6: - Added a new patch in the series to update drm ci documentation --- Documentation/gpu/automated_testing.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documen

[PATCH v6 10/10] drm: ci: Update xfails

2023-11-29 Thread Vignesh Raman
Update msm-apq8016-fails, mediatek-mt8173-fails and virtio_gpu-none-fails to include the tests which fail. Signed-off-by: Vignesh Raman --- v2: - No changes v3: - No changes v4: - No changes v5: - Generate fails and flakes file with the updated xfails script - https://www.spinics.net

[PATCH v6 08/10] drm: ci: uprev IGT

2023-11-29 Thread Vignesh Raman
virtio-gpu kernel driver reports 16 for count_crtcs which exceeds IGT_MAX_PIPES set to 8 in igt-gpu-tools. This results in below memory corruption,  malloc(): corrupted top size  Received signal SIGABRT.  Stack trace:   #0 [fatal_sig_handler+0x17b]   #1 [__sigaction+0x40]   #2 [pthread_key_delete+

Re: [EXTERNAL] Re: [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings

2023-11-29 Thread Donald Robson
On Wed, 2023-11-29 at 13:16 +0100, Arnd Bergmann wrote: > *** CAUTION: This email originates from a source not known to Imagination > Technologies. Think before you click a link or open an attachment *** > > On Wed, Nov 29, 2023, at 13:07, Donald Robson wrote: > > Hello Arnd, > > > > Thanks for

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-11-29 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Nov 29, 2023 at 12:34 PM Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 12:08:17PM +0100, Geert Uytterhoeven wrote: > > On Wed, Nov 29, 2023 at 11:50 AM Maxime Ripard wrote: > > > On Wed, Nov 29, 2023 at 11:10:51AM +0100, Geert Uytterhoeven wrote: > > > > On Wed, Nov 29, 2023

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-29 Thread Maxime Ripard
Hi Linus, On Mon, Nov 27, 2023 at 11:13:31PM +0100, Linus Walleij wrote: > On Mon, Nov 27, 2023 at 5:29 PM Maxime Ripard wrote: > > On Mon, Nov 27, 2023 at 05:03:53PM +0100, Linus Walleij wrote: > > > > > Liu Ying (2): > > > > driver core: Export device_is_dependent() to modules > > > > drm/

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-29 Thread Maxime Ripard
Hi, Thanks for writing this down On Thu, Nov 16, 2023 at 03:53:20PM +, Simon Ser wrote: > On Thursday, November 9th, 2023 at 08:45, Simon Ser > wrote: > > > User-space sometimes needs to allocate scanout-capable memory for > > GPU rendering purposes. On a vc4/v3d split render/display SoC,

Re: [PATCH 10/10] ACPI: IORT: Allow COMPILE_TEST of IORT

2023-11-29 Thread Lorenzo Pieralisi
On Tue, Nov 28, 2023 at 08:48:06PM -0400, Jason Gunthorpe wrote: > The arm-smmu driver can COMPILE_TEST on x86, so expand this to also > enable the IORT code so it can be COMPILE_TEST'd too. > > Signed-off-by: Jason Gunthorpe > --- > drivers/acpi/Kconfig| 2 -- > drivers/acpi/Makefile

Re: [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support

2023-11-29 Thread Sascha Hauer
On Wed, Nov 29, 2023 at 07:01:37PM +0800, Andy Yan wrote: > Hi Sascha: > > > > On 11/29/23 16:52, Sascha Hauer wrote: > > On Mon, Nov 27, 2023 at 06:56:34PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > thanks for you review. > > > > > > On 11/27/23 18:13, Sascha Hauer wrote:

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 01:05:14 +0300 > Dmitry Osipenko wrote: > > > On 11/28/23 15:37, Boris Brezillon wrote: > > > On Tue, 28 Nov 2023 12:14:42 +0100 > > > Maxime Ripard wrote: > > > > > >> Hi, > > >> > > >> On Fri, Nov 24, 202

Re: [PATCH v6 06/10] drm: ci: mediatek: Set IGT_FORCE_DRIVER for mt8173

2023-11-29 Thread Daniel Stone
Hi Vignesh, On Wed, 29 Nov 2023 at 12:19, Vignesh Raman wrote: > Expected driver for mt8173 is "mediatek" and for mt8183 > it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as > the expected driver for mt8173. Actually, for mt8183 it's both. And for mt8173 it will probably be mediatek+pvr pre

Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 01:40:38PM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Maxime Ripard wrote: > > On Wed, Nov 29, 2023 at 11:38:42AM +0200, Jani Nikula wrote: > >> On Wed, 29 Nov 2023, Maxime Ripard wrote: > >> > Hi Ville, > >> > > >> > On Tue, Nov 28, 2023 at 03:49:08PM +0200, Ville S

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 14:09:47 +0100 Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > > On Wed, 29 Nov 2023 01:05:14 +0300 > > Dmitry Osipenko wrote: > > > > > On 11/28/23 15:37, Boris Brezillon wrote: > > > > On Tue, 28 Nov 2023 12:14:42 +0100 > > > >

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-29 Thread Alyssa Ross
Thomas Zimmermann writes: > Hi > > Am 27.11.23 um 17:25 schrieb Alyssa Ross: >> Thomas Zimmermann writes: >> >>> Invoke drm_plane_helper_funcs.end_fb_access before >>> drm_atomic_helper_commit_hw_done(). The latter function hands over >>> ownership of the plane state to the following commit, wh

Re: Radeon regression in 6.6 kernel

2023-11-29 Thread Alex Deucher
On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote: > > On 2023-11-28 17:13, Alex Deucher wrote: > > On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote: > >> > >> Alex Deucher writes: > >> > In that case those are the already known problems with the scheduler > changes, aren't they? >

About resuming in the remove callback

2023-11-29 Thread Uwe Kleine-König
Hello Laurent, On Wed, Nov 29, 2023 at 12:11:50PM +0200, Laurent Pinchart wrote: > On Wed, Nov 29, 2023 at 10:51:37AM +0100, Uwe Kleine-König wrote: > > On Wed, Nov 29, 2023 at 02:39:55AM +0200, Laurent Pinchart wrote: > > > On Thu, Nov 23, 2023 at 06:54:27PM +0100, Uwe Kleine-König wrote: > > > >

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-29 Thread Vignesh Raman
Hi Jani, On 28/11/23 18:33, Jani Nikula wrote: On Tue, 28 Nov 2023, Vignesh Raman wrote: On 28/11/23 12:21, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: Hi Mani, On 28/11/23 10:44, Manivannan Sadhasivam wrote: On Tue, Nov 28, 2023 at 09:50:26A

[PATCH v1 1/1] drm/i915/display: Don't use "proxy" headers

2023-11-29 Thread Andy Shevchenko
The driver uses math.h and not util_macros.h. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c index

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-29 Thread Linus Walleij
On Wed, Nov 29, 2023 at 1:32 PM Maxime Ripard wrote: [Me] > > It is a bigger evil to leave the tree broken than to enforce formal process, > > and it is pretty self-evident. If any of them get annoyed about it we can > > revert the patch, or both. > > Yeah, I definitely understand why you did it,

[PATCH v3 00/12] RB1/QCM2290 features

2023-11-29 Thread Konrad Dybcio
This series brings: - interconnect plumbing - display setup for QCM2290/QRB2210 and - CAN bus controller - HDMI display - wifi fw variant name for QTI RB1 and the necessary bindings changes Patch 1-2 is for Dmitry/freedreno Patch 3 for Georgi/icc Patch 5 for Will/iommu the rest are for Bjorn/q

[PATCH v3 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-29 Thread Konrad Dybcio
The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC"), but the example hasn't been updated to reflect that. Fix that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compat

[PATCH v3 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-29 Thread Konrad Dybcio
Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are other connection paths: - a path that connects rotator block to the DDR. - a path that needs to be handled to ensure MDSS register access functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG interconnect. Describ

[PATCH v3 03/12] dt-bindings: interconnect: qcom,msm8998-bwmon: Add QCM2290 bwmon instance

2023-11-29 Thread Konrad Dybcio
QCM2290 has a single BWMONv4 intance for CPU. Document it. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/interconnect

[PATCH v3 04/12] dt-bindings: firmware: qcom,scm: Allow interconnect for everyone

2023-11-29 Thread Konrad Dybcio
Every Qualcomm SoC physically has a "CRYPTO0<->DDR" interconnect lane. Allow this property to be present, no matter the SoC. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 15 --- 1 file changed, 15 deleti

[PATCH v3 07/12] arm64: dts: qcom: sc7280: Add the missing MDSS icc path

2023-11-29 Thread Konrad Dybcio
MDSS, aside from the MDP-MEM path, also requires the CPU-DISP_CFG one. Failing to provide it may result in register accesses failing and that's never good. Add the missing path. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++-- 1 file changed, 7 insertions(+),

[PATCH v3 08/12] arm64: dts: qcom: qcm2290: Add display nodes

2023-11-29 Thread Konrad Dybcio
Add the required nodes to support display on QCM2290. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 214 ++ 1 file changed, 214 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm6

[PATCH v3 10/12] arm64: dts: qcom: qrb2210-rb1: Set up HDMI

2023-11-29 Thread Konrad Dybcio
Add the required nodes to support display output via the HDMI port. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 86 1 file changed, 86 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.

[PATCH v3 06/12] arm64: dts: qcom: sc7180: Add the missing MDSS icc path

2023-11-29 Thread Konrad Dybcio
MDSS, aside from the MDP-MEM path, also requires the CPU-DISP_CFG one. Failing to provide it may result in register accesses failing and that's never good. Add the missing path. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++-- 1 file changed, 6 insertions(+),

[PATCH v3 05/12] iommu/arm-smmu-qcom: Add QCM2290 MDSS compatible

2023-11-29 Thread Konrad Dybcio
Add the QCM2290 MDSS compatible to clients compatible list, as it also needs the workarounds. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[PATCH v3 11/12] arm64: dts: qcom: qrb2210-rb1: Enable CAN bus controller

2023-11-29 Thread Konrad Dybcio
Enable the Microchip mcp2518fd hosted on the SPI5 bus. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts index

[PATCH v3 09/12] arm64: dts: qcom: qcm2290: Hook up interconnects

2023-11-29 Thread Konrad Dybcio
Add interconnect provider nodes and hook up interconnects to consumer devices, including bwmon. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 248 ++ 1 file changed, 248 insertions(+) diff --git a/arch/arm

  1   2   3   >