Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-11-17 Thread Shyam Sundar S K
On 10/19/2023 2:31 PM, Christian König wrote: > Am 18.10.23 um 19:05 schrieb Shyam Sundar S K: >> >> On 10/18/2023 9:37 PM, Christian König wrote: >>> Am 18.10.23 um 17:47 schrieb Mario Limonciello: On 10/18/2023 08:40, Christian König wrote: > > Am 18.10.23 um 11:28 schrieb Shyam S

Re: [PATCH] drm/ili9163: Add "1.8-128160EF" to spi_device_id table

2023-11-17 Thread Javier Martinez Canillas
Mostafa Weshahy writes: Hello Mostafa, > drm/ili9163: Add "1.8-128160EF" to spi_device_id table > > Currently enabling CONFIG_TINYDRM_ILI9163 driver - regardless of the device > tree - results in the below confusing log line: > SPI driver ili9163 has no spi_device_id for newhaven,1.8-128160EF >

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-11-17 Thread Shyam Sundar S K
Hi Hans, Apologies for the long delay. On 10/19/2023 12:38 AM, Hans de Goede wrote: > Hi, > > I was not following this at first, so my apologies for > jumping in in the middle of the thread: > > > > >> +static int amd_pmf_gpu_get_cur_state(struct thermal_cooling_device >> *cooling_d

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

2023-11-17 Thread Thomas Hellström
Hi, On 11/16/23 14:13, Bagas Sanjaya wrote: On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: +TODO: Pointer to the gpuvm code implementation if this iteration and "... implementation of this iteration ..." +Using a MMU notifier for device DMA (and other methods) is describe

Re: [PATCH 3/3] drm/ssd130x: Change "solomon,page-offset" property default value

2023-11-17 Thread Maxime Ripard
On Thu, Nov 16, 2023 at 07:07:39PM +0100, Javier Martinez Canillas wrote: > This is used to specify the page start address offset of the display RAM. > > The value is used as offset when setting the page start address with the > SSD130X_SET_PAGE_RANGE command, and the driver currently sets its val

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-17 Thread Maxime Ripard
On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote: > On 10/9/23 10:58, Neil Armstrong wrote: > > On 09/10/2023 00:33, Marek Vasut wrote: > > > Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, > > > ones which match both the datasheet and the panel display_timing fl

[PATCH v7 0/8] Improve test coverage of TTM

2023-11-17 Thread Karolina Stolarek
Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of ttm_buffer_object also includes locking and unlocking the objec

[PATCH v7 1/8] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

2023-11-17 Thread Karolina Stolarek
Test initialization of ttm_resource using different memory domains. Add tests for a system memory manager and functions that can be tested without a fully-featured resource manager. Update ttm_bo_kunit_init() to initialize BO's kref and a genuine GEM drm object. Export ttm_resource_alloc for test p

[PATCH v7 2/8] drm/ttm/tests: Add tests for ttm_tt

2023-11-17 Thread Karolina Stolarek
Test initialization, creation and destruction of ttm_tt instances. Export ttm_tt_destroy and ttm_tt_create symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by: Amaranath Somalapuram --- drivers/gpu/drm/ttm/tests/Makefile| 1 + dri

[PATCH v7 3/8] drm/ttm/tests: Add tests for ttm_bo functions

2023-11-17 Thread Karolina Stolarek
Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 619 ++ d

[PATCH v7 5/8] drm/ttm/tests: Use an init function from the helpers lib

2023-11-17 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm/t

[PATCH v7 4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2023-11-17 Thread Karolina Stolarek
Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/

[PATCH v7 7/8] drm/ttm/tests: Add tests with mock resource managers

2023-11-17 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig

[PATCH v7 8/8] drm/ttm/tests: Add test cases dependent on fence signaling

2023-11-17 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 308 ++ 1 file changed

[PATCH v7 6/8] drm/ttm/tests: Test simple BO creation and validation

2023-11-17 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/te

Re: [PATCH] drm/etnaviv: Expose a few more chipspecs to userspace

2023-11-17 Thread Christian Gmeiner
Hi Tomeu > > These ones will be needed to make use fo the NN and TP units in the NPUs > based on Vivante IP. > > Also fix the number of NN cores in the VIPNano-qi. > > Signed-off-by: Tomeu Vizoso > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 20 > drivers/gpu/drm/etnaviv

Re: [PATCH 3/3] drm/ssd130x: Change "solomon,page-offset" property default value

2023-11-17 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > On Thu, Nov 16, 2023 at 07:07:39PM +0100, Javier Martinez Canillas wrote: >> This is used to specify the page start address offset of the display RAM. >> >> The value is used as offset when setting the page start address with the >> SSD130X_SET_PAGE_RANGE c

Re: [PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-17 Thread Christian König
Am 17.11.23 um 04:18 schrieb Luben Tuikov: On 2023-11-13 07:38, Christian König wrote: Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Thanks Christian for doing t

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-17 Thread Dmitry Baryshkov
On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: > > Hi, > > On 2023/11/16 23:23, Dmitry Baryshkov wrote: > Then you will need some way (fwnode?) to > discover the bridge chain. And at the last point you will get into the > device data and/or properties business. > > >>> No, l

Re: [PATCH v5 0/7] drm: Reuse temporary memory for format conversion

2023-11-17 Thread Maxime Ripard
On Mon, Oct 09, 2023 at 04:06:29PM +0200, Thomas Zimmermann wrote: > DRM's format-conversion helpers require temporary memory. Pass the > buffer from the caller to allow the caller to preallocate the buffer > memory. > > The motivation for this patchset is the recent work on a DRM panic > handler.

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-17 Thread Sascha Hauer
On Fri, Nov 17, 2023 at 03:06:35PM +0800, Andy Yan wrote: > Hi Sebastian: > > On 11/16/23 21:47, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: > > > > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > > > > > "rockchip,gr

[PULL] drm-misc-next

2023-11-17 Thread Maxime Ripard
Hi, Here's the first drm-misc-next PR for what will become 6.8. There's one missing SoB on the commit 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") from the committer. They provided their SoB on the ML here after the facts: https://lore.kernel.org/dri-devel/ce94020e-a7d4-4799-b87d-fbea

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-17 Thread Maxime Ripard
On Fri, Nov 17, 2023 at 01:18:49AM +0800, Sui Jingfeng wrote: > > On 2023/11/16 23:23, Dmitry Baryshkov wrote: > > On Thu, 16 Nov 2023 at 14:08, Sui Jingfeng wrote: > > > > > > On 2023/11/16 19:53, Sui Jingfeng wrote: > > > > Hi, > > > > > > > > > > > > On 2023/11/16 19:29, Dmitry Baryshkov wr

Re: [PATCH v5 0/7] drm: Reuse temporary memory for format conversion

2023-11-17 Thread Thomas Zimmermann
Hi Am 17.11.23 um 10:34 schrieb Maxime Ripard: On Mon, Oct 09, 2023 at 04:06:29PM +0200, Thomas Zimmermann wrote: DRM's format-conversion helpers require temporary memory. Pass the buffer from the caller to allow the caller to preallocate the buffer memory. The motivation for this patchset is

Re: [PATCH] drm/print: Handle NULL drm device in __drm_printk()

2023-11-17 Thread Jani Nikula
On Thu, 16 Nov 2023, Luben Tuikov wrote: > drm_{err,warn,...}() use __drm_printk() which takes a drm device pointer and > uses the embedded device pointer to print the device. This facility handles > NULL device pointer, but not NULL drm device pointer. This patch makes > __drm_printk() also handl

Re: [PATCH v5 0/7] drm: Reuse temporary memory for format conversion

2023-11-17 Thread Daniel Vetter
On Fri, 17 Nov 2023 at 11:07, Thomas Zimmermann wrote: > > Hi > > Am 17.11.23 um 10:34 schrieb Maxime Ripard: > > On Mon, Oct 09, 2023 at 04:06:29PM +0200, Thomas Zimmermann wrote: > >> DRM's format-conversion helpers require temporary memory. Pass the > >> buffer from the caller to allow the call

Re: [PULL] drm-misc-fixes

2023-11-17 Thread Daniel Vetter
On Thu, Nov 16, 2023 at 02:48:52PM +0100, Maarten Lankhorst wrote: > Hi Dave, Daniel, > > Small pull request, mostly nouveau fixes. > > Cheers, > ~Maarten > > Mostly drm-misc-fixes-2023-11-16: > Assorted fixes for v6.7-rc2: > - Nouveau GSP fixes. > - Fix nouveau driver load without display. > -

Re: [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

2023-11-17 Thread Ville Syrjälä
On Thu, Nov 16, 2023 at 03:18:31PM +0200, Imre Deak wrote: > On UHBR links the PBN divider is a fractional number, accordingly store > it in fixed point format. For now drm_dp_get_vc_payload_bw() always > returns a whole number and all callers will use only the integer part of > it which should pre

Re: [Intel-gfx] [PATCH v2 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-17 Thread Ville Syrjälä
On Thu, Nov 16, 2023 at 03:18:32PM +0200, Imre Deak wrote: > The current way of calculating the pbn_div value, the link BW per each > MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR > rates calculating with the correct channel coding efficiency based on > the link rate. > > v2:

Re: [Intel-gfx] [PATCH v2 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-17 Thread Ville Syrjälä
On Thu, Nov 16, 2023 at 03:18:33PM +0200, Imre Deak wrote: > Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 > and UHBR link configurations. > > Cc: Lyude Paul > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Imre Deak > --- > .../gpu/drm/tests/drm_dp_mst_helper_tes

Re: [pull] amdgpu drm-fixes-6.7

2023-11-17 Thread Daniel Vetter
On Fri, Nov 17, 2023 at 01:34:41AM -0500, Alex Deucher wrote: > Hi Dave, Sima, > > Fixes for 6.7. > > The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86: > > Linux 6.7-rc1 (2023-11-12 16:19:07 -0800) > > are available in the Git repository at: > > https://gitlab.fr

Re: [PATCH v2 4/5] drm/plane: Extend damage tracking kernel-doc

2023-11-17 Thread Thomas Zimmermann
Hi Am 16.11.23 um 16:24 schrieb Pekka Paalanen: On Thu, 16 Nov 2023 13:34:07 +0100 Thomas Zimmermann wrote: Hi Am 16.11.23 um 13:14 schrieb Simon Ser: On Thursday, November 16th, 2023 at 13:06, Thomas Zimmermann wrote: + * Note that there are two types of damage handling: frame damag

Re: [v7,4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2023-11-17 Thread Dominik Karol Piatkowski
Reviewed-by: Dominik Karol Piątkowski

[PATCH v3 1/1] backlight: pwm_bl: Use dev_err_probe

2023-11-17 Thread Alexander Stein
Use dev_err_probe to simplify error paths. Also let dev_err_probe handle the -EPROBE_DEFER case and add an entry to /sys/kernel/debug/devices_deferred when deferred. Signed-off-by: Alexander Stein --- Changes in v3: * Fix alignment on continuation * Small fixes to commit message Changes in v2: *

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

2023-11-17 Thread Mikhail Gavrilov
On Thu, Nov 16, 2023 at 11:56 PM Alex Deucher wrote: > > This patch should address the issue: > https://patchwork.freedesktop.org/patch/567101/ > If you still see issues, you may also need this series: > https://patchwork.freedesktop.org/series/126220/ > > Alex Thanks. The first one patch is enou

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-17 Thread Maxime Ripard
On Fri, Nov 17, 2023 at 12:24:22PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/11/16 23:23, Dmitry Baryshkov wrote: > > > > > Then you will need some way (fwnode?) to > > > > > discover the bridge chain. And at the last point you will get into the > > > > > device data and/or properties business.

Re: [PATCH 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag

2023-11-17 Thread Bruno Prémont
On Thu, 16 Nov 2023 11:27:55 +0100 Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > The picolcd_fb driver operates on system memory. Mark the framebuffer > > accordingly. Helpers operating on the framebuffer memory will test > > for the presence of this flag. > > > > Signed-off-b

[PATCH v2] dma-buf: heaps: Introduce cma_heap_add() for non-default CMA heap

2023-11-17 Thread Jaskaran Singh
From: Kunihiko Hayashi Currently dma-buf heaps can handle only default CMA. This exposes __add_cma_heap(), renamed to cma_heap_add(), as a public API to initialize CMA heaps from a pointer to a CMA region. At first, the driver calls of_reserved_mem_device_init() to set memory-region property ass

Re: [PATCH v7 0/8] Improve test coverage of TTM

2023-11-17 Thread Christian König
No idea how you managed to do this, but now Amar is CCed on the patches he already tested and *not* CCed on the new ones and the cover letter :) @Amar can you pick up the latest patches from the mailing list and give them another round of testing? I will try to find time to give that some rev

Re: [Intel-gfx] [PATCH v2 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-17 Thread Imre Deak
On Fri, Nov 17, 2023 at 01:00:58PM +0200, Ville Syrjälä wrote: > On Thu, Nov 16, 2023 at 03:18:32PM +0200, Imre Deak wrote: > > The current way of calculating the pbn_div value, the link BW per each > > MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR > > rates calculating with t

Re: Use after free with GEM shadow-buffered planes

2023-11-17 Thread Thomas Zimmermann
Hi Am 15.11.23 um 17:32 schrieb Alyssa Ross: [Originally reported at https://gitlab.freedesktop.org/drm/misc/-/issues/33] The following happens in a cycle: • An atomic state is allocated • A plane state is allocated (drm_gem_duplicate_shadow_plane_state()) • Commit (drm_atomic_helper_com

Re: [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

2023-11-17 Thread Imre Deak
On Fri, Nov 17, 2023 at 12:56:36PM +0200, Ville Syrjälä wrote: > On Thu, Nov 16, 2023 at 03:18:31PM +0200, Imre Deak wrote: > > On UHBR links the PBN divider is a fractional number, accordingly store > > it in fixed point format. For now drm_dp_get_vc_payload_bw() always > > returns a whole number

Re: [Intel-gfx] [PATCH v2 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-17 Thread Imre Deak
On Fri, Nov 17, 2023 at 01:04:02PM +0200, Ville Syrjälä wrote: > On Thu, Nov 16, 2023 at 03:18:33PM +0200, Imre Deak wrote: > > Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 > > and UHBR link configurations. > > > > Cc: Lyude Paul > > Cc: dri-devel@lists.freedesktop.org >

Re: [PATCH v3] drm/i915/vma: Fix VMA UAF on destroy against deactivate race

2023-11-17 Thread Andi Shyti
Hi Janusz, On Thu, Nov 16, 2023 at 03:07:20PM +0100, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object from when parking a GPU tile believed > to be idle. > > [161.359441] ODEBUG: free active (active state 0) o

[PATCH v3 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-17 Thread Imre Deak
The current way of calculating the pbn_div value, the link BW per each MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR rates calculating with the correct channel coding efficiency based on the link rate. v2: - Return the fractional pbn_div value from drm_dp_get_vc_payload_bw().

[PATCH v3 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-17 Thread Imre Deak
Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 and UHBR link configurations. v2: - List test cases in decreasing rate,lane count order matching the corresponding DP Standard tables. (Ville) - Add references to the DP Standard tables. Cc: Ville Syrjälä Cc: Lyude Paul Cc

[PATCH] drm/msm: Reduce fallout of fence signaling vs reclaim hangs

2023-11-17 Thread Rob Clark
From: Rob Clark Until various PM devfreq/QoS and interconnect patches land, we could potentially trigger reclaim from gpu scheduler thread, and under enough memory pressure that could trigger a sort of deadlock. Eventually the wait will timeout and we'll move on to consider other GEM objects. B

[PATCH] drm/msm/gpu: Skip retired submits in recover worker

2023-11-17 Thread Rob Clark
From: Rob Clark If we somehow raced with submit retiring, either while waiting for worker to have a chance to run or acquiring the gpu lock, then the recover worker should just bail. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 41 +++ 1 file cha

Re: [RFC PATCH] drm/imx: ipuv3-plane: Allow preventing sequential DMA bursts

2023-11-17 Thread Miquel Raynal
Hello, miquel.ray...@bootlin.com wrote on Fri, 27 Oct 2023 18:20:25 +0200: > Sequential DMA bursts improve NIC/RAM usage thanks to the basic NIC > hardware optimizations available when performing in-order sequential > accesses. This can be further enforced with the IPU DMA locking > mechanism whi

[PATCH v4 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-17 Thread Imre Deak
Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 and UHBR link configurations. v2: - List test cases in decreasing rate,lane count order matching the corresponding DP Standard tables. (Ville) - Add references to the DP Standard tables. v3: - Sort the testcases properly. Cc

Re: [PATCH] accel/ivpu/37xx: Fix hangs related to MMIO reset

2023-11-17 Thread Jeffrey Hugo
On 11/15/2023 4:10 AM, Jacek Lawrynowicz wrote: There is no need to call MMIO reset using VPU_37XX_BUTTRESS_VPU_IP_RESET register. IP will be reset by FLR or by entering d0i3. Also IP reset during power_up is not needed as the VPU is already in reset. Removing MMIO reset improves stability as it

Re: [PATCH v4 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-17 Thread Ville Syrjälä
On Fri, Nov 17, 2023 at 05:27:37PM +0200, Imre Deak wrote: > Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 > and UHBR link configurations. > > v2: > - List test cases in decreasing rate,lane count order matching the > corresponding DP Standard tables. (Ville) > - Add ref

Re: [PATCH v8 0/6] drm: Add support for atomic async page-flip

2023-11-17 Thread Simon Ser
It seems like commits were re-ordered at some point. I think we need "drm: introduce drm_mode_config.atomic_async_page_flip_not_supported" to come before "drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits" because the latter uses atomic_async_page_flip_not_supported. Similarly, "drm: Refuse to

Re: [PATCH v3 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-17 Thread Ville Syrjälä
On Fri, Nov 17, 2023 at 05:09:27PM +0200, Imre Deak wrote: > The current way of calculating the pbn_div value, the link BW per each > MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR > rates calculating with the correct channel coding efficiency based on > the link rate. > > v2:

Re: [PATCH 4/6] drm/amdkfd: Export DMABufs from KFD using GEM handles

2023-11-17 Thread Christian König
Am 16.11.23 um 22:53 schrieb Felix Kuehling: On 2023-11-07 11:58, Felix Kuehling wrote: Create GEM handles for exporting DMABufs using GEM-Prime APIs. The GEM handles are created in a drm_client_dev context to avoid exposing them in user mode contexts through a DMABuf import. This patch (and th

[PULL] drm-fixes for -rc2

2023-11-17 Thread Daniel Vetter
Hi Linus, This is a "blast from the bast" fixes pull, because it contains a bunch of AGP fixes for amdgpu. Otherwise nothing out of the ordinary. Next week is back to Dave unless he's knocked out by some conference bug. Cheers! drm-fixes-2023-11-17: drm-fixes for -rc2 - amdgpu: fixes all over,

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-17 Thread Marek Vasut
On 11/17/23 09:40, Maxime Ripard wrote: On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote: On 10/9/23 10:58, Neil Armstrong wrote: On 09/10/2023 00:33, Marek Vasut wrote: Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, ones which match both the datasheet and

Re: [PATCH V2] drm/panel: boe-tv101wum-nl6: Fine tune Himax83102-j02 panel HFP and HBP

2023-11-17 Thread Doug Anderson
Hi, On Thu, Nov 16, 2023 at 7:25 PM Cong Yang wrote: > > The refresh reported by modetest is 60.46Hz, and the actual measurement > is 60.01Hz, which is outside the expected tolerance. Presumably you've swapped the numbers above? The value reported by modetest is 60.01Hz and the actual measuremen

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-17 Thread Sui Jingfeng
Hi, On 2023/11/17 17:03, Dmitry Baryshkov wrote: On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: Hi, On 2023/11/16 23:23, Dmitry Baryshkov wrote: Then you will need some way (fwnode?) to discover the bridge chain. And at the last point you will get into the device data and/or properties bu

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-17 Thread Sui Jingfeng
Hi, On 2023/11/17 17:03, Dmitry Baryshkov wrote: On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: Hi, On 2023/11/16 23:23, Dmitry Baryshkov wrote: Then you will need some way (fwnode?) to discover the bridge chain. And at the last point you will get into the device data and/or properties b

[PATCH 0/2] Convert to persistent DRM devices

2023-11-17 Thread Jeffrey Hugo
The qaic driver currently creates and destroys the DRM devices when the qaic device is in an operational state for userspace. This does not match what other DRM drivers do, and leads to a few race conditions that need to be handled. Instead, create the DRM device when the underlying PCIe device is

[PATCH 2/2] accel/qaic: Expand DRM device lifecycle

2023-11-17 Thread Jeffrey Hugo
From: Carl Vanderlip Currently the QAIC DRM device registers itself when the MHI QAIC_CONTROL channel becomes available. This is when the device is able to process workloads. However, the DRM driver also provides the debugfs interface bootlog for the device. If the device fails to boot to the QSM

[PATCH 1/2] accel/qaic: Increase number of in_reset states

2023-11-17 Thread Jeffrey Hugo
From: Carl Vanderlip 'in_reset' holds the state of the device. As part of bringup, the device needs to be queried to check if it's in a valid state. Add a new state that indicates that the device is coming up, but not ready for users yet. Rename to 'reset_state' to better describe the variable.

Re: [PATCH] accel/qaic: Update MAX_ORDER use to be inclusive

2023-11-17 Thread Jeffrey Hugo
On 11/3/2023 9:33 AM, Jeffrey Hugo wrote: MAX_ORDER was redefined so that valid allocations to the page allocator are in the range of 0..MAX_ORDER, inclusive in the commit 23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely"). We are treating MAX_ORDER as an exclusive value, and thus could be

Re: [PATCH v3 1/1] backlight: pwm_bl: Use dev_err_probe

2023-11-17 Thread Uwe Kleine-König
Hello Alexander, On Fri, Nov 17, 2023 at 01:06:25PM +0100, Alexander Stein wrote: > Use dev_err_probe to simplify error paths. Also let dev_err_probe handle > the -EPROBE_DEFER case and add an entry to > /sys/kernel/debug/devices_deferred when deferred. > > Signed-off-by: Alexander Stein Review

[PATCH] drm/rockchip: lvds: do not print error message when deferring probe

2023-11-17 Thread Quentin Schulz
ret = -EPROBE_DEFER; goto err_put_port; } --- base-commit: 7475e51b87969e01a6812eac713a1c8310372e8a change-id: 20231117-rk-lvds-defer-msg-b2944b73d791 Best regards, -- Quentin Schulz

Re: [PATCH] dma-buf: Replace strlcpy() with strscpy()

2023-11-17 Thread T.J. Mercier
On Thu, Nov 16, 2023 at 11:14 AM Kees Cook wrote: > > strlcpy() reads the entire source buffer first. This read may exceed > the destination size limit. This is both inefficient and can lead > to linear read overflows if a source string is not NUL-terminated[1]. > Additionally, it returns the size

Re: [PATCH v7 6/8] drm/ttm/tests: Test simple BO creation and validation

2023-11-17 Thread kernel test robot
-20231117] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Karolina-Stolar

Re: [PATCH v5 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-11-17 Thread Harry Wentland
On 2023-11-16 14:57, Melissa Wen wrote: Add 3D LUT property for plane color transformations using a 3D lookup table. 3D LUT allows for highly accurate and complex color transformations and is suitable to adjust the balance between color channels. It's also more complex to manage and require more

Re: [PATCH] drm/rockchip: lvds: do not print error message when deferring probe

2023-11-17 Thread Fabio Estevam
Hi Quentin, On Fri, Nov 17, 2023 at 3:31 PM Quentin Schulz wrote: > > From: Quentin Schulz > > This scary message may happen if the panel or bridge is not probed > before the LVDS controller is, resulting in some head scratching because > the LVDS panel is actually working, since a later try wil

Re: [Intel-gfx] [PATCH v3 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-17 Thread Rodrigo Vivi
On Fri, Nov 17, 2023 at 06:21:07PM +0200, Ville Syrjälä wrote: > On Fri, Nov 17, 2023 at 05:09:27PM +0200, Imre Deak wrote: > > The current way of calculating the pbn_div value, the link BW per each > > MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR > > rates calculating with t

[PATCH V2 0/5] Elida KD35T133 Panel Improvements

2023-11-17 Thread Chris Morgan
From: Chris Morgan Fix a few bugs and clean up no longer needed code on the Elida KD35T133 DSI panel, as used in devices such as the Odroid Go Advance and the Anbernic RG351M. Changes since V1: - Split removal of shutdown logic into a new patch independent of dropping of prepared tracking.

[PATCH V2 4/5] drm/panel-elida-kd35t133: Drop shutdown logic

2023-11-17 Thread Chris Morgan
From: Chris Morgan The driver shutdown is duplicate as it calls drm_unprepare and drm_disable which are called anyway when associated drivers are shutdown/removed. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 17 - 1 file changed, 17 deletions(

[PATCH V2 5/5] drm/panel-elida-kd35t133: Drop prepare/unprepare logic

2023-11-17 Thread Chris Morgan
From: Chris Morgan Drop the prepare/unprepare logic, as this is now tracked elsewhere since this commit [1]. [1] commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 11 --- 1

[PATCH V2 2/5] drm/panel-elida-kd35t133: hold panel in reset for unprepare

2023-11-17 Thread Chris Morgan
From: Chris Morgan For devices like the Anbernic RG351M and RG351P the panel is wired to an always on regulator. When the device suspends and wakes up, there are some slight artifacts on the screen that go away over time. If instead we hold the panel in reset status after it is unprepared, this d

[PATCH V2 3/5] drm/panel-elida-kd35t133: drop drm_connector_set_orientation_from_panel

2023-11-17 Thread Chris Morgan
From: Chris Morgan Stop calling drm_connector_set_orientation_from_panel() as its now called by the panel bridge directly when it is initialized. Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 5 - 1 file changed, 5 deletions(-)

[PATCH V2 1/5] drm/panel-elida-kd35t133: trival: update panel size from 5.5 to 3.5

2023-11-17 Thread Chris Morgan
From: Chris Morgan The comments at the top of the driver state the panel size incorrectly as 5.5" instead of 3.5". Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH V4 2/6] drm/panel: nv3051d: Hold panel in reset for unprepare

2023-11-17 Thread Chris Morgan
From: Chris Morgan Improve the panel's ability to restore from suspend by holding the panel in suspend after unprepare. Fixes: b1d39f0f4264 ("drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel") Signed-off-by: Chris Morgan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-newvision-

[PATCH V4 5/6] arm64: dts: rockchip: Update powkiddy, rgb30 include to rk2023 DTSI

2023-11-17 Thread Chris Morgan
From: Chris Morgan The Powkiddy RGB30 device is similar to the Anbernic RGxx3 series, however there are several differences which require deleting nodes in order to properly define the hardware. This was deemed unacceptable for the RK2023, so instead create a common include file for the Powkiddy

[PATCH V4 0/6] rockchip: Add Powkiddy RK2023

2023-11-17 Thread Chris Morgan
From: Chris Morgan Add support for the Powkiddy RK2023, which is extremely similar to existing Powkiddy RGB30 device. Changes since V3: - Corrected commit subject lines. Changes since V2: - Split "hold panel in reset" to a separate patch for the NV3051D. - Changed replaced common include to

[PATCH V4 4/6] dt-bindings: arm: rockchip: Add Powkiddy RK2023

2023-11-17 Thread Chris Morgan
From: Chris Morgan The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and powered by the Rockchip RK3566 SoC. Group the Powkiddy RK3566 based devices together as they are both extremely similar. Signed-off-by: Chris Morgan Acked-by: Krzysztof Kozlowski --- Documentation/devicetr

[PATCH V4 1/6] dt-bindings: display: nv3051d: Update NewVision NV3051D compatibles

2023-11-17 Thread Chris Morgan
From: Chris Morgan Update the NewVision NV3051D compatible strings by adding a new panel, the powkiddy,rk2023-panel, and removing another entry, the anbernic,rg353v-panel. The rk2023-panel is similar to the rg353p-panel but has slightly different timings so it needs a new string. The rg353v-pan

[PATCH V4 6/6] arm64: dts: rockchip: Add Powkiddy RK2023

2023-11-17 Thread Chris Morgan
From: Chris Morgan Add support for the Powkiddy RK2023. The Powkiddy RK2023 is a handheld gaming device with a 3.5 inch screen powered by the Rockchip RK3566 SoC. The device looks physically different from the Powkiddy RGB30, but is functionally identical except for the panel. Signed-off-by: Chr

[PATCH V4 3/6] drm/panel: nv3051d: Add Powkiddy RK2023 Panel Support

2023-11-17 Thread Chris Morgan
From: Chris Morgan Refactor the driver to add support for the powkiddy,rk2023-panel panel. This panel is extremely similar to the rg353p-panel but requires a smaller vertical back porch and isn't as tolerant of higher speeds. Note that while all of these panels are identical in size (70x57) it is

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

2023-11-17 Thread Andy Shevchenko
On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote: > On Thu, 16 Nov 2023, Hans de Goede wrote: > > Ok, this now has been testen on both a BYT and a CHT device which > > actually use GPIO controls in their MIPI sequences so this > > series is: > > > > Tested-by: Hans de Goede > > > > And

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

2023-11-17 Thread Andy Shevchenko
On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote: > On 11/3/23 21:18, Andy Shevchenko wrote: > > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > > talking to GPIO IP behind the actual driver's back. A second attempt > > to fix that is here. > > > > If I underst

Re: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value

2023-11-17 Thread Andy Shevchenko
On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote: > This is used to specify the page start address offset of the display RAM. > > The value is used as offset when setting the page start address with the > SSD130X_SET_PAGE_RANGE command, and the driver currently sets its val

Re: [PATCH V2 2/5] drm/panel-elida-kd35t133: hold panel in reset for unprepare

2023-11-17 Thread Jessica Zhang
On 11/17/2023 11:44 AM, Chris Morgan wrote: From: Chris Morgan For devices like the Anbernic RG351M and RG351P the panel is wired to an always on regulator. When the device suspends and wakes up, there are some slight artifacts on the screen that go away over time. If instead we hold the pan

Re: [V3] drm/panel: auo, b101uan08.3: Fine tune the panel power sequence

2023-11-17 Thread Doug Anderson
Hi, On Mon, Nov 13, 2023 at 8:42 PM Xuxin Xiong wrote: > > For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that > MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. > > Fixes: 56ad624b4cb5 ("drm/panel: support for auo, b101uan08.3 wuxga dsi video > mo

[PATCH v7 0/3] Use correct mode for edp panel

2023-11-17 Thread Hsin-Yi Wang
This series contains 2 part to handle mode selection for edp panel: 1. (patch 1, 2) Add a quirk to override the edid mode for generic edp. 2. (patch 3) If a panel contains hardcoded mode, skip edid mode. Previous versions: v1: https://patchwork.kernel.org/project/dri-devel/cover/20231101212604.16

[PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v6->v7: split usecase

[PATCH v7 2/3] drm/panel-edp: Add auo_b116xa3_mode

2023-11-17 Thread Hsin-Yi Wang
Add auo_b116xa3_mode to override the original modes parsed from edid of the panels 0x405c B116XAK01.0 and 0x615c B116XAN06.1 which result in glitches on panel. Signed-off-by: Hsin-Yi Wang --- v6->v7: split usecase to another patch. --- drivers/gpu/drm/panel/panel-edp.c | 19 +--

[PATCH v7 3/3] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-17 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson

[PATCH 1/3] Revert "drm/prime: Unexport helpers for fd/handle conversion"

2023-11-17 Thread Felix Kuehling
This reverts commit 71a7974ac7019afeec105a54447ae1dc7216cbb3. These helper functions are needed for KFD to export and import DMABufs the right way without duplicating the tracking of DMABufs associated with GEM objects while ensuring that move notifier callbacks are working as intended. CC: Chris

[PATCH 2/3] drm/amdkfd: Export DMABufs from KFD using GEM handles

2023-11-17 Thread Felix Kuehling
Create GEM handles for exporting DMABufs using GEM-Prime APIs. The GEM handles are created in a drm_client_dev context to avoid exposing them in user mode contexts through a DMABuf import. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c

[PATCH 3/3] drm/amdkfd: Import DMABufs for interop through DRM

2023-11-17 Thread Felix Kuehling
Use drm_gem_prime_fd_to_handle to import DMABufs for interop. This ensures that a GEM handle is created on import and that obj->dma_buf will be set and remain set as long as the object is imported into KFD. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu Reviewed-by: Xiaogang.Chen Ac

Re: [PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Greg KH
On Fri, Nov 17, 2023 at 01:46:32PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > > Signed-off-by

Re: [PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Hsin-Yi Wang
On Fri, Nov 17, 2023 at 2:06 PM Greg KH wrote: > > On Fri, Nov 17, 2023 at 01:46:32PM -0800, Hsin-Yi Wang wrote: > > Generic edp gets mode from edid. However, some panels report incorrect > > mode in this way, resulting in glitches on panel. Introduce a new quirk > > additional_mode to the generic

Re: [PATCH v7 2/3] drm/panel-edp: Add auo_b116xa3_mode

2023-11-17 Thread Hsin-Yi Wang
On Fri, Nov 17, 2023 at 1:51 PM Hsin-Yi Wang wrote: > > Add auo_b116xa3_mode to override the original modes parsed from edid > of the panels 0x405c B116XAK01.0 and 0x615c B116XAN06.1 which result > in glitches on panel. > > Signed-off-by: Hsin-Yi Wang > --- > v6->v7: split usecase to another patc

Re: [PULL] drm-fixes for -rc2

2023-11-17 Thread pr-tracker-bot
The pull request you sent on Fri, 17 Nov 2023 18:02:21 +0100: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-11-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e63fe2d35ee095b483adf936747dbc7d85f3de38 Thank you! -- Deet-doot-dot, I am a bot. https://k

  1   2   >