Re: [PATCH v7 6/6] drm/i915/panelreplay: Debugfs support for panel replay

On Fri, 2023-11-03 at 06:10 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Thursday, November 2, 2023 1:08 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org; Murthy, Arun R > > ; Nikula,

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

Am 02.11.23 um 00:31 schrieb Danilo Krummrich: Implement reference counting for struct drm_gpuvm. From the design point of view what is that good for? Background is that the most common use case I see is that this object is embedded into something else and a reference count is then not really

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

On 02/11/2023 18:56, Uwe Kleine-König wrote: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resou

Re: [PATCH v2] drm/i915: Fix potential spectre vulnerability

On 03/11/2023 06:56, Krzysztof Kozlowski wrote: On 03/11/2023 03:32, Kunwu Chan wrote: Fix smatch warning: drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() warn: potential spectre issue 'pc->user_engines' [r] (local cap) Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-co

Re: [PATCH v9 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

Il 31/10/23 09:33, Moudy Ho ha scritto: Add a compatible string for the PADDING block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 08/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

Il 31/10/23 09:33, Moudy Ho ha scritto: Add the fundamental hardware configuration of component STITCH, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 10/16] dt-bindings: media: mediatek: mdp3: add component TDSHP for MT8195

Il 31/10/23 09:33, Moudy Ho ha scritto: Add the fundamental hardware configuration of component TDSHP, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

Hi Huacai, On 2023-11-02 Thu 08:38pm, Huacai Chen wrote: > Hi, Jaak, > > On Wed, Nov 1, 2023 at 7:52 PM Jaak Ristioja wrote: > > > > On 31.10.23 14:17, Huacai Chen wrote: > > > Hi, Jaak and Evan, > > > > > > On Sun, Oct 29, 2023 at 9:42 AM Huacai Chen wrote: > > >> > > >> On Sat, Oct 28, 2023 a

Re: [accel/ivpu] Help -- Which Intel CPU processor can be used for iVPU driver？

Yes, NPU should be available on future desktop chips. On 02.11.2023 12:09, Trigger Huang wrote: > Hi Jacek, > > Thanks for the quick response. > > Seems I need to wait for a while if I want to buy a Meteor Lake based > platform because I got the following message from wiki( > *https://en.wikipe

Re: [PATCH v2 3/6] drm/panfrost: Implement ability to turn on/off GPU clocks in suspend

Il 03/11/23 06:12, Chen-Yu Tsai ha scritto: On Thu, Nov 2, 2023 at 10:26 PM AngeloGioacchino Del Regno wrote: Currently, the GPU is being internally powered off for runtime suspend and turned back on for runtime resume through commands sent to it, but note that the GPU doesn't need to be clock

Re: [PATCH v2 3/6] drm/panfrost: Implement ability to turn on/off GPU clocks in suspend

On Fri, Nov 3, 2023 at 4:54 PM AngeloGioacchino Del Regno wrote: > > Il 03/11/23 06:12, Chen-Yu Tsai ha scritto: > > On Thu, Nov 2, 2023 at 10:26 PM AngeloGioacchino Del Regno > > wrote: > >> > >> Currently, the GPU is being internally powered off for runtime suspend > >> and turned back on for r

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

Hi Maxime, Thank you for posting v3, this time it runs fine on my RPi 4, thank you for fixing that. I'll start working on a conformity checker for this. I have a few remarks: On 31/10/2023 17:48, Maxime Ripard wrote: > There has been some discussions recently about the infoframes sent by > driv

Re: [PATCH v7 1/6] drm/panelreplay: dpcd register definition for panelreplay

On Wed, 11 Oct 2023, Animesh Manna wrote: > Add DPCD register definition for discovering, enabling and > checking status of panel replay of the sink. > > Cc: Jouni Högander > Cc: Arun R Murthy > Cc: Jani Nikula > Reviewed-by: Arun R Murthy > Signed-off-by: Animesh Manna Maarten, Maxime, Thom

Re: [RFC 03/11] drm: introduce drm evictable LRU

Am 03.11.23 um 05:04 schrieb Zeng, Oak:[SNIP] I also want to have a more advanced iterator at some point where we grab the BO lock for keeping a reference into the LRU list. Not sure how to do this if we don't have the BO here any more. Need to think about that further, Don't quite get the what

Re: [PATCH] drm/sched: Eliminate drm_sched_run_job_queue_if_ready()

On 02/11/2023 22:46, Luben Tuikov wrote: Eliminate drm_sched_run_job_queue_if_ready() and instead just call drm_sched_run_job_queue() in drm_sched_free_job_work(). The problem is that the former function uses drm_sched_select_entity() to determine if the scheduler had an entity ready in one of

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote: > Am 02.11.23 um 00:31 schrieb Danilo Krummrich: > > Implement reference counting for struct drm_gpuvm. > > From the design point of view what is that good for? It was discussed in this thread [1]. Essentially, the idea is to make

[PATCH v2 0/4] drm: Fix errors about uninitialized/wrong variables

Fix cases where smatch reports a use of an uninitialized variable, and one where the variable is initialized but contains wrong value. Tomi Signed-off-by: Tomi Valkeinen --- Changes in v2: - Added two more fixes - Link to v1: https://lore.kernel.org/r/20230804-uninit-fixes-v1-0-a60772c04...@id

[PATCH v2 2/4] drm/framebuffer: Fix use of uninitialized variable

smatch reports: drivers/gpu/drm/drm_framebuffer.c:654 drm_mode_getfb2_ioctl() error: uninitialized symbol 'ret'. 'ret' is possibly not set when there are no errors, causing the error above. I can't say if that ever happens in real-life, but in any case I think it is good to initialize 'ret' to 0

[PATCH v2 3/4] drm/bridge: cdns-mhdp8546: Fix use of uninitialized variable

'ret' could be uninitialized at the end of the function, although it's not clear if that can happen in practice. Fixes: 6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP") Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 3 ++- 1 file changed, 2 insert

[PATCH v2 1/4] drm/drm_file: fix use of uninitialized variable

smatch reports: drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'. 'supported_status' is only set in one code path. I'm not familiar with the code to say if that path will always be ran in real life, but whether that is the case or not, I think

[PATCH v2 4/4] drm/bridge: tc358767: Fix return value on error case

If the hpd_pin is invalid, the driver returns 'ret'. But 'ret' contains 0, instead of an error value. Return -EINVAL instead. Fixes: f25ee5017e4f ("drm/bridge: tc358767: add IRQ and HPD support") Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 inser

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

Am 03.11.23 um 14:14 schrieb Danilo Krummrich: On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote: Am 02.11.23 um 00:31 schrieb Danilo Krummrich: Implement reference counting for struct drm_gpuvm. From the design point of view what is that good for? It was discussed in this thre

RE: [RFC 03/11] drm: introduce drm evictable LRU

From: Christian König Sent: Friday, November 3, 2023 5:36 AM To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org Cc: thomas.hellst...@linux.intel.com; felix.kuehl...@amd.com; airl...@gmail.com; Welty, Brian Subject: Re: [RFC 03/11] drm: introduce drm evictable LRU

[RFC][PATCH v5 0/6] drm/panic: Add a drm panic handler

This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comments/10eccv9/config_vtn_in_2023/ Fbcon

[PATCH v5 3/6] drm/simpledrm: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drive

[PATCH v5 2/6] drm/panic: Add a drm panic handler

This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis) *

[PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. v5: * Change the drawing API, use drm_fb_blit_from_r1() to draw the font. * Also add drm_fb_fill() to fill area with background color. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/dr

[PATCH v5 4/6] drm/mgag200: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 25 + 1 file c

[PATCH v5 6/6] drm/imx: Add drm_panic support

Proof of concept to add drm_panic support on an arm based GPU. I've tested it with X11/llvmpipe, because I wasn't able to have 3d rendering with etnaviv on my imx6 board. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 30 1 file changed, 30

[PATCH v5 5/6] drm/ast: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- drivers/gpu/drm/ast/ast_drv.h | 3 +++ drivers/gpu/drm/ast/ast_mode.c | 26 ++ 3 files c

Re: [PATCH] accel/qaic: Quiet array bounds check on DMA abort message

On 10/27/2023 12:08 PM, Jeffrey Hugo wrote: From: Carl Vanderlip Current wrapper is right-sized to the message being transferred; however, this is smaller than the structure defining message wrappers since the trailing element is a union of message/transfer headers of various sizes (8 and 32 by

Re: [PATCH] accel/qaic: Support for 0 resize slice execution in BO

On 10/27/2023 10:43 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Add support to partially execute a slice which is resized to zero. Executing a zero size slice in a BO should mean that there is no DMA transfers involved but you should still configure doorbell and semaphores. For

Re: [PATCH] drm/sched: Eliminate drm_sched_run_job_queue_if_ready()

On Thu, Nov 02, 2023 at 06:46:54PM -0400, Luben Tuikov wrote: > Eliminate drm_sched_run_job_queue_if_ready() and instead just call > drm_sched_run_job_queue() in drm_sched_free_job_work(). The problem is that > the former function uses drm_sched_select_entity() to determine if the > scheduler had a

[PATCH] accel/qaic: Update MAX_ORDER use to be inclusive

MAX_ORDER was redefined so that valid allocations to the page allocator are in the range of 0..MAX_ORDER, inclusive in the commit 23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely"). We are treating MAX_ORDER as an exclusive value, and thus could be requesting larger allocations. Update our

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

On 11/3/23 15:04, Christian König wrote: Am 03.11.23 um 14:14 schrieb Danilo Krummrich: On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote: Am 02.11.23 um 00:31 schrieb Danilo Krummrich: Implement reference counting for struct drm_gpuvm. From the design point of view what is tha

Re: [Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

On Wed, Nov 01, 2023 at 02:44:46PM -0700, Zhanjun Dong wrote: > The gt wedged could be triggered by missing guc firmware file, HW not > working, etc. Once triggered, it means all gt usage is dead, therefore we > can't enable pxp under this fatal error condition. > > v2: Updated commit message. >

[PATCH] drivers: gpu: Fix warning using plain integer as NULL

sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case this warning is being shown because we are trying to intialize a pointer to NULL using integer value 0. Signed-off-by: Abhinav Singh --- drivers/gpu/drm/radeon/clearstate_evergre

VM_BIND locking document

Danilo, Boris As you might know we have a task to complete a VM_BIND locking document including userptr gating the Xe driver upstreaming. I have version 3 of that document out as a patch https://patchwork.freedesktop.org/series/122508/ updated with the latest gpuvm changes, including the fin

Re: [PATCH] drm/ast: use managed devres functions

On 30/10/2023 10:50, Philipp Stanner wrote: Currently, tha ast-driver just maps the PCI-dev's regions with pcim_iomap(). It does not actually reserve the regions exclusively with, e.g., pci_request_regions(). Replace the calls to pcim_iomap() with ones to pcim_iomap_regions() to reserve and map

Re: [PATCH v2 1/4] drm/panel-edp: Add several AUO/BOE panels

Hi, On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > Besides, modify the following panel: > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According > to the datasheet: T3

Re: [PATCH v2 3/4] drm/modes: Add a function to clear preferred modes

Hi, On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > Add a function to clear the preferred bit of a connector's existing modes. > This is useful for edp panel to unset the preferred modes read from edid > if the panel has hard-coded modes. > > Signed-off-by: Hsin-Yi Wang > --- > v1->v2: >

Re: [PATCH v2 4/4] drm/panel-edp: Choose correct preferred mode

Hi, On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > If a non generic edp-panel is under aux-bus, the mode read from edid would > still be selected as preferred and results in multiple preferred modes, > which is ambiguous. > > If a hard-coded mode is present, unset the preferred bit of the

Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63

On 11/2/2023 11:19 AM, Clayton Craft wrote: This panel is found on laptops e.g., variants of the Thinkpad X13s. Configuration was collected from the panel's EDID. Signed-off-by: Clayton Craft LGTM Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- V2: renamed to "*_mode" since th

[pull] amdgpu, amdkfd, radeon drm-next-6.7

Hi Dave, Sima, Fixes for 6.7. The following changes since commit 631808095a82e6b6f8410a95f8b12b8d0d38b161: Merge tag 'amd-drm-next-6.7-2023-10-27' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2023-10-31 12:37:19 +1000) are available in the Git repository at: https://gitla

Re: [PULL] drm-misc-next

Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 02ce6baacdad..08c088319652 100644 --- a/drivers/gpu/drm/drm_gpuvm.c

[PATCH] fbdev: omapfb: Drop unused remove function

OMAP2_VRFB is a bool, so the vrfb driver can never be compiled as a module. With that __exit_p(vrfb_remove) always evaluates to NULL and vrfb_remove() is unused. If the driver was compilable as a module, it would fail to build because the type of vrfb_remove() isn't compatible with struct platform

[PATCH v2] drm/ast: use managed devres functions

Currently, tha ast-driver just maps the PCI-dev's regions with pcim_iomap(). It does not actually reserve the regions exclusively with, e.g., pci_request_regions(). Replace the calls to pcim_iomap() with ones to pcim_iomap_regions() to reserve and map the regions simultaneously. Suggested-by: Tho

Re: [PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

Hi Jocelyn, kernel test robot noticed the following build warnings: [auto build test WARNING on ffc253263a1375a65fa6c9f62a893e9767fbebfa] url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Add-drm_fb_blit_from_r1-and-drm_fb_fill/20231103-225824 base

Re: [PATCH] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

On 11/2/2023 6:08 AM, xiazhengqiao wrote: For "starry, 2081101qfh032011-53g" this panel, it is stipulated in the Hi Zhengqiao, Nit: Can you reword this to "For the "starry, 2081101qfh032011-53g" panel..."? panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pul

Re: [PATCH v5 5/6] drm/ast: Add drm_panic support

Hi Jocelyn, kernel test robot noticed the following build warnings: [auto build test WARNING on ffc253263a1375a65fa6c9f62a893e9767fbebfa] url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Add-drm_fb_blit_from_r1-and-drm_fb_fill/20231103-225824 base

[PATCH v2 0/9] Improvements to pcie_bandwidth_available() for eGPUs

Downstream drivers are getting the wrong values from pcie_bandwidth_available() which is causing problems for performance of eGPUs. This series overhauls Thunderbolt related device detection and uses the changes to change the behavior of pcie_bandwidth_available(). NOTE: This series is currently

[PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to using dev_is_removable() to be able to detect USB4 devices as well. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/nouveau/nouveau_vga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH v2 2/9] drm/radeon: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to using dev_is_removable() to be able to detect USB4 devices as well. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/radeon_device.c | 4 ++-- drivers/gpu/drm/radeon/radeon_kms.c| 2 +- 2 files changed, 3 in

[PATCH v2 4/9] PCI: Move the `PCI_CLASS_SERIAL_USB_USB4` definition to common header

`PCI_CLASS_SERIAL_USB_USB4` may be used by code outside of thunderbolt. Move the declaration into the common pci_ids.h header. Acked-by: Mika Westerberberg Signed-off-by: Mario Limonciello --- drivers/thunderbolt/nhi.h | 2 -- include/linux/pci_ids.h | 1 + 2 files changed, 1 insertion(+), 2

[PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()

All callers have switched to dev_is_removable() for detecting hotpluggable PCIe devices. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index b56417276042..530b0a360514

[PATCH v2 5/9] PCI: pciehp: Move check for is_thunderbolt into a quirk

commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt ports") added a check into pciehp code to explicitly set NoCompl+ for all Intel Thunderbolt controllers, including those that don't need it. This overloaded the purpose of the `is_thunderbolt` member of `struct pci_device` because

[PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

The `is_thunderbolt` bit has been used to indicate that a PCIe device contained the Intel VSEC which is used by various parts of the kernel to change behavior. To later allow usage with USB4 controllers as well, rename this to `is_tunneled`. Signed-off-by: Mario Limonciello --- drivers/pci/pci.c

[PATCH v2 7/9] PCI: ACPI: Detect PCIe root ports that are used for tunneling

USB4 routers support a feature called "PCIe tunneling". This allows PCIe traffic to be transmitted over USB4 fabric. PCIe root ports that are used in this fashion can be discovered by device specific data that specifies the USB4 router they are connected to. For the PCI core, the specific connecti

[PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

The USB4 spec specifies that PCIe ports that are used for tunneling PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and behave as a PCIe Gen1 device. The actual performance of these ports is controlled by the fabric implementation. Downstream drivers such as amdgpu which utili

[PATCH v2 9/9] PCI: Add a quirk to mark 0x8086 : 0x9a23 as supporting PCIe tunneling

The PCI root port used for tunneling USB4 traffic on Tiger Lake is is not marked as tunneling but has the same limitations as other PCIe root ports used for tunneling. This causes pcie_bandwidth_available() to treat it as the limiting device in the PCI hierarchy and downstream driver to program de

Re: [PATCH v2 1/4] drm/panel-edp: Add several AUO/BOE panels

On Fri, Nov 3, 2023 at 9:02 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > Add a few generic edp panels used by mt8186 chromebooks. > > Besides, modify the following panel: > > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > > - AUO 0x405c B116XAK0

Re: [PATCH v2 4/4] drm/panel-edp: Choose correct preferred mode

On Fri, Nov 3, 2023 at 9:03 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > If a non generic edp-panel is under aux-bus, the mode read from edid would > > still be selected as preferred and results in multiple preferred modes, > > which is ambiguous.

Re: [PATCH v2 0/9] Improvements to pcie_bandwidth_available() for eGPUs

On Fri, Nov 03, 2023 at 02:07:49PM -0500, Mario Limonciello wrote: > Downstream drivers are getting the wrong values from > pcie_bandwidth_available() which is causing problems for performance > of eGPUs. > > This series overhauls Thunderbolt related device detection and uses > the changes to chan

Re: [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

Hi Andy, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-intel/for-linux-next-fixes linus/master v6.6 next-20231103] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

Hi, On 11/3/23 20:07, Mario Limonciello wrote: > The `is_thunderbolt` bit has been used to indicate that a PCIe device > contained the Intel VSEC which is used by various parts of the kernel > to change behavior. To later allow usage with USB4 controllers as well, > rename this to `is_tunneled`. >

[PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915

From: Jani Nikula Follow the contemporary conventions. Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Jani Nikula Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/

[PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()

From: Jani Nikula The lowest level functions are about setting GPIO values, not about executing any sequences anymore. Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Jani Nikula Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++--

[PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence

From: Jani Nikula With the various sequence versions and pointer increments interleaved, it's a bit hard to decipher what's going on. Add separate paths for different sequence versions. Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Jani Nikula Signed-off-by: Andy Shevchenko --- drive

[PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO

From: Jani Nikula Purely a guess. Drop the nop function. Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Jani Nikula Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu

[PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

From: Jani Nikula Drop the unused parameter. Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Jani Nikula Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/displa

[PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name

Names of the MIPI sequence steps are sequential and defined, no need to check for the gaps. However in seq_name the MIPI_SEQ_END is missing. Add it there, and drop unneeded NULL check in sequence_name(). Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/g

[rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

DSI code for VBT has a set of ugly GPIO hacks, one of which is direct talking to GPIO IP behind the actual driver's back. A second attempt to fix that is here. If I understood correctly, my approach should work in the similar way as the current IOSF GPIO. Hans, I believe you have some devices tha

[PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back

It's a dirty hack in the driver that pokes GPIO registers behind the driver's back. Moreoever it might be problematic as simultaneous I/O may hang the system, see the commit 40ecab551232 ("pinctrl: baytrail: Really serialize all register accesses") for the details. Taking all this into consideratio

[PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio()

For a couple of cases the branches call the same bxt_gpio_set_value(). As Ville suggested they can be combined by dropping the DISPLAY_VER() check from Gen 11 to Gen 9. Do it that way. Suggested-by: Ville Syrjälä Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c |

[PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition

Move existing condition to while(), so it will be clear on what circumstances the loop is successfully finishing. Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else'

In the snippets like the following if (...) return / goto / break / continue ...; else ... the 'else' is redundant. Get rid of it. Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/int

[PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()

From: Hans de Goede Fix wrong initial value for GPIOs in bxt_gpio_set_value(). Signed-off-by: Hans de Goede Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities

Currently soc_gpio_set_value() supports only a single indexing for GPIO pin. For CHV case, for example, we will need to distinguish community based index from the one that VBT is using. Introduce an additional parameter to soc_gpio_set_value() and its callers. Signed-off-by: Andy Shevchenko Acked

[PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()

From: Hans de Goede To properly deal with GPIOs used in MIPI panel sequences a temporary GPIO lookup will be used. Since there can only be 1 GPIO lookup table for the ":00:02.0" device this will not work if the GPIO lookup table used by intel_dsi_vbt_gpio_init() is still registered. After ge

[PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

It's a dirty hack in the driver that pokes GPIO registers behind the driver's back. Moreoever it might be problematic as simultaneous I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl: cherryview: prevent concurrent access to GPIO controllers") for the details. Taking all this into con

[PATCH v4 16/16] drm/i915/iosf: Drop unused APIs

Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write(). Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/gpu/drm/i915/vlv_sideband.c | 17 - drivers/gpu/drm/i915/vlv_sideband.h | 3 --- 2 files changed, 20 deletions(-) diff --git a/drivers/gpu/drm/i915/vlv_side

[PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper

Extract a common soc_gpio_set_value() helper that may be used by a few SoCs. Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[PATCH v8 0/6] Panel replay phase1 implementation

Panel Replay is a power saving feature for DP 2.0 monitor and similar to PSR on EDP. These patches are basic enablement patches added on top of existing psr framework to enable full-screen live active frame update mode of panel replay. Panel replay also can be enabled in selective update mode whic

[PATCH v8 1/6] drm/panelreplay: dpcd register definition for panelreplay

Add DPCD register definition for discovering, enabling and checking status of panel replay of the sink. Cc: Jouni Högander Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Animesh Manna --- include/drm/display/drm_dp.h | 23 +++ 1 file changed,

[PATCH v8 2/6] drm/i915/psr: Move psr specific dpcd init into own function

From: Jouni Högander This patch is preparing adding panel replay specific dpcd init. Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 41 +--- 1 file changed, 23 insertions(+), 18 de

[PATCH v8 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

Modify existing PSR implementation to enable panel replay feature of DP 2.0 which is similar to PSR feature of EDP panel. There is different DPCD address to check panel capability compare to PSR and vsc sdp header is different. v1: Initial version. v2: - Set source_panel_replay_support flag under

[PATCH v8 5/6] drm/i915/panelreplay: enable/disable panel replay

TRANS_DP2_CTL register is programmed to enable panel replay from source and sink is enabled through panel replay dpcd configuration address. Bspec: 1407940617 v1: Initial version. v2: - Use pr_* flags instead psr_* flags. [Jouni] - Remove intel_dp_is_edp check as edp1.5 also has panel replay. [Jo

[PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

Add debugfs support which will print source and sink status per connector basis. Existing i915_psr_status and i915_psr_sink_status will be used to get the source and sink status of panel replay. v1: Initial version. [rb-ed by Arun] v2: Added check for DP 2.0 and connector type in connector_debugfs

[PATCH v8 4/6] drm/i915/panelreplay: Enable panel replay dpcd initialization for DP

Due to similarity panel replay dpcd initialization got added in psr function which is specific for edp panel. This patch enables panel replay initialization for dp connector. Cc: Jouni Högander Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Animesh Manna --- driv

RE: [PATCH v7 6/6] drm/i915/panelreplay: Debugfs support for panel replay

> -Original Message- > From: Hogander, Jouni > Sent: Friday, November 3, 2023 12:32 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Murthy, Arun R > ; Nikula, Jani > Subject: Re: [PATCH v7 6/6] drm/i915/panelreplay: Debugfs support fo

Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63

On Thu, 2 Nov 2023 at 20:19, Clayton Craft wrote: > > This panel is found on laptops e.g., variants of the Thinkpad X13s. > Configuration was collected from the panel's EDID. > > Signed-off-by: Clayton Craft > --- > > V2: renamed to "*_mode" since there is only 1 mode listed > > drivers/gpu/drm/

Re: [PATCH v18 25/26] drm/virtio: Support shmem shrinking

On Sun, Oct 29, 2023 at 4:03 PM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > Support generic drm-shmem memory shrinker and add new madvise IOCTL to > the VirtIO-GPU driver. BO cache manager of Mesa driver will mark BOs as > "don't need" using the new IOCTL to let shrinker purge the ma

[PATCH v6 0/6] drm: simplify support for transparent DRM bridges

Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a different way resulted either in series of hacks or in device tree not reflecting the actual hardware design. This results in drivers having similar boilerp

[PATCH v6 2/6] phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE

Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Acked-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44

[PATCH v6 3/6] usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE

Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Reviewed-by: Heikki Krogerus Acked-by: Greg Kroah-Hartman Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +- drivers/usb/typ

[PATCH v6 6/6] usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE

Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/tcpm/Kconfig| 1 + drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 41 +++ 2 files

[PATCH v6 1/6] drm/bridge: add transparent bridge helper

Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any additio

[PATCH v6 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Reviewed-by: Bjorn Andersson Acked-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/Kconfig | 1 + drivers/soc/qcom/pmic_glink_al

[PATCH v6 4/6] drm/bridge: implement generic DP HPD bridge

Several USB-C controllers implement a pretty simple DRM bridge which implements just the HPD notification operations. Add special helper for creating such simple bridges. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/Kconfig | 8 ++ drivers/gpu/drm/bridge/Makefile

Re: [PATCH] drm/sched: Eliminate drm_sched_run_job_queue_if_ready()

Hi Matt, :-) On 2023-11-03 11:13, Matthew Brost wrote: > On Thu, Nov 02, 2023 at 06:46:54PM -0400, Luben Tuikov wrote: >> Eliminate drm_sched_run_job_queue_if_ready() and instead just call >> drm_sched_run_job_queue() in drm_sched_free_job_work(). The problem is that >> the former function uses dr

  1   2   >