Re: [PATCH 0/6] accel/ivpu: Update to -next 2023-10-20

2023-10-23 Thread Stanislaw Gruszka
On Fri, Oct 20, 2023 at 12:44:55PM +0200, Stanislaw Gruszka wrote: > Random changes across the driver. > > Karol Wachowski (1): > accel/ivpu: Read clock rate only if device is up > > Krystian Pradzynski (3): > accel/ivpu: Use ratelimited warn and err in IPC/JSM > accel/ivpu: Fix verbose ver

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 09:52, Alexander Stein wrote: > > Hi Dmitry, > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > On Thu, 19 Oct 2023 at 14:42, Alexander Stein > > > > wrote: > > > Hi, > > > > > > Am Donnerstag, 19. Oktober 2023, 13:19:51 CEST schrieb Dmitry Barysh

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Neil Armstrong
On 16/10/2023 18:53, Dmitry Baryshkov wrote: The MIPI DSI links do not fully fall into the DRM callbacks model. The drm_bridge_funcs abstraction. Instead of having just two states (off and on) the DSI hosts have separate LP-11 state. In this state the host is on, but the video stream is not yet e

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-23 Thread Evan Preston
On 2023-10-20 Fri 05:48pm, Huacai Chen wrote: > On Fri, Oct 20, 2023 at 5:35 PM Linux regression tracking (Thorsten > Leemhuis) wrote: > > > > On 09.10.23 10:54, Huacai Chen wrote: > > > On Mon, Oct 9, 2023 at 4:45 PM Bagas Sanjaya wrote: > > >> On Mon, Oct 09, 2023 at 09:27:02AM +0800, Huacai Ch

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 10:35, Neil Armstrong wrote: > > On 16/10/2023 18:53, Dmitry Baryshkov wrote: > > The MIPI DSI links do not fully fall into the DRM callbacks model. The > > drm_bridge_funcs abstraction. Instead of having just two states (off and > > on) the DSI hosts have separate LP-11 sta

[PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Albert Esteve
v6: Shift DRIVER_CURSOR_HOTSPOT flag bit to BIT(9), since BIT(8) was already taken by DRIVER_GEM_GPUVA. v5: Add a change with documentation from Michael, based on his discussion with Pekka and bump the kernel version DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT might be introduced with to 6.6. v4: Make dr

[PATCH v6 1/9] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-10-23 Thread Albert Esteve
From: Zack Rusin Cursor planes on virtualized drivers have special meaning and require that the clients handle them in specific ways, e.g. the cursor plane should react to the mouse movement the way a mouse cursor would be expected to and the client is required to set hotspot properties on it in

[PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Cc: Maaz Mombasawala Reviewed-by: Javier Martinez Canillas Reviewed-by: Martin Krastev --- dr

[PATCH v6 2/9] drm/atomic: Add support for mouse hotspots

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting code lacked support for specifying mouse cursor hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting the hotspot but the functionality was not implemented in the new atomic paths. Due to the lack of hotspots in the atomic paths userspace com

[PATCH v6 4/9] drm/qxl: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Reviewed-by: Gerd Hoffmann Cc: Dave Airlie Cc: Daniel Vetter Cc: virtualizat...@lists.linux-fo

[PATCH v6 6/9] drm/virtio: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Reviewed-by: Gerd Hoffmann Cc: David Airlie Cc: Gurchetan Singh Cc: Chia-I Wu Cc: Daniel Vett

[PATCH v6 8/9] drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT

2023-10-23 Thread Albert Esteve
From: Zack Rusin Virtualized drivers place additional restrictions on the cursor plane which breaks the contract of universal planes. To allow atomic modesettings with virtualized drivers the clients need to advertise that they're capable of dealing with those extra restrictions. To do that intr

[PATCH v6 5/9] drm/vboxvideo: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Cc: Hans de Goede Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Javier Martinez Canillas --

[PATCH v6 9/9] drm: Introduce documentation for hotspot properties

2023-10-23 Thread Albert Esteve
From: Michael Banack To clarify the intent and reasoning behind the hotspot properties introduce userspace documentation that goes over cursor handling in para-virtualized environments. The documentation is generic enough to not special case for any specific hypervisor and should apply equally t

[PATCH v6 7/9] drm: Remove legacy cursor hotspot code

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting supports mouse cursor offsets via the hotspot properties that are created on cursor planes. All drivers which support hotspots are atomic and the legacy code has been implemented in terms of the atomic properties as well. Due to the above the lagacy cursor hot

Re: [PATCH v6 1/9] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-10-23 Thread Simon Ser
Acked-by: Simon Ser

Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Simon Ser
On Monday, October 23rd, 2023 at 09:46, Albert Esteve wrote: > Link to the IGT test covering this patch (already merged): > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html Hmm. IGT should not be merged before the kernel, because as long as the kernel is not merged there mig

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-23 Thread Pekka Paalanen
On Fri, 20 Oct 2023 11:23:28 -0400 Harry Wentland wrote: > On 2023-10-20 10:57, Pekka Paalanen wrote: > > On Fri, 20 Oct 2023 16:22:56 +0200 > > Sebastian Wick wrote: > > > >> Thanks for continuing to work on this! > >> > >> On Thu, Oct 19, 2023 at 05:21:22PM -0400, Harry Wentland wrote: >

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Alexander Stein
Am Montag, 23. Oktober 2023, 09:34:42 CEST schrieb Dmitry Baryshkov: > On Mon, 23 Oct 2023 at 09:52, Alexander Stein > > wrote: > > Hi Dmitry, > > > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > > On Thu, 19 Oct 2023 at 14:42, Alexander Stein > > > > > > wrote: >

Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Albert Esteve
On Mon, Oct 23, 2023 at 9:55 AM Simon Ser wrote: > On Monday, October 23rd, 2023 at 09:46, Albert Esteve > wrote: > > > Link to the IGT test covering this patch (already merged): > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html > > Hmm. IGT should not be merged before the

Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Simon Ser
On Monday, October 23rd, 2023 at 10:14, Albert Esteve wrote: > On Mon, Oct 23, 2023 at 9:55 AM Simon Ser wrote: > > > On Monday, October 23rd, 2023 at 09:46, Albert Esteve > > wrote: > > > > > Link to the IGT test covering this patch (already merged): > > > https://lists.freedesktop.org/arc

Re: [PATCH v6 9/9] drm: Introduce documentation for hotspot properties

2023-10-23 Thread Pekka Paalanen
On Mon, 23 Oct 2023 09:46:13 +0200 Albert Esteve wrote: > From: Michael Banack > > To clarify the intent and reasoning behind the hotspot properties > introduce userspace documentation that goes over cursor handling > in para-virtualized environments. > > The documentation is generic enough to

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-23 Thread Simon Ser
On Tuesday, October 17th, 2023 at 14:10, Ville Syrjälä wrote: > On Mon, Oct 16, 2023 at 10:00:51PM +, Simon Ser wrote: > > > On Monday, October 16th, 2023 at 17:10, Ville Syrjälä > > ville.syrj...@linux.intel.com wrote: > > > > > On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wr

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Simon Ser
On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer wrote: > On 10/17/23 14:16, Simon Ser wrote: > > > After discussing with André it seems like we missed a plane type check > > here. We need to make sure FB_ID changes are only allowed on primary > > planes. > > Can you elaborate why that's

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

2023-10-23 Thread Jocelyn Falempe
On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectatio

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 11:14, Alexander Stein wrote: > > Am Montag, 23. Oktober 2023, 09:34:42 CEST schrieb Dmitry Baryshkov: > > On Mon, 23 Oct 2023 at 09:52, Alexander Stein > > > > wrote: > > > Hi Dmitry, > > > > > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > > >

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Michel Dänzer
On 10/23/23 10:27, Simon Ser wrote: > On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer > wrote: >> On 10/17/23 14:16, Simon Ser wrote: >> >>> After discussing with André it seems like we missed a plane type check >>> here. We need to make sure FB_ID changes are only allowed on primary >>> pl

Re: [PATCH] drm/stm: Avoid use-after-free issues with crtc and plane

2023-10-23 Thread Raphael Gallais-Pou
Hello Katya, Thanks for your submission. Please see drivers/gpu/drm/cr On 10/20/23 12:29, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes() and > drm_universal_plane_init(). These functions should not be called with > parameters allocated with devm_kzalloc() to avoi

Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes

2023-10-23 Thread Simon Ser
On Monday, October 23rd, 2023 at 10:42, Michel Dänzer wrote: > On 10/23/23 10:27, Simon Ser wrote: > > > On Sunday, October 22nd, 2023 at 12:12, Michel Dänzer > > michel.daen...@mailbox.org wrote: > > > > > On 10/17/23 14:16, Simon Ser wrote: > > > > > > > After discussing with André it seem

[PATCH] drm/vc4: fix typo

2023-10-23 Thread Dario Binacchi
Replace 'pack' with 'back'. Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") Signed-off-by: Dario Binacchi --- drivers/gpu/drm/vc4/vc4_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h ind

[PATCH] drm/panel: nt35510: fix typo

2023-10-23 Thread Dario Binacchi
Replace 'HFP' with 'HBP'. Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels") Signed-off-by: Dario Binacchi --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt3551

RE: [PATCH v5] backlight: mp3309c: Add support for MPS MP3309C

2023-10-23 Thread Flavio Suligoi
Hi Conor, ... > Subject: Re: [PATCH v5] backlight: mp3309c: Add support for MPS MP3309C > > On Fri, Oct 20, 2023 at 03:54:34PM +0200, Flavio Suligoi wrote: > > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, > > featuring a programmable switching frequency to optimize efficiency.

RE: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-10-23 Thread Flavio Suligoi
Hi Conor, ... > On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote: > > The two properties: > > > > - max-brightness > > - default brightness > > > > are not really required, so they can be removed from the "required" > > section. > > Why are they not required? You need to provide an

Re: [PATCH] drm/vc4: fix typo

2023-10-23 Thread Bagas Sanjaya
On Mon, Oct 23, 2023 at 10:59:20AM +0200, Dario Binacchi wrote: > Replace 'pack' with 'back'. > > Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") > Signed-off-by: Dario Binacchi > --- > > drivers/gpu/drm/vc4/vc4_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v3 1/3] pwm: make it possible to apply pwm changes in atomic context

2023-10-23 Thread Jani Nikula
On Tue, 17 Oct 2023, Sean Young wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c > b/drivers/gpu/drm/i915/display/intel_backlight.c > index 2e8f17c045222..cf516190cde8f 100644 > --- a/drivers/gpu/drm/i915/display/intel_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_bac

Re: [PATCH] drm/vc4: fix typo

2023-10-23 Thread Dave Stevenson
Hi Dario Thanks for the patch. On Mon, 23 Oct 2023 at 09:59, Dario Binacchi wrote: > > Replace 'pack' with 'back'. > > Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") > Signed-off-by: Dario Binacchi Reviewed-by: Dave Stevenson > --- > > drivers/gpu/drm/vc4/vc4_regs.h | 2

[PATCH 1/2] drm/v3d: wait for all jobs to finish before unregistering

2023-10-23 Thread Maíra Canal
Currently, we are only warning the user if the BIN or RENDER jobs don't finish before we unregister V3D. We must wait for all jobs to finish before unregistering. Therefore, warn the user if TFU or CSD jobs are not done by the time the driver is unregistered. Signed-off-by: Maíra Canal --- drive

[PATCH 2/2] drm/v3d: assure that the job is NULL after being freed

2023-10-23 Thread Maíra Canal
After the job is finished and freed, we need to make sure that the job is NULL. Otherwise, we would get a warning when unloading the driver, as it would look like the job still exists. Therefore, after freeing the job, let's assign it to NULL in order to indicate that the job has finished. Signed-

Re: Implement per-key keyboard backlight as auxdisplay?

2023-10-23 Thread Jani Nikula
On Mon, 16 Oct 2023, Miguel Ojeda wrote: > On Fri, Oct 13, 2023 at 9:56 PM Pavel Machek wrote: >> >> So... a bit of rationale. The keyboard does not really fit into the >> LED subsystem; LEDs are expected to be independent ("hdd led") and not >> a matrix of them. > > Makes sense. > >> We do see v

Re: [PATCH] drm: bridge: adv7511: get edid in hpd_work to update CEC phys address

2023-10-23 Thread Jani Nikula
On Sat, 14 Oct 2023, Alvin Šipraga wrote: > From: Alvin Šipraga > > The adv7511 driver is solely responsible for setting the physical > address of its CEC adapter. To do this, it must read the EDID. However, > EDID is only read when either the drm_bridge_funcs :: get_edid or > drm_connector_helpe

Re: Implement per-key keyboard backlight as auxdisplay?

2023-10-23 Thread Miguel Ojeda
On Mon, Oct 23, 2023 at 1:40 PM Jani Nikula wrote: > > One could also reasonably make the argument that controlling the > individual keyboard key backlights should be part of the input > subsystem. It's not a display per se. (Unless you actually have small > displays on the keycaps, and I think th

[PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-10-23 Thread Arnd Bergmann
From: Arnd Bergmann As with several other panel drivers, this fails to link without the DP helper library: ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare': panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack' Select the sam

[PATCH] drm/i915/gt: Use proper priority enum instead of 0

2023-10-23 Thread Nirmoy Das
I915_PRIORITY_NORMAL is 0 so use that instead for better readability. Cc: John Harrison Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c b/drivers/

Re: [PATCH v6 5/7] drm/sched: Split free_job into own work item

2023-10-23 Thread Boris Brezillon
Hi, On Tue, 17 Oct 2023 08:09:56 -0700 Matthew Brost wrote: > +static void drm_sched_run_job_work(struct work_struct *w) > +{ > + struct drm_gpu_scheduler *sched = > + container_of(w, struct drm_gpu_scheduler, work_run_job); > + struct drm_sched_entity *entity; > + struct

Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-10-23 Thread Dmitry Osipenko
On 10/3/23 04:00, Dongwon Kim wrote: > Having a fence linked to a virtio_gpu_framebuffer in the plane update sequence > would cause conflict when several planes referencing the same framebuffer > (e.g. Xorg screen covering multi-displays configured for an extended mode) > and those planes are updat

Re: [PATCH v6 5/7] drm/sched: Split free_job into own work item

2023-10-23 Thread Boris Brezillon
On Mon, 23 Oct 2023 14:16:06 +0200 Boris Brezillon wrote: > Hi, > > On Tue, 17 Oct 2023 08:09:56 -0700 > Matthew Brost wrote: > > > +static void drm_sched_run_job_work(struct work_struct *w) > > +{ > > + struct drm_gpu_scheduler *sched = > > + container_of(w, struct drm_gpu_schedul

Re: [PATCH] backlight: pwm_bl: Avoid backlight flicker applying initial PWM state

2023-10-23 Thread Daniel Thompson
On Fri, Oct 20, 2023 at 02:11:48PM +0200, Uwe Kleine-König wrote: > Hello Daniel, > > On Fri, Oct 20, 2023 at 12:27:27PM +0100, Daniel Thompson wrote: > > On Wed, Oct 18, 2023 at 11:07:41PM +0200, Uwe Kleine-König wrote: > > > Hello Philipp, > > > > > > On Thu, Jun 08, 2023 at 04:11:14PM +0200, Phi

Re: [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-23 Thread Jani Nikula
On Mon, 16 Oct 2023, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added memset() causes a warning for some reason I could not figure > out: > > In file included from arch/x86/include/asm/string.h:3, > from drivers/gpu/drm/i915/gt/intel_rc6.c:6: > In function 'rc6_res

Re: [PATCH] drm/panel: nt35510: fix typo

2023-10-23 Thread Neil Armstrong
On 23/10/2023 11:05, Dario Binacchi wrote: Replace 'HFP' with 'HBP'. Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels") Signed-off-by: Dario Binacchi --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-10-23 Thread Neil Armstrong
On 23/10/2023 13:55, Arnd Bergmann wrote: From: Arnd Bergmann As with several other panel drivers, this fails to link without the DP helper library: ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare': panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to

[PATCH] drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL

2023-10-23 Thread qu . huang
In certain types of chips, such as VEGA20, reading the amdgpu_regs_smc file could result in an abnormal null pointer access when the smc_rreg pointer is NULL. Below are the steps to reproduce this issue and the corresponding exception log: 1. Navigate to the directory: /sys/kernel/debug/dri/0 2

Re: [PATCH v3 1/3] pwm: make it possible to apply pwm changes in atomic context

2023-10-23 Thread Hans de Goede
Hi Sean, On 10/22/23 12:46, Sean Young wrote: > Hi Hans, > > On Sat, Oct 21, 2023 at 11:08:22AM +0200, Hans de Goede wrote: >> On 10/19/23 12:51, Uwe Kleine-König wrote: >>> On Wed, Oct 18, 2023 at 03:57:48PM +0200, Hans de Goede wrote: On 10/17/23 11:17, Sean Young wrote: > Some drivers

Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-10-23 Thread Neil Armstrong
Hi, On 23/10/2023 13:55, Arnd Bergmann wrote: From: Arnd Bergmann As with several other panel drivers, this fails to link without the DP helper library: ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare': panel-raydium-rm692e5.c:(.text+0x11f4): undefined referen

[PATCH][next] agp/amd64: remove redundant assignment to variable i

2023-10-23 Thread Colin Ian King
The variable i is being initialized to 0 and then again in the following for-loop. The initialization outside the for-loop is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/char/agp/amd64-agp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/agp/amd64-agp

Re: [PATCH v3 1/3] pwm: make it possible to apply pwm changes in atomic context

2023-10-23 Thread Daniel Thompson
On Sun, Oct 22, 2023 at 11:46:22AM +0100, Sean Young wrote: > Hi Hans, > > On Sat, Oct 21, 2023 at 11:08:22AM +0200, Hans de Goede wrote: > > On 10/19/23 12:51, Uwe Kleine-König wrote: > > > On Wed, Oct 18, 2023 at 03:57:48PM +0200, Hans de Goede wrote: > > >> On 10/17/23 11:17, Sean Young wrote: >

Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-10-23 Thread Konrad Dybcio
On 23.10.2023 15:25, Neil Armstrong wrote: > Hi, > > On 23/10/2023 13:55, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> As with several other panel drivers, this fails to link without the DP >> helper library: >> >> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function >> `rm692e5_p

Re: [PATCH v6 5/7] drm/sched: Split free_job into own work item

2023-10-23 Thread Matthew Brost
On Mon, Oct 23, 2023 at 02:39:37PM +0200, Boris Brezillon wrote: > On Mon, 23 Oct 2023 14:16:06 +0200 > Boris Brezillon wrote: > > > Hi, > > > > On Tue, 17 Oct 2023 08:09:56 -0700 > > Matthew Brost wrote: > > > > > +static void drm_sched_run_job_work(struct work_struct *w) > > > +{ > > > + str

Re: [PATCH v6 5/7] drm/sched: Split free_job into own work item

2023-10-23 Thread Boris Brezillon
On Mon, 23 Oct 2023 13:54:13 + Matthew Brost wrote: > On Mon, Oct 23, 2023 at 02:39:37PM +0200, Boris Brezillon wrote: > > On Mon, 23 Oct 2023 14:16:06 +0200 > > Boris Brezillon wrote: > > > > > Hi, > > > > > > On Tue, 17 Oct 2023 08:09:56 -0700 > > > Matthew Brost wrote: > > > > > >

[PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-10-23 Thread Konrad Dybcio
* to older things. -*/ - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1); return gpu->chip_id & 0xff; } --- base-commit: e8361b005d7c92997d12f2b85a9e4a525738bd9d change-id: 20231023-topic-adreno_warn-42a09bb4bf64 Best regards, -- Konrad Dybcio

[PATCH 00/18] Add display support for the MT8365-EVK board

2023-10-23 Thread Alexandre Mergnat
: d27bed55ce32b0732ef65561851fec3dc8d01852 change-id: 20231023-display-support-c6418b30e419 Best regards, -- Alexandre Mergnat

[PATCH 01/18] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Adaptive Ambient Light for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/d

[PATCH 10/18] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Data Path Read DMA for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devi

[PATCH 05/18] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Serial Interface for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devic

[PATCH 07/18] dt-bindings: display: mediatek: dpi: add binding for MT8365

2023-10-23 Thread amergnat
From: Fabien Parent DPI for MT8365 is compatible with MT8192 but requires an additional clock. Modify the documentation to requires this clock only on MT8365 SoCs. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- .../bindings/display/mediatek/mediatek,dpi.yaml | 19

[PATCH 11/18] dt-bindings: pwm: add power-domains property

2023-10-23 Thread Alexandre Mergnat
According to the Mediatek datasheet, the display PWM block has a power domain. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yam

[PATCH 04/18] dt-bindings: display: mediatek: dither: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Dither for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bin

[PATCH 14/18] drm/mediatek: dpi: add support for dpi clock

2023-10-23 Thread amergnat
From: Fabien Parent MT8365 requires an additional clock for DPI. Add support for that additional clock. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_dpi.c | 50 +- 1 file changed, 49 insertions(+), 1 deletio

[PATCH 16/18] arm64: defconfig: enable display connector support

2023-10-23 Thread Alexandre Mergnat
Enable this feature for the i350-evk HDMI connector support. Signed-off-by: Alexandre Mergnat --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5315789f4868..0a60e7616abe 100644 --- a/arch/arm64/

[PATCH 09/18] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Overlay for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8192 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 15/18] drm/mediatek: add MT8365 SoC support

2023-10-23 Thread amergnat
From: Fabien Parent Add DRM support for MT8365 SoC. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gp

[PATCH 03/18] dt-bindings: display: mediatek: color: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Color for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 06/18] dt-bindings: display: mediatek: dpi: add power-domains property

2023-10-23 Thread amergnat
From: Fabien Parent DPI is part of the display / multimedia block in MediaTek SoCs, and always have a power-domain (at least in the upstream device-trees). Add the power-domains property to the binding documentation. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- Documentat

[PATCH 17/18] arm64: dts: mediatek: add display blocks support for the MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
- Add aliases for each display components to help display drivers. - Add the Display Pulse Width Modulation (DISP_PWM) to provide PWM signals for the LED driver of mobile LCM. - Add the MIPI Display Serial Interface (DSI) PHY support. (up to 4-lane output) - Add the display mutex support. - Add

[PATCH 08/18] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display GAMMA for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pwm/mediatek,p

[PATCH 13/18] drm/mediatek: dsi: Improves the DSI lane setup robustness

2023-10-23 Thread Alexandre Mergnat
Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing b

[PATCH 02/18] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC

2023-10-23 Thread Alexandre Mergnat
Display Color Correction for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/de

[PATCH 18/18] arm64: dts: mediatek: add display support for mt8365-evk

2023-10-23 Thread Alexandre Mergnat
MIPI DSI: - Add "vsys_lcm_reg" regulator support and setup the "mt6357_vsim1_reg", to power the pannel plugged to the DSI connector. - Setup the Display Parallel Interface. - Add the startek kd070fhfid015 pannel support. HDMI: - Add HDMI connector support. - Add the "ite,it66121" HDMI bridge sup

Re: [RFC] Clean up check for already prepared panel

2023-10-23 Thread neil . armstrong
Hi, On 23/10/2023 16:51, Yuran Pereira wrote: Since the core function drm_panel_prepare already checks if the panel is prepared, we can remove this duplicate check from tm5p5_nt35596_prepare which acts as a no-op. As suggested in the GPU TODO [1] [1] https://docs.kernel.org/gpu/todo.html#clean

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-23 Thread Maxime Ripard
Hi Hans, On Thu, Oct 19, 2023 at 10:26:40AM +0200, Hans Verkuil wrote: > Hi Maxime, > > On 19/10/2023 10:02, Maxime Ripard wrote: > > Hi, > > > > On Wed, Oct 11, 2023 at 03:23:18PM +0200, Daniel Vetter wrote: > >> On Mon, 6 Mar 2023 at 11:49, Maxime Ripard wrote: > >>> > >>> From: Dave Stevenso

[RFC] Clean up check for already prepared panel

2023-10-23 Thread Yuran Pereira
Since the core function drm_panel_prepare already checks if the panel is prepared, we can remove this duplicate check from tm5p5_nt35596_prepare which acts as a no-op. As suggested in the GPU TODO [1] [1] https://docs.kernel.org/gpu/todo.html#clean-up-checks-for-already-prepared-enabled-in-panels

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-23 Thread Alex Deucher
On Fri, Oct 20, 2023 at 7:42 PM Aravind Iddamsetty wrote: > > Our hardware supports RAS(Reliability, Availability, Serviceability) by > reporting the errors to the host, which the KMD processes and exposes a > set of error counters which can be used by observability tools to take > corrective acti

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-23 Thread Sebastian Wick
Honestly, the less time people spend on this property the better. Lift the Intel one into core and be done with it. We'll hopefully be able to remove it in the not-to-distant future with the new color pipeline API and adding a new property which only sets the connector metadata instead of influenci

Re: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 09:28:03AM +, Flavio Suligoi wrote: > > On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote: > > > The two properties: > > > > > > - max-brightness > > > - default brightness > > > > > > are not really required, so they can be removed from the "required" > > >

[PATCH] drm: docs: Remove item from TODO list

2023-10-23 Thread Yuran Pereira
Since "Clean up checks for already prepared/enabled in panels" has already been done and merged [1], I think there is no longer a need for this item to be in the gpu TODO. [1] https://patchwork.freedesktop.org/patch/551421/ Signed-off-by: Yuran Pereira --- Documentation/gpu/todo.rst | 25 --

[RFC PATCH] drm/test: add a test suite for GEM objects backed by shmem

2023-10-23 Thread Marco Pagani
This patch introduces an initial KUnit test suite for GEM objects backed by shmem buffers. Signed-off-by: Marco Pagani --- drivers/gpu/drm/Kconfig| 1 + drivers/gpu/drm/tests/Makefile | 3 +- drivers/gpu/drm/tests/drm_gem_shmem_test.c | 303 +++

Re: [PATCH 01/18] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 04:40:01PM +0200, Alexandre Mergnat wrote: > Display Adaptive Ambient Light for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. s/binding/compatible/, here and in the subject. Cheers, Conor. > > Signed-off-by: Alexandre Mergnat

[Bug 201957] amdgpu: ring gfx timeout

2023-10-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added CC||mari

Re: [PATCH] drm: docs: Remove item from TODO list

2023-10-23 Thread Doug Anderson
Hi, On Mon, Oct 23, 2023 at 9:31 AM Yuran Pereira wrote: > > Since "Clean up checks for already prepared/enabled in panels" has > already been done and merged [1], I think there is no longer a need > for this item to be in the gpu TODO. > > [1] https://patchwork.freedesktop.org/patch/551421/ > >

RE: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-10-23 Thread Kim, Dongwon
> -Original Message- > From: Dmitry Osipenko > Sent: Monday, October 23, 2023 5:24 AM > To: Kim, Dongwon ; dri-devel@lists.freedesktop.org > Cc: kra...@redhat.com; Kasireddy, Vivek > Subject: Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update > > On 10/3/23 04:00, Dongwo

Re: [PATCH 02/18] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 04:40:02PM +0200, Alexandre Mergnat wrote: > Display Color Correction for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. This commit message's first line is too vague & the second doesn't make sense. I suspect something as succinct

Re: [PATCH 02/18] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 06:31:45PM +0100, Conor Dooley wrote: > On Mon, Oct 23, 2023 at 04:40:02PM +0200, Alexandre Mergnat wrote: > > Display Color Correction for MT8365 is compatible with another SoC. > > Then, add MT8365 binding along with MT8183 SoC. > > This commit message's first line is too

Re: [PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 04:40:12PM +0200, Alexandre Mergnat wrote: > Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding > along with MT8183 SoC. Additionally here, for the subject, "dt-bindings: pwm: mediatek,pwm-disp: add compatible for mt8365 SoC" Cheers Conor. > > Si

Re: [PATCH 11/18] dt-bindings: pwm: add power-domains property

2023-10-23 Thread Conor Dooley
Yo, On Mon, Oct 23, 2023 at 04:40:11PM +0200, Alexandre Mergnat wrote: > According to the Mediatek datasheet, the display PWM block has a power > domain. Datasheet for which soc? The mt8173? Is it valid for all devices in this binding? Cheers, Conor. > > Signed-off-by: Alexandre Mergnat > ---

[PATCH v5 2/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-10-23 Thread Jonas Karlman
Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328 and RK3399. Also add support for 10-bit 4:4:4 format while at it. V5: Use drm_format_info_min_pitch() for correct bpp Add missing NV21, NV61 and NV42 formats V4: Rework RK

[PATCH v5 0/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-10-23 Thread Jonas Karlman
This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. Also include 10-bit 4:4:4 support since VOP can support that also. First patch adds new fourcc 10-bit YUV formats with 4:2:2/4:4:4 sub-sampling

[PATCH v5 1/2] drm/fourcc: Add NV20 and NV30 YUV formats

2023-10-23 Thread Jonas Karlman
DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled variant of NV15, a 10-bit 2-plane YUV format that has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that each group is packed into an integer number of bytes: = UVUV =

Re: [PATCH v5 0/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-10-23 Thread Christopher Obbard
Hi Jonas, On Mon, 2023-10-23 at 17:37 +, Jonas Karlman wrote: > This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats > produced > by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. > Also include 10-bit 4:4:4 support since VOP can support that also. >

Re: [PATCH v5 1/2] drm/fourcc: Add NV20 and NV30 YUV formats

2023-10-23 Thread Christopher Obbard
Hi Jonas, On Mon, 2023-10-23 at 17:37 +, Jonas Karlman wrote: > DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled > variant of NV15, a 10-bit 2-plane YUV format that has no padding between > components. Instead, luminance and chrominance samples are grouped into 4s > so

Re: [PATCH v5 2/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-10-23 Thread Christopher Obbard
Hi Jonas, On Mon, 2023-10-23 at 17:37 +, Jonas Karlman wrote: > Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by > the Rockchip Video Decoder on RK322X, RK3288, RK3328 and RK3399. > Also add support for 10-bit 4:4:4 format while at it. > > V5: Use drm_format_info_min_pitc

  1   2   >