Re: linux-next: manual merge of the drm-msm tree with the mm, drm trees

2023-10-10 Thread Uwe Kleine-König
Hello Stephen, On Tue, Oct 10, 2023 at 12:33:45PM +1100, Stephen Rothwell wrote: > Today's linux-next merge of the drm-msm tree got conflicts in: > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > drivers/gpu

[PATCH v1 2/2] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Lakshmi Yadlapati
The MAX31785 has shown erratic behaviour across multiple system designs, unexpectedly clock stretching and NAKing transactions. Inserting a small delay (250us) after register writes makes the issue go away. Signed-off-by: Lakshmi Yadlapati --- drivers/hwmon/pmbus/max31785.c | 8 1 file

[PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Lakshmi Yadlapati
Reintroduce per-client throttling of transfers for improved compatibility. Some devices have experienced issues with small command turn-around times when using in-kernel device drivers. While a previous proposal was rejected due to concerns about error-prone open-coding of delays, recent upstrea

[PATCH] drm/amd/pm: Fix a memory leak on an error path

2023-10-10 Thread Kunwu.Chan
Add missing free on an error path. Fixes: 511a95552ec8 ("drm/amd/pm: Add SMU 13.0.6 support") Signed-off-by: Kunwu.Chan --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_p

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Lakshmi Yadlapati
Correct Link to Andrew's previous proposal: https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ On 10/9/23, 4:21 PM, "Lakshmi Yadlapati" mailto:laksh...@us.ibm.com>> wrote: Reintroduce per-client throttling of transfers for improved compatibility. Some devices have experien

[PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices

2023-10-10 Thread Lakshmi Yadlapati
Signed-off-by: Lakshmi Yadlapati --- drivers/i2c/i2c-core-base.c | 8 +- drivers/i2c/i2c-core-smbus.c | 143 --- drivers/i2c/i2c-core.h | 23 ++ include/linux/i2c.h | 2 + 4 files changed, 145 insertions(+), 31 deletions(-) diff --git a/dr

[PATCH] drm/amd/pm: Fix a memory leak on an error path

2023-10-10 Thread Kunwu.Chan
Add missing free on an error path. Signed-off-by: Kunwu.Chan --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.

Re: [PATCH drm-misc-next v2] drm/sched: implement dynamic job-flow control

2023-10-10 Thread Boris Brezillon
On Tue, 10 Oct 2023 00:35:53 +0200 Danilo Krummrich wrote: > Currently, job flow control is implemented simply by limiting the number > of jobs in flight. Therefore, a scheduler is initialized with a > submission limit that corresponds to the number of jobs which can be > sent to the hardware. >

Re: [PATCH 3/9] drm/ci: add helper script update-xfails.py

2023-10-10 Thread Vignesh Raman
Hi Helen, On 09/10/23 06:19, Helen Koike wrote: Add helper script that given a gitlab pipeline url, analyse which are the failures and flakes and update the xfails folder accordingly. Example: Trigger a pipeline in gitlab infrastructure, than re-try a few jobs more than once (so we can have dat

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 09/10/2023 18:07, Maxime Ripard wrote: On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: - I find it risky to completely reconfigure the hardware in a panic handler. I would expect to only change the format and base address of the framebuffer. I guess it can fail, but it does

Re: [PATCH RFC 4/5] drm/msm: dpu1: call wb & sspp clk_force_ctrl op if split clock control

2023-10-10 Thread Neil Armstrong
On 09/10/2023 19:07, Dmitry Baryshkov wrote: On 09/10/2023 19:36, Neil Armstrong wrote: Now clk_ctrl IDs can be optional and the clk_ctrl_reg can be specified on the SSPP & WB caps directly, pass the SSPP & WB hw struct to the qos & limit params then call the clk_force_ctrl() op accordingly. Si

Re: [PATCH RFC 5/5] drm/msm: dpu1: sm8550: move split clock controls to sspp entries

2023-10-10 Thread Neil Armstrong
On 09/10/2023 19:10, Dmitry Baryshkov wrote: On 09/10/2023 19:36, Neil Armstrong wrote: The SM8550 has the SSPP clk_ctrl in the SSPP registers, move them out of the MDP top. Signed-off-by: Neil Armstrong ---   .../gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 35 ++   1 f

Re: [PATCH RFC 5/5] drm/msm: dpu1: sm8550: move split clock controls to sspp entries

2023-10-10 Thread Neil Armstrong
On 09/10/2023 19:10, Dmitry Baryshkov wrote: On 09/10/2023 19:36, Neil Armstrong wrote: The SM8550 has the SSPP clk_ctrl in the SSPP registers, move them out of the MDP top. Signed-off-by: Neil Armstrong ---   .../gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 35 ++   1 f

Re: [PATCH 1/8] drm/solomon: Rename ssd130x driver to ssd13xx

2023-10-10 Thread Maxime Ripard
Hi, On Mon, Oct 09, 2023 at 08:34:15PM +0200, Javier Martinez Canillas wrote: > The driver only supports the SSD130x family of Solomon OLED controllers > now, but will be extended to also support the SSD132x (4-bit grayscale) > and SSD133x (16-bit RGB) controller families. Rename driver to ssd13xx

Re: [PATCH RFC 0/5] drm/msm: dpu1: correctly implement SSPP & WB Clock Control Split

2023-10-10 Thread Marijn Suijten
On 2023-10-09 18:36:11, Neil Armstrong wrote: > Starting with the SM8550 platform, the SSPP & WB Clock Controls are > no more in the MDP TOP registers, but in the SSPP & WB register space. > > Add the corresponding SSPP & WB ops and use them from the vbif QoS > and OT limit setup functions. > > S

Re: [PATCH RFC 0/5] drm/msm: dpu1: correctly implement SSPP & WB Clock Control Split

2023-10-10 Thread Neil Armstrong
On 10/10/2023 10:10, Marijn Suijten wrote: On 2023-10-09 18:36:11, Neil Armstrong wrote: Starting with the SM8550 platform, the SSPP & WB Clock Controls are no more in the MDP TOP registers, but in the SSPP & WB register space. Add the corresponding SSPP & WB ops and use them from the vbif QoS

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 09:55:46AM +0200, Jocelyn Falempe wrote: > On 09/10/2023 18:07, Maxime Ripard wrote: > > On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: > > > > > - I find it risky to completely reconfigure the hardware in a panic > > > > > handler. > > > > > > > > I woul

Re: [PATCH] drm/panel: fix a possible null pointer dereference

2023-10-10 Thread Neil Armstrong
Hi, On Sat, 07 Oct 2023 11:31:05 +0800, Ma Ke wrote: > In versatile_panel_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a NULL pointer dereference > on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Thanks, Applied to https://ano

Re: [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference

2023-10-10 Thread Neil Armstrong
Hi, On Mon, 09 Oct 2023 17:04:46 +0800, Ma Ke wrote: > In tpg110_get_modes(), the return value of drm_mode_duplicate() is > assigned to mode, which will lead to a NULL pointer dereference on > failure of drm_mode_duplicate(). Add a check to avoid npd. > > Thanks, Applied to https://anongit.free

Re: [PATCH 1/8] drm/solomon: Rename ssd130x driver to ssd13xx

2023-10-10 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, Thanks for the feedback. > Hi, > > On Mon, Oct 09, 2023 at 08:34:15PM +0200, Javier Martinez Canillas wrote: >> The driver only supports the SSD130x family of Solomon OLED controllers >> now, but will be extended to also support the SSD132x (4-bit grayscale)

Re: [PATCH v2] drm/panel: boe-tv101wum-nl6: Completely pull GPW to VGL before TP term

2023-10-10 Thread Neil Armstrong
Hi, On Sat, 07 Oct 2023 14:49:49 +0800, Ruihai Zhou wrote: > The sta_himax83102 panel sometimes shows abnormally flickering > horizontal lines. The front gate output will precharge the X point of > the next pole circuit before TP(TouchPanel Enable) term starts, and wait > until the end of the TP t

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 09.10.23 um 13:33 schrieb Maxime Ripard: [...] And you don't need to support all kinds of tiling, YUV or RGB variants. We should indeed not use YUV at all. For RGB, we already have plenty of conversion code from XRGB-to-, so we are more flexible there. So if I understand correct

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 09.10.23 um 18:07 schrieb Maxime Ripard: On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: - I find it risky to completely reconfigure the hardware in a panic handler. I would expect to only change the format and base address of the framebuffer. I guess it can fail, but i

Re: [PATCH v4 4/4] drm/mgag200: Add drm_panic support

2023-10-10 Thread Thomas Zimmermann
Hi Am 03.10.23 um 16:22 schrieb Jocelyn Falempe: Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 24 1 file changed, 24 insertions(+)

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > > > So if I understand correctly, drm_panic would pre-allocate a plane/commit, > > > and use that when a panic occurs ? > > > > And have it checked already, yes. We would only wait for a panic to > > happen to pull the trigger

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Wolfram Sang
Hi, thanks for this series! > Reference to Andrew's previous proposal: > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ I do totally agree with Guenter's comment[1], though. This just affects a few drivers and this patch is way too intrusive for the I2C core. The later sug

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 11:04:33AM +0200, Thomas Zimmermann wrote: > Am 09.10.23 um 18:07 schrieb Maxime Ripard: > > On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote: > > > > > - I find it risky to completely reconfigure the hardware in a panic > > > > > handler. > > > > > > > > I

Re: [PATCH v3 9/9] efi: move screen_info into efi init code

2023-10-10 Thread Catalin Marinas
On Mon, Oct 09, 2023 at 11:18:45PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > After the vga console no longer relies on global screen_info, there are > only two remaining use cases: > > - on the x86 architecture, it is used for multiple boot methods >(bzImage, EFI, Xen, kexec) to

Re: [PATCH v5 2/7] drm/atomic-helper: Add format-conversion state to shadow-plane state

2023-10-10 Thread Maxime Ripard
On Mon, Oct 09, 2023 at 04:22:29PM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > Store an instance of struct drm_format_conv_state in the shadow-plane > > state struct drm_shadow_plane_state. Many drivers with shadow planes > > use DRM's format helpers to copy or convert t

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake

2023-10-10 Thread Tvrtko Ursulin
On 08/10/2023 17:48, Andi Shyti wrote: From: Radhakrishna Sripada Meteor Lake has demonstrated consistent stability for some time. All user-space API modifications tide to its core platform functions are operational. The necessary firmware components are set up and comprehensive testing has

Re: [PATCH v4 0/7] drm: Reuse temporary memory for format conversion

2023-10-10 Thread Maxime Ripard
On Mon, Oct 09, 2023 at 10:23:02AM +0200, Thomas Zimmermann wrote: > Hi Maxime > > Am 06.10.23 um 16:49 schrieb Maxime Ripard: > > Hi, > > > > On Thu, Oct 05, 2023 at 11:04:20AM +0200, Thomas Zimmermann wrote: > > > DRM's format-conversion helpers require temporary memory. Pass the > > > buffer f

[git pull] habanalabs for drm-next-6.7

2023-10-10 Thread Oded Gabbay
Hi Dave, Daniel. Habanalabs pull request for 6.7. It's a bit all over the place, a few uapi changes, mostly improvements and bug fixes. Notable things are the move to the accel subsystem in the code itself, meaning we removed the habanalabs class and the code to created device char and instead w

Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset

2023-10-10 Thread Dmitry Osipenko
Hi, On 10/10/23 06:25, Huang Rui wrote: > These definitions are used fro qemu, and qemu imports this marco in the > headers to enable gfxstream or venus for virtio gpu. So it should add it > even kernel doesn't use this. > > Signed-off-by: Huang Rui > --- > > Changes V1 -> V2: > - Add all capse

Re: [PATCH v3 1/9] vgacon: rework Kconfig dependencies

2023-10-10 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Oct 9, 2023 at 11:19 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to suppo

Re: [PATCH v5 2/7] drm/atomic-helper: Add format-conversion state to shadow-plane state

2023-10-10 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Mon, Oct 09, 2023 at 04:22:29PM +0200, Javier Martinez Canillas wrote: >> Thomas Zimmermann writes: >> > Store an instance of struct drm_format_conv_state in the shadow-plane >> > state struct drm_shadow_plane_state. Many drivers with shadow planes >> > use DRM's forma

Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset

2023-10-10 Thread Huang Rui
On Tue, Oct 10, 2023 at 06:20:03PM +0800, Dmitry Osipenko wrote: > Hi, > > On 10/10/23 06:25, Huang Rui wrote: > > These definitions are used fro qemu, and qemu imports this marco in the > > headers to enable gfxstream or venus for virtio gpu. So it should add it > > even kernel doesn't use this.

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake

2023-10-10 Thread Andi Shyti
Hi Tvrtko, > > Meteor Lake has demonstrated consistent stability for some time. > > All user-space API modifications tide to its core platform > > functions are operational. > > > > The necessary firmware components are set up and comprehensive > > testing has been condused over a period. > > >

Re: [v1 1/2] drm/panel: ili9882t: Break out as separate driver

2023-10-10 Thread cong yang
Thanks for the review,I will modify these in V2. On Tue, Oct 10, 2023 at 4:44 AM Doug Anderson wrote: > > Hi, > > On Fri, Oct 6, 2023 at 11:07 PM Cong Yang > wrote: > > > > From: Linus Walleij > > > > The Starry ILI9882t-based panel should never have been part of the boe > > tv101wum driver, it

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Noralf Trønnes
On 10/10/23 11:25, Maxime Ripard wrote: > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: So if I understand correctly, drm_panic would pre-allocate a plane/commit, and use that when a panic occurs ? >>> >>> And have it checked already, yes. We would only wait

Re: [v1 2/2] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-10 Thread cong yang
Hi, On Tue, Oct 10, 2023 at 4:44 AM Doug Anderson wrote: > > Hi, > > On Fri, Oct 6, 2023 at 11:07 PM Cong Yang > wrote: > > > > At present, we have found that there may be a problem of blurred > > screen during fast sleep/resume. The direct cause of the blurred > > screen is that the IC does not

Re: [PATCH] drm/atomic: Perform blocking commits on workqueue

2023-10-10 Thread Daniel Vetter
On Thu, Oct 05, 2023 at 01:16:27PM +0300, Ville Syrjälä wrote: > On Thu, Oct 05, 2023 at 11:57:41AM +0200, Daniel Vetter wrote: > > On Tue, Sep 26, 2023 at 01:05:49PM -0400, Ray Strode wrote: > > > From: Ray Strode > > > > > > A drm atomic commit can be quite slow on some hardware. It can lead >

Re: [PATCH] drm/atomic: Perform blocking commits on workqueue

2023-10-10 Thread Daniel Vetter
On Mon, Oct 09, 2023 at 02:36:17PM +0200, Christian König wrote: > Am 09.10.23 um 14:19 schrieb Ville Syrjälä: > > On Mon, Oct 09, 2023 at 08:42:24AM +0200, Christian König wrote: > > > Am 06.10.23 um 20:48 schrieb Ray Strode: > > > > Hi, > > > > > > > > On Fri, Oct 6, 2023 at 3:12 AM Christian Kö

Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

2023-10-10 Thread Daniel Vetter
On Fri, Oct 06, 2023 at 04:34:01PM +0200, Ondrej Zary wrote: > On Friday 06 October 2023, Helge Deller wrote: > > On 10/5/23 09:01, Zhang Shurong wrote: > > > Add missing pci_disable_device() in error path in ark_pci_probe(). > > > > Do you have this hardware and tested your patch? > > I'm sure th

Re: [PATCH v3 0/9] video: screen_info cleanups

2023-10-10 Thread Daniel Vetter
On Mon, Oct 09, 2023 at 11:18:36PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > v3 changelog > > No real changes, just rebased for context changes, and picked up the Acks. > > This now conflicts with the ia64 removal and introduces one new dependency > on IA64, but that is harmless and

[v2 0/3] Break out as separate driver from boe-tv101wum-nl6 panel driver

2023-10-10 Thread Cong Yang
Linus series proposed to break out ili9882t as separate driver, but he didn't have time for that extensive rework of the driver. As discussed by Linus and Doug [1], keep macro using the "struct panel_init_cmd" until we get some resolution about the binary size issue. [1]: https://lore.kernel.org

[v2 1/3] drm/panel: ili9882t: Break out as separate driver

2023-10-10 Thread Cong Yang
The Starry ILI9882t-based panel should never have been part of the boe tv101wum driver, it is clearly based on the Ilitek ILI9882t display controller and if you look at the custom command sequences for the panel these clearly contain the signature Ilitek page switch (0xff) commands. The hardware ha

[v2 2/3] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-10 Thread Cong Yang
At present, we have found that there may be a problem of blurred screen during fast sleep/resume. The direct cause of the blurred screen is that the IC does not receive 0x28/0x10. Because of the particularity of the IC, before the panel enters sleep hid must stop scanning, i2c_hid_core_suspend befo

[v2 3/3] arm64: defconfig: Enable ILITEK_ILI9882T panel

2023-10-10 Thread Cong Yang
Enable ILITEK_ILI9882T panel. Signed-off-by: Cong Yang --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 0777bcae9104..c3453dcbad3e 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/conf

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Maxime Ripard
On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: > > > On 10/10/23 11:25, Maxime Ripard wrote: > > > > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > So if I understand correctly, drm_panic would pre-allocate a > plane/commit, > and use t

[PATCH RESEND v2 0/2] Add drm_dbg_ratelimited()

2023-10-10 Thread Andi Shyti
Hi, I might have picked up the wrong series and missed some reviews and the extra patch from Nirmoy with a real use of the drm_dbg_ratelimited() that John was looking for. Thanks, Andi v2: pick the right patch with the following changes: - add more r-b's - add a patch 2 where the drm_dbg_ratel

[PATCH v4 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-10 Thread Flavio Suligoi
The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a programmable switching frequency to optimize efficiency. The brightness can be controlled either by I2C commands (called "analog" mode) or by a PWM input signal (PWM mode). This driver supports both modes. For device drive

[PATCH RESEND v2 1/2] drm/print: Add drm_dbg_ratelimited

2023-10-10 Thread Andi Shyti
From: Nirmoy Das Add a function for ratelimitted debug print. Signed-off-by: Nirmoy Das Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andrzej Hajda Reviewed-by: Andi Shyti Reviewed-by: Sam Ravnborg

[PATCH v4 2/2] backlight: mp3309c: Add support for MPS MP3309C

2023-10-10 Thread Flavio Suligoi
The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a programmable switching frequency to optimize efficiency. The brightness can be controlled either by I2C commands (called "analog" mode) or by a PWM input signal (PWM mode). This driver supports both modes. For DT configura

[PATCH RESEND v2 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-10-10 Thread Andi Shyti
From: Nirmoy Das Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause dmesg spamming. Use ratelimit api to reduce log rate. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 Signed-off-by: Nirmoy Das Cc: Matthew Auld Reviewed-by: Matthew Auld Reviewed-by: Andrzej

Re: [PATCH v3 0/9] video: screen_info cleanups

2023-10-10 Thread Greg Kroah-Hartman
On Tue, Oct 10, 2023 at 01:48:07PM +0200, Daniel Vetter wrote: > On Mon, Oct 09, 2023 at 11:18:36PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > v3 changelog > > > > No real changes, just rebased for context changes, and picked up the Acks. > > > > This now conflicts with the ia6

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Daniel Vetter
On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote: > On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: > > > > > > On 10/10/23 11:25, Maxime Ripard wrote: > > > > > > > > > On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: > > So if I understand c

[PATCH v3 00/16] Introduce PMF Smart PC Solution Builder Feature

2023-10-10 Thread Shyam Sundar S K
Smart PC Solutions Builder allows for OEM to define a large number of custom system states to dynamically switch to. The system states are referred to as policies, and multiple policies can be loaded onto the system at any given time, however only one policy can be active at a given time. Policy i

Re: [PATCH] drm/atomic-helper: relax unregistered connector check

2023-10-10 Thread Simon Ser
Thank you both for the reviews! Some wlroots users have confirmed it fixes their issues. I've pushed the patch.

[PATCH v3 01/16] platform/x86/amd/pmf: Add PMF TEE interface

2023-10-10 Thread Shyam Sundar S K
AMD PMF driver loads the PMF TA (Trusted Application) into the AMD ASP's (AMD Security Processor) TEE (Trusted Execution Environment). PMF Trusted Application is a secured firmware placed under /lib/firmware/amdtee gets loaded only when the TEE environment is initialized. Add the initial code path

[PATCH v3 02/16] platform/x86/amd/pmf: Add support PMF-TA interaction

2023-10-10 Thread Shyam Sundar S K
PMF TA (Trusted Application) loads via the TEE environment into the AMD ASP. PMF-TA supports two commands: 1) Init: Initialize the TA with the PMF Smart PC policy binary and start the policy engine. A policy is a combination of inputs and outputs, where; - the inputs are the changing dynamics of

[PATCH v3 03/16] platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()

2023-10-10 Thread Shyam Sundar S K
In the current code, the metrics table information was required only for auto-mode or CnQF at a given time. Hence keeping the return type of amd_pmf_set_dram_addr() as static made sense. But with the addition of Smart PC builder feature, the metrics table information has to be shared by the Smart

[PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Shyam Sundar S K
PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary size and the address which has to be passed to

[PATCH v3 05/16] platform/x86/amd/pmf: change amd_pmf_init_features() call sequence

2023-10-10 Thread Shyam Sundar S K
To sideload pmf policy binaries, the Smart PC Solution Builder provides a debugfs file called "update_policy"; that gets created under a new debugfs directory called "pb" and this new directory has to be associated with existing parent directory for PMF driver called "amd_pmf". In the current code

[PATCH v3 06/16] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-10 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/M

[PATCH v3 07/16] platform/x86/amd/pmf: Add support update p3t limit

2023-10-10 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers/platf

[PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Shyam Sundar S K
PMF driver based on the output actions from the TA can request to update the system states like entering s0i3, lock screen etc. by generating an uevent. Based on the udev rules set in the userspace the event id matching the uevent shall get updated accordingly using the systemctl. Sample udev rule

[PATCH v3 10/16] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-10-10 Thread Shyam Sundar S K
A policy binary is OS agnostic, and the same policies are expected to work across the OSes. At times it becomes difficult to debug when the policies inside the policy binaries starts to misbehave. Add a way to sideload such policies independently to debug them via a debugfs entry. Reviewed-by: Ma

[PATCH v3 09/16] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-10-10 Thread Shyam Sundar S K
PMF driver sends constant inputs to TA which its gets via the other subsystems in the kernel. To debug certain TA issues knowing what inputs being sent to TA becomes critical. Add debug facility to the driver which can isolate Smart PC and TA related issues. Also, make source_as_str() as non-stati

[PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Shyam Sundar S K
Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even before sending that to TA. Signed-off-by: Shyam S

[PATCH v3 12/16] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-10 Thread Shyam Sundar S K
In order to provide GPU inputs to TA for the Smart PC solution to work, we need to have interface between the PMF driver and the AMDGPU driver. Add the initial code path for get interface from AMDGPU. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sunda

[PATCH v3 13/16] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-10-10 Thread Shyam Sundar S K
For the Smart PC Solution to fully work, it has to enact to the actions coming from TA. Add the initial code path for set interface to AMDGPU. Change amd_pmf_apply_policies() return type, so that it can return errors when the call to retrieve information from amdgpu fails. Co-developed-by: Mario

[PATCH v3 15/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K S

[PATCH v3 14/16] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar Current amd_sfh driver has float_to_int() to convert units from float to int. This is fine until this function gets called outside of the current scope of file. Add a prefix "amd_sfh" to float_to_int() so that function represents the driver name. This function will be cal

[PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. make amd_sfh_float_to_int() as non-static function so that this can be called outside of the

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver takes over. Generically speaking, there's str

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Ilpo Järvinen
On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > Sometimes policy binary retrieved from the BIOS maybe incorrect that can > end up in failing to enable the Smart PC solution feature. > > Use print_hex_dump_debug() to dump the policy binary in hex, so that we > debug the issues related to the binary

Re: [PATCH 1/2] accel/qaic: Add support for periodic timesync

2023-10-10 Thread kernel test robot
Hi Jeffrey, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on next-20231010] [cannot apply to linus/master v6.6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Thierry Reding
On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: > Return -ENOMEM if tegra_bo_mmap() fails. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/tegra/gem.c | 2 ++ > 1 file changed, 2 insertions(+) Sorry, this fell through the cracks. I think it'd be better if tegra_bo_mmap() w

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 14:59 schrieb Daniel Vetter: [...] Why can't we use the model[1] suggested by Daniel using a draw_pixel callback giving drivers full control on how they can put a pixel on the display? I share kind of the same general ideas/conclusions: "qthe idea is that all the fb select

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 14:59, Daniel Vetter wrote: On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: On 10/10/23 11:25, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: So if I under

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 15:05, Thomas Zimmermann wrote: Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver

[PATCH v7 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-10-10 Thread Sarah Walker
From: Donald Robson Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v6: - Remove use of __always_inline Signed-off-by: Donald Robson Signed-off-by: Sarah Walker --- incl

[PATCH v7 01/20] sizes.h: Add entries between SZ_32G and SZ_64T

2023-10-10 Thread Sarah Walker
From: Matt Coster sizes.h has a gap in defines between SZ_32G and SZ_64T. Add the missing defines so they can be used in drivers. Signed-off-by: Matt Coster Signed-off-by: Sarah Walker Reviewed-by: Linus Walleij --- include/linux/sizes.h | 9 + 1 file changed, 9 insertions(+) diff -

[PATCH v7 00/20] Imagination Technologies PowerVR DRM driver

2023-10-10 Thread Sarah Walker
This patch series adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver (pvrsrvkm)

[PATCH v7 19/20] drm/imagination: Add firmware trace to debugfs

2023-10-10 Thread Sarah Walker
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by: Matt Coster Signed-off-by: Matt Coster Signed-off-by: Sarah Walker --- drivers/gpu/drm/im

[PATCH v7 16/20] drm/imagination: Implement context creation/destruction ioctls

2023-10-10 Thread Sarah Walker
Implement ioctls for the creation and destruction of contexts. Contexts are used for job submission and each is associated with a particular job type. Changes since v5: - Fix context release in final error path in pvr_context_create() Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by:

[PATCH v7 20/20] drm/imagination: Add driver documentation

2023-10-10 Thread Sarah Walker
Add documentation for the UAPI. Changes since v5: - Remove obsolete VM documentation Co-developed-by: Matt Coster Signed-off-by: Matt Coster Co-developed-by: Donald Robson Signed-off-by: Donald Robson Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard --- Documentation/gpu/drivers.rst

[PATCH v7 18/20] drm/imagination: Add firmware trace header

2023-10-10 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker --- .../gpu/drm/imagination/pvr_rogue_fwif_sf.h | 1648 + 1 file changed, 1648 insertions(+) create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_fwif_sf.h diff --git a/drivers/gpu/drm/imag

[PATCH v7 12/20] drm/imagination: Implement power management

2023-10-10 Thread Sarah Walker
Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Changes since v5: - Use RUNTIME_PM_OPS() to declare PM callbacks - Add Kconfig dependency on CONFIG_PM Changes since v4: - Suspend runtime PM before u

[PATCH v7 13/20] drm/imagination: Implement firmware infrastructure and META FW support

2023-10-10 Thread Sarah Walker
The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. Changes since v6: - Add

[PATCH v7 06/20] drm/imagination: Get GPU resources

2023-10-10 Thread Sarah Walker
Acquire clock and register resources, and enable/map as appropriate. Changes since v3: - Remove regulator resource (not used on supported platform) - Use devm helpers - Use devm_clk_get_optional() for optional clocks - Don't prepare clocks on resource acquisition - Drop pvr_device_clk_core_get_fre

[PATCH v7 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-10-10 Thread Sarah Walker
Add the device tree binding documentation for the IMG AXE GPU used in TI AM62 SoCs. Co-developed-by: Frank Binns Signed-off-by: Frank Binns Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard Reviewed-by: Linus Walleij Reviewed-by: Conor Dooley --- Changes since v6: - Remove unused gpu la

[PATCH v7 05/20] drm/imagination: Add skeleton PowerVR driver

2023-10-10 Thread Sarah Walker
This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Changes since v5: - Update compatible string & description to match marketing name - Checkpatch fixes in to/from_pvr_device/file macros Changes since v3: -

[PATCH v7 14/20] drm/imagination: Implement MIPS firmware processor and MMU support

2023-10-10 Thread Sarah Walker
Add support for the MIPS firmware processor, used in the Series AXE GPU. The MIPS firmware processor uses a separate MMU to the rest of the GPU, so this patch adds support for that as well. Changes since v6: - Fix integer overflow in VM map error path Changes since v5: - Use alloc_page() when all

[PATCH v7 08/20] drm/imagination: Add firmware and MMU related headers

2023-10-10 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker Acked-by: Maxime Ripard --- .../drm/imagination/pvr_rogue_heap_config.h | 113 ++ drivers/gpu/drm/imagination/pvr_rogue_meta.h | 356 ++ drivers/gpu/drm/imagination/pvr_rogue_mips.h | 335

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug() to dump the policy binary in he

[PATCH v7 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-10-10 Thread Sarah Walker
Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Changes since v6: - Fix out-of-bounds shift in get_cr_multisamplectl_val() Chan

[PATCH v7 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-10-10 Thread Sarah Walker
Add the UAPI implementation for the PowerVR driver. Changes from v6 - Add padding to struct drm_pvr_dev_query_gpu_info - Improve BYPASS_CACHE flag documentation - Add SUBMIT_JOB_FRAG_CMD_DISABLE_PIXELMERGE flag Changes from v4: - Remove CREATE_ZEROED flag for BO creation (all buffers are now zero

[PATCH v7 17/20] drm/imagination: Implement job submission and scheduling

2023-10-10 Thread Sarah Walker
Implement job submission ioctl. Job scheduling is implemented using drm_sched. Jobs are submitted in a stream format. This is intended to allow the UAPI data format to be independent of the actual FWIF structures in use, which vary depending on the GPU in use. The stream formats are documented at

[PATCH v7 10/20] drm/imagination: Add GPU ID parsing and firmware loading

2023-10-10 Thread Sarah Walker
Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking at moving this infor

  1   2   >