Re: [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-02 Thread neil . armstrong
On 19/09/2023 20:22, Helen Koike wrote: DRM CI keeps track of which tests are failing, flaking or being skipped by the ci in the expectations files. Add entries for those files to the corresponding driver maintainer, so they can be notified when they change. Signed-off-by: Helen Koike --- For

Re: [PATCH] drm/bridge: dpc3433: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
On 01/10/2023 01:42, Mark Brown wrote: The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- dri

Re: [PATCH] drm/bridge: tc358767: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
On 01/10/2023 01:43, Mark Brown wrote: The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- dri

Re: [PATCH] drm/i915/uapi: fix doc typos

2023-10-02 Thread Randy Dunlap
Hi-- On 10/1/23 23:47, Ville Syrjälä wrote: > On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: >> Correct typo of "its". >> Add a comma for clarity. >> >> Signed-off-by: Randy Dunlap >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: Tvrtko Ursulin >> Cc: intel-

Re: [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
On 01/10/2023 01:46, Mark Brown wrote: The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- dri

Re: [PATCH] drm/bridge: lt9211: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
On 01/10/2023 12:24, Mark Brown wrote: The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- dri

Re: [PATCH] drm/bridge: sn65dsi83: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
On 01/10/2023 12:26, Mark Brown wrote: The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- dri

[PATCH] dma-buf: heaps: Fix off by one in cma_heap_vm_fault()

2023-10-02 Thread Dan Carpenter
The buffer->pages[] has "buffer->pagecount" elements so this > comparison has to be changed to >= to avoid reading beyond the end of the array. The buffer->pages[] array is allocated in cma_heap_allocate(). Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the cma_heap implementat

Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Fri, 29 Sep 2023 14:54:19 +0200, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH] drm/bridge: dpc3433: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 01:42:24 +0200, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH] drm/bridge: tc358767: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 01:43:13 +0200, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH] drm/bridge: lt9211: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 11:24:49 +0100, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 00:46:38 +0100, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH] drm/bridge: sn65dsi83: Convert to use maple tree register cache

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 11:26:22 +0100, Mark Brown wrote: > The maple tree register cache is based on a much more modern data structure > than the rbtree cache and makes optimisation choices which are probably > more appropriate for modern systems than those made by the rbtree cache. > > Thanks

Re: [PATCH 0/2] drm/panel: ili9322: Minor regmap improvements

2023-10-02 Thread Neil Armstrong
Hi, On Sun, 01 Oct 2023 11:24:12 +0100, Mark Brown wrote: > These two patches provide some minor improvements to the ili9322 regmap > API usage. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] drm/panel: ili9322: Remove redundant volatle_reg()

Re: [PATCH v2 0/2] Raydium RM692E5-based BOE panel driver

2023-10-02 Thread Neil Armstrong
Hi, On Fri, 29 Sep 2023 14:54:19 +0200, Konrad Dybcio wrote: > The Fairphone 5 smartphone ships with a BOE AMOLED panel in conjunction > with a Raydium RM692E5 driver IC. This series adds the bindings and driver > for that. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc

RE: [PATCH v2 0/8] ADV7511 driver enhancements

2023-10-02 Thread Biju Das
Hi All, Gentle ping. Are we happy with this patch serries? Cheers, Biju > -Original Message- > From: Biju Das > Sent: Wednesday, August 30, 2023 3:24 PM > Subject: [PATCH v2 0/8] ADV7511 driver enhancements > > This patch series aims to improve ADV7511 driver by adding feature bits and

Re: [PATCH v10 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-02 Thread 林睿祥

Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados
On Sat, Sep 30, 2023 at 05:52:17PM +0100, Phillip Potter wrote: > On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay > > > wrote: > > > > F

[PATCH v2] drm: panel-orientation-quirks: Add quirk for One Mix 2S

2023-10-02 Thread Kai Uwe Broulik
The One Mix 2S is a mini laptop with a 1200x1920 portrait screen mounted in a landscape oriented clamshell case. Because of the too generic DMI strings this entry is also doing bios-date matching. Signed-off-by: Kai Uwe Broulik --- Changes since v1: * Got two more BIOS dates reported drivers/gp

[PATCH v3] drm: rcar-du: turn rcar_du_group_get() into void and remove its return value check

2023-10-02 Thread Alexandra Diupina
rcar_du_group_get() never returns a negative error code (always returns 0), so change the comment about returned value, turn function into void (return code of rcar_du_group_get has been redundant for a long time, so perhaps it's just not required) and remove redundant error path handling in rcar_d

Re: [PATCH v2] drm: rcar-du: turn rcar_du_group_get() into void and remove its return value check

2023-10-02 Thread Александра Дюпина
Hi Laurent, I'm sorry, my mistake. Thank you for your comment, I will be more careful in the future 30.09.2023 17:50, Laurent Pinchart пишет: Using tools to find issues is fine in principle, but not even compile-testing the resulting patch before submitting it is not. Alexandra

Re: [PATCH v2] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2023-10-02 Thread Thomas Hellström
Hi, Zack On 9/26/23 19:51, Zack Rusin wrote: From: Zack Rusin Some drivers require the mapped tt pages to be decrypted. In an ideal world this would have been handled by the dma layer, but the TTM page fault handling would have to be rewritten to able to do that. A side-effect of the TTM page

Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Joel Granados
On Thu, Sep 28, 2023 at 04:31:30PM +, Christophe Leroy wrote: > > > Le 28/09/2023 à 15:21, Joel Granados via B4 Relay a écrit : > > From: Joel Granados > > Automatic test fails on powerpc, see > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230928-jag-sysctl_remove_empty_elem_d

Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: >> From: Joel Granados >> >> This commit comes at the tail end of a greater effort to remove the >> empty elements at the end of the ctl_table arrays (sentinels) which >> will reduce the overall

[PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados What? These commits remove the sentinel element (last empty element) from the sysctl arrays of all the files under the "drivers/" directory that use a sysctl array for registration. The merging of the preparation patches (in https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bomba

[PATCH v2 02/15] hpet: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 03/15] xen: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 09/15] char-misc: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 07/15] macintosh: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 06/15] parport: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 08/15] infiniband: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 13/15] raid: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 12/15] fw loader: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 05/15] scsi: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 14/15] Drivers: hv: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

[PATCH v2 15/15] intel drm: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https:/

Re: [PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 02. 10. 23, 10:55, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Greg Kroah-Hartman
On Mon, Oct 02, 2023 at 08:47:53AM +, Christophe Leroy wrote: > > > Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: > >> From: Joel Granados > >> > >> This commit comes at the tail end of a greater effort to remove the > >> empty elemen

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:47, Joel Granados a écrit : > On Thu, Sep 28, 2023 at 04:31:30PM +, Christophe Leroy wrote: > I followed this trace and proc_handler is correctly defined in tty_table > (struct ctl_table) in drivers/tty/tty_io.c:tty_init and there is not > path that changes these values. >

Re: [PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-02 Thread Ilpo Järvinen
On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > On 9/26/2023 10:38 PM, Ilpo Järvinen wrote: > > On Fri, 22 Sep 2023, Shyam Sundar S K wrote: > > > >> PMF driver sends changing inputs from each subystem to TA for evaluating > >> the conditions in the policy binary. > >> > >> Add initial support of p

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their acces

[PATCH] drm/mediatek: Correctly free sg_table in gem prime vmap

2023-10-02 Thread Chen-Yu Tsai
The MediaTek DRM driver implements GEM PRIME vmap by fetching the sg_table for the object, iterating through the pages, and then vmapping them. In essence, unlike the GEM DMA helpers which vmap when the object is first created or imported, the MediaTek version does it on request. Unfortunately, th

Re: [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

2023-10-02 Thread Jani Nikula
On Wed, 16 Aug 2023, Pablo Ceballos wrote: > This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", > followed by link training errors. Intel engineers recommended increasing > this timeout and that does resolve the issue. > > On some CometLake-based device designs the Parade PS17

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 9/29/23 22:41, Hamza Mahfooz wrote: > From: Ivan Lipski > > This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. > > Since, it causes the following IGT tests to fail: > kms_cursor_legacy@cursor-vs-flip.* > kms_cursor_legacy@flip-vs-cursor.* Any information about how those tests fail

Re: [PATCH] drm/msm/a6xx: don't set IO_PGTABLE_QUIRK_ARM_OUTER_WBWA with coherent SMMU

2023-10-02 Thread Will Deacon
On Fri, Sep 29, 2023 at 06:25:21PM +0100, Robin Murphy wrote: > On 29/09/2023 4:45 pm, Will Deacon wrote: > > On Mon, Sep 25, 2023 at 06:54:42PM +0100, Robin Murphy wrote: > > > On 2023-04-10 19:52, Dmitry Baryshkov wrote: > > > > If the Adreno SMMU is dma-coherent, allocation will fail unless we >

Re: [PATCH v10 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-02 Thread AngeloGioacchino Del Regno
Il 02/10/23 09:14, Jason-JH Lin (林睿祥) ha scritto: Hi Angelo, Thanks for the reviews. On Thu, 2023-09-28 at 12:00 +0200, AngeloGioacchino Del Regno wrote: Il 27/09/23 17:38, Jason-JH.Lin ha scritto: Add dynamic select available connector flow in mtk_drm_crtc_create() and mtk_drm_crtc_atomic_en

RE: [PATCH v10 3/4] drm: renesas: Add RZ/G2L DU Support

2023-10-02 Thread Biju Das
Hi Jacopo, > Subject: Re: [PATCH v10 3/4] drm: renesas: Add RZ/G2L DU Support > > Hi Biju > > On Mon, Sep 18, 2023 at 08:09:58AM +, Biju Das wrote: > > Hi Jacopo Mondi, > > > > Looks like you are happy with my response for V10. I will send V11 soon. > > Sorry for the late reply.. > > See b

Re: [PATCH] drm/mediatek: Correctly free sg_table in gem prime vmap

2023-10-02 Thread AngeloGioacchino Del Regno
Il 02/10/23 11:20, Chen-Yu Tsai ha scritto: The MediaTek DRM driver implements GEM PRIME vmap by fetching the sg_table for the object, iterating through the pages, and then vmapping them. In essence, unlike the GEM DMA helpers which vmap when the object is first created or imported, the MediaTek

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Bagas Sanjaya
On Sun, Oct 01, 2023 at 06:32:34PM +0200, Oleksandr Natalenko wrote: > Hello. > > I've got a VM from a cloud provider, and since v6.5 I observe the following > kfence splat in dmesg during boot: > > ``` > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > Corrupted memory at 0x

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Bagas Sanjaya
On Mon, Oct 02, 2023 at 08:20:15AM +0200, Oleksandr Natalenko wrote: > Hello. > > On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > > On Sun, Oct 01, 2023 at 06:32:34PM +0200, Oleksandr Natalenko wrote: > > > Hello. > > > > > > I've got a VM from a cloud provider, and since v6.5 I obse

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 10/2/23 12:05, Michel Dänzer wrote: > On 9/29/23 22:41, Hamza Mahfooz wrote: >> From: Ivan Lipski >> >> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >> >> Since, it causes the following IGT tests to fail: >> kms_cursor_legacy@cursor-vs-flip.* >> kms_cursor_legacy@flip-vs-cursor

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

2023-10-02 Thread Sebastian Andrzej Siewior
On 2023-09-22 07:33:26 [+0200], Christian König wrote: > Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior: > > Hi, > > > > I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix > > is #4 + #5 and the rest was made while looking at the code. > > Oh, yes please :) > > Rodr

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
/cc Matthew, Andrew (please see below) On pondělí 2. října 2023 12:42:42 CEST Bagas Sanjaya wrote: > On Mon, Oct 02, 2023 at 08:20:15AM +0200, Oleksandr Natalenko wrote: > > Hello. > > > > On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > > > On Sun, Oct 01, 2023 at 06:32:34PM +0200, O

[PATCH v2 3/5] drm/etnaviv: Add helper functions to create and destroy platform device

2023-10-02 Thread Sui Jingfeng
The newly introduced functions are etnaviv_create_platform_device() and etnaviv_destroy_platform_device(). Those two function are pure function and can be shared for other use case. Currently, the benefit is that we no longer need to call of_node_put() for three different cases, we only need to cal

[PATCH v2 0/5] drm/etnaviv: Various cleanup

2023-10-02 Thread Sui Jingfeng
v2: * refine on v1 and update Sui Jingfeng (5): drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl() drm/etnaviv: Fix coding style drm/etnaviv: Add helper functions to create and destroy platform device drm/etnaviv: Add a helper to get the first available GPU dev

[PATCH v2 5/5] drm/etnaviv: Using 'dev' instead of 'etnaviv_obj->base.dev'

2023-10-02 Thread Sui Jingfeng
As in the etnaviv_gem_get_pages() function, the point to the drm_device has already been cached to the 'dev' local variable. We can use it directly, While at it, using 'unsigned int' type to count the number of pages. As the drm_prime_pages_to_sg() function takes an unsigned int type for its third

[PATCH v2 4/5] drm/etnaviv: Add a helper to get the first available GPU device node

2023-10-02 Thread Sui Jingfeng
This patch make the code in the etnaviv_pdev_probe() less twisted, and it also make it easier to drop the reference to device node after finished. Before apply this patch, there is no call to of_node_put() when done. We should call of_node_put() when done. Signed-off-by: Sui Jingfeng --- drivers

[PATCH v2 1/5] drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl()

2023-10-02 Thread Sui Jingfeng
The mentioned second parameter is the 'u32 size', but it is not get used by the etnaviv_gem_new_impl() function, so drop it. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH v2 2/5] drm/etnaviv: Fix coding style

2023-10-02 Thread Sui Jingfeng
1) Keep the curly brace aligned. 2) No indentation by double tabs where single tab indentation is enough. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c

Re: [PATCH] dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'

2023-10-02 Thread Conor Dooley
On Sat, Sep 30, 2023 at 10:01:02AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > fsl,imx6-hdmi.yaml makes a reference to synopsys,dw-hdmi.yaml. > > The 'interrupts'and 'reg' properties are described in synopsys,dw-hdmi.yaml, > so use 'unevaluatedProperties: false' so that these two prope

[PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro Carvalho Chehab Cc: Andi Shyti Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Nirmoy Das

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com > > Comments/feedback greatly appreciated Same problem on powerpc CI tests, all boot target failed, most of them with similar OOPS, see https://patchwork.ozlabs.org/pro

[PATCH v11 0/4] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-10-02 Thread Biju Das
This path series aims to add support for RZ/G2L DU DRM driver. RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from DS

[PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-10-02 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video timi

[PATCH v11 2/4] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-10-02 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- v10->v11: * No change. v9->v10: * No chan

[PATCH v11 3/4] drm: renesas: Add RZ/G2L DU Support

2023-10-02 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU mo

[PATCH v11 4/4] MAINTAINERS: Add maintainer for RZ DU drivers

2023-10-02 Thread Biju Das
Add my self as maintainer for RZ DU drivers. While at it, update the entries for common parts, rcar-du and shmobile. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v10->v11: * No change. v9->v10: * No change. v8->v9: * Added Rb tag from Laurent. * Updated entries for common parts(

Re: [PATCH v2 0/5] drm: Reuse temporary memory for format conversion

2023-10-02 Thread Maxime Ripard
On Fri, Sep 29, 2023 at 04:58:30PM +0200, Thomas Zimmermann wrote: > Am 29.09.23 um 14:11 schrieb Maxime Ripard: > > On Wed, Sep 20, 2023 at 04:24:26PM +0200, Thomas Zimmermann wrote: > > > DRM's format-conversion helpers require temporary memory. Pass the > > > buffer from the caller and keep it a

Re: [PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-10-02 Thread Rob Herring
On Mon, 02 Oct 2023 13:27:37 +0100, Biju Das wrote: > The RZ/G2L LCD controller is composed of Frame Compression Processor > (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). > > The DU module supports the following hardware features > − Display Parallel Interface (DPI) and MIPI LIN

Re: [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Andi Shyti
Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: > Don't return early if one of the GT doesn't require > any flushing. > > Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") > Cc: Chris Wilson > Cc: Fei Yang > Cc: Mauro Carvalho Chehab > Cc: Andi Shyti > Cc

[PATCH v2 1/3] drm/nouveau: chan: use struct nvif_mclass

2023-10-02 Thread Danilo Krummrich
Use actual struct nvif_mclass instead of identical anonymous struct. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_chan.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c

[PATCH v2 2/3] drm/nouveau: chan: use channel class definitions

2023-10-02 Thread Danilo Krummrich
Use channel class definitions instead of magic numbers. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_chan.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c index df

[PATCH v2 3/3] drm/nouveau: exec: report max pushs through getparam

2023-10-02 Thread Danilo Krummrich
Report the maximum number of IBs that can be pushed with a single DRM_IOCTL_NOUVEAU_EXEC through DRM_IOCTL_NOUVEAU_GETPARAM. While the maximum number of IBs per ring might vary between chipsets, the kernel will make sure that userspace can only push a fraction of the maximum number of IBs per ring

Re: [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread David Ahern
On 10/2/23 2:55 AM, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory b

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 10/2/23 12:48, Michel Dänzer wrote: > On 10/2/23 12:05, Michel Dänzer wrote: >> On 9/29/23 22:41, Hamza Mahfooz wrote: >>> From: Ivan Lipski >>> >>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >>> >>> Since, it causes the following IGT tests to fail: >>> kms_cursor_legacy@curs

Re: [PATCH v2] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2023-10-02 Thread Thomas Hellström
On Mon, 2023-10-02 at 10:16 +0200, Thomas Hellström wrote: > Hi, Zack > > On 9/26/23 19:51, Zack Rusin wrote: > > From: Zack Rusin > > > > Some drivers require the mapped tt pages to be decrypted. In an > > ideal > > world this would have been handled by the dma layer, but the TTM > > page > > f

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Matthew Wilcox
On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > > > > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > > > > > > > > > Corrupted memory at 0xe173a294 [ ! ! ! ! ! ! ! ! ! ! ! ! ! ! > > > > > ! ! ] (in kfence-#108): > > > > > drm_gem_put_pages+0x

Re: [PATCH v2 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Steve Wahl
On Mon, Oct 02, 2023 at 10:55:28AM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel a

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Nirmoy Das
+dri-devel On 10/2/2023 4:07 PM, Jonathan Cavitt wrote: From: Chris Wilson With multi-GT devices, the object may have been bound on each GT and so we need to invalidate the TLBs across all GT before releasing the pages back to the system. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on

Re: [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Hi Andi, On 10/2/2023 3:45 PM, Andi Shyti wrote: Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro

Re: [PATCH] dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'

2023-10-02 Thread Rob Herring
On Sat, 30 Sep 2023 10:01:02 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > fsl,imx6-hdmi.yaml makes a reference to synopsys,dw-hdmi.yaml. > > The 'interrupts'and 'reg' properties are described in synopsys,dw-hdmi.yaml, > so use 'unevaluatedProperties: false' so that these two propertie

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Alex Deucher
On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute. F

Re: ti-sn65dsi86 linux driver using dsi clock source for pll

2023-10-02 Thread Doug Anderson
Hi, On Sat, Sep 30, 2023 at 4:41 AM Douglas Cooper wrote: > > Hi Doug > > That’s really good feedback. Thanks so much for taking the time to outline > that. I’ll keep investigating and dig into those areas you mentioned. > > I should have mentioned I’m also using the chip in conjunction with a f

DPMS problems with radeon card and dual monitor setup

2023-10-02 Thread Jeff Layton
I have been seeing problems when my displays go to sleep for a couple of releases now. I have a dual monitor setup and a single AMD RX 6600 card. When I leave for a bit and come back, often all of my windows have been shuffled to the secondary monitor, and sometimes GNOME designates that monitor as

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
On pondělí 2. října 2023 16:32:45 CEST Matthew Wilcox wrote: > On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > > > > > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > > > > > > > > > > > Corrupted memory at 0xe173a294 [ ! ! ! ! ! ! ! ! ! ! ! ! !

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-02 Thread kernel test robot
: a4ead6e37e3290cff399e2598d75e98777b69b37 patch link: https://lore.kernel.org/r/20230928191624.13703-5-dakr%40redhat.com patch subject: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects reproduce: (https://download.01.org/0day-ci/archive/20231002/202310022331.lpoa8krt

Re: [PATCH] dma-buf: add dma_fence_timestamp helper

2023-10-02 Thread Alex Deucher
On Sat, Sep 30, 2023 at 7:06 PM Christian König wrote: > > When a fence signals there is a very small race window where the timestamp > isn't updated yet. sync_file solves this by busy waiting for the > timestamp to appear, but on other ocassions didn't handled this > correctly. > > Provide a dma_

[PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

2023-10-02 Thread Rob Clark
From: Rob Clark Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm driver to not probe on devices that use panel-edp. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/arm.config | 1 + drivers/gpu/drm/ci/arm64.config | 1 + 2 files changed, 2 insertions(+) diff --git a/dr

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > On Mon, Oct 2, 2023 at 5:20 AM Christian König > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > > >> This is a batch of patches touching drm for preparing for the co

Re: [PATCH] dma-buf: heaps: Fix off by one in cma_heap_vm_fault()

2023-10-02 Thread T.J. Mercier
On Mon, Oct 2, 2023 at 12:04 AM Dan Carpenter wrote: > > The buffer->pages[] has "buffer->pagecount" elements so this > comparison > has to be changed to >= to avoid reading beyond the end of the array. > The buffer->pages[] array is allocated in cma_heap_allocate(). > > Fixes: a5d2d29e24be ("dma-

Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

2023-10-02 Thread Helen Koike
On 02/10/2023 13:47, Rob Clark wrote: From: Rob Clark Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm driver to not probe on devices that use panel-edp. Signed-off-by: Rob Clark Thank you a lot! Now sc7180, apq8096 and sdm845 are probing! Tested-by: Helen Koike

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm for

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > Am 02.10.23 um 18:53 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > > > On Mon, Oct 2, 2023 at 5:20 AM Christian König > > > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > > > O

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 20:08 schrieb Kees Cook: On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb Ke

  1   2   >