Re: [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Andi Shyti
Hi Nirmoy, On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote: > On MTL GEN12_RING_FAULT_REG is not replicated so don't > do mcr based operation for this register. > > v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). > > Signed-off-by: Nirmoy Das This looks very good! > - if (

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-27 Thread 何宗原
On Fri, 2023-09-22 at 16:51 +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 04:49:14PM +0100, Conor Dooley wrote: > > On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > > > Add a compatible string for the COLOR block in MediaTek MT8195 > > > that > > > is controlled by MDP3. > > > >

[PATCH] accel/habanalabs: add missing debugfs function stubs

2023-09-27 Thread Arnd Bergmann
From: Arnd Bergmann Two function stubs were removed in an earlier commit but are now needed again: drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you

Re: [PATCH drm-misc-next 1/3] drm/sched: implement dynamic job flow control

2023-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2023 02:13:59 +0200 Danilo Krummrich wrote: > On 9/26/23 22:43, Luben Tuikov wrote: > > Hi, > > > > On 2023-09-24 18:43, Danilo Krummrich wrote: > >> Currently, job flow control is implemented simply by limiting the amount > >> of jobs in flight. Therefore, a scheduler is initia

Re: [PATCH v4 00/10] DRM scheduler changes for Xe

2023-09-27 Thread Boris Brezillon
On Mon, 18 Sep 2023 22:01:45 -0700 Matthew Brost wrote: > As a prerequisite to merging the new Intel Xe DRM driver [1] [2], we > have been asked to merge our common DRM scheduler patches first. > > This a continuation of a RFC [3] with all comments addressed, ready for > a full review, and hopef

[PATCH 01/46] fbdev: Provide I/O-memory helpers as module

2023-09-27 Thread Thomas Zimmermann
Provide helpers for accessing I/O memory in a helper module. The fbdev core uses these helpers, so select the module unconditionally for fbdev. Drivers will later be able to select the module individually and the helpers will become optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fb

[PATCH 06/46] fbdev/atafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 05/46] fbdev/arkfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 14/46] fbdev/ep93xx-fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 09/46] fbdev/cirrusfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 13/46] fbdev/dnfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 11/46] fbdev/controlfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 18/46] fbdev/hpfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 12/46] fbdev/cyber2000fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 21/46] fbdev/intelfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 16/46] fbdev/hgafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 17/46] fbdev/hitfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 10/46] fbdev/cobalt-lcd: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 31/46] fbdev/s1d13xxxfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 46/46] fbdev/vt8623fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 20/46] fbdev/imsttfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 24/46] fbdev/nvidiafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 34/46] fbdev/savagefb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 29/46] fbdev/radeon: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 19/46] fbdev/i810fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 30/46] fbdev/rivafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 27/46] fbdev/pm3fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 45/46] fbdev/viafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 37/46] fbdev/sm712fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 32/46] fbdev/s3fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 38/46] fbdev/stifb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 44/46] fbdev/vga16fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 36/46] fbdev/sm501fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize each instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on th

[PATCH 25/46] fbdev/omapfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 02/46] fbdev/68328fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory

2023-09-27 Thread Thomas Zimmermann
Initialize struct fb_ops for drivers for hardware with framebuffers in I/O-memory ranges with the respective helper macros. Also select the appropriate Kconfig dependencies. The patchset is part of a larger effort to modularize the fbdev core and make it more adaptable. Most of these drivers do no

[PATCH 35/46] fbdev/sisfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 22/46] fbdev/matroxfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize each instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on th

[PATCH 41/46] fbdev/tgafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 39/46] fbdev/sunxvr500: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 40/46] fbdev/tdfxfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 04/46] fbdev/amifb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 42/46] fbdev/tridentfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 26/46] fbdev/pm2fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 08/46] fbdev/au1100fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 23/46] fbdev/neofb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 43/46] fbdev/vermilionfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 07/46] fbdev/atyfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 03/46] fbdev/amba-clcd: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 15/46] fbdev/gbefb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 28/46] fbdev/pvr2fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH 33/46] fbdev/sa1100fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-09-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the

Re: [PATCH] drm/atomic: Perform blocking commits on workqueue

2023-09-27 Thread Christian König
Am 26.09.23 um 19:05 schrieb Ray Strode: From: Ray Strode A drm atomic commit can be quite slow on some hardware. It can lead to a lengthy queue of commands that need to get processed and waited on before control can go back to user space. If user space is a real-time thread, that delay can ha

Re: [PATCH 6/6] drm/i915: Implement fdinfo memory stats printing

2023-09-27 Thread kernel test robot
://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230922134700.235039-7-tvrtko.ursulin%40linux.intel.com patch subject: [PATCH 6/6] drm/i915: Implement fdinfo memory stats printing config: i386-randconfig-062-20230927 (https://download.01.org/0day-ci/archive/20230927/202309271528

Re: [Patch v1] drm/i915: Add uAPI to query micro-controller FW version

2023-09-27 Thread Jani Nikula
On Tue, 26 Sep 2023, "Balasubrawmanian, Vivaik" wrote: > Due to a bug in GuC firmware, Mesa can't enable by default the usage of > compute engines in DG2 and newer. > > > A new GuC firmware fixed the issue but until now there was no way > > for Mesa to know if KMD was running with the fixed GuC

[PATCH v3] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Nirmoy Das
On MTL GEN12_RING_FAULT_REG is not replicated so don't do mcr based operation for this register. v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). v3: s/"MEDIA_VER(i915) == 13"/"MEDIA_VER(i915) >= 13"(Matt) improve comment. Signed-off-by: Nirmoy Das Reviewed-by: Matt Roper --- drivers/g

Re: [PATCH v6 09/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

2023-09-27 Thread 何宗原
On Mon, 2023-09-25 at 11:09 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Fri, Sep 22, 2023 at 03:21:09PM +0800, Moudy Ho wrote: > > Add the fundamental hardware configuration of compon

Re: [PATCH v3] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Andi Shyti
Hi Nirmoy, On Wed, Sep 27, 2023 at 10:24:30AM +0200, Nirmoy Das wrote: > On MTL GEN12_RING_FAULT_REG is not replicated so don't > do mcr based operation for this register. > > v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). > v3: s/"MEDIA_VER(i915) == 13"/"MEDIA_VER(i915) >= 13"(Matt) >

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Andrzej Hajda
On 27.09.2023 10:24, Nirmoy Das wrote: On MTL GEN12_RING_FAULT_REG is not replicated so don't do mcr based operation for this register. v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). v3: s/"MEDIA_VER(i915) == 13"/"MEDIA_VER(i915) >= 13"(Matt) improve comment. Signed-off-by: Nirmoy Da

Re: [RFC PATCH] drm/ci: add helper script update-xfails.py

2023-09-27 Thread Sergi Blanch Torne
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Helen, On Mon, 2023-09-25 at 16:55 -0300, Helen Koike wrote: > Hello, > > This script is being very handy for me, so I suppose it could be > handy > to others, since I'm publishing it in the xfails folder. > > Let me know your thoughts. I have

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-09-27 Thread Tvrtko Ursulin
On 26/09/2023 20:05, Alan Previn wrote: When suspending, add a timeout when calling intel_gt_pm_wait_for_idle else if we have a lost G2H event that holds a wakeref (which would be indicative of a bug elsewhere in the driver), driver will at least complete the suspend-resume cycle, (albeit not h

Re: [Intel-gfx] [Patch v1] drm/i915: Add uAPI to query micro-controller FW version

2023-09-27 Thread Tvrtko Ursulin
On 27/09/2023 05:14, Balasubrawmanian, Vivaik wrote: Due to a bug in GuC firmware, Mesa can't enable by default the usage of compute engines in DG2 and newer. A new GuC firmware fixed the issue but until now there was no way for Mesa to know if KMD was running with the fixed GuC version or

[PATCH v6 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP

2023-09-27 Thread Manikandan Muralidharan
Add is_xlcdc flag and LCD IP specific ops in driver data to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 68 1 file changed, 68 insertions(+) diff --git a/dr

[PATCH v6 3/7] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

2023-09-27 Thread Manikandan Muralidharan
From: Durai Manickam KR The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC. Defining those address space with valid macros. Signed-off-by: Durai Manickam KR [manikanda...@microchip.com: Remove unused macro definitions] Signed-off-by: Manikandan

[PATCH v6 5/7] drm: atmel-hlcdc: add DPI mode support for XLCDC

2023-09-27 Thread Manikandan Muralidharan
Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping. DPI mode BIT is configured in LCDC_CFG5 register. Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update DPI mode bit using is_xlcdc fl

[PATCH v6 0/7] Add support for XLCDC to sam9x7 SoC family.

2023-09-27 Thread Manikandan Muralidharan
This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The new compatible string "microchip,sam9x75-xlcdc" is defined for sam9x75 variant of the sam9

[PATCH v6 6/7] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

2023-09-27 Thread Manikandan Muralidharan
Update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2

[PATCH v6 4/7] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-09-27 Thread Manikandan Muralidharan
XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag and with HLCDC and XLCDC IP specific ops. HEO scaling, window resampling, Alpha blendin

[PATCH v6 2/7] drm: atmel-hlcdc: add LCD controller layer definition for sam9x75

2023-09-27 Thread Manikandan Muralidharan
Add the LCD controller layer definition and descriptor structure for sam9x75 for the following layers: - Base Layer - Overlay1 Layer - Overlay2 Layer - High End Overlay Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 97 1 file chang

[PATCH v6 7/7] drm: atmel-hlcdc: add support for DSI output formats

2023-09-27 Thread Manikandan Muralidharan
Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet: - 16BPPCFG1 - 16BPPCFG2 - 16BPPCFG3 - 18BPPCFG1 - 18BPPCFG2 - 24BPP Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update output format using is_xlcdc flag] Signed-off-by: Dur

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-27 Thread Conor Dooley
On Wed, Sep 27, 2023 at 07:19:28AM +, Moudy Ho (何宗原) wrote: > On Fri, 2023-09-22 at 16:51 +0100, Conor Dooley wrote: > > On Fri, Sep 22, 2023 at 04:49:14PM +0100, Conor Dooley wrote: > > > On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > > > > Add a compatible string for the COLOR bl

Re: [PATCH v2] drm/mediatek: dsi: Add mode_valid callback to DSI bridge

2023-09-27 Thread 胡俊光

[PULL] drm-misc-next

2023-09-27 Thread Maarten Lankhorst
drm-misc-next-2023-09-27: drm-misc-next for v6.7-rc1: UAPI Changes: - drm_file owner is now updated during use, in the case of a drm fd opened by the display server for a client, the correct owner is displayed. - Qaic gains support for the QAIC_DETACH_SLICE_BO ioctl to allow bo recycling.

Re: [RESEND PATCH v6 11/20] drm/mediatek: Rename OVL_ADAPTOR_TYPE_RDMA

2023-09-27 Thread 胡俊光

[PATCH 1/3] drm/i915: Introduce intel_gt_mcr_lock_reset()

2023-09-27 Thread Nirmoy Das
Implement intel_gt_mcr_lock_reset() to provide a mechanism for resetting the steer semaphore when absolutely necessary. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 29 ++ drivers/gpu/drm/i915/gt/intel_gt_mcr.h | 1 + 2 files changed, 30 inserti

[PATCH 2/3] drm/i915: Reset steer semaphore for media GT

2023-09-27 Thread Nirmoy Das
During resime, the steer semaphore on GT1 was observed to be held. The hardware team has confirmed the safety of clearing the steer semaphore during driver load/resume, as no lock acquisitions can occur in this process by other agents. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_

[PATCH v4 3/3] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Nirmoy Das
On MTL GEN12_RING_FAULT_REG is not replicated so don't do mcr based operation for this register. v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). v3: s/"MEDIA_VER(i915) == 13"/"MEDIA_VER(i915) >= 13"(Matt) improve comment. v4: improve the comment further(Andi) Signed-off-by: Nirmoy Das R

Re: [PATCH v2] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Nirmoy Das
On 9/27/2023 9:04 AM, Andi Shyti wrote: Hi Nirmoy, On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote: On MTL GEN12_RING_FAULT_REG is not replicated so don't do mcr based operation for this register. v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt). Signed-off-by: Nirmoy Das Th

[PATCH v5 0/7] drm/i915: Convert fbdev to DRM client

2023-09-27 Thread Thomas Zimmermann
Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. The patchset also enables unloading of driver modules with in-kernel DRM clients; a feature required by i915. As with the other drivers' fbdev emulation, fbdev in

[PATCH v5 2/7] drm/client: Do not acquire module reference

2023-09-27 Thread Thomas Zimmermann
Do not acquire a reference on the module that provides a client's callback functions in drm_client_init(). The additional reference prevents the user from unloading the callback functions' module and thus creating dangling pointers. This is only necessary if there is no direct dependency between t

[PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-09-27 Thread Thomas Zimmermann
Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to i915_fbdev_setup() after i915 has registered its DRM device. Just like similar code in other drivers, i915 fbdev emulation now acts as a regular DRM client.

[PATCH v5 1/7] drm/i915: Unregister in-kernel clients

2023-09-27 Thread Thomas Zimmermann
Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915 does not use this helper, it has to perform the call by itself. Note that there are currently no in-kernel clients in i915. The patch prepares the driver for

[PATCH v5 3/7] drm/client: Export drm_client_dev_unregister()

2023-09-27 Thread Thomas Zimmermann
Export drm_client_dev_unregister() for use by the i915 driver. The driver does not use drm_dev_unregister(), so it has to clean up the in-kernel DRM clients by itself. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 13 + 1 file changed, 13 insertions(+) diff --g

[PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-09-27 Thread Thomas Zimmermann
Initialize i915's fbdev client by giving an instance of struct drm_client_funcs to drm_client_init(). Also clean up with drm_client_release(). Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see drm_fb_helper_init()). No functional change yet; the c

[PATCH v5 4/7] drm/i915: Move fbdev functions

2023-09-27 Thread Thomas Zimmermann
Move functions within intel_fbdev.c to simplify later updates. Minor style fixes to make checkpatch happy, but no functional changes. v5: * style fixes (checkpatch) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 154 ++--- 1 file change

[PATCH v5 6/7] drm/i915: Implement fbdev client callbacks

2023-09-27 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

Re: [RESEND PATCH v6 13/20] drm/mediatek: Sort OVL adaptor components

2023-09-27 Thread 胡俊光

Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly

2023-09-27 Thread Jani Nikula
On Tue, 26 Sep 2023, Laurent Pinchart wrote: > Hi Jani, > > Thank you for the patch. > > On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote: >> Make drm_bridge_get_edid() the one place to call the hook. >> >> Cc: Andrzej Hajda >> Cc: Neil Armstrong >> Cc: Robert Foss >> Cc: Laurent Pi

Re: [RESEND PATCH v6 14/20] drm/mediatek: Add component ID to component match structure

2023-09-27 Thread 胡俊光

Re: [PATCH v2] drm/gma500: refactor deprecated strncpy

2023-09-27 Thread Patrik Jakobsson
On Tue, Sep 19, 2023 at 04:41:16AM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > Since `chan->base.name` is expected to be NUL-terminated, a suitable > replacement

Re: [PATCH v2] drm/i915: Do not disable preemption for resets

2023-09-27 Thread Tvrtko Ursulin
On 26/09/2023 11:26, Andi Shyti wrote: Hi Tvrtko, On Tue, Sep 26, 2023 at 11:08:55AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit ade8a0f59844 ("drm/i915: Make all GPU resets atomic") added a preempt disable section over the hardware reset callback to prepare the driver for bein

Re: [PATCH 1/2] accel/ivpu: Update debugfs to latest changes in DRM

2023-09-27 Thread Stanislaw Gruszka
On Thu, Sep 07, 2023 at 09:26:09AM +0200, Stanislaw Gruszka wrote: > Use new drm debugfs helpers. This is needed after changes from > commit 78346ebf9f94 ("drm/debugfs: drop debugfs_init() for the render > and accel node v2"). Applied to drm-misc-next Thanks Stanislaw

Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly

2023-09-27 Thread Laurent Pinchart
Hi Jani, On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote: > Make drm_bridge_get_edid() the one place to call the hook. > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Signed-off-by: Jani Nikula > >

Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly

2023-09-27 Thread Laurent Pinchart
On Wed, Sep 27, 2023 at 01:33:56PM +0300, Jani Nikula wrote: > On Tue, 26 Sep 2023, Laurent Pinchart wrote: > > On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote: > >> Make drm_bridge_get_edid() the one place to call the hook. > >> > >> Cc: Andrzej Hajda > >> Cc: Neil Armstrong > >> Cc

Re: [PATCH 2/3] drm/i915: Reset steer semaphore for media GT

2023-09-27 Thread Andi Shyti
Hi Nirmoy, On Wed, Sep 27, 2023 at 12:22:36PM +0200, Nirmoy Das wrote: > During resime, the steer semaphore on GT1 was observed to be held. The resime/resume/ > hardware team has confirmed the safety of clearing the steer semaphore > during driver load/resume, as no lock acquisitions can occur i

Re: [PATCH 1/3] drm/i915: Introduce intel_gt_mcr_lock_reset()

2023-09-27 Thread Andi Shyti
Hi Nirmoy, [...] > +void intel_gt_mcr_lock_reset(struct intel_gt *gt) > +{ > + unsigned long __flags; > + > + lockdep_assert_not_held(>->uncore->lock); > + > + spin_lock_irqsave(>->mcr_lock, __flags); > + > + if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 70)) > + intel

Re: [PATCH v4 3/3] drm/i915/mtl: Skip MCR ops for ring fault register

2023-09-27 Thread Andi Shyti
Hi Nirmoy, > + /* > + * For the media GT, this ring fault register is not replicated, > + * so don't do multicast/replicated register read/write operation on it. > + */ thanks! Andi

Re: [PATCH v2] drm/simpledrm: Add support for multiple "power-domains"

2023-09-27 Thread Ulf Hansson
On Tue, 26 Sept 2023 at 09:32, Geert Uytterhoeven wrote: > > CC genpd > > On Mon, Sep 18, 2023 at 10:24 AM Thomas Zimmermann > wrote: > > Am 12.09.23 um 22:22 schrieb Janne Grunau via B4 Relay: > > > From: Janne Grunau > > > > > > Multiple power domains need to be handled explicitly in each dri

Re: [PATCH drm-misc-next 1/3] drm/sched: implement dynamic job flow control

2023-09-27 Thread Danilo Krummrich
On 9/27/23 09:25, Boris Brezillon wrote: On Wed, 27 Sep 2023 02:13:59 +0200 Danilo Krummrich wrote: On 9/26/23 22:43, Luben Tuikov wrote: Hi, On 2023-09-24 18:43, Danilo Krummrich wrote: Currently, job flow control is implemented simply by limiting the amount of jobs in flight. Therefore, a

Re: [PATCH drm-misc-next 1/3] drm/sched: implement dynamic job flow control

2023-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2023 13:45:37 +0200 Danilo Krummrich wrote: > On 9/27/23 09:25, Boris Brezillon wrote: > > On Wed, 27 Sep 2023 02:13:59 +0200 > > Danilo Krummrich wrote: > > > >> On 9/26/23 22:43, Luben Tuikov wrote: > >>> Hi, > >>> > >>> On 2023-09-24 18:43, Danilo Krummrich wrote: >

  1   2   3   >